DO NOT REPLY [Bug 47907] Improvements for Comparison Assertion and Comparison Visualizer

2009-09-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47907

--- Comment #4 from Milamber  2009-09-26 14:10:10 PDT 
---
Created an attachment (id=24318)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=24318)
JMeter script testcases

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: jmeter-dev-unsubscr...@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-h...@jakarta.apache.org



DO NOT REPLY [Bug 47907] Improvements for Comparison Assertion and Comparison Visualizer

2009-09-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47907

--- Comment #3 from Milamber  2009-09-26 14:09:13 PDT 
---
Created an attachment (id=24317)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=24317)
Sample screenshot with improvement

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: jmeter-dev-unsubscr...@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-h...@jakarta.apache.org



DO NOT REPLY [Bug 47907] Improvements for Comparison Assertion and Comparison Visualizer

2009-09-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47907

--- Comment #2 from Milamber  2009-09-26 14:05:25 PDT 
---
Created an attachment (id=24316)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=24316)
Proposal improvements patch with detab

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: jmeter-dev-unsubscr...@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-h...@jakarta.apache.org



DO NOT REPLY [Bug 47907] Improvements for Comparison Assertion and Comparison Visualizer

2009-09-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47907

Milamber  changed:

   What|Removed |Added

 CC||milambersp...@gmail.com

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: jmeter-dev-unsubscr...@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-h...@jakarta.apache.org



DO NOT REPLY [Bug 47907] Improvements for Comparison Assertion and Comparison Visualizer

2009-09-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47907

--- Comment #1 from Milamber  2009-09-26 14:04:32 PDT 
---
Created an attachment (id=24315)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=24315)
Proposal improvements patch

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: jmeter-dev-unsubscr...@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-h...@jakarta.apache.org



DO NOT REPLY [Bug 47907] New: Improvements for Comparison Assertion and Comparison Visualizer

2009-09-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47907

   Summary: Improvements for Comparison Assertion and Comparison
Visualizer
   Product: JMeter
   Version: Nightly (Please specify date)
  Platform: PC
OS/Version: All
Status: NEW
  Severity: enhancement
  Priority: P2
 Component: Main
AssignedTo: jmeter-dev@jakarta.apache.org
ReportedBy: milambersp...@gmail.com


* now, in a loop or a controller with more than two samplers, "Comparison
Assertion" compare the first to the current (before, always the first and the
second for all samplers in a controller)

* Comparison Visualizer display a success icon on success and a error icon on
failure

* Comparison Visualizer is more verbose on success and failure 

* Comparison Visualizer show the left pane (the first sample to compare) in
light grey (better visual effect). And panes are not editable now.

* in manual, add "response time" instead of "time" to more precision on
comparison. (perhaps change field name?)

I provided two patches: one without detab (best view changes) and one with
detab in accord with code style JMeter.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: jmeter-dev-unsubscr...@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-h...@jakarta.apache.org



Re: svn commit: r807418 - in /jakarta/jmeter/trunk: src/core/org/apache/jmeter/resources/ src/protocol/http/org/apache/jmeter/protocol/http/config/gui/ src/protocol/http/org/apache/jmeter/protocol/h

2009-09-26 Thread Milamber

Hello,

Le 26/09/2009 14:18, sebb a ecrit :

On 26/09/2009, Milamber  wrote:
  

Hello,

 In attachment,



Thanks!

May I request that patches are provided via Buzilla in future?
It's a lot easier to keep track of them that way.
  

Sorry, I will do this next time.

The dev or user list are good for discussion of any proposals, but
patches are best done via Bugzilla.

  

a proposal patch to change position of new "Proxy Server"
panel to the end of page. More user-friendly (I think)
 (see screenshots)



Not 100% sure about that, will need to consider further.
  

I think this visual order is better :
1/ Label&comment
2/ Webserver
3/ HTTP Request
4/ Request via Proxy Server
5/ Optional tasks

than :
1/ Label&comment
2/ Webserver
3/ Request via Proxy Server
4/ HTTP Request
5/ Optional tasks

Because, we are in a sampler HTTP Request, and I think is better to have 
panel "HTTP Request" first.


"Request via Proxy Server" is optional and HTTP Request panel is 
(always) required.


I think too, the proposal's order is more better for beginner.

In all case, this new functionality is nice :-)


Milamber
  

 And change the proxy server title panel from "Proxy Server" to "Request via
Proxy Server"



Yes, I agree.

  

 Milamber

 Le 24/08/2009 22:38, s...@apache.org a ecrit :





  




Re: svn commit: r807418 - in /jakarta/jmeter/trunk: src/core/org/apache/jmeter/resources/ src/protocol/http/org/apache/jmeter/protocol/http/config/gui/ src/protocol/http/org/apache/jmeter/protocol/h

2009-09-26 Thread sebb
On 26/09/2009, Milamber  wrote:
> Hello,
>
>  Le 26/09/2009 14:18, sebb a ecrit :
>
> > On 26/09/2009, Milamber  wrote:
> >
> >
> > > Hello,
> > >
> > >  In attachment,
> > >
> > >
> >
> > Thanks!
> >
> > May I request that patches are provided via Buzilla in future?
> > It's a lot easier to keep track of them that way.
> >
> >
>  Sorry, I will do this next time.

Thanks!
[No need to apologise.]

>
> > The dev or user list are good for discussion of any proposals, but
> > patches are best done via Bugzilla.
> >
> >
> >
> > > a proposal patch to change position of new "Proxy Server"
> > > panel to the end of page. More user-friendly (I think)
> > >  (see screenshots)
> > >
> > >
> >
> > Not 100% sure about that, will need to consider further.
> >
> >
>  I think this visual order is better :
>  1/ Label&comment
>  2/ Webserver
>  3/ HTTP Request
>  4/ Request via Proxy Server
>  5/ Optional tasks
>
>  than :
>  1/ Label&comment
>  2/ Webserver
>  3/ Request via Proxy Server
>  4/ HTTP Request
>  5/ Optional tasks
>
>  Because, we are in a sampler HTTP Request, and I think is better to have
> panel "HTTP Request" first.
>
>  "Request via Proxy Server" is optional and HTTP Request panel is (always)
> required.
>
>  I think too, the proposal's order is more better for beginner.

I put it with the Webserver because that's the way I think of it - as
a pre-requisite for requesting the URL.

However, I can see why it might be better at the bottom with other
optional items.
I'll consider it some more.

-
To unsubscribe, e-mail: jmeter-dev-unsubscr...@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-h...@jakarta.apache.org



Re: svn commit: r807418 - in /jakarta/jmeter/trunk: src/core/org/apache/jmeter/resources/ src/protocol/http/org/apache/jmeter/protocol/http/config/gui/ src/protocol/http/org/apache/jmeter/protocol/h

2009-09-26 Thread sebb
On 26/09/2009, Milamber  wrote:
> Hello,
>
>  In attachment,

Thanks!

May I request that patches are provided via Buzilla in future?
It's a lot easier to keep track of them that way.

The dev or user list are good for discussion of any proposals, but
patches are best done via Bugzilla.

> a proposal patch to change position of new "Proxy Server"
> panel to the end of page. More user-friendly (I think)
>  (see screenshots)

Not 100% sure about that, will need to consider further.

>  And change the proxy server title panel from "Proxy Server" to "Request via
> Proxy Server"

Yes, I agree.

>  Milamber
>
>  Le 24/08/2009 22:38, s...@apache.org a ecrit :
>
>

-
To unsubscribe, e-mail: jmeter-dev-unsubscr...@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-h...@jakarta.apache.org