svn commit: r910379 - /jakarta/jmeter/trunk/build.properties

2010-02-15 Thread sebb
Author: sebb
Date: Tue Feb 16 02:18:35 2010
New Revision: 910379

URL: http://svn.apache.org/viewvc?rev=910379&view=rev
Log:
More recent versions of Geronimo spec jars

Modified:
jakarta/jmeter/trunk/build.properties

Modified: jakarta/jmeter/trunk/build.properties
URL: 
http://svn.apache.org/viewvc/jakarta/jmeter/trunk/build.properties?rev=910379&r1=910378&r2=910379&view=diff
==
--- jakarta/jmeter/trunk/build.properties (original)
+++ jakarta/jmeter/trunk/build.properties Tue Feb 16 02:18:35 2010
@@ -184,19 +184,17 @@
 xmlgraphics-commons.md5 = E63589601D939739349A50A029DAB120
 
 # Geronimo API jars (compile-time only)
-activation.jar  = geronimo-activation_1.0.2_spec-1.1.jar
-activation.loc  = 
http://mirrors.ibiblio.org/pub/mirrors/maven/org.apache.geronimo.specs/jars
-# diff
-activation.md5  = 6a3a594753a07b325f21d32c452c3779
+activation.jar  = geronimo-activation_1.1_spec-1.0.2.jar
+activation.loc  = 
http://repo2.maven.org/maven2/org/apache/geronimo/specs/geronimo-activation_1.1_spec/1.0.2/
+activation.md5  = 9759ed85c6e767bf3dc00c4cf635c4e2
 
-javamail.jar= geronimo-javamail_1.3.1_spec-1.1.jar
-javamail.loc= 
http://mirrors.ibiblio.org/pub/mirrors/maven/org.apache.geronimo.specs/jars
-# diff 
-javamail.md5= 529c667a51cc4febdff3caeda4675cb4
+javamail.jar= geronimo-javamail_1.4_spec-1.6.jar
+javamail.loc= 
http://repo2.maven.org/maven2/org/apache/geronimo/specs/geronimo-javamail_1.4_spec/1.6/
+javamail.md5= 2bcb3208c8e0c8e9713d8222abb33788
 
-jms.jar = geronimo-jms_1.1_spec-1.0.jar
-jms.loc = 
http://mirrors.ibiblio.org/pub/mirrors/maven/org.apache.geronimo.specs/jars
-jms.md5 = 3A10BDB4AB6455AB16E4FC543BBD6B89
+jms.jar = geronimo-jms_1.1_spec-1.1.1.jar
+jms.loc = 
http://repo2.maven.org/maven2/org/apache/geronimo/specs/geronimo-jms_1.1_spec/1.1.1/
+jms.md5 = d80ce71285696d36c1add1989b94f084
 
 # The following jars are only needed for source distributions
 # They are used for building the documentation



-
To unsubscribe, e-mail: jmeter-dev-unsubscr...@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-h...@jakarta.apache.org



svn commit: r910377 - /jakarta/jmeter/trunk/lib/api/

2010-02-15 Thread sebb
Author: sebb
Date: Tue Feb 16 02:02:41 2010
New Revision: 910377

URL: http://svn.apache.org/viewvc?rev=910377&view=rev
Log:
Allow any versions of geronimo spec jars

Modified:
jakarta/jmeter/trunk/lib/api/   (props changed)

Propchange: jakarta/jmeter/trunk/lib/api/
--
--- svn:ignore (original)
+++ svn:ignore Tue Feb 16 02:02:41 2010
@@ -1,4 +1,4 @@
-geronimo-activation_1.0.2_spec-1.1.jar
-geronimo-jms_1.1_spec-1.0.jar
-geronimo-javamail_1.3.1_spec-1.1.jar
+geronimo-activation_*_spec-*.jar
+geronimo-jms_*_spec-*.jar
+geronimo-javamail_*_spec-*.jar
 bsf-api-*.jar



-
To unsubscribe, e-mail: jmeter-dev-unsubscr...@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-h...@jakarta.apache.org



svn commit: r910224 - /jakarta/jmeter/trunk/src/components/org/apache/jmeter/visualizers/RenderAsXML.java

2010-02-15 Thread sebb
Author: sebb
Date: Mon Feb 15 14:24:25 2010
New Revision: 910224

URL: http://svn.apache.org/viewvc?rev=910224&view=rev
Log:
Remove dependency on default encoding

Modified:

jakarta/jmeter/trunk/src/components/org/apache/jmeter/visualizers/RenderAsXML.java

Modified: 
jakarta/jmeter/trunk/src/components/org/apache/jmeter/visualizers/RenderAsXML.java
URL: 
http://svn.apache.org/viewvc/jakarta/jmeter/trunk/src/components/org/apache/jmeter/visualizers/RenderAsXML.java?rev=910224&r1=910223&r2=910224&view=diff
==
--- 
jakarta/jmeter/trunk/src/components/org/apache/jmeter/visualizers/RenderAsXML.java
 (original)
+++ 
jakarta/jmeter/trunk/src/components/org/apache/jmeter/visualizers/RenderAsXML.java
 Mon Feb 15 14:24:25 2010
@@ -49,7 +49,7 @@
 
 private static final Logger log = LoggingManager.getLoggerForClass();
 
-private static final byte[] XML_PFX = "

svn commit: r910218 - /jakarta/jmeter/trunk/src/core/org/apache/jmeter/samplers/SampleResult.java

2010-02-15 Thread sebb
Author: sebb
Date: Mon Feb 15 13:55:44 2010
New Revision: 910218

URL: http://svn.apache.org/viewvc?rev=910218&view=rev
Log:
Extract static constant

Modified:
jakarta/jmeter/trunk/src/core/org/apache/jmeter/samplers/SampleResult.java

Modified: 
jakarta/jmeter/trunk/src/core/org/apache/jmeter/samplers/SampleResult.java
URL: 
http://svn.apache.org/viewvc/jakarta/jmeter/trunk/src/core/org/apache/jmeter/samplers/SampleResult.java?rev=910218&r1=910217&r2=910218&view=diff
==
--- jakarta/jmeter/trunk/src/core/org/apache/jmeter/samplers/SampleResult.java 
(original)
+++ jakarta/jmeter/trunk/src/core/org/apache/jmeter/samplers/SampleResult.java 
Mon Feb 15 13:55:44 2010
@@ -68,6 +68,9 @@
 = JMeterUtils.getPropDefault("sampleresult.default.encoding", // 
$NON-NLS-1$
 DEFAULT_HTTP_ENCODING);
 
+/* The default used by {...@link #setResponseData(String, String)} */
+private static final String DEFAULT_CHARSET = 
Charset.defaultCharset().name();
+
 /**
  * Data type value indicating that the response data is text.
  *
@@ -529,16 +532,15 @@
  *
  */
 public void setResponseData(final String response, final String encoding) {
-String defaultEncodingName = Charset.defaultCharset().name();
-String encodeUsing = encoding != null? encoding : defaultEncodingName; 
+String encodeUsing = encoding != null? encoding : DEFAULT_CHARSET; 
 try {
 responseData = response.getBytes(encodeUsing);
 setDataEncoding(encodeUsing);
 } catch (UnsupportedEncodingException e) {
 log.warn("Could not convert string using "+encodeUsing+
-", using default encoding: "+defaultEncodingName+" 
"+e.getLocalizedMessage());
+", using default encoding: "+DEFAULT_CHARSET+" 
"+e.getLocalizedMessage());
 responseData = response.getBytes();
-setDataEncoding(defaultEncodingName);
+setDataEncoding(DEFAULT_CHARSET);
 }
 }
 



-
To unsubscribe, e-mail: jmeter-dev-unsubscr...@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-h...@jakarta.apache.org



Re: Custom Thread Group

2010-02-15 Thread sebb
On 15/02/2010, Andrey Pohilko  wrote:
> It was easier than I expected - I managed to make Thread Groups a regular
>  plugin with ability to add my own and fully compatible with existing test
>  plans.
>
>  It is:
> 1. Extract abstract superclass AbstractThreadGroup and
>  AbstractThreadGroupGui.
> 2. Modify JMeterEngine and ThreadGroup to delegate thread scheduling
>  to ThreadGroup.
> 3. Add menu group "Threads" and place all thread groups under it.
>  Just like Listeners do via MenuFactory.
>
>  Then I'm able to add my custom thread groups and JMeter works perfectly. The
>  only visible problem I see is tree icon for custom thread groups - it is
>  default.
>
>  What'd ya say, sebb? What should I do next if I want this changes to be
>  committed?

Create a Bugzilla enhancement request and attach the code to it.

New files can be attached as is, but any patches should be in unified
diff format (e.g. as generated by Eclipse - but please use a Patch
Root of "Project", not "Workspace").

>
>  С уважением,
>  Андрей Похилько
>  -Original Message-
>
> From: Andrey Pohilko [mailto:a...@fininfor.ru]
>  Sent: Tuesday, February 09, 2010 12:34 PM
>  To: 'JMeter Developers List'
>
> Subject: RE: Custom Thread Group
>
>  Hello!
>
>  I mean that I can write custom Listener or Sampler, but can't write custom
>  Thread Group. Or I can but just don't know how?
>
>  С уважением,
>  Андрей Похилько
>  -Original Message-
>  From: sebb [mailto:seb...@gmail.com]
>  Sent: Tuesday, February 09, 2010 3:14 AM
>  To: JMeter Developers List
>  Subject: Re: Custom Thread Group
>
>  On 03/02/2010, Andrey Pohilko  wrote:
>  > Hello!
>  >
>  >
>  >
>  >  I'm maintaner of jmeter-plugins project at Google Code and love writing
>  >  JMeter plugins very much along with using this plugins at my work for
>  >  complex load tests.
>  >
>  >  I'd like to write my own Thread Group plugin with custom threads
>  >  starting/stopping logic (step function like LoadRunner), but there's 2
>  >  problems:
>  >
>  >  1. Thread Groups does cannot be custom, there's fixed code for thread
>  >  groups
>  >
>  >  2. Start/end time logic placed in JMeterStandardEngine, not
>  ThreadGroup
>  >
>  >
>  >
>  >  I can modify JMeterStandardEngine and ThreadGroup code to use new
>  >  "Alternative Scheduling" option and send a patch to developers to include
>  in
>  >  Jmeter source code, but this is not so elegant way as regular jmeter
>  >  plugins. Actually, for now it's the only way for me and I almost
>  implemented
>  >  it. But it's ugly way to have an improvement which I cannot share.
>  >
>  >
>  >
>  >  I think the best way is make Thread Group regular plugin and delegate
>  thread
>  >  scheduling calculation logic to it, then anyone will be able to make any
>  >  thread scheduling logic without impact on jmeter source code.
>  >
>
>  Not sure I understand how you propose doing this.
>
>  Can you explain a bit more what you mean?
>
>  Note that any changes would need to be compatible with existing test plans.
>
>  >
>  >  What would you say?
>  >
>  >
>  >
>  >  Best wishes,
>  >
>  >
>  >  Andrey Pohilko
>  >
>  >
>
>  -
>  To unsubscribe, e-mail: jmeter-dev-unsubscr...@jakarta.apache.org
>  For additional commands, e-mail: jmeter-dev-h...@jakarta.apache.org
>
>
>
>  -
>  To unsubscribe, e-mail: jmeter-dev-unsubscr...@jakarta.apache.org
>  For additional commands, e-mail: jmeter-dev-h...@jakarta.apache.org
>
>
>
>  -
>  To unsubscribe, e-mail: jmeter-dev-unsubscr...@jakarta.apache.org
>  For additional commands, e-mail: jmeter-dev-h...@jakarta.apache.org
>
>

-
To unsubscribe, e-mail: jmeter-dev-unsubscr...@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-h...@jakarta.apache.org



DO NOT REPLY [Bug 48728] HTTPS SOAP requests unable to open connection

2010-02-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48728

Sebb  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: jmeter-dev-unsubscr...@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-h...@jakarta.apache.org



DO NOT REPLY [Bug 48650] No response is visible

2010-02-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48650

Sebb  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID

--- Comment #17 from Sebb  2010-02-15 13:13:54 UTC ---
I repeat: the "Sampler result" tab has important information on it that is
needed to debug the issue.

If you cannot provide this information then there's not much anyone can do to
help.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: jmeter-dev-unsubscr...@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-h...@jakarta.apache.org



DO NOT REPLY [Bug 48728] HTTPS SOAP requests unable to open connection

2010-02-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48728

--- Comment #2 from Stealth_Man  
2010-02-15 12:56:26 UTC ---
Thanks Sebb, XML-RPC SOAP works now.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: jmeter-dev-unsubscr...@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-h...@jakarta.apache.org



DO NOT REPLY [Bug 48650] No response is visible

2010-02-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48650

--- Comment #16 from raghavendra  2010-02-15 
12:38:12 UTC ---
Hi sebb,

I am telling about the tabs that are at the bottom like render html,render
XML,Show text are disabled, not the tabs sample result,request,response etc...

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: jmeter-dev-unsubscr...@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-h...@jakarta.apache.org



DO NOT REPLY [Bug 48650] No response is visible

2010-02-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48650

--- Comment #15 from Sebb  2010-02-15 12:22:42 UTC ---
The "Sampler result" tab has important information on it that is needed to
debug the issue.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: jmeter-dev-unsubscr...@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-h...@jakarta.apache.org



DO NOT REPLY [Bug 48650] No response is visible

2010-02-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48650

raghavendra  changed:

   What|Removed |Added

 Status|NEEDINFO|NEW

--- Comment #14 from raghavendra  2010-02-15 
12:18:52 UTC ---
Hi Sebb,Leave about the tabs...

Why we  are unable to see the response for a request ,which we are able to do
from web browser

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: jmeter-dev-unsubscr...@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-h...@jakarta.apache.org



DO NOT REPLY [Bug 48650] No response is visible

2010-02-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48650

Sebb  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO

--- Comment #13 from Sebb  2010-02-15 12:08:28 UTC ---
The tabs are at the top of the page and are not disabled.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: jmeter-dev-unsubscr...@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-h...@jakarta.apache.org



DO NOT REPLY [Bug 48650] No response is visible

2010-02-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48650

raghavendra  changed:

   What|Removed |Added

 Status|NEEDINFO|NEW

--- Comment #12 from raghavendra  2010-02-15 
11:59:51 UTC ---
please see the attachments that i have sent to you where in response page the
tabs are disabled

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: jmeter-dev-unsubscr...@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-h...@jakarta.apache.org



DO NOT REPLY [Bug 48650] No response is visible

2010-02-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48650

Sebb  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO

--- Comment #11 from Sebb  2010-02-15 11:57:26 UTC ---
The tabs cannot be disabled, otherwise you would not be able to show the screen
shots from the "Request" and "Response data" tabs.

Please try again.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: jmeter-dev-unsubscr...@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-h...@jakarta.apache.org



DO NOT REPLY [Bug 48650] No response is visible

2010-02-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48650

raghavendra  changed:

   What|Removed |Added

 Status|NEEDINFO|NEW

--- Comment #10 from raghavendra  2010-02-15 
11:40:41 UTC ---
Hi sebb,This is showing empty response,and the Tabs at the border are disabled

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: jmeter-dev-unsubscr...@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-h...@jakarta.apache.org



DO NOT REPLY [Bug 48650] No response is visible

2010-02-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48650

Sebb  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO

--- Comment #9 from Sebb  2010-02-15 11:36:19 UTC ---
One last time:

What does the "Sampler response" tab show? This is the tab to the left of the
"Request" tab.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: jmeter-dev-unsubscr...@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-h...@jakarta.apache.org



RE: Custom Thread Group

2010-02-15 Thread Andrey Pohilko
It was easier than I expected - I managed to make Thread Groups a regular
plugin with ability to add my own and fully compatible with existing test
plans.

It is:
1. Extract abstract superclass AbstractThreadGroup and
AbstractThreadGroupGui.
2. Modify JMeterEngine and ThreadGroup to delegate thread scheduling
to ThreadGroup.
3. Add menu group "Threads" and place all thread groups under it.
Just like Listeners do via MenuFactory.

Then I'm able to add my custom thread groups and JMeter works perfectly. The
only visible problem I see is tree icon for custom thread groups - it is
default.

What'd ya say, sebb? What should I do next if I want this changes to be
committed?
 
С уважением,
Андрей Похилько
-Original Message-
From: Andrey Pohilko [mailto:a...@fininfor.ru] 
Sent: Tuesday, February 09, 2010 12:34 PM
To: 'JMeter Developers List'
Subject: RE: Custom Thread Group

Hello!

I mean that I can write custom Listener or Sampler, but can't write custom
Thread Group. Or I can but just don't know how?
 
С уважением,
Андрей Похилько
-Original Message-
From: sebb [mailto:seb...@gmail.com] 
Sent: Tuesday, February 09, 2010 3:14 AM
To: JMeter Developers List
Subject: Re: Custom Thread Group

On 03/02/2010, Andrey Pohilko  wrote:
> Hello!
>
>
>
>  I'm maintaner of jmeter-plugins project at Google Code and love writing
>  JMeter plugins very much along with using this plugins at my work for
>  complex load tests.
>
>  I'd like to write my own Thread Group plugin with custom threads
>  starting/stopping logic (step function like LoadRunner), but there's 2
>  problems:
>
>  1. Thread Groups does cannot be custom, there's fixed code for thread
>  groups
>
>  2. Start/end time logic placed in JMeterStandardEngine, not
ThreadGroup
>
>
>
>  I can modify JMeterStandardEngine and ThreadGroup code to use new
>  "Alternative Scheduling" option and send a patch to developers to include
in
>  Jmeter source code, but this is not so elegant way as regular jmeter
>  plugins. Actually, for now it's the only way for me and I almost
implemented
>  it. But it's ugly way to have an improvement which I cannot share.
>
>
>
>  I think the best way is make Thread Group regular plugin and delegate
thread
>  scheduling calculation logic to it, then anyone will be able to make any
>  thread scheduling logic without impact on jmeter source code.
>

Not sure I understand how you propose doing this.

Can you explain a bit more what you mean?

Note that any changes would need to be compatible with existing test plans.

>
>  What would you say?
>
>
>
>  Best wishes,
>
>
>  Andrey Pohilko
>
>

-
To unsubscribe, e-mail: jmeter-dev-unsubscr...@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-h...@jakarta.apache.org



-
To unsubscribe, e-mail: jmeter-dev-unsubscr...@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-h...@jakarta.apache.org



-
To unsubscribe, e-mail: jmeter-dev-unsubscr...@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-h...@jakarta.apache.org