Author: sebb Date: Tue Feb 9 17:50:00 2010 New Revision: 908128 URL: http://svn.apache.org/viewvc?rev=908128&view=rev Log: Thread-safety fixes
Modified: jakarta/jmeter/trunk/src/core/org/apache/jmeter/reporters/ResultCollector.java Modified: jakarta/jmeter/trunk/src/core/org/apache/jmeter/reporters/ResultCollector.java URL: http://svn.apache.org/viewvc/jakarta/jmeter/trunk/src/core/org/apache/jmeter/reporters/ResultCollector.java?rev=908128&r1=908127&r2=908128&view=diff ============================================================================== --- jakarta/jmeter/trunk/src/core/org/apache/jmeter/reporters/ResultCollector.java (original) +++ jakarta/jmeter/trunk/src/core/org/apache/jmeter/reporters/ResultCollector.java Tue Feb 9 17:50:00 2010 @@ -122,7 +122,7 @@ //@GuardedBy("LOCK") private static int instanceCount; // Keep track of how many instances are active - // Instance variables + // Instance variables (guarded by volatile) private transient volatile PrintWriter out; @@ -131,7 +131,7 @@ private volatile boolean isStats = false; /** the summarizer to which this result collector will forward the samples */ - private Summariser summariser; + private volatile Summariser summariser; /** * No-arg constructor. @@ -170,11 +170,11 @@ return getPropertyAsBoolean(ERROR_LOGGING); } - public void setErrorLogging(boolean errorLogging) { + public final void setErrorLogging(boolean errorLogging) { setProperty(new BooleanProperty(ERROR_LOGGING, errorLogging)); } - public void setSuccessOnlyLogging(boolean value) { + public final void setSuccessOnlyLogging(boolean value) { if (value) { setProperty(new BooleanProperty(SUCCESS_ONLY_LOGGING, true)); } else { @@ -248,7 +248,7 @@ } } - public synchronized void testStarted(String host) { + public void testStarted(String host) { synchronized(LOCK){ instanceCount++; try { --------------------------------------------------------------------- To unsubscribe, e-mail: jmeter-dev-unsubscr...@jakarta.apache.org For additional commands, e-mail: jmeter-dev-h...@jakarta.apache.org