Re: [josm-dev] Combine and Merge

2009-04-30 Thread Russ Nelson
Greg Troxel writes:
  I don't actually care which node controls the resulting location, but it
  seems obvious the first one added to the selection should be it.

Yup.  The nodes seem to get sorted numerically by id.  That's correct
for display purposes, but not for the purpose of choosing the code to
hold the location.  I'll take a look at it.

-- 
--my blog is athttp://blog.russnelson.com
Cloudmade supports http://openstreetmap.org/ 
521 Pleasant Valley Rd. | +1 315-323-1241
Potsdam, NY 13676-3213  | Sheepdog   

___
josm-dev mailing list
josm-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev


[josm-dev] Combine and Merge

2009-04-23 Thread Russ Nelson
Can we combine and merge Combine and Merge?

Combine: combines ways.
Merge: combines nodes.

If there's no objection, I'll write the patch.

-- 
--my blog is athttp://blog.russnelson.com
Cloudmade supports http://openstreetmap.org/ 
521 Pleasant Valley Rd. | +1 315-323-1241
Potsdam, NY 13676-3213  | Sheepdog   

___
josm-dev mailing list
josm-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev


Re: [josm-dev] Combine and Merge

2009-04-23 Thread Russ Nelson
Russ Nelson writes:
  Can we combine and merge Combine and Merge?

No, I suggest this instead:

Can we combine, join, and merge Combine, Join Node to Way, and Merge?

Combine Way(two or more ways) - combines ways.
Combine Way(two or more ways with any number of node selections) -
 combines ways, ignores node selection.
Merge(two or more nodes) - combines nodes.
Merge(two or more nodes with any number of ways) - ignored (greyed
 out)

Join Node(one node) - joins node into one or more of the nearest ways.
Join Node(one way) - ignored but not greyed out.
Join Node(multiple nodes) - ignored but not greyed out.


We make a new command called Join (which is the mirror of
Separate):

Join(two or more ways) - combines ways.
Join(two or more nodes) - combines nodes.
Join(one node and one way) - inserts the node into the way at the
nearest point.  If it's not near, throw a message saying Not near enough

Join(one node and multiple ways) - for each way: Join(node, way)
Join(one way and multiple nodes) - for each node: Join(node, way)

Join(multiple ways and multiple nodes) - error: Too many things selected

-- 
--my blog is athttp://blog.russnelson.com
Cloudmade supports http://openstreetmap.org/ 
521 Pleasant Valley Rd. | +1 315-323-1241
Potsdam, NY 13676-3213  | Sheepdog   

___
josm-dev mailing list
josm-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev


Re: [josm-dev] Combine and Merge

2009-04-23 Thread Frederik Ramm
Hi,

Ævar Arnfjörð Bjarmason wrote:
 If you're rewriting this perhaps you could also make it support
 merging two (or more) nodes two the location of a specific node,
 currently merge will merge to the oldest node, which isn't always
 what you want.
 
 Perhaps the combine way has this problem as well?

It has in that you cannot control which of the two ways will be extended 
to contain the other's nodes and which of the two will be deleted, but 
since no nodes are moved in the process it is not visible.

Bye
Frederik

-- 
Frederik Ramm  ##  eMail frede...@remote.org  ##  N49°00'09 E008°23'33

___
josm-dev mailing list
josm-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev


Re: [josm-dev] Combine and Merge

2009-04-23 Thread Russ Nelson
Ævar Arnfjörð Bjarmason writes:
  On Thu, Apr 23, 2009 at 6:58 PM, Russ Nelson nel...@crynwr.com wrote:
   Can we combine and merge Combine and Merge?
  
   Combine: combines ways.
   Merge: combines nodes.
  
   If there's no objection, I'll write the patch.
  
  If you're rewriting this perhaps you could also make it support
  merging two (or more) nodes two the location of a specific node,
  currently merge will merge to the oldest node, which isn't always
  what you want.

I recall that the resultant node used to have the average location of
both nodes, but now it seems to use the first node listed in the
Current Selection box.

Seems like if you don't like this behavior, 

  Perhaps the combine way has this problem as well?

Not really.  The ways are already touching, so nothing needs to get
moved.  The tags from both ways get piled into the new way.  If there
are any tags with different values in the different ways, you get
asked which value to use.

-- 
--my blog is athttp://blog.russnelson.com
Cloudmade supports http://openstreetmap.org/ 
521 Pleasant Valley Rd. | +1 315-323-1241
Potsdam, NY 13676-3213  | Sheepdog   

___
josm-dev mailing list
josm-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev