[josm-dev] Selection handling

2009-10-11 Thread Karl Guggisberg
Hi Dave,

I saw that your patch regarding selection handling was commited:
  http://josm.openstreetmap.de/ticket/3676

When you introduce a new selection cache in the future, could you make
sure it's *ordered*, i.e. it reflects the order in which primitives are
selected (could be a list, an ordered set, instead of a plain collection)?

This would be an important prerequisite for a couple of trac tickets asking
for
* adding the current selection as relation members *in order*
* picking the *firts* selected node as target node in node merging
* picking the *firts* selected way as target way in way combining

Thanks and regards
Karl 




___
josm-dev mailing list
josm-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev


Re: [josm-dev] Selection handling

2009-10-11 Thread Petr NejedlĂ˝
Karl Guggisberg napsal(a):
 Hi Dave,
 
 I saw that your patch regarding selection handling was commited:
   http://josm.openstreetmap.de/ticket/3676
 
 When you introduce a new selection cache in the future, could you make
 sure it's *ordered*, i.e. it reflects the order in which primitives are
 selected (could be a list, an ordered set, instead of a plain collection)?

FYI: josm-ng used LinkedHashSet for keeping (per-layer) selection and 
used the order just to cover the cases you mentioned.

Nenik

___
josm-dev mailing list
josm-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev


Re: [josm-dev] Selection handling

2009-10-11 Thread Dave Hansen
On Sun, 2009-10-11 at 11:04 +0200, Karl Guggisberg wrote:
 Hi Dave,
 
 I saw that your patch regarding selection handling was commited:
   http://josm.openstreetmap.de/ticket/3676
 
 When you introduce a new selection cache in the future, could you make
 sure it's *ordered*, i.e. it reflects the order in which primitives are
 selected (could be a list, an ordered set, instead of a plain collection)?
 
 This would be an important prerequisite for a couple of trac tickets asking
 for
 * adding the current selection as relation members *in order*
 * picking the *firts* selected node as target node in node merging
 * picking the *firts* selected way as target way in way combining

Oh, cool.  I didn't even realize it had been committed.  Have you fixed
up the ordering yet?  I'd be glad to do it since I caused the problem in
the first place, of course.

-- Dave


___
josm-dev mailing list
josm-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev


Re: [josm-dev] Selection handling

2009-10-11 Thread Dave Hansen
On Sun, 2009-10-11 at 19:31 +0200, Karl Guggisberg wrote:
  Have you fixed up the ordering yet?
 No, not yet, I just wanted to let you know, in case you want to continue
 your work on this feature. 

OK, I'll probably have time to go look at it later today.

-- Dave


___
josm-dev mailing list
josm-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev