Re: [josm-dev] Tasks for all of you
On Wed, 31 Dec 2008, Shaun McDonald wrote: As I understood, a new user must be registred. That's a completely separate server, not connected to the rest of OSM. http://api06.dev.openstreetmap.org/user/new That's correct, all 3 of these test servers have their own user accounts connected to nothing else. Could you tell the other two? I did search for them today and was unable to find a note of their existence. And the obvious try http://dev.openstreetmap.org/ also lead to nothing (thought http://api06.dev.openstreetmap.org/ at the moment has the same problem :-) Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Tasks for all of you
That's just some failure on the dev server: http://wiki.openstreetmap.org/wiki/Platform_Status I think it will soon be back online. -Original Message- From: Dirk StЖcker openstreet...@dstoecker.de To: josm-dev@openstreetmap.org Date: Thu, 1 Jan 2009 12:32:05 +0100 (CET) Subject: Re: [josm-dev] Tasks for all of you On Wed, 31 Dec 2008, Shaun McDonald wrote: As I understood, a new user must be registred. That's a completely separate server, not connected to the rest of OSM. http://api06.dev.openstreetmap.org/user/new That's correct, all 3 of these test servers have their own user accounts connected to nothing else. Could you tell the other two? I did search for them today and was unable to find a note of their existence. And the obvious try http://dev.openstreetmap.org/ also lead to nothing (thought http://api06.dev.openstreetmap.org/ at the moment has the same problem :-) Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev Женя mailto:yourn...@mail.ru ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Tasks for all of you
On Mon, 29 Dec 2008, Shaun McDonald wrote: One option might be to manually make one and use one of the development test servers at http://apis.dev.openstreetmap.org to test it. What username/password must be used there? Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Tasks for all of you
Dirk Stöcker wrote: http://josm.openstreetmap.de/ticket/1906 WMS-Plugin: Implement caching Is this in compliance with yahoos usage license? There had been a discussion recently, I think the conclusion was that saving the yahoo-tiles on disk might violate the rules. http://info.yahoo.com/legal/us/yahoo/maps/mapsapi/mapsapi-2141.html (viii) store or allow end users to store map imagery, map data or geocoded location information from the Yahoo! Maps APIs for any future use; As a browser also saves tiles to a cache (firefox does), I would interpret that caching does not allow an end user to save the data. But it might be wise to clarify this issue first before implementing too much. Maybe webkit could do the caching... Stephan ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Tasks for all of you
Dirk Stöcker writes: http://josm.openstreetmap.de/ticket/1712 Incomplete ways are discarded without notice Could you go ahead and apply the patch in this email? http://lists.openstreetmap.org/pipermail/josm-dev/2008-December/002293.html I may never get around to improving it beyond it's current state, but for now it's an improvement over the current code and is worth using. At least having it there prevents bit rot and allows somebody else to pitch in and improve it. -- --my blog is athttp://blog.russnelson.com | Delegislation is a slippery Crynwr sells support for free software | PGPok | slope to prosperity. 521 Pleasant Valley Rd. | +1 315-323-1241 | Fewer laws, more freedom. Potsdam, NY 13676-3213 | Sheepdog | (Not a GOP supporter). ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Tasks for all of you
On Mon, 2008-12-22 at 17:44 +0100, Dirk Stöcker wrote: http://josm.openstreetmap.de/ticket/1677 plugin-preferences selection does not survive Update-clicking http://josm.openstreetmap.de/ticket/1442 Extrude of horizontal way only downwards, not upwards I've attached patches for these to the bugs. Matthew W. S. Bell ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Tasks for all of you
On Sun, 28 Dec 2008, Matthew W. S. Bell wrote: http://josm.openstreetmap.de/ticket/1677 plugin-preferences selection does not survive Update-clicking http://josm.openstreetmap.de/ticket/1442 Extrude of horizontal way only downwards, not upwards I've attached patches for these to the bugs. Thanks a lot. Applied. So 50% are done. Missing: http://josm.openstreetmap.de/ticket/1555 Downloaded GPS data is displayed in reverse http://josm.openstreetmap.de/ticket/1712 Incomplete ways are discarded without notice http://josm.openstreetmap.de/ticket/1654 Plugin dialog has non-clickable weblinks New tasks to have 6 again: http://josm.openstreetmap.de/ticket/1906 WMS-Plugin: Implement caching http://josm.openstreetmap.de/ticket/1903 Plugin-Update should test required version before installing http://josm.openstreetmap.de/ticket/1905 WMS-Plugin: Red error tiles do no automatically disappear and cannot be reloaded Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Tasks for all of you
Dirk Stöcker writes: http://josm.openstreetmap.de/ticket/1712 Incomplete ways are discarded without notice This is a minimal patch. I didn't want to make too many changes because somebody else is going to have to read this patch before they apply it. I don't know Java very well, so if anybody spots anything un-Javanic, please tell me. Potential improvements: o convert all invocations of OsmReader.parseDataSet() to OsmReader.parseDataSetOsm() to gain access to getParseNotes(). o Doing something more sensible with the output presentation if there are too many warnings than can fit on the screen (or will it switch to a scrollbox?) o It's possible that DataSet ought to be the entity that has parseNotes. That would make for a simpler patch, but not necessarily more correct. Index: src/org/openstreetmap/josm/actions/OpenFileAction.java === --- src/org/openstreetmap/josm/actions/OpenFileAction.java (revision 1180) +++ src/org/openstreetmap/josm/actions/OpenFileAction.java (working copy) @@ -74,10 +74,14 @@ private void openAsData(File file) throws SAXException, IOException, FileNotFoundException { String fn = file.getName(); if (ExtensionFileFilter.filters[ExtensionFileFilter.OSM].acceptName(fn)) { -DataSet dataSet = OsmReader.parseDataSet(new FileInputStream(file), null, Main.pleaseWaitDlg); +OsmReader osm = OsmReader.parseDataSetOsm(new FileInputStream(file), null, Main.pleaseWaitDlg); +DataSet dataSet = osm.getDs(); OsmDataLayer layer = new OsmDataLayer(dataSet, file.getName(), file); Main.main.addLayer(layer); layer.fireDataChange(); +if (osm.getParseNotes().length() != 0) { +JOptionPane.showMessageDialog(Main.parent, osm.getParseNotes()); +} } else JOptionPane.showMessageDialog(Main.parent, fn+: +tr(Unknown file extension: {0}, fn.substring(file.getName().lastIndexOf('.')+1))); Index: src/org/openstreetmap/josm/io/OsmReader.java === --- src/org/openstreetmap/josm/io/OsmReader.java(revision 1180) +++ src/org/openstreetmap/josm/io/OsmReader.java(working copy) @@ -59,8 +59,18 @@ * The dataset to add parsed objects to. */ private DataSet ds = new DataSet(); + public DataSet getDs() { return ds; } /** + * Record warnings. If there were any data inconsistencies, append + * a newline-terminated string. + */ + private String parseNotes = new String(); + public String getParseNotes() { + return parseNotes; + } + + /** * The visitor to use to add the data to the set. */ private AddVisitor adder = new AddVisitor(ds); @@ -332,6 +342,7 @@ for (long id : e.getValue()) { Node n = findNode(id); if (n == null) { + parseNotes += Skipping a way because it includes a node that doesn't exist: + id + \n; failed = true; break; } @@ -434,6 +445,10 @@ * elemet found there is returned. */ public static DataSet parseDataSet(InputStream source, DataSet ref, PleaseWaitDialog pleaseWaitDlg) throws SAXException, IOException { + return parseDataSetOsm(source, ref, pleaseWaitDlg).ds; + } + + public static OsmReader parseDataSetOsm(InputStream source, DataSet ref, PleaseWaitDialog pleaseWaitDlg) throws SAXException, IOException { OsmReader osm = new OsmReader(); osm.references = ref == null ? new DataSet() : ref; @@ -467,6 +482,6 @@ if (o.id 0) o.id = 0; - return osm.ds; + return osm; } } ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Tasks for all of you
On Mon, 22 Dec 2008, Russ Nelson wrote: Dirk Stöcker writes: http://josm.openstreetmap.de/ticket/1712 Incomplete ways are discarded without notice What should be done? Throw an exception immediately? Load the way anyway, ignoring missing points, and throw an exception after everything has been loaded? Either load the way without the nodes or drop the way as done now. But in any case inform the user about the fact. Ciao -- http://www.dstoecker.eu/ (PGP key available)___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Tasks for all of you
Dirk Stöcker writes: http://josm.openstreetmap.de/ticket/1712 Incomplete ways are discarded without notice What should be done? Throw an exception immediately? Load the way anyway, ignoring missing points, and throw an exception after everything has been loaded? In theory, the semantics of this file are as unacceptable as if it wasn't an XML file at all, and so the proper thing to do is throw away the entire contents of the file. In practice, this file may contain valuable data and the best thing to do is select all the ways in error and report an error message. -- --my blog is athttp://blog.russnelson.com | Delegislation is a slippery Crynwr sells support for free software | PGPok | slope to prosperity. 521 Pleasant Valley Rd. | +1 315-323-1241 | Fewer laws, more freedom. Potsdam, NY 13676-3213 | Sheepdog | (Not a GOP supporter). ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev