Re: [josm-dev] WMS and remote-control

2010-08-26 Thread Bodo Meissner

 Am 25.08.2010 23:54, schrieb Stephan Knauss:

Sebastian Klein wrote:

Stephan Knauss wrote:

Sebastian Klein wrote:
How about adding the basic functionality into core? Providing the 
listener and accepting commands.
I consider this is a viable solution. It fixes the problem of version 
dependency between wmsplugin and remotecontrol. The core part of 
remotecontrol would go into JOSM main

[...]

Is this being worked on? Maybe for the next version after tested is 
released...

I'm not working on this and I will not.
I think the dependency between remotecontrol and wmsplugin is 
sufficiently handled.
If the basic functionality of remotecontrol would be part of JOSM core 
it would make it more difficult for me when I have to make changes.



Bodo

___
josm-dev mailing list
josm-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev


Re: [josm-dev] WMS and remote-control

2010-08-22 Thread Sebastian Klein

Stephan Knauss wrote:

Sebastian Klein wrote:

So either the common protocol must be included in Josm core or
another possible solution would be to use reflection.


How about adding the basic functionality into core? Providing the 
listener and accepting commands.


By default it will have no commands included.

It provides a capabilities command that reports back the supported 
commands and their protocol version.


Plugins can register new commands with the core similar than they would 
register other functionality (like shortcuts and such).


So the core will know what commands are available and which plugin 
handles them.
It can also reject registrations of commands that already exist. It can 
provide a single configuration dialog where the plugins can append their 
plugin-specific settings.


Comments?


I consider this is a viable solution. It fixes the problem of version 
dependency between wmsplugin and remotecontrol. The core part of 
remotecontrol would go into JOSM main, but it would not even listen to 
some network port, if no commands are registered. (This should satisfy 
the paranoid people.)


remotecontrol plugin would then provide a basic set of commands and 
register them with JOSM core.


Each time the protocol of the callback changes, developers have to 
update the Mainversion of all the remote-controlling plugins. 
(currently wmsplugin and remotecontrol)


This would fit much better in the current framework.


Sebastian

___
josm-dev mailing list
josm-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev


Re: [josm-dev] WMS and remote-control

2010-08-22 Thread Bodo Meissner
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Am 20.08.2010 16:33, schrieb Komяpa:

 If possible, would also be nice to have just zoom command
[...]

Done.
see http://wiki.openstreetmap.org/wiki/JOSM/Plugins/RemoteControl#zoom_command


Bodo
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEARECAAYFAkxxigYACgkQnMz9fgzDSqcFQQCfWAz6JLWYxIujxWLOlmSQTDsk
0cMAoJw2NcF+cguDphuhkVjDIZrixNmL
=cdlh
-END PGP SIGNATURE-

___
josm-dev mailing list
josm-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev


Re: [josm-dev] WMS and remote-control

2010-08-21 Thread Stephan Knauss

Sebastian Klein wrote:

So either the common protocol must be included in Josm core or
another possible solution would be to use reflection.


How about adding the basic functionality into core? Providing the 
listener and accepting commands.


By default it will have no commands included.

It provides a capabilities command that reports back the supported 
commands and their protocol version.


Plugins can register new commands with the core similar than they would 
register other functionality (like shortcuts and such).


So the core will know what commands are available and which plugin 
handles them.
It can also reject registrations of commands that already exist. It can 
provide a single configuration dialog where the plugins can append their 
plugin-specific settings.


Comments?

Stephan

___
josm-dev mailing list
josm-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev


Re: [josm-dev] WMS and remote-control

2010-08-21 Thread Frederik Ramm

Hi,

Stephan Knauss wrote:
How about adding the basic functionality into core? Providing the 
listener and accepting commands.


There's bound to be some Java standard for doing this request broker 
stuff? It isn't exactly a niche thing one should think.


I am however wary at how people seem to use the remote control plugin 
for more and more stuff... where will it end? A special request where 
you can send some Java code to JOSM and it will execute that ;)?


Bye
Frederik

--
Frederik Ramm  ##  eMail frede...@remote.org  ##  N49°00'09 E008°23'33

___
josm-dev mailing list
josm-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev


Re: [josm-dev] WMS and remote-control

2010-08-21 Thread Russ Nelson
Frederik Ramm writes:
  I am however wary at how people seem to use the remote control plugin 
  for more and more stuff... where will it end? A special request where 
  you can send some Java code to JOSM and it will execute that ;)?

Every program expands until it can send email.  JOSM?? Not there yet!

-- 
--my blog is athttp://blog.russnelson.com
Crynwr supports open source software
521 Pleasant Valley Rd. | +1 315-600-8815
Potsdam, NY 13676-3213  | Sheepdog   

___
josm-dev mailing list
josm-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev


Re: [josm-dev] WMS and remote-control

2010-08-21 Thread Bodo Meissner
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Am 20.08.2010 16:33, schrieb Komяpa:

 If possible, would also be nice to have just zoom command, that
 won't load any data from OSM, but center view along bbox. If I've
 skipped it in documentation, please point me into it.

A zoom only command is not available. I will try to add this while working on 
the remotecontrol plugin.


Bodo

-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEARECAAYFAkxwL2cACgkQnMz9fgzDSqfLmQCeKRMcOS+hH6cZbnyYiU58CZaW
lXUAnj92iG2VucFlTGYt8mybN42hnVqs
=oPKw
-END PGP SIGNATURE-

___
josm-dev mailing list
josm-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev


Re: [josm-dev] WMS and remote-control

2010-08-20 Thread Komяpa
Hi Bodo,

2010/8/18 Bodo Meissner b...@bodo-m.de:

 I hope this is what you imagined.
 Please inform me about problems or suggestions.
Thanks.

If possible, would also be nice to have just zoom command, that
won't load any data from OSM, but center view along bbox. If I've
skipped it in documentation, please point me into it.


-- 
Darafei Komяpa Praliaskouski
xmpp:m...@komzpa.net mailto:m...@komzpa.net

___
josm-dev mailing list
josm-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev


Re: [josm-dev] WMS and remote-control

2010-08-18 Thread Sebastian Klein

Bodo Meissner wrote:

Hello Komяpa,

I modified the plugins remotecontrol and wmsplugin.
see
http://wiki.openstreetmap.org/wiki/JOSM/Plugins/RemoteControl#other_commands
and
http://wiki.openstreetmap.org/wiki/JOSM/Plugins/WMSPlugin#Remote_control

I hope this is what you imagined.
Please inform me about problems or suggestions.


I think you broke wmsplugin (see #5348). You cannot add RemoteControl to 
the classpath for compiling and then not deploy the binaries needed to 
execute.


At the moment, I'm not sure how to do this the right way, but please fix 
this as soon as possible, even if it is provisorily.



Sebastian


___
josm-dev mailing list
josm-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev


Re: [josm-dev] WMS and remote-control

2010-08-18 Thread Sebastian Klein

Sebastian Klein wrote:

Bodo Meissner wrote:

Hello Komяpa,

I modified the plugins remotecontrol and wmsplugin.
see
http://wiki.openstreetmap.org/wiki/JOSM/Plugins/RemoteControl#other_commands 


and
http://wiki.openstreetmap.org/wiki/JOSM/Plugins/WMSPlugin#Remote_control

I hope this is what you imagined.
Please inform me about problems or suggestions.


I think you broke wmsplugin (see #5348). You cannot add RemoteControl to 
the classpath for compiling and then not deploy the binaries needed to 
execute.


At the moment, I'm not sure how to do this the right way, but please fix 
this as soon as possible, even if it is provisorily.


There can be different conflicting versions of RemoteControl, wms and 
other pugins that will have support for Remote commands in the future.


So either the common protocol must be included in Josm core or
another possible solution would be to use reflection.


Sebastian

___
josm-dev mailing list
josm-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev


Re: [josm-dev] WMS and remote-control

2010-08-18 Thread Bodo Meissner

 Am 18.08.2010 23:49, schrieb Sebastian Klein:

So either the common protocol must be included in Josm core or
another possible solution would be to use reflection.


Yesterday I fixed the problem by using reflection in WMSPlugin.java to 
call functions of RemoteControlPlugin. (see WMSPlugin.initRemoteControl())

Maybe I can solve the problem by encapsulation.

Currently I use WMSRemoteHandler which is a subclass of 
org.openstreetmap.josm.plugins.remotecontrol.RequestHandler and this 
does not trigger the ClassNotFoundException.


I thought that it might be possible to move 
WMSPlugin.initRemoteControl() to some other class in wmsplugin.jar, 
maybe to WMSRemoteHandler and use normal calls instead of reflection.



Bodo

___
josm-dev mailing list
josm-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev


Re: [josm-dev] WMS and remote-control

2010-08-17 Thread Stephan Knauss

Hi Bodo,

Bodo Meissner wrote:

http://wiki.openstreetmap.org/wiki/JOSM/Plugins/RemoteControl#other_commands


a while back I added the version command to enable web sites to detect a 
running JOSM.


I thought that a version number might be sufficient to let Websites know 
which commands are available in the reported protocol version.


With the possibility to add arbitrary commands that seams to be not 
enough. I think it might be useful to provide a capabilities command. 
That would report back the available commands as well as the interface 
version of each command.


That way a website can discover whether the JOSM in use supports the 
requested functionality.


What do you think?

Stephan

___
josm-dev mailing list
josm-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev


Re: [josm-dev] WMS and remote-control

2010-08-17 Thread Bodo Meissner

 Am 18.08.2010 00:57, schrieb Stephan Knauss:
a while back I added the version command to enable web sites to detect 
a running JOSM.


I thought that a version number might be sufficient to let Websites 
know which commands are available in the reported protocol version.

That means I should increment the version number.

With the possibility to add arbitrary commands that seams to be not 
enough. I think it might be useful to provide a capabilities command. 
That would report back the available commands as well as the interface 
version of each command.

In theory this is a good idea.
Is there any website actually using the version number request?
Currently the website could simply try the command and check the response.

Should JOSM report only commands that are not disabled by configuration?
IIRC a non-existing command will produce the same response as a disabled 
command.



Bodo

___
josm-dev mailing list
josm-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev


Re: [josm-dev] WMS and remote-control

2010-08-14 Thread Sebastian Klein

Komяpa wrote:

2010/8/12 Sebastian Klein basti...@googlemail.com:

Komяpa wrote:



1) Due to Landsat WMS being down and overloaded usually, we've set up
a caching WMS proxy for it.
JOSM URL is http://irs.gis-lab.info/?layers=landsat;
Please consider updating JOSM defaults.

Do you want it to show up in the list on the bottom, or make it installed by
default instead of the standard landsat URL?
Are you sure, you can handle the traffic?

This server also provides IRS imagery for Russia for quite a long time.
I'm sure it will be able to handle traffic. So, worth trying
installing it by default.


Done.


Now, we need a convenient way to load that imagery into josm. An
extenstion to josm-remote that will load specified WMS URL will be
just fine. Hope somebody will write it, as I'm no java coder,
unfortunately.

There are some security issues when the browser has too much control over
the client software.


As far as I know, josm-remote has options that lets paranoid users
disable some of its features if they dislike that.


OK, the question is: Make it opt-in or opt-out? Let's wait till it's 
ready, then we can decide...


Sebastian



___
josm-dev mailing list
josm-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev


Re: [josm-dev] WMS and remote-control

2010-08-13 Thread Komяpa
2010/8/12 Sebastian Klein basti...@googlemail.com:
 Komяpa wrote:

 1) Due to Landsat WMS being down and overloaded usually, we've set up
 a caching WMS proxy for it.
 JOSM URL is http://irs.gis-lab.info/?layers=landsat;
 Please consider updating JOSM defaults.
 Do you want it to show up in the list on the bottom, or make it installed by
 default instead of the standard landsat URL?
 Are you sure, you can handle the traffic?
This server also provides IRS imagery for Russia for quite a long time.
I'm sure it will be able to handle traffic. So, worth trying
installing it by default.

 However you cannot force people to delete an entry from their
 menu, once it has been added it to their bookmarks.
Ok.

 Now, we need a convenient way to load that imagery into josm. An
 extenstion to josm-remote that will load specified WMS URL will be
 just fine. Hope somebody will write it, as I'm no java coder,
 unfortunately.

 There are some security issues when the browser has too much control over
 the client software.

As far as I know, josm-remote has options that lets paranoid users
disable some of its features if they dislike that.

-- 
Darafei Komяpa Praliaskouski
xmpp:m...@komzpa.net mailto:m...@komzpa.net

___
josm-dev mailing list
josm-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev


Re: [josm-dev] WMS and remote-control

2010-08-12 Thread bomm


Komяpa wrote:
 
 2) fires.Kosmosnimki.ru have provided us access to their realtime
 satellite imagery. That imagery [...] consists of thousands of layers.
 [...]
 Now, we need a convenient way to load that imagery into josm. An
 extenstion to josm-remote that will load specified WMS URL will be
 just fine.
 

What do you want to implement? A Web page to select a layer and load it into
JOSM?

Currently the WMS plugin needs a configuration entry for every WMS server
(and every layer).
I don't know how much work it would be to implement a remote interface for
(temporarily?) adding the necessary configuration and automatically loading
the new WMS layer.

For now I suggest you generate and display the WMS URL for the selected
layer in the format required by JOSM. Then the user can copy and paste it
into JOSM's configuration as needed. It's not as user friendly as you
intended but it's the best you can do with the current version of JOSM and
WMS plugin.

(I resend this via nabble because my original message sent via webmail
interface did not show up on the list.)


Bodo
-- 
View this message in context: 
http://gis.638310.n2.nabble.com/WMS-and-remote-control-tp5413841p5415372.html
Sent from the JOSM Development mailing list archive at Nabble.com.

___
josm-dev mailing list
josm-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev


Re: [josm-dev] WMS and remote-control

2010-08-12 Thread Komяpa
 What do you want to implement? A Web page to select a layer and load it into
 JOSM?
Yes.

 Currently the WMS plugin needs a configuration entry for every WMS server
 (and every layer).
 I don't know how much work it would be to implement a remote interface for
 (temporarily?) adding the necessary configuration and automatically loading
 the new WMS layer.
Except for configuration window (F12-WMS), WMS plugin has menu item
WMS-Rectified Image, that lets user quickly add a layer by WMS URL.
What's needed is a way to access this functionality from a webpage.

-- 
Darafei Komяpa Praliaskouski
xmpp:m...@komzpa.net mailto:m...@komzpa.net

___
josm-dev mailing list
josm-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev


Re: [josm-dev] WMS and remote-control

2010-08-12 Thread Sebastian Klein

Komяpa wrote:

Hi all,

1) Due to Landsat WMS being down and overloaded usually, we've set up
a caching WMS proxy for it.
JOSM URL is http://irs.gis-lab.info/?layers=landsat;
Please consider updating JOSM defaults.


Do you want it to show up in the list on the bottom, or make it 
installed by default instead of the standard landsat URL?


Are you sure, you can handle the traffic?

The list of wms services [1] can be edited and is loaded by each wms 
client on startup. However you cannot force people to delete an entry 
from their menu, once it has been added it to their bookmarks.


[1] 
http://svn.openstreetmap.org/applications/editors/josm/plugins/wmsplugin/sources.cfg



2) fires.Kosmosnimki.ru have provided us access to their realtime
satellite imagery. That imagery is not mosaiced, and consists of
thousands of layers. We've made a WMS gateway to it.
Now, we need a convenient way to load that imagery into josm. An
extenstion to josm-remote that will load specified WMS URL will be
just fine. Hope somebody will write it, as I'm no java coder,
unfortunately.


There are some security issues when the browser has too much control 
over the client software.


If you extend josm-remote this way, I suggest you fork it. (No offence 
intended, might be useful for some.)



Sebastian

___
josm-dev mailing list
josm-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev