Re: [josm-dev] Illegal tag/value combination
2011/4/17 Dirk Stöcker openstreet...@dstoecker.de: I have no idea how the relevant code really should work, but ATM I think it is broken by design. It seems it tries to check combinations of two tags, but in the way it is implemented it totally fails in case only the first tag exists). btw: This message is also appearing for highway=road (with the description: temporary highway type (or similar)), not only for unknown k/v. cheers, Martin ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Illegal tag/value combination
On Sat, 16 Apr 2011, M∡rtin Koppenhoefer wrote: Well, test is not recognized and unknown tags are info-level and not displayed by default. I see. Turned it on ;-) Actually I think that displaying these info-level hints as Infos (and not as errors like before) would be also useful by default. I don't perceive it as nannying the users. Info level has too many false positives to be useful as default and I don't think this will change in future. I don't want to encourage the users who want to have everything perfect and then destroy perfectly valid data not recogniced by validator. The validator should only be a help to find obvious errors and allows deeper inspection only when the user knows what he does. Ciao -- http://www.dstoecker.eu/ (PGP key available)___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Illegal tag/value combination
On Tue, 12 Apr 2011, Nakor wrote: It is. You always have a second message telling you the exact issue. Sorry I do not see this second message. Where would it be? Simply enlarge the display or use mouse-over. It is appended at the end. I now reversed this, so the detailed message comes first. Also I changed Illegal to Suspicious, which is a lot better. I also improved the upload validator dialog a lot (as already discussed before), so it should be much better understandable what it really means. Improved wording of the texts is always welcome. 2) degraded to warning or info: this is not an error just some missing data It is warning, info or error, depending on the settings for this particular issue. What could we do to downgrade this one to an info? When you tell us which one: yes. Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Illegal tag/value combination
2011/4/15 Dirk Stöcker openstreet...@dstoecker.de: Also I changed Illegal to Suspicious, which is a lot better. thank you, maybe unknown would be even better (maybe you could also not only say key/value-combination but explicitly name key or value (or key and value) It is warning, info or error, depending on the settings for this particular issue. generally the wording Your data contains errors sounds a bit harsh when the problems are only warnings. (Maybe this is already changed?) Btw: validator doesn't seem to work any more. I tried to upload a way tagged test=apfelbaum and could have uploaded it without any complaint, even on manual check validator didn't care. cheers, Martin ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Illegal tag/value combination
On 4/15/2011 6:30 AM, Dirk Stöcker wrote: Simply enlarge the display or use mouse-over. It is appended at the end. I now reversed this, so the detailed message comes first. Also I changed Illegal to Suspicious, which is a lot better. I also improved the upload validator dialog a lot (as already discussed before), so it should be much better understandable what it really means. Improved wording of the texts is always welcome. Thank you very much for this. 2) degraded to warning or info: this is not an error just some missing data It is warning, info or error, depending on the settings for this particular issue. What could we do to downgrade this one to an info? When you tell us which one: yes. The one for all those church in the previous screenshot. If I understand correctlyu what has been told before that would be a place of worship without a religion tag. ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Illegal tag/value combination
Am 15.04.2011 17:03, schrieb Nakor: On 4/15/2011 6:30 AM, Dirk Stöcker wrote: Simply enlarge the display or use mouse-over. It is appended at the end. I now reversed this, so the detailed message comes first. Also I changed Illegal to Suspicious, which is a lot better. I also improved the upload validator dialog a lot (as already discussed before), so it should be much better understandable what it really means. Improved wording of the texts is always welcome. Thank you very much for this. +1 by the way: The validator layer is slowing down JOSM if on top of all layers. Maybe also the direct rendering a problem ? cu colliar ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Illegal tag/value combination
On Fri, 15 Apr 2011, M∡rtin Koppenhoefer wrote: thank you, maybe unknown would be even better (maybe you could also not only say key/value-combination but explicitly name key or value (or key and value) This is not possible, as the generic group does not know if it is key, value or both. generally the wording Your data contains errors sounds a bit harsh when the problems are only warnings. (Maybe this is already changed?) Already fixed. Btw: validator doesn't seem to work any more. I tried to upload a way tagged test=apfelbaum and could have uploaded it without any complaint, even on manual check validator didn't care. Well, test is not recogniced and unknown tags are info-level and not displayed by default. Ciao -- http://www.dstoecker.eu/ (PGP key available)___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Illegal tag/value combination
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Am 15.04.2011 17:54, schrieb colliar: by the way: The validator layer is slowing down JOSM if on top of all layers. Maybe also the direct rendering a problem ? Sorry I meant antialiasing like the gpx-layer Cheers colliar -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.10 (GNU/Linux) iEYEAREIAAYFAk2ok5MACgkQalWTFLzqsCtyrwCgimoK3ASFxtULD7Oy9l6P+SeC dJgAn0waK2kBqAlzHgxSPwM+8hitid3l =ixxl -END PGP SIGNATURE- ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Illegal tag/value combination
2011/4/15 Dirk Stöcker openstreet...@dstoecker.de: On Fri, 15 Apr 2011, M∡rtin Koppenhoefer wrote: Well, test is not recognized and unknown tags are info-level and not displayed by default. I see. Turned it on ;-) Actually I think that displaying these info-level hints as Infos (and not as errors like before) would be also useful by default. I don't perceive it as nannying the users. cheers, Martin ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Illegal tag/value combination
On Sun, 10 Apr 2011, Nakor wrote: I usually get that when a religious building is missing the denomination tag. Can the message be: 1) more explicit It is. You always have a second message telling you the exact issue. 2) degraded to warning or info: this is not an error just some missing data It is warning, info or error, depending on the settings for this particular issue. Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Illegal tag/value combination
Hi Nakor, I usually get that when a religious building is missing the denomination tag. Polyglot 2011/4/9 Nakor nakor@gmail.com Hello, What is an illegal tag/value combination and why does it show up as an error? Thanks, N. ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Illegal tag/value combination
On 04/10/2011 03:00 AM, Jo wrote: Hi Nakor, I usually get that when a religious building is missing the denomination tag. Polyglot Can the message be: 1) more explicit 2) degraded to warning or info: this is not an error just some missing data Thanks, N. ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
