[Review Queue] :: openbook :: ethercalc :: cassandra :: apache2
Its that time again - the Big Data team had the opportunity to review some of the items in the review queue... *openbook* https://code.launchpad.net/~talligent/charms/trusty/openbook/trunk/+merge/267885 This one went very smoothly - passed all tests the first time. I was then able to log in with the URL and credentials supplied in the readme and click around. Approved. *ethercalc* https://bugs.launchpad.net/charms/+bug/1486247 Test had some small issues, and port was missing on website-relation MP provided for those issues, and otherwise it seems ok to promulgate *cassandra* https://code.launchpad.net/~stub/charms/trusty/cassandra/spike/+merge/270378 Test fixes and other small improvements Looks good, tests pass. Merged. *apache2* https://code.launchpad.net/~mbruzek/charms/trusty/apache2/nagios_extra_check_https/+merge/275095 This proposal introduces a new nagios config option so the monitor can call check_http with multiple parameters (good for checking multiple hosts from 1 apache2 service) We proposed enhancing the current nagios config to support multiple args instead of having 2 config options that both affect check_http. During review, we also found failures in the hook tests. These were not introduced by this MP, so we opened the following bug to address them: - https://bugs.launchpad.net/charms/+source/apache2/+bug/1511474 -- Juju mailing list Juju@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju
[Review Queue]: Openbook
For my time in the review queue I did another round on the Talligent Openbook charm. The previous problem was fixed, but it had another configuration related problem. https://bugs.launchpad.net/charms/+bug/1411402 - Matt Bruzek matthew.bru...@canonical.com -- Juju mailing list Juju@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju
[Review Queue] Openbook
Openbook is a cloud billing solution from Talligent. They charmed it up and are proposing it for inclusion in the charm store. The charm is really well documented and relates to mariadb and tomcat. While peer reviewing with Cory, we noticed the relation to tomcat was over the implicit juju-info. Though this is common for subordinate charms relating to tomcat, it isn't ideal -- it makes openbook capable of colocating on any unit (since all units provide juju-info). See Cory's RQ note from this morning for more info. When tomcat is updated, we'll circle back to all tomcat subordinates and suggest an updated relation. Back to openbook -- following the readme was simple, and deployment went smoothly. This charm didn't include tests, so we can't recommend it in the store just yet. I proposed a simple test for inclusion and offered suggestions in case they want to expand on mine. I look forward to re-reviewing once tests fall into place. https://bugs.launchpad.net/charms/+bug/1411402 Thanks, -Kevin -- Juju mailing list Juju@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju
