[Review Queue] ibm-ib, mobicents-rescomm-charm, ethercalc, git

2015-08-21 Thread Cory Johns
Greetings,

Kevin, Amir, Andrew, and I attacked the Review Queue yesterday and threw in
our two cents on several charm submissions by the excellent members of our
community.

+ ibm-ib
https://bugs.launchpad.net/charms/+bug/1452242

Following up on reviews by Matt and Adam, vsr addressed all of their
comments and thus I was able to successfully deploy and relate this charm,
which also passed all of the other criteria of review.  So, I gave it my +1
to be promoted alongside the ibm-mq charm in the store!  Great work from
the charmers at IBM.

+ mobicents-restcomm-charm
https://bugs.launchpad.net/charms/+bug/1452242

Kevin had some excellent feedback to improve this charm's README and user
experience, which Jean has already started working to incorporate.

+ ethercalc
https://bugs.launchpad.net/charms/+bug/1486247

Amir has some small suggestions, which he helpfully submitted as a merge
proposal on the branch, which Joe has already merged.  I think that with
another look, this is probably ready to go.

+ git
https://bugs.launchpad.net/charms/+bug/1481282

Andrew took a look at this charm since Domas addressed my feedback from
last week, but unfortunately still ran into an issue with the test.  We had
some speculation that it might depend on the timing of the services coming
up and thus be something of a race condition, which are always difficult to
sort out.  But we're optimistic that the test output that Andrew provided
should help in getting it fixed.
-- 
Juju mailing list
Juju@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/juju


[Review Queue] IBM IB

2015-05-08 Thread Matt Bruzek
I spent some time reviewing the IBM Integration Bus (IB) charm today.  My
review is here:  https://bugs.launchpad.net/charms/+bug/1452242

This is another charm where the author is expecting the Juju user to
download the software (1.2GB) separately, host it on a web server and
*then* deploy will work.  That is a really poor experience in my opinion
and I would like to see the charm automatically download the software for
the user, that is the magic bit of Juju!

   - Matt Bruzek 
-- 
Juju mailing list
Juju@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/juju