[Review Queue] etcd, apache2, kibana, neutron-calico, bird
Greetings. The big data team (myself, Kevin, and Andrew) spent some time on the review queue yesterday and worked on the following reviews: - etcd - https://code.launchpad.net/~kubernetes/charms/trusty/etcd/trunk/+merge/275768 - This is a fairly simple update that includes extended status messages. Deployment looks great with these new messages, and all tests pass. Approved and merged. - apache2 - https://code.launchpad.net/~verterok/charms/trusty/apache2/hostname-resolution-fix/+merge/272127 - This adds ip/hostname information to /etc/hosts on the apache unit. While it looks good, it is currently held up by a prereq that modifies nagios http checks. This will be good to merge once the prereq has been committed. - Kibana (version bump) - https://code.launchpad.net/~chris.macnaughton/charms/trusty/kibana/version_bump/+merge/274029 - All tests now pass and as per previous reviews this one looks good - Approved and merged (thanks to Chuck for the merge). - Kibana (url mod) - https://code.launchpad.net/~canonical-is-sa/charms/trusty/kibana/trunk/+merge/276221 - Tests fail due to issues which are fixed in the above (version bump) MR - this needs to be merged in and re-tested. - neutron-calico - https://bugs.launchpad.net/charms/+bug/1421230 - Minor issues with README deploy instructions and charm proof failure. MP with fix provided. Otherwise good, and I will follow up later today and Monday to try to get these promoted. - bird - https://bugs.launchpad.net/charms/+bug/1431445 - Amulet test fails because neutron-calico is subordinate; needs to also deploy nova-compute. MP with fix provided. Otherwise good, and I will follow up later today and Monday to try to get these promoted. -- Juju mailing list Juju@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju
[Review Queue] etcd
Hi, I had the pleasure of reviewing the etcd charm today. It passed charm proof, the python code passed pep8 and my review of the code. I deployed this charm manually on GCE and scaled up to a 3 node cluster successfully. I also ran the tests with bundletester on Amazon and the three tests passed! For more details go here: https://bugs.launchpad.net/charms/+bug/1474061 Thanks, - Matt Bruzek -- Juju mailing list Juju@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju
[Review Queue] etcd, storage, postgresql (and some from last week)
Greetings. The Big Data team (myself, Kevin, and Amir) got in some Review Queue time today. We also apparently forgot to send out an email for the RQ items we got to last week, so those are included below, as well. + etcd https://bugs.launchpad.net/charms/+bug/1474061 Mostly good, Amir had a couple of suggested small improvements to the README and ran into what may be a race condition in the Amulet test causing an intermittent spurious failure. + storage https://code.launchpad.net/~verterok/charms/precise/storage/wait-a-bit-longer-if-needed/+merge/263016 The addition of an option to control the timeout waiting for the block device was a nice change with good test coverage, making for an easy +1. + postgresql https://code.launchpad.net/~stub/charms/trusty/postgresql/replication-control/+merge/262968 Actions are great, and this MP added two new actions to pause and resume the hot-standby replication. Also easy to approve another great addition. --- And, hearkening back to the week prior, some belated reviews from our team: + apache-spark-notebook https://bugs.launchpad.net/charms/+bug/1463019 Kevin was able to review and put the finishing touches on this and get it all ready for promulgation, where it will join our rapidly growing collection of Big Data solutions. + plumgrid-director https://bugs.launchpad.net/charms/+bug/1459568 A follow-up to an earlier review, the architecture design of this related set of charms is coming along very nicely and some items from previous reviews appear to have been addressed. Definitely looking forward to seeing the finished product on these. + ibm-mq https://bugs.launchpad.net/charms/+bug/1432489 Though there were some issues with the external binaries needed for this charm mentioned by others, I was able to provide some suggested improvements to the README and tests. Those have since been incorporated and additional information regarding the external binaries provided, so this seems to be ready for another round of review. -- Juju mailing list Juju@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju
