Re: [Review Queue] postgresql

[Andreas Hasenack]

On Wed, Nov 11, 2015 at 8:17 PM, Antonio Rosales <
antonio.rosa...@canonical.com> wrote:

> On Wed, Nov 11, 2015 at 2:31 PM, Matt Bruzek
>  wrote:
> > I reviewed the rewrite of the postgresql charm today.  It is finally
> passing
> > tests in the automated test runner but I also ran bundletester on a local
> > KVM provider where it too a REALLY long time but all 12 tests passed!
> >
> > +1 LGTM so I merged it today.
> >
> > You can read more about the proposal here:
> >
> https://code.launchpad.net/~stub/charms/trusty/postgresql/rewrite/+merge/267646
> >
> > A big thank you to Stuart Bishop and Tim for all the cycles with our
> team to
> > get the postgresql tests to run in automation!
>
> Great to see the tests passing!
>
>
Be careful, somehow this landed in the precise postgresql charm and broke
the precise deployment, because python3 is not there by default:
2015-11-11 21:07:30 ERROR juju.worker.uniter.operation runhook.go:107 hook
"install" failed: fork/exec
/var/lib/juju/agents/unit-postgresql-0/charm/hooks/install: no such
 file or directory
2015-11-11 21:07:30 DEBUG juju.worker.uniter modes.go:31 [AGENT-STATUS]
failed: run install hook

# head -n 1 /var/lib/juju/agents/unit-postgresql-0/charm/hooks/install
#!/usr/bin/python3
-- 
Juju mailing list
Juju@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/juju

Re: [Review Queue] postgresql

[Antonio Rosales]

On Wed, Nov 11, 2015 at 2:31 PM, Matt Bruzek
 wrote:
> I reviewed the rewrite of the postgresql charm today.  It is finally passing
> tests in the automated test runner but I also ran bundletester on a local
> KVM provider where it too a REALLY long time but all 12 tests passed!
>
> +1 LGTM so I merged it today.
>
> You can read more about the proposal here:
> https://code.launchpad.net/~stub/charms/trusty/postgresql/rewrite/+merge/267646
>
> A big thank you to Stuart Bishop and Tim for all the cycles with our team to
> get the postgresql tests to run in automation!

Great to see the tests passing!

-Antonio

>
>- Matt Bruzek 
>
> --
> Juju mailing list
> Juju@lists.ubuntu.com
> Modify settings or unsubscribe at:
> https://lists.ubuntu.com/mailman/listinfo/juju
>

-- 
Juju mailing list
Juju@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/juju

[Review Queue] postgresql

[Matt Bruzek]

I reviewed the rewrite of the postgresql charm today.  It is finally
passing tests in the automated test runner but I also ran bundletester on a
local KVM provider where it too a REALLY long time but all 12 tests passed!

+1 LGTM so I merged it today.

You can read more about the proposal here:
https://code.launchpad.net/~stub/charms/trusty/postgresql/rewrite/+merge/267646

A big thank you to Stuart Bishop and Tim for all the cycles with our team
to get the postgresql tests to run in automation!

   - Matt Bruzek 
-- 
Juju mailing list
Juju@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/juju

[Review Queue] Postgresql, IBM LSF Platform

[Charles Butler]

https://code.launchpad.net/~stub/charms/trusty/postgresql/rewrite-charmhelpers/+merge/267645

Quick sync charm helpers into PGSQL to break apart the noise from
features/fixes. +1 and merged


https://bugs.launchpad.net/charms/+bug/1462212

IBM LSF is a high performance workload management platform for distributed
compute jobs. The charm is well done for a first submission, and has a few
nitpicks that need to be addressed before it can be accepted, but i am
confident these changes are minor and will be fixed soon. -1 for now

All the best,


Charles Butler  - Juju Charmer
Come see the future of datacenter orchestration: http://jujucharms.com
-- 
Juju mailing list
Juju@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/juju

Re: [Review Queue] Postgresql Integration Tests

[Stuart Bishop]

On 1 April 2015 at 02:02, Charles Butler  wrote:
> I had a bit of a rough go with this one, but I've managed to make the same
> assertions Adam did
>
> https://code.launchpad.net/~stub/charms/precise/postgresql/enable-integration-tests/+merge/238283
>
> -1 pending a short patch, and getting the upstream projects patched to
> support the work going on in this branch. (deployer, et-al)

I've flagged the MP as in-progress. Adam's run had picked up what I
think is a genuine and easy to fix race condition in the charm.

-- 
Stuart Bishop 

-- 
Juju mailing list
Juju@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/juju

[Review Queue] Postgresql Integration Tests

[Charles Butler]

I had a bit of a rough go with this one, but I've managed to make the same
assertions Adam did

https://code.launchpad.net/~stub/charms/precise/postgresql/enable-integration-tests/+merge/238283

-1 pending a short patch, and getting the upstream projects patched to
support the work going on in this branch. (deployer, et-al)

Charles Butler  - Juju Charmer
Come see the future of datacenter orchestration: http://jujucharms.com
-- 
Juju mailing list
Juju@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/juju

[Review Queue] postgresql

[Adam Israel]

postgresql

This was a comprehensive review of a new suite of integration tests.
There were intermittent failures that I traced back to a bug in juju
core and other assorted issues with some of our test toolchain. I
resolved those issues (see below) and was able to run most of the tests
successfully.

There were a few changes that needed to be made to the tests themselves,
one correcting a typo and another to increase a timeout. I ended up with
one test failing, though I suspect it’s a logic issue in the test rather
than an actual failure.

bundletester - https://github.com/juju-solutions/bundletester/pull/14:

  * Fixed bug that could lead to |make lint| and |make test| to be run twice

juju-deployer -
https://code.launchpad.net/~aisrael/juju-deployer/workaround-lp-1421315/+merge/254328
:

  * Added a workaround for an issue with juju api where a subordinate
unit may not immediately appear in the watch output (see
lp:1421315), which would cause a deployment to fail.
  * Added a workaround to add_units() where it would attempt to add
units to a service that was not available via juju api’s status
output yet.

juju-wait -
https://code.launchpad.net/~aisrael/juju-wait/fix-lock-timeout/+merge/254331


  * Changed the Executor worker count from 6 to 1, to resolve recurring
“ERROR cannot read info: lock timeout exceeded” errors.

​
-- 
Juju mailing list
Juju@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/juju

[Review Queue] postgresql

[Adam Israel]

Postgresql - re-enabling integration tests using amulet

I NAK’d this merge proposal for now. There was one minor issue with test
dependencies not being installed when |make test| was run, but the
larger issue was that machines were not being destroyed between tests so
the integrations eventually failed with 29 running machines and 3 stuck
in pending (exhausting local resources).

I’ve asked for more info about the submitters own test runs, in case
there’s a step I’m missing.

https://code.launchpad.net/~stub/charms/precise/postgresql/enable-integration-tests/+merge/238283


​
-- 
Juju mailing list
Juju@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/juju

[Review Queue] Postgresql, Mongodb, and [Trusty]

[Charles Butler]

That awkward moment when you realize you composed a draft but never sent
it... a week ago...

-- the old --
Today I've done quite a few wrap-up reviews of several charms that I've
been working over the last week in between conference cycles - so apologies
on the lengthy delay of getting things merged, and/or response cycles there
in.


Postgresql -  Reviewed a wrap up branch from stub that addresses several
concerns of the current charm in the store. There is additional work to
make it perfect regarding testing, but the charm itself is solid and should
replace what we have in the store. +1

review:
https://code.launchpad.net/~stub/charms/precise/postgresql/integration/+merge/233666
follow up bug:
https://bugs.launchpad.net/charms/+source/postgresql/+bug/1384894

MongoDB - I did a follow up review of MattyW's branch which introduces
user/password auth to MongoDB. This is a large leap forward in terms of
securing your mongodb instance in the cloud. - but still needs final
testing against all the substrates and configurations. (thanks for being
patient matty!)


I did a cursory review for MariaDB from an ISV branch without a bug
attacked due to time sensitivity in the review process: - this charm is a
really good rehash of mysql that bakes in multi-platform support int he
install hook and has stellar comments. I'll be earmarking this charm's
install hook for future reference

lp:~dbart/charms/trusty/mariadb/trunk


-- the new --

Today I did some promotion work with regard to the precise => trusty
upgrade movement we're working on internally, these charms made the cut:

lamp
munin
openerp-server
postgresql-psql


All the best,

Charles
-- 
Juju mailing list
Juju@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/juju

Re: [Review Queue] Postgresql WAL-E, ES Bundle

[Stuart Bishop]

On 27 August 2014 01:12, Whit Morriss  wrote:
> Last week:
>
> *WAL-E*: I reviewed Stuart Bishop's WAL-E merge proposal which adds
> experimental support via the wal-e utility for shipping logs to a variety of
> blobs stores (Swift, s3, and azure's WABs).  In general, the addition looks
> good, a fine addition to a fine charm.  I requested some additions to the
> documentation.  This week Stuart removed the charm from the queue citing
> that the charm was going in a possibly incompatible direction.

I think that last sentence is for another charm (I recall closing off
an old MP, where there were requested changes outstanding, the main
charm going Ansible, and the branch author stated they had no interest
in following). 
https://code.launchpad.net/~stub/charms/precise/postgresql/wal-e/+merge/225807
is still very much alive and looking for Approval from a ~charmer (and
feel free to just review and not land - I can handle landing when all
the dependant branches are done).

-- 
Stuart Bishop 

-- 
Juju mailing list
Juju@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/juju

Re: [Review Queue] Postgresql WAL-E, ES Bundle

[Charles Butler]

As a follow up to this email:

[0] was triaged - the ElasticSearch bundle is now available here:
https://code.launchpad.net/~charmers/charms/bundles/elasticsearch/bundle
[2] was pushed a while ago and is a byproduct of bug triage not happening.
I've closed out the bug and verified the wildfly bundle exists here:
https://code.launchpad.net/~charmers/charms/bundles/wildfly/bundle

All the best,

Charles


On Tue, Aug 26, 2014 at 2:12 PM, Whit Morriss 
wrote:

> Last week:
>
> *WAL-E*: I reviewed Stuart Bishop's WAL-E merge proposal which adds
> experimental support via the wal-e utility for shipping logs to a variety
> of blobs stores (Swift, s3, and azure's WABs).  In general, the addition
> looks good, a fine addition to a fine charm.  I requested some additions to
> the documentation.  This week Stuart removed the charm from the queue
> citing that the charm was going in a possibly incompatible direction.
>
> This week:
>
> *Elasticsearch Bundle*: Jorge Castro has compile a fine bundle for
> elasticsearch and friends: logstash, kibana, and a demo of paramedic and
> bigdesk, ES dashboards.  This bundle comes with a script to load up the
> dashboard plugins and the works of shakespeare so a user can play with
> querying es via kibana. The bundle is well documented and functions as
> advertised. gave it a +1. [0]
>
> *jujubackup*: (Vincenzo Di Somma *)* This
> charm installs as a subordinate to back up files to s3 or ubuntu one via
> duplicity.  I rejected it based on needing an icon, copyright and tests.
> [1]
>
> *WildFly Bundle* (from Jorge Castro): Wildfly is a java web application
> runtime. The bundle sets up an haproxy, a wildfly container and a mysql db.
>  A simple bundle, works as advertised, gave it a +1.
> [2]
>
> *Hortonworks Zookeeper* (from Amir Sanjar): The hortonwork package of
> apache zookeeper. Did not finish this review today, but passed back some
> requests based on charm proofing.
> [3]
>
> -w
>
> [0] https://code.launchpad.net/~jorge/charms/bundles/elasticsearch/bundle
> [1] https://bugs.launchpad.net/charms/+bug/1292492
> [2] https://bugs.launchpad.net/charms/+bug/1292597
> [3] https://bugs.launchpad.net/charms/+bug/1353197
>
> --
> ---
> D. Whit Morriss
> Developer, Juju Ecosystem
> Canonical USA
>
> --
> Juju mailing list
> Juju@lists.ubuntu.com
> Modify settings or unsubscribe at:
> https://lists.ubuntu.com/mailman/listinfo/juju
>
>
-- 
Juju mailing list
Juju@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/juju

[Review Queue] Postgresql WAL-E, ES Bundle

[Whit Morriss]

Last week:

*WAL-E*: I reviewed Stuart Bishop's WAL-E merge proposal which adds
experimental support via the wal-e utility for shipping logs to a variety
of blobs stores (Swift, s3, and azure's WABs).  In general, the addition
looks good, a fine addition to a fine charm.  I requested some additions to
the documentation.  This week Stuart removed the charm from the queue
citing that the charm was going in a possibly incompatible direction.

This week:

*Elasticsearch Bundle*: Jorge Castro has compile a fine bundle for
elasticsearch and friends: logstash, kibana, and a demo of paramedic and
bigdesk, ES dashboards.  This bundle comes with a script to load up the
dashboard plugins and the works of shakespeare so a user can play with
querying es via kibana. The bundle is well documented and functions as
advertised. gave it a +1. [0]

*jujubackup*: (Vincenzo Di Somma *)* This
charm installs as a subordinate to back up files to s3 or ubuntu one via
duplicity.  I rejected it based on needing an icon, copyright and tests.
[1]

*WildFly Bundle* (from Jorge Castro): Wildfly is a java web application
runtime. The bundle sets up an haproxy, a wildfly container and a mysql db.
 A simple bundle, works as advertised, gave it a +1.
[2]

*Hortonworks Zookeeper* (from Amir Sanjar): The hortonwork package of
apache zookeeper. Did not finish this review today, but passed back some
requests based on charm proofing.
[3]

-w

[0] https://code.launchpad.net/~jorge/charms/bundles/elasticsearch/bundle
[1] https://bugs.launchpad.net/charms/+bug/1292492
[2] https://bugs.launchpad.net/charms/+bug/1292597
[3] https://bugs.launchpad.net/charms/+bug/1353197

-- 
---
D. Whit Morriss
Developer, Juju Ecosystem
Canonical USA
-- 
Juju mailing list
Juju@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/juju