Hi folks

The mentored reviewers spreadsheet [1] has seven people down as people
who would like review mentors.

I'd like the team leads now to make sure that the people on their teams
have a mentor assigned.

The purpose of the mentor is to "review the review".  The idea here is
that the mentored reviewer will do a code review, and then ping their
mentor.  The mentor looks over the code, and looks over the review and
makes sure that the mentored reviewer raised the right concerns,
suggested good things and generally covered the bases that needed to be
covered.  The mentor then adds their LGTM to the pull request.

The idea here is to spread the knowledge of juju, but also to socialise
within the team how we like code reviews done, and the things that
raised to the developers.

Over time the reviewers learn more about what is expected, and as such,
tend to produce better code themselves as they know more what is going
to be picked up at review time.

Cheers,
Tim



[1]
https://docs.google.com/a/canonical.com/spreadsheets/d/1v9KB6Y4r1bMLOyB1JEs-wj_jBAvsq6EglWssa4cOx9c/edit#gid=0


-- 
Juju-dev mailing list
Juju-dev@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/juju-dev

Reply via email to