Re: Merge gating for more juju subprojects
On 25/03/2015, Rick Harding rick.hard...@canonical.com wrote: If you're using the github lander make sure the user has made it's org membership public. Thanks Rick, that was is. Thought I'd marked the bot's membership of go-goose at public previously, but had not. Martin -- Juju-dev mailing list Juju-dev@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju-dev
Re: Merge gating for more juju subprojects
On Wed, Mar 25, 2015 at 7:29 AM, Martin Packman martin.pack...@canonical.com wrote: On 13/03/2015, Martin Packman martin.pack...@canonical.com wrote: That said, if there are any packages you think we should *not* gate landings on their test suite passing yet, please say now. With the lack of objections, I've gone ahead and made the more active projects in the juju namespace on github merge gated. Thanks Martin. From now on, to land branches for: juju/errors juju/loggo juju/names juju/testing juju/utils Add $$merge$$ in a comment on the pr and wait for the bot to run tests. Please poke me if you notice anything amiss. Katherine just tried to $$merge$$ a go-goose branch, and it looks like the script is broken: https://github.com/go-goose/goose/pull/3 Tests passed, but merge failed. Ian merged manually. Cheers, Andrew Martin -- Juju-dev mailing list Juju-dev@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju-dev -- Juju-dev mailing list Juju-dev@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju-dev
Re: Merge gating for more juju subprojects
On 13/03/2015, Martin Packman martin.pack...@canonical.com wrote: That said, if there are any packages you think we should *not* gate landings on their test suite passing yet, please say now. With the lack of objections, I've gone ahead and made the more active projects in the juju namespace on github merge gated. From now on, to land branches for: juju/errors juju/loggo juju/names juju/testing juju/utils Add $$merge$$ in a comment on the pr and wait for the bot to run tests. Please poke me if you notice anything amiss. Martin -- Juju-dev mailing list Juju-dev@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju-dev
Re: Merge gating for more juju subprojects
On Wed, Mar 25, 2015 at 8:57 AM, Rick Harding rick.hard...@canonical.com
wrote:
If you're using the github lander make sure the user has made it's org
membership public.
kat-co's membership to go-goose is public.
I think we used to have this same issue with juju, but not for a long time.
Rick
On Mar 24, 2015 8:49 PM, Martin Packman martin.pack...@canonical.com
wrote:
On 24/03/2015, Andrew Wilkins andrew.wilk...@canonical.com wrote:
Katherine just tried to $$merge$$ a go-goose branch, and it looks like
the
script is broken: https://github.com/go-goose/goose/pull/3
Tests passed, but merge failed. Ian merged manually.
Hmm, would have been nice to send it through again to see what the
github api was complaining about.
ERROR: Failed to merge: {u'documentation_url':
u'
https://developer.github.com/v3/pulls/#merge-a-pull-request-merge-button
',
u'message': u'Not Found'}
Not a super-useful error back from the merge. Maybe the bot just
doesn't have the right perms currently? Landing in the juju namespace
is working.
Martin
--
Juju-dev mailing list
Juju-dev@lists.ubuntu.com
Modify settings or unsubscribe at:
https://lists.ubuntu.com/mailman/listinfo/juju-dev
--
Juju-dev mailing list
Juju-dev@lists.ubuntu.com
Modify settings or unsubscribe at:
https://lists.ubuntu.com/mailman/listinfo/juju-dev
--
Juju-dev mailing list
Juju-dev@lists.ubuntu.com
Modify settings or unsubscribe at:
https://lists.ubuntu.com/mailman/listinfo/juju-dev
Re: Merge gating for more juju subprojects
On 24/03/2015, Andrew Wilkins andrew.wilk...@canonical.com wrote:
Katherine just tried to $$merge$$ a go-goose branch, and it looks like the
script is broken: https://github.com/go-goose/goose/pull/3
Tests passed, but merge failed. Ian merged manually.
Hmm, would have been nice to send it through again to see what the
github api was complaining about.
ERROR: Failed to merge: {u'documentation_url':
u'https://developer.github.com/v3/pulls/#merge-a-pull-request-merge-button',
u'message': u'Not Found'}
Not a super-useful error back from the merge. Maybe the bot just
doesn't have the right perms currently? Landing in the juju namespace
is working.
Martin
--
Juju-dev mailing list
Juju-dev@lists.ubuntu.com
Modify settings or unsubscribe at:
https://lists.ubuntu.com/mailman/listinfo/juju-dev
Re: Merge gating for more juju subprojects
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Thanks for doing this Martin! I can't wait to try it out next week :) Cheers, Dimiter On 14.03.2015 00:01, Martin Packman wrote: I've put up a gating job for goose on our jenkins slave for juju: http://juju-ci.vapour.ws/job/github-merge-goose/ It will likely need some more work, but I fake-landed Katherine's proposed branch and it passed. The switch over steps are disabling direct landing for most/all contributers and getting everyone using $$merge$$ as with juju. Many of the other juju subprojects are also suitable for sending through automated unit tests before landing, and I can easily make a whole bunch more jobs for whichever packages we want to gate landing on. There are a few caveats: * There isn't proper isolation with lxc yet, so test suites that do dodgy things are still an issue. * Most packages don't use dependencies.tsv so the deps are tied to the merge job currently. * Anything that needs a large external dependency like mongo isn't catered for at the moment. That said, if there are any packages you think we should *not* gate landings on their test suite passing yet, please say now. Thanks! Martin - -- Dimiter Naydenov dimiter.nayde...@canonical.com Juju Core Sapphire team http://juju.ubuntu.com -BEGIN PGP SIGNATURE- Version: GnuPG v1 iQEcBAEBAgAGBQJVBDvUAAoJENzxV2TbLzHwSIAH/jmgSDXGPnW1xn+G3r0oox5h kKVdcJMDWWyA4HpSowPPPVD2gXM7XEGBb/9/kLfrcAx6g80XVE3S/O4R3wQ632ub 7K/hWdaH8On0mj/W931WGN4acAHqFUoyYBX2c/zyU07kdGTH3ztl37R3se6JO0rt ou1DlC0Sl1L5wTrN2j7f7Dmn7+SNHxn3YfZxHSaqY861sCuALBavQniLD3bFF2xe wwbit6RyimhEHPFqYrNF2+3oDQsMc+bCWULr7W4y14U8H6sA4fT9bRNnoVER74Vk OChNLJtcaShr51bAKRcUjz5pRe28u/TidHg/5+qqjburR5PrGOXvSysSVLdPg6g= =E1vJ -END PGP SIGNATURE- -- Juju-dev mailing list Juju-dev@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju-dev
Merge gating for more juju subprojects
I've put up a gating job for goose on our jenkins slave for juju: http://juju-ci.vapour.ws/job/github-merge-goose/ It will likely need some more work, but I fake-landed Katherine's proposed branch and it passed. The switch over steps are disabling direct landing for most/all contributers and getting everyone using $$merge$$ as with juju. Many of the other juju subprojects are also suitable for sending through automated unit tests before landing, and I can easily make a whole bunch more jobs for whichever packages we want to gate landing on. There are a few caveats: * There isn't proper isolation with lxc yet, so test suites that do dodgy things are still an issue. * Most packages don't use dependencies.tsv so the deps are tied to the merge job currently. * Anything that needs a large external dependency like mongo isn't catered for at the moment. That said, if there are any packages you think we should *not* gate landings on their test suite passing yet, please say now. Thanks! Martin -- Juju-dev mailing list Juju-dev@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju-dev
