Re: Organising apiserver facades

[Menno Smits]

On 9 July 2017 at 18:13, roger peppe  wrote:

> Getting all of that facade-specific logic out of the apiserver package
> seems like a great idea to me. I don't think it would take *too* much work
> to factor the helper logic into its own package entirely, with no
> dependencies on the facades.
>



> The client is actually almost there already with its APICaller interface
> as common currency - we should really follow the intent of this old
> comment of William's
> .The
> manifold issue is the interesting one - work out a good solution to that
> and the rest'll come quite quickly, I feel.
>

​FWIW, that list of client side facade factory methods on api.Connection
which shouldn't be there used to be a lot bigger. We've removed about two
thirds of them while converting the machine agent to use the dependency
engine.


>
> It would be marvellous to get parts moving more freely in Juju again -
> losing big fan-out dependency graphs is a good way to move in that
> direction, I'm pretty sure.
>

​+1

- Menno
-- 
Juju-dev mailing list
Juju-dev@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/juju-dev

Re: Organising apiserver facades

[roger peppe]

Getting all of that facade-specific logic out of the apiserver package
seems like a great idea to me. I don't think it would take *too* much work
to factor the helper logic into its own package entirely, with no
dependencies on the facades. The client is actually almost there already
with its APICaller interface as common currency - we should really follow
the intent of this old comment of William's
.The
manifold issue is the interesting one - work out a good solution to that
and the rest'll come quite quickly, I feel.

It would be marvellous to get parts moving more freely in Juju again -
losing big fan-out dependency graphs is a good way to move in that
direction, I'm pretty sure.

  rog.


On 6 July 2017 at 10:55, Andrew Wilkins 
wrote:

> The juju/apiserver package currently has a whole lot of facade packages
> within it, as well as some other packages related to authentication,
> logging, and other bits and bobs. I find it difficult to navigate and tell
> what's what a lot of the time.
>
> I'd like to move the apiserver facade packages into a common "facades"
> sub-directory:
>   apiserver/facades/application
>   apiserver/facades/client
>   apiserver/facades/controller
>   etc.
>
> Any objections? Or alternative suggestions?
>
> Cheers,
> Andrew
>
> --
> Juju-dev mailing list
> Juju-dev@lists.ubuntu.com
> Modify settings or unsubscribe at: https://lists.ubuntu.com/
> mailman/listinfo/juju-dev
>
>
-- 
Juju-dev mailing list
Juju-dev@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/juju-dev

Re: Organising apiserver facades

[Menno Smits]

+1

This helps us get to towards the requested feature of having client and
agent facades served from different network spaces.

Having controller agent facades only served on localhost would also be nice
from a security perspective.

On 7 Jul 2017 11:17 am, "Andrew Wilkins" 
wrote:

> On Thu, Jul 6, 2017 at 7:09 PM John Meinel  wrote:
>
>> I'd really like to see us split apart the facades-by-purpose. So we'd
>> collect the facades for Agents separately from facades for Users (and
>> possibly also facades for Controller).
>> I'm not sure if moving things just into 'facades' just moves the problem
>> around and leaves us with just a *different* directory that is a bit
>> cluttered.  But I'm +1 on things that would help organize the layout.
>>
>
> Cool. I was considering controller vs. agent already, separating client
> off sounds good to me too. I'll send a PR soon.
>
>
>> John
>> =:->
>>
>> On Thu, Jul 6, 2017 at 1:55 PM, Andrew Wilkins <
>> andrew.wilk...@canonical.com> wrote:
>>
>>> The juju/apiserver package currently has a whole lot of facade packages
>>> within it, as well as some other packages related to authentication,
>>> logging, and other bits and bobs. I find it difficult to navigate and tell
>>> what's what a lot of the time.
>>>
>>> I'd like to move the apiserver facade packages into a common "facades"
>>> sub-directory:
>>>   apiserver/facades/application
>>>   apiserver/facades/client
>>>   apiserver/facades/controller
>>>   etc.
>>>
>>> Any objections? Or alternative suggestions?
>>>
>>> Cheers,
>>> Andrew
>>>
>>> --
>>> Juju-dev mailing list
>>> Juju-dev@lists.ubuntu.com
>>> Modify settings or unsubscribe at: https://lists.ubuntu.com/
>>> mailman/listinfo/juju-dev
>>>
>>>
> --
> Juju-dev mailing list
> Juju-dev@lists.ubuntu.com
> Modify settings or unsubscribe at: https://lists.ubuntu.com/
> mailman/listinfo/juju-dev
>
>
-- 
Juju-dev mailing list
Juju-dev@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/juju-dev

Re: Organising apiserver facades

[Andrew Wilkins]

On Thu, Jul 6, 2017 at 7:09 PM John Meinel  wrote:

> I'd really like to see us split apart the facades-by-purpose. So we'd
> collect the facades for Agents separately from facades for Users (and
> possibly also facades for Controller).
> I'm not sure if moving things just into 'facades' just moves the problem
> around and leaves us with just a *different* directory that is a bit
> cluttered.  But I'm +1 on things that would help organize the layout.
>

Cool. I was considering controller vs. agent already, separating client off
sounds good to me too. I'll send a PR soon.


> John
> =:->
>
> On Thu, Jul 6, 2017 at 1:55 PM, Andrew Wilkins <
> andrew.wilk...@canonical.com> wrote:
>
>> The juju/apiserver package currently has a whole lot of facade packages
>> within it, as well as some other packages related to authentication,
>> logging, and other bits and bobs. I find it difficult to navigate and tell
>> what's what a lot of the time.
>>
>> I'd like to move the apiserver facade packages into a common "facades"
>> sub-directory:
>>   apiserver/facades/application
>>   apiserver/facades/client
>>   apiserver/facades/controller
>>   etc.
>>
>> Any objections? Or alternative suggestions?
>>
>> Cheers,
>> Andrew
>>
>> --
>> Juju-dev mailing list
>> Juju-dev@lists.ubuntu.com
>> Modify settings or unsubscribe at:
>> https://lists.ubuntu.com/mailman/listinfo/juju-dev
>>
>>
-- 
Juju-dev mailing list
Juju-dev@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/juju-dev

Re: Organising apiserver facades

[Tim Penhey]

I agree with John. Having the agent facades separate from the client
facades would also be good.

Tim

On 06/07/17 23:09, John Meinel wrote:
> I'd really like to see us split apart the facades-by-purpose. So we'd
> collect the facades for Agents separately from facades for Users (and
> possibly also facades for Controller).
> I'm not sure if moving things just into 'facades' just moves the problem
> around and leaves us with just a *different* directory that is a bit
> cluttered.  But I'm +1 on things that would help organize the layout.
> 
> John
> =:->
> 
> On Thu, Jul 6, 2017 at 1:55 PM, Andrew Wilkins
> > wrote:
> 
> The juju/apiserver package currently has a whole lot of facade
> packages within it, as well as some other packages related to
> authentication, logging, and other bits and bobs. I find it
> difficult to navigate and tell what's what a lot of the time.
> 
> I'd like to move the apiserver facade packages into a common
> "facades" sub-directory:
>   apiserver/facades/application
>   apiserver/facades/client
>   apiserver/facades/controller
>   etc.
> 
> Any objections? Or alternative suggestions?
> 
> Cheers,
> Andrew
> 
> --
> Juju-dev mailing list
> Juju-dev@lists.ubuntu.com 
> Modify settings or unsubscribe at:
> https://lists.ubuntu.com/mailman/listinfo/juju-dev
> 
> 
> 
> 
> 

-- 
Juju-dev mailing list
Juju-dev@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/juju-dev

Re: Organising apiserver facades

[John Meinel]

I'd really like to see us split apart the facades-by-purpose. So we'd
collect the facades for Agents separately from facades for Users (and
possibly also facades for Controller).
I'm not sure if moving things just into 'facades' just moves the problem
around and leaves us with just a *different* directory that is a bit
cluttered.  But I'm +1 on things that would help organize the layout.

John
=:->

On Thu, Jul 6, 2017 at 1:55 PM, Andrew Wilkins  wrote:

> The juju/apiserver package currently has a whole lot of facade packages
> within it, as well as some other packages related to authentication,
> logging, and other bits and bobs. I find it difficult to navigate and tell
> what's what a lot of the time.
>
> I'd like to move the apiserver facade packages into a common "facades"
> sub-directory:
>   apiserver/facades/application
>   apiserver/facades/client
>   apiserver/facades/controller
>   etc.
>
> Any objections? Or alternative suggestions?
>
> Cheers,
> Andrew
>
> --
> Juju-dev mailing list
> Juju-dev@lists.ubuntu.com
> Modify settings or unsubscribe at: https://lists.ubuntu.com/
> mailman/listinfo/juju-dev
>
>
-- 
Juju-dev mailing list
Juju-dev@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/juju-dev

Organising apiserver facades

[Andrew Wilkins]

The juju/apiserver package currently has a whole lot of facade packages
within it, as well as some other packages related to authentication,
logging, and other bits and bobs. I find it difficult to navigate and tell
what's what a lot of the time.

I'd like to move the apiserver facade packages into a common "facades"
sub-directory:
  apiserver/facades/application
  apiserver/facades/client
  apiserver/facades/controller
  etc.

Any objections? Or alternative suggestions?

Cheers,
Andrew
-- 
Juju-dev mailing list
Juju-dev@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/juju-dev