Re: Reserved actions
I've created this issue, and will make sure it lands in time for Xenial. https://github.com/juju/charm-tools/issues/161 On Tue, Mar 29, 2016 at 1:55 AM Rick Hardingwrote: > +1 to reserving the juju* space just as we do with relations and such. > > On Mon, Mar 28, 2016 at 10:12 PM Andrew Wilkins < > andrew.wilk...@canonical.com> wrote: > >> On Tue, Mar 29, 2016 at 10:03 AM Marco Ceppi >> wrote: >> >>> On Mon, Mar 28, 2016 at 9:49 PM Andrew Wilkins < >>> andrew.wilk...@canonical.com> wrote: >>> Hi, There's a code review in progress (http://reviews.vapour.ws/r/4286/) that will introduce a predefined action, "juju-run", which is part of the replacement for the current SSH-based juju-run. >>> >>> This is interesting. What's the semantics for this? How does juju-run >>> action work for machine level items? >>> >> >> From the end-user perspective, juju run should work just the same as >> before. There will be a machine-level worker in Juju that will initially >> handle only juju-run actions. It's not expected that you'll use juju-run >> actions directly, but I don't think there's anything stopping you. >> >> This means that "juju-run" will no longer be a valid action name for use in a charm. This may come up again in the future, so we think it would be prudent to reserve a namespace for additional predefined actions. The most straightforward thing to do would be to reserve the "juju-" prefix, like we do for relations. >>> >>> This seems fine, we'll add "juju-run" as a blacklist in charm proof. >>> >> >> If everyone's OK with reserving the "juju-" prefix, I think it would be >> better to blacklist the whole namespace. Nip it in the bud. >> >> >>> Any objections? Does anyone have any actions using the "juju-" prefix already? >>> >>> I don't believe so, I'l do a quick search in the charm store though to >>> verify >>> >>> Cheers, Andrew >>> -- Juju-dev mailing list Juju-dev@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju-dev >>> -- >> Juju-dev mailing list >> Juju-dev@lists.ubuntu.com >> Modify settings or unsubscribe at: >> https://lists.ubuntu.com/mailman/listinfo/juju-dev >> > -- Juju-dev mailing list Juju-dev@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju-dev
Re: Reserved actions
+1 to reserving the juju* space just as we do with relations and such. On Mon, Mar 28, 2016 at 10:12 PM Andrew Wilkins < andrew.wilk...@canonical.com> wrote: > On Tue, Mar 29, 2016 at 10:03 AM Marco Ceppi> wrote: > >> On Mon, Mar 28, 2016 at 9:49 PM Andrew Wilkins < >> andrew.wilk...@canonical.com> wrote: >> >>> Hi, >>> >>> There's a code review in progress (http://reviews.vapour.ws/r/4286/) >>> that will introduce a predefined action, "juju-run", which is part of the >>> replacement for the current SSH-based juju-run. >>> >> >> This is interesting. What's the semantics for this? How does juju-run >> action work for machine level items? >> > > From the end-user perspective, juju run should work just the same as > before. There will be a machine-level worker in Juju that will initially > handle only juju-run actions. It's not expected that you'll use juju-run > actions directly, but I don't think there's anything stopping you. > > This means that "juju-run" will no longer be a valid action name for use >>> in a charm. This may come up again in the future, so we think it would be >>> prudent to reserve a namespace for additional predefined actions. The most >>> straightforward thing to do would be to reserve the "juju-" prefix, like we >>> do for relations. >>> >> >> This seems fine, we'll add "juju-run" as a blacklist in charm proof. >> > > If everyone's OK with reserving the "juju-" prefix, I think it would be > better to blacklist the whole namespace. Nip it in the bud. > > >> Any objections? Does anyone have any actions using the "juju-" prefix >>> already? >>> >> >> I don't believe so, I'l do a quick search in the charm store though to >> verify >> >> >>> Cheers, >>> Andrew >>> >> -- >>> Juju-dev mailing list >>> Juju-dev@lists.ubuntu.com >>> Modify settings or unsubscribe at: >>> https://lists.ubuntu.com/mailman/listinfo/juju-dev >>> >> -- > Juju-dev mailing list > Juju-dev@lists.ubuntu.com > Modify settings or unsubscribe at: > https://lists.ubuntu.com/mailman/listinfo/juju-dev > -- Juju-dev mailing list Juju-dev@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju-dev
Re: Reserved actions
On Mon, Mar 28, 2016 at 9:49 PM Andrew Wilkinswrote: > Hi, > > There's a code review in progress (http://reviews.vapour.ws/r/4286/) that > will introduce a predefined action, "juju-run", which is part of the > replacement for the current SSH-based juju-run. > This is interesting. What's the semantics for this? How does juju-run action work for machine level items? This means that "juju-run" will no longer be a valid action name for use in > a charm. This may come up again in the future, so we think it would be > prudent to reserve a namespace for additional predefined actions. The most > straightforward thing to do would be to reserve the "juju-" prefix, like we > do for relations. > This seems fine, we'll add "juju-run" as a blacklist in charm proof. Any objections? Does anyone have any actions using the "juju-" prefix > already? > I don't believe so, I'l do a quick search in the charm store though to verify > Cheers, > Andrew > -- > Juju-dev mailing list > Juju-dev@lists.ubuntu.com > Modify settings or unsubscribe at: > https://lists.ubuntu.com/mailman/listinfo/juju-dev > -- Juju-dev mailing list Juju-dev@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju-dev