Re: reviewboard update
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 15.11.2014 07:07, Eric Snow wrote: FYI, I was able to solve 3 reviewboard-github integration issues today: 1. pull requests for branches other than master now work (e.g. 1.21 backports) 2. no more hitting rate limits (5000 requests/hour limit instead of 60) 3. pull request bodies now get updated with a link to the new review request If you have any trouble with any of these please let me know. Thanks! -eric Great job Eric! I can confirm RB diffs for backports to 1.21 get generated correctly now, and the PR description is updated to include a link to the RB diff. There's one issue however -- the link in the PR is https://reviews.vapour.ws/r/id, rather than http://..;, which cause some problems: 1. The browser displays The site's security certificate is not trusted, so I need to either add an exception or change the URL to use http instead. 2. If you do add an exception try to review and click Ship It!, it's not taking effect (Michael had that issue with one of my reviews). So you *need* to use the http URL for the Ship It! to work. It would be nice to fix this :) Thanks, - -- Dimiter Naydenov dimiter.nayde...@canonical.com juju-core team -BEGIN PGP SIGNATURE- Version: GnuPG v1 iQEcBAEBAgAGBQJUaeWaAAoJENzxV2TbLzHw2kcH/iddKLRScZFgBue9RqcEr5DU XrsSin07R1SrrD7xK/PH9z8ONGCVcXeZyAG+hkZiIu7cmL69pFs/ooOuLPZRHuSs ZmEGi27WMX9Aem4RkJpgjet1xMW1eOAeSYgSHeaqPIzSPWwArl6HedUw0V40/etW 3MJJPQw0FpCl6iEqqJtq85s+Ngs8n58Dk0dAQt7yVKQ1xovoognWwdGrTcio2NIZ y5dDM1c+1OJfkRkZDMUAQpJBq45uit29kDc9XAgHUlWZf/1tXD8SLslLb9Wiz7Us b+fQaP+2L+JjnVdN1gObkhMUF67rJceX1Y5djiEubAp6/RTKaMsHuEZT5O2zERM= =kGql -END PGP SIGNATURE- -- Juju-dev mailing list Juju-dev@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju-dev
Re: reviewboard update
On Mon, Nov 17, 2014 at 5:10 AM, Dimiter Naydenov dimiter.nayde...@canonical.com wrote: I can confirm RB diffs for backports to 1.21 get generated correctly now, and the PR description is updated to include a link to the RB diff. Thanks for reporting on this. There's one issue however -- the link in the PR is https://reviews.vapour.ws/r/id, rather than http://..;, which cause some problems: I've switched it to HTTP. -eric -- Juju-dev mailing list Juju-dev@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju-dev
Re: reviewboard update
FWIW, I'd rather we used HTTPS and just fixed whatever issues we had with Ship It, etc. But I'm certainly happiest just to see it working. John =:- On Mon, Nov 17, 2014 at 6:55 PM, Eric Snow eric.s...@canonical.com wrote: On Mon, Nov 17, 2014 at 5:10 AM, Dimiter Naydenov dimiter.nayde...@canonical.com wrote: I can confirm RB diffs for backports to 1.21 get generated correctly now, and the PR description is updated to include a link to the RB diff. Thanks for reporting on this. There's one issue however -- the link in the PR is https://reviews.vapour.ws/r/id, rather than http://..;, which cause some problems: I've switched it to HTTP. -eric -- Juju-dev mailing list Juju-dev@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju-dev -- Juju-dev mailing list Juju-dev@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju-dev
Re: reviewboard update
Awesome, nice work! On Nov 15, 2014 12:07 AM, Eric Snow eric.s...@canonical.com wrote: FYI, I was able to solve 3 reviewboard-github integration issues today: 1. pull requests for branches other than master now work (e.g. 1.21 backports) 2. no more hitting rate limits (5000 requests/hour limit instead of 60) 3. pull request bodies now get updated with a link to the new review request If you have any trouble with any of these please let me know. Thanks! -eric -- Juju-dev mailing list Juju-dev@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju-dev -- Juju-dev mailing list Juju-dev@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju-dev
