Re: developer commands

2017-08-28 Thread Tim Penhey 
I don't think the YAML format for status should be the serialized model
description as it holds more info, and not all relevant for status.

dump-model was originally used to test export code.

dump-db was used to get access to the contents of the db without going
through mongo shell.

Both very dev focused, and both only usable by admins.

Tim

On 29/08/17 13:11, Andrew Wilkins wrote:
> On Mon, Aug 28, 2017 at 5:17 PM Tim Penhey <tim.pen...@canonical.com
> <mailto:tim.pen...@canonical.com>> wrote:
> 
> FYI, the developer commands were originally designed like the controller
> commands.
> 
> You don't say "juju destroy-model -m foo".
> 
> 
> I think that holds for "dump-model", but I'm not so sure about
> "dump-db". It feels natural enough to me to say "juju dump-db -m foo",
> or "juju dump-db".
> 
> I'm wondering about the future of "dump-model". Since you've been
> looking at using the model description to feed "juju status", I wonder
> if it wouldn't make sense to update the "juju status" YAML format to be
> exactly the model description. Then "dump-model" becomes redundant. We'd
> have to make it an option, though, because backwards compatibility.
> 
> Cheers,
> Andrew
>  
> 
> Tim
> 
> On 28/08/17 19:48, Anastasia Macmood wrote:
> > Hi
> >
> > Just a quick note for developers that use developer commands.
> >
> > 'juju dump-model' and 'juju dump-db' are changing on develop tip [1],
> > from 2.3.x.
> > These commands are now fully-fledged model commands as they were
> > originally designed.
> > This means that they will now accept model name as an option
> instead of
> > as a positional argument.
> >
> > i.e.
> > 'juju dump-model -m modelName' NOT 'juju dump-model modelName'
> > 'juju dump-db -m modelName' NOT 'juju dump-db modelName'
> >
> > Happy juju-ing!
> >
> > Sincerely Yours,
> > Anastasia
> >
> > [1]
> > https://github.com/juju/juju/pull/7797
> >
> >
> 
> --
> Juju-dev mailing list
> Juju-dev@lists.ubuntu.com <mailto:Juju-dev@lists.ubuntu.com>
> Modify settings or unsubscribe at:
> https://lists.ubuntu.com/mailman/listinfo/juju-dev
> 

-- 
Juju-dev mailing list
Juju-dev@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/juju-dev

Re: developer commands

2017-08-28 Thread Andrew Wilkins 
On Mon, Aug 28, 2017 at 5:17 PM Tim Penhey <tim.pen...@canonical.com> wrote:

> FYI, the developer commands were originally designed like the controller
> commands.
>
> You don't say "juju destroy-model -m foo".
>

I think that holds for "dump-model", but I'm not so sure about "dump-db".
It feels natural enough to me to say "juju dump-db -m foo", or "juju
dump-db".

I'm wondering about the future of "dump-model". Since you've been looking
at using the model description to feed "juju status", I wonder if it
wouldn't make sense to update the "juju status" YAML format to be exactly
the model description. Then "dump-model" becomes redundant. We'd have to
make it an option, though, because backwards compatibility.

Cheers,
Andrew


> Tim
>
> On 28/08/17 19:48, Anastasia Macmood wrote:
> > Hi
> >
> > Just a quick note for developers that use developer commands.
> >
> > 'juju dump-model' and 'juju dump-db' are changing on develop tip [1],
> > from 2.3.x.
> > These commands are now fully-fledged model commands as they were
> > originally designed.
> > This means that they will now accept model name as an option instead of
> > as a positional argument.
> >
> > i.e.
> > 'juju dump-model -m modelName' NOT 'juju dump-model modelName'
> > 'juju dump-db -m modelName' NOT 'juju dump-db modelName'
> >
> > Happy juju-ing!
> >
> > Sincerely Yours,
> > Anastasia
> >
> > [1]
> > https://github.com/juju/juju/pull/7797
> >
> >
>
> --
> Juju-dev mailing list
> Juju-dev@lists.ubuntu.com
> Modify settings or unsubscribe at:
> https://lists.ubuntu.com/mailman/listinfo/juju-dev
>
-- 
Juju-dev mailing list
Juju-dev@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/juju-dev

Re: developer commands

2017-08-28 Thread Anastasia Macmood 
Furthermore, if you are seeing any problems with these commands or if
you *think* that they no longer behave as per your expectations, let me
know :D


On 28/08/17 21:18, Anastasia Macmood wrote:
> Tim,
>
> Completely agree :)
>
> By changing where these commands fit within command infrastructure, they
> gained access to some useful methods. Thus, eliminating code duplication
> and inconsistencies.
>
> The versions of command, acting as "controller" type commands, that take
> no arguments, indeed exist. Both commands can be used without model
> name, i.e. 'juju dump-model' and 'juju dump-db' are fully formed. These
> versions still work as expected, have not changed and are, in fact,
> verified by existing feature tests.
>
> The change that I have brought up is only applicable to the versions of
> commands that were passing in a model name.
>
> Anastasia
>
>
> On 28/08/17 19:16, Tim Penhey wrote:
>> FYI, the developer commands were originally designed like the controller
>> commands.
>>
>> You don't say "juju destroy-model -m foo".
>>
>> Tim
>>
>> On 28/08/17 19:48, Anastasia Macmood wrote:
>>> Hi
>>>
>>> Just a quick note for developers that use developer commands.
>>>
>>> 'juju dump-model' and 'juju dump-db' are changing on develop tip [1],
>>> from 2.3.x.
>>> These commands are now fully-fledged model commands as they were
>>> originally designed.
>>> This means that they will now accept model name as an option instead of
>>> as a positional argument.
>>>
>>> i.e.
>>> 'juju dump-model -m modelName' NOT 'juju dump-model modelName'
>>> 'juju dump-db -m modelName' NOT 'juju dump-db modelName'
>>>
>>> Happy juju-ing!
>>>
>>> Sincerely Yours,
>>> Anastasia
>>>
>>> [1]
>>> https://github.com/juju/juju/pull/7797
>>>
>>>
>


-- 
Juju-dev mailing list
Juju-dev@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/juju-dev

Re: developer commands

2017-08-28 Thread Anastasia Macmood 
Tim,

Completely agree :)

By changing where these commands fit within command infrastructure, they
gained access to some useful methods. Thus, eliminating code duplication
and inconsistencies.

The versions of command, acting as "controller" type commands, that take
no arguments, indeed exist. Both commands can be used without model
name, i.e. 'juju dump-model' and 'juju dump-db' are fully formed. These
versions still work as expected, have not changed and are, in fact,
verified by existing feature tests.

The change that I have brought up is only applicable to the versions of
commands that were passing in a model name.

Anastasia


On 28/08/17 19:16, Tim Penhey wrote:
> FYI, the developer commands were originally designed like the controller
> commands.
>
> You don't say "juju destroy-model -m foo".
>
> Tim
>
> On 28/08/17 19:48, Anastasia Macmood wrote:
>> Hi
>>
>> Just a quick note for developers that use developer commands.
>>
>> 'juju dump-model' and 'juju dump-db' are changing on develop tip [1],
>> from 2.3.x.
>> These commands are now fully-fledged model commands as they were
>> originally designed.
>> This means that they will now accept model name as an option instead of
>> as a positional argument.
>>
>> i.e.
>> 'juju dump-model -m modelName' NOT 'juju dump-model modelName'
>> 'juju dump-db -m modelName' NOT 'juju dump-db modelName'
>>
>> Happy juju-ing!
>>
>> Sincerely Yours,
>> Anastasia
>>
>> [1]
>> https://github.com/juju/juju/pull/7797
>>
>>



-- 
Juju-dev mailing list
Juju-dev@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/juju-dev

Re: developer commands

2017-08-28 Thread Tim Penhey 
FYI, the developer commands were originally designed like the controller
commands.

You don't say "juju destroy-model -m foo".

Tim

On 28/08/17 19:48, Anastasia Macmood wrote:
> Hi
> 
> Just a quick note for developers that use developer commands.
> 
> 'juju dump-model' and 'juju dump-db' are changing on develop tip [1],
> from 2.3.x.
> These commands are now fully-fledged model commands as they were
> originally designed.
> This means that they will now accept model name as an option instead of
> as a positional argument.
> 
> i.e.
> 'juju dump-model -m modelName' NOT 'juju dump-model modelName'
> 'juju dump-db -m modelName' NOT 'juju dump-db modelName'
> 
> Happy juju-ing!
> 
> Sincerely Yours,
> Anastasia
> 
> [1]
> https://github.com/juju/juju/pull/7797
> 
> 

-- 
Juju-dev mailing list
Juju-dev@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/juju-dev

Fwd: developer commands

2017-08-28 Thread Anastasia Macmood 
-- Here is un-encrypted version \o/ --

Hi

Just a quick note for developers that use developer commands.

'juju dump-model' and 'juju dump-db' are changing on develop tip [1],
from 2.3.x.
These commands are now fully-fledged model commands as they were
originally designed.
This means that they will now accept model name as an option instead of
as a positional argument.

i.e.
'juju dump-model -m modelName' NOT 'juju dump-model modelName'
'juju dump-db -m modelName' NOT 'juju dump-db modelName'

Happy juju-ing!

Sincerely Yours,
Anastasia

[1]
https://github.com/juju/juju/pull/7797


-- 
Juju-dev mailing list
Juju-dev@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/juju-dev

Re: developer commands

2017-08-28 Thread John Meinel 
I don't think you intended to send the email as PGP encrypted.

John
=:->


2017-08-28 12:06 GMT+04:00 Tim Penhey :

> -BEGIN PGP MESSAGE-
> Version: GnuPG v2
>
> hQIMA233D38ktbXXAQ/+P+Wl6YvVE3PVo1tsN/ynVPSeR5Xu3SfKLoRmXvxM0om/
> /LXYkelYeD5xuJCuLP87gNqiDqJnDZi4I0kOWkLjeG9xvAAJY/57tZLbv29quyKZ
> 9qVAKXbaCL8bsqHOZ9hsecpq8Bdkhu0P0J/VW0B/YYr3x8O3gggxYxD2EJD/+M4w
> Z0TJw6CYjEVy4nZ4dtn7TkBd/g68hcjU367VZLHdumxaCieoPm0Yq8jILP1FpfxQ
> DNyKs3PwPEtJJz1PAvq/pG01GeAiO+9+xl12KdCUDGlgUE7ph+U1Uw7On12zS+n1
> 1UzhyNxGD3lrjvJsM11pSi2R84o3ad+MGF3zCNbXowp6QowUytK5/xquFOqtBqze
> +yQ/3GcVaHnRnSHpxZt68rfq5DGCTqP233zKT11qo/Hxho3OmVP3tQpNh4Y6b2J6
> 6Cz7bH5L8MxaZexBEvMZcEfFMedLylVncxZeuvsGf1dSqGirIN4toejt69TUrD3C
> uF6aDySX5ruObPf7vkzzKXkXXN2qM9tXx9iMLaCRyYPCxt2lvGJYfbQtOupo4df/
> DgjjwGiXzjrUmAGpU1A6vCIotIw7pOsfVdlVicYRmkHoyShOWWv5oA6myqtcgmsO
> wGdAA2ZubE3p/WFL0Qfl8bPNGy4Yh22QdAAQsCLbhbWm0Q2LNDVqaSO3ODEBGf+F
> AQ4DdFn2rLtx3aMQA/4ncKGDjs/kcp1dxHM6FJJ8hu7vsMJxTZLdLWmx7ZIeBJNw
> 5RrnB0BAid03DHyPF8dMi+kgfiD1dwFMbBW8FTsKv1muHmjdePj27I/4K/5F7s08
> v1JuPAt0neI94Xkyx18+aih3gnmC2TCYgka9LhusDY2otlr1X1//vgAZj33OLgP+
> JNmQeq3LGP9Y10wHbnXcWQ5TTKD2rGDOLItNAYyVKTg6erHRR+8NlWLYz32XDN1D
> eITHN7BnvhbMcaiD+pQsU6J3zoPky1ZkW8GN4o8/lrOZW1zUnUnsl0RQmplNIKi1
> Zarch+m8+I8dmS4R9pdk69Zc3sAl114FMhp3C8bmsXDS6QEwYFfG7vFFN8kPPx0f
> MN2aj6SBCAq33DDWZRcUiqdTtxRaf6IFCcLZmYFNuEc4dloONE7zin0xUoGNmhoV
> m+CNwoeHvP72xcTclIqXwvH90HI1K8eSVE9PmvTSY/QW9fxv+Wp1pQSowbJmfoA1
> qQX1wU90tlEfnM9sYtr6ggjN0ee2WyhOc63p7U7W9L3r13D/nZggLMOzPW5krz5C
> K+/92ZGT7Eo8q8PQQzZvBrx4WMGDth/AGMBsRbf0LsCCzWcjKhMuKzzfxDbbgNc9
> EjPl6OzzjYnkuToXgCkkO9NrUN9wcpricMP54OFoK7eE+s085/oX1EYsDM/dyHTB
> TjhFbMUqyIvNM6muX3mzrEIokWIjGZEzuPQC2gu1+QMMPgU/BjN+9UuDsD/uT9pu
> s9/VwW9MKxZLQnNbRVCH0Ei134+MN4YSrSGuVuBTLObDHMp7XnFy7nGfVduyf4b3
> HuxPGIMwilVpM9gpC2puEqriUuxB/uw2PxBIVIhIyRgnqUB128XIIDJpIXzLOAlC
> ucM0Y2JB4/DNAiMUx+EeDT0lihu5xG6oigKTdI9NilAM03jEc4namoEJJtOAiMe/
> j14wm8VqBk0GvZ99EGnvOArV2MKZDziKyZdKTNtqyKLuyC4wI28mfmzfq1kd9Mxw
> MaYNbcn4dpTKZjQn0f5IF9+jwKh7YY6FuXqvFNpKkHBSOxu0ognj4oDej/qsJSz8
> oCW2rRfLwPzt9hGvM9VX62TGoCiR4TI488NE/0VlVZ/Bk0ehqg6casaUZxyfuFQO
> X8k5mNfOy2b+beq7CSo4sm9RiuGyOUBxMP4ur0hyT7xi8CQgB2KWBlsHn9k5H4Cu
> a/qB798tKrbkd0hn7uXIeSPcenBWF8LPGeIvQtHQ3ZJgmjxBwxsFLELioGgstpCl
> 93/Ny9K8mxNcEcAmj866g03Z5dBqsc9T+lg6viDMMKnQmqqlvC5l1VhTLf8D6Jpd
> oiW7M7Q76xi/uR+0m2ofRNf+FRfoOPGMKyXDTWlk1K+YjZp5LixAokgnOWKJeXB0
> rNy9V+E70ijvNtcTVvI5Cp2X7a+2PanCyj/2O37CBsE28TflYS0HMUUGZDmI+JUu
> DGAnEKBxxzEvu4jJ3gg68ipbbQRzr7eKlTc4xAGRZmlJkUloT2tqfp0kEPM=
> =Va56
> -END PGP MESSAGE-
>
> --
> Juju-dev mailing list
> Juju-dev@lists.ubuntu.com
> Modify settings or unsubscribe at: https://lists.ubuntu.com/
> mailman/listinfo/juju-dev
>
>
-- 
Juju-dev mailing list
Juju-dev@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/juju-dev

Re: developer commands

2017-08-28 Thread Tim Penhey 


binMOC2fYDKR9.bin
Description: PGP/MIME version identification


encrypted.asc
Description: OpenPGP encrypted message
-- 
Juju-dev mailing list
Juju-dev@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/juju-dev

developer commands

2017-08-28 Thread Anastasia Macmood 
Hi

Just a quick note for developers that use developer commands.

'juju dump-model' and 'juju dump-db' are changing on develop tip [1],
from 2.3.x.
These commands are now fully-fledged model commands as they were
originally designed.
This means that they will now accept model name as an option instead of
as a positional argument.

i.e.
'juju dump-model -m modelName' NOT 'juju dump-model modelName'
'juju dump-db -m modelName' NOT 'juju dump-db modelName'

Happy juju-ing!

Sincerely Yours,
Anastasia

[1]
https://github.com/juju/juju/pull/7797


-- 
Juju-dev mailing list
Juju-dev@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/juju-dev