Re: [JPP-Devel] General refactoring of OpenJUMP
Hi Benjamin, I've started to build the testing environment a week ago. Let's make a brief summary about what happend since my last post. Documentation was added to the classes and Javadocs and testing results can be generated as html files. Also all needed methods for the tests where arranged in TestTools (buildWorkbench, configurePlugIn, executePlugIn). The mechanics on how to provide configuration values and on how to execute the plugin stayed the same. http://openjump-tools-docs.googlecode.com/git/javadoc/index.html http://openjump-tools-docs.googlecode.com/git/testdoc/report/index.html http://openjump-tools-docs.googlecode.com/git/checkstyle/report/report.html I've also documented/outlined two different types of testable plugins (see also Javadocs for documentation): Nice to see your progress on a unit test framework setting. It would be good if it could help making a better separation between plugin parameters and ui stuff. Have you commit rights on the project's svn ? Michaël ExamplePlugInWithFields: http://goo.gl/sjHUs ExamplePlugInWithDialog: http://goo.gl/KWN06 If something is unclear I could improve the code/comments. It looks very promising so far; next up is implementing test cases for UnionByAttributePlugIn. Repository: https://github.com/hastebrot/openjump-tools-sandbox/ Zipped Eclipse Project: https://github.com/hastebrot/openjump-tools-sandbox/zipball/master Greetings Benjamin -- Write once. Port to many. Get the SDK and tools to simplify cross-platform app development. Create new or port existing apps to sell to consumers worldwide. Explore the Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join http://p.sf.net/sfu/intel-appdev ___ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel -- Write once. Port to many. Get the SDK and tools to simplify cross-platform app development. Create new or port existing apps to sell to consumers worldwide. Explore the Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join http://p.sf.net/sfu/intel-appdev___ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
[JPP-Devel] Cannot open old project file
Hi, New OJ does not open my old project files which I have created in 2009. It is not a problem because I have the corresponding OpenJUMP version in the same zip file. Big advantage from a small footprint. I still wonder what has changed and how the old project files could be edited to be usasable with a fresh OJ. It would be nice to be able to save the project file to that datasource path would be relational to JUMP_HOME or something. That would make it possible to deliver data, project, styles and software all together - unzip and launch and you are ready to work in one minute. You cannot do that with ArcGIS but I guess it might be possible to do with OpenJUMP. It is already possible if operation system gives USB disk the same volume letter in the lottery but that is not always the case and users without admin rights cannot change volume letters at least on Windows. -Jukka Rahkonen- -- Write once. Port to many. Get the SDK and tools to simplify cross-platform app development. Create new or port existing apps to sell to consumers worldwide. Explore the Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join http://p.sf.net/sfu/intel-appdev ___ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
[JPP-Devel] [ jump-pilot-Bugs-3472008 ] AssertionFailedException with two identical attribute name
Bugs item #3472008, was opened at 2012-01-10 13:28 Message generated for change (Tracker Item Submitted) made by michaudm You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=679906aid=3472008group_id=118054 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: OpenJUMP - Menu - Edit Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: michael michaud (michaudm) Assigned to: Nobody/Anonymous (nobody) Summary: AssertionFailedException with two identical attribute name Initial Comment: How can two identical attribute names happen ? - with a sql query : ex. select geom, name, name, name from city (although I don't think a plain table can have duplicate names) - it can be saved/read to/from a shapefile, a jml (with different results !) - feature schema edition tool pevent such a schema edition What happens ? - a AssertionFailedException is thrown by plugins like * combine selected layers * clip map to fence * there are other problems if one try to change an attribute value using its name... What to do ? The minimum would be to throw a clearer message Maybe sufficient, automatic renaming seems a bit dangerous Refusing data loading maybe frustrating (although getting a yellow warning light be useful) Michaël -- You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=679906aid=3472008group_id=118054 -- Write once. Port to many. Get the SDK and tools to simplify cross-platform app development. Create new or port existing apps to sell to consumers worldwide. Explore the Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join http://p.sf.net/sfu/intel-appdev ___ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
Re: [JPP-Devel] General refactoring of OpenJUMP
@Michaël Nice to see your progress on a unit test framework setting. It would be good if it could help making a better separation between plugin parameters and ui stuff. I think the other plugins should be refactored like you already refactored the UnionByAttributePlugIn. TestToolsTest.ExamplePlugInWithFields is how it works with the refactored version and TestToolsTest.ExamplePlugInWithDialog is how it works with the old versoin of UnionByAttributePlugIn. Have you commit rights on the project's svn ? Yes, Stefan already added me to the developers list: https://sourceforge.net/project/memberlist.php?group_id=118054 The question is now, how to add the framework to the repository. Adding it to the svn would be of course the best way to work together. I might create a new branch and add the sourcecode as a new project somewhere. Before that I would change the dependencies from the test/lib directory to the core/lib directory and add core as a project dependency to eclipse. --Benjamin -- Write once. Port to many. Get the SDK and tools to simplify cross-platform app development. Create new or port existing apps to sell to consumers worldwide. Explore the Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join http://p.sf.net/sfu/intel-appdev___ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
Re: [JPP-Devel] General refactoring of OpenJUMP
Hi, Yes, Stefan already added me to the developers list: https://sourceforge.net/project/memberlist.php?group_id=118054 Fine, The question is now, how to add the framework to the repository. Adding it to the svn would be of course the best way to work together. Sure, I might create a new branch and add the sourcecode as a new project somewhere. Before that I would change the dependencies from the test/lib directory to the core/lib directory and add core as a project dependency to eclipse. Wouldn't be enough to add a new package to the source trunk for developpers and to exclude the package for releases, and nightly builds ? Michaël --Benjamin -- Write once. Port to many. Get the SDK and tools to simplify cross-platform app development. Create new or port existing apps to sell to consumers worldwide. Explore the Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join http://p.sf.net/sfu/intel-appdev ___ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel -- Write once. Port to many. Get the SDK and tools to simplify cross-platform app development. Create new or port existing apps to sell to consumers worldwide. Explore the Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join http://p.sf.net/sfu/intel-appdev___ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
[JPP-Devel] [ jump-pilot-Feature Requests-3472020 ] Saving long attribute name into shapefile
Feature Requests item #3472020, was opened at 2012-01-10 14:06 Message generated for change (Tracker Item Submitted) made by michaudm You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=679909aid=3472020group_id=118054 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: File/Data IO Group: None Status: Open Priority: 5 Private: No Submitted By: michael michaud (michaudm) Assigned to: Nobody/Anonymous (nobody) Summary: Saving long attribute name into shapefile Initial Comment: Mail from Jukka related to bug id 3472008 : What might happen when user is saving into shapefile a dataset with attributes like long_attribute_name_01 and long_attribute_name_02? Truncating names to suit the .dbf format would yield to identical names. This is how GDAL behaves: Attribute names can only be up to 10 characters long. Longer names will be silently truncated. This may result in non-unique column names, which will definitely cause problems later. Starting with version 1.7, the OGR Shapefile driver tries to generate unique field names. Successive duplicate field names, including those created by truncation to 10 characters, will be truncated to 8 characters and appended with a serial number from 1 to 99. For example: a → a, a → a_1, A → A_2; abcdefghijk → abcdefghij, abcdefghijkl → abcdefgh_1 Taken from http://gdal.org/ogr/drv_shapefile.html -- You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=679909aid=3472020group_id=118054 -- Write once. Port to many. Get the SDK and tools to simplify cross-platform app development. Create new or port existing apps to sell to consumers worldwide. Explore the Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join http://p.sf.net/sfu/intel-appdev ___ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
Re: [JPP-Devel] [ jump-pilot-Bugs-3472008 ] AssertionFailedException with two identical attribute name
Hi, What might happen when user is saving into shapefile a dataset with attributes like long_attribute_name_01 and long_attribute_name_02? Truncating names to suit the .dbf format would yield to identical names. This is how GDAL behaves: Attribute names can only be up to 10 characters long. Longer names will be silently truncated. This may result in non-unique column names, which will definitely cause problems later. Starting with version 1.7, the OGR Shapefile driver tries to generate unique field names. Successive duplicate field names, including those created by truncation to 10 characters, will be truncated to 8 characters and appended with a serial number from 1 to 99. Yes, this is a good idea. This is also the way short file names are written by windows to follow the old 8.3 convention. Should not be too hard to implement. Michaël For example: a → a, a → a_1, A → A_2; abcdefghijk → abcdefghij, abcdefghijkl → abcdefgh_1 Taken from http://gdal.org/ogr/drv_shapefile.html -Jukka Rahkonen- Lähettäjä: SourceForge.net [nore...@sourceforge.net] Lähetetty: 10. tammikuuta 2012 23:28 Vastaanottaja: SourceForge.net Aihe: [JPP-Devel] [ jump-pilot-Bugs-3472008 ] AssertionFailedException with two identical attribute name Bugs item #3472008, was opened at 2012-01-10 13:28 Message generated for change (Tracker Item Submitted) made by michaudm You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=679906aid=3472008group_id=118054 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: OpenJUMP - Menu - Edit Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: michael michaud (michaudm) Assigned to: Nobody/Anonymous (nobody) Summary: AssertionFailedException with two identical attribute name Initial Comment: How can two identical attribute names happen ? - with a sql query : ex. select geom, name, name, name from city (although I don't think a plain table can have duplicate names) - it can be saved/read to/from a shapefile, a jml (with different results !) - feature schema edition tool pevent such a schema edition What happens ? - a AssertionFailedException is thrown by plugins like * combine selected layers * clip map to fence * there are other problems if one try to change an attribute value using its name... What to do ? The minimum would be to throw a clearer message Maybe sufficient, automatic renaming seems a bit dangerous Refusing data loading maybe frustrating (although getting a yellow warning light be useful) Michaël -- You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=679906aid=3472008group_id=118054 -- Write once. Port to many. Get the SDK and tools to simplify cross-platform app development. Create new or port existing apps to sell to consumers worldwide. Explore the Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join http://p.sf.net/sfu/intel-appdev ___ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel -- Write once. Port to many. Get the SDK and tools to simplify cross-platform app development. Create new or port existing apps to sell to consumers worldwide. Explore the Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join http://p.sf.net/sfu/intel-appdev ___ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel -- Write once. Port to many. Get the SDK and tools to simplify cross-platform app development. Create new or port existing apps to sell to consumers worldwide. Explore the Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join http://p.sf.net/sfu/intel-appdev ___ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
Re: [JPP-Devel] Cannot open old project file
Hi, Hi, New OJ does not open my old project files which I have created in 2009. It is not a problem because I have the corresponding OpenJUMP version in the same zip file. Big advantage from a small footprint. I still wonder what has changed and how the old project files could be edited to be usasable with a fresh OJ. Have you got error messages ? Is it just a matter of unrecognized paths or some incompatible change. Anyway, this would be interesting to gather old projects and to aks benjamin how he would include a unit test to keep sure new version don't break the compatibility :o) It would be nice to be able to save the project file to that datasource path would be relational to JUMP_HOME or something. That would make it possible to deliver data, project, styles and software all together - unzip and launch and you are ready to work in one minute. You cannot do that with ArcGIS but I guess it might be possible to do with OpenJUMP. It is already possible if operation system gives USB disk the same volume letter in the lottery but that is not always the case and users without admin rights cannot change volume letters at least on Windows. Have you ever try update project from cadplan (I think I did not). Maybe a plugin to re-locate a project is a good alternative to an option to record project with relative paths. Michaël -Jukka Rahkonen- -- Write once. Port to many. Get the SDK and tools to simplify cross-platform app development. Create new or port existing apps to sell to consumers worldwide. Explore the Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join http://p.sf.net/sfu/intel-appdev ___ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel -- Write once. Port to many. Get the SDK and tools to simplify cross-platform app development. Create new or port existing apps to sell to consumers worldwide. Explore the Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join http://p.sf.net/sfu/intel-appdev ___ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
Re: [JPP-Devel] General refactoring of OpenJUMP
Wouldn't be enough to add a new package to the source trunk for developpers and to exclude the package for releases, and nightly builds ? Michaël Okay. I will relayout the existing source code to fit into the structure of core/trunk. After that I will create a new branch at svn with the integrated test environment. What are the right commands to create this branch in svn? I last used svn in 2006 or so (I usually use distributed VCS like mercurial and git). --BEnjamin -- Write once. Port to many. Get the SDK and tools to simplify cross-platform app development. Create new or port existing apps to sell to consumers worldwide. Explore the Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join http://p.sf.net/sfu/intel-appdev___ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
Re: [JPP-Devel] General refactoring of OpenJUMP
If we want to directly commit this to trunk without creating a branch, I first need to thunk about possible consequences when we refactor exising code. Stefan maybe has also some ideas about that. 2012/1/10 Benjamin Gudehus hasteb...@googlemail.com Wouldn't be enough to add a new package to the source trunk for developpers and to exclude the package for releases, and nightly builds ? Michaël Okay. I will relayout the existing source code to fit into the structure of core/trunk. After that I will create a new branch at svn with the integrated test environment. What are the right commands to create this branch in svn? I last used svn in 2006 or so (I usually use distributed VCS like mercurial and git). --BEnjamin -- Write once. Port to many. Get the SDK and tools to simplify cross-platform app development. Create new or port existing apps to sell to consumers worldwide. Explore the Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join http://p.sf.net/sfu/intel-appdev___ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
Re: [JPP-Devel] Cannot open old project file
Hi Jukka, I haven't posted for a while, but I'm still listening. Your post reminded me that OJ still doesn't have one of my favorite features in SkyJUMP: the layer file. These are basically project files per layer. They are created when you use the Archive Selected Datasets menu option. It creates a zip file containing all of the selected layers (using their current file format) along with a project file (with the jmp extension) that has the same filename as each archived layer . The zip file can then be used to deliver data along with associated style information to others without any file path problems. The recipient of the archive can choose to open it directly and work on it in-place (all changes will be written back into the zip file), or extract it and Merge the selected layer project files into their current project. This feature has been in use at ISA for many years and we consider it essential to using JUMP to work on projects with multiple people editing at the same time. regards, Larry Becker ISA On Tue, Jan 10, 2012 at 3:17 PM, Rahkonen Jukka jukka.rahko...@mmmtike.fiwrote: Hi, New OJ does not open my old project files which I have created in 2009. It is not a problem because I have the corresponding OpenJUMP version in the same zip file. Big advantage from a small footprint. I still wonder what has changed and how the old project files could be edited to be usasable with a fresh OJ. It would be nice to be able to save the project file to that datasource path would be relational to JUMP_HOME or something. That would make it possible to deliver data, project, styles and software all together - unzip and launch and you are ready to work in one minute. You cannot do that with ArcGIS but I guess it might be possible to do with OpenJUMP. It is already possible if operation system gives USB disk the same volume letter in the lottery but that is not always the case and users without admin rights cannot change volume letters at least on Windows. -Jukka Rahkonen- -- Write once. Port to many. Get the SDK and tools to simplify cross-platform app development. Create new or port existing apps to sell to consumers worldwide. Explore the Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join http://p.sf.net/sfu/intel-appdev ___ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel -- Write once. Port to many. Get the SDK and tools to simplify cross-platform app development. Create new or port existing apps to sell to consumers worldwide. Explore the Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join http://p.sf.net/sfu/intel-appdev___ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
Re: [JPP-Devel] General refactoring of OpenJUMP
Hi, If we want to directly commit this to trunk without creating a branch, I first need to thunk about possible consequences when we refactor exising code. Stefan maybe has also some ideas about that. Right, wait for Stefan's and Ede's advice. It must make use and adoption simple, not more complex ! Michaël 2012/1/10 Benjamin Gudehus hasteb...@googlemail.com mailto:hasteb...@googlemail.com Wouldn't be enough to add a new package to the source trunk for developpers and to exclude the package for releases, and nightly builds ? Michaël Okay. I will relayout the existing source code to fit into the structure of core/trunk. After that I will create a new branch at svn with the integrated test environment. What are the right commands to create this branch in svn? I last used svn in 2006 or so (I usually use distributed VCS like mercurial and git). --BEnjamin -- Write once. Port to many. Get the SDK and tools to simplify cross-platform app development. Create new or port existing apps to sell to consumers worldwide. Explore the Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join http://p.sf.net/sfu/intel-appdev ___ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel -- Write once. Port to many. Get the SDK and tools to simplify cross-platform app development. Create new or port existing apps to sell to consumers worldwide. Explore the Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join http://p.sf.net/sfu/intel-appdev___ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
Re: [JPP-Devel] Cannot open old project file
New OJ does not open my old project files which I have created in 2009. It is not a problem because I have the corresponding OpenJUMP version in the same zip file. Big advantage from a small footprint. I still wonder what has changed and how the old project files could be edited to be usasable with a fresh OJ. Have you got error messages ? Is it just a matter of unrecognized paths or some incompatible change. Anyway, this would be interesting to gather old projects and to aks benjamin how he would include a unit test to keep sure new version don't break the compatibility :o) The test enviroment contains already a function to open files (TestTools.openFile()). I would first look what exceptions will throw when a project could not be loaded. We also could make some assertions on the Task object. That would be the easy part. If this would not fullfill sufficient needs we'll need to test some methods directly. 2012/1/10 Larry Becker becker.la...@gmail.com I haven't posted for a while, but I'm still listening. Your post reminded me that OJ still doesn't have one of my favorite features in SkyJUMP: the layer file. These are basically project files per layer. They are created when you use the Archive Selected Datasets menu option. It creates a zip file containing all of the selected layers (using their current file format) along with a project file (with the jmp extension) that has the same filename as each archived layer . The zip file can then be used to deliver data along with associated style information to others without any file path problems. The recipient of the archive can choose to open it directly and work on it in-place (all changes will be written back into the zip file), or extract it and Merge the selected layer project files into their current project. I also thought about the problems with absolute paths. Maybe we could add both a relative path and an absolute path to the project file. The file on the relative path would tried first and when not found the file on the absolute path would tried to load. This would also keep compatibility to older versions of OpenJUMP. -- Write once. Port to many. Get the SDK and tools to simplify cross-platform app development. Create new or port existing apps to sell to consumers worldwide. Explore the Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join http://p.sf.net/sfu/intel-appdev___ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
