Re: [JPP-Devel] Selectable and Editable menu items won't check on Vista and Win7

2012-04-03 Thread edgar . soldin
actually the observed light blue square background for selected menuitems seems 
to be standard vista+ theme. other native windows applications have the same 
issue. you just have to get used to it. so it's mainly an issue of personal 
preference, but still it was a fun issue to work around.

..ede

On 02.04.2012 20:07, Michaël Michaud wrote:
 Hi,
 
 Nice work Ede, thanks a lot.
 
 Michaël
 On 31.03.2012 16:29, Michaël Michaud wrote:
 Hi,
 we could disable the icons conditionally for windows laf and win7+ as 
 other lafs and platforms are not hit.
 Agree if you do it ;-)
 done

 I will open a bug report which will stay opened as long as the bug is
 not fixed in jre.
 beat you to it ;)

 I had a quick look in the menus and noticed also
 - a icon + check symbol in category context menu (change visibility)
 - a icon + check symbol for View  Edit toolbox menuitem
 I suppose they are also concerned by the bug, which means there are at
 least 4 menu-items to fix.

 it's worked around generically where the menuitems are generated. i also did 
 some housekeeping while at it. here's the commit message

 Revision: 2786

 http://jump-pilot.svn.sourceforge.net/jump-pilot/?rev=2786view=rev
 Author:   edso
 Date: 2012-04-02 13:14:37 + (Mon, 02 Apr 2012)
 Log Message:
 ---
 bugfix:
  http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7122141
  
 http://www.mail-archive.com/jump-pilot-devel@lists.sourceforge.net/msg10601.html

 com.vividsolutions.jump.workbench.ui.plugin.FeatureInstaller
 - unified spaces/tabs, general reformatting
 - privatized internally used behead method
 - deprecated legacy methods addLayerViewMenuItem(), 
 addLayerNameViewMenuItem()
 - added replacement method for deprecated addMainMenuItem to add plain 
 plugins:
 addMainMenuPlugin( PlugIn, menuPath, menuItemName, checkBox, icon, 
 enableCheck, pos),
former changes by michael added methods for JMenuItem and 
 AbstractUiPlugIn only
 - added addMenuItemIcon() method used by all methods that add menu entries 
 to popup/mainmenu
it contains a workaround for the windows laf missing checkmark ticks for 
 checkbox entries on vista and later
 - cleaned up addPopupMenuItem() method that duplicated routines
 - commented (pending deletion) addMainMenuItemWithJava14Fix() methods
classes using the method above modified to use addMainMenuItem()

 ..ede

 --
 This SF email is sponsosred by:
 Try Windows Azure free for 90 days Click Here
 http://p.sf.net/sfu/sfd2d-msazure
 ___
 Jump-pilot-devel mailing list
 Jump-pilot-devel@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel


 
 
 --
 This SF email is sponsosred by:
 Try Windows Azure free for 90 days Click Here 
 http://p.sf.net/sfu/sfd2d-msazure
 ___
 Jump-pilot-devel mailing list
 Jump-pilot-devel@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel

--
Better than sec? Nothing is better than sec when it comes to
monitoring Big Data applications. Try Boundary one-second 
resolution app monitoring today. Free.
http://p.sf.net/sfu/Boundary-dev2dev
___
Jump-pilot-devel mailing list
Jump-pilot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel


Re: [JPP-Devel] Selectable and Editable menu items won't check on Vista and Win7

2012-04-02 Thread edgar . soldin
On 31.03.2012 16:29, Michaël Michaud wrote:
 Hi,
 we could disable the icons conditionally for windows laf and win7+ as other 
 lafs and platforms are not hit.
 Agree if you do it ;-)

done

 I will open a bug report which will stay opened as long as the bug is 
 not fixed in jre.

beat you to it ;)

 I had a quick look in the menus and noticed also
 - a icon + check symbol in category context menu (change visibility)
 - a icon + check symbol for View  Edit toolbox menuitem
 I suppose they are also concerned by the bug, which means there are at 
 least 4 menu-items to fix.
 

it's worked around generically where the menuitems are generated. i also did 
some housekeeping while at it. here's the commit message

Revision: 2786
  http://jump-pilot.svn.sourceforge.net/jump-pilot/?rev=2786view=rev
Author:   edso
Date: 2012-04-02 13:14:37 + (Mon, 02 Apr 2012)
Log Message:
---
bugfix:
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7122141

http://www.mail-archive.com/jump-pilot-devel@lists.sourceforge.net/msg10601.html

com.vividsolutions.jump.workbench.ui.plugin.FeatureInstaller
- unified spaces/tabs, general reformatting
- privatized internally used behead method
- deprecated legacy methods addLayerViewMenuItem(), addLayerNameViewMenuItem()
- added replacement method for deprecated addMainMenuItem to add plain plugins: 
   addMainMenuPlugin( PlugIn, menuPath, menuItemName, checkBox, icon, 
enableCheck, pos), 
  former changes by michael added methods for JMenuItem and AbstractUiPlugIn 
only
- added addMenuItemIcon() method used by all methods that add menu entries to 
popup/mainmenu
  it contains a workaround for the windows laf missing checkmark ticks for 
checkbox entries on vista and later
- cleaned up addPopupMenuItem() method that duplicated routines
- commented (pending deletion) addMainMenuItemWithJava14Fix() methods
  classes using the method above modified to use addMainMenuItem()

..ede

--
This SF email is sponsosred by:
Try Windows Azure free for 90 days Click Here 
http://p.sf.net/sfu/sfd2d-msazure
___
Jump-pilot-devel mailing list
Jump-pilot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel


Re: [JPP-Devel] Selectable and Editable menu items won't check on Vista and Win7

2012-04-02 Thread Michaël Michaud
Hi,

Nice work Ede, thanks a lot.

Michaël
 On 31.03.2012 16:29, Michaël Michaud wrote:
 Hi,
 we could disable the icons conditionally for windows laf and win7+ as other 
 lafs and platforms are not hit.
 Agree if you do it ;-)
 done

 I will open a bug report which will stay opened as long as the bug is
 not fixed in jre.
 beat you to it ;)

 I had a quick look in the menus and noticed also
 - a icon + check symbol in category context menu (change visibility)
 - a icon + check symbol for View  Edit toolbox menuitem
 I suppose they are also concerned by the bug, which means there are at
 least 4 menu-items to fix.

 it's worked around generically where the menuitems are generated. i also did 
 some housekeeping while at it. here's the commit message

 Revision: 2786
http://jump-pilot.svn.sourceforge.net/jump-pilot/?rev=2786view=rev
 Author:   edso
 Date: 2012-04-02 13:14:37 + (Mon, 02 Apr 2012)
 Log Message:
 ---
 bugfix:
   http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7122141
   
 http://www.mail-archive.com/jump-pilot-devel@lists.sourceforge.net/msg10601.html

 com.vividsolutions.jump.workbench.ui.plugin.FeatureInstaller
 - unified spaces/tabs, general reformatting
 - privatized internally used behead method
 - deprecated legacy methods addLayerViewMenuItem(), addLayerNameViewMenuItem()
 - added replacement method for deprecated addMainMenuItem to add plain 
 plugins:
 addMainMenuPlugin( PlugIn, menuPath, menuItemName, checkBox, icon, 
 enableCheck, pos),
former changes by michael added methods for JMenuItem and AbstractUiPlugIn 
 only
 - added addMenuItemIcon() method used by all methods that add menu entries to 
 popup/mainmenu
it contains a workaround for the windows laf missing checkmark ticks for 
 checkbox entries on vista and later
 - cleaned up addPopupMenuItem() method that duplicated routines
 - commented (pending deletion) addMainMenuItemWithJava14Fix() methods
classes using the method above modified to use addMainMenuItem()

 ..ede

 --
 This SF email is sponsosred by:
 Try Windows Azure free for 90 days Click Here
 http://p.sf.net/sfu/sfd2d-msazure
 ___
 Jump-pilot-devel mailing list
 Jump-pilot-devel@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel




--
This SF email is sponsosred by:
Try Windows Azure free for 90 days Click Here 
http://p.sf.net/sfu/sfd2d-msazure
___
Jump-pilot-devel mailing list
Jump-pilot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel


Re: [JPP-Devel] Selectable and Editable menu items won't check on Vista and Win7

2012-04-02 Thread Edgar Soldin
actually the observed light blue square background for selected menuitems seems 
to be standard vista+ theme. other native windows applications have the same 
issue. you just have to get used to it. so it's mainly an issue of personal 
preference, but still it was a fun issue to work around.

..ede

On 02.04.2012 20:07, Michaël Michaud wrote:
 Hi,
 
 Nice work Ede, thanks a lot.
 
 Michaël
 On 31.03.2012 16:29, Michaël Michaud wrote:
 Hi,
 we could disable the icons conditionally for windows laf and win7+ as 
 other lafs and platforms are not hit.
 Agree if you do it ;-)
 done

 I will open a bug report which will stay opened as long as the bug is
 not fixed in jre.
 beat you to it ;)

 I had a quick look in the menus and noticed also
 - a icon + check symbol in category context menu (change visibility)
 - a icon + check symbol for View  Edit toolbox menuitem
 I suppose they are also concerned by the bug, which means there are at
 least 4 menu-items to fix.

 it's worked around generically where the menuitems are generated. i also did 
 some housekeeping while at it. here's the commit message

 Revision: 2786

 http://jump-pilot.svn.sourceforge.net/jump-pilot/?rev=2786view=rev
 Author:   edso
 Date: 2012-04-02 13:14:37 + (Mon, 02 Apr 2012)
 Log Message:
 ---
 bugfix:
  http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7122141
  
 http://www.mail-archive.com/jump-pilot-devel@lists.sourceforge.net/msg10601.html

 com.vividsolutions.jump.workbench.ui.plugin.FeatureInstaller
 - unified spaces/tabs, general reformatting
 - privatized internally used behead method
 - deprecated legacy methods addLayerViewMenuItem(), 
 addLayerNameViewMenuItem()
 - added replacement method for deprecated addMainMenuItem to add plain 
 plugins:
 addMainMenuPlugin( PlugIn, menuPath, menuItemName, checkBox, icon, 
 enableCheck, pos),
former changes by michael added methods for JMenuItem and 
 AbstractUiPlugIn only
 - added addMenuItemIcon() method used by all methods that add menu entries 
 to popup/mainmenu
it contains a workaround for the windows laf missing checkmark ticks for 
 checkbox entries on vista and later
 - cleaned up addPopupMenuItem() method that duplicated routines
 - commented (pending deletion) addMainMenuItemWithJava14Fix() methods
classes using the method above modified to use addMainMenuItem()

 ..ede

 --
 This SF email is sponsosred by:
 Try Windows Azure free for 90 days Click Here
 http://p.sf.net/sfu/sfd2d-msazure
 ___
 Jump-pilot-devel mailing list
 Jump-pilot-devel@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel


 
 
 --
 This SF email is sponsosred by:
 Try Windows Azure free for 90 days Click Here 
 http://p.sf.net/sfu/sfd2d-msazure
 ___
 Jump-pilot-devel mailing list
 Jump-pilot-devel@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel

-- 
public class WhoDidIt{ // A comment. I love comments 
  private static Person sender;

  public static void main (String[] foo){

  sender = new Person();
  sender.setName(new String[]{Edgar, Soldin});

  Address address = new Address();
  address.setStreet(Stadtweg 119);
  address.setZip(39116);
  address.setCity(Magdeburg);
  address.setCountry(Germany);

  sender.setAddress(address);

  sender.setMobilePhone( +49(0)171-2782880 );
  sender.setWebSiteUrl( http://www.soldin.de );
  sender.setEmail( ed...@soldin.de );
  sender.setPGPPublicKey( http://www.soldin.de/edgar_soldin.asc );
  sender.setGender(true);

  System.out.println(sender.toString());
  }
}

--
This SF email is sponsosred by:
Try Windows Azure free for 90 days Click Here 
http://p.sf.net/sfu/sfd2d-msazure
___
Jump-pilot-devel mailing list
Jump-pilot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel


Re: [JPP-Devel] Selectable and Editable menu items won't check on Vista and Win7

2012-03-31 Thread Michaël Michaud

Hi Larry, Jukka,

Thanks for the details,
I could find the bug report in the bug database
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7122141

I agree that having the check symbol visible is more important than the 
icon,

so I will apply Larry's patch.
I liked the icons too and voted for a fix in the Oracle's bug database 
as it had a very low priority.


Michaël

Le 30/03/2012 15:13, Rahkonen Jukka a écrit :

Hi,
Checks does not show for me on Vista 32-bit either with the default 
skin.  With most other skins the checkbox is visible.

-Jukka Rahkonen-


Larry Becker  wrote:
Hi Michaël,

  I've attached screen captures to illustrate the problem.  Notice
that XP displays both icons and checks, but Windows 7 shows only
icons.

  Now that I look closely, I see that the icons themselves provide
a subtle feedback that the item is selected.  I prefer the actual
checks myself.

Larry

2012/3/29 Michaël Michaud michael.mich...@free.fr
mailto:michael.mich...@free.fr

Hi Larry,

Thanks for the tip.
Can you give more details about the configuration that does
not work,
I can't reproduce the problem :
Windows Vista SP2 64bits + jre6 32 bits works as it should
Windows Vista SP2 64bits + jre7 32 bits works as it should
Windows Vista SP2 64bits + jre7 64 bits works as it should.

Michaël

Le 29/03/2012 21:55, Larry Becker a écrit :

Hi,

  I noticed that the Selectable and Editable menu items won't
check on Vista and Win7 due to an interface change.  If we
get rid of the menu icons, which don't really add much, the
functionality is restored.  I have included a patch to try
out the fix.

regards,

Larry

Index:

C:/eclipse3/workspace/OpenJumpSvn/src/com/vividsolutions/jump/workbench/JUMPConfiguration.java
===
---
C:/eclipse3/workspace/OpenJumpSvn/src/com/vividsolutions/jump/workbench/JUMPConfiguration.java   
(revision 2751)

+++
C:/eclipse3/workspace/OpenJumpSvn/src/com/vividsolutions/jump/workbench/JUMPConfiguration.java   
(working copy)

@@ -507,10 +507,10 @@
 .getFrame().getLayerNamePopupMenu();


featureInstaller.addPopupMenuItem(layerNamePopupMenu,

editablePlugIn,
-editablePlugIn.getName(), true,
EditablePlugIn.ICON, editablePlugIn
+editablePlugIn.getName(), true, null,
editablePlugIn
 .createEnableCheck(workbenchContext));

featureInstaller.addPopupMenuItem(layerNamePopupMenu,

selectablePlugIn,
-selectablePlugIn.getName(), true,
selectablePlugIn.ICON, selectablePlugIn
+selectablePlugIn.getName(), true, null,
selectablePlugIn
 .createEnableCheck(workbenchContext));
 layerNamePopupMenu.addSeparator(); //
===





--
This SF email is sponsosred by:
Try Windows Azure free for 90 days Click Here
http://p.sf.net/sfu/sfd2d-msazure


___
Jump-pilot-devel mailing list
Jump-pilot-devel@lists.sourceforge.net  
mailto:Jump-pilot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel




--
This SF email is sponsosred by:
Try Windows Azure free for 90 days Click Here
http://p.sf.net/sfu/sfd2d-msazure
___
Jump-pilot-devel mailing list
Jump-pilot-devel@lists.sourceforge.net
mailto:Jump-pilot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel




--
This SF email is sponsosred by:
Try Windows Azure free for 90 days Click Here
http://p.sf.net/sfu/sfd2d-msazure


___
Jump-pilot-devel mailing list
Jump-pilot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel


--
This SF email is sponsosred by:
Try Windows Azure free for 90 days Click Here 
http://p.sf.net/sfu/sfd2d-msazure___
Jump-pilot-devel mailing list
Jump-pilot-devel@lists.sourceforge.net

Re: [JPP-Devel] Selectable and Editable menu items won't check on Vista and Win7

2012-03-31 Thread edgar . soldin
On 31.03.2012 15:46, Michaël Michaud wrote:
 Hi Larry, Jukka,
 
 Thanks for the details,
 I could find the bug report in the bug database
 http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7122141
 
 I agree that having the check symbol visible is more important than the icon,
 so I will apply Larry's patch.
 I liked the icons too and voted for a fix in the Oracle's bug database as it 
 had a very low priority.
 

we could disable the icons conditionally for windows laf and win7+ as other 
lafs and platforms are not hit.

..ede

--
This SF email is sponsosred by:
Try Windows Azure free for 90 days Click Here 
http://p.sf.net/sfu/sfd2d-msazure
___
Jump-pilot-devel mailing list
Jump-pilot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel


Re: [JPP-Devel] Selectable and Editable menu items won't check on Vista and Win7

2012-03-31 Thread Michaël Michaud
Hi,
 we could disable the icons conditionally for windows laf and win7+ as other 
 lafs and platforms are not hit.
Agree if you do it ;-)
I will open a bug report which will stay opened as long as the bug is 
not fixed in jre.
I had a quick look in the menus and noticed also
- a icon + check symbol in category context menu (change visibility)
- a icon + check symbol for View  Edit toolbox menuitem
I suppose they are also concerned by the bug, which means there are at 
least 4 menu-items to fix.

Michaël

 ..ede

 --
 This SF email is sponsosred by:
 Try Windows Azure free for 90 days Click Here
 http://p.sf.net/sfu/sfd2d-msazure
 ___
 Jump-pilot-devel mailing list
 Jump-pilot-devel@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel




--
This SF email is sponsosred by:
Try Windows Azure free for 90 days Click Here 
http://p.sf.net/sfu/sfd2d-msazure
___
Jump-pilot-devel mailing list
Jump-pilot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel


Re: [JPP-Devel] Selectable and Editable menu items won't check on Vista and Win7

2012-03-30 Thread Larry Becker
Hi Michaël,

  I've attached screen captures to illustrate the problem.  Notice that XP
displays both icons and checks, but Windows 7 shows only icons.

  Now that I look closely, I see that the icons themselves provide a subtle
feedback that the item is selected.  I prefer the actual checks myself.

Larry

2012/3/29 Michaël Michaud michael.mich...@free.fr

  Hi Larry,

 Thanks for the tip.
 Can you give more details about the configuration that does not work,
 I can't reproduce the problem :
 Windows Vista SP2 64bits + jre6 32 bits works as it should
 Windows Vista SP2 64bits + jre7 32 bits works as it should
 Windows Vista SP2 64bits + jre7 64 bits works as it should.

 Michaël

 Le 29/03/2012 21:55, Larry Becker a écrit :

 Hi,

   I noticed that the Selectable and Editable menu items won't check on
 Vista and Win7 due to an interface change.  If we get rid of the menu
 icons, which don't really add much, the functionality is restored.  I have
 included a patch to try out the fix.

 regards,

 Larry

 Index:
 C:/eclipse3/workspace/OpenJumpSvn/src/com/vividsolutions/jump/workbench/JUMPConfiguration.java
 ===
 ---
 C:/eclipse3/workspace/OpenJumpSvn/src/com/vividsolutions/jump/workbench/JUMPConfiguration.java
 (revision 2751)
 +++
 C:/eclipse3/workspace/OpenJumpSvn/src/com/vividsolutions/jump/workbench/JUMPConfiguration.java
 (working copy)
 @@ -507,10 +507,10 @@
  .getFrame().getLayerNamePopupMenu();

  featureInstaller.addPopupMenuItem(layerNamePopupMenu,
 editablePlugIn,
 -editablePlugIn.getName(), true, EditablePlugIn.ICON,
 editablePlugIn
 +editablePlugIn.getName(), true, null, editablePlugIn
  .createEnableCheck(workbenchContext));
  featureInstaller.addPopupMenuItem(layerNamePopupMenu,
 selectablePlugIn,
 -selectablePlugIn.getName(), true, selectablePlugIn.ICON,
 selectablePlugIn
 +selectablePlugIn.getName(), true, null, selectablePlugIn
  .createEnableCheck(workbenchContext));
  layerNamePopupMenu.addSeparator(); // ===




 --
 This SF email is sponsosred by:
 Try Windows Azure free for 90 days Click Here 
 http://p.sf.net/sfu/sfd2d-msazure



 ___
 Jump-pilot-devel mailing 
 listJump-pilot-devel@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/jump-pilot-devel




 --
 This SF email is sponsosred by:
 Try Windows Azure free for 90 days Click Here
 http://p.sf.net/sfu/sfd2d-msazure
 ___
 Jump-pilot-devel mailing list
 Jump-pilot-devel@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel


attachment: XP.PNGattachment: Win7.png--
This SF email is sponsosred by:
Try Windows Azure free for 90 days Click Here 
http://p.sf.net/sfu/sfd2d-msazure___
Jump-pilot-devel mailing list
Jump-pilot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel


Re: [JPP-Devel] Selectable and Editable menu items won't check on Vista and Win7

2012-03-30 Thread Rahkonen Jukka
Hi,

Checks does not show for me on Vista 32-bit either with the default skin.  With 
most other skins the checkbox is visible.

-Jukka Rahkonen-


Larry Becker  wrote:
Hi Michaël,

  I've attached screen captures to illustrate the problem.  Notice that XP 
displays both icons and checks, but Windows 7 shows only icons.

  Now that I look closely, I see that the icons themselves provide a subtle 
feedback that the item is selected.  I prefer the actual checks myself.

Larry

2012/3/29 Michaël Michaud 
michael.mich...@free.frmailto:michael.mich...@free.fr
Hi Larry,

Thanks for the tip.
Can you give more details about the configuration that does not work,
I can't reproduce the problem :
Windows Vista SP2 64bits + jre6 32 bits works as it should
Windows Vista SP2 64bits + jre7 32 bits works as it should
Windows Vista SP2 64bits + jre7 64 bits works as it should.

Michaël

Le 29/03/2012 21:55, Larry Becker a écrit :
Hi,

  I noticed that the Selectable and Editable menu items won't check on Vista 
and Win7 due to an interface change.  If we get rid of the menu icons, which 
don't really add much, the functionality is restored.  I have included a patch 
to try out the fix.

regards,

Larry

Index: 
C:/eclipse3/workspace/OpenJumpSvn/src/com/vividsolutions/jump/workbench/JUMPConfiguration.java
===
--- 
C:/eclipse3/workspace/OpenJumpSvn/src/com/vividsolutions/jump/workbench/JUMPConfiguration.java
(revision 2751)
+++ 
C:/eclipse3/workspace/OpenJumpSvn/src/com/vividsolutions/jump/workbench/JUMPConfiguration.java
(working copy)
@@ -507,10 +507,10 @@
 .getFrame().getLayerNamePopupMenu();

 featureInstaller.addPopupMenuItem(layerNamePopupMenu, editablePlugIn,
-editablePlugIn.getName(), true, EditablePlugIn.ICON, 
editablePlugIn
+editablePlugIn.getName(), true, null, editablePlugIn
 .createEnableCheck(workbenchContext));
 featureInstaller.addPopupMenuItem(layerNamePopupMenu, selectablePlugIn,
-selectablePlugIn.getName(), true, selectablePlugIn.ICON, 
selectablePlugIn
+selectablePlugIn.getName(), true, null, selectablePlugIn
 .createEnableCheck(workbenchContext));
 layerNamePopupMenu.addSeparator(); // ===





--
This SF email is sponsosred by:
Try Windows Azure free for 90 days Click Here
http://p.sf.net/sfu/sfd2d-msazure



___
Jump-pilot-devel mailing list
Jump-pilot-devel@lists.sourceforge.netmailto:Jump-pilot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel



--
This SF email is sponsosred by:
Try Windows Azure free for 90 days Click Here
http://p.sf.net/sfu/sfd2d-msazure
___
Jump-pilot-devel mailing list
Jump-pilot-devel@lists.sourceforge.netmailto:Jump-pilot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel


--
This SF email is sponsosred by:
Try Windows Azure free for 90 days Click Here 
http://p.sf.net/sfu/sfd2d-msazure___
Jump-pilot-devel mailing list
Jump-pilot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel


[JPP-Devel] Selectable and Editable menu items won't check on Vista and Win7

2012-03-29 Thread Larry Becker
Hi,

  I noticed that the Selectable and Editable menu items won't check on
Vista and Win7 due to an interface change.  If we get rid of the menu
icons, which don't really add much, the functionality is restored.  I have
included a patch to try out the fix.

regards,

Larry

Index:
C:/eclipse3/workspace/OpenJumpSvn/src/com/vividsolutions/jump/workbench/JUMPConfiguration.java
===
---
C:/eclipse3/workspace/OpenJumpSvn/src/com/vividsolutions/jump/workbench/JUMPConfiguration.java
(revision 2751)
+++
C:/eclipse3/workspace/OpenJumpSvn/src/com/vividsolutions/jump/workbench/JUMPConfiguration.java
(working copy)
@@ -507,10 +507,10 @@
 .getFrame().getLayerNamePopupMenu();

 featureInstaller.addPopupMenuItem(layerNamePopupMenu,
editablePlugIn,
-editablePlugIn.getName(), true, EditablePlugIn.ICON,
editablePlugIn
+editablePlugIn.getName(), true, null, editablePlugIn
 .createEnableCheck(workbenchContext));
 featureInstaller.addPopupMenuItem(layerNamePopupMenu,
selectablePlugIn,
-selectablePlugIn.getName(), true, selectablePlugIn.ICON,
selectablePlugIn
+selectablePlugIn.getName(), true, null, selectablePlugIn
 .createEnableCheck(workbenchContext));
 layerNamePopupMenu.addSeparator(); // ===
--
This SF email is sponsosred by:
Try Windows Azure free for 90 days Click Here 
http://p.sf.net/sfu/sfd2d-msazure___
Jump-pilot-devel mailing list
Jump-pilot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel


Re: [JPP-Devel] Selectable and Editable menu items won't check on Vista and Win7

2012-03-29 Thread Michaël Michaud

Hi Larry,

Thanks for the tip.
Can you give more details about the configuration that does not work,
I can't reproduce the problem :
Windows Vista SP2 64bits + jre6 32 bits works as it should
Windows Vista SP2 64bits + jre7 32 bits works as it should
Windows Vista SP2 64bits + jre7 64 bits works as it should.

Michaël

Le 29/03/2012 21:55, Larry Becker a écrit :

Hi,

  I noticed that the Selectable and Editable menu items won't check on 
Vista and Win7 due to an interface change.  If we get rid of the menu 
icons, which don't really add much, the functionality is restored.  I 
have included a patch to try out the fix.


regards,

Larry

Index: 
C:/eclipse3/workspace/OpenJumpSvn/src/com/vividsolutions/jump/workbench/JUMPConfiguration.java

===
--- 
C:/eclipse3/workspace/OpenJumpSvn/src/com/vividsolutions/jump/workbench/JUMPConfiguration.java
(revision 2751)
+++ 
C:/eclipse3/workspace/OpenJumpSvn/src/com/vividsolutions/jump/workbench/JUMPConfiguration.java
(working copy)

@@ -507,10 +507,10 @@
 .getFrame().getLayerNamePopupMenu();

 featureInstaller.addPopupMenuItem(layerNamePopupMenu, 
editablePlugIn,
-editablePlugIn.getName(), true, EditablePlugIn.ICON, 
editablePlugIn

+editablePlugIn.getName(), true, null, editablePlugIn
 .createEnableCheck(workbenchContext));
 featureInstaller.addPopupMenuItem(layerNamePopupMenu, 
selectablePlugIn,
-selectablePlugIn.getName(), true, 
selectablePlugIn.ICON, selectablePlugIn

+selectablePlugIn.getName(), true, null, selectablePlugIn
 .createEnableCheck(workbenchContext));
 layerNamePopupMenu.addSeparator(); // ===




--
This SF email is sponsosred by:
Try Windows Azure free for 90 days Click Here
http://p.sf.net/sfu/sfd2d-msazure


___
Jump-pilot-devel mailing list
Jump-pilot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel


--
This SF email is sponsosred by:
Try Windows Azure free for 90 days Click Here 
http://p.sf.net/sfu/sfd2d-msazure___
Jump-pilot-devel mailing list
Jump-pilot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel