Re: [JPP-Devel] menu entries for geometry conversion
Le 24/06/2011 11:15, edgar.sol...@web.de a écrit : peppe votes to have the geometry conversion also in the layerview context menu. as i do not work with gis i don't know how often one needs this functonality. so i put that up for voting. anybody else in favor or against it? @michael: your vote on integrating the geomconv into core is still missing. Hi all, I have just tested geomconv for the first time. Good work. Geometry type conversion is a very useful feature. I agree with peppe that it would be nice to have the menu in layerview context menu In my opinion, it would need a bit more work (and translation). I would vote to include it in 1.4.2 (and I'm ready to help to improve and to translate it). Here are my remarks (more or less important, feedback is welcome) : 1) It took me some times to understand the differences with existing tools like extract points I would reorganize Edit Geometry convert menu into - Edit Geometry Extract (points, boundaries, segments...) these plugins work on a whole layer and create a new one for the result - Edit Geometry Convert (ede's conversion tool) these plugins work mainly on a selection and modify directly geometries Note : conversion are undoable, which is a great feature ! 2) If no feature is selected, the tool converts the whole layer This is a useful feature, but It would be nice to warn the user, as the menu name is convert selected geometry 3) Converting polygons with holes or multipolygons into linestrings create bridges joining linear components It should be converted int multilinestrings Why not use *com.vividsolutions.jts.geom.util.LinearComponentExtracter* In a more general way, I would propose to convert geometries into : - ponctual, lineal or polygonal geometries The plugin should choose the best geometry type - points into punctual - points - any other geometry into punctual - multipoint - point into lineal : not possible - multipoint into lineal - linestring (or linearring if first = last coordinate) - linestring into lineal - linestring - polygon without hole into lineal - linear ring - polygon with holes or multipolygons into lineal - multilinestring - point into polygonal - not possible - linestring into polygonal - polygon if closed (option to close it ?) - multilinestring into polygon - polygon or multipolygon (may be difficlut to find interior rings and exterior rings, I have some code for that) 4) Missing coversion of polygons with holes and multi-polygons into multilinestring Possible improvements : 5) The tool works on a per feature basis. It means that a linestring cannot be converted into a point. It may be useful, but it is not always intuitive. I would like an option like authorize conversion of one feature into several. Just an idea for improvement, not a requirement. If neither a multipoint nor a linestring, nor a polygon can be converted to a point (Too many points selected. Only one point needed) what can the convert to point plugin do ? 6) Converting linearring into multipoints keeps the starting and the ending point (it's OK as the default behaviour, but an option as the one in extract points would be welcome) Converting multipoints into linear ring fails if last point is not equals to first one (it's OK as the default behaviour, but an option to close the line would be welcome) 7) Missing conversion of multi linear rings into polygons or multi-polygons (not easy) Hope it helps regards ede -- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity and more. Splunk takes this data and makes sense of it. Business sense. IT sense. Common sense.. http://p.sf.net/sfu/splunk-d2d-c1 ___ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel -- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity and more. Splunk takes this data and makes sense of it. Business sense. IT sense. Common sense.. http://p.sf.net/sfu/splunk-d2d-c1___ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
Re: [JPP-Devel] menu entries for geometry conversion
Hi all, few considerations 1) It took me some times to understand the differences with existing tools like extract points That's why I think that it should be better into Edit menu on toolbar. Anyhow the LayerContext menu will be more acxtractive 2) If no feature is selected, the tool converts the whole layer It should be limited only to selected features. ToolsEdit Geometriesconvert tools work on the whole layer More general I understand in OpenJUMP that Menubar Edit tools affects only selected features while MenubarToolsEdit Geometry tools work on the entire layer Peppe -- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity and more. Splunk takes this data and makes sense of it. Business sense. IT sense. Common sense.. http://p.sf.net/sfu/splunk-d2d-c1 ___ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
Re: [JPP-Devel] menu entries for geometry conversion
On 25.06.2011 10:21, Michaël Michaud wrote: I have just tested geomconv for the first time. Good work. Geometry type conversion is a very useful feature. I agree with peppe that it would be nice to have the menu in layerview context menu thanks, and thanks for all the issues you pointed out. i highly value that! this is terribly needed because my gis background is purely theoretical and limited to my work on openjump. In my opinion, it would need a bit more work (and translation). I would vote to include it in 1.4.2 (and I'm ready to help to improve and to translate it). no problem. i'll keep it external until we all agree it is matured enough. any other distro can use the plugins as well packaged as extension. Here are my remarks (more or less important, feedback is welcome) : 1) It took me some times to understand the differences with existing tools like extract points I would reorganize Edit Geometry convert menu into - Edit Geometry Extract (points, boundaries, segments...) these plugins work on a whole layer and create a new one for the result - Edit Geometry Convert (ede's conversion tool) these plugins work mainly on a selection and modify directly geometries Polygonize is also a conversion tool (but i can't be put in the same category as it works totally different) Planar Graph is also extractionary? Note : conversion are undoable, which is a great feature ! and necessary, because errors might have occured and the user might not be satidfied with the result we should by the way consider a empty undo/redo queue functionality (with button) to release ram after big conversions. is there something similar already existing? 2) If no feature is selected, the tool converts the whole layer This is a useful feature, but It would be nice to warn the user, as the menu name is convert selected geometry well it is 'Convert selected Geometries/Layers to' exactly, but you are right a short modal ok/cancel dialogue is in order. 3) Converting polygons with holes or multipolygons into linestrings create bridges joining linear components It should be converted int multilinestrings Why not use *com.vividsolutions.jts.geom.util.LinearComponentExtracter* good hint, will check out LinearComponentExtracter for a conversion to Multilinestring. if the user explicitly ordered a conversion to Linestring it behaves correctly, don't you think? In a more general way, I would propose to convert geometries into : - ponctual, lineal or polygonal geometries i am not sure if i really want to spend effort to make it that 'intelligent'. The plugin should choose the best geometry type - points into punctual - points - any other geometry into punctual - multipoint - point into lineal : not possible - multipoint into lineal - linestring (or linearring if first = last coordinate) - linestring into lineal - linestring - polygon without hole into lineal - linear ring - polygon with holes or multipolygons into lineal - multilinestring - point into polygonal - not possible - linestring into polygonal - polygon if closed (option to close it ?) - multilinestring into polygon - polygon or multipolygon (may be difficlut to find interior rings and exterior rings, I have some code for that) i rather prefer the user to exactly specify what the result should be. this way the user can e.g. make point to linestring and add more points to the same feature. the user retains pretty much has the possibility to convert anything to everything (if possible). if there i enhanced logic i'd rather offer conversion targets like 'linearring (autoclose ring)' or 'multilinestring (separate holes)' 4) Missing coversion of polygons with holes and multi-polygons into multilinestring this should come with the multilinestring (separate holes) target provided i find the logic somewhere that does that (will check your suggestion above). the standard conversion to multi* will create a multi* with one entry. Possible improvements : 5) The tool works on a per feature basis. It means that a linestring cannot be converted into a point. It may be useful, but it is not always intuitive. I would like an option like authorize conversion of one feature into several. Just an idea for improvement, not a requirement. i'd really like to stick with the per feature basis for now. let's solve the outstanding issues and we might think about splitting fatures. If neither a multipoint nor a linestring, nor a polygon can be converted to a point (Too many points selected. Only one point needed) what can the convert to point plugin do ? exactly what is possible. convert a multipoint, a linestring or a polygon with exactly one point to a point geometry ;). 6) Converting linearring into multipoints keeps the starting and the ending point (it's OK as the default behaviour, but an option as the one in extract points would be welcome) you mean deleting the useless end point?
Re: [JPP-Devel] menu entries for geometry conversion
+1 On Fri, Jun 24, 2011 at 4:15 AM, edgar.sol...@web.de wrote: peppe votes to have the geometry conversion also in the layerview context menu. as i do not work with gis i don't know how often one needs this functonality. so i put that up for voting. anybody else in favor or against it? @michael: your vote on integrating the geomconv into core is still missing. regards ede -- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity and more. Splunk takes this data and makes sense of it. Business sense. IT sense. Common sense.. http://p.sf.net/sfu/splunk-d2d-c1 ___ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel -- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity and more. Splunk takes this data and makes sense of it. Business sense. IT sense. Common sense.. http://p.sf.net/sfu/splunk-d2d-c1___ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
