On Tue, Jul 15, 2014 at 08:53:52AM +0000, Opensource [James Seong-Won Ban] 
wrote:
> Hi Dan,
> 
> There is no problem in the code because the pdata is checked before the 
> function.
> Do I have to do something?

The checker is saying that the code doesn't make sense as-is becuase we
dereference "chip->pdata" and we have a check to see if it is NULL.  The
check doesn't make sense because we would have crashed already at that
point.  You are saying that the extra check for "chip->pdata" is not
needed.

                if (chip->pdata)
                        config.init_data =
                                &(chip->pdata->init_data[i]);

Just delete it then.  That way the code will make sense and be
consistent.

regards,
dan carpenter

_______________________________________________
kbuild mailing list
kbuild@lists.01.org
https://lists.01.org/mailman/listinfo/kbuild

Reply via email to