[ This one is my bad. I said that "req" didn't need to be initialized
but it does. Sorry. -dan ]
tree: git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: f68f82364938548b58b51d4b926642b0a3cf4c27
commit: ab909585b813193bb45f52367c1e7d056e33cfa9 [980/1325] staging: lustre:
Cleanup variable declarations in mdc_enqueue()
New smatch warnings:
drivers/staging/lustre/lustre/mdc/mdc_locks.c:866 mdc_enqueue() error:
potentially dereferencing uninitialized 'req'.
Old smatch warnings:
drivers/staging/lustre/lustre/mdc/mdc_locks.c:866 mdc_enqueue() error: we
previously assumed 'req' could be null (see line 860)
drivers/staging/lustre/lustre/mdc/../include/lustre_mdc.h:116
mdc_get_rpc_lock() warn: inconsistent returns mutex:&lck->rpcl_mutex: locked
(116) unlocked (86, 101)
git remote add next
git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
git remote update next
git checkout ab909585b813193bb45f52367c1e7d056e33cfa9
vim +/req +866 drivers/staging/lustre/lustre/mdc/mdc_locks.c
e93a3082 Andrew Perepechko 2014-02-09 850 } else if (it->it_op &
IT_GETXATTR) {
7fc1f831 Andrew Perepechko 2013-12-03 851 req =
mdc_intent_getxattr_pack(exp, it, op_data);
d7e09d03 Peng Tao 2013-05-02 852 } else {
d7e09d03 Peng Tao 2013-05-02 853 LBUG();
0a3bdb00 Greg Kroah-Hartman 2013-08-03 854 return -EINVAL;
d7e09d03 Peng Tao 2013-05-02 855 }
d7e09d03 Peng Tao 2013-05-02 856
d7e09d03 Peng Tao 2013-05-02 857 if (IS_ERR(req))
0a3bdb00 Greg Kroah-Hartman 2013-08-03 858 return PTR_ERR(req);
d7e09d03 Peng Tao 2013-05-02 859
d7e09d03 Peng Tao 2013-05-02 860 if (req != NULL && it &&
it->it_op & IT_CREAT)
d7e09d03 Peng Tao 2013-05-02 861 /* ask ptlrpc not to
resend on EINPROGRESS since we have our own
d7e09d03 Peng Tao 2013-05-02 862 * retry logic */
d7e09d03 Peng Tao 2013-05-02 863
req->rq_no_retry_einprogress = 1;
d7e09d03 Peng Tao 2013-05-02 864
d7e09d03 Peng Tao 2013-05-02 865 if (resends) {
d7e09d03 Peng Tao 2013-05-02 @866 req->rq_generation_set
= 1;
d7e09d03 Peng Tao 2013-05-02 867
req->rq_import_generation = generation;
7264b8a5 Greg Kroah-Hartman 2014-07-12 868 req->rq_sent =
get_seconds() + resends;
d7e09d03 Peng Tao 2013-05-02 869 }
d7e09d03 Peng Tao 2013-05-02 870
d7e09d03 Peng Tao 2013-05-02 871 /* It is important to obtain
rpc_lock first (if applicable), so that
d7e09d03 Peng Tao 2013-05-02 872 * threads that are serialised
with rpc_lock are not polluting our
d7e09d03 Peng Tao 2013-05-02 873 * rpcs in flight counter. We
do not do flock request limiting, though*/
d7e09d03 Peng Tao 2013-05-02 874 if (it) {
--
0-DAY kernel build testing backend Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild Intel Corporation
_______________________________________________
kbuild mailing list
kbuild@lists.01.org
https://lists.01.org/mailman/listinfo/kbuild
