[kbuild] [regulator:topic/isl9305 5/5] drivers/regulator/isl9305.c:202 isl9305_i2c_probe() error: buffer overflow 'pdata-init_data' 3 = 3
tree: git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git
topic/isl9305
head: dec38b5ce6a9edb406c60c2670b26a1a4262fdb9
commit: dec38b5ce6a9edb406c60c2670b26a1a4262fdb9 [5/5] regulator: isl9305: Add
Intersil ISL9305/H driver
drivers/regulator/isl9305.c:202 isl9305_i2c_probe() error: buffer overflow
'pdata-init_data' 3 = 3
git remote add regulator
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git
git remote update regulator
git checkout dec38b5ce6a9edb406c60c2670b26a1a4262fdb9
vim +202 drivers/regulator/isl9305.c
dec38b5c Mark Brown 2014-09-06 186 dev_err(i2c-dev, Failed to
create regmap: %d\n, ret);
dec38b5c Mark Brown 2014-09-06 187 return ret;
dec38b5c Mark Brown 2014-09-06 188 }
dec38b5c Mark Brown 2014-09-06 189
dec38b5c Mark Brown 2014-09-06 190 config.dev = i2c-dev;
dec38b5c Mark Brown 2014-09-06 191
dec38b5c Mark Brown 2014-09-06 192 for (i = 0; i
ARRAY_SIZE(isl9305_regulators); i++) {
dec38b5c Mark Brown 2014-09-06 193 config.of_node = NULL;
dec38b5c Mark Brown 2014-09-06 194 config.init_data = NULL;
dec38b5c Mark Brown 2014-09-06 195
dec38b5c Mark Brown 2014-09-06 196 if (of_matches) {
dec38b5c Mark Brown 2014-09-06 197 config.init_data =
of_matches[i].init_data;
dec38b5c Mark Brown 2014-09-06 198 config.of_node =
of_matches[i].of_node;
dec38b5c Mark Brown 2014-09-06 199 }
dec38b5c Mark Brown 2014-09-06 200
dec38b5c Mark Brown 2014-09-06 201 if (!config.init_data pdata)
dec38b5c Mark Brown 2014-09-06 @202 config.init_data =
pdata-init_data[i];
dec38b5c Mark Brown 2014-09-06 203
dec38b5c Mark Brown 2014-09-06 204 rdev =
devm_regulator_register(i2c-dev,
dec38b5c Mark Brown 2014-09-06 205
isl9305_regulators[i],
dec38b5c Mark Brown 2014-09-06 206
config);
dec38b5c Mark Brown 2014-09-06 207 if (IS_ERR(rdev)) {
dec38b5c Mark Brown 2014-09-06 208 ret = PTR_ERR(rdev);
dec38b5c Mark Brown 2014-09-06 209 dev_err(i2c-dev,
Failed to register %s: %d\n,
dec38b5c Mark Brown 2014-09-06 210
isl9305_regulators[i].name, ret);
---
0-DAY kernel build testing backend Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild Intel Corporation
___
kbuild mailing list
kbuild@lists.01.org
https://lists.01.org/mailman/listinfo/kbuild
[kbuild] [tip:sched/core 23/24] kernel/sched/cputime.c:312:22: sparse: context imbalance in 'thread_group_cputime' - different lock contexts for basic block
TO: Rik van Riel r...@redhat.com
CC: Ingo Molnar mi...@kernel.org
CC: Peter Zijlstra (Intel) pet...@infradead.org
tree: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git sched/core
head: eb1b4af0a64ac7bb0ee36f579c1c7cefcbc3ac2c
commit: e78c3496790ee8a36522a838b59b388e8a709e65 [23/24] time, signal: Protect
resource use statistics with seqlock
reproduce: make C=1 CF=-D__CHECK_ENDIAN__
:: branch date: 2 hours ago
:: commit date: 2 hours ago
kernel/sched/cputime.c:304:42: sparse: incorrect type in argument 2
(different modifiers)
kernel/sched/cputime.c:304:42:expected unsigned long [nocast] [usertype]
*utime
kernel/sched/cputime.c:304:42:got unsigned long *noident
kernel/sched/cputime.c:304:42: sparse: implicit cast to nocast type
kernel/sched/cputime.c:304:50: sparse: incorrect type in argument 3
(different modifiers)
kernel/sched/cputime.c:304:50:expected unsigned long [nocast] [usertype]
*stime
kernel/sched/cputime.c:304:50:got unsigned long *noident
kernel/sched/cputime.c:304:50: sparse: implicit cast to nocast type
kernel/sched/cputime.c:276:24: sparse: implicit cast from nocast type
kernel/sched/cputime.c:620:26: sparse: incorrect type in argument 2
(different modifiers)
kernel/sched/cputime.c:620:26:expected unsigned long [nocast] [usertype]
*utime
kernel/sched/cputime.c:620:26:got unsigned long *noident
kernel/sched/cputime.c:620:26: sparse: implicit cast to nocast type
kernel/sched/cputime.c:620:42: sparse: incorrect type in argument 3
(different modifiers)
kernel/sched/cputime.c:620:42:expected unsigned long [nocast] [usertype]
*stime
kernel/sched/cputime.c:620:42:got unsigned long *noident
kernel/sched/cputime.c:620:42: sparse: implicit cast to nocast type
kernel/sched/cputime.c:312:22: sparse: context imbalance in
'thread_group_cputime' - different lock contexts for basic block
git remote add tip git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git
git remote update tip
git checkout e78c3496790ee8a36522a838b59b388e8a709e65
vim +/thread_group_cputime +312 kernel/sched/cputime.c
dee08a72 Frederic Weisbecker 2014-03-05 270 * granularity and
account the rest on the next rounds.
dee08a72 Frederic Weisbecker 2014-03-05 271 */
dee08a72 Frederic Weisbecker 2014-03-05 272steal_ct =
nsecs_to_cputime(steal);
dee08a72 Frederic Weisbecker 2014-03-05 273
this_rq()-prev_steal_time += cputime_to_nsecs(steal_ct);
73fbec60 Frederic Weisbecker 2012-06-16 274
dee08a72 Frederic Weisbecker 2014-03-05 275
account_steal_time(steal_ct);
dee08a72 Frederic Weisbecker 2014-03-05 276return steal_ct;
73fbec60 Frederic Weisbecker 2012-06-16 277}
73fbec60 Frederic Weisbecker 2012-06-16 278 #endif
73fbec60 Frederic Weisbecker 2012-06-16 279return false;
73fbec60 Frederic Weisbecker 2012-06-16 280 }
73fbec60 Frederic Weisbecker 2012-06-16 281
a634f933 Frederic Weisbecker 2012-11-21 282 /*
a634f933 Frederic Weisbecker 2012-11-21 283 * Accumulate raw cputime values
of dead tasks (sig-[us]time) and live
a634f933 Frederic Weisbecker 2012-11-21 284 * tasks (sum on group iteration)
belonging to @tsk's group.
a634f933 Frederic Weisbecker 2012-11-21 285 */
a634f933 Frederic Weisbecker 2012-11-21 286 void thread_group_cputime(struct
task_struct *tsk, struct task_cputime *times)
a634f933 Frederic Weisbecker 2012-11-21 287 {
a634f933 Frederic Weisbecker 2012-11-21 288struct signal_struct *sig =
tsk-signal;
6fac4829 Frederic Weisbecker 2012-11-13 289cputime_t utime, stime;
a634f933 Frederic Weisbecker 2012-11-21 290struct task_struct *t;
e78c3496 Rik van Riel2014-08-16 291unsigned int seq, nextseq;
a634f933 Frederic Weisbecker 2012-11-21 292
e78c3496 Rik van Riel2014-08-16 293rcu_read_lock();
e78c3496 Rik van Riel2014-08-16 294/* Attempt a lockless read on
the first round. */
e78c3496 Rik van Riel2014-08-16 295nextseq = 0;
e78c3496 Rik van Riel2014-08-16 296do {
e78c3496 Rik van Riel2014-08-16 297seq = nextseq;
e78c3496 Rik van Riel2014-08-16 298
read_seqbegin_or_lock(sig-stats_lock, seq);
a634f933 Frederic Weisbecker 2012-11-21 299times-utime =
sig-utime;
a634f933 Frederic Weisbecker 2012-11-21 300times-stime =
sig-stime;
a634f933 Frederic Weisbecker 2012-11-21 301times-sum_exec_runtime
= sig-sum_sched_runtime;
a634f933 Frederic Weisbecker 2012-11-21 302
1e4dda08 Oleg Nesterov 2014-08-13 303for_each_thread(tsk, t)
{
e614b333 Stanislaw Gruszka 2013-04-04 304task_cputime(t,
utime, stime);
6fac4829 Frederic Weisbecker 2012-11-13 305times-utime +=
utime;
6fac4829 Frederic Weisbecker 2012-11-13 306times-stime +=
stime;
a634f933 Frederic Weisbecker
[kbuild] [regulator:topic/tps65217 1/1] drivers/regulator/tps65217-regulator.c:248 tps65217_regulator_probe() error: we previously assumed 'pdata' could be null (see line 243)
tree: git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git
topic/tps65217
head: 81baf9fe0243a4450d738676ccf99d325460c748
commit: 81baf9fe0243a4450d738676ccf99d325460c748 [1/1] regulator: tps65217:
Remove spurious platform data check
drivers/regulator/tps65217-regulator.c:248 tps65217_regulator_probe() error: we
previously assumed 'pdata' could be null (see line 243)
git remote add regulator
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git
git remote update regulator
git checkout 81baf9fe0243a4450d738676ccf99d325460c748
vim +/pdata +248 drivers/regulator/tps65217-regulator.c
c172708d38 Mark Brown 2012-04-04 237
1922b0f275 AnilKumar Ch 2012-08-13 238 platform_set_drvdata(pdev, tps);
a493077f18 AnilKumar Ch 2012-01-11 239
1922b0f275 AnilKumar Ch 2012-08-13 240 for (i = 0; i
TPS65217_NUM_REGULATOR; i++) {
1922b0f275 AnilKumar Ch 2012-08-13 241 /* Register the
regulators */
1922b0f275 AnilKumar Ch 2012-08-13 242 config.dev = tps-dev;
81baf9fe02 Mark Brown 2014-09-06 243 if (pdata)
94ee607c96 Axel Lin 2014-02-21 244
config.init_data = pdata-tps65217_init_data[i];
1922b0f275 AnilKumar Ch 2012-08-13 245 config.driver_data =
tps;
1922b0f275 AnilKumar Ch 2012-08-13 246 config.regmap =
tps-regmap;
1922b0f275 AnilKumar Ch 2012-08-13 247 if (tps-dev-of_node)
1922b0f275 AnilKumar Ch 2012-08-13 248 config.of_node
= pdata-of_node[i];
1922b0f275 AnilKumar Ch 2012-08-13 249
4aac198ddc Sachin Kamat 2013-09-04 250 rdev =
devm_regulator_register(pdev-dev, regulators[i],
4aac198ddc Sachin Kamat 2013-09-04 251
config);
---
0-DAY kernel build testing backend Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild Intel Corporation
___
kbuild mailing list
kbuild@lists.01.org
https://lists.01.org/mailman/listinfo/kbuild
[kbuild] [nfc-next:master 42/43] drivers/nfc/trf7970a.c:876 trf7970a_irq() warn: inconsistent returns mutex:trf-lock: locked (836 [s32min-(-1), 1-s32max], 849 [s32min-(-1), 1-s32max]) unlocked (744
[ The New Smatch warning format for this looks like:
CHECK drivers/nfc/trf7970a.c
drivers/nfc/trf7970a.c:810 trf7970a_irq() warn: passing zero to 'ERR_PTR'
drivers/nfc/trf7970a.c:876 trf7970a_irq() warn: inconsistent returns
'mutex:trf-lock'.
Locked on: line 836
line 849
Unlocked on: line 744
line 750
line 758
line 876
drivers/nfc/trf7970a.c:1663 trf7970a_tg_listen() warn: inconsistent returns
'mutex:trf-lock'.
Locked on: line 1630
line 1635
line 1640
line 1645
Unlocked on: line 1663
-dan ]
tree: git://git.kernel.org/pub/scm/linux/kernel/git/sameo/nfc-next.git master
head: cb174aba86fe10ddac8b692c90a9480526c02953
commit: 13b4272a8264220ec043a922fd1fa05da72d57ae [42/43] NFC: trf7970a: Add
Target Mode Support
New smatch warnings:
drivers/nfc/trf7970a.c:876 trf7970a_irq() warn: inconsistent returns
mutex:trf-lock: locked (836 [s32min-(-1),1-s32max], 849
[s32min-(-1),1-s32max]) unlocked (744 [0], 750 [0], 758 [0], 876 [1])
Old smatch warnings:
drivers/nfc/trf7970a.c:1663 trf7970a_tg_listen() warn: inconsistent returns
mutex:trf-lock: locked (1630 [s32min-(-1),1-s32max], 1635
[s32min-(-1),1-s32max], 1640 [s32min-(-1),1-s32max], 1645
[s32min-(-1),1-s32max]) unlocked (1663 [0], 1663 [s32min-(-1),1-s32max], 1663
[(-12)], 1663 [(-125)], 1663 [(-5)])
git remote add nfc-next
git://git.kernel.org/pub/scm/linux/kernel/git/sameo/nfc-next.git
git remote update nfc-next
git checkout 13b4272a8264220ec043a922fd1fa05da72d57ae
vim +876 drivers/nfc/trf7970a.c
9d9304b3 Mark A. Greer 2014-03-10 860 break;
13b4272a Mark A. Greer 2014-09-02 861 case TRF7970A_ST_LISTENING:
13b4272a Mark A. Greer 2014-09-02 862 if (status
TRF7970A_IRQ_STATUS_SRX) {
13b4272a Mark A. Greer 2014-09-02 863
trf-ignore_timeout =
13b4272a Mark A. Greer 2014-09-02 864
!cancel_delayed_work(trf-timeout_work);
13b4272a Mark A. Greer 2014-09-02 865
trf7970a_drain_fifo(trf, status);
13b4272a Mark A. Greer 2014-09-02 866 } else if (!(status
TRF7970A_IRQ_STATUS_NFC_RF)) {
13b4272a Mark A. Greer 2014-09-02 867
trf7970a_send_err_upstream(trf, -EIO);
13b4272a Mark A. Greer 2014-09-02 868 }
13b4272a Mark A. Greer 2014-09-02 869 break;
165063f1 Mark A. Greer 2014-03-10 870 default:
165063f1 Mark A. Greer 2014-03-10 871 dev_err(trf-dev, %s -
Driver in invalid state: %d\n,
165063f1 Mark A. Greer 2014-03-10 872
__func__, trf-state);
165063f1 Mark A. Greer 2014-03-10 873 }
165063f1 Mark A. Greer 2014-03-10 874
165063f1 Mark A. Greer 2014-03-10 875 mutex_unlock(trf-lock);
165063f1 Mark A. Greer 2014-03-10 @876 return IRQ_HANDLED;
165063f1 Mark A. Greer 2014-03-10 877 }
165063f1 Mark A. Greer 2014-03-10 878
9d9304b3 Mark A. Greer 2014-03-10 879 static void trf7970a_issue_eof(struct
trf7970a *trf)
9d9304b3 Mark A. Greer 2014-03-10 880 {
9d9304b3 Mark A. Greer 2014-03-10 881 int ret;
9d9304b3 Mark A. Greer 2014-03-10 882
9d9304b3 Mark A. Greer 2014-03-10 883 dev_dbg(trf-dev, Issuing
EOF\n);
9d9304b3 Mark A. Greer 2014-03-10 884
---
0-DAY kernel build testing backend Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild Intel Corporation
___
kbuild mailing list
kbuild@lists.01.org
https://lists.01.org/mailman/listinfo/kbuild
[kbuild] [devfreq:for-chanwoo 1/5] drivers/devfreq/devfreq-event.c:85:1-7: preceding lock on line 57
tree: git://git.kernel.org/pub/scm/linux/kernel/git/mzx/devfreq for-chanwoo
head: 3a85940e803da22f5fedc64871c5f065802057b5
commit: 52d1ab5e8580ce084c1c312e15a1025662d12c30 [1/5] devfreq: Add new
devfreq_event class to provide basic data for devfreq governor
drivers/devfreq/devfreq-event.c:85:1-7: preceding lock on line 57
git remote add devfreq git://git.kernel.org/pub/scm/linux/kernel/git/mzx/devfreq
git remote update devfreq
git checkout 52d1ab5e8580ce084c1c312e15a1025662d12c30
vim +85 drivers/devfreq/devfreq-event.c
52d1ab5e Chanwoo Choi 2014-07-18 51return ERR_PTR(-EINVAL);
52d1ab5e Chanwoo Choi 2014-07-18 52
52d1ab5e Chanwoo Choi 2014-07-18 53edev = kzalloc(sizeof(struct
devfreq_event_dev), GFP_KERNEL);
52d1ab5e Chanwoo Choi 2014-07-18 54if (!edev)
52d1ab5e Chanwoo Choi 2014-07-18 55return ERR_PTR(-ENOMEM);
52d1ab5e Chanwoo Choi 2014-07-18 56
52d1ab5e Chanwoo Choi 2014-07-18 57mutex_lock(devfreq_event_list_lock);
52d1ab5e Chanwoo Choi 2014-07-18 58
52d1ab5e Chanwoo Choi 2014-07-18 59mutex_init(edev-mutex);
52d1ab5e Chanwoo Choi 2014-07-18 60edev-desc = desc;
52d1ab5e Chanwoo Choi 2014-07-18 61edev-driver_data = desc-driver_data;
52d1ab5e Chanwoo Choi 2014-07-18 62edev-owner = desc-owner;
52d1ab5e Chanwoo Choi 2014-07-18 63
52d1ab5e Chanwoo Choi 2014-07-18 64edev-dev.parent = dev;
52d1ab5e Chanwoo Choi 2014-07-18 65edev-dev.class = devfreq_event_class;
52d1ab5e Chanwoo Choi 2014-07-18 66
52d1ab5e Chanwoo Choi 2014-07-18 67dev_set_name(edev-dev, event.%d,
52d1ab5e Chanwoo Choi 2014-07-18 68
atomic_inc_return(event_no) - 1);
52d1ab5e Chanwoo Choi 2014-07-18 69ret = device_register(edev-dev);
52d1ab5e Chanwoo Choi 2014-07-18 70if (ret != 0) {
52d1ab5e Chanwoo Choi 2014-07-18 71put_device(edev-dev);
52d1ab5e Chanwoo Choi 2014-07-18 72goto err;
52d1ab5e Chanwoo Choi 2014-07-18 73}
52d1ab5e Chanwoo Choi 2014-07-18 74dev_set_drvdata(edev-dev, edev);
52d1ab5e Chanwoo Choi 2014-07-18 75
52d1ab5e Chanwoo Choi 2014-07-18 76/* Add devfreq event device to
devfreq_event_list */
52d1ab5e Chanwoo Choi 2014-07-18 77INIT_LIST_HEAD(edev-node);
52d1ab5e Chanwoo Choi 2014-07-18 78list_add(edev-node,
devfreq_event_list);
52d1ab5e Chanwoo Choi 2014-07-18 79
52d1ab5e Chanwoo Choi 2014-07-18 80mutex_unlock(devfreq_event_list_lock);
52d1ab5e Chanwoo Choi 2014-07-18 81
52d1ab5e Chanwoo Choi 2014-07-18 82return edev;
52d1ab5e Chanwoo Choi 2014-07-18 83 err:
52d1ab5e Chanwoo Choi 2014-07-18 84kfree(edev);
52d1ab5e Chanwoo Choi 2014-07-18 85return ERR_PTR(ret);
52d1ab5e Chanwoo Choi 2014-07-18 86 }
52d1ab5e Chanwoo Choi 2014-07-18 87 EXPORT_SYMBOL(devfreq_add_event_device);
52d1ab5e Chanwoo Choi 2014-07-18 88
---
0-DAY kernel build testing backend Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild Intel Corporation
___
kbuild mailing list
kbuild@lists.01.org
https://lists.01.org/mailman/listinfo/kbuild
___
kbuild mailing list
kbuild@lists.01.org
https://lists.01.org/mailman/listinfo/kbuild
[kbuild] [vireshk:cpufreq/governor-fixes 2/2] drivers/cpufreq/cpufreq.c:938:34: sparse: odd constant _Bool cast (5 becomes 1)
tree: git://git.linaro.org/people/vireshk/linux cpufreq/governor-fixes
head: 250686bfdbb183a9d798b071d32972b65d35c915
commit: 250686bfdbb183a9d798b071d32972b65d35c915 [2/2] cpufreq: Track
governor-state with 'policy-governor_state'
reproduce: make C=1 CF=-D__CHECK_ENDIAN__
drivers/cpufreq/cpufreq.c:938:34: sparse: odd constant _Bool cast (5 becomes
1)
git remote add vireshk git://git.linaro.org/people/vireshk/linux
git remote update vireshk
git checkout 250686bfdbb183a9d798b071d32972b65d35c915
vim +938 drivers/cpufreq/cpufreq.c
ecf7e461 Dave Jones 2009-07-08 922 goto err_out_kobj_put;
ecf7e461 Dave Jones 2009-07-08 923
e18f1682 Srivatsa S. Bhat 2013-07-30 924 return ret;
e18f1682 Srivatsa S. Bhat 2013-07-30 925
e18f1682 Srivatsa S. Bhat 2013-07-30 926 err_out_kobj_put:
e18f1682 Srivatsa S. Bhat 2013-07-30 927 kobject_put(policy-kobj);
e18f1682 Srivatsa S. Bhat 2013-07-30 928
wait_for_completion(policy-kobj_unregister);
e18f1682 Srivatsa S. Bhat 2013-07-30 929 return ret;
e18f1682 Srivatsa S. Bhat 2013-07-30 930 }
e18f1682 Srivatsa S. Bhat 2013-07-30 931
e18f1682 Srivatsa S. Bhat 2013-07-30 932 static void
cpufreq_init_policy(struct cpufreq_policy *policy)
e18f1682 Srivatsa S. Bhat 2013-07-30 933 {
6e2c89d1 viresh kumar 2014-03-04 934 struct cpufreq_governor *gov =
NULL;
e18f1682 Srivatsa S. Bhat 2013-07-30 935 struct cpufreq_policy
new_policy;
e18f1682 Srivatsa S. Bhat 2013-07-30 936 int ret = 0;
e18f1682 Srivatsa S. Bhat 2013-07-30 937
250686bf Viresh Kumar 2014-09-08 @938 policy-governor_state =
CPUFREQ_GOV_POLICY_EXIT;
d5b73cd8 Viresh Kumar 2013-08-06 939 memcpy(new_policy, policy,
sizeof(*policy));
a27a9ab7 Jason Baron 2013-12-19 940
6e2c89d1 viresh kumar 2014-03-04 941 /* Update governor of
new_policy to the governor used before hotplug */
6e2c89d1 viresh kumar 2014-03-04 942 gov =
__find_governor(per_cpu(cpufreq_cpu_governor, policy-cpu));
6e2c89d1 viresh kumar 2014-03-04 943 if (gov)
6e2c89d1 viresh kumar 2014-03-04 944 pr_debug(Restoring
governor %s for cpu %d\n,
6e2c89d1 viresh kumar 2014-03-04 945
policy-governor-name, policy-cpu);
6e2c89d1 viresh kumar 2014-03-04 946 else
---
0-DAY kernel build testing backend Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild Intel Corporation
___
kbuild mailing list
kbuild@lists.01.org
https://lists.01.org/mailman/listinfo/kbuild
___
kbuild mailing list
kbuild@lists.01.org
https://lists.01.org/mailman/listinfo/kbuild
[kbuild] [dhowells-fs:modsign-pkcs7 10/13] crypto/asymmetric_keys/pkcs7_trust.c:90 pkcs7_validate_trust_one() error: we previously assumed 'x509' could be null (see line 43)
TO: David Howells dhowe...@redhat.com
tree: git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs
modsign-pkcs7
head: 1148a967cac3bcea81a6910660ddb6cda7b067d4
commit: 7f2d0d9924b26de3f059972a01cc55fbafb24956 [10/13] PKCS#7: Handle PKCS#7
messages that contain no X.509 certs
:: branch date: 88 minutes ago
:: commit date: 88 minutes ago
crypto/asymmetric_keys/pkcs7_trust.c:90 pkcs7_validate_trust_one() error: we
previously assumed 'x509' could be null (see line 43)
git remote add dhowells-fs
git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs
git remote update dhowells-fs
git checkout 7f2d0d9924b26de3f059972a01cc55fbafb24956
vim +/x509 +90 crypto/asymmetric_keys/pkcs7_trust.c
08815b62 David Howells 2014-07-01 37
0fc6b54f David Howells 2014-09-08 38 if (sinfo-unsupported_crypto) {
0fc6b54f David Howells 2014-09-08 39 kleave( = -ENOPKG [cached]);
0fc6b54f David Howells 2014-09-08 40 return -ENOPKG;
0fc6b54f David Howells 2014-09-08 41 }
0fc6b54f David Howells 2014-09-08 42
08815b62 David Howells 2014-07-01 43 for (x509 = sinfo-signer; x509; x509 =
x509-signer) {
08815b62 David Howells 2014-07-01 44 if (x509-seen) {
08815b62 David Howells 2014-07-01 45 if (x509-verified) {
08815b62 David Howells 2014-07-01 46 trusted =
x509-trusted;
08815b62 David Howells 2014-07-01 47 goto verified;
08815b62 David Howells 2014-07-01 48 }
08815b62 David Howells 2014-07-01 49 kleave( = -ENOKEY
[cached]);
08815b62 David Howells 2014-07-01 50 return -ENOKEY;
08815b62 David Howells 2014-07-01 51 }
08815b62 David Howells 2014-07-01 52 x509-seen = true;
08815b62 David Howells 2014-07-01 53
08815b62 David Howells 2014-07-01 54 /* Look to see if this
certificate is present in the trusted
08815b62 David Howells 2014-07-01 55* keys.
08815b62 David Howells 2014-07-01 56*/
061ab8ff David Howells 2014-09-05 57 key =
x509_request_asymmetric_key(trust_keyring, x509-id);
7f2d0d99 David Howells 2014-09-08 58 if (!IS_ERR(key)) {
08815b62 David Howells 2014-07-01 59 /* One of the X.509
certificates in the PKCS#7 message
08815b62 David Howells 2014-07-01 60* is apparently the
same as one we already trust.
08815b62 David Howells 2014-07-01 61* Verify that the
trusted variant can also validate
08815b62 David Howells 2014-07-01 62* the signature on the
descendant.
08815b62 David Howells 2014-07-01 63*/
7f2d0d99 David Howells 2014-09-08 64 pr_devel(sinfo %u:
Cert %u as key %x\n,
7f2d0d99 David Howells 2014-09-08 65sinfo-index,
x509-index, key_serial(key));
08815b62 David Howells 2014-07-01 66 goto matched;
7f2d0d99 David Howells 2014-09-08 67 }
08815b62 David Howells 2014-07-01 68 if (key == ERR_PTR(-ENOMEM))
08815b62 David Howells 2014-07-01 69 return -ENOMEM;
08815b62 David Howells 2014-07-01 70
08815b62 David Howells 2014-07-01 71/* Self-signed certificates
form roots of their own, and if we
08815b62 David Howells 2014-07-01 72 * don't know them, then we
can't accept them.
08815b62 David Howells 2014-07-01 73 */
08815b62 David Howells 2014-07-01 74 if (x509-next == x509) {
08815b62 David Howells 2014-07-01 75 kleave( = -ENOKEY
[unknown self-signed]);
08815b62 David Howells 2014-07-01 76 return -ENOKEY;
08815b62 David Howells 2014-07-01 77 }
08815b62 David Howells 2014-07-01 78
08815b62 David Howells 2014-07-01 79 might_sleep();
08815b62 David Howells 2014-07-01 80 last = x509;
08815b62 David Howells 2014-07-01 81 sig = last-sig;
08815b62 David Howells 2014-07-01 82 }
08815b62 David Howells 2014-07-01 83
08815b62 David Howells 2014-07-01 84 /* No match - see if the root
certificate has a signer amongst the
08815b62 David Howells 2014-07-01 85* trusted keys.
08815b62 David Howells 2014-07-01 86*/
7f2d0d99 David Howells 2014-09-08 87 if (last last-authority) {
061ab8ff David Howells 2014-09-05 88 key =
x509_request_asymmetric_key(trust_keyring, last-authority);
7f2d0d99 David Howells 2014-09-08 89 if (!IS_ERR(key)) {
7f2d0d99 David Howells 2014-09-08 90 pr_devel(sinfo %u:
Root cert %u signer is key %x\n,
7f2d0d99 David Howells 2014-09-08 91sinfo-index,
x509-index, key_serial(key));
08815b62 David Howells 2014-07-01 92 x509 = last;
7f2d0d99 David Howells 2014-09-08 93 goto matched;
---
0-DAY kernel build testing backend Open Source Technology Center
[kbuild] [next:master 3652/4405] drivers/scsi/fnic/fnic_fcs.c:38:37: sparse: invalid initializer
TO: Hiral Shah his...@cisco.com CC: Christoph Hellwig h...@lst.de CC: Sesidhar Baddela sebad...@cisco.com tree: git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: e8f4bf74c14e3cf0289b103e96f8d58a02d875cf commit: fb0a4482ae1b6a863e03519888aad460ef6aa5c4 [3652/4405] fnic: assign FIP_ALL_FCF_MACS to fcoe_all_fcfs reproduce: make C=1 CF=-D__CHECK_ENDIAN__ :: branch date: 8 hours ago :: commit date: 4 days ago drivers/scsi/fnic/fnic_fcs.c:38:37: sparse: invalid initializer git remote add next git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git git remote update next git checkout fb0a4482ae1b6a863e03519888aad460ef6aa5c4 vim +38 drivers/scsi/fnic/fnic_fcs.c 5df6d737 Abhijeet Joglekar 2009-04-17 22 #include linux/interrupt.h 5df6d737 Abhijeet Joglekar 2009-04-17 23 #include linux/spinlock.h 5df6d737 Abhijeet Joglekar 2009-04-17 24 #include linux/if_ether.h 5df6d737 Abhijeet Joglekar 2009-04-17 25 #include linux/if_vlan.h 5df6d737 Abhijeet Joglekar 2009-04-17 26 #include linux/workqueue.h 78112e55 Joe Eykholt 2009-11-03 27 #include scsi/fc/fc_fip.h 5df6d737 Abhijeet Joglekar 2009-04-17 28 #include scsi/fc/fc_els.h 5df6d737 Abhijeet Joglekar 2009-04-17 29 #include scsi/fc/fc_fcoe.h 5df6d737 Abhijeet Joglekar 2009-04-17 30 #include scsi/fc_frame.h 5df6d737 Abhijeet Joglekar 2009-04-17 31 #include scsi/libfc.h 5df6d737 Abhijeet Joglekar 2009-04-17 32 #include fnic_io.h 5df6d737 Abhijeet Joglekar 2009-04-17 33 #include fnic.h d3c995f1 Hiral Patel 2013-02-25 34 #include fnic_fip.h 5df6d737 Abhijeet Joglekar 2009-04-17 35 #include cq_enet_desc.h 5df6d737 Abhijeet Joglekar 2009-04-17 36 #include cq_exch_desc.h 5df6d737 Abhijeet Joglekar 2009-04-17 37 fb0a4482 Hiral Shah2014-05-02 @38 static u8 fcoe_all_fcfs[ETH_ALEN] = FIP_ALL_FCF_MACS; d3c995f1 Hiral Patel 2013-02-25 39 struct workqueue_struct *fnic_fip_queue; 5df6d737 Abhijeet Joglekar 2009-04-17 40 struct workqueue_struct *fnic_event_queue; 5df6d737 Abhijeet Joglekar 2009-04-17 41 78112e55 Joe Eykholt 2009-11-03 42 static void fnic_set_eth_mode(struct fnic *); d3c995f1 Hiral Patel 2013-02-25 43 static void fnic_fcoe_send_vlan_req(struct fnic *fnic); d3c995f1 Hiral Patel 2013-02-25 44 static void fnic_fcoe_start_fcf_disc(struct fnic *fnic); d3c995f1 Hiral Patel 2013-02-25 45 static void fnic_fcoe_process_vlan_resp(struct fnic *fnic, struct sk_buff *); d3c995f1 Hiral Patel 2013-02-25 46 static int fnic_fcoe_vlan_check(struct fnic *fnic, u16 flag); --- 0-DAY kernel build testing backend Open Source Technology Center http://lists.01.org/mailman/listinfo/kbuild Intel Corporation ___ kbuild mailing list kbuild@lists.01.org https://lists.01.org/mailman/listinfo/kbuild
