date:20141206

[kbuild] [netdev-next:master 16/16] drivers/net/ethernet/intel/i40e/i40e_debugfs.c:832 i40e_dbg_dump_desc() warn: possible memory leak of 'ring'

2014-12-06 Thread kbuild test robot

TO: Joe Perches j...@perches.com
CC: Jeff Kirsher jeffrey.t.kirs...@intel.com

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/net-next.git 
master
head:   e6c97234d1b18d4751671df15d52e29daa8a7ba8
commit: e6c97234d1b18d4751671df15d52e29daa8a7ba8 [16/16] i40e: Reduce stack in 
i40e_dbg_dump_desc
:: branch date: 15 minutes ago
:: commit date: 15 minutes ago

New smatch warnings:
drivers/net/ethernet/intel/i40e/i40e_debugfs.c:832 i40e_dbg_dump_desc() warn: 
possible memory leak of 'ring'

Old smatch warnings:
drivers/net/ethernet/intel/i40e/i40e_debugfs.c:107 i40e_dbg_dump_read() warn: 
maybe return -EFAULT instead of the bytes remaining?
drivers/net/ethernet/intel/i40e/i40e_debugfs.c:357 i40e_dbg_command_read() 
warn: maybe return -EFAULT instead of the bytes remaining?
drivers/net/ethernet/intel/i40e/i40e_debugfs.c:386 i40e_dbg_dump_vsi_seid() 
warn: this array is probably non-NULL. 'vsi-active_vlans'
drivers/net/ethernet/intel/i40e/i40e_debugfs.c:991 i40e_dbg_command_write() 
warn: maybe return -EFAULT instead of the bytes remaining?
drivers/net/ethernet/intel/i40e/i40e_debugfs.c:1971 i40e_dbg_netdev_ops_read() 
warn: maybe return -EFAULT instead of the bytes remaining?
drivers/net/ethernet/intel/i40e/i40e_debugfs.c:2005 i40e_dbg_netdev_ops_write() 
warn: maybe return -EFAULT instead of the bytes remaining?

git remote add netdev-next 
git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/net-next.git
git remote update netdev-next
git checkout e6c97234d1b18d4751671df15d52e29daa8a7ba8
vim +/ring +832 drivers/net/ethernet/intel/i40e/i40e_debugfs.c

68bf94aa Shannon Nelson   2014-01-15  816   
d[%03i] = 0x%016llx 0x%016llx\n,
68bf94aa Shannon Nelson   2014-01-15  817   
 i, rxd-read.pkt_addr,
68bf94aa Shannon Nelson   2014-01-15  818   
 rxd-read.hdr_addr);
68bf94aa Shannon Nelson   2014-01-15  819   } else {
e6c97234 Joe Perches  2014-11-18  820   rxd = 
I40E_RX_DESC(ring, i);
02e9c290 Jesse Brandeburg 2013-09-11  821   
dev_info(pf-pdev-dev,
02e9c290 Jesse Brandeburg 2013-09-11  822   
d[%03i] = 0x%016llx 0x%016llx 0x%016llx 0x%016llx\n,
68bf94aa Shannon Nelson   2014-01-15  823   
 i, rxd-read.pkt_addr,
68bf94aa Shannon Nelson   2014-01-15  824   
 rxd-read.hdr_addr,
68bf94aa Shannon Nelson   2014-01-15  825   
 rxd-read.rsvd1, rxd-read.rsvd2);
68bf94aa Shannon Nelson   2014-01-15  826   }
02e9c290 Jesse Brandeburg 2013-09-11  827   }
02e9c290 Jesse Brandeburg 2013-09-11  828   } else if (cnt == 3) {
e6c97234 Joe Perches  2014-11-18  829   if (desc_n = 
ring-count || desc_n  0) {
02e9c290 Jesse Brandeburg 2013-09-11  830   
dev_info(pf-pdev-dev,
02e9c290 Jesse Brandeburg 2013-09-11  831
descriptor %d not found\n, desc_n);
02e9c290 Jesse Brandeburg 2013-09-11 @832   return;
02e9c290 Jesse Brandeburg 2013-09-11  833   }
68bf94aa Shannon Nelson   2014-01-15  834   if (!is_rx_ring) {
e6c97234 Joe Perches  2014-11-18  835   txd = 
I40E_TX_DESC(ring, desc_n);
02e9c290 Jesse Brandeburg 2013-09-11  836   
dev_info(pf-pdev-dev,
68bf94aa Shannon Nelson   2014-01-15  837vsi = 
%02i tx ring = %02i d[%03i] = 0x%016llx 0x%016llx\n,
68bf94aa Shannon Nelson   2014-01-15  838
vsi_seid, ring_id, desc_n,
68bf94aa Shannon Nelson   2014-01-15  839
txd-buffer_addr, txd-cmd_type_offset_bsz);
68bf94aa Shannon Nelson   2014-01-15  840   } else if (sizeof(union 
i40e_rx_desc) ==

:: The code at line 832 was first introduced by commit
:: 02e9c290814cc143ceccecb14eac3e7a05da745e i40e: debugfs interface

:: TO: Jesse Brandeburg jesse.brandeb...@intel.com
:: CC: Jeff Kirsher jeffrey.t.kirs...@intel.com

---
0-DAY kernel test infrastructureOpen Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild Intel Corporation
___
kbuild mailing list
kbuild@lists.01.org
https://lists.01.org/mailman/listinfo/kbuild

[kbuild] [netdev-next:master 16/16] drivers/net/ethernet/intel/i40e/i40e_debugfs.c:832 i40e_dbg_dump_desc() warn: possible memory leak of 'ring'

2014-12-06 Thread Dan Carpenter

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/net-next.git 
master
head:   e6c97234d1b18d4751671df15d52e29daa8a7ba8
commit: e6c97234d1b18d4751671df15d52e29daa8a7ba8 [16/16] i40e: Reduce stack in 
i40e_dbg_dump_desc

New smatch warnings:
drivers/net/ethernet/intel/i40e/i40e_debugfs.c:832 i40e_dbg_dump_desc() warn: 
possible memory leak of 'ring'

Old smatch warnings:
drivers/net/ethernet/intel/i40e/i40e_debugfs.c:107 i40e_dbg_dump_read() warn: 
maybe return -EFAULT instead of the bytes remaining?
drivers/net/ethernet/intel/i40e/i40e_debugfs.c:357 i40e_dbg_command_read() 
warn: maybe return -EFAULT instead of the bytes remaining?
drivers/net/ethernet/intel/i40e/i40e_debugfs.c:386 i40e_dbg_dump_vsi_seid() 
warn: this array is probably non-NULL. 'vsi-active_vlans'
drivers/net/ethernet/intel/i40e/i40e_debugfs.c:991 i40e_dbg_command_write() 
warn: maybe return -EFAULT instead of the bytes remaining?
drivers/net/ethernet/intel/i40e/i40e_debugfs.c:1971 i40e_dbg_netdev_ops_read() 
warn: maybe return -EFAULT instead of the bytes remaining?
drivers/net/ethernet/intel/i40e/i40e_debugfs.c:2005 i40e_dbg_netdev_ops_write() 
warn: maybe return -EFAULT instead of the bytes remaining?

git remote add netdev-next 
git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/net-next.git
git remote update netdev-next
git checkout e6c97234d1b18d4751671df15d52e29daa8a7ba8
vim +/ring +832 drivers/net/ethernet/intel/i40e/i40e_debugfs.c

68bf94aa Shannon Nelson   2014-01-15  816   
d[%03i] = 0x%016llx 0x%016llx\n,
68bf94aa Shannon Nelson   2014-01-15  817   
 i, rxd-read.pkt_addr,
68bf94aa Shannon Nelson   2014-01-15  818   
 rxd-read.hdr_addr);
68bf94aa Shannon Nelson   2014-01-15  819   } else {
e6c97234 Joe Perches  2014-11-18  820   rxd = 
I40E_RX_DESC(ring, i);
02e9c290 Jesse Brandeburg 2013-09-11  821   
dev_info(pf-pdev-dev,
02e9c290 Jesse Brandeburg 2013-09-11  822   
d[%03i] = 0x%016llx 0x%016llx 0x%016llx 0x%016llx\n,
68bf94aa Shannon Nelson   2014-01-15  823   
 i, rxd-read.pkt_addr,
68bf94aa Shannon Nelson   2014-01-15  824   
 rxd-read.hdr_addr,
68bf94aa Shannon Nelson   2014-01-15  825   
 rxd-read.rsvd1, rxd-read.rsvd2);
68bf94aa Shannon Nelson   2014-01-15  826   }
02e9c290 Jesse Brandeburg 2013-09-11  827   }
02e9c290 Jesse Brandeburg 2013-09-11  828   } else if (cnt == 3) {
e6c97234 Joe Perches  2014-11-18  829   if (desc_n = 
ring-count || desc_n  0) {
02e9c290 Jesse Brandeburg 2013-09-11  830   
dev_info(pf-pdev-dev,
02e9c290 Jesse Brandeburg 2013-09-11  831
descriptor %d not found\n, desc_n);
02e9c290 Jesse Brandeburg 2013-09-11 @832   return;
02e9c290 Jesse Brandeburg 2013-09-11  833   }
68bf94aa Shannon Nelson   2014-01-15  834   if (!is_rx_ring) {
e6c97234 Joe Perches  2014-11-18  835   txd = 
I40E_TX_DESC(ring, desc_n);
02e9c290 Jesse Brandeburg 2013-09-11  836   
dev_info(pf-pdev-dev,
68bf94aa Shannon Nelson   2014-01-15  837vsi = 
%02i tx ring = %02i d[%03i] = 0x%016llx 0x%016llx\n,
68bf94aa Shannon Nelson   2014-01-15  838
vsi_seid, ring_id, desc_n,
68bf94aa Shannon Nelson   2014-01-15  839
txd-buffer_addr, txd-cmd_type_offset_bsz);
68bf94aa Shannon Nelson   2014-01-15  840   } else if (sizeof(union 
i40e_rx_desc) ==

---
0-DAY kernel test infrastructureOpen Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild Intel Corporation
___
kbuild mailing list
kbuild@lists.01.org
https://lists.01.org/mailman/listinfo/kbuild

[kbuild] [netdev-next:master 16/16] drivers/net/ethernet/intel/i40e/i40e_debugfs.c:832 i40e_dbg_dump_desc() warn: possible memory leak of 'ring'

[kbuild] [netdev-next:master 16/16] drivers/net/ethernet/intel/i40e/i40e_debugfs.c:832 i40e_dbg_dump_desc() warn: possible memory leak of 'ring'

2 matches

Site Navigation

Mail list logo

Footer information