Re: [kbuild] [daniel.lezcano:chromebook2 10152/10189] drivers/input/touchscreen/atmel_mxt_ts.c:1592 mxt_get_object_table() warn: assigning (-2) to unsigned variable 'data-num_touchids'
So long as we trust the firmware to give good data then this code is fine. regards, dan carpenter On Sat, Dec 13, 2014 at 12:10:16AM +0800, kbuild test robot wrote: TO: Nick Dyer nick.d...@itdev.co.uk CC: Kevin Hilman khil...@linaro.org CC: Javier Martinez Canillas javier.marti...@collabora.co.uk tree: https://git.linaro.org/people/daniel.lezcano/linux chromebook2 head: 4002075ccb928a8b1d02e8067b36591ecfc9bab5 commit: 06b74cff1f9b3714be351a2e864a8903ae3b6f1e [10152/10189] Input: atmel_mxt_ts - implement support for T100 touch object :: branch date: 22 hours ago :: commit date: 3 days ago drivers/input/touchscreen/atmel_mxt_ts.c:1592 mxt_get_object_table() warn: assigning (-2) to unsigned variable 'data-num_touchids' drivers/input/touchscreen/atmel_mxt_ts.c:1875 mxt_initialize_t100_input_device() warn: variable dereferenced before check 'data' (see line 1866) git remote add daniel.lezcano https://git.linaro.org/people/daniel.lezcano/linux git remote update daniel.lezcano git checkout 06b74cff1f9b3714be351a2e864a8903ae3b6f1e vim +1592 drivers/input/touchscreen/atmel_mxt_ts.c 333e5a9a drivers/input/touchscreen/atmel_mxt_ts.c Daniel Kurtz 2012-06-28 1576 case MXT_TOUCH_MULTI_T9: 333e5a9a drivers/input/touchscreen/atmel_mxt_ts.c Daniel Kurtz 2012-06-28 1577 data-T9_reportid_min = min_id; 333e5a9a drivers/input/touchscreen/atmel_mxt_ts.c Daniel Kurtz 2012-06-28 1578 data-T9_reportid_max = max_id; 9d8dc3e5 drivers/input/touchscreen/atmel_mxt_ts.c Nick Dyer 2014-07-23 1579 data-num_touchids = object-num_report_ids 9d8dc3e5 drivers/input/touchscreen/atmel_mxt_ts.c Nick Dyer 2014-07-23 1580 * mxt_obj_instances(object); 9d8dc3e5 drivers/input/touchscreen/atmel_mxt_ts.c Nick Dyer 2014-07-23 1581 break; 9d8dc3e5 drivers/input/touchscreen/atmel_mxt_ts.c Nick Dyer 2014-07-23 1582 case MXT_SPT_MESSAGECOUNT_T44: 9d8dc3e5 drivers/input/touchscreen/atmel_mxt_ts.c Nick Dyer 2014-07-23 1583 data-T44_address = object-start_address; 333e5a9a drivers/input/touchscreen/atmel_mxt_ts.c Daniel Kurtz 2012-06-28 1584 break; 22dfab7f drivers/input/touchscreen/atmel_mxt_ts.c Daniel Kurtz 2013-03-07 1585 case MXT_SPT_GPIOPWM_T19: 22dfab7f drivers/input/touchscreen/atmel_mxt_ts.c Daniel Kurtz 2013-03-07 1586 data-T19_reportid = min_id; 22dfab7f drivers/input/touchscreen/atmel_mxt_ts.c Daniel Kurtz 2013-03-07 1587 break; 06b74cff drivers/input/touchscreen/atmel_mxt_ts.c Nick Dyer 2014-08-27 1588 case MXT_TOUCH_MULTITOUCHSCREEN_T100: 06b74cff drivers/input/touchscreen/atmel_mxt_ts.c Nick Dyer 2014-08-27 1589 data-T100_reportid_min = min_id; 06b74cff drivers/input/touchscreen/atmel_mxt_ts.c Nick Dyer 2014-08-27 1590 data-T100_reportid_max = max_id; 06b74cff drivers/input/touchscreen/atmel_mxt_ts.c Nick Dyer 2014-08-27 1591 /* first two report IDs reserved */ 06b74cff drivers/input/touchscreen/atmel_mxt_ts.c Nick Dyer 2014-08-27 @1592 data-num_touchids = object-num_report_ids - 2; 06b74cff drivers/input/touchscreen/atmel_mxt_ts.c Nick Dyer 2014-08-27 1593 break; 4cf51c38 drivers/input/touchscreen/qt602240_ts.c Joonyoung Shim 2010-07-14 1594 } 4ce6fa01 drivers/input/touchscreen/atmel_mxt_ts.c Nick Dyer 2014-07-23 1595 4ce6fa01 drivers/input/touchscreen/atmel_mxt_ts.c Nick Dyer 2014-07-23 1596 end_address = object-start_address 4ce6fa01 drivers/input/touchscreen/atmel_mxt_ts.c Nick Dyer 2014-07-23 1597 + mxt_obj_size(object) * mxt_obj_instances(object) - 1; 4ce6fa01 drivers/input/touchscreen/atmel_mxt_ts.c Nick Dyer 2014-07-23 1598 4ce6fa01 drivers/input/touchscreen/atmel_mxt_ts.c Nick Dyer 2014-07-23 1599 if (end_address = data-mem_size) 4ce6fa01 drivers/input/touchscreen/atmel_mxt_ts.c Nick Dyer 2014-07-23 1600 data-mem_size = end_address + 1; --- 0-DAY kernel test infrastructureOpen Source Technology Center http://lists.01.org/mailman/listinfo/kbuild Intel Corporation ___ kbuild mailing list kbuild@lists.01.org https://lists.01.org/mailman/listinfo/kbuild
[kbuild] [socfpga-nex:for_next-fpgamgr-without-overlays-v4.3 7/9] drivers/staging/fpga/fpga-mgr.c:425 fpga_mgr_register() warn: possible memory leak of 'mgr'
TO: Alan Tull at...@opensource.altera.com
tree: git://git.rocketboards.org/linux-socfpga-next
for_next-fpgamgr-without-overlays-v4.3
head: 7920447fc75922e9a72db640cddf890d75a30e0d
commit: 8d6817a5d6d24010a3b3acc976f09b61fb65ee92 [7/9] staging: fpga manager:
framework core
:: branch date: 3 days ago
:: commit date: 3 days ago
drivers/staging/fpga/fpga-mgr.c:425 fpga_mgr_register() warn: possible memory
leak of 'mgr'
git remote add socfpga-nex git://git.rocketboards.org/linux-socfpga-next
git remote update socfpga-nex
git checkout 8d6817a5d6d24010a3b3acc976f09b61fb65ee92
vim +/mgr +425 drivers/staging/fpga/fpga-mgr.c
8d6817a5 Alan Tull 2014-10-16 409 int fpga_mgr_register(struct device *dev,
const char *name,
8d6817a5 Alan Tull 2014-10-16 410struct fpga_manager_ops
*mops,
8d6817a5 Alan Tull 2014-10-16 411void *priv)
8d6817a5 Alan Tull 2014-10-16 412 {
8d6817a5 Alan Tull 2014-10-16 413 struct fpga_manager *mgr;
8d6817a5 Alan Tull 2014-10-16 414 int id, ret;
8d6817a5 Alan Tull 2014-10-16 415
8d6817a5 Alan Tull 2014-10-16 416 if (!mops || !name || !strlen(name))
8d6817a5 Alan Tull 2014-10-16 417 return -EINVAL;
8d6817a5 Alan Tull 2014-10-16 418
8d6817a5 Alan Tull 2014-10-16 419 mgr = kzalloc(sizeof(*mgr), GFP_KERNEL);
8d6817a5 Alan Tull 2014-10-16 420 if (!mgr)
8d6817a5 Alan Tull 2014-10-16 421 return -ENOMEM;
8d6817a5 Alan Tull 2014-10-16 422
8d6817a5 Alan Tull 2014-10-16 423 id = ida_simple_get(fpga_mgr_ida, 0,
0, GFP_KERNEL);
8d6817a5 Alan Tull 2014-10-16 424 if (id 0)
8d6817a5 Alan Tull 2014-10-16 @425 return id;
8d6817a5 Alan Tull 2014-10-16 426
8d6817a5 Alan Tull 2014-10-16 427 mutex_init(mgr-lock);
8d6817a5 Alan Tull 2014-10-16 428
8d6817a5 Alan Tull 2014-10-16 429 mgr-name = name;
8d6817a5 Alan Tull 2014-10-16 430 mgr-mops = mops;
8d6817a5 Alan Tull 2014-10-16 431 mgr-priv = priv;
8d6817a5 Alan Tull 2014-10-16 432
8d6817a5 Alan Tull 2014-10-16 433 /*
---
0-DAY kernel test infrastructureOpen Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild Intel Corporation
___
kbuild mailing list
kbuild@lists.01.org
https://lists.01.org/mailman/listinfo/kbuild
[kbuild] [netdev-next:master 16/16] drivers/net/ethernet/intel/i40e/i40e_debugfs.c:832 i40e_dbg_dump_desc() warn: possible memory leak of 'ring'
tree: git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/net-next.git
master
head: e6c97234d1b18d4751671df15d52e29daa8a7ba8
commit: e6c97234d1b18d4751671df15d52e29daa8a7ba8 [16/16] i40e: Reduce stack in
i40e_dbg_dump_desc
New smatch warnings:
drivers/net/ethernet/intel/i40e/i40e_debugfs.c:832 i40e_dbg_dump_desc() warn:
possible memory leak of 'ring'
Old smatch warnings:
drivers/net/ethernet/intel/i40e/i40e_debugfs.c:107 i40e_dbg_dump_read() warn:
maybe return -EFAULT instead of the bytes remaining?
drivers/net/ethernet/intel/i40e/i40e_debugfs.c:357 i40e_dbg_command_read()
warn: maybe return -EFAULT instead of the bytes remaining?
drivers/net/ethernet/intel/i40e/i40e_debugfs.c:386 i40e_dbg_dump_vsi_seid()
warn: this array is probably non-NULL. 'vsi-active_vlans'
drivers/net/ethernet/intel/i40e/i40e_debugfs.c:991 i40e_dbg_command_write()
warn: maybe return -EFAULT instead of the bytes remaining?
drivers/net/ethernet/intel/i40e/i40e_debugfs.c:1971 i40e_dbg_netdev_ops_read()
warn: maybe return -EFAULT instead of the bytes remaining?
drivers/net/ethernet/intel/i40e/i40e_debugfs.c:2005 i40e_dbg_netdev_ops_write()
warn: maybe return -EFAULT instead of the bytes remaining?
vim +/ring +832 drivers/net/ethernet/intel/i40e/i40e_debugfs.c
68bf94aa Shannon Nelson 2014-01-15 816
d[%03i] = 0x%016llx 0x%016llx\n,
68bf94aa Shannon Nelson 2014-01-15 817
i, rxd-read.pkt_addr,
68bf94aa Shannon Nelson 2014-01-15 818
rxd-read.hdr_addr);
68bf94aa Shannon Nelson 2014-01-15 819 } else {
e6c97234 Joe Perches 2014-11-18 820 rxd =
I40E_RX_DESC(ring, i);
02e9c290 Jesse Brandeburg 2013-09-11 821
dev_info(pf-pdev-dev,
02e9c290 Jesse Brandeburg 2013-09-11 822
d[%03i] = 0x%016llx 0x%016llx 0x%016llx 0x%016llx\n,
68bf94aa Shannon Nelson 2014-01-15 823
i, rxd-read.pkt_addr,
68bf94aa Shannon Nelson 2014-01-15 824
rxd-read.hdr_addr,
68bf94aa Shannon Nelson 2014-01-15 825
rxd-read.rsvd1, rxd-read.rsvd2);
68bf94aa Shannon Nelson 2014-01-15 826 }
02e9c290 Jesse Brandeburg 2013-09-11 827 }
02e9c290 Jesse Brandeburg 2013-09-11 828 } else if (cnt == 3) {
e6c97234 Joe Perches 2014-11-18 829 if (desc_n =
ring-count || desc_n 0) {
02e9c290 Jesse Brandeburg 2013-09-11 830
dev_info(pf-pdev-dev,
02e9c290 Jesse Brandeburg 2013-09-11 831
descriptor %d not found\n, desc_n);
02e9c290 Jesse Brandeburg 2013-09-11 @832 return;
02e9c290 Jesse Brandeburg 2013-09-11 833 }
68bf94aa Shannon Nelson 2014-01-15 834 if (!is_rx_ring) {
e6c97234 Joe Perches 2014-11-18 835 txd =
I40E_TX_DESC(ring, desc_n);
02e9c290 Jesse Brandeburg 2013-09-11 836
dev_info(pf-pdev-dev,
68bf94aa Shannon Nelson 2014-01-15 837vsi =
%02i tx ring = %02i d[%03i] = 0x%016llx 0x%016llx\n,
68bf94aa Shannon Nelson 2014-01-15 838
vsi_seid, ring_id, desc_n,
68bf94aa Shannon Nelson 2014-01-15 839
txd-buffer_addr, txd-cmd_type_offset_bsz);
68bf94aa Shannon Nelson 2014-01-15 840 } else if (sizeof(union
i40e_rx_desc) ==
---
0-DAY kernel test infrastructureOpen Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild Intel Corporation
___
kbuild mailing list
kbuild@lists.01.org
https://lists.01.org/mailman/listinfo/kbuild
