[kbuild] arch/riscv/kernel/cpufeature.c:288:27: warning: Parameter 'end' can be declared with const [constParameter]
:: :: Manual check reason: "low confidence static check warning: arch/riscv/kernel/cpufeature.c:288:27: warning: Parameter 'end' can be declared with const [constParameter]" :: BCC: l...@intel.com CC: kbuild-...@lists.01.org CC: linux-ker...@vger.kernel.org TO: Heiko Stuebner CC: Palmer Dabbelt CC: Wei Fu CC: Liu Shaohua CC: Guo Ren CC: Philipp Tomsich tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: c40e8341e3b3bb27e3a65b06b5b454626234c4f0 commit: ff689fd21cb13098305bae3f8d0c0065df2e2fc1 riscv: add RISC-V Svpbmt extension support date: 4 months ago :: branch date: 27 hours ago :: commit date: 4 months ago compiler: riscv64-linux-gcc (GCC) 12.1.0 reproduce (cppcheck warning): # apt-get install cppcheck git checkout ff689fd21cb13098305bae3f8d0c0065df2e2fc1 cppcheck --quiet --enable=style,performance,portability --template=gcc FILE If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot cppcheck possible warnings: (new ones prefixed by >>, may not real problems) >> arch/riscv/kernel/cpufeature.c:288:27: warning: Parameter 'end' can be >> declared with const [constParameter] struct alt_entry *end, ^ -- >> block/blk-throttle.c:1484:3: warning: %llu in format string (no. 1) requires >> 'unsigned long long' but the argument type is 'unsigned long'. >> [invalidPrintfArgType_uint] snprintf(bufs[0], sizeof(bufs[0]), "%llu", ^ block/blk-throttle.c:1487:3: warning: %llu in format string (no. 1) requires 'unsigned long long' but the argument type is 'unsigned long'. [invalidPrintfArgType_uint] snprintf(bufs[1], sizeof(bufs[1]), "%llu", ^ >> block/blk-throttle.c:1814:21: warning: Parameter 'this_tg' can be declared >> with const [constParameter] struct throtl_grp *this_tg) ^ vim +/end +288 arch/riscv/kernel/cpufeature.c ff689fd21cb130 Heiko Stuebner 2022-05-11 286 ff689fd21cb130 Heiko Stuebner 2022-05-11 287 void __init_or_module riscv_cpufeature_patch_func(struct alt_entry *begin, ff689fd21cb130 Heiko Stuebner 2022-05-11 @288 struct alt_entry *end, -- 0-DAY CI Kernel Test Service https://01.org/lkp ___ kbuild mailing list -- kbuild@lists.01.org To unsubscribe send an email to kbuild-le...@lists.01.org
[kbuild] net/mac80211/tx.c:2916 ieee80211_build_hdr() error: testing array offset 'link_id' after use.
BCC: l...@intel.com
CC: kbuild-...@lists.01.org
CC: linux-ker...@vger.kernel.org
TO: Johannes Berg
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
master
head: c40e8341e3b3bb27e3a65b06b5b454626234c4f0
commit: 9dd1953846c7cd58100a5c6bd90db54e2c60668a wifi: nl80211/mac80211:
clarify link ID in control port TX
date: 5 weeks ago
:: branch date: 20 hours ago
:: commit date: 5 weeks ago
config: openrisc-randconfig-m031-20220824
(https://download.01.org/0day-ci/archive/20220825/202208250601.jxpuiekb-...@intel.com/config)
compiler: or1k-linux-gcc (GCC) 12.1.0
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot
Reported-by: Dan Carpenter
New smatch warnings:
net/mac80211/tx.c:2916 ieee80211_build_hdr() error: testing array offset
'link_id' after use.
Old smatch warnings:
net/mac80211/tx.c:1846 invoke_tx_handlers_late() warn: variable dereferenced
before check 'tx->skb' (see line 1821)
net/mac80211/tx.c:3509 ieee80211_xmit_fast_finish() error: we previously
assumed 'key' could be null (see line 3477)
vim +/link_id +2916 net/mac80211/tx.c
33b64eb2b1b1759 Luis Carlos Cobo 2008-02-23 2877
065e9605f941b8b Harvey Harrison 2008-06-22 2878 if
(ieee80211_is_data_qos(fc)) {
c29b9b9b0235d56 Johannes Berg2007-09-14 2879 __le16
*qos_control;
c29b9b9b0235d56 Johannes Berg2007-09-14 2880
d58ff35122847a8 Johannes Berg2017-06-16 2881 qos_control =
skb_push(skb, 2);
c29b9b9b0235d56 Johannes Berg2007-09-14 2882
memcpy(skb_push(skb, hdrlen - 2), , hdrlen - 2);
c29b9b9b0235d56 Johannes Berg2007-09-14 2883 /*
c29b9b9b0235d56 Johannes Berg2007-09-14 2884* Maybe we
could actually set some fields here, for now just
c29b9b9b0235d56 Johannes Berg2007-09-14 2885* initialise
to zero to indicate no special operation.
c29b9b9b0235d56 Johannes Berg2007-09-14 2886*/
c29b9b9b0235d56 Johannes Berg2007-09-14 2887 *qos_control =
0;
c29b9b9b0235d56 Johannes Berg2007-09-14 2888 } else
e2ebc74d7e3d716 Johannes Berg2007-07-27 2889
memcpy(skb_push(skb, hdrlen), , hdrlen);
c29b9b9b0235d56 Johannes Berg2007-09-14 2890
d57a544d71092a8 Zhang Shengju2016-03-03 2891
skb_reset_mac_header(skb);
e2ebc74d7e3d716 Johannes Berg2007-07-27 2892
489ee9195a7de9e Felix Fietkau2010-12-18 2893 info =
IEEE80211_SKB_CB(skb);
3b8d81e020f77c9 Johannes Berg2009-06-17 2894 memset(info, 0,
sizeof(*info));
3b8d81e020f77c9 Johannes Berg2009-06-17 2895
a729cff8ad5120d Johannes Berg2011-11-06 2896 info->flags =
info_flags;
a729cff8ad5120d Johannes Berg2011-11-06 2897 info->ack_frame_id =
info_id;
73c4e195e6396ee Johannes Berg2014-11-09 2898 info->band = band;
9dd1953846c7cd5 Johannes Berg2022-07-19 2899
9dd1953846c7cd5 Johannes Berg2022-07-19 2900 if (likely(!cookie)) {
9dd1953846c7cd5 Johannes Berg2022-07-19 2901 ctrl_flags |=
u32_encode_bits(link_id,
69d41b5a9c9d8d2 Johannes Berg2022-06-09 2902
IEEE80211_TX_CTRL_MLO_LINK);
9dd1953846c7cd5 Johannes Berg2022-07-19 2903 } else {
9dd1953846c7cd5 Johannes Berg2022-07-19 2904 unsigned int
pre_conf_link_id;
9dd1953846c7cd5 Johannes Berg2022-07-19 2905
9dd1953846c7cd5 Johannes Berg2022-07-19 2906 /*
9dd1953846c7cd5 Johannes Berg2022-07-19 2907* ctrl_flags
already have been set by
9dd1953846c7cd5 Johannes Berg2022-07-19 2908*
ieee80211_tx_control_port(), here
9dd1953846c7cd5 Johannes Berg2022-07-19 2909* we just
sanity check that
9dd1953846c7cd5 Johannes Berg2022-07-19 2910*/
9dd1953846c7cd5 Johannes Berg2022-07-19 2911
9dd1953846c7cd5 Johannes Berg2022-07-19 2912
pre_conf_link_id = u32_get_bits(ctrl_flags,
9dd1953846c7cd5 Johannes Berg2022-07-19 2913
IEEE80211_TX_CTRL_MLO_LINK);
9dd1953846c7cd5 Johannes Berg2022-07-19 2914
9dd1953846c7cd5 Johannes Berg2022-07-19 2915 if
(pre_conf_link_id != link_id &&
9dd1953846c7cd5 Johannes Berg2022-07-19 @2916 link_id !=
IEEE80211_LINK_UNSPECIFIED) {
9dd1953846c7cd5 Johannes Berg2022-07-19 2917 #ifdef
CPTCFG_MAC80211_VERBOSE_DEBUG
9dd1953846c7cd5 Johannes Berg2022-07-19 2918
net_info_ratelimited("%s: dropped frame to %pM with bad link ID request (%d vs.
%d)\n",
9dd1953846c7cd5 Johannes Berg2022-07-19 2919
sdata->name, hdr.addr1,
9dd1953846c7cd5 Johannes Berg2022-07-19 2920
pre_conf_l
[kbuild] drivers/net/phy/phylink.c:887 phylink_change_inband_advert() error: we previously assumed 'pl->pcs' could be null (see line 870)
BCC: l...@intel.com
CC: kbuild-...@lists.01.org
CC: linux-ker...@vger.kernel.org
TO: "Russell King (Oracle)"
CC: Jakub Kicinski
CC: Andrew Lunn
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
master
head: c40e8341e3b3bb27e3a65b06b5b454626234c4f0
commit: 4f1dd48f403149dc720a24c54120749433c4b984 net: phylink: remove pcs_ops
member
date: 8 weeks ago
:: branch date: 14 hours ago
:: commit date: 8 weeks ago
config: openrisc-randconfig-m031-20220824
(https://download.01.org/0day-ci/archive/20220825/202208250056.trybiaak-...@intel.com/config)
compiler: or1k-linux-gcc (GCC) 12.1.0
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot
Reported-by: Dan Carpenter
smatch warnings:
drivers/net/phy/phylink.c:887 phylink_change_inband_advert() error: we
previously assumed 'pl->pcs' could be null (see line 870)
vim +887 drivers/net/phy/phylink.c
9525ae83959b60 Russell King 2017-07-25 856
1571e700fd610c Russell King 2020-07-21 857 /*
1571e700fd610c Russell King 2020-07-21 858 * Reconfigure for a
change of inband advertisement.
1571e700fd610c Russell King 2020-07-21 859 * If we have a separate
PCS, we only need to call its pcs_config() method,
1571e700fd610c Russell King 2020-07-21 860 * and then restart AN if
it indicates something changed. Otherwise, we do
1571e700fd610c Russell King 2020-07-21 861 * the full MAC
reconfiguration.
1571e700fd610c Russell King 2020-07-21 862 */
1571e700fd610c Russell King 2020-07-21 863 static int
phylink_change_inband_advert(struct phylink *pl)
1571e700fd610c Russell King 2020-07-21 864 {
1571e700fd610c Russell King 2020-07-21 865int ret;
1571e700fd610c Russell King 2020-07-21 866
1571e700fd610c Russell King 2020-07-21 867if
(test_bit(PHYLINK_DISABLE_STOPPED, >phylink_disable_state))
1571e700fd610c Russell King 2020-07-21 868return 0;
1571e700fd610c Russell King 2020-07-21 869
4f1dd48f403149 Russell King (Oracle 2022-06-27 @870) if (!pl->pcs &&
pl->config->legacy_pre_march2020) {
1571e700fd610c Russell King 2020-07-21 871/* Legacy
method */
1571e700fd610c Russell King 2020-07-21 872
phylink_mac_config(pl, >link_config);
1571e700fd610c Russell King 2020-07-21 873
phylink_mac_pcs_an_restart(pl);
1571e700fd610c Russell King 2020-07-21 874return 0;
1571e700fd610c Russell King 2020-07-21 875}
1571e700fd610c Russell King 2020-07-21 876
1571e700fd610c Russell King 2020-07-21 877phylink_dbg(pl, "%s:
mode=%s/%s adv=%*pb pause=%02x\n", __func__,
1571e700fd610c Russell King 2020-07-21 878
phylink_an_mode_str(pl->cur_link_an_mode),
1571e700fd610c Russell King 2020-07-21 879
phy_modes(pl->link_config.interface),
1571e700fd610c Russell King 2020-07-21 880
__ETHTOOL_LINK_MODE_MASK_NBITS, pl->link_config.advertising,
1571e700fd610c Russell King 2020-07-21 881
pl->link_config.pause);
1571e700fd610c Russell King 2020-07-21 882
1571e700fd610c Russell King 2020-07-21 883/* Modern PCS-based
method; update the advert at the PCS, and
1571e700fd610c Russell King 2020-07-21 884 * restart negotiation
if the pcs_config() helper indicates that
1571e700fd610c Russell King 2020-07-21 885 * the programmed
advertisement has changed.
1571e700fd610c Russell King 2020-07-21 886 */
4f1dd48f403149 Russell King (Oracle 2022-06-27 @887) ret =
pl->pcs->ops->pcs_config(pl->pcs, pl->cur_link_an_mode,
1571e700fd610c Russell King 2020-07-21 888
pl->link_config.interface,
1571e700fd610c Russell King 2020-07-21 889
pl->link_config.advertising,
4f1dd48f403149 Russell King (Oracle 2022-06-27 890)
!!(pl->link_config.pause &
4f1dd48f403149 Russell King (Oracle 2022-06-27 891)
MLO_PAUSE_AN));
1571e700fd610c Russell King 2020-07-21 892if (ret < 0)
1571e700fd610c Russell King 2020-07-21 893return ret;
1571e700fd610c Russell King 2020-07-21 894
1571e700fd610c Russell King 2020-07-21 895if (ret > 0)
1571e700fd610c Russell King 2020-07-21 896
phylink_mac_pcs_an_restart(pl);
1571e700fd610c Russell King 2020-07-21 897
1571e700fd610c Russell King 2020-07-21 898return 0;
1571e700fd610c Russell King 2020-07-21 899 }
1571e700fd610c Russell King 2020-07-21 900
--
0-DAY CI Kernel Test Se
[kbuild] drivers/net/dsa/realtek/rtl8365mb.c:1391 rtl8365mb_stats_update() error: uninitialized symbol 'ret'.
BCC: l...@intel.com
CC: kbuild-...@lists.01.org
CC: linux-ker...@vger.kernel.org
TO: "Alvin Šipraga"
Hi Alvin,
First bad commit (maybe != root cause):
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
master
head: c40e8341e3b3bb27e3a65b06b5b454626234c4f0
commit: 2511e0c87786f333c4665508f421ac99e378c719 net: dsa: realtek: fix Kconfig
to assure consistent driver linkage
date: 4 months ago
:: branch date: 11 hours ago
:: commit date: 4 months ago
config: openrisc-randconfig-m031-20220824
(https://download.01.org/0day-ci/archive/20220824/202208242139.0eddbkzo-...@intel.com/config)
compiler: or1k-linux-gcc (GCC) 12.1.0
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot
Reported-by: Dan Carpenter
smatch warnings:
drivers/net/dsa/realtek/rtl8365mb.c:1391 rtl8365mb_stats_update() error:
uninitialized symbol 'ret'.
vim +/ret +1391 drivers/net/dsa/realtek/rtl8365mb.c
4af2950c50c863 drivers/net/dsa/rtl8365mb.c Alvin Šipraga
2021-10-18 1348
f5f119077b1cd6 drivers/net/dsa/realtek/rtl8365mb.c Luiz Angelo Daros de Luca
2022-01-28 1349 static void rtl8365mb_stats_update(struct realtek_priv *priv,
int port)
4af2950c50c863 drivers/net/dsa/rtl8365mb.c Alvin Šipraga
2021-10-18 1350 {
4af2950c50c863 drivers/net/dsa/rtl8365mb.c Alvin Šipraga
2021-10-18 1351 u64 cnt[RTL8365MB_MIB_END] = {
4af2950c50c863 drivers/net/dsa/rtl8365mb.c Alvin Šipraga
2021-10-18 1352 [RTL8365MB_MIB_ifOutOctets] = 1,
4af2950c50c863 drivers/net/dsa/rtl8365mb.c Alvin Šipraga
2021-10-18 1353 [RTL8365MB_MIB_ifOutUcastPkts] = 1,
4af2950c50c863 drivers/net/dsa/rtl8365mb.c Alvin Šipraga
2021-10-18 1354 [RTL8365MB_MIB_ifOutMulticastPkts] = 1,
4af2950c50c863 drivers/net/dsa/rtl8365mb.c Alvin Šipraga
2021-10-18 1355 [RTL8365MB_MIB_ifOutBroadcastPkts] = 1,
4af2950c50c863 drivers/net/dsa/rtl8365mb.c Alvin Šipraga
2021-10-18 1356 [RTL8365MB_MIB_ifOutDiscards] = 1,
4af2950c50c863 drivers/net/dsa/rtl8365mb.c Alvin Šipraga
2021-10-18 1357 [RTL8365MB_MIB_ifInOctets] = 1,
4af2950c50c863 drivers/net/dsa/rtl8365mb.c Alvin Šipraga
2021-10-18 1358 [RTL8365MB_MIB_ifInUcastPkts] = 1,
4af2950c50c863 drivers/net/dsa/rtl8365mb.c Alvin Šipraga
2021-10-18 1359 [RTL8365MB_MIB_ifInMulticastPkts] = 1,
4af2950c50c863 drivers/net/dsa/rtl8365mb.c Alvin Šipraga
2021-10-18 1360 [RTL8365MB_MIB_ifInBroadcastPkts] = 1,
4af2950c50c863 drivers/net/dsa/rtl8365mb.c Alvin Šipraga
2021-10-18 1361 [RTL8365MB_MIB_etherStatsDropEvents] = 1,
4af2950c50c863 drivers/net/dsa/rtl8365mb.c Alvin Šipraga
2021-10-18 1362 [RTL8365MB_MIB_etherStatsCollisions] = 1,
4af2950c50c863 drivers/net/dsa/rtl8365mb.c Alvin Šipraga
2021-10-18 1363 [RTL8365MB_MIB_etherStatsFragments] = 1,
4af2950c50c863 drivers/net/dsa/rtl8365mb.c Alvin Šipraga
2021-10-18 1364 [RTL8365MB_MIB_etherStatsJabbers] = 1,
4af2950c50c863 drivers/net/dsa/rtl8365mb.c Alvin Šipraga
2021-10-18 1365 [RTL8365MB_MIB_dot3StatsFCSErrors] = 1,
4af2950c50c863 drivers/net/dsa/rtl8365mb.c Alvin Šipraga
2021-10-18 1366 [RTL8365MB_MIB_dot3StatsLateCollisions] = 1,
4af2950c50c863 drivers/net/dsa/rtl8365mb.c Alvin Šipraga
2021-10-18 1367 };
f5f119077b1cd6 drivers/net/dsa/realtek/rtl8365mb.c Luiz Angelo Daros de Luca
2022-01-28 1368 struct rtl8365mb *mb = priv->chip_data;
4af2950c50c863 drivers/net/dsa/rtl8365mb.c Alvin Šipraga
2021-10-18 1369 struct rtnl_link_stats64 *stats;
4af2950c50c863 drivers/net/dsa/rtl8365mb.c Alvin Šipraga
2021-10-18 1370 int ret;
4af2950c50c863 drivers/net/dsa/rtl8365mb.c Alvin Šipraga
2021-10-18 1371 int i;
4af2950c50c863 drivers/net/dsa/rtl8365mb.c Alvin Šipraga
2021-10-18 1372
4af2950c50c863 drivers/net/dsa/rtl8365mb.c Alvin Šipraga
2021-10-18 1373 stats = >ports[port].stats;
4af2950c50c863 drivers/net/dsa/rtl8365mb.c Alvin Šipraga
2021-10-18 1374
4af2950c50c863 drivers/net/dsa/rtl8365mb.c Alvin Šipraga
2021-10-18 1375 mutex_lock(>mib_lock);
4af2950c50c863 drivers/net/dsa/rtl8365mb.c Alvin Šipraga
2021-10-18 1376 for (i = 0; i < RTL8365MB_MIB_END; i++) {
4af2950c50c863 drivers/net/dsa/rtl8365mb.c Alvin Šipraga
2021-10-18 1377 struct rtl8365mb_mib_counter *c =
_mib_counters[i];
4af2950c50c863 drivers/net/dsa/rtl8365mb.c
[kbuild] drivers/net/dsa/realtek/rtl8365mb.c:1391 rtl8365mb_stats_update() error: uninitialized symbol 'ret'.
BCC: l...@intel.com
CC: kbuild-...@lists.01.org
CC: linux-ker...@vger.kernel.org
TO: "Alvin Šipraga"
Hi Alvin,
First bad commit (maybe != root cause):
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
master
head: c40e8341e3b3bb27e3a65b06b5b454626234c4f0
commit: 2511e0c87786f333c4665508f421ac99e378c719 net: dsa: realtek: fix Kconfig
to assure consistent driver linkage
date: 4 months ago
:: branch date: 10 hours ago
:: commit date: 4 months ago
config: openrisc-randconfig-m031-20220824
(https://download.01.org/0day-ci/archive/20220824/202208242050.9wfsnrta-...@intel.com/config)
compiler: or1k-linux-gcc (GCC) 12.1.0
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot
Reported-by: Dan Carpenter
smatch warnings:
drivers/net/dsa/realtek/rtl8365mb.c:1391 rtl8365mb_stats_update() error:
uninitialized symbol 'ret'.
vim +/ret +1391 drivers/net/dsa/realtek/rtl8365mb.c
4af2950c50c863 drivers/net/dsa/rtl8365mb.c Alvin Šipraga
2021-10-18 1348
f5f119077b1cd6 drivers/net/dsa/realtek/rtl8365mb.c Luiz Angelo Daros de Luca
2022-01-28 1349 static void rtl8365mb_stats_update(struct realtek_priv *priv,
int port)
4af2950c50c863 drivers/net/dsa/rtl8365mb.c Alvin Šipraga
2021-10-18 1350 {
4af2950c50c863 drivers/net/dsa/rtl8365mb.c Alvin Šipraga
2021-10-18 1351 u64 cnt[RTL8365MB_MIB_END] = {
4af2950c50c863 drivers/net/dsa/rtl8365mb.c Alvin Šipraga
2021-10-18 1352 [RTL8365MB_MIB_ifOutOctets] = 1,
4af2950c50c863 drivers/net/dsa/rtl8365mb.c Alvin Šipraga
2021-10-18 1353 [RTL8365MB_MIB_ifOutUcastPkts] = 1,
4af2950c50c863 drivers/net/dsa/rtl8365mb.c Alvin Šipraga
2021-10-18 1354 [RTL8365MB_MIB_ifOutMulticastPkts] = 1,
4af2950c50c863 drivers/net/dsa/rtl8365mb.c Alvin Šipraga
2021-10-18 1355 [RTL8365MB_MIB_ifOutBroadcastPkts] = 1,
4af2950c50c863 drivers/net/dsa/rtl8365mb.c Alvin Šipraga
2021-10-18 1356 [RTL8365MB_MIB_ifOutDiscards] = 1,
4af2950c50c863 drivers/net/dsa/rtl8365mb.c Alvin Šipraga
2021-10-18 1357 [RTL8365MB_MIB_ifInOctets] = 1,
4af2950c50c863 drivers/net/dsa/rtl8365mb.c Alvin Šipraga
2021-10-18 1358 [RTL8365MB_MIB_ifInUcastPkts] = 1,
4af2950c50c863 drivers/net/dsa/rtl8365mb.c Alvin Šipraga
2021-10-18 1359 [RTL8365MB_MIB_ifInMulticastPkts] = 1,
4af2950c50c863 drivers/net/dsa/rtl8365mb.c Alvin Šipraga
2021-10-18 1360 [RTL8365MB_MIB_ifInBroadcastPkts] = 1,
4af2950c50c863 drivers/net/dsa/rtl8365mb.c Alvin Šipraga
2021-10-18 1361 [RTL8365MB_MIB_etherStatsDropEvents] = 1,
4af2950c50c863 drivers/net/dsa/rtl8365mb.c Alvin Šipraga
2021-10-18 1362 [RTL8365MB_MIB_etherStatsCollisions] = 1,
4af2950c50c863 drivers/net/dsa/rtl8365mb.c Alvin Šipraga
2021-10-18 1363 [RTL8365MB_MIB_etherStatsFragments] = 1,
4af2950c50c863 drivers/net/dsa/rtl8365mb.c Alvin Šipraga
2021-10-18 1364 [RTL8365MB_MIB_etherStatsJabbers] = 1,
4af2950c50c863 drivers/net/dsa/rtl8365mb.c Alvin Šipraga
2021-10-18 1365 [RTL8365MB_MIB_dot3StatsFCSErrors] = 1,
4af2950c50c863 drivers/net/dsa/rtl8365mb.c Alvin Šipraga
2021-10-18 1366 [RTL8365MB_MIB_dot3StatsLateCollisions] = 1,
4af2950c50c863 drivers/net/dsa/rtl8365mb.c Alvin Šipraga
2021-10-18 1367 };
f5f119077b1cd6 drivers/net/dsa/realtek/rtl8365mb.c Luiz Angelo Daros de Luca
2022-01-28 1368 struct rtl8365mb *mb = priv->chip_data;
4af2950c50c863 drivers/net/dsa/rtl8365mb.c Alvin Šipraga
2021-10-18 1369 struct rtnl_link_stats64 *stats;
4af2950c50c863 drivers/net/dsa/rtl8365mb.c Alvin Šipraga
2021-10-18 1370 int ret;
4af2950c50c863 drivers/net/dsa/rtl8365mb.c Alvin Šipraga
2021-10-18 1371 int i;
4af2950c50c863 drivers/net/dsa/rtl8365mb.c Alvin Šipraga
2021-10-18 1372
4af2950c50c863 drivers/net/dsa/rtl8365mb.c Alvin Šipraga
2021-10-18 1373 stats = >ports[port].stats;
4af2950c50c863 drivers/net/dsa/rtl8365mb.c Alvin Šipraga
2021-10-18 1374
4af2950c50c863 drivers/net/dsa/rtl8365mb.c Alvin Šipraga
2021-10-18 1375 mutex_lock(>mib_lock);
4af2950c50c863 drivers/net/dsa/rtl8365mb.c Alvin Šipraga
2021-10-18 1376 for (i = 0; i < RTL8365MB_MIB_END; i++) {
4af2950c50c863 drivers/net/dsa/rtl8365mb.c Alvin Šipraga
2021-10-18 1377 struct rtl8365mb_mib_counter *c =
_mib_counters[i];
4af2950c50c863 drivers/net/dsa/rtl8365mb.c
[kbuild] net/dsa/tag_sja1105.c:168 sja1105_xmit_tpid() error: uninitialized symbol 'proto'.
BCC: l...@intel.com
CC: kbuild-...@lists.01.org
CC: linux-ker...@vger.kernel.org
TO: Vladimir Oltean
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
master
head: c40e8341e3b3bb27e3a65b06b5b454626234c4f0
commit: 8ded9160928e545c2e694b77a87263fa078ff4c6 net: dsa: tag_sja1105: stop
asking the sja1105 driver in sja1105_xmit_tpid
date: 12 months ago
:: branch date: 9 hours ago
:: commit date: 12 months ago
config: openrisc-randconfig-m031-20220824
(https://download.01.org/0day-ci/archive/20220824/202208241912.7oigqbq6-...@intel.com/config)
compiler: or1k-linux-gcc (GCC) 12.1.0
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot
Reported-by: Dan Carpenter
New smatch warnings:
net/dsa/tag_sja1105.c:168 sja1105_xmit_tpid() error: uninitialized symbol
'proto'.
Old smatch warnings:
net/dsa/tag_sja1105.c:508 sja1105_rcv() error: uninitialized symbol 'vid'.
vim +/proto +168 net/dsa/tag_sja1105.c
a68578c20a9667 Vladimir Oltean 2020-01-04 135
8ded9160928e54 Vladimir Oltean 2021-08-24 136 /* Send VLAN tags with a TPID
that blends in with whatever VLAN protocol a
8ded9160928e54 Vladimir Oltean 2021-08-24 137 * bridge spanning ports of
this switch might have.
8ded9160928e54 Vladimir Oltean 2021-08-24 138 */
994d2cbb08ca05 Vladimir Oltean 2021-08-17 139 static u16
sja1105_xmit_tpid(struct dsa_port *dp)
38b5beeae7a4cd Vladimir Oltean 2020-05-12 140 {
8ded9160928e54 Vladimir Oltean 2021-08-24 141 struct dsa_switch *ds =
dp->ds;
8ded9160928e54 Vladimir Oltean 2021-08-24 142 struct dsa_port
*other_dp;
8ded9160928e54 Vladimir Oltean 2021-08-24 143 u16 proto;
8ded9160928e54 Vladimir Oltean 2021-08-24 144
8ded9160928e54 Vladimir Oltean 2021-08-24 145 /* Since VLAN awareness
is global, then if this port is VLAN-unaware,
8ded9160928e54 Vladimir Oltean 2021-08-24 146 * all ports are. Use
the VLAN-unaware TPID used for tag_8021q.
8ded9160928e54 Vladimir Oltean 2021-08-24 147 */
8ded9160928e54 Vladimir Oltean 2021-08-24 148 if
(!dsa_port_is_vlan_filtering(dp))
8ded9160928e54 Vladimir Oltean 2021-08-24 149 return
ETH_P_SJA1105;
8ded9160928e54 Vladimir Oltean 2021-08-24 150
8ded9160928e54 Vladimir Oltean 2021-08-24 151 /* Port is VLAN-aware,
so there is a bridge somewhere (a single one,
8ded9160928e54 Vladimir Oltean 2021-08-24 152 * we're sure about
that). It may not be on this port though, so we
8ded9160928e54 Vladimir Oltean 2021-08-24 153 * need to find it.
8ded9160928e54 Vladimir Oltean 2021-08-24 154 */
8ded9160928e54 Vladimir Oltean 2021-08-24 155
list_for_each_entry(other_dp, >dst->ports, list) {
8ded9160928e54 Vladimir Oltean 2021-08-24 156 if
(other_dp->ds != ds)
8ded9160928e54 Vladimir Oltean 2021-08-24 157
continue;
8ded9160928e54 Vladimir Oltean 2021-08-24 158
8ded9160928e54 Vladimir Oltean 2021-08-24 159 if
(!other_dp->bridge_dev)
8ded9160928e54 Vladimir Oltean 2021-08-24 160
continue;
8ded9160928e54 Vladimir Oltean 2021-08-24 161
8ded9160928e54 Vladimir Oltean 2021-08-24 162 /* Error is
returned only if CONFIG_BRIDGE_VLAN_FILTERING,
8ded9160928e54 Vladimir Oltean 2021-08-24 163 * which seems
pointless to handle, as our port cannot become
8ded9160928e54 Vladimir Oltean 2021-08-24 164 * VLAN-aware
in that case.
8ded9160928e54 Vladimir Oltean 2021-08-24 165 */
8ded9160928e54 Vladimir Oltean 2021-08-24 166
br_vlan_get_proto(other_dp->bridge_dev, );
8ded9160928e54 Vladimir Oltean 2021-08-24 167
8ded9160928e54 Vladimir Oltean 2021-08-24 @168 return proto;
8ded9160928e54 Vladimir Oltean 2021-08-24 169 }
994d2cbb08ca05 Vladimir Oltean 2021-08-17 170
8ded9160928e54 Vladimir Oltean 2021-08-24 171 WARN_ONCE(1, "Port is
VLAN-aware but cannot find associated bridge!\n");
994d2cbb08ca05 Vladimir Oltean 2021-08-17 172
8ded9160928e54 Vladimir Oltean 2021-08-24 173 return ETH_P_SJA1105;
38b5beeae7a4cd Vladimir Oltean 2020-05-12 174 }
38b5beeae7a4cd Vladimir Oltean 2020-05-12 175
--
0-DAY CI Kernel Test Service
https://01.org/lkp
___
kbuild mailing list -- kbuild@lists.01.org
To unsubscribe send an email to kbuild-le...@lists.01.org
[kbuild] [rt-devel:linux-6.0.y-rt-rebase 29/59] kernel/printk/printk.c:2471 __alloc_atomic_data() warn: returning -1 instead of -ENOMEM is sloppy
BCC: l...@intel.com
CC: kbuild-...@lists.01.org
CC: linux-ker...@vger.kernel.org
TO: John Ogness
CC: Sebastian Andrzej Siewior
tree: https://git.kernel.org/pub/scm/linux/kernel/git/rt/linux-rt-devel.git
linux-6.0.y-rt-rebase
head: 1d8c2694d3f649c97636d991dca099bd86f63f97
commit: 15b527e196320901ae7acc6a060c64d69a4bbdc7 [29/59] serial: 8250:
implement write_atomic
:: branch date: 2 days ago
:: commit date: 2 days ago
config: x86_64-randconfig-m001
(https://download.01.org/0day-ci/archive/20220824/202208241943.ra6mmw4r-...@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-5) 11.3.0
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot
Reported-by: Dan Carpenter
smatch warnings:
kernel/printk/printk.c:2471 __alloc_atomic_data() warn: returning -1 instead of
-ENOMEM is sloppy
vim +2471 kernel/printk/printk.c
e2c203102ac06a John Ogness 2022-02-04 2466
e2c203102ac06a John Ogness 2022-02-04 2467 static int
__alloc_atomic_data(struct console_atomic_data *d, short flags)
e2c203102ac06a John Ogness 2022-02-04 2468 {
e2c203102ac06a John Ogness 2022-02-04 2469 d->text =
kmalloc(CONSOLE_LOG_MAX, GFP_KERNEL);
e2c203102ac06a John Ogness 2022-02-04 2470 if (!d->text)
e2c203102ac06a John Ogness 2022-02-04 @2471 return -1;
e2c203102ac06a John Ogness 2022-02-04 2472
e2c203102ac06a John Ogness 2022-02-04 2473 if (flags & CON_EXTENDED) {
e2c203102ac06a John Ogness 2022-02-04 2474 d->ext_text =
kmalloc(CONSOLE_EXT_LOG_MAX, GFP_KERNEL);
e2c203102ac06a John Ogness 2022-02-04 2475 if (!d->ext_text)
e2c203102ac06a John Ogness 2022-02-04 2476 return -1;
e2c203102ac06a John Ogness 2022-02-04 2477 } else {
e2c203102ac06a John Ogness 2022-02-04 2478 d->dropped_text =
kmalloc(DROPPED_TEXT_MAX, GFP_KERNEL);
e2c203102ac06a John Ogness 2022-02-04 2479 if (!d->dropped_text)
e2c203102ac06a John Ogness 2022-02-04 2480 return -1;
e2c203102ac06a John Ogness 2022-02-04 2481 }
e2c203102ac06a John Ogness 2022-02-04 2482
e2c203102ac06a John Ogness 2022-02-04 2483 return 0;
e2c203102ac06a John Ogness 2022-02-04 2484 }
e2c203102ac06a John Ogness 2022-02-04 2485
:: The code at line 2471 was first introduced by commit
:: e2c203102ac06a753b2d35ee377887350ad82b84 printk: add infrastucture for
atomic consoles
:: TO: John Ogness
:: CC: Sebastian Andrzej Siewior
--
0-DAY CI Kernel Test Service
https://01.org/lkp
___
kbuild mailing list -- kbuild@lists.01.org
To unsubscribe send an email to kbuild-le...@lists.01.org
[kbuild] [linux-next:master 2392/2947] fs/btrfs/volumes.c:6546 __btrfs_map_block() error: we previously assumed 'mirror_num_ret' could be null (see line 6373)
BCC: l...@intel.com
CC: kbuild-...@lists.01.org
CC: Linux Memory Management List
TO: Christoph Hellwig
CC: David Sterba
CC: Nikolay Borisov
CC: Johannes Thumshirn
CC: Anand Jain
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
master
head: 68a00424bf69036970ced7930f9e4d709b4a6423
commit: 8c1e13672fefc7c3f251bd5e75830939890a628a [2392/2947] btrfs: add fast
path for single device io in __btrfs_map_block
:: branch date: 7 hours ago
:: commit date: 18 hours ago
config: nios2-randconfig-m031-20220824
(https://download.01.org/0day-ci/archive/20220824/202208241953.fweyhf3g-...@intel.com/config)
compiler: nios2-linux-gcc (GCC) 12.1.0
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot
Reported-by: Dan Carpenter
New smatch warnings:
fs/btrfs/volumes.c:6546 __btrfs_map_block() error: we previously assumed
'mirror_num_ret' could be null (see line 6373)
Old smatch warnings:
arch/nios2/include/asm/thread_info.h:62 current_thread_info() error:
uninitialized symbol 'sp'.
fs/btrfs/volumes.c:6396 __btrfs_map_block() error: 'em' dereferencing possible
ERR_PTR()
vim +/mirror_num_ret +6546 fs/btrfs/volumes.c
8c1e13672fefc7 Christoph Hellwig 2022-08-06 6357
cf8cddd38bab31 Christoph Hellwig 2016-10-27 6358 static int
__btrfs_map_block(struct btrfs_fs_info *fs_info,
8c1e13672fefc7 Christoph Hellwig 2022-08-06 6359
enum btrfs_map_op op, u64 logical, u64 *length,
4c664611791239 Qu Wenruo 2021-09-15 6360
struct btrfs_io_context **bioc_ret,
8c1e13672fefc7 Christoph Hellwig 2022-08-06 6361
struct btrfs_io_stripe *smap,
8c1e13672fefc7 Christoph Hellwig 2022-08-06 6362
int *mirror_num_ret, int need_raid_map)
0b86a832a1f38a Chris Mason 2008-03-24 6363 {
0b86a832a1f38a Chris Mason 2008-03-24 6364 struct extent_map *em;
0b86a832a1f38a Chris Mason 2008-03-24 6365 struct map_lookup *map;
593060d756e0c2 Chris Mason 2008-03-25 6366 u64 stripe_offset;
593060d756e0c2 Chris Mason 2008-03-25 6367 u64 stripe_nr;
53b381b3abeb86 David Woodhouse 2013-01-29 6368 u64 stripe_len;
9d644a623ec48e David Sterba 2015-02-20 6369 u32 stripe_index;
cff8267228c14e David Sterba 2019-05-17 6370 int data_stripes;
cea9e4452ebaf1 Chris Mason 2008-04-09 6371 int i;
de11cc12df1733 Li Zefan 2011-12-01 6372 int ret = 0;
8c1e13672fefc7 Christoph Hellwig 2022-08-06 @6373 int mirror_num =
(mirror_num_ret ? *mirror_num_ret : 0);
f2d8d74d7874f8 Chris Mason 2008-04-21 6374 int num_stripes;
a236aed14ccb06 Chris Mason 2008-04-29 6375 int max_errors = 0;
2c8cdd6ee4e7f6 Miao Xie 2014-11-14 6376 int tgtdev_indexes = 0;
4c664611791239 Qu Wenruo 2021-09-15 6377 struct btrfs_io_context
*bioc = NULL;
472262f35a6b34 Stefan Behrens2012-11-06 6378 struct
btrfs_dev_replace *dev_replace = _info->dev_replace;
472262f35a6b34 Stefan Behrens2012-11-06 6379 int
dev_replace_is_ongoing = 0;
472262f35a6b34 Stefan Behrens2012-11-06 6380 int num_alloc_stripes;
ad6d620e2a5704 Stefan Behrens2012-11-06 6381 int
patch_the_first_stripe_for_dev_replace = 0;
ad6d620e2a5704 Stefan Behrens2012-11-06 6382 u64
physical_to_patch_in_first_stripe = 0;
53b381b3abeb86 David Woodhouse 2013-01-29 6383 u64
raid56_full_stripe_start = (u64)-1;
89b798ad1b42b1 Nikolay Borisov 2019-06-03 6384 struct
btrfs_io_geometry geom;
89b798ad1b42b1 Nikolay Borisov 2019-06-03 6385
4c664611791239 Qu Wenruo 2021-09-15 6386 ASSERT(bioc_ret);
75fb2e9e49c1bf David Sterba 2018-08-03 6387 ASSERT(op !=
BTRFS_MAP_DISCARD);
0b3d4cd371edb6 Liu Bo2017-03-14 6388
420343131970fd Michal Rostecki 2021-01-27 6389 em =
btrfs_get_chunk_map(fs_info, logical, *length);
420343131970fd Michal Rostecki 2021-01-27 6390 ASSERT(!IS_ERR(em));
420343131970fd Michal Rostecki 2021-01-27 6391
43c0d1a5e11795 Qu Wenruo 2021-04-13 6392 ret =
btrfs_get_io_geometry(fs_info, em, op, logical, );
89b798ad1b42b1 Nikolay Borisov 2019-06-03 6393 if (ret < 0)
89b798ad1b42b1 Nikolay Borisov 2019-06-03 6394 return ret;
0b86a832a1f38a Chris Mason 2008-03-24 6395
95617d69326ce3 Jeff Mahoney 2015-06-03 6396 map = em->map_lookup;
593060d756e0c2 Chris Mason 2008-03-25 6397
89b798ad1b42b1 Nikolay Borisov 2019-06-03 6398 *length = geom.len;
89b798ad1b42b1 Nikolay Borisov 2019-06-03 6399 stripe_len =
geom.stripe_len;
89b798ad1b42b1 Nikolay Borisov 2019-06-03 6400 stripe_nr =
geom.stripe_nr;
89b798ad1b42b1 Nikolay Borisov 2019-06-03 6401 stripe_offset =
geom.stripe_offset;
89b798ad1b42b1 Nikolay Borisov 2019-06
[kbuild] net/dsa/tag_sja1105.c:168 sja1105_xmit_tpid() error: uninitialized symbol 'proto'.
BCC: l...@intel.com
CC: kbuild-...@lists.01.org
CC: linux-ker...@vger.kernel.org
TO: Vladimir Oltean
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
master
head: c40e8341e3b3bb27e3a65b06b5b454626234c4f0
commit: 8ded9160928e545c2e694b77a87263fa078ff4c6 net: dsa: tag_sja1105: stop
asking the sja1105 driver in sja1105_xmit_tpid
date: 12 months ago
:: branch date: 7 hours ago
:: commit date: 12 months ago
config: openrisc-randconfig-m031-20220824
(https://download.01.org/0day-ci/archive/20220824/202208241748.plmhogiy-...@intel.com/config)
compiler: or1k-linux-gcc (GCC) 12.1.0
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot
Reported-by: Dan Carpenter
New smatch warnings:
net/dsa/tag_sja1105.c:168 sja1105_xmit_tpid() error: uninitialized symbol
'proto'.
Old smatch warnings:
net/dsa/tag_sja1105.c:508 sja1105_rcv() error: uninitialized symbol 'vid'.
vim +/proto +168 net/dsa/tag_sja1105.c
a68578c20a9667 Vladimir Oltean 2020-01-04 135
8ded9160928e54 Vladimir Oltean 2021-08-24 136 /* Send VLAN tags with a TPID
that blends in with whatever VLAN protocol a
8ded9160928e54 Vladimir Oltean 2021-08-24 137 * bridge spanning ports of
this switch might have.
8ded9160928e54 Vladimir Oltean 2021-08-24 138 */
994d2cbb08ca05 Vladimir Oltean 2021-08-17 139 static u16
sja1105_xmit_tpid(struct dsa_port *dp)
38b5beeae7a4cd Vladimir Oltean 2020-05-12 140 {
8ded9160928e54 Vladimir Oltean 2021-08-24 141 struct dsa_switch *ds =
dp->ds;
8ded9160928e54 Vladimir Oltean 2021-08-24 142 struct dsa_port
*other_dp;
8ded9160928e54 Vladimir Oltean 2021-08-24 143 u16 proto;
8ded9160928e54 Vladimir Oltean 2021-08-24 144
8ded9160928e54 Vladimir Oltean 2021-08-24 145 /* Since VLAN awareness
is global, then if this port is VLAN-unaware,
8ded9160928e54 Vladimir Oltean 2021-08-24 146 * all ports are. Use
the VLAN-unaware TPID used for tag_8021q.
8ded9160928e54 Vladimir Oltean 2021-08-24 147 */
8ded9160928e54 Vladimir Oltean 2021-08-24 148 if
(!dsa_port_is_vlan_filtering(dp))
8ded9160928e54 Vladimir Oltean 2021-08-24 149 return
ETH_P_SJA1105;
8ded9160928e54 Vladimir Oltean 2021-08-24 150
8ded9160928e54 Vladimir Oltean 2021-08-24 151 /* Port is VLAN-aware,
so there is a bridge somewhere (a single one,
8ded9160928e54 Vladimir Oltean 2021-08-24 152 * we're sure about
that). It may not be on this port though, so we
8ded9160928e54 Vladimir Oltean 2021-08-24 153 * need to find it.
8ded9160928e54 Vladimir Oltean 2021-08-24 154 */
8ded9160928e54 Vladimir Oltean 2021-08-24 155
list_for_each_entry(other_dp, >dst->ports, list) {
8ded9160928e54 Vladimir Oltean 2021-08-24 156 if
(other_dp->ds != ds)
8ded9160928e54 Vladimir Oltean 2021-08-24 157
continue;
8ded9160928e54 Vladimir Oltean 2021-08-24 158
8ded9160928e54 Vladimir Oltean 2021-08-24 159 if
(!other_dp->bridge_dev)
8ded9160928e54 Vladimir Oltean 2021-08-24 160
continue;
8ded9160928e54 Vladimir Oltean 2021-08-24 161
8ded9160928e54 Vladimir Oltean 2021-08-24 162 /* Error is
returned only if CONFIG_BRIDGE_VLAN_FILTERING,
8ded9160928e54 Vladimir Oltean 2021-08-24 163 * which seems
pointless to handle, as our port cannot become
8ded9160928e54 Vladimir Oltean 2021-08-24 164 * VLAN-aware
in that case.
8ded9160928e54 Vladimir Oltean 2021-08-24 165 */
8ded9160928e54 Vladimir Oltean 2021-08-24 166
br_vlan_get_proto(other_dp->bridge_dev, );
8ded9160928e54 Vladimir Oltean 2021-08-24 167
8ded9160928e54 Vladimir Oltean 2021-08-24 @168 return proto;
8ded9160928e54 Vladimir Oltean 2021-08-24 169 }
994d2cbb08ca05 Vladimir Oltean 2021-08-17 170
8ded9160928e54 Vladimir Oltean 2021-08-24 171 WARN_ONCE(1, "Port is
VLAN-aware but cannot find associated bridge!\n");
994d2cbb08ca05 Vladimir Oltean 2021-08-17 172
8ded9160928e54 Vladimir Oltean 2021-08-24 173 return ETH_P_SJA1105;
38b5beeae7a4cd Vladimir Oltean 2020-05-12 174 }
38b5beeae7a4cd Vladimir Oltean 2020-05-12 175
--
0-DAY CI Kernel Test Service
https://01.org/lkp
___
kbuild mailing list -- kbuild@lists.01.org
To unsubscribe send an email to kbuild-le...@lists.01.org
[kbuild] Re: [linux-next:master 2079/2594] fs/btrfs/volumes.c:6546 __btrfs_map_block() error: we previously assumed 'mirror_num_p' could be null (see line 6373)
On Wed, Aug 24, 2022 at 07:35:27AM +0200, Christoph Hellwig wrote: > On Wed, Aug 24, 2022 at 08:28:26AM +0300, Dan Carpenter wrote: > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git > > master > > head: 05477f3653b82d8b3bcf39d2937d9893124976db > > commit: 51bf2819055847ce90006a368f8d2c07f408dd33 [2079/2594] btrfs: make > > the btrfs_io_context allocation in __btrfs_map_block optional > > config: nios2-randconfig-m031-20220824 > > (https://download.01.org/0day-ci/archive/20220824/202208240734.u4y7q6sw-...@intel.com/config > > ) > > compiler: nios2-linux-gcc (GCC) 12.1.0 > > > > If you fix the issue, kindly add following tag where applicable > > Reported-by: kernel test robot > > Reported-by: Dan Carpenter > > > > New smatch warnings: > > The calling convention implies that either smap and mirror_num_p are both > NULL or neither. We could add an extra check to shut up the validator > if this really helps. No need. That's a simple relationship and the warning should be silenced if you have the cross function DB information. (It's just not possible to build the cross function DB for the number of builds that the kbuild-bot does). regards, dan carpenter ___ kbuild mailing list -- kbuild@lists.01.org To unsubscribe send an email to kbuild-le...@lists.01.org
