[kbuild] [PATCH] scsi: hisi_sas: fix platform_get_irq.cocci warnings
CC: kbuild-...@lists.01.org
CC: linux-ker...@vger.kernel.org
TO: Sergey Shtylyov
CC: "Martin K. Petersen"
CC: John Garry
CC: "James E.J. Bottomley"
CC: linux-s...@vger.kernel.org
CC: linux-ker...@vger.kernel.org
From: kernel test robot
drivers/scsi/hisi_sas/hisi_sas_v1_hw.c:1650:4-11: line 1650 is redundant
because platform_get_irq() already prints an error
drivers/scsi/hisi_sas/hisi_sas_v1_hw.c:1669:3-10: line 1669 is redundant
because platform_get_irq() already prints an error
drivers/scsi/hisi_sas/hisi_sas_v1_hw.c:1687:3-10: line 1687 is redundant
because platform_get_irq() already prints an error
Remove dev_err() messages after platform_get_irq*() failures
Generated by: scripts/coccinelle/api/platform_get_irq.cocci
Fixes: 6c11dc060427 ("scsi: hisi_sas: Fix IRQ checks")
CC: Sergey Shtylyov
Reported-by: kernel test robot
Signed-off-by: kernel test robot
---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
master
head: 0c18f29aae7ce3dadd26d8ee3505d07cc982df75
commit: 6c11dc060427e07ca144eacaccd696106b361b06 scsi: hisi_sas: Fix IRQ checks
:: branch date: 15 hours ago
:: commit date: 2 months ago
Please take the patch only if it's a positive warning. Thanks!
hisi_sas_v1_hw.c |6 --
1 file changed, 6 deletions(-)
--- a/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c
+++ b/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c
@@ -1647,8 +1647,6 @@ static int interrupt_init_v1_hw(struct h
for (j = 0; j < HISI_SAS_PHY_INT_NR; j++, idx++) {
irq = platform_get_irq(pdev, idx);
if (irq < 0) {
- dev_err(dev, "irq init: fail map phy interrupt
%d\n",
- idx);
return irq;
}
@@ -1666,8 +1664,6 @@ static int interrupt_init_v1_hw(struct h
for (i = 0; i < hisi_hba->queue_count; i++, idx++) {
irq = platform_get_irq(pdev, idx);
if (irq < 0) {
- dev_err(dev, "irq init: could not map cq interrupt
%d\n",
- idx);
return irq;
}
@@ -1684,8 +1680,6 @@ static int interrupt_init_v1_hw(struct h
for (i = 0; i < HISI_SAS_FATAL_INT_NR; i++, idx++) {
irq = platform_get_irq(pdev, idx);
if (irq < 0) {
- dev_err(dev, "irq init: could not map fatal interrupt
%d\n",
- idx);
return irq;
}
___
kbuild mailing list -- kbuild@lists.01.org
To unsubscribe send an email to kbuild-le...@lists.01.org
[kbuild] [PATCH] scsi: hisi_sas: fix platform_get_irq.cocci warnings
CC: kbuild-...@lists.01.org
CC: Linux Memory Management List
TO: Sergey Shtylyov
CC: "Martin K. Petersen"
CC: John Garry
CC: "James E.J. Bottomley"
CC: linux-s...@vger.kernel.org
CC: linux-ker...@vger.kernel.org
From: kernel test robot
drivers/scsi/hisi_sas/hisi_sas_v1_hw.c:1650:4-11: line 1650 is redundant
because platform_get_irq() already prints an error
drivers/scsi/hisi_sas/hisi_sas_v1_hw.c:1669:3-10: line 1669 is redundant
because platform_get_irq() already prints an error
drivers/scsi/hisi_sas/hisi_sas_v1_hw.c:1687:3-10: line 1687 is redundant
because platform_get_irq() already prints an error
Remove dev_err() messages after platform_get_irq*() failures
Generated by: scripts/coccinelle/api/platform_get_irq.cocci
Fixes: 6c11dc060427 ("scsi: hisi_sas: Fix IRQ checks")
CC: Sergey Shtylyov
Reported-by: kernel test robot
Signed-off-by: kernel test robot
---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
master
head: dcf1b51d6b2ac5da234ae6883ed0e9422c339588
commit: 6c11dc060427e07ca144eacaccd696106b361b06 [12286/12404] scsi: hisi_sas:
Fix IRQ checks
:: branch date: 6 hours ago
:: commit date: 12 hours ago
Please take the patch only if it's a positive warning. Thanks!
hisi_sas_v1_hw.c |6 --
1 file changed, 6 deletions(-)
--- a/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c
+++ b/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c
@@ -1647,8 +1647,6 @@ static int interrupt_init_v1_hw(struct h
for (j = 0; j < HISI_SAS_PHY_INT_NR; j++, idx++) {
irq = platform_get_irq(pdev, idx);
if (irq < 0) {
- dev_err(dev, "irq init: fail map phy interrupt
%d\n",
- idx);
return -ENOENT;
}
@@ -1666,8 +1664,6 @@ static int interrupt_init_v1_hw(struct h
for (i = 0; i < hisi_hba->queue_count; i++, idx++) {
irq = platform_get_irq(pdev, idx);
if (irq < 0) {
- dev_err(dev, "irq init: could not map cq interrupt
%d\n",
- idx);
return -ENOENT;
}
@@ -1684,8 +1680,6 @@ static int interrupt_init_v1_hw(struct h
for (i = 0; i < HISI_SAS_FATAL_INT_NR; i++, idx++) {
irq = platform_get_irq(pdev, idx);
if (irq < 0) {
- dev_err(dev, "irq init: could not map fatal interrupt
%d\n",
- idx);
return -ENOENT;
}
___
kbuild mailing list -- kbuild@lists.01.org
To unsubscribe send an email to kbuild-le...@lists.01.org
