[kbuild] [jlayton:locks-3.19 44/47] fs/cifs/file.c:1198 cifs_push_posix_locks() warn: inconsistent returns spin_lock:inode-i_lock: locked (1192 [s32min-s32max]) unlocked (1192 [0])

2014-09-04 Thread kbuild test robot 
TO: Jeff Layton jlay...@primarydata.com

tree:   git://git.samba.org/jlayton/linux locks-3.19
head:   d9212689e0732acf5a0b94083c1319ee4f396a15
commit: 35c20cc874547c97d0c5abd315caef5bb52c056b [44/47] cifs: convert it to 
use file_lock_context
:: branch date: 76 minutes ago
:: commit date: 76 minutes ago

New smatch warnings:
fs/cifs/file.c:1198 cifs_push_posix_locks() warn: inconsistent returns 
spin_lock:inode-i_lock: locked (1192 [s32min-s32max]) unlocked (1192 [0])

Old smatch warnings:
fs/cifs/file.c:3181 cifs_read() warn: variable dereferenced before check 
'tcon-ses' (see line 3166)

git remote add jlayton git://git.samba.org/jlayton/linux
git remote update jlayton
git checkout 35c20cc874547c97d0c5abd315caef5bb52c056b
vim +1198 fs/cifs/file.c

c5fd363d Jeff Layton 2012-07-23  1182   
 lck-offset, lck-length, NULL,
4f6bcec9 Pavel Shilovsky 2011-10-22  1183   
 lck-type, 0);
4f6bcec9 Pavel Shilovsky 2011-10-22  1184   if (stored_rc)
4f6bcec9 Pavel Shilovsky 2011-10-22  1185   rc = stored_rc;
4f6bcec9 Pavel Shilovsky 2011-10-22  1186   list_del(lck-llist);
4f6bcec9 Pavel Shilovsky 2011-10-22  1187   kfree(lck);
4f6bcec9 Pavel Shilovsky 2011-10-22  1188   }
4f6bcec9 Pavel Shilovsky 2011-10-22  1189  
d5751469 Pavel Shilovsky 2012-03-05  1190  out:
6d5786a3 Pavel Shilovsky 2012-06-20  1191   free_xid(xid);
4f6bcec9 Pavel Shilovsky 2011-10-22  1192   return rc;
d5751469 Pavel Shilovsky 2012-03-05  1193  err_out:
d5751469 Pavel Shilovsky 2012-03-05  1194   list_for_each_entry_safe(lck, 
tmp, locks_to_send, llist) {
d5751469 Pavel Shilovsky 2012-03-05  1195   list_del(lck-llist);
d5751469 Pavel Shilovsky 2012-03-05  1196   kfree(lck);
d5751469 Pavel Shilovsky 2012-03-05  1197   }
d5751469 Pavel Shilovsky 2012-03-05 @1198   goto out;
4f6bcec9 Pavel Shilovsky 2011-10-22  1199  }
4f6bcec9 Pavel Shilovsky 2011-10-22  1200  
4f6bcec9 Pavel Shilovsky 2011-10-22  1201  static int
b8db928b Pavel Shilovsky 2012-11-22  1202  cifs_push_locks(struct cifsFileInfo 
*cfile)
9ec3c882 Pavel Shilovsky 2012-11-22  1203  {
b8db928b Pavel Shilovsky 2012-11-22  1204   struct cifs_sb_info *cifs_sb = 
CIFS_SB(cfile-dentry-d_sb);
9ec3c882 Pavel Shilovsky 2012-11-22  1205   struct cifsInodeInfo *cinode = 
CIFS_I(cfile-dentry-d_inode);
b8db928b Pavel Shilovsky 2012-11-22  1206   struct cifs_tcon *tcon = 
tlink_tcon(cfile-tlink);

:: The code at line 1198 was first introduced by commit
:: d5751469f210d2149cc215966cbeef6da3f2 CIFS: Do not kmalloc under the 
flocks spinlock

:: TO: Pavel Shilovsky pias...@etersoft.ru
:: CC: Steve French sfre...@us.ibm.com

---
0-DAY kernel build testing backend  Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild Intel Corporation
___
kbuild mailing list
kbuild@lists.01.org
https://lists.01.org/mailman/listinfo/kbuild

[kbuild] [jlayton:locks-3.19 44/47] fs/cifs/file.c:1198 cifs_push_posix_locks() warn: inconsistent returns spin_lock:inode-i_lock: locked (1192 [s32min-s32max]) unlocked (1192 [0])

2014-09-04 Thread Dan Carpenter 
[ It looks like a stray spin_unlock(inode-i_lock); was left behind by
  mistake.  -dan ]

tree:   git://git.samba.org/jlayton/linux locks-3.19
head:   d9212689e0732acf5a0b94083c1319ee4f396a15
commit: 35c20cc874547c97d0c5abd315caef5bb52c056b [44/47] cifs: convert it to 
use file_lock_context

New smatch warnings:
fs/cifs/file.c:1198 cifs_push_posix_locks() warn: inconsistent returns 
spin_lock:inode-i_lock: locked (1192 [s32min-s32max]) unlocked (1192 [0])

Old smatch warnings:
fs/cifs/file.c:3181 cifs_read() warn: variable dereferenced before check 
'tcon-ses' (see line 3166)

git remote add jlayton git://git.samba.org/jlayton/linux
git remote update jlayton
git checkout 35c20cc874547c97d0c5abd315caef5bb52c056b
vim +1198 fs/cifs/file.c

c5fd363d Jeff Layton 2012-07-23  1182   
 lck-offset, lck-length, NULL,
4f6bcec9 Pavel Shilovsky 2011-10-22  1183   
 lck-type, 0);
4f6bcec9 Pavel Shilovsky 2011-10-22  1184   if (stored_rc)
4f6bcec9 Pavel Shilovsky 2011-10-22  1185   rc = stored_rc;
4f6bcec9 Pavel Shilovsky 2011-10-22  1186   list_del(lck-llist);
4f6bcec9 Pavel Shilovsky 2011-10-22  1187   kfree(lck);
4f6bcec9 Pavel Shilovsky 2011-10-22  1188   }
4f6bcec9 Pavel Shilovsky 2011-10-22  1189  
d5751469 Pavel Shilovsky 2012-03-05  1190  out:
6d5786a3 Pavel Shilovsky 2012-06-20  1191   free_xid(xid);
4f6bcec9 Pavel Shilovsky 2011-10-22  1192   return rc;
d5751469 Pavel Shilovsky 2012-03-05  1193  err_out:
d5751469 Pavel Shilovsky 2012-03-05  1194   list_for_each_entry_safe(lck, 
tmp, locks_to_send, llist) {
d5751469 Pavel Shilovsky 2012-03-05  1195   list_del(lck-llist);
d5751469 Pavel Shilovsky 2012-03-05  1196   kfree(lck);
d5751469 Pavel Shilovsky 2012-03-05  1197   }
d5751469 Pavel Shilovsky 2012-03-05 @1198   goto out;
4f6bcec9 Pavel Shilovsky 2011-10-22  1199  }
4f6bcec9 Pavel Shilovsky 2011-10-22  1200  
4f6bcec9 Pavel Shilovsky 2011-10-22  1201  static int
b8db928b Pavel Shilovsky 2012-11-22  1202  cifs_push_locks(struct cifsFileInfo 
*cfile)
9ec3c882 Pavel Shilovsky 2012-11-22  1203  {
b8db928b Pavel Shilovsky 2012-11-22  1204   struct cifs_sb_info *cifs_sb = 
CIFS_SB(cfile-dentry-d_sb);
9ec3c882 Pavel Shilovsky 2012-11-22  1205   struct cifsInodeInfo *cinode = 
CIFS_I(cfile-dentry-d_inode);
b8db928b Pavel Shilovsky 2012-11-22  1206   struct cifs_tcon *tcon = 
tlink_tcon(cfile-tlink);

---
0-DAY kernel build testing backend  Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild Intel Corporation
___
kbuild mailing list
kbuild@lists.01.org
https://lists.01.org/mailman/listinfo/kbuild