[kbuild] [kees:lsm/stacking 4/4] security/smack/smack_lsm.c:457 smack_sb_kern_mount() error: potentially dereferencing uninitialized 'isp'.
tree: git://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git lsm/stacking head: a1811bedacca7afc4f41741401eeaa003d22d6bb commit: a1811bedacca7afc4f41741401eeaa003d22d6bb [4/4] LSM: Stop allocating inode-i_security security/smack/smack_lsm.c:457 smack_sb_kern_mount() error: potentially dereferencing uninitialized 'isp'. git remote add kees git://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git git remote update kees git checkout a1811bedacca7afc4f41741401eeaa003d22d6bb vim +/isp +457 security/smack/smack_lsm.c 24ea1b6e Casey Schaufler 2013-12-30 441 */ 24ea1b6e Casey Schaufler 2013-12-30 442skp = smk_of_current(); 24ea1b6e Casey Schaufler 2013-12-30 443sp-smk_root = skp-smk_known; 24ea1b6e Casey Schaufler 2013-12-30 444sp-smk_default = skp-smk_known; 24ea1b6e Casey Schaufler 2013-12-30 445} e114e473 Casey Schaufler 2008-02-04 446/* e114e473 Casey Schaufler 2008-02-04 447 * Initialize the root inode. e114e473 Casey Schaufler 2008-02-04 448 */ a1811bed Casey Schaufler 2014-08-08 449if (!(inode-i_smack.smk_flags SMK_INODE_ALLOCATED)) a1811bed Casey Schaufler 2014-08-08 450/* a1811bed Casey Schaufler 2014-08-08 451 * Don't optimize this. The desired result is that flags be a1811bed Casey Schaufler 2014-08-08 452 * cleared except for the ALLOCATED bit. a1811bed Casey Schaufler 2014-08-08 453 */ a1811bed Casey Schaufler 2014-08-08 454 inode-i_smack.smk_flags = SMK_INODE_ALLOCATED; e114e473 Casey Schaufler 2008-02-04 455 e830b394 Casey Schaufler 2013-05-22 456if (transmute) e830b394 Casey Schaufler 2013-05-22 @457isp-smk_flags |= SMK_INODE_TRANSMUTE; e830b394 Casey Schaufler 2013-05-22 458 e114e473 Casey Schaufler 2008-02-04 459return 0; e114e473 Casey Schaufler 2008-02-04 460 } e114e473 Casey Schaufler 2008-02-04 461 e114e473 Casey Schaufler 2008-02-04 462 /** e114e473 Casey Schaufler 2008-02-04 463 * smack_sb_statfs - Smack check on statfs e114e473 Casey Schaufler 2008-02-04 464 * @dentry: identifies the file system in question e114e473 Casey Schaufler 2008-02-04 465 * --- 0-DAY kernel build testing backend Open Source Technology Center http://lists.01.org/mailman/listinfo/kbuild Intel Corporation ___ kbuild mailing list kbuild@lists.01.org https://lists.01.org/mailman/listinfo/kbuild
[kbuild] [kees:lsm/stacking 4/4] security/smack/smack_lsm.c:457 smack_sb_kern_mount() error: potentially dereferencing uninitialized 'isp'.
TO: Casey Schaufler ca...@schaufler-ca.com CC: Kees Cook keesc...@chromium.org tree: git://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git lsm/stacking head: a1811bedacca7afc4f41741401eeaa003d22d6bb commit: a1811bedacca7afc4f41741401eeaa003d22d6bb [4/4] LSM: Stop allocating inode-i_security :: branch date: 70 minutes ago :: commit date: 70 minutes ago New smatch warnings: security/smack/smack_lsm.c:457 smack_sb_kern_mount() error: potentially dereferencing uninitialized 'isp'. Old smatch warnings: security/smack/smack_lsm.c:2853 smack_d_instantiate() warn: missing break? reassigning 'final' git remote add kees git://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git git remote update kees git checkout a1811bedacca7afc4f41741401eeaa003d22d6bb vim +/isp +457 security/smack/smack_lsm.c 24ea1b6e Casey Schaufler 2013-12-30 441 */ 24ea1b6e Casey Schaufler 2013-12-30 442skp = smk_of_current(); 24ea1b6e Casey Schaufler 2013-12-30 443sp-smk_root = skp-smk_known; 24ea1b6e Casey Schaufler 2013-12-30 444sp-smk_default = skp-smk_known; 24ea1b6e Casey Schaufler 2013-12-30 445} e114e473 Casey Schaufler 2008-02-04 446/* e114e473 Casey Schaufler 2008-02-04 447 * Initialize the root inode. e114e473 Casey Schaufler 2008-02-04 448 */ a1811bed Casey Schaufler 2014-08-08 449if (!(inode-i_smack.smk_flags SMK_INODE_ALLOCATED)) a1811bed Casey Schaufler 2014-08-08 450/* a1811bed Casey Schaufler 2014-08-08 451 * Don't optimize this. The desired result is that flags be a1811bed Casey Schaufler 2014-08-08 452 * cleared except for the ALLOCATED bit. a1811bed Casey Schaufler 2014-08-08 453 */ a1811bed Casey Schaufler 2014-08-08 454 inode-i_smack.smk_flags = SMK_INODE_ALLOCATED; e114e473 Casey Schaufler 2008-02-04 455 e830b394 Casey Schaufler 2013-05-22 456if (transmute) e830b394 Casey Schaufler 2013-05-22 @457isp-smk_flags |= SMK_INODE_TRANSMUTE; e830b394 Casey Schaufler 2013-05-22 458 e114e473 Casey Schaufler 2008-02-04 459return 0; e114e473 Casey Schaufler 2008-02-04 460 } e114e473 Casey Schaufler 2008-02-04 461 e114e473 Casey Schaufler 2008-02-04 462 /** e114e473 Casey Schaufler 2008-02-04 463 * smack_sb_statfs - Smack check on statfs e114e473 Casey Schaufler 2008-02-04 464 * @dentry: identifies the file system in question e114e473 Casey Schaufler 2008-02-04 465 * :: The code at line 457 was first introduced by commit :: e830b39412ca2bbedd7508243f21c04d57ad543c Smack: Add smkfstransmute mount option :: TO: Casey Schaufler ca...@schaufler-ca.com :: CC: Casey Schaufler ca...@schaufler-ca.com --- 0-DAY kernel build testing backend Open Source Technology Center http://lists.01.org/mailman/listinfo/kbuild Intel Corporation ___ kbuild mailing list kbuild@lists.01.org https://lists.01.org/mailman/listinfo/kbuild
