subject:"\[kbuild\] \[linux\-next\:master 317\/9190\] drivers\/gpu\/drm\/i915\/display\/intel_psr.c\:1517\:30\: warning\: Redundant condition\: intel_dp\->psr.enabled. '\!A \|\| \(A \&\& B\)' is equivalent to '\!A \|\| B' \[redundantCondi"

[kbuild] [linux-next:master 317/9190] drivers/gpu/drm/i915/display/intel_psr.c:1517:30: warning: Redundant condition: intel_dp->psr.enabled. '!A || (A && B)' is equivalent to '!A || B' [redundantCondi

2021-04-09 Thread Dan Carpenter

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git  
master
head:   454c576c3f5e51d60f00a4ac0dde07f4f9d70e9d
commit: b64d6c51380b7dea17d5503a250ca9cc84025453 [317/9190] drm/i915/display: 
Support PSR Multiple Instances
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot 

cppcheck possible warnings: (new ones prefixed by >>, may not real problems)

>> drivers/gpu/drm/i915/display/intel_psr.c:1517:30: warning: Redundant 
>> condition: intel_dp->psr.enabled. '!A || (A && B)' is equivalent to '!A || 
>> B' [redundantCondition]
 if (!intel_dp->psr.enabled ||
^
   drivers/gpu/drm/i915/display/intel_psr.c:362:11: warning: Same expression on 
both sides of '-'. [duplicateExpression]
 [3] = 1 - 1,
 ^

vim +1517 drivers/gpu/drm/i915/display/intel_psr.c

b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 
2021-02-04  1503  void intel_psr_wait_for_idle(const struct intel_crtc_state 
*new_crtc_state)
b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 
2021-02-04  1504  {
b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 
2021-02-04  1505struct drm_i915_private *dev_priv = 
to_i915(new_crtc_state->uapi.crtc->dev);
b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 
2021-02-04  1506struct intel_encoder *encoder;
b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 
2021-02-04  1507  
b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 
2021-02-04  1508if (!new_crtc_state->has_psr)
b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 
2021-02-04  1509return;
b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 
2021-02-04  1510  
b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 
2021-02-04  1511for_each_intel_encoder_mask_can_psr(_priv->drm, 
encoder,
b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 
2021-02-04  1512
new_crtc_state->uapi.encoder_mask) {
b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 
2021-02-04  1513struct intel_dp *intel_dp = 
enc_to_intel_dp(encoder);
b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 
2021-02-04  1514u32 psr_status;
b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 
2021-02-04  1515  
b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 
2021-02-04  1516mutex_lock(_dp->psr.lock);
b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 
2021-02-04 @1517if (!intel_dp->psr.enabled ||
b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 
2021-02-04  1518(intel_dp->psr.enabled && 
intel_dp->psr.psr2_enabled)) {

 ^
More clear to write:

if (!intel_dp->psr.enabled || intel_dp->psr.psr2_enabled) {
mutex_unlock(_dp->psr.lock);
continue;
}

b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 
2021-02-04  1519mutex_unlock(_dp->psr.lock);
b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 
2021-02-04  1520continue;
b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 
2021-02-04  1521}
b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 
2021-02-04  1522  
b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 
2021-02-04  1523/* when the PSR1 is enabled */
b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 
2021-02-04  1524if (psr_wait_for_idle(intel_dp, _status))
b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 
2021-02-04  1525drm_err(_priv->drm,
b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 
2021-02-04  1526"PSR idle timed out 0x%x, 
atomic update may fail\n",
b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 
2021-02-04  1527psr_status);
b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 
2021-02-04  1528mutex_unlock(_dp->psr.lock);
b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 
2021-02-04  1529}
b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 
2021-02-04  1530  }

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org

[kbuild] [linux-next:master 317/9190] drivers/gpu/drm/i915/display/intel_psr.c:1517:30: warning: Redundant condition: intel_dp->psr.enabled. '!A || (A && B)' is equivalent to '!A || B' [redundantCondi

2021-04-03 Thread kernel test robot

CC: kbuild-...@lists.01.org
CC: Linux Memory Management List 
TO: "Gwan-gyeong Mun" 
CC: "José Roberto de Souza" 
CC: Anshuman Gupta 

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git 
master
head:   454c576c3f5e51d60f00a4ac0dde07f4f9d70e9d
commit: b64d6c51380b7dea17d5503a250ca9cc84025453 [317/9190] drm/i915/display: 
Support PSR Multiple Instances
:: branch date: 2 days ago
:: commit date: 8 weeks ago
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot 


cppcheck possible warnings: (new ones prefixed by >>, may not real problems)

>> drivers/gpu/drm/i915/display/intel_psr.c:1517:30: warning: Redundant 
>> condition: intel_dp->psr.enabled. '!A || (A && B)' is equivalent to '!A || 
>> B' [redundantCondition]
 if (!intel_dp->psr.enabled ||
^
   drivers/gpu/drm/i915/display/intel_psr.c:362:11: warning: Same expression on 
both sides of '-'. [duplicateExpression]
 [3] = 1 - 1,
 ^

vim +1517 drivers/gpu/drm/i915/display/intel_psr.c

c43dbcbbcc8c51 drivers/gpu/drm/i915/intel_psr.c Tarun Vyas  
2018-06-27  1495  
b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 
2021-02-04  1496  /**
b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 
2021-02-04  1497   * intel_psr_wait_for_idle - wait for PSR1 to idle
b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 
2021-02-04  1498   * @new_crtc_state: new CRTC state
b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 
2021-02-04  1499   *
b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 
2021-02-04  1500   * This function is expected to be called from 
pipe_update_start() where it is
b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 
2021-02-04  1501   * not expected to race with PSR enable or disable.
b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 
2021-02-04  1502   */
b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 
2021-02-04  1503  void intel_psr_wait_for_idle(const struct intel_crtc_state 
*new_crtc_state)
b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 
2021-02-04  1504  {
b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 
2021-02-04  1505struct drm_i915_private *dev_priv = 
to_i915(new_crtc_state->uapi.crtc->dev);
b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 
2021-02-04  1506struct intel_encoder *encoder;
b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 
2021-02-04  1507  
b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 
2021-02-04  1508if (!new_crtc_state->has_psr)
b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 
2021-02-04  1509return;
b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 
2021-02-04  1510  
b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 
2021-02-04  1511for_each_intel_encoder_mask_can_psr(_priv->drm, 
encoder,
b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 
2021-02-04  1512
new_crtc_state->uapi.encoder_mask) {
b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 
2021-02-04  1513struct intel_dp *intel_dp = 
enc_to_intel_dp(encoder);
b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 
2021-02-04  1514u32 psr_status;
b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 
2021-02-04  1515  
b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 
2021-02-04  1516mutex_lock(_dp->psr.lock);
b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 
2021-02-04 @1517if (!intel_dp->psr.enabled ||
b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 
2021-02-04  1518(intel_dp->psr.enabled && 
intel_dp->psr.psr2_enabled)) {
b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 
2021-02-04  1519mutex_unlock(_dp->psr.lock);
b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 
2021-02-04  1520continue;
b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 
2021-02-04  1521}
b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 
2021-02-04  1522  
b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 
2021-02-04  1523/* when the PSR1 is enabled */
b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c Gwan-gyeong Mun 
2021-02-04  1524if (psr_wait_for_idle(intel_dp, _status))
b64d6c51380b7d drivers/gpu/drm/i915/display/intel_psr.c

[kbuild] [linux-next:master 317/9190] drivers/gpu/drm/i915/display/intel_psr.c:1517:30: warning: Redundant condition: intel_dp->psr.enabled. '!A || (A && B)' is equivalent to '!A || B' [redundantCondi

[kbuild] [linux-next:master 317/9190] drivers/gpu/drm/i915/display/intel_psr.c:1517:30: warning: Redundant condition: intel_dp->psr.enabled. '!A || (A && B)' is equivalent to '!A || B' [redundantCondi

2 matches

Site Navigation

Mail list logo

Footer information