Re: [kbuild] [net-next:master 1271/1277] drivers/net/ethernet/rocker/rocker.c:3078 rocker_port_fdb() warn: passing freed memory 'fdb'
False positives.
regards,
dan carpenter
On Wed, Dec 03, 2014 at 03:28:58PM +0800, kbuild test robot wrote:
TO: Scott Feldman sfel...@gmail.com
CC: Jiri Pirko j...@resnulli.us
tree: git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git
master
head: d8febb77b52ebddb9bd03ccaa5b61005e3a45a85
commit: 6c7079450071f889b4c2b55f8d030b1a5e859401 [1271/1277] rocker:
implement L2 bridge offloading
:: branch date: 3 hours ago
:: commit date: 3 hours ago
New smatch warnings:
drivers/net/ethernet/rocker/rocker.c:3078 rocker_port_fdb() warn: passing
freed memory 'fdb'
Old smatch warnings:
drivers/net/ethernet/rocker/rocker.c:1242 rocker_port_set_enable() warn:
should '1 rocker_port-lport' be a 64 bit type?
drivers/net/ethernet/rocker/rocker.c:2375 rocker_flow_tbl_bridge() warn:
maybe use instead of
drivers/net/ethernet/rocker/rocker.c:2377 rocker_flow_tbl_bridge() warn:
maybe use instead of
drivers/net/ethernet/rocker/rocker.c:2381 rocker_flow_tbl_bridge() warn: add
some parenthesis here?
drivers/net/ethernet/rocker/rocker.c:2381 rocker_flow_tbl_bridge() warn:
maybe use instead of
drivers/net/ethernet/rocker/rocker.c:2383 rocker_flow_tbl_bridge() warn: add
some parenthesis here?
drivers/net/ethernet/rocker/rocker.c:2383 rocker_flow_tbl_bridge() warn:
maybe use instead of
drivers/net/ethernet/rocker/rocker.c:2385 rocker_flow_tbl_bridge() warn: add
some parenthesis here?
git remote add net-next
git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git
git remote update net-next
git checkout 6c7079450071f889b4c2b55f8d030b1a5e859401
vim +/fdb +3078 drivers/net/ethernet/rocker/rocker.c
6c707945 Scott Feldman 2014-11-28 3062
6c707945 Scott Feldman 2014-11-28 3063
spin_lock_irqsave(rocker-fdb_tbl_lock, lock_flags);
6c707945 Scott Feldman 2014-11-28 3064
6c707945 Scott Feldman 2014-11-28 3065 found =
rocker_fdb_tbl_find(rocker, fdb);
6c707945 Scott Feldman 2014-11-28 3066
6c707945 Scott Feldman 2014-11-28 3067 if (removing found) {
6c707945 Scott Feldman 2014-11-28 3068 kfree(fdb);
6c707945 Scott Feldman 2014-11-28 3069 hash_del(found-entry);
6c707945 Scott Feldman 2014-11-28 3070 } else if (!removing !found)
{
6c707945 Scott Feldman 2014-11-28 3071
hash_add(rocker-fdb_tbl, fdb-entry, fdb-key_crc32);
6c707945 Scott Feldman 2014-11-28 3072 }
6c707945 Scott Feldman 2014-11-28 3073
6c707945 Scott Feldman 2014-11-28 3074
spin_unlock_irqrestore(rocker-fdb_tbl_lock, lock_flags);
6c707945 Scott Feldman 2014-11-28 3075
6c707945 Scott Feldman 2014-11-28 3076 /* Check if adding and already
exists, or removing and can't find */
6c707945 Scott Feldman 2014-11-28 3077 if (!found != !removing) {
6c707945 Scott Feldman 2014-11-28 @3078 kfree(fdb);
6c707945 Scott Feldman 2014-11-28 3079 if (!found removing)
6c707945 Scott Feldman 2014-11-28 3080 return 0;
6c707945 Scott Feldman 2014-11-28 3081 /* Refreshing existing
to update aging timers */
6c707945 Scott Feldman 2014-11-28 3082 flags |=
ROCKER_OP_FLAG_REFRESH;
6c707945 Scott Feldman 2014-11-28 3083 }
6c707945 Scott Feldman 2014-11-28 3084
6c707945 Scott Feldman 2014-11-28 3085 return
rocker_port_fdb_learn(rocker_port, flags, addr, vlan_id);
6c707945 Scott Feldman 2014-11-28 3086 }
---
0-DAY kernel test infrastructureOpen Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild Intel Corporation
___
kbuild mailing list
kbuild@lists.01.org
https://lists.01.org/mailman/listinfo/kbuild
[kbuild] [net-next:master 1271/1277] drivers/net/ethernet/rocker/rocker.c:3078 rocker_port_fdb() warn: passing freed memory 'fdb'
TO: Scott Feldman sfel...@gmail.com
CC: Jiri Pirko j...@resnulli.us
tree: git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master
head: d8febb77b52ebddb9bd03ccaa5b61005e3a45a85
commit: 6c7079450071f889b4c2b55f8d030b1a5e859401 [1271/1277] rocker: implement
L2 bridge offloading
:: branch date: 3 hours ago
:: commit date: 3 hours ago
New smatch warnings:
drivers/net/ethernet/rocker/rocker.c:3078 rocker_port_fdb() warn: passing freed
memory 'fdb'
Old smatch warnings:
drivers/net/ethernet/rocker/rocker.c:1242 rocker_port_set_enable() warn: should
'1 rocker_port-lport' be a 64 bit type?
drivers/net/ethernet/rocker/rocker.c:2375 rocker_flow_tbl_bridge() warn: maybe
use instead of
drivers/net/ethernet/rocker/rocker.c:2377 rocker_flow_tbl_bridge() warn: maybe
use instead of
drivers/net/ethernet/rocker/rocker.c:2381 rocker_flow_tbl_bridge() warn: add
some parenthesis here?
drivers/net/ethernet/rocker/rocker.c:2381 rocker_flow_tbl_bridge() warn: maybe
use instead of
drivers/net/ethernet/rocker/rocker.c:2383 rocker_flow_tbl_bridge() warn: add
some parenthesis here?
drivers/net/ethernet/rocker/rocker.c:2383 rocker_flow_tbl_bridge() warn: maybe
use instead of
drivers/net/ethernet/rocker/rocker.c:2385 rocker_flow_tbl_bridge() warn: add
some parenthesis here?
git remote add net-next
git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git
git remote update net-next
git checkout 6c7079450071f889b4c2b55f8d030b1a5e859401
vim +/fdb +3078 drivers/net/ethernet/rocker/rocker.c
6c707945 Scott Feldman 2014-11-28 3062
6c707945 Scott Feldman 2014-11-28 3063
spin_lock_irqsave(rocker-fdb_tbl_lock, lock_flags);
6c707945 Scott Feldman 2014-11-28 3064
6c707945 Scott Feldman 2014-11-28 3065 found =
rocker_fdb_tbl_find(rocker, fdb);
6c707945 Scott Feldman 2014-11-28 3066
6c707945 Scott Feldman 2014-11-28 3067 if (removing found) {
6c707945 Scott Feldman 2014-11-28 3068 kfree(fdb);
6c707945 Scott Feldman 2014-11-28 3069 hash_del(found-entry);
6c707945 Scott Feldman 2014-11-28 3070 } else if (!removing !found)
{
6c707945 Scott Feldman 2014-11-28 3071
hash_add(rocker-fdb_tbl, fdb-entry, fdb-key_crc32);
6c707945 Scott Feldman 2014-11-28 3072 }
6c707945 Scott Feldman 2014-11-28 3073
6c707945 Scott Feldman 2014-11-28 3074
spin_unlock_irqrestore(rocker-fdb_tbl_lock, lock_flags);
6c707945 Scott Feldman 2014-11-28 3075
6c707945 Scott Feldman 2014-11-28 3076 /* Check if adding and already
exists, or removing and can't find */
6c707945 Scott Feldman 2014-11-28 3077 if (!found != !removing) {
6c707945 Scott Feldman 2014-11-28 @3078 kfree(fdb);
6c707945 Scott Feldman 2014-11-28 3079 if (!found removing)
6c707945 Scott Feldman 2014-11-28 3080 return 0;
6c707945 Scott Feldman 2014-11-28 3081 /* Refreshing existing
to update aging timers */
6c707945 Scott Feldman 2014-11-28 3082 flags |=
ROCKER_OP_FLAG_REFRESH;
6c707945 Scott Feldman 2014-11-28 3083 }
6c707945 Scott Feldman 2014-11-28 3084
6c707945 Scott Feldman 2014-11-28 3085 return
rocker_port_fdb_learn(rocker_port, flags, addr, vlan_id);
6c707945 Scott Feldman 2014-11-28 3086 }
---
0-DAY kernel test infrastructureOpen Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild Intel Corporation
___
kbuild mailing list
kbuild@lists.01.org
https://lists.01.org/mailman/listinfo/kbuild
