[kbuild] [staging:staging-next 461/473] drivers/staging/vt6655/device_main.c:1023 device_free_info() warn: variable dereferenced before check 'pDevice' (see line 1021)

2014-09-01 Thread Dan Carpenter
tree:   git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git 
staging-next
head:   f25884839e7e8de72b3c0da518900f5915b7c4b1
commit: 70afb8e5037a97d7294955531395b65e225c98e1 [461/473] staging: vt6655: 
remove multiple instances of driver loading.

New smatch warnings:
drivers/staging/vt6655/device_main.c:1023 device_free_info() warn: variable 
dereferenced before check 'pDevice' (see line 1021)

Old smatch warnings:
drivers/staging/vt6655/device_main.c:1771 device_dma0_xmit() error: 
__builtin_memcpy() 'pDevice-sTxEthHeader.abyDstAddr' too small (6 vs 14)
drivers/staging/vt6655/device_main.c:1962 device_xmit() error: 
__builtin_memcpy() 'pDevice-sTxEthHeader.abyDstAddr' too small (6 vs 14)
drivers/staging/vt6655/device_main.c:2137 device_xmit() error: we previously 
assumed 'pTransmitKey' could be null (see line 2041)
drivers/staging/vt6655/device_main.c:2523 Config_FileOperation() warn: 
returning -1 instead of -ENOMEM is sloppy
drivers/staging/vt6655/device_main.c:2821 device_ioctl() warn: check that 
'range' doesn't leak information (struct has a hole after 'num_bitrates')

git remote add staging 
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
git remote update staging
git checkout 70afb8e5037a97d7294955531395b65e225c98e1
vim +/pDevice +1023 drivers/staging/vt6655/device_main.c

5449c685 Forest Bond   2009-04-25  1015  
1b12068a Charles Clément   2010-08-01  1016 return true;
5449c685 Forest Bond   2009-04-25  1017  }
5449c685 Forest Bond   2009-04-25  1018  
3f8597f4 Malcolm Priestley 2014-08-10  1019  static void 
device_free_info(struct vnt_private *pDevice)
84b50762 Guillaume Clement 2014-07-25  1020  {
5449c685 Forest Bond   2009-04-25 @1021 struct net_device *dev = 
pDevice-dev;
5449c685 Forest Bond   2009-04-25  1022  
70afb8e5 Malcolm Priestley 2014-08-21 @1023 if (!pDevice)
70afb8e5 Malcolm Priestley 2014-08-21  1024 return;
70afb8e5 Malcolm Priestley 2014-08-21  1025  
5449c685 Forest Bond   2009-04-25  1026 ASSERT(pDevice);

---
0-DAY kernel build testing backend  Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild Intel Corporation
___
kbuild mailing list
kbuild@lists.01.org
https://lists.01.org/mailman/listinfo/kbuild


[kbuild] [staging:staging-next 461/473] drivers/staging/vt6655/device_main.c:1023 device_free_info() warn: variable dereferenced before check 'pDevice' (see line 1021)

2014-08-30 Thread kbuild test robot
TO: Malcolm Priestley tvbox...@gmail.com
CC: Greg Kroah-Hartman gre...@linuxfoundation.org

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git 
staging-next
head:   f25884839e7e8de72b3c0da518900f5915b7c4b1
commit: 70afb8e5037a97d7294955531395b65e225c98e1 [461/473] staging: vt6655: 
remove multiple instances of driver loading.
:: branch date: 8 minutes ago
:: commit date: 15 minutes ago

New smatch warnings:
drivers/staging/vt6655/device_main.c:1023 device_free_info() warn: variable 
dereferenced before check 'pDevice' (see line 1021)

Old smatch warnings:
drivers/staging/vt6655/device_main.c:1771 device_dma0_xmit() error: 
__builtin_memcpy() 'pDevice-sTxEthHeader.abyDstAddr' too small (6 vs 14)
drivers/staging/vt6655/device_main.c:1962 device_xmit() error: 
__builtin_memcpy() 'pDevice-sTxEthHeader.abyDstAddr' too small (6 vs 14)
drivers/staging/vt6655/device_main.c:2137 device_xmit() error: we previously 
assumed 'pTransmitKey' could be null (see line 2041)
drivers/staging/vt6655/device_main.c:2523 Config_FileOperation() warn: 
returning -1 instead of -ENOMEM is sloppy
drivers/staging/vt6655/device_main.c:2821 device_ioctl() warn: check that 
'range' doesn't leak information (struct has a hole after 'num_bitrates')

git remote add staging 
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
git remote update staging
git checkout 70afb8e5037a97d7294955531395b65e225c98e1
vim +/pDevice +1023 drivers/staging/vt6655/device_main.c

5449c685 Forest Bond   2009-04-25  1015  
1b12068a Charles Clément   2010-08-01  1016 return true;
5449c685 Forest Bond   2009-04-25  1017  }
5449c685 Forest Bond   2009-04-25  1018  
3f8597f4 Malcolm Priestley 2014-08-10  1019  static void 
device_free_info(struct vnt_private *pDevice)
84b50762 Guillaume Clement 2014-07-25  1020  {
5449c685 Forest Bond   2009-04-25 @1021 struct net_device *dev = 
pDevice-dev;
5449c685 Forest Bond   2009-04-25  1022  
70afb8e5 Malcolm Priestley 2014-08-21 @1023 if (!pDevice)
70afb8e5 Malcolm Priestley 2014-08-21  1024 return;
70afb8e5 Malcolm Priestley 2014-08-21  1025  
5449c685 Forest Bond   2009-04-25  1026 ASSERT(pDevice);

---
0-DAY kernel build testing backend  Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild Intel Corporation
___
kbuild mailing list
kbuild@lists.01.org
https://lists.01.org/mailman/listinfo/kbuild