[kbuild] [ubifs:master 18/23] drivers/mtd/ubi/block.c:508 ubiblock_resize() error: potentially dereferencing uninitialized 'dev'.

2014-07-31 Thread kbuild test robot 
TO: Richard Weinberger rich...@nod.at
CC: Artem Bityutskiy artem.bityuts...@linux.intel.com
CC: Ezequiel Garcia ezequiel.gar...@free-electrons.com

tree:   git://git.infradead.org/linux-ubifs.git master
head:   675ed2cad7be2477dadb70ff77316d125ae85b6f
commit: 4df38926f337ff4de49a8fb512aa4a55df0c502d [18/23] UBI: block: Avoid disk 
size integer overflow
:: branch date: 34 minutes ago
:: commit date: 3 days ago

drivers/mtd/ubi/block.c:508 ubiblock_resize() error: potentially dereferencing 
uninitialized 'dev'.

git remote add ubifs git://git.infradead.org/linux-ubifs.git
git remote update ubifs
git checkout 4df38926f337ff4de49a8fb512aa4a55df0c502d
vim +/dev +508 drivers/mtd/ubi/block.c

9d54c8a3 Ezequiel Garcia2014-02-25  492  
9d54c8a3 Ezequiel Garcia2014-02-25  493 /* Flush pending work and stop 
this workqueue */
9d54c8a3 Ezequiel Garcia2014-02-25  494 destroy_workqueue(dev-wq);
9d54c8a3 Ezequiel Garcia2014-02-25  495  
9d54c8a3 Ezequiel Garcia2014-02-25  496 ubiblock_cleanup(dev);
9d54c8a3 Ezequiel Garcia2014-02-25  497 mutex_unlock(dev-dev_mutex);
9d54c8a3 Ezequiel Garcia2014-02-25  498 kfree(dev);
9d54c8a3 Ezequiel Garcia2014-02-25  499 return 0;
9d54c8a3 Ezequiel Garcia2014-02-25  500  }
9d54c8a3 Ezequiel Garcia2014-02-25  501  
495f2bf6 Ezequiel Garcia2014-05-05  502  static int ubiblock_resize(struct 
ubi_volume_info *vi)
9d54c8a3 Ezequiel Garcia2014-02-25  503  {
9d54c8a3 Ezequiel Garcia2014-02-25  504 struct ubiblock *dev;
4df38926 Richard Weinberger 2014-05-05  505 u64 disk_capacity = 
((u64)vi-size * vi-usable_leb_size)  9;
9d54c8a3 Ezequiel Garcia2014-02-25  506  
4df38926 Richard Weinberger 2014-05-05  507 if ((sector_t)disk_capacity != 
disk_capacity) {
4df38926 Richard Weinberger 2014-05-05 @508 ubi_warn(%s: the 
volume is too big, cannot resize (%d LEBs),
4df38926 Richard Weinberger 2014-05-05  509  
dev-gd-disk_name, vi-size);
4df38926 Richard Weinberger 2014-05-05  510 return -EFBIG;
4df38926 Richard Weinberger 2014-05-05  511 }
9d54c8a3 Ezequiel Garcia2014-02-25  512 /*
9d54c8a3 Ezequiel Garcia2014-02-25  513  * Need to lock the device list 
until we stop using the device,
4d283ee2 Artem Bityutskiy   2014-03-04  514  * otherwise the device struct 
might get released in
4d283ee2 Artem Bityutskiy   2014-03-04  515  * 'ubiblock_remove()'.
9d54c8a3 Ezequiel Garcia2014-02-25  516  */

---
0-DAY kernel build testing backend  Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild Intel Corporation
___
kbuild mailing list
kbuild@lists.01.org
https://lists.01.org/mailman/listinfo/kbuild

Re: [kbuild] [ubifs:master 18/23] drivers/mtd/ubi/block.c:508 ubiblock_resize() error: potentially dereferencing uninitialized 'dev'.

2014-07-31 Thread Dan Carpenter 
I sent this one earlier this morning.

regards,
dan carpenter

On Thu, Jul 31, 2014 at 09:28:26PM +0800, kbuild test robot wrote:
 TO: Richard Weinberger rich...@nod.at
 CC: Artem Bityutskiy artem.bityuts...@linux.intel.com
 CC: Ezequiel Garcia ezequiel.gar...@free-electrons.com
 
 tree:   git://git.infradead.org/linux-ubifs.git master
 head:   675ed2cad7be2477dadb70ff77316d125ae85b6f
 commit: 4df38926f337ff4de49a8fb512aa4a55df0c502d [18/23] UBI: block: Avoid 
 disk size integer overflow
 :: branch date: 34 minutes ago
 :: commit date: 3 days ago
 
 drivers/mtd/ubi/block.c:508 ubiblock_resize() error: potentially 
 dereferencing uninitialized 'dev'.
 
 git remote add ubifs git://git.infradead.org/linux-ubifs.git
 git remote update ubifs
 git checkout 4df38926f337ff4de49a8fb512aa4a55df0c502d
 vim +/dev +508 drivers/mtd/ubi/block.c
 
 9d54c8a3 Ezequiel Garcia2014-02-25  492  
 9d54c8a3 Ezequiel Garcia2014-02-25  493   /* Flush pending work and stop 
 this workqueue */
 9d54c8a3 Ezequiel Garcia2014-02-25  494   destroy_workqueue(dev-wq);
 9d54c8a3 Ezequiel Garcia2014-02-25  495  
 9d54c8a3 Ezequiel Garcia2014-02-25  496   ubiblock_cleanup(dev);
 9d54c8a3 Ezequiel Garcia2014-02-25  497   mutex_unlock(dev-dev_mutex);
 9d54c8a3 Ezequiel Garcia2014-02-25  498   kfree(dev);
 9d54c8a3 Ezequiel Garcia2014-02-25  499   return 0;
 9d54c8a3 Ezequiel Garcia2014-02-25  500  }
 9d54c8a3 Ezequiel Garcia2014-02-25  501  
 495f2bf6 Ezequiel Garcia2014-05-05  502  static int 
 ubiblock_resize(struct ubi_volume_info *vi)
 9d54c8a3 Ezequiel Garcia2014-02-25  503  {
 9d54c8a3 Ezequiel Garcia2014-02-25  504   struct ubiblock *dev;
 4df38926 Richard Weinberger 2014-05-05  505   u64 disk_capacity = 
 ((u64)vi-size * vi-usable_leb_size)  9;
 9d54c8a3 Ezequiel Garcia2014-02-25  506  
 4df38926 Richard Weinberger 2014-05-05  507   if ((sector_t)disk_capacity != 
 disk_capacity) {
 4df38926 Richard Weinberger 2014-05-05 @508   ubi_warn(%s: the 
 volume is too big, cannot resize (%d LEBs),
 4df38926 Richard Weinberger 2014-05-05  509
 dev-gd-disk_name, vi-size);
 4df38926 Richard Weinberger 2014-05-05  510   return -EFBIG;
 4df38926 Richard Weinberger 2014-05-05  511   }
 9d54c8a3 Ezequiel Garcia2014-02-25  512   /*
 9d54c8a3 Ezequiel Garcia2014-02-25  513* Need to lock the device list 
 until we stop using the device,
 4d283ee2 Artem Bityutskiy   2014-03-04  514* otherwise the device struct 
 might get released in
 4d283ee2 Artem Bityutskiy   2014-03-04  515* 'ubiblock_remove()'.
 9d54c8a3 Ezequiel Garcia2014-02-25  516*/
 
 ---
 0-DAY kernel build testing backend  Open Source Technology Center
 http://lists.01.org/mailman/listinfo/kbuild Intel Corporation
___
kbuild mailing list
kbuild@lists.01.org
https://lists.01.org/mailman/listinfo/kbuild