subject:"\[kbuild\] Re\: \[PATCH net\-next v2 1\/2\] of\: net\: pass the dst buffer to of_get_mac

[kbuild] Re: [PATCH net-next v2 1/2] of: net: pass the dst buffer to of_get_mac_address()

2021-04-13 Thread Dan Carpenter

Hi Michael,

url:
https://github.com/0day-ci/linux/commits/Michael-Walle/of-net-support-non-platform-devices-in-of_get_mac_address/20210406-234030
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 
cc0626c2aaed8e475efdd85fa374b497a7192e35
config: x86_64-randconfig-m001-20210406 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot 
Reported-by: Dan Carpenter 

smatch warnings:
drivers/net/ethernet/xilinx/xilinx_axienet_main.c:2069 axienet_probe() warn: 
passing a valid pointer to 'PTR_ERR'

vim +/PTR_ERR +2069 drivers/net/ethernet/xilinx/xilinx_axienet_main.c

522856cefaf09d Robert Hancock  2019-06-06  2060 /* Check for Ethernet 
core IRQ (optional) */
522856cefaf09d Robert Hancock  2019-06-06  2061 if (lp->eth_irq <= 0)
522856cefaf09d Robert Hancock  2019-06-06  2062 
dev_info(>dev, "Ethernet core IRQ not defined\n");
522856cefaf09d Robert Hancock  2019-06-06  2063  
8a3b7a252dca9f Daniel Borkmann 2012-01-19  2064 /* Retrieve the MAC 
address */
411b125c6ace1f Michael Walle   2021-04-06  2065 ret = 
of_get_mac_address(pdev->dev.of_node, mac_addr);
411b125c6ace1f Michael Walle   2021-04-06  2066 if (!ret) {
411b125c6ace1f Michael Walle   2021-04-06  2067 
axienet_set_mac_address(ndev, mac_addr);
411b125c6ace1f Michael Walle   2021-04-06  2068 } else {
d05a9ed5c3a773 Robert Hancock  2019-06-06 @2069 
dev_warn(>dev, "could not find MAC address property: %ld\n",
d05a9ed5c3a773 Robert Hancock  2019-06-06  2070  
PTR_ERR(mac_addr));
 
^
This should print "ret".

411b125c6ace1f Michael Walle   2021-04-06  2071 
axienet_set_mac_address(ndev, NULL);
8a3b7a252dca9f Daniel Borkmann 2012-01-19  2072 }
8a3b7a252dca9f Daniel Borkmann 2012-01-19  2073  
8a3b7a252dca9f Daniel Borkmann 2012-01-19  2074 lp->coalesce_count_rx = 
XAXIDMA_DFT_RX_THRESHOLD;
8a3b7a252dca9f Daniel Borkmann 2012-01-19  2075 lp->coalesce_count_tx = 
XAXIDMA_DFT_TX_THRESHOLD;

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org


.config.gz
Description: application/gzip
___
kbuild mailing list -- kbuild@lists.01.org
To unsubscribe send an email to kbuild-le...@lists.01.org

[kbuild] Re: [PATCH net-next v2 1/2] of: net: pass the dst buffer to of_get_mac_address()

2021-04-09 Thread Dan Carpenter

Hi Michael,

I love your patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]

url:
https://github.com/0day-ci/linux/commits/Michael-Walle/of-net-support-non-platform-devices-in-of_get_mac_address/20210406-234030
 
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git  
cc0626c2aaed8e475efdd85fa374b497a7192e35
config: x86_64-randconfig-m001-20210406 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot 
Reported-by: Dan Carpenter 

smatch warnings:
drivers/net/ethernet/xilinx/xilinx_axienet_main.c:2069 axienet_probe() warn: 
passing a valid pointer to 'PTR_ERR'

vim +/PTR_ERR +2069 drivers/net/ethernet/xilinx/xilinx_axienet_main.c

2be586205ca2b8 Srikanth Thokala2015-05-05  1832  static int 
axienet_probe(struct platform_device *pdev)
8a3b7a252dca9f Daniel Borkmann 2012-01-19  1833  {
8495659bf93c8e Srikanth Thokala2015-05-05  1834 int ret;
8a3b7a252dca9f Daniel Borkmann 2012-01-19  1835 struct device_node *np;
8a3b7a252dca9f Daniel Borkmann 2012-01-19  1836 struct axienet_local 
*lp;
8a3b7a252dca9f Daniel Borkmann 2012-01-19  1837 struct net_device *ndev;
28ef9ebdb64c6f Robert Hancock  2019-06-06  1838 struct resource *ethres;
411b125c6ace1f Michael Walle   2021-04-06  1839 u8 mac_addr[ETH_ALEN];
^^

5fff0151b3244d Andre Przywara  2020-03-24  1840 int addr_width = 32;
8495659bf93c8e Srikanth Thokala2015-05-05  1841 u32 value;
8a3b7a252dca9f Daniel Borkmann 2012-01-19  1842  
8a3b7a252dca9f Daniel Borkmann 2012-01-19  1843 ndev = 
alloc_etherdev(sizeof(*lp));
41de8d4cff21a2 Joe Perches 2012-01-29  1844 if (!ndev)
8a3b7a252dca9f Daniel Borkmann 2012-01-19  1845 return -ENOMEM;
8a3b7a252dca9f Daniel Borkmann 2012-01-19  1846  
95219aa538e11d Srikanth Thokala2015-05-05  1847 
platform_set_drvdata(pdev, ndev);
8a3b7a252dca9f Daniel Borkmann 2012-01-19  1848  
95219aa538e11d Srikanth Thokala2015-05-05  1849 SET_NETDEV_DEV(ndev, 
>dev);
8a3b7a252dca9f Daniel Borkmann 2012-01-19  1850 ndev->flags &= 
~IFF_MULTICAST;  /* clear multicast */
28e24c62ab3062 Eric Dumazet2013-12-02  1851 ndev->features = 
NETIF_F_SG;
8a3b7a252dca9f Daniel Borkmann 2012-01-19  1852 ndev->netdev_ops = 
_netdev_ops;
8a3b7a252dca9f Daniel Borkmann 2012-01-19  1853 ndev->ethtool_ops = 
_ethtool_ops;
8a3b7a252dca9f Daniel Borkmann 2012-01-19  1854  
d894be57ca92c8 Jarod Wilson2016-10-20  1855 /* MTU range: 64 - 9000 
*/
d894be57ca92c8 Jarod Wilson2016-10-20  1856 ndev->min_mtu = 64;
d894be57ca92c8 Jarod Wilson2016-10-20  1857 ndev->max_mtu = 
XAE_JUMBO_MTU;
d894be57ca92c8 Jarod Wilson2016-10-20  1858  
8a3b7a252dca9f Daniel Borkmann 2012-01-19  1859 lp = netdev_priv(ndev);
8a3b7a252dca9f Daniel Borkmann 2012-01-19  1860 lp->ndev = ndev;
95219aa538e11d Srikanth Thokala2015-05-05  1861 lp->dev = >dev;
8a3b7a252dca9f Daniel Borkmann 2012-01-19  1862 lp->options = 
XAE_OPTION_DEFAULTS;
8b09ca823ffb4e Robert Hancock  2019-06-06  1863 lp->rx_bd_num = 
RX_BD_NUM_DEFAULT;
8b09ca823ffb4e Robert Hancock  2019-06-06  1864 lp->tx_bd_num = 
TX_BD_NUM_DEFAULT;
57baf8cc70ea4c Robert Hancock  2021-02-12  1865  
b11bfb9a19f9d7 Robert Hancock  2021-03-25  1866 lp->axi_clk = 
devm_clk_get_optional(>dev, "s_axi_lite_clk");
b11bfb9a19f9d7 Robert Hancock  2021-03-25  1867 if (!lp->axi_clk) {
b11bfb9a19f9d7 Robert Hancock  2021-03-25  1868 /* For backward 
compatibility, if named AXI clock is not present,
b11bfb9a19f9d7 Robert Hancock  2021-03-25  1869  * treat the 
first clock specified as the AXI clock.
b11bfb9a19f9d7 Robert Hancock  2021-03-25  1870  */
b11bfb9a19f9d7 Robert Hancock  2021-03-25  1871 lp->axi_clk = 
devm_clk_get_optional(>dev, NULL);
b11bfb9a19f9d7 Robert Hancock  2021-03-25  1872 }
b11bfb9a19f9d7 Robert Hancock  2021-03-25  1873 if 
(IS_ERR(lp->axi_clk)) {
b11bfb9a19f9d7 Robert Hancock  2021-03-25  1874 ret = 
PTR_ERR(lp->axi_clk);
57baf8cc70ea4c Robert Hancock  2021-02-12  1875 goto 
free_netdev;
57baf8cc70ea4c Robert Hancock  2021-02-12  1876 }
b11bfb9a19f9d7 Robert Hancock  2021-03-25  1877 ret = 
clk_prepare_enable(lp->axi_clk);
57baf8cc70ea4c Robert Hancock  2021-02-12  1878 if (ret) {
b11bfb9a19f9d7 Robert Hancock  2021-03-25  1879 
dev_err(>dev, "Unable to enable AXI clock: %d\n", ret);
57baf8cc70ea4c Robert Hancock  2021-02-12  1880 goto 
free_netdev;
57baf8cc70ea4c Robert Hancock  2021-02-12  1881 }
57baf8cc70ea4c Robert Hancock  2021-02-12  1882

[kbuild] Re: [PATCH net-next v2 1/2] of: net: pass the dst buffer to of_get_mac_address()

2021-04-06 Thread kernel test robot

CC: kbuild-...@lists.01.org
In-Reply-To: <20210406153725.10059-2-mich...@walle.cc>
References: <20210406153725.10059-2-mich...@walle.cc>
TO: Michael Walle 
TO: ath9k-de...@qca.qualcomm.com
TO: unglinuxdri...@microchip.com
TO: linux-arm-ker...@lists.infradead.org
TO: linux-ker...@vger.kernel.org
TO: linuxppc-...@lists.ozlabs.org
TO: net...@vger.kernel.org
TO: linux-media...@lists.infradead.org
TO: linux-renesas-...@vger.kernel.org
TO: linux-st...@st-md-mailman.stormreply.com
TO: linux-amlo...@lists.infradead.org

Hi Michael,

I love your patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]

url:
https://github.com/0day-ci/linux/commits/Michael-Walle/of-net-support-non-platform-devices-in-of_get_mac_address/20210406-234030
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 
cc0626c2aaed8e475efdd85fa374b497a7192e35
:: branch date: 5 hours ago
:: commit date: 5 hours ago
config: x86_64-randconfig-m001-20210406 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot 
Reported-by: Dan Carpenter 

smatch warnings:
drivers/net/ethernet/xilinx/xilinx_axienet_main.c:2069 axienet_probe() warn: 
passing a valid pointer to 'PTR_ERR'

vim +/PTR_ERR +2069 drivers/net/ethernet/xilinx/xilinx_axienet_main.c

8a3b7a252dca9f Daniel Borkmann 2012-01-19  1819  
8a3b7a252dca9f Daniel Borkmann 2012-01-19  1820  /**
2be586205ca2b8 Srikanth Thokala2015-05-05  1821   * axienet_probe - Axi 
Ethernet probe function.
95219aa538e11d Srikanth Thokala2015-05-05  1822   * @pdev:  Pointer to 
platform device structure.
8a3b7a252dca9f Daniel Borkmann 2012-01-19  1823   *
b0d081c524b46c Michal Simek2015-05-05  1824   * Return: 0, on success
8a3b7a252dca9f Daniel Borkmann 2012-01-19  1825   * Non-zero error 
value on failure.
8a3b7a252dca9f Daniel Borkmann 2012-01-19  1826   *
8a3b7a252dca9f Daniel Borkmann 2012-01-19  1827   * This is the probe 
routine for Axi Ethernet driver. This is called before
8a3b7a252dca9f Daniel Borkmann 2012-01-19  1828   * any other driver 
routines are invoked. It allocates and sets up the Ethernet
8a3b7a252dca9f Daniel Borkmann 2012-01-19  1829   * device. Parses through 
device tree and populates fields of
8a3b7a252dca9f Daniel Borkmann 2012-01-19  1830   * axienet_local. It 
registers the Ethernet device.
8a3b7a252dca9f Daniel Borkmann 2012-01-19  1831   */
2be586205ca2b8 Srikanth Thokala2015-05-05  1832  static int 
axienet_probe(struct platform_device *pdev)
8a3b7a252dca9f Daniel Borkmann 2012-01-19  1833  {
8495659bf93c8e Srikanth Thokala2015-05-05  1834 int ret;
8a3b7a252dca9f Daniel Borkmann 2012-01-19  1835 struct device_node *np;
8a3b7a252dca9f Daniel Borkmann 2012-01-19  1836 struct axienet_local 
*lp;
8a3b7a252dca9f Daniel Borkmann 2012-01-19  1837 struct net_device *ndev;
28ef9ebdb64c6f Robert Hancock  2019-06-06  1838 struct resource *ethres;
411b125c6ace1f Michael Walle   2021-04-06  1839 u8 mac_addr[ETH_ALEN];
5fff0151b3244d Andre Przywara  2020-03-24  1840 int addr_width = 32;
8495659bf93c8e Srikanth Thokala2015-05-05  1841 u32 value;
8a3b7a252dca9f Daniel Borkmann 2012-01-19  1842  
8a3b7a252dca9f Daniel Borkmann 2012-01-19  1843 ndev = 
alloc_etherdev(sizeof(*lp));
41de8d4cff21a2 Joe Perches 2012-01-29  1844 if (!ndev)
8a3b7a252dca9f Daniel Borkmann 2012-01-19  1845 return -ENOMEM;
8a3b7a252dca9f Daniel Borkmann 2012-01-19  1846  
95219aa538e11d Srikanth Thokala2015-05-05  1847 
platform_set_drvdata(pdev, ndev);
8a3b7a252dca9f Daniel Borkmann 2012-01-19  1848  
95219aa538e11d Srikanth Thokala2015-05-05  1849 SET_NETDEV_DEV(ndev, 
>dev);
8a3b7a252dca9f Daniel Borkmann 2012-01-19  1850 ndev->flags &= 
~IFF_MULTICAST;  /* clear multicast */
28e24c62ab3062 Eric Dumazet2013-12-02  1851 ndev->features = 
NETIF_F_SG;
8a3b7a252dca9f Daniel Borkmann 2012-01-19  1852 ndev->netdev_ops = 
_netdev_ops;
8a3b7a252dca9f Daniel Borkmann 2012-01-19  1853 ndev->ethtool_ops = 
_ethtool_ops;
8a3b7a252dca9f Daniel Borkmann 2012-01-19  1854  
d894be57ca92c8 Jarod Wilson2016-10-20  1855 /* MTU range: 64 - 9000 
*/
d894be57ca92c8 Jarod Wilson2016-10-20  1856 ndev->min_mtu = 64;
d894be57ca92c8 Jarod Wilson2016-10-20  1857 ndev->max_mtu = 
XAE_JUMBO_MTU;
d894be57ca92c8 Jarod Wilson2016-10-20  1858  
8a3b7a252dca9f Daniel Borkmann 2012-01-19  1859 lp = netdev_priv(ndev);
8a3b7a252dca9f Daniel Borkmann 2012-01-19  1860 lp->ndev = ndev;
95219aa538e11d Srikanth Thokala2015-05-05  1861 lp->dev = >dev;
8a3b7a252dca9f Daniel Borkmann 2012-01-19  1862 lp->options = 
XAE_OPTION_DEFAULTS;
8b09ca823ffb4e Robert Hancock  2019-06-06  1863 lp->rx_bd_num =

[kbuild] Re: [PATCH net-next v2 1/2] of: net: pass the dst buffer to of_get_mac_address()

[kbuild] Re: [PATCH net-next v2 1/2] of: net: pass the dst buffer to of_get_mac_address()

[kbuild] Re: [PATCH net-next v2 1/2] of: net: pass the dst buffer to of_get_mac_address()

3 matches

Site Navigation

Mail list logo

Footer information