CC: kbuild-...@lists.01.org In-Reply-To: <1590585268-25423-1-git-send-email-christian.gr...@microchip.com> References: <1590585268-25423-1-git-send-email-christian.gr...@microchip.com> TO: Christian Gromm <christian.gr...@microchip.com> TO: gre...@linuxfoundation.org CC: Christian Gromm <christian.gr...@microchip.com> CC: driverdev-de...@linuxdriverproject.org CC: linux-...@vger.kernel.org
Hi Christian, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on staging/staging-testing] [also build test WARNING on linus/master v5.7-rc7 next-20200529] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Christian-Gromm/drivers-most-add-USB-adapter-driver/20200527-211740 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git 36cf583eaff3458abbfac144c5e4d417a23fa1a1 :::::: branch date: 4 days ago :::::: commit date: 4 days ago config: x86_64-randconfig-m001-20200531 (attached as .config) compiler: gcc-9 (Debian 9.3.0-13) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kbuild test robot <l...@intel.com> Reported-by: Dan Carpenter <dan.carpen...@oracle.com> smatch warnings: drivers/most/most_usb.c:220 get_stream_frame_size() error: uninitialized symbol 'frame_size'. # https://github.com/0day-ci/linux/commit/0ea547bd5c23af58b60f907ee741a02bb1488a4e git remote add linux-review https://github.com/0day-ci/linux git remote update linux-review git checkout 0ea547bd5c23af58b60f907ee741a02bb1488a4e vim +/frame_size +220 drivers/most/most_usb.c 0ea547bd5c23af Christian Gromm 2020-05-27 186 0ea547bd5c23af Christian Gromm 2020-05-27 187 /** 0ea547bd5c23af Christian Gromm 2020-05-27 188 * get_stream_frame_size - calculate frame size of current configuration 0ea547bd5c23af Christian Gromm 2020-05-27 189 * @dev: device structure 0ea547bd5c23af Christian Gromm 2020-05-27 190 * @cfg: channel configuration 0ea547bd5c23af Christian Gromm 2020-05-27 191 */ 0ea547bd5c23af Christian Gromm 2020-05-27 192 static unsigned int get_stream_frame_size(struct device *dev, 0ea547bd5c23af Christian Gromm 2020-05-27 193 struct most_channel_config *cfg) 0ea547bd5c23af Christian Gromm 2020-05-27 194 { 0ea547bd5c23af Christian Gromm 2020-05-27 195 unsigned int frame_size; 0ea547bd5c23af Christian Gromm 2020-05-27 196 unsigned int sub_size = cfg->subbuffer_size; 0ea547bd5c23af Christian Gromm 2020-05-27 197 0ea547bd5c23af Christian Gromm 2020-05-27 198 if (!sub_size) { 0ea547bd5c23af Christian Gromm 2020-05-27 199 dev_warn(dev, "Misconfig: Subbuffer size zero.\n"); 0ea547bd5c23af Christian Gromm 2020-05-27 200 return 0; 0ea547bd5c23af Christian Gromm 2020-05-27 201 } 0ea547bd5c23af Christian Gromm 2020-05-27 202 switch (cfg->data_type) { 0ea547bd5c23af Christian Gromm 2020-05-27 203 case MOST_CH_ISOC: 0ea547bd5c23af Christian Gromm 2020-05-27 204 frame_size = AV_PACKETS_PER_XACT * sub_size; 0ea547bd5c23af Christian Gromm 2020-05-27 205 break; 0ea547bd5c23af Christian Gromm 2020-05-27 206 case MOST_CH_SYNC: 0ea547bd5c23af Christian Gromm 2020-05-27 207 if (cfg->packets_per_xact == 0) { 0ea547bd5c23af Christian Gromm 2020-05-27 208 dev_warn(dev, "Misconfig: Packets per XACT zero\n"); 0ea547bd5c23af Christian Gromm 2020-05-27 209 frame_size = 0; 0ea547bd5c23af Christian Gromm 2020-05-27 210 } else if (cfg->packets_per_xact == 0xFF) { 0ea547bd5c23af Christian Gromm 2020-05-27 211 frame_size = (USB_MTU / sub_size) * sub_size; 0ea547bd5c23af Christian Gromm 2020-05-27 212 } else { 0ea547bd5c23af Christian Gromm 2020-05-27 213 frame_size = cfg->packets_per_xact * sub_size; 0ea547bd5c23af Christian Gromm 2020-05-27 214 } 0ea547bd5c23af Christian Gromm 2020-05-27 215 break; 0ea547bd5c23af Christian Gromm 2020-05-27 216 default: 0ea547bd5c23af Christian Gromm 2020-05-27 217 dev_warn(dev, "Query frame size of non-streaming channel\n"); 0ea547bd5c23af Christian Gromm 2020-05-27 218 break; 0ea547bd5c23af Christian Gromm 2020-05-27 219 } 0ea547bd5c23af Christian Gromm 2020-05-27 @220 return frame_size; 0ea547bd5c23af Christian Gromm 2020-05-27 221 } 0ea547bd5c23af Christian Gromm 2020-05-27 222 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
_______________________________________________ kbuild mailing list -- kbuild@lists.01.org To unsubscribe send an email to kbuild-le...@lists.01.org
