[kbuild] Re: drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c:1433 amdgpu_discovery_get_vcn_info() error: buffer overflow 'adev->vcn.vcn_codec_disable_mask' 2 <= 3
On Thu, Jun 02, 2022 at 10:24:58AM -0400, Alex Deucher wrote: > On Thu, Jun 2, 2022 at 7:51 AM Dan Carpenter wrote: > > > > On Thu, Jun 02, 2022 at 08:26:03AM +0200, Ernst Sjöstrand wrote: > > > Dan: I also ran Smatch which resulted in the following discussion: > > > > > > https://lists.freedesktop.org/archives/amd-gfx/2022-May/079228.html > > > > Since the bounds check is dead code which does not make sense and is not > > required, another idea would be to just delete it. > > It wouldn't be dead code if AMDGPU_MAX_VCN_INSTANCES ever increased. Or we could add a comment to the code I suppose. /* Impossible in 2022 but this check might sense in the future */ regards, dan carpenter ___ kbuild mailing list -- kbuild@lists.01.org To unsubscribe send an email to kbuild-le...@lists.01.org
[kbuild] Re: drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c:1433 amdgpu_discovery_get_vcn_info() error: buffer overflow 'adev->vcn.vcn_codec_disable_mask' 2 <= 3
On Thu, Jun 02, 2022 at 08:26:03AM +0200, Ernst Sjöstrand wrote: > Dan: I also ran Smatch which resulted in the following discussion: > > https://lists.freedesktop.org/archives/amd-gfx/2022-May/079228.html Since the bounds check is dead code which does not make sense and is not required, another idea would be to just delete it. regards, dan carpenter ___ kbuild mailing list -- kbuild@lists.01.org To unsubscribe send an email to kbuild-le...@lists.01.org
[kbuild] Re: drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c:1433 amdgpu_discovery_get_vcn_info() error: buffer overflow 'adev->vcn.vcn_codec_disable_mask' 2 <= 3
On Fri, May 27, 2022 at 07:56:48AM +, Chen, Guchun wrote: > A patch was available already to protect against such scenario. > > https://patchwork.freedesktop.org/patch/486289/ , "drm/amdgpu/discovery: > validate VCN and SDMA instances" > What? That's an unrelated patch and it has already been applied so I took it into consideration when doing my analysis. regards, dan carpenter ___ kbuild mailing list -- kbuild@lists.01.org To unsubscribe send an email to kbuild-le...@lists.01.org