[krita] [Bug 357493] Remember color history after reopening a document
https://bugs.kde.org/show_bug.cgi?id=357493 --- Comment #7 from Bourumir Wyngs --- There is a merge request on this at https://invent.kde.org/graphics/krita/-/merge_requests/1424 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 452834] New: Segmentation fault when closing multiple windows
https://bugs.kde.org/show_bug.cgi?id=452834 Bug ID: 452834 Summary: Segmentation fault when closing multiple windows Product: krita Version: git master (please specify the git hash!) Platform: Ubuntu Packages OS: Linux Status: REPORTED Severity: normal Priority: NOR Component: * Unknown Assignee: krita-bugs-n...@kde.org Reporter: bourumir.wy...@gmail.com Target Milestone: --- Created attachment 148289 --> https://bugs.kde.org/attachment.cgi?id=148289=edit gdb backtrace SUMMARY When more than one window is used, closing windows one by one terminates Krita with segmentation fault. Segmentation fault message is visible in console and can be analyzed with gdb. Crash rather than normal termination may prevent saving state on exit. *** STEPS TO REPRODUCE 1. Start krita from the command line, so that the terminal output is visible. 2. Open one picture. 3. Open another picture in a new window, using Window -> New Window from menu. 4. Close both windows, starting from the last opened window. Sometimes the crash happens when closing the first window, sometimes when another but I have never seen a clean exit at this point. At this step Krita will terminate with segmentation fault message in console. Or, if running under gdb, the following message will appear: Thread 1 "krita" received signal SIGSEGV, Segmentation fault. KoToolProxy::priv (this=0x0) at kritadev/krita/libs/flake/KoToolProxy.cpp:495 495 return d; OBSERVED RESULT Segmentation fault EXPECTED RESULT Normal exit SOFTWARE/OS VERSIONS Ubuntu Mate 20.04. Standard build as recommended in documentation. Master branch commit 6419e038185a3377f638d26e34588a56c0f71cd8 . ADDITIONAL INFORMATION >From the code analysis looks like the crash happens because 'this' is null in KisToolProxy::activateToolAction. The bug can be suppressed by adding check if (this == nullptr) return at the start of this method, but some more in depth analysis would probably be beneficial, maybe we should not get there starting from. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 357493] Remember color history after reopening a document
https://bugs.kde.org/show_bug.cgi?id=357493 Bourumir Wyngs changed: What|Removed |Added CC||bourumir.wy...@gmail.com --- Comment #6 from Bourumir Wyngs --- As discussed in IRC with @tiar, I will try to put the color history into KisConfig. We agreed that the resource system is less appropriate for this. To avoid writing to hard drive too often, the color history will only be dropped into KisConfig in destructor. This does not look very critical resource to be saved on every change; currently not saved at all. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 445089] English comment making no sense
https://bugs.kde.org/show_bug.cgi?id=445089 --- Comment #5 from Bourumir Wyngs --- One of the ways to resolve this is to ask for the bug reporter to propose the error message as expected behavior. Considering the bug report currently does not define expected behavior. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 445089] English comment making no sense
https://bugs.kde.org/show_bug.cgi?id=445089 Bourumir Wyngs changed: What|Removed |Added Assignee|bourumir.wy...@gmail.com|krita-bugs-n...@kde.org --- Comment #3 from Bourumir Wyngs --- Due some reason not obvious for me Krita developer team rejects this single line merge request, even if I tried to tweak the phraseology. Yielding. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 421084] t variable is reasigned in kis_color_selector.cpp
https://bugs.kde.org/show_bug.cgi?id=421084 Bourumir Wyngs changed: What|Removed |Added CC||bourumir.wy...@gmail.com --- Comment #3 from Bourumir Wyngs --- I think this is not "for code change" but rather there are serious reasons to suspect that the code does a different thing than it was intended by the original author. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 445089] English comment making no sense
https://bugs.kde.org/show_bug.cgi?id=445089 Bourumir Wyngs changed: What|Removed |Added Assignee|krita-bugs-n...@kde.org |bourumir.wy...@gmail.com --- Comment #2 from Bourumir Wyngs --- I have opened the merge request is https://invent.kde.org/graphics/krita/-/merge_requests/1414 The text as it stands now is "The saved archive %1 is broken as it is missing the expected file %2. Please try to save again to another location." I also named 'file' into 'archive' in the statement nearby. This code checks for the file presence in the saved .zip archives. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 445089] English comment making no sense
https://bugs.kde.org/show_bug.cgi?id=445089
Bourumir Wyngs changed:
What|Removed |Added
CC||bourumir.wy...@gmail.com
--- Comment #1 from Bourumir Wyngs ---
The code there checks if each of the list of files is present in the saved
store (saved file archive). If any one is missing, this is not good and then
all saved store is seen as broken:
Q_FOREACH(const QString , filesToCheck) {
if (!store->hasFile(file)) {
return i18n("File %1 is missing in %2 and is broken. Please try to
save again in a different location.", file, fileName);
}
This probably can be translated as:
The saved bundle %1 is broken as it is missing the expected file %2. Please try
to save again in a different location.
--
You are receiving this mail because:
You are watching all bug changes.
[krita] [Bug 430363] Allow frame rates less than 1 for GIF export
https://bugs.kde.org/show_bug.cgi?id=430363 --- Comment #6 from Bourumir Wyngs --- This feature will be additionally discussed at https://krita-artists.org/t/fractional-frame-rates-needed-or-not/39513 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 430363] Allow frame rates less than 1 for GIF export
https://bugs.kde.org/show_bug.cgi?id=430363 --- Comment #5 from Bourumir Wyngs --- Proposed merge request https://invent.kde.org/graphics/krita/-/merge_requests/1400?commit_id=2b78f5e71c5bc7be46aeeea49168aa2ad66df452 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 430363] Allow frame rates less than 1 for GIF export
https://bugs.kde.org/show_bug.cgi?id=430363 Bourumir Wyngs changed: What|Removed |Added Assignee|krita-bugs-n...@kde.org |bourumir.wy...@gmail.com --- Comment #4 from Bourumir Wyngs --- I will propose the change that supports fractional frame rates in story board and also in export dialogs. Instead of complicating the user selection with fractional parts, I simply extended the existing spin box to spin down below 1 into 1/2 and other fractions. 3/2 is also provided. Fractions are useful for educational animations that may run slowly and do not need many frames. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 440122] Krita export overwrites files without asking
https://bugs.kde.org/show_bug.cgi?id=440122 Bourumir Wyngs changed: What|Removed |Added Status|ASSIGNED|CONFIRMED Assignee|bourumir.wy...@gmail.com|krita-bugs-n...@kde.org -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 430363] Allow frame rates less than 1 for GIF export
https://bugs.kde.org/show_bug.cgi?id=430363 Bourumir Wyngs changed: What|Removed |Added CC||bourumir.wy...@gmail.com --- Comment #3 from Bourumir Wyngs --- I suggest adding fractional rates to the spin box: 2/3, 1/2, 1/3, 1/4, 1/5, 1/10 . This looks clear and intuitive enough and would be useful for educational animations like matrix multiplication, or chemical reaction, or how exactly the Judo throw should be performed. Such animations require serious thinking while watching and slow speeds may be for them appropriate. This would require a derivative of QSpinBox where rendering is overridden. We can think on possible alternatives. If the community is OK, I can take over this request of enhancement and implement the change. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 451473] The "Animated PNG Image" export has file extension .png instead of .apng
https://bugs.kde.org/show_bug.cgi?id=451473
Bourumir Wyngs changed:
What|Removed |Added
CC||bourumir.wy...@gmail.com
--- Comment #4 from Bourumir Wyngs ---
This is a feature, not a bug. In KisDlgAnimationRenderer::defaultVideoFileName
we see:
videoFileName =
QString("%1%2%3.%4").arg(path).arg('/').arg(baseName).arg(KisMimeDatabase::suffixesForMimeType(
mimeType == "image/apng" ? "image/png":mimeType ).first());
Please confirm it is OK to remove the "feature", it is not a big work for us to
do this. If I just remove this override, KisMimeDatabase database suggests
.apng for image/apng and the file name is suggested as expected.
Also, calling first() on empty list may result the undefined behavior. We
should probably have a check there.
--
You are receiving this mail because:
You are watching all bug changes.
[krita] [Bug 303151] Ability for Digital Color Mixer to save state and reset to defaults
https://bugs.kde.org/show_bug.cgi?id=303151 Bourumir Wyngs changed: What|Removed |Added Assignee|krita-bugs-n...@kde.org |bourumir.wy...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 440122] Krita export overwrites files without asking
https://bugs.kde.org/show_bug.cgi?id=440122 Bourumir Wyngs changed: What|Removed |Added Assignee|krita-bugs-n...@kde.org |bourumir.wy...@gmail.com --- Comment #8 from Bourumir Wyngs --- This is because both Export and Save As dialogs rely on the native QFileDialog ability for checking and confirming the file overwrite. If we alter the file name later, as by adding the extension for the typed-in name without extension, this does not longer works as expected. -- You are receiving this mail because: You are watching all bug changes.
