[krita] [Bug 473760] Krita crashes when saving

2023-08-30 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=473760

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/krita/-/commit/a8e420b |hics/krita/-/commit/9bcab19
   |afd48e55e33d5fee89836d3d71f |c91e3b3d9d9536c769f66e595ef
   |fb9ffb  |f2e2ba

--- Comment #5 from Dmitry Kazakov  ---
Git commit 9bcab19c91e3b3d9d9536c769f66e595eff2e2ba by Dmitry Kazakov.
Committed on 30/08/2023 at 13:27.
Pushed by dkazakov into branch 'master'.

Possibly fix a crash when switching animated documents

We shouldn't delete KisPlaybackEngineQT::Private::measure on every
stop of the playback, because the timer events may be randomly
postponed and we can end up reading from a null location.

M  +22   -22   libs/ui/KisPlaybackEngineQT.cpp

https://invent.kde.org/graphics/krita/-/commit/9bcab19c91e3b3d9d9536c769f66e595eff2e2ba

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 473760] Krita crashes when saving

2023-08-30 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=473760

Dmitry Kazakov  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
  Latest Commit||https://invent.kde.org/grap
   ||hics/krita/-/commit/a8e420b
   ||afd48e55e33d5fee89836d3d71f
   ||fb9ffb
 Resolution|--- |FIXED

--- Comment #4 from Dmitry Kazakov  ---
Git commit a8e420bafd48e55e33d5fee89836d3d71ffb9ffb by Dmitry Kazakov.
Committed on 30/08/2023 at 12:22.
Pushed by dkazakov into branch 'krita/5.2'.

Possibly fix a crash when switching animated documents

We shouldn't delete KisPlaybackEngineQT::Private::measure on every
stop of the playback, because the timer events may be randomly
postponed and we can end up reading from a null location.

M  +22   -22   libs/ui/KisPlaybackEngineQT.cpp

https://invent.kde.org/graphics/krita/-/commit/a8e420bafd48e55e33d5fee89836d3d71ffb9ffb

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 473760] Krita crashes when saving

2023-08-30 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=473760

Dmitry Kazakov  changed:

   What|Removed |Added

 CC||ahmettab...@gmail.com

--- Comment #3 from Dmitry Kazakov  ---
*** Bug 472763 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 472763] Animation play CRASH!! (beta1 and nightly 5.3.0-prealpha-179e89dec5)

2023-08-30 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=472763

Dmitry Kazakov  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #6 from Dmitry Kazakov  ---
The backtrace is exactly the same as in bug 473760, so marking that as a
duplicate...

*** This bug has been marked as a duplicate of bug 473760 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 473760] Krita crashes when saving

2023-08-30 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=473760

--- Comment #2 from Dmitry Kazakov  ---
The problem happens in line 276 in
KisPlaybackEngineQT::throttledDriverCallback(). It seems like `m_d->measure` is
null by the time of the call. The problem is that two lines above Krita
writes(!) into the same location, so, most probably, some recursion happens in
`bool neededRefresh = displayProxy->displayFrame(targetFrame, false)` function
call... :(


269 [1] if (currentFrame != targetFrame) {
0x7ffc752fe3a4  <+  868>41 39 c4cmp%eax,%r12d
0x7ffc752fe3a7  <+  871>74 36   je
0x7ffc752fe3df <_ZN19KisPlaybackEngineQT23throttledDriverCallbackEv+927>
C:/Packaging/KritaWS/deps-install/include/QtCore/qscopedpointer.h:
0x7ffc752fe3a9  <+  873>48 8b 4e 28 mov   
0x28(%rsi),%rcx
0x7ffc752fe3ad  <+  877>48 8b 11mov(%rcx),%rdx
0x7ffc752fe3b0  <+  880>48 8b 49 08 mov   
0x8(%rcx),%rcx
106 [1] return m_dropFrames;
0x7ffc752fe3b4  <+  884>0f b6 52 3c movzbl
0x3c(%rdx),%edx
271 [1] m_d->measure->waitingForFrame =
!m_d->driver->dropFrames();
0x7ffc752fe3b8  <+  888>80 f2 01xor$0x1,%dl
0x7ffc752fe3bb  <+  891>88 51 18mov   
%dl,0x18(%rcx)
273 [1] bool neededRefresh =
displayProxy->displayFrame(targetFrame, false);
0x7ffc752fe3be  <+  894>48 89 f9mov%rdi,%rcx
0x7ffc752fe3c1  <+  897>89 c2   mov%eax,%edx
0x7ffc752fe3c3  <+  899>45 31 c0xor%r8d,%r8d
0x7ffc752fe3c6  <+  902>e8 b5 c6 37 00  call  
0x7ffc7567aa80 <_ZN20KisFrameDisplayProxy12displayFrameEib>
C:/Packaging/KritaWS/deps-install/include/QtCore/qscopedpointer.h:
0x7ffc752fe3cb  <+  907>48 8b 4e 28 mov   
0x28(%rsi),%rcx
0x7ffc752fe3cf  <+  911>48 8b 49 08 mov   
0x8(%rcx),%rcx
276 [1] m_d->measure->waitingForFrame =
m_d->measure->waitingForFrame && neededRefresh;
0x7ffc752fe3d3  <+  915>80 79 18 00 cmpb  
$0x0,0x18(%rcx)
0x7ffc752fe3d7  <+  919>0f 95 c2setne  %dl
0x7ffc752fe3da  <+  922>20 c2   and%al,%dl
0x7ffc752fe3dc  <+  924>88 51 18mov   
%dl,0x18(%rcx)
279 [1] }

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 472763] Animation play CRASH!! (beta1 and nightly 5.3.0-prealpha-179e89dec5)

2023-08-30 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=472763

--- Comment #5 from Dmitry Kazakov  ---
That seems to be the same crash as in bug
https://bugs.kde.org/show_bug.cgi?id=473760 though it needs rechecking

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 473715] Line/shape tools: KisPaintInformation::drawingAngleSafe() DirectionHistoryInfo object is not available

2023-08-30 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=473715

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/krita/-/commit/165992c |hics/krita/-/commit/4616984
   |517e4f1a225a0f1adb5a5da696d |d1efe15bf501e4a973099830e64
   |3b2876  |ceda6e

--- Comment #2 from Dmitry Kazakov  ---
Git commit 4616984d1efe15bf501e4a973099830e64ceda6e by Dmitry Kazakov.
Committed on 30/08/2023 at 09:59.
Pushed by dkazakov into branch 'krita/5.2'.

Fix a warning in outline generation code in shape tools

M  +23   -2libs/ui/tool/kis_tool_paint.cc
M  +3-0libs/ui/tool/kis_tool_paint.h

https://invent.kde.org/graphics/krita/-/commit/4616984d1efe15bf501e4a973099830e64ceda6e

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 473715] Line/shape tools: KisPaintInformation::drawingAngleSafe() DirectionHistoryInfo object is not available

2023-08-30 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=473715

Dmitry Kazakov  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED
  Latest Commit||https://invent.kde.org/grap
   ||hics/krita/-/commit/165992c
   ||517e4f1a225a0f1adb5a5da696d
   ||3b2876

--- Comment #1 from Dmitry Kazakov  ---
Git commit 165992c517e4f1a225a0f1adb5a5da696d3b2876 by Dmitry Kazakov.
Committed on 30/08/2023 at 09:48.
Pushed by dkazakov into branch 'master'.

Fix a warning in outline generation code in shape tools

M  +23   -2libs/ui/tool/kis_tool_paint.cc
M  +3-0libs/ui/tool/kis_tool_paint.h

https://invent.kde.org/graphics/krita/-/commit/165992c517e4f1a225a0f1adb5a5da696d3b2876

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 469116] Cant launch through Steam but the .sh and .appimage work in steamapps folder

2023-08-30 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=469116

--- Comment #4 from Dmitry Kazakov  ---
Hi, Emmet!

To run the unpacked appimage you need to set up two variables:

APPIMAGE=1 APPDIR=/extracted/path ./AppRun

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 473750] krita crashes after pasting text out of edit text window or hitting ctrl+v on krita window with text in the clipboard

2023-08-29 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=473750

Dmitry Kazakov  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
 Resolution|--- |FIXED

--- Comment #4 from Dmitry Kazakov  ---
Hi, Fausto!

Thank you very much for your help with testing! :)

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 473853] Artifacts when dragging a layer under a filter that produces new pixels outside the paint layer contents rect

2023-08-29 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=473853

Dmitry Kazakov  changed:

   What|Removed |Added

   Keywords||regression
 CC||dimul...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 473719] When activating some tools, actions are always enabled at first

2023-08-29 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=473719

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/krita/-/commit/c4c0d1a |hics/krita/-/commit/087c9ef
   |02fb9a2e273c9b4ee67d7282146 |921bc70e5bee9ddc646ba4d34ad
   |4f4861  |153e89

--- Comment #2 from Dmitry Kazakov  ---
Git commit 087c9ef921bc70e5bee9ddc646ba4d34ad153e89 by Dmitry Kazakov.
Committed on 29/08/2023 at 11:07.
Pushed by dkazakov into branch 'master'.

Fix 'enabled' state of the actions in the Default Tool

The tool manager enables all the actions unconditionally, we should
do that **before** actually calling the tool's activate method.

M  +16   -2libs/flake/KoToolManager.cpp

https://invent.kde.org/graphics/krita/-/commit/087c9ef921bc70e5bee9ddc646ba4d34ad153e89

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 473719] When activating some tools, actions are always enabled at first

2023-08-29 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=473719

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/grap
   ||hics/krita/-/commit/c4c0d1a
   ||02fb9a2e273c9b4ee67d7282146
   ||4f4861
 Resolution|--- |FIXED
 Status|REPORTED|RESOLVED

--- Comment #1 from Dmitry Kazakov  ---
Git commit c4c0d1a02fb9a2e273c9b4ee67d72821464f4861 by Dmitry Kazakov.
Committed on 29/08/2023 at 11:07.
Pushed by dkazakov into branch 'krita/5.2'.

Fix 'enabled' state of the actions in the Default Tool

The tool manager enables all the actions unconditionally, we should
do that **before** actually calling the tool's activate method.

M  +16   -2libs/flake/KoToolManager.cpp

https://invent.kde.org/graphics/krita/-/commit/c4c0d1a02fb9a2e273c9b4ee67d72821464f4861

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 461350] Krita Freezes and crashes without a crash log - no matter what - after a few minutes of usage.

2023-08-29 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=461350

--- Comment #5 from Dmitry Kazakov  ---
Thank you for your kind words! :)

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 473724] New Blending Info feature: Opacity info is slow to update

2023-08-29 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=473724

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/krita/-/commit/fd204a7 |hics/krita/-/commit/1c2ca25
   |a6017a6ae2d0d19b24b1fd863e9 |dcd63e5edc8d39d6c7b789d9413
   |f48115  |a0f787

--- Comment #4 from Dmitry Kazakov  ---
Git commit 1c2ca25dcd63e5edc8d39d6c7b789d9413a0f787 by Dmitry Kazakov.
Committed on 29/08/2023 at 10:48.
Pushed by dkazakov into branch 'krita/5.2'.

Make sure that the node emits nodeChanged() signal on opacity change

That makes the layers model to update the item in the list

M  +1-0libs/image/kis_base_node.cpp

https://invent.kde.org/graphics/krita/-/commit/1c2ca25dcd63e5edc8d39d6c7b789d9413a0f787

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 473724] New Blending Info feature: Opacity info is slow to update

2023-08-29 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=473724

Dmitry Kazakov  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/grap
   ||hics/krita/-/commit/fd204a7
   ||a6017a6ae2d0d19b24b1fd863e9
   ||f48115
 Status|ASSIGNED|RESOLVED

--- Comment #3 from Dmitry Kazakov  ---
Git commit fd204a7a6017a6ae2d0d19b24b1fd863e9f48115 by Dmitry Kazakov.
Committed on 29/08/2023 at 10:48.
Pushed by dkazakov into branch 'master'.

Make sure that the node emits nodeChanged() signal on opacity change

That makes the layers model to update the item in the list

M  +1-0libs/image/kis_base_node.cpp

https://invent.kde.org/graphics/krita/-/commit/fd204a7a6017a6ae2d0d19b24b1fd863e9f48115

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 469116] Cant launch through Steam but the .sh and .appimage work in steamapps folder

2023-08-29 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=469116

Dmitry Kazakov  changed:

   What|Removed |Added

   Keywords||release_blocker
 CC||dimul...@gmail.com

--- Comment #3 from Dmitry Kazakov  ---
Just a note: here is an upstream report for it:

https://bugs.kde.org/show_bug.cgi?id=469116

We need to somehow add an environment variable to our **flatpack** packages of
Krita on steam:

```
export APPIMAGE_EXTRACT_AND_RUN=1
```

The most important thing is that non-flatpack packages of steam should **not**
use this variable. I'm not sure if it is possible to implement that though.

PS:
I've tested this environment variable in the normal docker environment, and it
seems to work correctly. **But** it make Krita's startup process a bit slower
(due to unpack operation, obviously)

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 472900] PSD import crash on Android (works fine on desktop)

2023-08-29 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=472900

Dmitry Kazakov  changed:

   What|Removed |Added

 Resolution|--- |WAITINGFORINFO
 Status|REPORTED|NEEDSINFO

--- Comment #8 from Dmitry Kazakov  ---
Hi, pinkdama!

Could you please check if the crash happens in the latest Krita 5.2.0 Beta2
builds? 

https://krita.org/en/item/second-beta-for-krita-5-2-0-released/

I have a feeling that the bug could have been fixed in bug 464015, and the fix
wasn't included in 5.1.x release cycle...

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 472705] 5.2 Beta 1 Android: App crashes shortly after transforming multiple layers or at random moments

2023-08-29 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=472705

Dmitry Kazakov  changed:

   What|Removed |Added

 CC||dimul...@gmail.com
   Keywords||regression, release_blocker

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 443799] Warp transform mask makes layer content invisible for a short time after layer reorder

2023-08-28 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=443799

Dmitry Kazakov  changed:

   What|Removed |Added

   Assignee|krita-bugs-n...@kde.org |dimul...@gmail.com
 CC||dimul...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 473719] When activating some tools, actions are always enabled at first

2023-08-28 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=473719

Dmitry Kazakov  changed:

   What|Removed |Added

 CC||dimul...@gmail.com
   Assignee|krita-bugs-n...@kde.org |dimul...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 473603] Exporting the time-lapse trough recorder gives "FFMPEG crashed" error and video is not exported (git 8bacaa0)

2023-08-28 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=473603

Dmitry Kazakov  changed:

   What|Removed |Added

 CC||dimul...@gmail.com

--- Comment #2 from Dmitry Kazakov  ---
Hi, Emmet!

Can this bug be related to the following report
https://bugs.kde.org/show_bug.cgi?id=473727 ?

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 473724] New Blending Info feature: Opacity info is slow to update

2023-08-28 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=473724

Dmitry Kazakov  changed:

   What|Removed |Added

   Keywords||regression, release_blocker

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 473724] New Blending Info feature: Opacity info is slow to update

2023-08-28 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=473724

Dmitry Kazakov  changed:

   What|Removed |Added

   Assignee|krita-bugs-n...@kde.org |dimul...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 473724] New Blending Info feature: Opacity info is slow to update

2023-08-28 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=473724

Dmitry Kazakov  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 CC||dimul...@gmail.com
 Status|REPORTED|CONFIRMED

--- Comment #1 from Dmitry Kazakov  ---
Hi, Askkegra!

Thanks a lot for the report. I can confirm the issue! :)

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 473748] opening popup-palette quickly after selecting a layer, selects another layer which name starts with the letter of the popup-palette keyboard shortcut.

2023-08-28 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=473748

Dmitry Kazakov  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 473806] Resizing an image leads to erroneous display of the data?

2023-08-28 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=473806

Dmitry Kazakov  changed:

   What|Removed |Added

 Resolution|--- |WAITINGFORINFO
 Status|REPORTED|NEEDSINFO
 CC||dimul...@gmail.com

--- Comment #1 from Dmitry Kazakov  ---
Hi, borkborkas!

Thank you very much for your report. Could you please answer a few questions
for me?

1) Do you mean that reopening the same image after scaling showed the entire
image scaled correctly, right?

2) Is this bug reproducible, that is, if you try to scale an image again, will
it show the checkers pattern again?

3) Could you try Krita 5.2.0 Beta2 version of Krita and see if the bug is still
reproducible there?

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 461350] Krita Freezes and crashes without a crash log - no matter what - after a few minutes of usage.

2023-08-28 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=461350

Dmitry Kazakov  changed:

   What|Removed |Added

 Status|REPORTED|NEEDSINFO
 Resolution|--- |WAITINGFORINFO

--- Comment #3 from Dmitry Kazakov  ---
Hi, Marek!

Could you please check the nightly version of the upcoming Krita 5.2? We have
fixed a lot of animation-related issues, including the ones happening when
applying transformation or move operations to the animated layer. There were
multiple issues caused by the new implementation of the 'auto-keyframe' option:

https://binary-factory.kde.org/job/Krita_Stable_Windows_Build/

If you still experience a crash in this build, please try disabling
"Auto-create keyframe" option and check if the crash goes away. Checking for
'kritacrash.log' again would also help.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 472900] PSD import crash on Android (works fine on desktop)

2023-08-28 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=472900

Dmitry Kazakov  changed:

   What|Removed |Added

   Severity|normal  |crash

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 473760] Krita crashes when saving

2023-08-28 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=473760

Dmitry Kazakov  changed:

   What|Removed |Added

   Keywords||regression, release_blocker
 CC||dimul...@gmail.com
 Ever confirmed|0   |1
 Status|REPORTED|ASSIGNED

--- Comment #1 from Dmitry Kazakov  ---
Hi, Angel!

Thank you very much for your report! I will try to look into it...

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 473484] Krita 5.2.0-beta 2 closes when trying to open animation file.

2023-08-28 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=473484

Dmitry Kazakov  changed:

   What|Removed |Added

 CC||anistagea_d...@outlook.com

--- Comment #7 from Dmitry Kazakov  ---
*** Bug 473767 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 473767] Any attempt at opening animation files results in the application closing after a few seconds

2023-08-28 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=473767

Dmitry Kazakov  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|REPORTED|RESOLVED
 CC||dimul...@gmail.com

--- Comment #1 from Dmitry Kazakov  ---
Hi, Anista!

Thank you very much for your report! I think the bug should now be fixed in
this nightly build of the stable branch:

https://binary-factory.kde.org/job/Krita_Stable_Windows_Build/

Could you please check if the bug doesn't happen in this build?

(the bug was related to the audio file attached to the .kra document; it was
possible to workaround it by creating any empty document first and adding audio
to it, after which Krita would open .kra's with audio properly...)

*** This bug has been marked as a duplicate of bug 473484 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 473750] krita crashes after pasting text out of edit text window or hitting ctrl+v on krita window with text in the clipboard

2023-08-28 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=473750

Dmitry Kazakov  changed:

   What|Removed |Added

 Resolution|--- |WAITINGFORINFO
 Status|REPORTED|NEEDSINFO
 CC||dimul...@gmail.com

--- Comment #1 from Dmitry Kazakov  ---
Hi, Fausto!

Could you please check if this bug is still reproducible in Krita 5.2.0 Beta2?
I guess wee have fixed a bug like that quite recently, so there should be no
crash in 5.2.x branch anymore...

Here is the page for downloading the beta-version:
https://krita.org/en/item/second-beta-for-krita-5-2-0-released/

If you can still reproduce the issue, please tell what software you copy text
from (and website, if it is chrome/firefox). And whether you somehow close the
source application in the meantime before pasting into Krita.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 473479] Krita app keeps crashing while im drawing

2023-08-28 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=473479

--- Comment #10 from Dmitry Kazakov  ---
Hi, Adele!

I think I have fixed the bug. I've also requested the nightly builds for the
stable branch, could you please test the resulting package when it finishes
building?

https://binary-factory.kde.org/job/Krita_Stable_Windows_Build/1957/

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 473479] Krita app keeps crashing while im drawing

2023-08-25 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=473479

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/krita/-/commit/966076d |hics/krita/-/commit/dc68a24
   |0265f8ea02bf01f76913edc5b52 |67eb038543345ecd23e67b9a354
   |e941d6  |31fd70

--- Comment #9 from Dmitry Kazakov  ---
Git commit dc68a2467eb038543345ecd23e67b9a35431fd70 by Dmitry Kazakov.
Committed on 25/08/2023 at 21:33.
Pushed by dkazakov into branch 'krita/5.2'.

Fix cross-colorspace bitBlt with channel flags

The channel flags passed to bitBlt should be applied to the
source pixels in source color space. It means that the channels
should be pre-processed with convertChannelToVisualRepresentation()
before being blended into the destination.

Please take it into account that source **color** flags should be
passed to convertChannelToVisualRepresentation, but **alpha** flags
should go to the final blend operation.

M  +1-22   libs/image/kis_layer_projection_plane.cpp
M  +1-1libs/image/kis_onion_skin_compositor.cpp
M  +1-1libs/image/kis_painter.cc
M  +37   -8libs/pigment/KoColorSpace.cpp
M  +16   -1libs/pigment/KoColorSpace_p.h
M  +201  -1libs/pigment/tests/TestKoColorSpaceAbstract.cpp
M  +3-0libs/pigment/tests/TestKoColorSpaceAbstract.h

https://invent.kde.org/graphics/krita/-/commit/dc68a2467eb038543345ecd23e67b9a35431fd70

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 473479] Krita app keeps crashing while im drawing

2023-08-25 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=473479

Dmitry Kazakov  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED
  Latest Commit||https://invent.kde.org/grap
   ||hics/krita/-/commit/966076d
   ||0265f8ea02bf01f76913edc5b52
   ||e941d6

--- Comment #8 from Dmitry Kazakov  ---
Git commit 966076d0265f8ea02bf01f76913edc5b52e941d6 by Dmitry Kazakov.
Committed on 25/08/2023 at 18:22.
Pushed by dkazakov into branch 'master'.

Fix cross-colorspace bitBlt with channel flags

The channel flags passed to bitBlt should be applied to the
source pixels in source color space. It means that the channels
should be pre-processed with convertChannelToVisualRepresentation()
before being blended into the destination.

Please take it into account that source **color** flags should be
passed to convertChannelToVisualRepresentation, but **alpha** flags
should go to the final blend operation.

M  +1-22   libs/image/kis_layer_projection_plane.cpp
M  +1-1libs/image/kis_onion_skin_compositor.cpp
M  +1-1libs/image/kis_painter.cc
M  +37   -8libs/pigment/KoColorSpace.cpp
M  +16   -1libs/pigment/KoColorSpace_p.h
M  +201  -1libs/pigment/tests/TestKoColorSpaceAbstract.cpp
M  +3-0libs/pigment/tests/TestKoColorSpaceAbstract.h

https://invent.kde.org/graphics/krita/-/commit/966076d0265f8ea02bf01f76913edc5b52e941d6

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 473748] opening popup-palette quickly after selecting a layer, selects another layer which name starts with the letter of the popup-palette keyboard shortcut.

2023-08-25 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=473748

Dmitry Kazakov  changed:

   What|Removed |Added

 Status|REPORTED|NEEDSINFO
 Resolution|--- |WAITINGFORINFO
 CC||dimul...@gmail.com

--- Comment #1 from Dmitry Kazakov  ---
Hi, fausto!

That is a standard functionality of any OS: an ability to select an item in a
list by typing its first letters. I'm not sure we should disable that
functionality for the layers list.

In Krita we have a spacial workaround for such behavior, when you actively
hover over the canvas for 400ms, Krita will automatically switch input focus to
the canvas, so the layers list accelerators will not work anymore. You can also
click on the canvas to explicitly set focus to it.

Basically, that applies to all single-letter shortcuts we have, like B, T, M
and so on. 

Can you try that 400-ms delay approach? Will it work for you?

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 473715] Line/shape tools: KisPaintInformation::drawingAngleSafe() DirectionHistoryInfo object is not available

2023-08-25 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=473715

Dmitry Kazakov  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|REPORTED|ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 473715] Line/shape tools: KisPaintInformation::drawingAngleSafe() DirectionHistoryInfo object is not available

2023-08-25 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=473715

Dmitry Kazakov  changed:

   What|Removed |Added

   Assignee|krita-bugs-n...@kde.org |dimul...@gmail.com
 CC||dimul...@gmail.com
   Keywords||release_blocker

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 473479] Krita app keeps crashing while im drawing

2023-08-23 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=473479

Dmitry Kazakov  changed:

   What|Removed |Added

   Assignee|krita-bugs-n...@kde.org |dimul...@gmail.com
   Keywords||release_blocker

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 473479] Krita app keeps crashing while im drawing

2023-08-23 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=473479

Dmitry Kazakov  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|REPORTED|ASSIGNED

--- Comment #5 from Dmitry Kazakov  ---
Okay, I think I can somewhat reproduce this bug. The problem happens if you do
the following:

1) Create a CMYK image
2) Paste an image from the internet (or another document) in RGB
3) Click inherit alpha on the pasted layer

It leads to an immediate crash:

Thread 219 (Thread 0x7fff778cc700 (LWP 254328) "Thread (pooled)"):
#0  __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50
set = {__val = {0, 4597185181852517762, 4605217331491495499,
4605217331491495499, 4601487774501153729, 4601487774501153729,
4606956589509306729, 4606956589509306729, 13666173069255770112,
4453497081515999232, 13679965343114592256, 13682920830370054144,
140735199090256, 140737344529147, 206158430240, 140735199090528}}
pid = 
tid = 
ret = 
#1  0x7fffeccb8859 in __GI_abort () at abort.c:79
save_stage = 1
act = {__sigaction_handler = {sa_handler = 0x0, sa_sigaction = 0x0},
sa_mask = {__val = {0 , 3, 140735199090712, 140735199090952,
140737172565129, 0}}, sa_flags = 137288, sa_restorer = 0xfffeef19336}
sigs = {__val = {32, 0 }}
#2  0x7fffed2a2c0f in qt_message_fatal (message=...,
context=...) at
/home/appimage/appimage-workspace/deps-build/ext_qt/ext_qt-prefix/src/ext_qt/qtbase/src/corelib/global/qlogging.cpp:1924
No locals.
#3  QMessageLogger::fatal (this=this@entry=0x7fff778c9908,
msg=msg@entry=0x7fffed5c2000 "ASSERT: \"%s\" in file %s, line %d") at
/home/appimage/appimage-workspace/deps-build/ext_qt/ext_qt-prefix/src/ext_qt/qtbase/src/corelib/global/qlogging.cpp:893
message = {static null = {}, d = }
ap = {{gp_offset = 40, fp_offset = 48, overflow_arg_area =
0x7fff778c9900, reg_save_area = 0x7fff778c9840}}
#4  0x7fffed2a2000 in qt_assert (assertion=assertion@entry=0x76cdc3c0
"uint(i) < uint(size())", file=file@entry=0x76cdc2e0
"/home/appimage/appimage-workspace/deps/usr/include/QtCore/qbitarray.h",
line=line@entry=121) at
/home/appimage/appimage-workspace/deps-build/ext_qt/ext_qt-prefix/src/ext_qt/qtbase/src/corelib/global/qglobal.cpp:3366
No locals.
#5  0x75518035 in QBitArray::testBit (this=,
i=) at
/home/appimage/appimage-workspace/deps/usr/include/QtCore/qbitarray.h:121
__PRETTY_FUNCTION__ = "bool QBitArray::testBit(int) const"
#6  0x7fffb46bb524 in KoCompositeOpBase(unsigned char, unsigned char)),
KoSubtractiveBlendingPolicy > >::composite (this=, params=...) at
/home/appimage/persistent/krita/libs/pigment/compositeops/KoCompositeOpBase.h:49
flags = 
allChannelFlags = 
alphaLocked = 
useMask = 
#7  0x7015eee4 in KoColorSpace::bitBlt (this=this@entry=0x6040004a6550,
srcSpace=, params=..., op=op@entry=0x602000142e90,
renderingIntent=renderingIntent@entry=KoColorConversionTransformation::IntentPerceptual,
conversionFlags=...) at
/home/appimage/persistent/krita/libs/pigment/KoColorSpace.cpp:553
conversionBufferStride = 315
conversionCache = 
conversionData = 
paramInfo = {dstRowStart = , dstRowStride = , srcRowStart = , srcRowStride = ,
maskRowStart = , maskRowStride = , rows =
, cols = , opacity = , flow =
, _lastOpacityData = , lastOpacity = , channelFlags = {d = {d = }}}
#8  0x72d2e97c in KisPainter::bitBltImpl (this=,
dstX=, dstY=, srcDev=..., srcX=,
srcY=, srcWidth=, srcHeight=) at
/home/appimage/persistent/krita/libs/image/kis_painter.cc:806
numContiguousSrcColumns = 
columns = 63
dstRowStride = 
numContiguousDstColumns = 
srcRowStride = 
srcX_ = 1217
numContiguousDstRows = 
dstX_ = 1217
columnsRemaining = 350
numContiguousSrcRows = 
rows = 63
srcRect = {x1 = , y1 = , x2 = , y2 = }
dstY_ = 897
srcY_ = 897
rowsRemaining = 166
compositeOp = 0x602000142e90
srcIt = {d = }
dstIt = {d = }
#9  0x72cf21af in KisPainter::bitBlt (this=,
dstX=, dstY=, srcDev=..., srcX=,
srcY=, srcWidth=, srcHeight=) at
/home/appimage/persistent/krita/libs/image/kis_painter.cc:828
No locals.
#10 0x72cf252b in KisPainter::bitBlt (this=this@entry=0x7fff778ca800,
pos=..., srcDev=..., srcRect=...) at
/home/appimage/persistent/krita/libs/image/kis_painter.cc:834
No locals.
#11 0x73cd8d8b in KisMultipleProjection::apply
(this=this@entry=0x606001c5d498, dstDevice=..., rect=...,
env=env@entry=0x6021e2b0) at
/home/appimage/persistent/krita/libs/image/layerstyles/kis_multiple_projection.cpp:148
gc = {_vptr.KisPainter = , d = }
readLocker = {q_va

[krita] [Bug 467829] The line tool doesn't work propperly with pressure sensitive brushes

2023-08-23 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=467829

Dmitry Kazakov  changed:

   What|Removed |Added

   Keywords||release_blocker
 CC||dimul...@gmail.com
   Assignee|krita-bugs-n...@kde.org |dimul...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 472414] Crash when undoing the move tool on a keyframe (git bc41e49)

2023-08-23 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=472414

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/krita/-/commit/f692df5 |hics/krita/-/commit/e71e835
   |615344bb367895a784d28c96fa8 |fe66d1db8bd442db842d7892e1e
   |cacb82  |19b204

--- Comment #8 from Dmitry Kazakov  ---
Git commit e71e835fe66d1db8bd442db842d7892e1e19b204 by Dmitry Kazakov.
Committed on 23/08/2023 at 14:03.
Pushed by dkazakov into branch 'krita/5.2'.

Don't recreate the frames when not necessary

This bug was an artifact of the lazy-frames refactoring. The frames should
not be recreated when they are actually the ones we transform.

M  +5-2libs/ui/tool/strokes/move_stroke_strategy.cpp

https://invent.kde.org/graphics/krita/-/commit/e71e835fe66d1db8bd442db842d7892e1e19b204

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 472414] Crash when undoing the move tool on a keyframe (git bc41e49)

2023-08-23 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=472414

Dmitry Kazakov  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/grap
   ||hics/krita/-/commit/f692df5
   ||615344bb367895a784d28c96fa8
   ||cacb82
 Status|ASSIGNED|RESOLVED

--- Comment #7 from Dmitry Kazakov  ---
Git commit f692df5615344bb367895a784d28c96fa8cacb82 by Dmitry Kazakov.
Committed on 23/08/2023 at 14:00.
Pushed by dkazakov into branch 'master'.

Don't recreate the frames when not necessary

This bug was an artifact of the lazy-frames refactoring. The frames should
not be recreated when they are actually the ones we transform.

M  +5-2libs/ui/tool/strokes/move_stroke_strategy.cpp

https://invent.kde.org/graphics/krita/-/commit/f692df5615344bb367895a784d28c96fa8cacb82

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 472414] Crash when undoing the move tool on a keyframe (git bc41e49)

2023-08-23 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=472414

Dmitry Kazakov  changed:

   What|Removed |Added

 Status|REPORTED|ASSIGNED
   Keywords||release_blocker
 Ever confirmed|0   |1

--- Comment #6 from Dmitry Kazakov  ---
Hi, Cade!

Thank you for your info! I seem to be able to reproduce the issue now...

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 473485] QAbstractItemModel::endInsertColumns: Invalid index

2023-08-23 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=473485

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/krita/-/commit/2157e5c |hics/krita/-/commit/de673fe
   |8a4d36c13f7b69be739f136639f |ee8f20079e54b51f7799d48e267
   |aeb2ca  |703035

--- Comment #6 from Dmitry Kazakov  ---
Git commit de673feee8f20079e54b51f7799d48e267703035 by Dmitry Kazakov.
Committed on 23/08/2023 at 11:26.
Pushed by dkazakov into branch 'krita/5.2'.

Fix a model warning in KisTimeBasedItemModel

There were two issues:

1) KisTimeBasedItemModel::columnCount() could return the value that
   has already changed in the image without calling to
   begin/endInsertColumns. That is not really welcome by Qt.

2) In KisTimeBasedItemModel::setImage() we reset the model (and therefore
   updated its columns list), but didn't update m_d->numFramesOverride,
   which caused double insertion of the columns in
   slotPlaybackRangeChanged() a bit later.

M  +2-1plugins/dockers/animation/KisTimeBasedItemModel.cpp

https://invent.kde.org/graphics/krita/-/commit/de673feee8f20079e54b51f7799d48e267703035

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 473485] QAbstractItemModel::endInsertColumns: Invalid index

2023-08-23 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=473485

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/grap
   ||hics/krita/-/commit/2157e5c
   ||8a4d36c13f7b69be739f136639f
   ||aeb2ca
 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED

--- Comment #5 from Dmitry Kazakov  ---
Git commit 2157e5c8a4d36c13f7b69be739f136639faeb2ca by Dmitry Kazakov.
Committed on 23/08/2023 at 11:24.
Pushed by dkazakov into branch 'master'.

Fix a model warning in KisTimeBasedItemModel

There were two issues:

1) KisTimeBasedItemModel::columnCount() could return the value that
   has already changed in the image without calling to
   begin/endInsertColumns. That is not really welcome by Qt.

2) In KisTimeBasedItemModel::setImage() we reset the model (and therefore
   updated its columns list), but didn't update m_d->numFramesOverride,
   which caused double insertion of the columns in
   slotPlaybackRangeChanged() a bit later.

M  +2-1plugins/dockers/animation/KisTimeBasedItemModel.cpp

https://invent.kde.org/graphics/krita/-/commit/2157e5c8a4d36c13f7b69be739f136639faeb2ca

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 473509] Huge space in the start area buttons on the start page

2023-08-23 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=473509

Dmitry Kazakov  changed:

   What|Removed |Added

 Resolution|--- |WAITINGFORINFO
 Status|REPORTED|NEEDSINFO

--- Comment #1 from Dmitry Kazakov  ---
Hi, Takiro!

Do you use Krita's official AppImage package or a package built by Arch Linux?
Our AppImage has a few patches to Qt that should fix those issues, and I cannot
reproduce them locally. Could you try the AppImage?

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 473484] Krita 5.2.0-beta 2 closes when trying to open animation file.

2023-08-23 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=473484

--- Comment #6 from Dmitry Kazakov  ---
The fix is pushed into both

master:
https://invent.kde.org/graphics/krita/-/commit/a8fcd53a094ddc3b2d841e0d779c05bb533dbfe9

and krita/5.2:
https://invent.kde.org/graphics/krita/-/commit/2c3c49c0c211b472673a58d7eb3ea980c514e7dc

I have triggered the stable nightly builds, so the package should be available
here in about an hour:
https://binary-factory.kde.org/job/Krita_Stable_Windows_Build/1953/

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 473484] Krita 5.2.0-beta 2 closes when trying to open animation file.

2023-08-22 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=473484

--- Comment #3 from Dmitry Kazakov  ---
Hi, electricdragon160!

Please discard my previous comment, I have managed to reproduce the issue.

The issue happens when opening an animation file with audio. Krita tries to
upgrade an animation engine from normal to MLT one, but it happens before the
canvas got properly initialized, hence, the assert.

As a temporary workaround:
1) Open Krita
2) Create an empty document
3) Add any audio to this document
4) Close the document

>From now on, Krita will be able to open any document with attached audio.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 473484] Krita 5.2.0-beta 2 closes when trying to open animation file.

2023-08-22 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=473484

--- Comment #2 from Dmitry Kazakov  ---
Hi, electricdragon160!

Could you please share the animation file that you use to reproduce this crash?
I cannot reproduce the issue with the test file I have. If your file should be
kept private, you can send it to my email directly dimula73 at gmail dot com

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 472721] transform bug

2023-08-22 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=472721

Dmitry Kazakov  changed:

   What|Removed |Added

 Resolution|--- |WAITINGFORINFO
 Status|REPORTED|NEEDSINFO
 CC||dimul...@gmail.com

--- Comment #1 from Dmitry Kazakov  ---
Hi, Loveigh15!

Could you please try the latest Krita 5.2.0 Beta2 package if the bug still
exists there? I have a feeling like I fixed a bug exactly like that for
Beta2...

https://krita.org/en/item/second-beta-for-krita-5-2-0-released/

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 472706] krita brush engine crash

2023-08-22 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=472706

Dmitry Kazakov  changed:

   What|Removed |Added

 Status|REPORTED|NEEDSINFO
 CC||dimul...@gmail.com
 Resolution|--- |WAITINGFORINFO

--- Comment #1 from Dmitry Kazakov  ---
Hi, Ubiratan!

Could you please check the latest AppImage package for Krita 5.2.Beta2. From
your description it looks as if the bug is somehow related to Flatpack
packaging.

https://krita.org/en/item/second-beta-for-krita-5-2-0-released/

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 472414] Crash when undoing the move tool on a keyframe (git bc41e49)

2023-08-22 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=472414

Dmitry Kazakov  changed:

   What|Removed |Added

   Assignee|krita-bugs-n...@kde.org |dimul...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 449163] Plasma panel visually freezes after some time under Wayland

2023-08-22 Thread Dmitry Petrov
https://bugs.kde.org/show_bug.cgi?id=449163

Dmitry Petrov  changed:

   What|Removed |Added

 CC||dimakrm...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 472900] PSD import crash on Android (works fine on desktop)

2023-08-21 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=472900

Dmitry Kazakov  changed:

   What|Removed |Added

Summary|PSD import bug  |PSD import crash on Android
   ||(works fine on desktop)
 Status|NEEDSINFO   |REPORTED
 Resolution|WAITINGFORINFO  |---

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 473558] Broken list in the Brush Preset dockers horizontal mode

2023-08-21 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=473558

Dmitry Kazakov  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/grap
   ||hics/krita/-/commit/93cf546
   ||fe8554b60d6461e37a8ee1afc41
   ||a7f216
 Status|REPORTED|RESOLVED

--- Comment #2 from Dmitry Kazakov  ---
Git commit 93cf546fe8554b60d6461e37a8ee1afc41a7f216 by Dmitry Kazakov.
Committed on 21/08/2023 at 18:13.
Pushed by dkazakov into branch 'master'.

Hide preset chooser mode button when the chooser is in horizontal mode

M  +3-2libs/resourcewidgets/KisResourceItemChooser.cpp

https://invent.kde.org/graphics/krita/-/commit/93cf546fe8554b60d6461e37a8ee1afc41a7f216

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 473558] Broken list in the Brush Preset dockers horizontal mode

2023-08-21 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=473558

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/krita/-/commit/93cf546 |hics/krita/-/commit/5aa40e0
   |fe8554b60d6461e37a8ee1afc41 |309fe81033c3dc2f337b09fcb6d
   |a7f216  |038f75

--- Comment #3 from Dmitry Kazakov  ---
Git commit 5aa40e0309fe81033c3dc2f337b09fcb6d038f75 by Dmitry Kazakov.
Committed on 21/08/2023 at 18:12.
Pushed by dkazakov into branch 'krita/5.2'.

Hide preset chooser mode button when the chooser is in horizontal mode

M  +3-2libs/resourcewidgets/KisResourceItemChooser.cpp

https://invent.kde.org/graphics/krita/-/commit/5aa40e0309fe81033c3dc2f337b09fcb6d038f75

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 463520] [5.2.0 Nightly] Brush setting panel (F5) changing center width and cutoff brush presets and scratchpad side panels

2023-08-21 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=463520

Dmitry Kazakov  changed:

   What|Removed |Added

 Resolution|--- |WAITINGFORINFO
 Status|CONFIRMED   |NEEDSINFO
 CC||dimul...@gmail.com

--- Comment #8 from Dmitry Kazakov  ---
I guess the bug should be fixed now. Protoniv, could you please check if the
bug is still present in Krita 5.2 Beta2?

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 473559] Create from Clipboard clashes w. with fill layer background

2023-08-21 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=473559

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/krita/-/commit/75ca223 |hics/krita/-/commit/274502b
   |142dd8e299eaf5021010190dc98 |f4cf1e6f822a4b6c29c1b8bf4b9
   |b9c1f5  |ef7c64

--- Comment #2 from Dmitry Kazakov  ---
Git commit 274502bf4cf1e6f822a4b6c29c1b8bf4b9ef7c64 by Dmitry Kazakov.
Committed on 21/08/2023 at 17:26.
Pushed by dkazakov into branch 'master'.

Fix creation of a new image from clipboard

When there is only one layer available and it is a fill layer we
should create a new paint layer for the paste.

M  +25   -9libs/libqml/plugins/kritasketchplugin/ImageBuilder.cpp
M  +2-1libs/ui/kis_import_catcher.h
M  +17   -3libs/ui/widgets/kis_image_from_clipboard_widget.cpp

https://invent.kde.org/graphics/krita/-/commit/274502bf4cf1e6f822a4b6c29c1b8bf4b9ef7c64

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 473559] Create from Clipboard clashes w. with fill layer background

2023-08-21 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=473559

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/grap
   ||hics/krita/-/commit/75ca223
   ||142dd8e299eaf5021010190dc98
   ||b9c1f5
 Resolution|--- |FIXED
 Status|REPORTED|RESOLVED

--- Comment #1 from Dmitry Kazakov  ---
Git commit 75ca223142dd8e299eaf5021010190dc98b9c1f5 by Dmitry Kazakov.
Committed on 21/08/2023 at 17:25.
Pushed by dkazakov into branch 'krita/5.2'.

Fix creation of a new image from clipboard

When there is only one layer available and it is a fill layer we
should create a new paint layer for the paste.

M  +25   -9libs/libqml/plugins/kritasketchplugin/ImageBuilder.cpp
M  +2-1libs/ui/kis_import_catcher.h
M  +17   -3libs/ui/widgets/kis_image_from_clipboard_widget.cpp

https://invent.kde.org/graphics/krita/-/commit/75ca223142dd8e299eaf5021010190dc98b9c1f5

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 473510] Brush preset docker: tag list shows empty squares

2023-08-21 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=473510

--- Comment #3 from Dmitry Kazakov  ---
Git commit c35dd06f895e89019f5b195af2a826bdc0f8c25d by Dmitry Kazakov.
Committed on 21/08/2023 at 16:55.
Pushed by dkazakov into branch 'krita/5.2'.

[for 5.2 only] Simplified fix for tag selector and checkboxes problem

Doing the full (and correct) refactoring might be a bit too risky
for the upcoming release.

M  +0-3libs/resources/KisTagModel.cpp

https://invent.kde.org/graphics/krita/-/commit/c35dd06f895e89019f5b195af2a826bdc0f8c25d

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 440337] Undelete option in tags popup isn't reset when needed

2023-08-21 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=440337

--- Comment #4 from Dmitry Kazakov  ---
Git commit ef90f573b4219549377ef94498b42941d6d04afc by Dmitry Kazakov.
Committed on 21/08/2023 at 16:53.
Pushed by dkazakov into branch 'master'.

Fix tag selector not to show the checkboxes next to each tag

We shouldn't use Qt::CheckStateRole, we have a special 'Active'
role for that.
Related: bug 473510

M  +5-8libs/resources/KisTagModel.cpp

https://invent.kde.org/graphics/krita/-/commit/ef90f573b4219549377ef94498b42941d6d04afc

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 473510] Brush preset docker: tag list shows empty squares

2023-08-21 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=473510

Dmitry Kazakov  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/grap
   ||hics/krita/-/commit/ef90f57
   ||3b4219549377ef94498b42941d6
   ||d04afc
 Status|CONFIRMED   |RESOLVED

--- Comment #2 from Dmitry Kazakov  ---
Git commit ef90f573b4219549377ef94498b42941d6d04afc by Dmitry Kazakov.
Committed on 21/08/2023 at 16:53.
Pushed by dkazakov into branch 'master'.

Fix tag selector not to show the checkboxes next to each tag

We shouldn't use Qt::CheckStateRole, we have a special 'Active'
role for that.
Related: bug 440337

M  +5-8libs/resources/KisTagModel.cpp

https://invent.kde.org/graphics/krita/-/commit/ef90f573b4219549377ef94498b42941d6d04afc

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 473510] Brush preset docker: tag list shows empty squares

2023-08-21 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=473510

Dmitry Kazakov  changed:

   What|Removed |Added

   Assignee|krita-bugs-n...@kde.org |dimul...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 473559] Create from Clipboard clashes w. with fill layer background

2023-08-21 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=473559

Dmitry Kazakov  changed:

   What|Removed |Added

 CC||dimul...@gmail.com
   Keywords||regression, release_blocker

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 473558] Broken list in the Brush Preset dockers horizontal mode

2023-08-21 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=473558

Dmitry Kazakov  changed:

   What|Removed |Added

 CC||dimul...@gmail.com
   Keywords||regression

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 473509] Huge space in the start area buttons on the start page

2023-08-21 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=473509

Dmitry Kazakov  changed:

   What|Removed |Added

 CC||dimul...@gmail.com
   Keywords||regression

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 473485] QAbstractItemModel::endInsertColumns: Invalid index

2023-08-21 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=473485

Dmitry Kazakov  changed:

   What|Removed |Added

 CC||dimul...@gmail.com
   Keywords||regression, release_blocker

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 473479] Krita app keeps crashing while im drawing

2023-08-21 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=473479

--- Comment #4 from Dmitry Kazakov  ---
Hi, Adele!

Could you please check if the timestamps of these lines in the log actually
correspond to the moments of crash? If they do, it could help me a little
bit...

12 Aug 2023 21:29:00 -0700: SAFE ASSERT (krita): "onlyColor.size() ==
paramInfo.channelFlags.size()" in file
C:/Packaging/workspace/Krita_Release_Windows64_Build/krita/libs/image/kis_painter.cc,
line 489

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 473510] Brush preset docker: tag list shows empty squares

2023-08-21 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=473510

Dmitry Kazakov  changed:

   What|Removed |Added

 CC||dimul...@gmail.com
   Keywords||release_blocker

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 472900] PSD import bug

2023-08-21 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=472900

Dmitry Kazakov  changed:

   What|Removed |Added

 Status|REPORTED|NEEDSINFO
 Resolution|--- |WAITINGFORINFO

--- Comment #5 from Dmitry Kazakov  ---
Mark as needsinfo again

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 472900] PSD import bug

2023-08-21 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=472900

Dmitry Kazakov  changed:

   What|Removed |Added

 CC||dimul...@gmail.com

--- Comment #4 from Dmitry Kazakov  ---
Hi, pinkdama!

Could you please tell what is the problem with the file you linked? It seems to
load fine here. It seems to have correct colors and only one layer included.

We need an example of the file that Krita fails to load and a screenshot from
PS how this file should look like. Then we could look into that. You can remove
all the artistic bits from the file and keep color blobs only to make sure your
sensitive information doesn't leak.

Please also take it into account that Krita doesn't support vector and text
extensions of PSD file. They are imported as rasterized layers. We have no
plans to implement these two features.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 473515] Crash when activating Multibrush tool

2023-08-21 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=473515

Dmitry Kazakov  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/grap
   ||hics/krita/-/commit/6c5ea78
   ||b398b1387405103f9fc5ab191d1
   ||8e19c0

--- Comment #3 from Dmitry Kazakov  ---
Git commit 6c5ea78b398b1387405103f9fc5ab191d18e19c0 by Dmitry Kazakov, on
behalf of Freya Lupen.
Committed on 21/08/2023 at 09:09.
Pushed by dkazakov into branch 'master'.

Initialize tool configGroup before optionWidget

Otherwise KisToolMultihand::createOptionWidget will crash.

M  +1-2plugins/tools/basictools/kis_tool_brush.cc

https://invent.kde.org/graphics/krita/-/commit/6c5ea78b398b1387405103f9fc5ab191d18e19c0

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 473459] Line Tool produces wobbly lines

2023-08-18 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=473459

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/krita/-/commit/f4934e2 |hics/krita/-/commit/1af06cb
   |177863e519130a34381439ec38b |d8e48602b80c8da564a8db9d213
   |085962  |000ac3

--- Comment #2 from Dmitry Kazakov  ---
Git commit 1af06cbd8e48602b80c8da564a8db9d213000ac3 by Dmitry Kazakov.
Committed on 18/08/2023 at 13:54.
Pushed by dkazakov into branch 'master'.

Fix wobbly lines when using line tool

DDA adjustment should happen only when we use tiny brushes

M  +0-1plugins/tools/basictools/kis_tool_line_helper.cpp

https://invent.kde.org/graphics/krita/-/commit/1af06cbd8e48602b80c8da564a8db9d213000ac3

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 473459] Line Tool produces wobbly lines

2023-08-18 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=473459

Dmitry Kazakov  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/grap
   ||hics/krita/-/commit/f4934e2
   ||177863e519130a34381439ec38b
   ||085962

--- Comment #1 from Dmitry Kazakov  ---
Git commit f4934e2177863e519130a34381439ec38b085962 by Dmitry Kazakov.
Committed on 18/08/2023 at 13:54.
Pushed by dkazakov into branch 'krita/5.2'.

Fix wobbly lines when using line tool

DDA adjustment should happen only when we use tiny brushes

M  +0-1plugins/tools/basictools/kis_tool_line_helper.cpp

https://invent.kde.org/graphics/krita/-/commit/f4934e2177863e519130a34381439ec38b085962

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 473130] Crash when undoing image color space conversion

2023-08-18 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=473130

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/krita/-/commit/d75c3ef |hics/krita/-/commit/665bf7a
   |f6f861ebffe4667e0d44e525e1a |c7afc47e5e403f2b779ac3f68c2
   |98315d  |01df9b

--- Comment #3 from Dmitry Kazakov  ---
Git commit 665bf7ac7afc47e5e403f2b779ac3f68c201df9b by Dmitry Kazakov.
Committed on 18/08/2023 at 13:01.
Pushed by dkazakov into branch 'krita/5.2'.

Fix Channels docker to generate thumbnails asynchronously

Now the docker basically reuses the strategy used in Overview docker,
so there should be no threading issues/crashes anymore.


(cherry picked from commit d75c3eff6f861ebffe4667e0d44e525e1a98315d)

M  +1-0libs/ui/CMakeLists.txt
R  +30   -26   libs/ui/KisImageThumbnailStrokeStrategy.cpp [from:
plugins/dockers/overview/OverviewThumbnailStrokeStrategy.cpp - 056% similarity]
A  +72   -0libs/ui/KisImageThumbnailStrokeStrategy.h [License:
GPL(v2.0+)]
M  +6-1plugins/dockers/channeldocker/CMakeLists.txt
A  +56   -0   
plugins/dockers/channeldocker/KisChannelsThumbnailsStrokeStrategy.cpp
[License: GPL(v2.0+)]
A  +24   -0   
plugins/dockers/channeldocker/KisChannelsThumbnailsStrokeStrategy.h  *
M  +45   -40   plugins/dockers/channeldocker/channeldocker_dock.cpp
M  +7-8plugins/dockers/channeldocker/channeldocker_dock.h
M  +51   -88   plugins/dockers/channeldocker/channelmodel.cpp
M  +7-6plugins/dockers/channeldocker/channelmodel.h
M  +1-2plugins/dockers/overview/CMakeLists.txt
D  +0-58   plugins/dockers/overview/OverviewThumbnailStrokeStrategy.h
M  +3-3plugins/dockers/overview/overviewwidget.cc

The files marked with a * at the end have a non valid license. Please read:
https://community.kde.org/Policies/Licensing_Policy and use the headers which
are listed at that page.


https://invent.kde.org/graphics/krita/-/commit/665bf7ac7afc47e5e403f2b779ac3f68c201df9b

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 473130] Crash when undoing image color space conversion

2023-08-18 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=473130

Dmitry Kazakov  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
  Latest Commit||https://invent.kde.org/grap
   ||hics/krita/-/commit/d75c3ef
   ||f6f861ebffe4667e0d44e525e1a
   ||98315d
 Resolution|--- |FIXED

--- Comment #2 from Dmitry Kazakov  ---
Git commit d75c3eff6f861ebffe4667e0d44e525e1a98315d by Dmitry Kazakov.
Committed on 18/08/2023 at 11:32.
Pushed by dkazakov into branch 'master'.

Fix Channels docker to generate thumbnails asynchronously

Now the docker basically reuses the strategy used in Overview docker,
so there should be no threading issues/crashes anymore.

M  +1-0libs/ui/CMakeLists.txt
R  +30   -26   libs/ui/KisImageThumbnailStrokeStrategy.cpp [from:
plugins/dockers/overview/OverviewThumbnailStrokeStrategy.cpp - 056% similarity]
A  +72   -0libs/ui/KisImageThumbnailStrokeStrategy.h [License:
GPL(v2.0+)]
M  +6-1plugins/dockers/channeldocker/CMakeLists.txt
A  +56   -0   
plugins/dockers/channeldocker/KisChannelsThumbnailsStrokeStrategy.cpp
[License: GPL(v2.0+)]
A  +24   -0   
plugins/dockers/channeldocker/KisChannelsThumbnailsStrokeStrategy.h  *
M  +45   -40   plugins/dockers/channeldocker/channeldocker_dock.cpp
M  +7-8plugins/dockers/channeldocker/channeldocker_dock.h
M  +51   -88   plugins/dockers/channeldocker/channelmodel.cpp
M  +7-6plugins/dockers/channeldocker/channelmodel.h
M  +1-2plugins/dockers/overview/CMakeLists.txt
D  +0-58   plugins/dockers/overview/OverviewThumbnailStrokeStrategy.h
M  +3-3plugins/dockers/overview/overviewwidget.cc

The files marked with a * at the end have a non valid license. Please read:
https://community.kde.org/Policies/Licensing_Policy and use the headers which
are listed at that page.


https://invent.kde.org/graphics/krita/-/commit/d75c3eff6f861ebffe4667e0d44e525e1a98315d

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 473479] Krita app keeps crashing while im drawing

2023-08-18 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=473479

Dmitry Kazakov  changed:

   What|Removed |Added

 CC||dimul...@gmail.com

--- Comment #1 from Dmitry Kazakov  ---
Hi, Adele!

Could you please attach the crashlog of Krita? It should be stored in this
location:

%LOCALAPPDATA%\kritacrash.log

Please also tell what tool you used when the crash happened? Did you use any
channel locks? And did you convert image color space right before the crash? 

Your log has some suspicious lines, but they seem to have happened much earlier
than you reported this bug, so I'm not sure they are related.

You can also try to install debugging symbols, so the next time Krita crashes
we had a better crash log:
https://docs.krita.org/en/reference_manual/dr_minw_debugger.html#dr-minw

(though right now just providing your current (limited) log would also be
helpful)

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 473484] Krita 5.2.0-beta 2 closes when trying to open animation file.

2023-08-18 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=473484

Dmitry Kazakov  changed:

   What|Removed |Added

   Keywords||regression, release_blocker
 CC||dimul...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 473459] Line Tool produces wobbly lines

2023-08-18 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=473459

Dmitry Kazakov  changed:

   What|Removed |Added

   Keywords||release_blocker
 CC||dimul...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 473130] Crash when undoing image color space conversion

2023-08-17 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=473130

Dmitry Kazakov  changed:

   What|Removed |Added

 Ever confirmed|0   |1
   Keywords||release_blocker
 CC||dimul...@gmail.com
   Assignee|krita-bugs-n...@kde.org |dimul...@gmail.com
 Status|REPORTED|ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 473242] Filter brush engine crashes after switching filters

2023-08-16 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=473242

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/krita/-/commit/7a50879 |hics/krita/-/commit/5e5dc66
   |a8cce2a41ac847e15ba36a4a2e7 |3f6be0621135f3ecb948d5e6075
   |c80d0c  |815f7d

--- Comment #4 from Dmitry Kazakov  ---
Git commit 5e5dc663f6be0621135f3ecb948d5e6075815f7d by Dmitry Kazakov.
Committed on 16/08/2023 at 18:25.
Pushed by dkazakov into branch 'krita/5.2'.

Fix a crash when activating Color Index filter in the filter brush

M  +14   -2plugins/filters/indexcolors/indexcolorpalette.cpp
M  +5-0plugins/filters/indexcolors/indexcolors.cpp

https://invent.kde.org/graphics/krita/-/commit/5e5dc663f6be0621135f3ecb948d5e6075815f7d

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 473242] Filter brush engine crashes after switching filters

2023-08-16 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=473242

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/krita/-/commit/74a8cf5 |hics/krita/-/commit/7a50879
   |472249d05a8a4dd9350e3e2331d |a8cce2a41ac847e15ba36a4a2e7
   |b3c58c  |c80d0c

--- Comment #3 from Dmitry Kazakov  ---
Git commit 7a50879a8cce2a41ac847e15ba36a4a2e7c80d0c by Dmitry Kazakov.
Committed on 16/08/2023 at 18:25.
Pushed by dkazakov into branch 'krita/5.2'.

Fix crash when activating Halftone filter in Filter Brush

We shouldn't recreate the generator widget when the generator is
unchanged, it may cause a destruction of the compressor tight in
the timer handler, which causes a crash.

M  +18   -13   plugins/filters/halftone/KisHalftoneConfigPageWidget.cpp
M  +1-0plugins/filters/halftone/KisHalftoneConfigPageWidget.h

https://invent.kde.org/graphics/krita/-/commit/7a50879a8cce2a41ac847e15ba36a4a2e7c80d0c

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 473242] Filter brush engine crashes after switching filters

2023-08-16 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=473242

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/grap
   ||hics/krita/-/commit/e5d4773
   ||c2995be6028b037933989389744
   ||3d330f
 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED

--- Comment #1 from Dmitry Kazakov  ---
Git commit e5d4773c2995be6028b0379339893897443d330f by Dmitry Kazakov.
Committed on 16/08/2023 at 17:58.
Pushed by dkazakov into branch 'master'.

Fix crash when activating Halftone filter in Filter Brush

We shouldn't recreate the generator widget when the generator is
unchanged, it may cause a destruction of the compressor tight in
the timer handler, which causes a crash.

M  +18   -13   plugins/filters/halftone/KisHalftoneConfigPageWidget.cpp
M  +1-0plugins/filters/halftone/KisHalftoneConfigPageWidget.h

https://invent.kde.org/graphics/krita/-/commit/e5d4773c2995be6028b0379339893897443d330f

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 473242] Filter brush engine crashes after switching filters

2023-08-16 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=473242

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/krita/-/commit/e5d4773 |hics/krita/-/commit/74a8cf5
   |c2995be6028b037933989389744 |472249d05a8a4dd9350e3e2331d
   |3d330f  |b3c58c

--- Comment #2 from Dmitry Kazakov  ---
Git commit 74a8cf5472249d05a8a4dd9350e3e2331db3c58c by Dmitry Kazakov.
Committed on 16/08/2023 at 17:58.
Pushed by dkazakov into branch 'master'.

Fix a crash when activating Color Index filter in the filter brush

M  +14   -2plugins/filters/indexcolors/indexcolorpalette.cpp
M  +5-0plugins/filters/indexcolors/indexcolors.cpp

https://invent.kde.org/graphics/krita/-/commit/74a8cf5472249d05a8a4dd9350e3e2331db3c58c

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 455431] Spare layout not working on Wayland

2023-08-14 Thread Dmitry Misharov
https://bugs.kde.org/show_bug.cgi?id=455431

Dmitry Misharov  changed:

   What|Removed |Added

 CC||quarcks...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 472779] 5.2 beta1 - Soften edge slider on Sharpness feature doesn't work

2023-08-14 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=472779

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/krita/-/commit/5fdf853 |hics/krita/-/commit/5209cf9
   |a1a1fe21b04c6bf02584762040b |464fd7bb5c9fe1e9c02365e659b
   |d66628  |755409

--- Comment #3 from Dmitry Kazakov  ---
Git commit 5209cf9464fd7bb5c9fe1e9c02365e659b755409 by Dmitry Kazakov.
Committed on 14/08/2023 at 18:12.
Pushed by dkazakov into branch 'krita/5.2'.

Fix sharpness option being uninitialized
Related: bug 472723

M  +1-1plugins/paintops/libpaintop/KisSharpnessOption.cpp

https://invent.kde.org/graphics/krita/-/commit/5209cf9464fd7bb5c9fe1e9c02365e659b755409

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 472723] "Align the brush to preview outline to the pixel grid" don't work anymore

2023-08-14 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=472723

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/krita/-/commit/5fdf853 |hics/krita/-/commit/5209cf9
   |a1a1fe21b04c6bf02584762040b |464fd7bb5c9fe1e9c02365e659b
   |d66628  |755409

--- Comment #3 from Dmitry Kazakov  ---
Git commit 5209cf9464fd7bb5c9fe1e9c02365e659b755409 by Dmitry Kazakov.
Committed on 14/08/2023 at 18:12.
Pushed by dkazakov into branch 'krita/5.2'.

Fix sharpness option being uninitialized
Related: bug 472779

M  +1-1plugins/paintops/libpaintop/KisSharpnessOption.cpp

https://invent.kde.org/graphics/krita/-/commit/5209cf9464fd7bb5c9fe1e9c02365e659b755409

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 472723] "Align the brush to preview outline to the pixel grid" don't work anymore

2023-08-14 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=472723

Dmitry Kazakov  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/grap
   ||hics/krita/-/commit/5fdf853
   ||a1a1fe21b04c6bf02584762040b
   ||d66628

--- Comment #2 from Dmitry Kazakov  ---
Git commit 5fdf853a1a1fe21b04c6bf02584762040bd66628 by Dmitry Kazakov.
Committed on 14/08/2023 at 18:11.
Pushed by dkazakov into branch 'master'.

Fix sharpness option being uninitialized
Related: bug 472779

M  +1-1plugins/paintops/libpaintop/KisSharpnessOption.cpp

https://invent.kde.org/graphics/krita/-/commit/5fdf853a1a1fe21b04c6bf02584762040bd66628

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 472779] 5.2 beta1 - Soften edge slider on Sharpness feature doesn't work

2023-08-14 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=472779

Dmitry Kazakov  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/grap
   ||hics/krita/-/commit/5fdf853
   ||a1a1fe21b04c6bf02584762040b
   ||d66628
 Status|CONFIRMED   |RESOLVED

--- Comment #2 from Dmitry Kazakov  ---
Git commit 5fdf853a1a1fe21b04c6bf02584762040bd66628 by Dmitry Kazakov.
Committed on 14/08/2023 at 18:11.
Pushed by dkazakov into branch 'master'.

Fix sharpness option being uninitialized
Related: bug 472723

M  +1-1plugins/paintops/libpaintop/KisSharpnessOption.cpp

https://invent.kde.org/graphics/krita/-/commit/5fdf853a1a1fe21b04c6bf02584762040bd66628

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 472763] Animation play CRASH!! (beta1 and nightly 5.3.0-prealpha-179e89dec5)

2023-08-09 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=472763

Dmitry Kazakov  changed:

   What|Removed |Added

   Keywords||release_blocker
 CC||dimul...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 471871] Image gets white outline on certain transparent parts in some image viewing programs and other software

2023-08-09 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=471871

--- Comment #8 from Dmitry Kazakov  ---
> From the sounds of it this will need to be done for every layer and will 
> require collapsing f.ex. the stroke FX effect. I can't really see many 
> artists wanting to go through this many steps when exporting assets for games 
> and places like Discord.

That is just a workaround that can be used in the released versions of Krita
until we invent some better fix. And that shouldn't be performed for every
layer, instead, you should flatten the image before doing this.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 473161] UI Font in Krita 5.3 is not correct

2023-08-09 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=473161

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/krita/-/commit/021c164 |hics/krita/-/commit/0cef5cb
   |1a8d5e15454f92fdbccf3f8ebdb |1fd9542e4dad48a8ec5374ea84f
   |718450  |6eb34c

--- Comment #4 from Dmitry Kazakov  ---
Git commit 0cef5cb1fd9542e4dad48a8ec5374ea84f6eb34c by Dmitry Kazakov.
Committed on 09/08/2023 at 11:33.
Pushed by dkazakov into branch 'krita/5.2'.

Fix initialization of the fontconfig embedded into AppImage

Since we embed our own fontconfig into the appimage we should make sure
that it fetches the corrent fonts.conf file from the system location.

M  +40   -19   krita/main.cc

https://invent.kde.org/graphics/krita/-/commit/0cef5cb1fd9542e4dad48a8ec5374ea84f6eb34c

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 473161] UI Font in Krita 5.3 is not correct

2023-08-09 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=473161

Dmitry Kazakov  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/grap
   ||hics/krita/-/commit/021c164
   ||1a8d5e15454f92fdbccf3f8ebdb
   ||718450
 Status|REPORTED|RESOLVED

--- Comment #3 from Dmitry Kazakov  ---
Git commit 021c1641a8d5e15454f92fdbccf3f8ebdb718450 by Dmitry Kazakov.
Committed on 09/08/2023 at 11:33.
Pushed by dkazakov into branch 'master'.

Fix initialization of the fontconfig embedded into AppImage

Since we embed our own fontconfig into the appimage we should make sure
that it fetches the corrent fonts.conf file from the system location.

M  +40   -19   krita/main.cc

https://invent.kde.org/graphics/krita/-/commit/021c1641a8d5e15454f92fdbccf3f8ebdb718450

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 469604] [5.2] Masked brush tip size setting is broken

2023-08-09 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=469604

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/krita/-/commit/98405f8 |hics/krita/-/commit/41956a6
   |05169113e792025c8b970ef4c02 |27b4ac8a0ec7f6f6d63b6ae3179
   |b28881  |924eb9

--- Comment #8 from Dmitry Kazakov  ---
Git commit 41956a627b4ac8a0ec7f6f6d63b6ae3179924eb9 by Dmitry Kazakov.
Committed on 09/08/2023 at 10:00.
Pushed by dkazakov into branch 'krita/5.2'.

Fix masking brush size issues (again)

The problem happens because of the proportional size link of the
masking brush. It got broken after introduction of
m_commonBrushSizeData field for auto/predefined brushes.

M  +17   -16   plugins/paintops/libpaintop/KisMaskingBrushOption.cpp

https://invent.kde.org/graphics/krita/-/commit/41956a627b4ac8a0ec7f6f6d63b6ae3179924eb9

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 469604] [5.2] Masked brush tip size setting is broken

2023-08-09 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=469604

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/krita/-/commit/887a540 |hics/krita/-/commit/98405f8
   |d0b571c4b0cf9d0618e6469375f |05169113e792025c8b970ef4c02
   |3b5e15  |b28881
 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED

--- Comment #7 from Dmitry Kazakov  ---
Git commit 98405f805169113e792025c8b970ef4c02b28881 by Dmitry Kazakov.
Committed on 09/08/2023 at 09:52.
Pushed by dkazakov into branch 'master'.

Fix masking brush size issues (again)

The problem happens because of the proportional size link of the
masking brush. It got broken after introduction of
m_commonBrushSizeData field for auto/predefined brushes.

M  +17   -16   plugins/paintops/libpaintop/KisMaskingBrushOption.cpp

https://invent.kde.org/graphics/krita/-/commit/98405f805169113e792025c8b970ef4c02b28881

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 472167] Animation player drops frames unconditionally and ignores the user settings

2023-08-08 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=472167

Dmitry Kazakov  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED

--- Comment #10 from Dmitry Kazakov  ---
The patch is now fixed by this MR:
https://invent.kde.org/graphics/krita/-/merge_requests/1886

The should already be available in Krita Nigthly.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 469226] Transformation on large canvas animation frames causes crash

2023-08-08 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=469226

Dmitry Kazakov  changed:

   What|Removed |Added

 CC||denispolozo...@gmail.com

--- Comment #17 from Dmitry Kazakov  ---
*** Bug 472637 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 472637] Getting crashes without any messages when trying to move objects on canvas

2023-08-08 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=472637

Dmitry Kazakov  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #1 from Dmitry Kazakov  ---
Hi, Denis!

Could you please check the latest Krita 5.2 Beta1, I think I have fixed this
bug in it :)

https://krita.org/en/item/first-beta-for-krita-5-2-0-released/

*** This bug has been marked as a duplicate of bug 469226 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

<    2   3   4   5   6   7   8   9   10   11   >