[plasmashell] [Bug 395390] After making the default panel vertically-oriented, Kickoff's layout is messed up until plasmashell is restarted

2019-02-21 Thread Dmitry Khlestkov
https://bugs.kde.org/show_bug.cgi?id=395390

--- Comment #17 from Dmitry Khlestkov  ---
Piotr,

how it is supposed to look like? I checked your original Bug 396583 and both
screenshots looks different from this one.

Anyway, I don't think I can help. You have to "play" with qml to find what is
working for you.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 395390] After making the default panel vertically-oriented, Kickoff's layout is messed up until plasmashell is restarted

2019-02-19 Thread Dmitry Khlestkov
https://bugs.kde.org/show_bug.cgi?id=395390

--- Comment #14 from Dmitry Khlestkov  ---
> implicit height

sorry, it is "explicit"

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 395390] After making the default panel vertically-oriented, Kickoff's layout is messed up until plasmashell is restarted

2019-02-19 Thread Dmitry Khlestkov
https://bugs.kde.org/show_bug.cgi?id=395390

--- Comment #13 from Dmitry Khlestkov  ---
I'm using locally modified version of kickoff with this modifications for
"left" orientation (ui/FullRepresentation.qml):

  AnchorChanges {
target: tabBar
anchors {
  left: root.left
- top: root.top
  right: undefined
  bottom: header.top
}
  }

+ PropertyChanges {
+   target: tabBar
+   height: units.gridUnit * 29
+  }

E.g. anchors.top replaced with implicit height. Similar workaround may be
applied to "right" orientation. Obviously height should be calculated from tab
count instead of being hardcoded.

Yes, this is not a proper fix but we can't be picky at this moment, can we?
I've reported this issue 10 months ago and no one seems to have skills and/or
resolve to fix it properly.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 393697] [vertical tabs] first tab not fully visible on popup show

2018-04-30 Thread Dmitry Khlestkov
https://bugs.kde.org/show_bug.cgi?id=393697

--- Comment #1 from Dmitry Khlestkov <dsx@yandex.ru> ---
Created attachment 112330
  --> https://bugs.kde.org/attachment.cgi?id=112330=edit
"before" the commit

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 393697] New: [vertical tabs] first tab not fully visible on popup show

2018-04-30 Thread Dmitry Khlestkov
https://bugs.kde.org/show_bug.cgi?id=393697

Bug ID: 393697
   Summary: [vertical tabs] first tab not fully visible on popup
show
   Product: plasmashell
   Version: 5.12.4
  Platform: Other
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: Application Launcher (Kickoff)
  Assignee: k...@davidedmundson.co.uk
  Reporter: dsx@yandex.ru
CC: plasma-b...@kde.org
  Target Milestone: 1.0

Created attachment 112329
  --> https://bugs.kde.org/attachment.cgi?id=112329=edit
"after" the commit

This started a couple weeks ago. I've tracked the issue down to specific
commit: https://phabricator.kde.org/D11098

before the commit vertical tabs are working as expected, but after the commit
first tab is not fully visible when kickoff is opened for the first time.
Clicking on any other tab (or hovering mouse if "Switch tabs on hover" is
enabled) forces the tab to slide down back into place (the kickoff popup can be
closed/reopened but the issue persists until any other tab is activated).

P.S.
Horizontal tabs are working as expected both before and after the commit.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-solid] [Bug 389479] Plasma not mount disk

2018-02-19 Thread Dmitry Khlestkov
https://bugs.kde.org/show_bug.cgi?id=389479

--- Comment #32 from Dmitry Khlestkov <dsx@yandex.ru> ---
(In reply to Nate Graham from comment #31)
> Thanks for the patch! Patches in bug reports tend to get missed, so please
> submit this using Phabricator. For documentation regarding how to do this,
> see https://community.kde.org/Infrastructure/Phabricator

I've tried my best but I have no idea who should be reviewer
https://phabricator.kde.org/D10671

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-solid] [Bug 389479] Plasma not mount disk

2018-02-19 Thread Dmitry Khlestkov
https://bugs.kde.org/show_bug.cgi?id=389479

--- Comment #30 from Dmitry Khlestkov <dsx@yandex.ru> ---
Created attachment 110820
  --> https://bugs.kde.org/attachment.cgi?id=110820=edit
don't ignore storage with empty path

Actually, I've added debug output to StorageAccess::isIgnored
(udisks2/udisksstorageaccess.cpp):
StorageAccess::isIgnored udi:'/org/freedesktop/UDisks2/block_devices/sdd1'
path:'' (empty,ignored)
StorageAccess::isIgnored udi:'/org/freedesktop/UDisks2/block_devices/sdb2'
path:'' (empty,ignored)
StorageAccess::isIgnored udi:'/org/freedesktop/UDisks2/block_devices/sdc1'
path:'' (empty,ignored)
StorageAccess::isIgnored udi:'/org/freedesktop/UDisks2/block_devices/sda7'
path:'' (empty,ignored)
StorageAccess::isIgnored udi:'/org/freedesktop/UDisks2/block_devices/sda6'
path:'/home' (non-empty,ignored)
StorageAccess::isIgnored udi:'/org/freedesktop/UDisks2/block_devices/sda5'
path:'/' (non-empty,ignored)
StorageAccess::isIgnored udi:'/org/freedesktop/UDisks2/block_devices/sda3'
path:'/boot' (non-empty,ignored)

All devices that was auto-mountable before 5.43 has empty path. I've added
isEmpty check and it works like a charm now. Please check the patch

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-solid] [Bug 389479] Plasma not mount disk

2018-02-19 Thread Dmitry Khlestkov
https://bugs.kde.org/show_bug.cgi?id=389479

--- Comment #28 from Dmitry Khlestkov <dsx@yandex.ru> ---
(In reply to Kai Uwe Broulik from comment #26)
> Can you please check the output of solid-hardware5 details 
> /path/to/the/offending/device (it could show up
> multiple times, e.g. as block device and as usb stick).

see the attachment

> Can you try whether reverting ed1e7f5fc5c083c17bd44e4220a35eae140f980b and
> 1384f275ab2f1ad1841753ee163af6d1b0bb952b in Solid helps?

Yes, this helps.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-solid] [Bug 389479] Plasma not mount disk

2018-02-19 Thread Dmitry Khlestkov
https://bugs.kde.org/show_bug.cgi?id=389479

--- Comment #27 from Dmitry Khlestkov <dsx@yandex.ru> ---
Created attachment 110815
  --> https://bugs.kde.org/attachment.cgi?id=110815=edit
output of solid-hardware5 #27

-- 
You are receiving this mail because:
You are watching all bug changes.