[konsole] [Bug 449236] Scrollbar do not takes the colors from the profile color scheme anymore when using an Application Theme different from Breeze i.e.(Oxygen, Fusion).
https://bugs.kde.org/show_bug.cgi?id=449236 --- Comment #38 from Giovanni Santoni --- (In reply to tcanabrava from comment #37) > Created attachment 146482 [details] > attachment-13430-0.html > > Sorry, real life got me. > It’s always better to send patches trough the gitlab instance at > invent.kde.org > No. I am sorry to disturb you with such trivial requests Btw i will try to create a merge request when my real life allows me. Thank you !! -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 449236] Scrollbar do not takes the colors from the profile color scheme anymore when using an Application Theme different from Breeze i.e.(Oxygen, Fusion).
https://bugs.kde.org/show_bug.cgi?id=449236 Giovanni Santoni changed: What|Removed |Added CC||tcanabr...@kde.org --- Comment #36 from Giovanni Santoni --- (In reply to tcanabrava from comment #26) > Created attachment 146160 [details] > attachment-20044-0.html > > People, anyone here is willing to try to add that option? > I'd gladly accept patches for that. @tcanabr...@kde.org. Hi any news about the patch? or should i register on kde gitlab and create a merge request? -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 449236] Scrollbar do not takes the colors from the profile color scheme anymore when using an Application Theme different from Breeze i.e.(Oxygen, Fusion).
https://bugs.kde.org/show_bug.cgi?id=449236 --- Comment #31 from Giovanni Santoni --- Created attachment 146188 --> https://bugs.kde.org/attachment.cgi?id=146188=edit setting -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 449236] Scrollbar do not takes the colors from the profile color scheme anymore when using an Application Theme different from Breeze i.e.(Oxygen, Fusion).
https://bugs.kde.org/show_bug.cgi?id=449236 --- Comment #30 from Giovanni Santoni --- (In reply to tcanabrava from comment #26) > Created attachment 146160 [details] > attachment-20044-0.html > > People, anyone here is willing to try to add that option? > I'd gladly accept patches for that. I created a patch for Tag 21.12.1. I tested it and seem to work. I added the option inProfile->Appareance->Miscellaneous -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 449236] Scrollbar do not takes the colors from the profile color scheme anymore when using an Application Theme different from Breeze i.e.(Oxygen, Fusion).
https://bugs.kde.org/show_bug.cgi?id=449236 --- Comment #29 from Giovanni Santoni --- Created attachment 146187 --> https://bugs.kde.org/attachment.cgi?id=146187=edit scrollbar match terminal patch for 21.12.1 -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 449236] Scrollbar do not takes the colors from the profile color scheme anymore when using an Application Theme different from Breeze i.e.(Oxygen, Fusion).
https://bugs.kde.org/show_bug.cgi?id=449236 --- Comment #22 from Giovanni Santoni --- (In reply to Ahmad Samir from comment #18) And sorry if I insist but the person that reported bug 393423 and also some people in the comments where simply asking to add an option to disable it. -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 449236] Scrollbar do not takes the colors from the profile color scheme anymore when using an Application Theme different from Breeze i.e.(Oxygen, Fusion).
https://bugs.kde.org/show_bug.cgi?id=449236 --- Comment #21 from Giovanni Santoni --- (In reply to Ahmad Samir from comment #18) And in the kde gears release notes https://kde.org/announcements/gear/21.12.0/ there is this statement in the Konsole section: "It is important to use applications that are visually appealing, but, as beauty is in the eyes of the beholder, Konsole, in classic KDE fashions gives you plenty of chances of customizing its look to your taste." So please give the users the choice. -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 449236] Scrollbar do not takes the colors from the profile color scheme anymore when using an Application Theme different from Breeze i.e.(Oxygen, Fusion).
https://bugs.kde.org/show_bug.cgi?id=449236
--- Comment #19 from Giovanni Santoni ---
(In reply to Ahmad Samir from comment #18)
> From my point of view, the scrollbar belongs to the window widget style, the
> terminal colour scheme shouldn't affect it, since the scrollbar is
> technically not part of the terminal display in the first place. The
> behaviour to make the scrollbar match the terminal background colour wasn't
> a good one, in my opinion. We also got bug reports about that matching going
> wrong and the scrollbar becoming invisible, see the screenshots from bug
> 393423.
Ok but now if you use Breeze you get the color matching the terminal
background, if not you get the color from the window ...
this is more inconsistent to me.
> Providing a setting for every bit where it works sometimes and breaks some
> other times would create bigger and bigger config dialogs, and complicate
> the code, needlessly.
in the code now you have this:
if (appStyle->objectName() == QLatin1String("breeze")) {
setPalette(_backgroundMatchingPalette);
} else {
setPalette(QGuiApplication::palette());
}
So the code to make this work it's still there there is no complication..
Is it not better than giving the user the choice?
In KDE there you can customize the color of window decoration for each window.
Some applications like kate and Konsole permit to use of a custom color for the
entire window and in Konsole you can customize the color of each tab...
So there are plenty of customization options and I don't think that adding
a checkbox in the scrollbar settings will make the configuration so big and
complicated.
I don't understand why not give the user the choice for a feature that was
already there for years
--
You are receiving this mail because:
You are watching all bug changes.
[konsole] [Bug 449236] Scrollbar do not takes the colors from the profile color scheme anymore when using an Application Theme different from Breeze i.e.(Oxygen, Fusion).
https://bugs.kde.org/show_bug.cgi?id=449236 --- Comment #13 from Giovanni Santoni --- (In reply to Ahmad Samir from comment #11) > That "feature" was removed because it only worked with Breeze, with Oxygen, > Fusion ...etc, sometimes one ended up with a black scrollbar on a black > background, where you couldn't easily distinguish the position of the > scrollbar in the gutter. > > A feature that causes a bug, for people with vision impairment, was reverted > (and should have been reverted 1-2 years ago). > > You could select a colour scheme for the widget style that matches the > terminal colour scheme? I understand the point of people with vision impairment and i respect it.. but you should also understand point of view of people who liked that "feature" and used it for years... I respect your work but was not better to simply make it optional and make it disabled by default to help people with vision impairment. And no. I don't want to change the window color scheme to match that of the terminal. It is also impossible because i use another nice looking "feature" of the Konsole terminal emulator: i use a terminal color theme with a random background color and i cannot guess wich color the terminal will be. What i should do? Change the window color theme manually each time i open a new window or tab? Best regards. -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 449236] Scrollbar do not takes the colors from the profile color scheme anymore when using an Application Theme different from Breeze i.e.(Oxygen, Fusion).
https://bugs.kde.org/show_bug.cgi?id=449236 --- Comment #10 from Giovanni Santoni --- (In reply to Ahmad Samir from comment #9) > Changing the colour scheme of all the widgets in the app doesn't work? > Settings -> Window colour scheme. Yes but changing the window color scheme is another thing Before 21.12.1 the scrollbar blended with the terminal color scheme indipendent of the window color scheme ... and i think that feature was introduced 1-2 years ago.. is not very nice to remove a feature that was around for a very long time without giving users an option to re enable it... now it works only using breeze... but i dont use it. (In reply to Ahmad Samir from comment #9) > Changing the colour scheme of all the widgets in the app doesn't work? > Settings -> Window colour scheme. -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 449236] Scrollbar do not takes the colors from the profile color scheme anymore when using an Application Theme different from Breeze i.e.(Oxygen, Fusion).
https://bugs.kde.org/show_bug.cgi?id=449236 --- Comment #7 from Giovanni Santoni --- Sorry for my previous rude comment but i liked that feature very much If it was causing problems to many people it was not better to make an option and leave it disabled by default... Adding an hardcoded check in the code only for a style is not very nice Thank you anyway... -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 449236] Scrollbar do not takes the colors from the profile color scheme anymore when using an Application Theme different from Breeze i.e.(Oxygen, Fusion).
https://bugs.kde.org/show_bug.cgi?id=449236 --- Comment #6 from Giovanni Santoni --- Ok... but it's very bad to remove features to fix bugs... I'm not a user of the breeze theme and now with dark color schemes it looks ugly.. Adding an option to toggle it was much better than removing a feature or adding a ugly hack in the code to make it work only with the breeze theme. -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 449236] Scrollbar do not takes the colors from the profile color scheme anymore when using an Application Theme different from Breeze i.e.(Oxygen, Fusion).
https://bugs.kde.org/show_bug.cgi?id=449236 Giovanni Santoni changed: What|Removed |Added Summary|Scrollbar do not take the |Scrollbar do not takes the |colors from the profile |colors from the profile |color scheme anymore when |color scheme anymore when |using an Application Theme |using an Application Theme |different from Breeze |different from Breeze |i.e.(Oxygen, Fusion). |i.e.(Oxygen, Fusion). -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 449236] Scrollbar do not take the colors from the profile color scheme anymore when using an Application Theme different from Breeze i.e.(Oxygen, Fusion).
https://bugs.kde.org/show_bug.cgi?id=449236 --- Comment #4 from Giovanni Santoni --- Created attachment 145986 --> https://bugs.kde.org/attachment.cgi?id=145986=edit 21.08.03 light theme oxygen -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 449236] Scrollbar do not take the colors from the profile color scheme anymore when using an Application Theme different from Breeze i.e.(Oxygen, Fusion).
https://bugs.kde.org/show_bug.cgi?id=449236 --- Comment #3 from Giovanni Santoni --- Created attachment 145985 --> https://bugs.kde.org/attachment.cgi?id=145985=edit konsole 21.08.03 fusion -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 449236] Scrollbar do not take the colors from the profile color scheme anymore when using an Application Theme different from Breeze i.e.(Oxygen, Fusion).
https://bugs.kde.org/show_bug.cgi?id=449236 Giovanni Santoni changed: What|Removed |Added Attachment #145984|21.08.03 oxygen |konsole 21.08.03 oxygen description|| -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 449236] Scrollbar do not take the colors from the profile color scheme anymore when using an Application Theme different from Breeze i.e.(Oxygen, Fusion).
https://bugs.kde.org/show_bug.cgi?id=449236 --- Comment #2 from Giovanni Santoni --- Created attachment 145984 --> https://bugs.kde.org/attachment.cgi?id=145984=edit 21.08.03 oxygen -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 449236] Scrollbar do not take the colors from the profile color scheme anymore when using an Application Theme different from Breeze i.e.(Oxygen, Fusion).
https://bugs.kde.org/show_bug.cgi?id=449236 --- Comment #1 from Giovanni Santoni --- Created attachment 145983 --> https://bugs.kde.org/attachment.cgi?id=145983=edit konsole 21.12.1 fusion -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 449236] Scrollbar do not take the colors from the profile color scheme anymore when using an Application Theme different from Breeze i.e.(Oxygen, Fusion).
https://bugs.kde.org/show_bug.cgi?id=449236 Giovanni Santoni changed: What|Removed |Added CC||giovanni.santon...@gmail.co ||m -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 449236] New: Scrollbar do not take the colors from the profile color scheme anymore when using an Application Theme different from Breeze i.e.(Oxygen, Fusion).
https://bugs.kde.org/show_bug.cgi?id=449236 Bug ID: 449236 Summary: Scrollbar do not take the colors from the profile color scheme anymore when using an Application Theme different from Breeze i.e.(Oxygen, Fusion). Product: konsole Version: 21.12.1 Platform: Gentoo Packages OS: Linux Status: REPORTED Severity: normal Priority: NOR Component: general Assignee: konsole-de...@kde.org Reporter: giovanni.santon...@gmail.com Target Milestone: --- Created attachment 145982 --> https://bugs.kde.org/attachment.cgi?id=145982=edit Konsole 21.12.1 oxygen SUMMARY *** Scrollbar do not take the colors from the profile color scheme anymore when using an Application Theme different from Breeze i.e.(Oxygen, Fusion). In 21.08.3 it was working. *** STEPS TO REPRODUCE 1. Set Fusion Application theme from settings. 2. Open Konsole and edit current profile. 3. From the Appareance section change the color scheme. OBSERVED RESULT The scrollbar keeps the color of the Global color scheme. EXPECTED RESULT The scrollbar take the color of the Konsole profile color scheme. SOFTWARE/OS VERSIONS Linux/KDE Plasma: KDE Plasma Version: 5.23.5 KDE Frameworks Version: 5.90 Qt Version: 5.15.2 ADDITIONAL INFORMATION -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 426143] Kwin didn't drop shadows in some cases:
https://bugs.kde.org/show_bug.cgi?id=426143 --- Comment #8 from Giovanni Santoni --- Hi tank you for the link i will do some test immediately. By the way i tried to manually add _KDE_NET_WM_SHADOW to google Chrome: xprop -id 0x465 -f _KDE_NET_WM_SHADOW 32c -set _KDE_NET_WM_SHADOW 35651649,35651659,35651660,35651661,35651662,35651663,35651664,35651665,8,8,1,8 copying the id of the pixmaps and the offsets from the plasma panel and it works. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 426143] Kwin didn't drop shadows in some cases:
https://bugs.kde.org/show_bug.cgi?id=426143 --- Comment #7 from Giovanni Santoni --- Created attachment 131412 --> https://bugs.kde.org/attachment.cgi?id=131412=edit Chrome with _KDE_NET_WM_SHADOW -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 426143] Kwin didn't drop shadows in some cases:
https://bugs.kde.org/show_bug.cgi?id=426143 Giovanni Santoni changed: What|Removed |Added Resolution|NOT A BUG |--- Ever confirmed|0 |1 Status|RESOLVED|REOPENED -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 426143] Kwin didn't drop shadows in some cases:
https://bugs.kde.org/show_bug.cgi?id=426143 --- Comment #5 from Giovanni Santoni --- Ok but as a workaround would be possible to provide a drop shadow effect (like the one before plasma 4.6) to provide shadows for all the applications which dont draw drop-shadows on their own? If is in theory possible a would like to try to implement one on myself. Where i can find some documentation to start? -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 426143] Kwin didn't drop shadows in some cases:
https://bugs.kde.org/show_bug.cgi?id=426143 --- Comment #3 from Giovanni Santoni --- Gnome mutter is able to draw correctly shadow in all those cases giving a more consistent desktop experience. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 426143] Kwin didn't drop shadows in some cases:
https://bugs.kde.org/show_bug.cgi?id=426143 Giovanni Santoni changed: What|Removed |Added CC||giovanni.santon...@gmail.co ||m -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 426143] Kwin didn't drop shadows in some cases:
https://bugs.kde.org/show_bug.cgi?id=426143 --- Comment #2 from Giovanni Santoni --- Created attachment 131392 --> https://bugs.kde.org/attachment.cgi?id=131392=edit Intellij menus no shadow -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 426143] Kwin didn't drop shadows in some cases:
https://bugs.kde.org/show_bug.cgi?id=426143 --- Comment #1 from Giovanni Santoni --- Created attachment 131391 --> https://bugs.kde.org/attachment.cgi?id=131391=edit Qmmp no shadows -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 426143] New: Kwin didn't drop shadows in some cases:
https://bugs.kde.org/show_bug.cgi?id=426143 Bug ID: 426143 Summary: Kwin didn't drop shadows in some cases: Product: kwin Version: unspecified Platform: Other OS: Linux Status: REPORTED Severity: wishlist Priority: NOR Component: compositing Assignee: kwin-bugs-n...@kde.org Reporter: giovanni.santon...@gmail.com Target Milestone: --- Created attachment 131389 --> https://bugs.kde.org/attachment.cgi?id=131389=edit Google chrome and popups Kwin didn't drop shadows in some cases: Google chrome main windows and popups. Shaped windows i.e. android studio emulators. Qmmp Non gtk toolkit popups (i.e emacs using xaw3d or Intellij IDE using java) Electron applications i.e. Visual Studio code or MS Teams client. SOFTWARE/OS VERSIONS Windows: macOS: Linux/KDE Plasma: KDE Plasma Version: 5.19.5 KDE Frameworks Version: 5.73 Qt Version: 5.14.2 ADDITIONAL INFORMATION -- You are receiving this mail because: You are watching all bug changes.
