[valgrind] [Bug 358697] valgrind.h: Some code remains even when defining NVALGRIND

[Matthias Schwarzott via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=358697

--- Comment #3 from Matthias Schwarzott  ---
e.g. QT has a macro like this:

#define Q_UNUSED(x) (void)x;

To be used inside functions:
Q_UNUSED(format)

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 358697] valgrind.h: Some code remains even when defining NVALGRIND

[Matthias Schwarzott via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=358697

--- Comment #2 from Matthias Schwarzott  ---
The simplest solution could be to use "(void)format" and protect this with an
ifdef checking that we are not running under the problematic static code
checker.

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 358697] valgrind.h: Some code remains even when defining NVALGRIND

[Matthias Schwarzott via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=358697

--- Comment #1 from Matthias Schwarzott  ---
Created attachment 96891
  --> https://bugs.kde.org/attachment.cgi?id=96891=edit
valgrind-improve-unused-parameter-on-r15763.patch

This patch implements the __attribute__ usage.
But I am not sure about the ifdef code. It is just what was originally around
the __attribute__ usage.

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 356817] New: valgrind.h triggers compiler errors on MSVC when defining NVALGRIND

[Matthias Schwarzott via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=356817

Bug ID: 356817
   Summary: valgrind.h triggers compiler errors on MSVC when
defining NVALGRIND
   Product: valgrind
   Version: unspecified
  Platform: Compiled Sources
OS: MS Windows
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: jsew...@acm.org
  Reporter: z...@gentoo.org

When compiling sources on MSVC with NVALGRIND being defined, it shows this
error:
1>include\Valgrind/valgrind.h(4493) : error C2220: warning treated as error -
no 'object' file generated
1>include\Valgrind/valgrind.h(4493) : warning C4100: 'format' : unreferenced
formal parameter
1>include\Valgrind/valgrind.h(4531) : warning C4100: 'format' : unreferenced
formal parameter


Reproducible: Always

-- 
You are receiving this mail because:
You are watching all bug changes.