[dolphin] [Bug 447530] Untracked empty folders in a git repo are wrongly shown with the 'up-to-date' icon
https://bugs.kde.org/show_bug.cgi?id=447530 Nikolai Krasheninnikov changed: What|Removed |Added Latest Commit||https://invent.kde.org/sdk/ ||dolphin-plugins/-/commit/29 ||a6aff76d1a4dc9b236b75b359d4 ||e97d2d0b987 Status|ASSIGNED|RESOLVED Resolution|--- |FIXED --- Comment #5 from Nikolai Krasheninnikov --- Git commit 29a6aff76d1a4dc9b236b75b359d4e97d2d0b987 by Nikolai Krasheninnikov. Committed on 28/05/2024 at 14:34. Pushed by nikolaik into branch 'master'. git: untracked empty dirs are no longer shown as versioned As git can't add empty dirs, they don't show up in `git status`. We can get this list from `git ls-files`. This list is overlapping with `git status` but we can't gain all info from just one command. So we use both. M +10 -1git/fileviewgitplugin.cpp M +23 -0git/gitwrapper.cpp M +10 -0git/gitwrapper.h https://invent.kde.org/sdk/dolphin-plugins/-/commit/29a6aff76d1a4dc9b236b75b359d4e97d2d0b987 -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 483080] Git icons appear only if a new Dolphin tab is opened
https://bugs.kde.org/show_bug.cgi?id=483080 --- Comment #9 from Nikolai Krasheninnikov --- (In reply to Aldo Latino from comment #8) > (In reply to Nikolai Krasheninnikov from comment #7) > > Cannot reproduce, always works as expected > > Reopen? > > If it works correctly in your computer, the problem is in my installation. > So this is not a bug, I think. :-) So the second one is a duplicate and can be also closed. -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 483080] Git icons appear only if a new Dolphin tab is opened
https://bugs.kde.org/show_bug.cgi?id=483080 --- Comment #7 from Nikolai Krasheninnikov --- Cannot reproduce, always works as expected Reopen? -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 483080] Git icons appear only if a new Dolphin tab is opened
https://bugs.kde.org/show_bug.cgi?id=483080 --- Comment #5 from Nikolai Krasheninnikov --- (In reply to Aldo Latino from comment #4) > In the meantime, I found an interesting thing. In Dolphin, if you activate > the option to show your home as starting directory when you open a new > instance of Dolphin, the green check marks don't appear over the files in a > directory under Git control. If you setup another directory (e.g, > /home/user/Desktop), the green check marks appear. And they appear also if > you leave active the first option to remember last opened directory and tabs. > > In other words, if in dolphinrc config file we have these options together: > HomeUrl=/home/aldo/any-folder > RememberOpenedTabs=false > the green check marks appear. > > If we have this option only without "HomeUrl" > RememberOpenedTabs=false > the green check marks don't appear. > > Can you confirm this behavior? Cannot reproduce :( What I am trying is: 1. open a Dolphin, enable SVN and GIT plugins 2. in the same instance check save state from last time on startup 3. close Dolphin, open new instance, badges are there I also tried modifying dolphinrc as described, nothing changed, badges are there. Maybe we closed this one too quickly. I am on current master. -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 483080] Git icons appear only if a new Dolphin tab is opened
https://bugs.kde.org/show_bug.cgi?id=483080 --- Comment #3 from Nikolai Krasheninnikov --- (In reply to Aldo Latino from comment #2) > I close this bug because, after the Nikolai's comment, I tested the plugin > in a brand new installation and it works as expected. So the problem is in > another place, perhaps a conflict with some other setting. https://bugs.kde.org/show_bug.cgi?id=450944 looks same, may also be closed -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 482524] dolphin svn plugin: ODR violations when building with LTO
https://bugs.kde.org/show_bug.cgi?id=482524 Nikolai Krasheninnikov changed: What|Removed |Added Status|ASSIGNED|RESOLVED Latest Commit||https://invent.kde.org/sdk/ ||dolphin-plugins/-/commit/77 ||2a4d712abcf1c6c86f25bd30678 ||5815132d886 Resolution|--- |FIXED --- Comment #2 from Nikolai Krasheninnikov --- Git commit 772a4d712abcf1c6c86f25bd306785815132d886 by Nikolai Krasheninnikov. Committed on 02/04/2024 at 09:07. Pushed by nikolaik into branch 'master'. svn: Fix gcc-13 One Definition Rule compilation error with LTO enabled columns_t enum defined multiple times in different translation units. Although this should not be an error, we move the definition to a separate unnamed namespace. M +5-5svn/svncommitdialog.cpp M +7-7svn/svnlogdialog.cpp https://invent.kde.org/sdk/dolphin-plugins/-/commit/772a4d712abcf1c6c86f25bd306785815132d886 -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 483080] Git icons appear only if a new Dolphin tab is opened
https://bugs.kde.org/show_bug.cgi?id=483080 Nikolai Krasheninnikov changed: What|Removed |Added CC||nkrasheninni...@yandex.ru --- Comment #1 from Nikolai Krasheninnikov --- Cannot confirm, works as expected on current master. KDE Plasma Version: 6.1.0 Qt Version: 6.6.3 Graphic platform: X11 -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 420239] Provide vcs plugins action to checkout/clone repository
https://bugs.kde.org/show_bug.cgi?id=420239 Nikolai Krasheninnikov changed: What|Removed |Added Status|RESOLVED|CLOSED -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 420239] Provide vcs plugins action to checkout/clone repository
https://bugs.kde.org/show_bug.cgi?id=420239 Nikolai Krasheninnikov changed: What|Removed |Added Resolution|--- |FIXED Status|REPORTED|RESOLVED --- Comment #2 from Nikolai Krasheninnikov --- Fixed in: https://phabricator.kde.org/D29041 https://phabricator.kde.org/D29042 -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 420239] New: Provide vcs plugins action to checkout/clone repository
https://bugs.kde.org/show_bug.cgi?id=420239 Bug ID: 420239 Summary: Provide vcs plugins action to checkout/clone repository Product: dolphin Version: unspecified Platform: Kubuntu Packages OS: Linux Status: REPORTED Severity: wishlist Priority: NOR Component: general Assignee: dolphin-bugs-n...@kde.org Reporter: nkrasheninni...@yandex.ru CC: kfm-de...@kde.org Target Milestone: --- SUMMARY Common use-case for vcs is checkout/clone. For now Dolphin's KVersionControlPlugin interface doesn't support this because KVersionControlPlugin::actions() applied only for versioned directories. This wishlist is for filling a request for this feature and also for a possible design discussion. We can extend KVersionControlPlugin interface with one more pure virtual function. That function will return action list for a unversioned directory with clone action (and maybe more like for example plugin settings). Function could be 'KVersionControlPlugin::unversionedActions()' and 'KVersionControlPlugin::versionedActions()' (previously known as 'actions()'). This requires simultaneous update of 'dolphin' and 'dolphin-plugins' projects. -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 319546] Subversion plugin issuing "mkfifo" on Windows
https://bugs.kde.org/show_bug.cgi?id=319546 Nikolai Krasheninnikov changed: What|Removed |Added Status|CONFIRMED |RESOLVED CC||nkrasheninni...@yandex.ru Resolution|--- |FIXED --- Comment #4 from Nikolai Krasheninnikov --- This commit fixes an issue: https://phabricator.kde.org/R449:0df2e299f415411eef36327c8d8d4933766a94d5 -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 415698] VCS plugin function calls redundant
https://bugs.kde.org/show_bug.cgi?id=415698 --- Comment #2 from Nikolai Krasheninnikov --- Addition on #4: as it turns out KVersionControlPlugin::itemVersion() got called by VCS plugin itself on the context menu creation so its ok. -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 415698] VCS plugin function calls redundant
https://bugs.kde.org/show_bug.cgi?id=415698 Nikolai Krasheninnikov changed: What|Removed |Added Summary|VCS plugin functions calls |VCS plugin function calls |redundant |redundant -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 415698] New: VCS plugin functions calls redundant
https://bugs.kde.org/show_bug.cgi?id=415698 Bug ID: 415698 Summary: VCS plugin functions calls redundant Product: dolphin Version: unspecified Platform: Compiled Sources OS: Linux Status: REPORTED Severity: minor Priority: NOR Component: general Assignee: dolphin-bugs-n...@kde.org Reporter: nkrasheninni...@yandex.ru CC: kfm-de...@kde.org Target Milestone: --- SUMMARY This applies to any VCS dolphin plugin. KVersionControlPlugin base class virtual functions get called more than actually needed. 1. KVersionControlPlugin::fileName() calls each time entering directory or updating existing one. Sometimes it get called 3 times. 2. KVersionControlPlugin::beginRetrieval()/endRetrieval() pair get called 2 times on each directory update. 3. KVersionControlPlugin::itemVersion() for each directory entry called twice. 4. When KVersionControlPlugin::actions() got implied KVersionControlPlugin::itemVersion() get called on current item. STEPS TO REPRODUCE 1. Add debug output to specified functions. 2. Enter a directory under VCS. 3. Call popup VCS plugin menu by right click. OBSERVED RESULT Virtual functions got called several times. EXPECTED RESULT 1. KVersionControlPlugin::fileName() should be called only once on Dolphin execution. 2. KVersionControlPlugin::beginRetrieval()/endRetrieval() should be called once on directory update. 3. KVersionControlPlugin::itemVersion() should be called once on directory update. 4. Implying KVersionControlPlugin::actions() should not result in itemVersion() call since item version updates only in beginRetrieval()/endRetrieval(). SOFTWARE/OS VERSIONS Dolphin: 20.03.70 ADDITIONAL INFORMATION Compiled from sources of current master -- You are receiving this mail because: You are watching all bug changes.
