[okular] [Bug 370217] [frameworks] Line width of freehand annotation is resolution dependent

[Oliver Sander via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=370217

--- Comment #3 from Oliver Sander  ---
Thanks for the hint.  I played around with this a little.  It seems that the
initial drawing code is buggier than I though.  Simply multiplying the zoom
factor to the pen width doesn't cut it.  You can witness the problems without
patching okular: go to Options -> set up Okular -> Annotations -> freehand -->
edit and set the line width to something large, like 20.  When I do this, the
drawing becomes very blocky, the pen width is not constant anymore, and
sometimes parts of what I draw are not shown.

Any ideas?  I may look some more into this, but currently I am out of ideas.

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 370217] [frameworks] Line width of freehand annotation is resolution dependent

[Oliver Sander via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=370217

--- Comment #1 from Oliver Sander  ---
Friendly ping :-)

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 321992] Feature request: Can the highlighter automatically fill the attached pop-up note with highlighted text.

[Oliver Sander via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=321992

Oliver Sander  changed:

   What|Removed |Added

 CC||oliver.san...@tu-dresden.de

--- Comment #14 from Oliver Sander  ---
It's not me who decides what goes into okular and what doesn't, but I know that
your chances increase if you upload the patch to
https://git.reviewboard.kde.org .

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 370217] New: [frameworks] Line width of freehand annotation is resolution dependent

[Oliver Sander via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=370217

Bug ID: 370217
   Summary: [frameworks] Line width of freehand annotation is
resolution dependent
   Product: okular
   Version: unspecified
  Platform: Compiled Sources
OS: Linux
Status: UNCONFIRMED
  Severity: minor
  Priority: NOR
 Component: general
  Assignee: okular-de...@kde.org
  Reporter: oliver.san...@tu-dresden.de

Try drawing a freehand annotation on a pdf document (F6 and then the third icon
from the top).  You will see it appear while you draw.  Then as you lift off
the pen / release the mouse button, it will disappear very briefly, and then
reappear.  The bug is that the line also changes its width at the same moment.

Here is what I think is happening: the line is drawn by two different parts of
the code before and after you release the mouse button.  While you draw, the
line is drawn by a QPen object constructed in annotationtools.cpp:158.  The pen
width is

const qreal penWidth = m_annotElement.attribute( QStringLiteral("width"),
QStringLiteral("1.0") ).toDouble();

from three lines above.  Once the mouse button is released, the line is redrawn
by code somewhere else, and I haven't been able to find where.  I don't know
how the pen width is computed there.

I played around with my screen resolution and it seems that the problem is that
the first drawing code does not take screen resolution into account, while the
second one does.  I am interested in debugging this further, but I need some
help: where is the code that draws the freehand annotation after the initial
drawing is completed?  I suppose that comparing the two will explain why the
line widths differ.

Reproducible: Always

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 366781] [frameworks] Implement zooming with a pinch gesture on a touch screen

[Oliver Sander via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=366781

--- Comment #2 from Oliver Sander  ---
I managed to upload the patch to reviewboard after all:

https://git.reviewboard.kde.org/r/128821/

Unlike the patch that I attached above, the one at reviewboard applies directly
to the frameworks branch, and contains all necessary gesture-grabbing
infrastructure.  Therefore,

https://git.reviewboard.kde.org/r/126809/ 

is not needed.  Instead, the two will conflict.  I'll update one as soon as the
other one is committed.

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 367959] Okular mangles some characters (non embedded fonts)

[Oliver Sander via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=367959

Oliver Sander  changed:

   What|Removed |Added

 CC||oliver.san...@tu-dresden.de

--- Comment #4 from Oliver Sander  ---
Confirmed on

Qt: 4.8.7
KDE: 4.14.23
Okular: 0.25.0
poppler 0.44.0
Debian Testing

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 366785] Crash while oprning PDF from Google slides.

[Oliver Sander via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=366785

Oliver Sander  changed:

   What|Removed |Added

 CC||oliver.san...@tu-dresden.de

--- Comment #2 from Oliver Sander  ---
Works for me:  Debian Testing

Qt: 4.8.7
KDE: 4.14.22
Okular: 0.25.0

poppler:  0.44.0-3

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 366781] Implement zooming with a pinch gesture on a touch screen

[Oliver Sander via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=366781

--- Comment #1 from Oliver Sander  ---
Created attachment 100602
  --> https://bugs.kde.org/attachment.cgi?id=100602=edit
Implement zooming with a two-finger pinch gesture on a touch screen.

Needs the framework branch and

https://git.reviewboard.kde.org/r/126809/

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 366617] okular crash when opening a pdfmod generated file

[Oliver Sander via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=366617

--- Comment #10 from Oliver Sander  ---
According to the original trace, the segfault happens in poppler, so maybe you
should start with that.

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 366617] okular crash when opening a pdfmod generated file

[Oliver Sander via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=366617

--- Comment #7 from Oliver Sander  ---
I don't know how to do it on ArchLinux.  DuckDuckGo gave me the following link,
which appears to go into the right direction:

https://wiki.archlinux.org/index.php/Debug_-_Getting_Traces

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 366617] okular crash when opening a pdfmod generated file

[Oliver Sander via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=366617

--- Comment #5 from Oliver Sander  ---
Hmm, strange.  Can you get a backtrace with debug symbols?

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 366617] okular crash when opening a pdfmod generated file

[Oliver Sander via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=366617

--- Comment #3 from Oliver Sander  ---
It works for me.  Is your okular/poppler too old?  Mine is

$okular --version
Qt: 4.8.7
KDE: 4.14.22
Okular: 0.25.0

$apt show libpoppler-dev
Package: libpoppler-dev
Version: 0.44.0-3

on an up-to-date Debian Testing.

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 366617] okular crash when opening a pdfmod generated file

[Oliver Sander via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=366617

Oliver Sander  changed:

   What|Removed |Added

 CC||oliver.san...@tu-dresden.de

--- Comment #1 from Oliver Sander  ---
Can you please attach the file?

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 365460] PDF Version 1.7 - Document Password needed

[Oliver Sander via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365460

Oliver Sander  changed:

   What|Removed |Added

 CC||oliver.san...@tu-dresden.de

--- Comment #1 from Oliver Sander  ---
Do you  mean this one:

https://www.bundesbank.de/Redaktion/DE/Downloads/Aufgaben/Unbarer_Zahlungsverkehr/Vordrucke/7000_c3_einreichungsverzeichnis_auslandsschecks.pdf

I can open it without issues.  (It has only one page, right?)  Maybe your
okular/poppler is too old?
Mine are

Qt: 4.8.7
KDE: 4.14.21
Okular: 0.25.0
Poppler 0.44
(all from Debian testing)

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 177778] make it possible to resize resizable annotations

[Oliver Sander via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=18

Oliver Sander  changed:

   What|Removed |Added

 CC||oliver.san...@tu-dresden.de

--- Comment #13 from Oliver Sander  ---
The Berlin office of KDAB got hired several times to implement support for
embedded movies in okular.  That worked out very nicely.

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 357822] Superscript characters sometimes not displayed

[Oliver Sander via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=357822

Oliver Sander  changed:

   What|Removed |Added

 CC||oliver.san...@tu-dresden.de

--- Comment #4 from Oliver Sander  ---
I can reproduce the problem with pdftotext version 0.38.0 from Debian testing.

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 357822] Superscript characters sometimes not displayed

[Oliver Sander via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=357822

--- Comment #9 from Oliver Sander  ---
My freetype version appears to be 2.6.1 (says my Debian package manager).

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 357822] Superscript characters sometimes not displayed

[Oliver Sander via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=357822

--- Comment #8 from Oliver Sander  ---
Created attachment 96596
  --> https://bugs.kde.org/attachment.cgi?id=96596=edit
Screenshot of my file->properties->fonts

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 357579] Okular-15.12.0: page numbers text area not sized correctly when refreshing a document

[Oliver Sander via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=357579

Oliver Sander  changed:

   What|Removed |Added

 CC||oliver.san...@tu-dresden.de

--- Comment #2 from Oliver Sander  ---
I can confirm this.  There are more ways to make the mis-rendering go away
(temporarily), e.g., moving to a different page.

~ okular --version
Qt: 4.8.7
KDE: 4.14.14
Okular: 0.23.2
(from today's Debian testing, using the MATE desktop)

-- 
You are receiving this mail because:
You are watching all bug changes.