[partitionmanager] [Bug 398154] New: kpmcore starts external process dd

[Pali Rohár]

https://bugs.kde.org/show_bug.cgi?id=398154

Bug ID: 398154
   Summary: kpmcore starts external process dd
   Product: partitionmanager
   Version: Git
  Platform: Other
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: andr...@stikonas.eu
  Reporter: pali.ro...@gmail.com
  Target Milestone: ---

It does not make any sense to use external process dd. Qt provides QFile class
for reading and writing to files.

$ git grep '"dd"'
src/fs/fat12.cpp:m_UpdateUUID = findExternal(QStringLiteral("dd")) ?
cmdSupportFileSystem : cmdSupportNone;
src/fs/fat12.cpp:ExternalCommand cmd(report, QStringLiteral("dd"), {
QStringLiteral("of=") + deviceNode , QStringLiteral("bs=1"),
QStringLiteral("count=4"), QStringLiteral("seek=39") });
src/fs/fat16.cpp:m_UpdateUUID = findExternal(QStringLiteral("dd")) ?
cmdSupportFileSystem : cmdSupportNone;
src/fs/fat32.cpp:ExternalCommand cmd(report, QStringLiteral("dd"), {
QStringLiteral("of=") + deviceNode, QStringLiteral("bs=1"),
QStringLiteral("count=4"), QStringLiteral("seek=67") });
src/fs/ntfs.cpp:ExternalCommand cmd(report, QStringLiteral("dd"), {
QStringLiteral("of=") + deviceNode , QStringLiteral("bs=1"),
QStringLiteral("count=4"), QStringLiteral("seek=28") });
src/fs/ntfs.cpp:ExternalCommand cmd2(report, QStringLiteral("dd"), {
QStringLiteral("of=") + deviceNode , QStringLiteral("bs=1"),
QStringLiteral("count=4"), QStringLiteral("seek=") + QString::number(pos) });
src/plugins/sfdisk/sfdiskbackend.cpp:ExternalCommand
ddCommand(QStringLiteral("dd"),
src/util/externalcommand_whitelist.h:QStringLiteral("dd"),

-- 
You are receiving this mail because:
You are watching all bug changes.

[trojita] [Bug 391718] Trojita hangs in infinite loop

[Pali Rohár]

https://bugs.kde.org/show_bug.cgi?id=391718

--- Comment #2 from Pali Rohár <pali.ro...@gmail.com> ---
Created attachment 111653
  --> https://bugs.kde.org/attachment.cgi?id=111653=edit
trojita-connection-log

Now Trojita hangs in infinite loop every time I open mbox. In attachment is log
file (some mbox names were anonymized to ). Plus here is backtrace:

(gdb) bt
#0  Imap::Mailbox::TreeItemMessage::uid (this=0x564a08c1a080) at
trojita/src/Imap/Model/MailboxTree.cpp:1436
#1  0x564a05c24571 in (anonymous namespace)::messageHasUidZero
(item=) at trojita/src/Imap/Model/Model.cpp:96
#2 
Common::linearLowerBoundWithUnknownElements<QTypedArrayData<Imap::Mailbox::TreeItem*>::iterator,
unsigned int, bool (*)(Imap::Mailbox::TreeItem const*), bool
(*)(Imap::Mailbox::TreeItem const*, unsigned int)> (lessThan=0x564a05c218e0
<(anonymous namespace)::uidComparator(Imap::Mailbox::TreeItem const*, uint)>,
isUnknown=, value=: , end=...,
begin=...) at trojita/src/Common/FindWithUnknown.h:38
#3 
Common::lowerBoundWithUnknownElements<QTypedArrayData<Imap::Mailbox::TreeItem*>::iterator,
unsigned int, bool (*)(Imap::Mailbox::TreeItem const*), bool
(*)(Imap::Mailbox::TreeItem const*, unsigned int)> (lessThan=0x564a05c218e0
<(anonymous namespace)::uidComparator(Imap::Mailbox::TreeItem const*, uint)>,
isUnknown=, value=: , end=...,
begin=...) at trojita/src/Common/FindWithUnknown.h:60
#4  Imap::Mailbox::Model::findMessageOrNextOneByUid
(this=this@entry=0x564a07585f50, list=list@entry=0x564a0758f250,
uid=uid@entry=969217) at trojita/src/Imap/Model/Model.cpp:1299
#5  0x564a05c1411f in Imap::Mailbox::TreeItemMailbox::handleVanished
(this=, model=, resp=...) at
trojita/src/Imap/Model/MailboxTree.cpp:622
#6  0x564a05c79c76 in
Imap::Mailbox::ObtainSynchronizedMailboxTask::handleVanished
(this=0x564a077eaf20, resp=0x564a085f7ae0) at
trojita/src/Imap/Tasks/ObtainSynchronizedMailboxTask.cpp:849
#7  0x564a05c2cdaf in Imap::Mailbox::Model::responseReceived
(this=this@entry=0x564a07585f50, it=..., it@entry=...) at
trojita/src/Imap/Model/Model.cpp:221
#8  0x564a05c2d3de in Imap::Mailbox::Model::responseReceived
(this=0x564a07585f50, parser=0x564a077d8b30) at
trojita/src/Imap/Model/Model.cpp:163
#9  0x7ff71b4bf499 in QObject::event(QEvent*) () from
/usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#10 0x7ff71bd75b8c in QApplicationPrivate::notify_helper(QObject*, QEvent*)
() from /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
#11 0x7ff71bd7d341 in QApplication::notify(QObject*, QEvent*) () from
/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
#12 0x7ff71b4929e0 in QCoreApplication::notifyInternal2(QObject*, QEvent*)
() from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#13 0x7ff71b49516d in QCoreApplicationPrivate::sendPostedEvents(QObject*,
int, QThreadData*) () from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#14 0x7ff71b4e6c43 in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#15 0x7ff718a167f7 in g_main_context_dispatch () from
/lib/x86_64-linux-gnu/libglib-2.0.so.0
#16 0x7ff718a16a60 in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#17 0x7ff718a16b0c in g_main_context_iteration () from
/lib/x86_64-linux-gnu/libglib-2.0.so.0
#18 0x7ff71b4e704f in
QEventDispatcherGlib::processEvents(QFlags) ()
from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#19 0x7ff71b4909ca in
QEventLoop::exec(QFlags) () from
/usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#20 0x7ff71b49913c in QCoreApplication::exec() () from
/usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#21 0x564a05adcce5 in main (argc=, argv=) at
trojita/src/Gui/main.cpp:218
(gdb) next
Common::linearLowerBoundWithUnknownElements<QTypedArrayData<Imap::Mailbox::TreeItem*>::iterator,
unsigned int, bool (*)(Imap::Mailbox::TreeItem const*), bool
(*)(Imap::Mailbox::TreeItem const*, unsigned int)> (lessThan=0x564a05c218e0
<(anonymous namespace)::uidComparator(Imap::Mailbox::TreeItem const*, uint)>,
isUnknown=, value=: 969217, end=...,
begin=...) at trojita/src/Common/FindWithUnknown.h:38
38  if (isUnknown(*begin)) {
(gdb) next
Common::lowerBoundWithUnknownElements<QTypedArrayData<Imap::Mailbox::TreeItem*>::iterator,
unsigned int, bool (*)(Imap::Mailbox::TreeItem const*), bool
(*)(Imap::Mailbox::TreeItem const*, unsigned int)> (lessThan=0x564a05c218e0
<(anonymous namespace)::uidComparator(Imap::Mailbox::TreeItem const*, uint)>,
isUnknown=, value=: 969217, end=...,
begin=...) at trojita/src/Common/FindWithUnknown.h:60
60  return linearLowerBoundWithUnknownElements(begin, begin +
n, value, isUnknown, lessThan);
(gdb) next

-- 
You are receiving this mail because:
You are watching all bug changes.

[trojita] [Bug 391727] Trojita crashed when idling in INBOX

[Pali Rohár]

https://bugs.kde.org/show_bug.cgi?id=391727

--- Comment #3 from Pali Rohár <pali.ro...@gmail.com> ---
Created attachment 111632
  --> https://bugs.kde.org/attachment.cgi?id=111632=edit
Output from massif

In attachment is output from massif. I killed trojita when it consumed more
then 1GB of memory. Output on stdout was:

$ valgrind --tool=massif trojita
==14521== Massif, a heap profiler
==14521== Copyright (C) 2003-2015, and GNU GPL'd, by Nicholas Nethercote
==14521== Using Valgrind-3.12.0.SVN and LibVEX; rerun with -h for copyright
info
==14521== Command: trojita
==14521== 
^C==14521== 
==14521== Process terminating with default action of signal 2 (SIGINT)
==14521==at 0x995A96B: __dynamic_cast (in
/usr/lib/x86_64-linux-gnu/libstdc++.so.6.0.22)
==14521==by 0x2F00B6: void
Imap::Mailbox::ThreadingMsgListModel::threadForeach(unsigned int const&,
std::function) const
(ThreadingMsgListModel.cpp:1246)
==14521==by 0x2E4FCA:
Imap::Mailbox::ThreadingMsgListModel::threadAggregatedFlags(unsigned int) const
(ThreadingMsgListModel.cpp:1271)
==14521==by 0x2EE78B:
Imap::Mailbox::ThreadingMsgListModel::data(QModelIndex const&, int) const
(ThreadingMsgListModel.cpp:307)
==14521==by 0x9640BA8: QSortFilterProxyModel::data(QModelIndex const&, int)
const (in /usr/lib/x86_64-linux-gnu/libQt5Core.so.5.7.1)
==14521==by 0x2D7D38: Imap::Mailbox::PrettyMsgListModel::data(QModelIndex
const&, int) const (PrettyMsgListModel.cpp:175)
==14521==by 0x1DB86E: Gui::MsgItemDelegate::itemColor(QModelIndex const&)
const (qabstractitemmodel.h:426)
==14521==by 0x1DBB5C: Gui::MsgItemDelegate::paint(QPainter*,
QStyleOptionViewItem const&, QModelIndex const&) const (MsgItemDelegate.cpp:89)
==14521==by 0x8C46B0F: QTreeView::drawRow(QPainter*, QStyleOptionViewItem
const&, QModelIndex const&) const (in
/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5.7.1)
==14521==by 0x8C4C596: QTreeView::drawTree(QPainter*, QRegion const&) const
(in /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5.7.1)
==14521==by 0x8C510B5: QTreeView::paintEvent(QPaintEvent*) (in
/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5.7.1)
==14521==by 0x8A03277: QWidget::event(QEvent*) (in
/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5.7.1)
==14521== 
Zabitý

Memory leak probably occured in snapshot=46 which contains trace:

n2: 1103927816 (heap allocation functions) malloc/new/new[], --alloc-fns, etc.
 n2: 1074037664 0x950CC6F: QListData::realloc_grow(int) (in
/usr/lib/x86_64-linux-gnu/libQt5Core.so.5.7.1)
  n2: 1074029280 0x950CD0D: QListData::append(int) (in
/usr/lib/x86_64-linux-gnu/libQt5Core.so.5.7.1)
   n1: 1073741824 0x20887E: QList::operator+=(QList const&)
(qlist.h:942)
n1: 1073741824 0x2F0102: void
Imap::Mailbox::ThreadingMsgListModel::threadForeach(unsigned int const&,
std::function) const
(functional:2127)
 n1: 1073741824 0x2E4FC9:
Imap::Mailbox::ThreadingMsgListModel::threadAggregatedFlags(unsigned int) const
(ThreadingMsgListModel.cpp:1271)
  n1: 1073741824 0x2EE78A:
Imap::Mailbox::ThreadingMsgListModel::data(QModelIndex const&, int) const
(ThreadingMsgListModel.cpp:307)
   n1: 1073741824 0x9640BA7: QSortFilterProxyModel::data(QModelIndex
const&, int) const (in /usr/lib/x86_64-linux-gnu/libQt5Core.so.5.7.1)
n1: 1073741824 0x2D7D37:
Imap::Mailbox::PrettyMsgListModel::data(QModelIndex const&, int) const
(PrettyMsgListModel.cpp:175)
 n1: 1073741824 0x1DB86D: Gui::MsgItemDelegate::itemColor(QModelIndex
const&) const (qabstractitemmodel.h:426)
  n1: 1073741824 0x1DBB5B: Gui::MsgItemDelegate::paint(QPainter*,
QStyleOptionViewItem const&, QModelIndex const&) const (MsgItemDelegate.cpp:89)

-- 
You are receiving this mail because:
You are watching all bug changes.

[trojita] [Bug 391710] Trojita crash when searching: ASSERT: "it != ptrToInternal.constEnd()" in file src/Imap/Model/ThreadingMsgListModel.cpp, line 1476

[Pali Rohár]

https://bugs.kde.org/show_bug.cgi?id=391710

--- Comment #3 from Pali Rohár <pali.ro...@gmail.com> ---
Created attachment 111604
  --> https://bugs.kde.org/attachment.cgi?id=111604=edit
crash-log

In attachment is crash log, some of the mailboxes in imap log were replaced by
string YYY.

Now trojita crashed with assert:

ASSERT: "replaceWith != threading.end()" in file
trojita/src/Imap/Model/ThreadingMsgListModel.cpp, line 1142

-- 
You are receiving this mail because:
You are watching all bug changes.

[trojita] [Bug 391382] Trojita with watchFolders=all or watchFolders=subscribed crash

[Pali Rohár]

https://bugs.kde.org/show_bug.cgi?id=391382

--- Comment #4 from Pali Rohár <pali.ro...@gmail.com> ---
It is strange that I can reproduce it just against one server, local process
via ssh. All other configurations IMAP via TCP, or local process via ssh to
other servers do not hit.

-- 
You are receiving this mail because:
You are watching all bug changes.

[trojita] [Bug 391727] Trojita crashed when idling in INBOX

[Pali Rohár]

https://bugs.kde.org/show_bug.cgi?id=391727

--- Comment #1 from Pali Rohár <pali.ro...@gmail.com> ---
Same situation, memory usage about 2.7 GB and crash again with following, but
different backtrace:

terminate called after throwing an instance of 'std::bad_alloc'
  what():  std::bad_alloc

Thread 1 "trojita" received signal SIGABRT, Aborted.
__GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:51
51  ../sysdeps/unix/sysv/linux/raise.c: Adresár alebo súbor neexistuje.
(gdb) bt
#0  __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:51
#1  0x7273342a in __GI_abort () at abort.c:89
#2  0x7304a0ad in __gnu_cxx::__verbose_terminate_handler() () from
/usr/lib/x86_64-linux-gnu/libstdc++.so.6
#3  0x73048066 in ?? () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#4  0x730480b1 in std::terminate() () from
/usr/lib/x86_64-linux-gnu/libstdc++.so.6
#5  0x730482c9 in __cxa_throw () from
/usr/lib/x86_64-linux-gnu/libstdc++.so.6
#6  0x733cb9b2 in qBadAlloc() () from
/usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#7  0x73449c9a in QListData::realloc_grow(int) () from
/usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#8  0x73449d0f in QListData::append(int) () from
/usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#9  0x5573bb10 in QList::operator+=
(this=this@entry=0x7fffa6c8, l=...) at
/usr/include/x86_64-linux-gnu/qt5/QtCore/qlist.h:942
#10 0x5573c127 in QList::append (t=...,
this=0x7fffa6c8) at /usr/include/x86_64-linux-gnu/qt5/QtCore/qlist.h:960
#11 Imap::Mailbox::ThreadingMsgListModel::threadForeach(unsigned int
const&, std::function) const
(this=this@entry=0x55dbb590, root=@0x7fffa73c: 6899, 
root@entry=@0x7fffa73c: , callback=...) at
trojita/src/Imap/Model/ThreadingMsgListModel.cpp:1251
#12 0x55730fcb in
Imap::Mailbox::ThreadingMsgListModel::threadAggregatedFlags
(this=this@entry=0x55dbb590, root=) at
trojita/src/Imap/Model/ThreadingMsgListModel.cpp:1271
#13 0x5573a78c in Imap::Mailbox::ThreadingMsgListModel::data
(this=0x55dbb590, proxyIndex=..., role=963) at
trojita/src/Imap/Model/ThreadingMsgListModel.cpp:307
#14 0x7357dba9 in QSortFilterProxyModel::data(QModelIndex const&, int)
const () from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#15 0x55723d39 in Imap::Mailbox::PrettyMsgListModel::data
(this=, index=..., role=963) at
trojita/src/Imap/Model/PrettyMsgListModel.cpp:175
#16 0x5562786f in QModelIndex::data (arole=963, this=0x7fffac80) at
/usr/include/x86_64-linux-gnu/qt5/QtCore/qabstractitemmodel.h:426
#17 Gui::MsgItemDelegate::itemColor (this=this@entry=0x55c476a0, index=...)
at trojita/src/Gui/MsgItemDelegate.cpp:47
#18 0x55627b5d in Gui::MsgItemDelegate::paint (this=0x55c476a0,
painter=0x7fffaff0, option=..., index=...) at
trojita/src/Gui/MsgItemDelegate.cpp:89
#19 0x74127b10 in QTreeView::drawRow(QPainter*, QStyleOptionViewItem
const&, QModelIndex const&) const () from
/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
#20 0x7412d597 in QTreeView::drawTree(QPainter*, QRegion const&) const
() from /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
#21 0x741320b6 in QTreeView::paintEvent(QPaintEvent*) () from
/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
#22 0x73ee4278 in QWidget::event(QEvent*) () from
/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
#23 0x73fcca0e in QFrame::event(QEvent*) () from
/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
#24 0x740f3503 in QAbstractItemView::viewportEvent(QEvent*) () from
/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
#25 0x74132f6c in QTreeView::viewportEvent(QEvent*) () from
/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
#26 0x735b9741 in
QCoreApplicationPrivate::sendThroughObjectEventFilters(QObject*, QEvent*) ()
from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#27 0x73e9cb65 in QApplicationPrivate::notify_helper(QObject*, QEvent*)
() from /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
#28 0x73ea4341 in QApplication::notify(QObject*, QEvent*) () from
/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
#29 0x735b99e0 in QCoreApplication::notifyInternal2(QObject*, QEvent*)
() from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#30 0x73edcfda in QWidgetPrivate::sendPaintEvent(QRegion const&) ()
from /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
#31 0x73edd646 in QWidgetPrivate::drawWidget(QPaintDevice*, QRegion
const&, QPoint const&, int, QPainter*, QWidgetBackingStore*) () from
/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
#32 0x73ede34c in QWidgetPrivate::paintSiblingsRecursive(QPaintDevice*,
QList<QObject*> const&, int, QRegion const&, QPoint const&, int, QPainter*,
QWidgetBackingStore*) ()
   from /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
#33 0x73ede239 in QWidgetPrivate::paintSiblingsRecursive(QPaintDevice*,
QList&l

[trojita] [Bug 391727] New: Trojita crashed when idling in INBOX

[Pali Rohár]

https://bugs.kde.org/show_bug.cgi?id=391727

Bug ID: 391727
   Summary: Trojita crashed when idling in INBOX
   Product: trojita
   Version: git
  Platform: Other
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: Other
  Assignee: trojita-b...@kde.org
  Reporter: pali.ro...@gmail.com
  Target Milestone: ---

Trojita crashed when was minimized, idling in INBOX. Another IMAP client was
heavily loading new messages (more 20 000) into same INBOX which had Trojita
opened.

Trojita crashed with std::bad_alloc when it had allocated more then 2.1 GB. So
it looks like a memory leak for a newly received messages when IDLE is active.

Here is gdb backtrace:

terminate called after throwing an instance of 'std::bad_alloc'
  what():  std::bad_alloc

Thread 1 "trojita" received signal SIGABRT, Aborted.
__GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:51
51  ../sysdeps/unix/sysv/linux/raise.c: Adresár alebo súbor neexistuje.
(gdb) bt
#0  __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:51
#1  0x7273342a in __GI_abort () at abort.c:89
#2  0x7304a0ad in __gnu_cxx::__verbose_terminate_handler() () from
/usr/lib/x86_64-linux-gnu/libstdc++.so.6
#3  0x73048066 in ?? () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#4  0x730480b1 in std::terminate() () from
/usr/lib/x86_64-linux-gnu/libstdc++.so.6
#5  0x730482c9 in __cxa_throw () from
/usr/lib/x86_64-linux-gnu/libstdc++.so.6
#6  0x733cb9b2 in qBadAlloc() () from
/usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#7  0x73449c9a in QListData::realloc_grow(int) () from
/usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#8  0x73449d0f in QListData::append(int) () from
/usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#9  0x55654880 in QList::operator+= (this=0x7fffa790,
l=...) at /usr/include/x86_64-linux-gnu/qt5/QtCore/qlist.h:942
#10 0x5573c104 in std::function::operator()(Imap::Mailbox::TreeItemMessage const&) const
(__args#0=..., this=0x7fffa6d0) at /usr/include/c++/6/functional:2127
#11 Imap::Mailbox::threadForeachCallback(std::function, Imap::Mailbox::TreeItemMessage
const&) (message=..., callback=...)
at trojita/src/Imap/Model/ThreadingMsgListModel.cpp:1222
#12 Imap::Mailbox::ThreadingMsgListModel::threadForeach(unsigned int
const&, std::function) const
(this=this@entry=0x55dbb560, root=@0x7fffa73c: 14175, 
root@entry=@0x7fffa73c: , callback=...) at
trojita/src/Imap/Model/ThreadingMsgListModel.cpp:1248
#13 0x55730fcb in
Imap::Mailbox::ThreadingMsgListModel::threadAggregatedFlags
(this=this@entry=0x55dbb560, root=) at
trojita/src/Imap/Model/ThreadingMsgListModel.cpp:1271
#14 0x5573a78c in Imap::Mailbox::ThreadingMsgListModel::data
(this=0x55dbb560, proxyIndex=..., role=963) at
trojita/src/Imap/Model/ThreadingMsgListModel.cpp:307
#15 0x7357dba9 in QSortFilterProxyModel::data(QModelIndex const&, int)
const () from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#16 0x55723d39 in Imap::Mailbox::PrettyMsgListModel::data
(this=, index=..., role=963) at
trojita/src/Imap/Model/PrettyMsgListModel.cpp:175
#17 0x5562786f in QModelIndex::data (arole=963, this=0x7fffac80) at
/usr/include/x86_64-linux-gnu/qt5/QtCore/qabstractitemmodel.h:426
#18 Gui::MsgItemDelegate::itemColor (this=this@entry=0x55c47580, index=...)
at trojita/src/Gui/MsgItemDelegate.cpp:47
#19 0x55627b5d in Gui::MsgItemDelegate::paint (this=0x55c47580,
painter=0x7fffaff0, option=..., index=...) at
trojita/src/Gui/MsgItemDelegate.cpp:89
#20 0x74127b10 in QTreeView::drawRow(QPainter*, QStyleOptionViewItem
const&, QModelIndex const&) const () from
/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
#21 0x7412d597 in QTreeView::drawTree(QPainter*, QRegion const&) const
() from /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
#22 0x741320b6 in QTreeView::paintEvent(QPaintEvent*) () from
/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
#23 0x73ee4278 in QWidget::event(QEvent*) () from
/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
#24 0x73fcca0e in QFrame::event(QEvent*) () from
/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
#25 0x740f3503 in QAbstractItemView::viewportEvent(QEvent*) () from
/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
#26 0x74132f6c in QTreeView::viewportEvent(QEvent*) () from
/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
#27 0x735b9741 in
QCoreApplicationPrivate::sendThroughObjectEventFilters(QObject*, QEvent*) ()
from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#28 0x73e9cb65 in QApplicationPrivate::notify_helper(QObject*, QEvent*)
() from /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
#29 0x73ea4341 in QApplication::notify(QObject*, QEvent*) () from
/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
#30 0x735b99e0 in 

[trojita] [Bug 391718] New: Trojita hangs in infinite loop

[Pali Rohár]

https://bugs.kde.org/show_bug.cgi?id=391718

Bug ID: 391718
   Summary: Trojita hangs in infinite loop
   Product: trojita
   Version: git
  Platform: Other
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: Other
  Assignee: trojita-b...@kde.org
  Reporter: pali.ro...@gmail.com
  Target Milestone: ---

For unknown reasons trojita hangs in infinite loop on following place:

file trojita/src/Imap/Model/ThreadingMsgListModel.cpp
function ThreadingMsgListModel::handleDataChanged

134while (rootCandidate.parent().isValid()) {
135rootCandidate = rootCandidate.parent();
136}

Adding breakpoint on line 137 proved it, while loop is never finished. GUI is
completely freezed.

What I did? Absolutely nothing, just had opened INBOX and waiting for a new
emails.

Here is gdb backtrace.

(gdb) bt
#0  0x55738820 in QModelIndex::parent (this=0x7fffcc60) at
/usr/include/x86_64-linux-gnu/qt5/QtCore/qabstractitemmodel.h:417
#1  Imap::Mailbox::ThreadingMsgListModel::handleDataChanged
(this=0x55dbb410, topLeft=..., bottomRight=...) at
trojita/src/Imap/Model/ThreadingMsgListModel.cpp:134
#2  0x735e595e in QMetaObject::activate(QObject*, int, int, void**) ()
from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#3  0x7365c61c in QAbstractItemModel::dataChanged(QModelIndex const&,
QModelIndex const&, QVector const&) () from
/usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#4  0x55718ccf in Imap::Mailbox::MsgListModel::handleDataChanged
(this=0x55db6a70, topLeft=..., bottomRight=...) at
trojita/src/Imap/Model/MsgListModel.cpp:105
#5  0x735e595e in QMetaObject::activate(QObject*, int, int, void**) ()
from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#6  0x7365c61c in QAbstractItemModel::dataChanged(QModelIndex const&,
QModelIndex const&, QVector const&) () from
/usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#7  0x7365d759 in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#8  0x735e6499 in QObject::event(QEvent*) () from
/usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#9  0x73e9cb8c in QApplicationPrivate::notify_helper(QObject*, QEvent*)
() from /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
#10 0x73ea4341 in QApplication::notify(QObject*, QEvent*) () from
/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
#11 0x735b99e0 in QCoreApplication::notifyInternal2(QObject*, QEvent*)
() from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#12 0x735bc16d in QCoreApplicationPrivate::sendPostedEvents(QObject*,
int, QThreadData*) () from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#13 0x7360dc43 in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#14 0x70b3d7f7 in g_main_context_dispatch () from
/lib/x86_64-linux-gnu/libglib-2.0.so.0
#15 0x70b3da60 in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#16 0x70b3db0c in g_main_context_iteration () from
/lib/x86_64-linux-gnu/libglib-2.0.so.0
#17 0x7360e04f in
QEventDispatcherGlib::processEvents(QFlags) ()
from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#18 0x735b79ca in
QEventLoop::exec(QFlags) () from
/usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#19 0x735c013c in QCoreApplication::exec() () from
/usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#20 0x555c5ce5 in main (argc=, argv=) at
trojita/src/Gui/main.cpp:218

Apparently I cannot debug it as gdb cannot resolve inlined function :-(

(gdb) up
#1  Imap::Mailbox::ThreadingMsgListModel::handleDataChanged
(this=0x55dbb410, topLeft=..., bottomRight=...) at
trojita/src/Imap/Model/ThreadingMsgListModel.cpp:134
134 while (rootCandidate.parent().isValid()) {
(gdb) print rootCandidate
$1 = {r = 0, c = 0, i = 6899, m = 0x55dbb410}
(gdb) print rootCandidate.parent
Cannot take address of method parent.
(gdb) print rootCandidate.parent()
Cannot evaluate function -- may be inlined
(gdb) print rootCandidate.parent().isValid()
Cannot evaluate function -- may be inlined
(gdb) print translated
$2 = {r = 2, c = 0, i = 6900, m = 0x55dbb410}

-- 
You are receiving this mail because:
You are watching all bug changes.

[trojita] [Bug 391710] New: Trojita crash when searching

[Pali Rohár]

https://bugs.kde.org/show_bug.cgi?id=391710

Bug ID: 391710
   Summary: Trojita crash when searching
   Product: trojita
   Version: git
  Platform: Other
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: Other
  Assignee: trojita-b...@kde.org
  Reporter: pali.ro...@gmail.com
  Target Milestone: ---

Trojita periodically crash when trying search in raw mode (":=HEADER "header"
"value"). Following assert fails:

ASSERT: "it != ptrToInternal.constEnd()" in file
trojita/src/Imap/Model/ThreadingMsgListModel.cpp, line 1476

Here is gdb stacktrace:

#0  __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:51
#1  0x7273342a in __GI_abort () at abort.c:89
#2  0x733d0561 in QMessageLogger::fatal(char const*, ...) const () from
/usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#3  0x733cba2e in qt_assert(char const*, char const*, int) () from
/usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#4  0x557360d5 in Imap::Mailbox::ThreadingMsgListModel::applySort
(this=this@entry=0x55dbace0) at
trojita/src/Imap/Model/ThreadingMsgListModel.cpp:1476
#5  0x55736edf in
Imap::Mailbox::ThreadingMsgListModel::searchSortPreferenceImplementation
(this=this@entry=0x55dbace0, searchConditions=...,
criterium=Imap::Mailbox::ThreadingMsgListModel::SORT_NONE, 
order=) at
trojita/src/Imap/Model/ThreadingMsgListModel.cpp:1421
#6  0x55737b48 in Imap::Mailbox::ThreadingMsgListModel::applyThreading
(this=this@entry=0x55dbace0, mapping=...) at
trojita/src/Imap/Model/ThreadingMsgListModel.cpp:996
#7  0x55738451 in Imap::Mailbox::ThreadingMsgListModel::wantThreading
(this=this@entry=0x55dbace0,
skipSortSearch=skipSortSearch@entry=Imap::Mailbox::ThreadingMsgListModel::AUTO_SORT_SEARCH)
at trojita/src/Imap/Model/ThreadingMsgListModel.cpp:590
#8  0x557396b9 in
Imap::Mailbox::ThreadingMsgListModel::slotSortingAvailable
(this=0x55dbace0, uids=...) at
trojita/src/Imap/Model/ThreadingMsgListModel.cpp:834
#9  0x735e595e in QMetaObject::activate(QObject*, int, int, void**) ()
from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#10 0x55776e22 in Imap::Mailbox::SortTask::sortingAvailable
(this=this@entry=0x5ac558e0, _t1=...) at
trojita/build/Imap_automoc.dir/moc_SortTask_4YBJI63NCCXEIP.cpp:155
#11 0x5576f4f0 in Imap::Mailbox::SortTask::handleStateHelper
(this=0x5ac558e0, resp=0x56cb8500) at
trojita/src/Imap/Tasks/SortTask.cpp:135
#12 0x55715daf in Imap::Mailbox::Model::responseReceived
(this=this@entry=0x55d9cbc0, it=..., it@entry=...) at
trojita/src/Imap/Model/Model.cpp:221
#13 0x557163de in Imap::Mailbox::Model::responseReceived
(this=0x55d9cbc0, parser=0x55ff0ac0) at
trojita/src/Imap/Model/Model.cpp:163
#14 0x735e6499 in QObject::event(QEvent*) () from
/usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#15 0x73e9cb8c in QApplicationPrivate::notify_helper(QObject*, QEvent*)
() from /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
#16 0x73ea4341 in QApplication::notify(QObject*, QEvent*) () from
/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
#17 0x735b99e0 in QCoreApplication::notifyInternal2(QObject*, QEvent*)
() from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#18 0x735bc16d in QCoreApplicationPrivate::sendPostedEvents(QObject*,
int, QThreadData*) () from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#19 0x7360dc43 in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#20 0x70b3d7f7 in g_main_context_dispatch () from
/lib/x86_64-linux-gnu/libglib-2.0.so.0
#21 0x70b3da60 in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#22 0x70b3db0c in g_main_context_iteration () from
/lib/x86_64-linux-gnu/libglib-2.0.so.0
#23 0x7360e04f in
QEventDispatcherGlib::processEvents(QFlags) ()
from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#24 0x735b79ca in
QEventLoop::exec(QFlags) () from
/usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#25 0x735c013c in QCoreApplication::exec() () from
/usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#26 0x555c5ce5 in main (argc=, argv=) at
trojita/src/Gui/main.cpp:218

-- 
You are receiving this mail because:
You are watching all bug changes.

[trojita] [Bug 391382] Trojita with watchFolders=all or watchFolders=subscribed crash

[Pali Rohár]

https://bugs.kde.org/show_bug.cgi?id=391382

--- Comment #2 from Pali Rohár <pali.ro...@gmail.com> ---
(In reply to Jan Kundrát from comment #1)
> Strange -- I cannot reproduce that. Can you please:
> 
> - ensure that you have debugging symbols and that Q_ASSERT are not being
> compiled out,

Now I recompiled with -DCMAKE_BUILD_TYPE=Debug, it is enough?

> - tell me what your cache settings are,

Remember messages for 30 days

> - tell me the connection method you use,

Local process, dovecot/imap over ssh.

> - specify your version of Qt?

5.7.1 from Debian Stable.


After recompilation with -DCMAKE_BUILD_TYPE=Debug I see in gdb:

ASSERT: "mailbox" in file trojita/src/Imap/Model/Model.cpp, line 757

Thread 1 "trojita" received signal SIGABRT, Aborted.
__GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:51
51  ../sysdeps/unix/sysv/linux/raise.c: Adresár alebo súbor neexistuje.
(gdb) bt
#0  __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:51
#1  0x727333fa in __GI_abort () at abort.c:89
#2  0x733d0561 in QMessageLogger::fatal(char const*, ...) const () from
/usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#3  0x733cba2e in qt_assert(char const*, char const*, int) () from
/usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#4  0x5570e0af in Imap::Mailbox::Model::askForChildrenOfMailbox
(this=0x55d64c90, index=..., cacheMode=Imap::Mailbox::LOAD_CACHED_IS_OK) at
trojita/src/Imap/Model/Model.cpp:757
#5  0x5577a707 in Imap::Mailbox::Model::qt_static_metacall
(_o=, _c=, _id=, _a=)
at trojita/build/Imap_automoc.dir/moc_Model_GWT5ZYT4XQA7JO.cpp:324
#6  0x735e6499 in QObject::event(QEvent*) () from
/usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#7  0x73e9cb8c in QApplicationPrivate::notify_helper(QObject*, QEvent*)
() from /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
#8  0x73ea4341 in QApplication::notify(QObject*, QEvent*) () from
/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
#9  0x735b99e0 in QCoreApplication::notifyInternal2(QObject*, QEvent*)
() from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#10 0x735bc16d in QCoreApplicationPrivate::sendPostedEvents(QObject*,
int, QThreadData*) () from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#11 0x7360dc43 in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#12 0x70b3d7f7 in g_main_context_dispatch () from
/lib/x86_64-linux-gnu/libglib-2.0.so.0
#13 0x70b3da60 in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#14 0x70b3db0c in g_main_context_iteration () from
/lib/x86_64-linux-gnu/libglib-2.0.so.0
#15 0x7360e04f in
QEventDispatcherGlib::processEvents(QFlags) ()
from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#16 0x735b79ca in
QEventLoop::exec(QFlags) () from
/usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#17 0x735c013c in QCoreApplication::exec() () from
/usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#18 0x555c5ce5 in main (argc=, argv=) at
trojita/src/Gui/main.cpp:218

-- 
You are receiving this mail because:
You are watching all bug changes.

[trojita] [Bug 391382] New: Trojita with watchFolders=all or watchFolders=subscribed crash

[Pali Rohár]

https://bugs.kde.org/show_bug.cgi?id=391382

Bug ID: 391382
   Summary: Trojita with watchFolders=all or
watchFolders=subscribed crash
   Product: trojita
   Version: git
  Platform: Debian stable
OS: Linux
Status: UNCONFIRMED
  Severity: crash
  Priority: NOR
 Component: Other
  Assignee: trojita-b...@kde.org
  Reporter: pali.ro...@gmail.com
  Target Milestone: ---

When Notifications is set either to Subscribed Mailboxes
(watchFolders=subscribed ) or All Mailboxes (watchFolders=all), then Trojita
crash at every startup. Option INBOX only is working fine without crash.

Here is backtrace output from gdb:

#0  0x73047930 in __dynamic_cast () from
/usr/lib/x86_64-linux-gnu/libstdc++.so.6
#1  0x556fa16f in Imap::Mailbox::Model::askForChildrenOfMailbox
(this=0x55d30c00, index=..., cacheMode=Imap::Mailbox::LOAD_CACHED_IS_OK) at
trojita/src/Imap/Model/Model.cpp:753
#2  0x5575fb27 in Imap::Mailbox::Model::qt_static_metacall
(_o=, _c=, _id=, _a=) at trojita/build/Imap_automoc.dir/moc_Model_GWT5ZYT4XQA7JO.cpp:324
#3  0x735e7499 in QObject::event(QEvent*) () from
/usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#4  0x73e9db8c in QApplicationPrivate::notify_helper(QObject*, QEvent*)
() from /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
#5  0x73ea5341 in QApplication::notify(QObject*, QEvent*) () from
/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
#6  0x735ba9e0 in QCoreApplication::notifyInternal2(QObject*, QEvent*)
() from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#7  0x735bd16d in QCoreApplicationPrivate::sendPostedEvents(QObject*,
int, QThreadData*) () from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#8  0x7360ec43 in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#9  0x70b3e7f7 in g_main_context_dispatch () from
/lib/x86_64-linux-gnu/libglib-2.0.so.0
#10 0x70b3ea60 in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#11 0x70b3eb0c in g_main_context_iteration () from
/lib/x86_64-linux-gnu/libglib-2.0.so.0
#12 0x7360f04f in
QEventDispatcherGlib::processEvents(QFlags) ()
from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#13 0x735b89ca in
QEventLoop::exec(QFlags) () from
/usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#14 0x735c113c in QCoreApplication::exec() () from
/usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#15 0x555c55e8 in main (argc=, argv=) at
trojita/src/Gui/main.cpp:218

And here output from valgrind:

==9394== Invalid read of size 8
==9394==at 0x996292D: __dynamic_cast (in
/usr/lib/x86_64-linux-gnu/libstdc++.so.6.0.22)
==9394==by 0x2AE16E:
Imap::Mailbox::Model::askForChildrenOfMailbox(QModelIndex const&,
Imap::Mailbox::CacheLoadingMode) (Model.cpp:753)
==9394==by 0x313B26: Imap::Mailbox::Model::qt_static_metacall(QObject*,
QMetaObject::Call, int, void**) (moc_Model_GWT5ZYT4XQA7JO.cpp:324)
==9394==by 0x96B1498: QObject::event(QEvent*) (in
/usr/lib/x86_64-linux-gnu/libQt5Core.so.5.7.1)
==9394==by 0x89C3B8B: QApplicationPrivate::notify_helper(QObject*, QEvent*)
(in /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5.7.1)
==9394==by 0x89CB340: QApplication::notify(QObject*, QEvent*) (in
/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5.7.1)
==9394==by 0x96849DF: QCoreApplication::notifyInternal2(QObject*, QEvent*)
(in /usr/lib/x86_64-linux-gnu/libQt5Core.so.5.7.1)
==9394==by 0x968716C: QCoreApplicationPrivate::sendPostedEvents(QObject*,
int, QThreadData*) (in /usr/lib/x86_64-linux-gnu/libQt5Core.so.5.7.1)
==9394==by 0x96D8C42: ??? (in
/usr/lib/x86_64-linux-gnu/libQt5Core.so.5.7.1)
==9394==by 0xBE537F6: g_main_context_dispatch (in
/lib/x86_64-linux-gnu/libglib-2.0.so.0.5000.3)
==9394==by 0xBE53A5F: ??? (in
/lib/x86_64-linux-gnu/libglib-2.0.so.0.5000.3)
==9394==by 0xBE53B0B: g_main_context_iteration (in
/lib/x86_64-linux-gnu/libglib-2.0.so.0.5000.3)
==9394==  Address 0x217e65a0 is 0 bytes inside a block of size 128 free'd
==9394==at 0x4C2D2DB: operator delete(void*) (in
/usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==9394==by 0x2AC99D:
qDeleteAll::const_iterator>
(qalgorithms.h:323)
==9394==by 0x2AC99D: qDeleteAll >
(qalgorithms.h:331)
==9394==by 0x2AC99D:
Imap::Mailbox::Model::replaceChildMailboxes(Imap::Mailbox::TreeItemMailbox*,
QVector const&) (Model.cpp:481)
==9394==by 0x2B0BDF: Imap::Mailbox::Model::finalizeList(Imap::Parser*,
Imap::Mailbox::TreeItemMailbox*) (Model.cpp:385)
==9394==by 0x2FA743:
Imap::Mailbox::ListChildMailboxesTask::handleStateHelper(Imap::Responses::State
const*) (ListChildMailboxesTask.cpp:96)
==9394==by 0x2B5073:
Imap::Mailbox::Model::responseReceived(QMap::iterator) (Model.cpp:221)
==9394==by 0x2B566D: 

[partitionmanager] [Bug 384321] Mess with encoding in kpmcore

[Pali Rohár]

https://bugs.kde.org/show_bug.cgi?id=384321

--- Comment #5 from Pali Rohár <pali.ro...@gmail.com> ---
Block device name is just ordinary file. In most cases people use only ascii
characters (because non-ascii names are lot of times broken in CLI or GUI
tools), but there is no restrictions for 8bit. On linux you can call mknod and
create block device on file system with any file name (all 8 bit characters
expect slash and nul are allowed)...

Now looking at QFile::decodeName() implementation (it is inlined in header file
qfile.h) and there is #ifdef. On linux it just call QString::fromLocal8Bit()
and on other platforms it doing some UTF-8 normalization.

So this filename stuff depends on you, if you are going to write application
which is linux-only then QString::fromLocal8Bit() is for sure enough (as
QFile::decodeName() is doing this on linux). But if you are going to support
also other systems (Mac OS, Windows, ...) then it is really a good idea to use
Qt functions which deals with those platform dependent problems...

But problem with LC_ALL=C is a real problem for linux, because all application
which uses wide characters (in C it is wchar_t and in C++ it is also
std::wstring) uses encoding specified in LC_CTYPE (resp. LC_ALL). And "C" means
7bit ASCII. Not Latin1, not UTF-8. And both C and C++ libraries uses LC_CTYPE
for converting char*/std::string to wchar_t*/std::wstring according to LC_CTYPE
(resp. LC_ALL). So with restriction to 7bit ASCII (as "C" is ASCII) you just
kill whole UTF-8/Unicode support.

To test current encoding you can use this simple C program:

  #include 
  #include 
  #include 
  int main() { setlocale(LC_CTYPE,""); puts(nl_langinfo(CODESET)); return 0; }

Also it is important that some programs works in UTF-8 independently of how is
LC_ALL configured (e.g mkudffs when is called with --utf8 param, but there are
probably others too). And so for these programs it is needed to use fromUtf8
and toUtf8, not fromLocal8bit/toLocal8bit (as those functions decode/encode
according to LC_CTYPE/LC_ALL).

-- 
You are receiving this mail because:
You are watching all bug changes.

[partitionmanager] [Bug 384321] Mess with encoding in kpmcore

[Pali Rohár]

https://bugs.kde.org/show_bug.cgi?id=384321

Pali Rohár <pali.ro...@gmail.com> changed:

   What|Removed |Added

 Resolution|FIXED   |---
 Status|RESOLVED|REOPENED

--- Comment #3 from Pali Rohár <pali.ro...@gmail.com> ---
> -if 
> (QFileInfo(QString::fromUtf8(storage.device())).canonicalFilePath() == 
> canonicalDeviceNode ) {
> +if 
> (QFileInfo(QString::fromLocal8Bit(storage.device())).canonicalFilePath() == 
> canonicalDeviceNode ) {

This does not look like a correct change. As I wrote in first comment, for
decoding and encoding file names QFile::decodeName() resp. QFile::decodeName()
should be used:

http://doc.qt.io/qt-5/qfile.html#decodeName
http://doc.qt.io/qt-5/qfile.html#encodeName

And when starting external program with env LC_ALL=C then
QString::fromLocal8Bit() and toLocal8Bit() is also wrong as LC_ALL=C define
ASCII encoding. So some equivalent of "to 7bit ASCII" and "from 7bit ASCII"
should be used (seems that QString does not provide ASCII transformation
functions yet).

-- 
You are receiving this mail because:
You are watching all bug changes.

[trojita] [Bug 386860] mailto: URL with attachments

[Pali Rohár]

https://bugs.kde.org/show_bug.cgi?id=386860

Pali Rohár <pali.ro...@gmail.com> changed:

   What|Removed |Added

 CC||pali.ro...@gmail.com

--- Comment #1 from Pali Rohár <pali.ro...@gmail.com> ---
> but looks like mailto: URL with attachments isn't supported yet.

That is because mailto: URI itslef does not support attachments, see:
https://tools.ietf.org/html/rfc6068

See also this unfinished patch also with security problems:
https://gerrit.vesnicky.cesnet.cz/r/#/c/869/

-- 
You are receiving this mail because:
You are watching all bug changes.

[partitionmanager] [Bug 384321] New: Mess with encoding in kpmcore

[Pali Rohár]

https://bugs.kde.org/show_bug.cgi?id=384321

Bug ID: 384321
   Summary: Mess with encoding in kpmcore
   Product: partitionmanager
   Version: unspecified
  Platform: Other
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: andr...@stikonas.eu
  Reporter: pali.ro...@gmail.com
  Target Milestone: ---

Created attachment 107670
  --> https://bugs.kde.org/attachment.cgi?id=107670=edit
$ git grep -E 'Latin1|Utf8'

Look at attched output from command: git grep -E 'Latin1|Utf8'

There is a big mess with encodings, on some places is used Latin1 on other
places UTF-8 without reason.

For converting filename stored in char* to QString should be used function
QFile::decodeName(). And for reverse operation -- conversion of filename from
QString to char* should be used function QFile::encodeName()

http://doc.qt.io/qt-5/qfile.html#decodeName
http://doc.qt.io/qt-5/qfile.html#encodeName

For converting other locale/system dependent settings (like env variables,
command line arguments or stdin/stdout), QString methods toLocal8Bit() and
fromLocal8Bit() should be used.

http://doc.qt.io/qt-5/qstring.html#toLocal8Bit
http://doc.qt.io/qt-5/qstring.html#fromLocal8Bit

Methods toUtf8() resp. toLatin1() should be used only in case callee C function
has defined API that char* must be in UTF-8 resp. in Latin1.

For ASCII strings, both UTF-8 and Latin1 encoding doing exaclty same things.
But problem happen for non-ASCII strings, when Unicode internationalization is
widely used. Properly written Unicode applications should not have this
problem.

Please recheck where UTF-8 resp. Latin1 functions are correctly used and where
decodeName() and fromLocal8Bit() should be instead.

-- 
You are receiving this mail because:
You are watching all bug changes.

[partitionmanager] [Bug 383451] [PATCH] Add basic support for UDF filesystem

[Pali Rohár]

https://bugs.kde.org/show_bug.cgi?id=383451

--- Comment #3 from Pali Rohár <pali.ro...@gmail.com> ---
(In reply to Andrius Štikonas from comment #2)
> (In reply to Pali Rohár from comment #0)
> 
> > Problems:
> > * Check for max label length is incorrect too as it depends on characters
> >   itself in label.
> 
> Maybe I should restrict it to 63 for now and refactor later? 63 is not that
> little, should be enough for most use cases. Then we can extend API to check
> a particular label and not just length.

It is not so simple. Some background:

Label is stored as UDF Logical Volume Identifier (--lvid) which has above
restrictions. But due to compatibility reasons with Linux systems with older
blkid library/binaries, it is needed to store label also into UDF Volume
Identifier (--vid) which has restriction of 30 resp. 15 characters (again 15
only if label contains at least one Unicode codepoint above U+FF). Moreover
mkudffs prior to version 1.1 is able to process --lvid and --vid params which
contains only ASCII characters. Other non-ASCII character cause creating
damaged file system.

-- 
You are receiving this mail because:
You are watching all bug changes.

[partitionmanager] [Bug 383451] [PATCH] Add basic support for UDF filesystem

[Pali Rohár]

https://bugs.kde.org/show_bug.cgi?id=383451

--- Comment #1 from Pali Rohár <pali.ro...@gmail.com> ---
Note that incorrect MBR means that filesystem is not detected by Windows
systems which is a big problem as choice for UDF is multiplatform support.

-- 
You are receiving this mail because:
You are watching all bug changes.

[partitionmanager] [Bug 383451] New: [PATCH] Add basic support for UDF filesystem

[Pali Rohár]

https://bugs.kde.org/show_bug.cgi?id=383451

Bug ID: 383451
   Summary: [PATCH] Add basic support for UDF filesystem
   Product: partitionmanager
   Version: unspecified
  Platform: Other
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: andr...@stikonas.eu
  Reporter: pali.ro...@gmail.com
  Target Milestone: ---

Created attachment 107251
  --> https://bugs.kde.org/attachment.cgi?id=107251=edit
[PATCH] Add basic support for UDF filesystem

For reading UDF label and UUID is needed blkid >= 2.30. For creating new
UDF filesystem is needed mkudffs binary from the udftools package.

When creating new UDF fileystem, revision 2.01 for hard disk media is used.
Therefore it is not possible to use it for optical (or other) medias.

Problems:
* Check for min and max capacity is incorrect as it depends on logical
  (sector) size of the disk.
* Check for max label length is incorrect too as it depends on characters
  itself in label.
* Specifying label is not working yet as FileSystem::create() does not get
  label parameter.
* UDF filesystem should be used on unpartitioned disk, without MBR or GPT
  and spanning whole disk, but KDE Partition Manager does not support it.
* When MBR is used, MBR partition id should be 0x07, but currently it is
  incorrect 0x83. See: https://serverfault.com/a/829172 (same for GPT)

-- 
You are receiving this mail because:
You are watching all bug changes.

[kopete] [Bug 378012] Crash when going online

[Pali Rohár]

https://bugs.kde.org/show_bug.cgi?id=378012

Pali Rohár <pali.ro...@gmail.com> changed:

   What|Removed |Added

 Resolution|BACKTRACE   |INVALID
 Status|NEEDSINFO   |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

[kopete] [Bug 378012] Crash when going online

[Pali Rohár]

https://bugs.kde.org/show_bug.cgi?id=378012

Pali Rohár <pali.ro...@gmail.com> changed:

   What|Removed |Added

 CC||pali.ro...@gmail.com
 Status|UNCONFIRMED |NEEDSINFO
 Resolution|--- |BACKTRACE

--- Comment #1 from Pali Rohár <pali.ro...@gmail.com> ---
(In reply to OlafLostViking from comment #0)
> The crash does not seem to be reproducible.

This is really hard to debug...

> Thread 1 (Thread 0x7f863da52840 (LWP 2184)):
> [KCrash Handler]
> #6  0x7f863cbe16a0 in  () at /usr/lib/libkopete.so.4
> #7  0x7f863cbe157f in  () at /usr/lib/libkopete.so.4
> #8  0x7f863cbe15e9 in  () at /usr/lib/libkopete.so.4

Also there are missing function names to do any investigation. Without debug
symbols such report is unusable.

-- 
You are receiving this mail because:
You are watching all bug changes.

[trojita] [Bug 377382] Unable to log in -- IMAP alert

[Pali Rohár]

https://bugs.kde.org/show_bug.cgi?id=377382

--- Comment #11 from Pali Rohár <pali.ro...@gmail.com> ---
On Thursday 09 March 2017 07:24:37 Thomas Lübking wrote:
> https://bugs.kde.org/show_bug.cgi?id=377382
> 
> --- Comment #10 from Thomas Lübking <thomas.luebk...@gmail.com> ---
> Evolution has OAUTH2 support - it's not exaclty proprietary (that wouldn't 
> make
> sense) but it's certainly far from unobjected, see
> https://en.wikipedia.org/wiki/OAuth#Controversy

OAUTH2 RFC does not specify exact steps for implementation and specially
how to exchange and generate tokens. That RFC is too vague for such
things, but show examples...

Basically we can say that for usage of OAUTH2 you need proprietary
extension + try to interpret vague RFC specification for OAUTH2.

And IIRC more vendors needs different client implementation of OAUTH2...

> Leaving the complexity concerns aside, there's certainly usecase for such
> system, but it's not "your MUA wants to log into your IMAP server" but more
> like "webservice foo wants to use your google drive" which you can then
> individually permit and revoke that permission w/o having to expose (and thus
> later change) your credentials.
> 
> Also I frankly wonder how google secures the OAUTH2 access of MUAs -
> "something™" will have to open a 2nd channel to google and have it ask for
> confirmation.

>From my understanding of OAUTH2: this protocol is not designed for open
source MUAs, but for servers which must not disclose their parts of
authentication/token material. Or for closed source application which
must contains data which must not be disclosed to user.

If you want to use your own application (which is fully under your
control) for OAUTH2, then you send just plain text token in protocol
(e.g. IMAP) to server (which is equivalent of user+password). And via
other channel (HTTP) you need to request for such token.

Google's implementation: On Google console website you need to register
your application. You will receive public and private tokens for your
application. Application tokens then will be used for requesting user
tokens (via web page! with user input). This token is IIRC with infinite
validity but Google can revoke it at any time. And with this (your
private) token you can request via HTTP REST API for time-limited
authentication token, which is then used in application protocol for
login (e.g. in IMAP). Note that for requesting authentication token you
just need to know your private user token and public application. So
once your private user token will be stolen anybody can login to your
account (if know application).

Which means private application token must be kept secret and to
correctly use OAUTH2 either application must be closed-source and had
obfuscated private application token in binary (and it cannot leak!) or
every user generates your own application token (this is only one
solution how to properly implement OAUTH2 for open source application).
Server needs to have ability to revoke application token at any time.

> If "someone" is your local client that opens a browser with a google link, I
> could imagine this is easily broken (by the local client never opening a
> visible webpage and just clicking "ok" for the user...) - so the client would
> have to tell the user "please log into your google account and allow me"

This is used for requesting user tokens and caller needs to know private
application token. In case whole service is running on server, then user
does not see private application token, it is exchanged between Google
server and service server.

And if correctly implemented, this step is needed only once. From
requested token you can request (now without application private parts)
time-limited access token which then you will use in IMAP (or other
protocol) for authentication.

Basically server can track for which protocols is application token (and
derived tokens) applicable.

If you think more about it you should realise that it is too
complicated, hard to properly implement and it has zero benefits for
desktop applications (comparing to plain text user+password auth).

Security throw obscurity and obfuscating plain text auth in user's
applications binaries does not work. And you can perfectly implement
time-limited protocol specified access via user+passwords also on server
without need for such thing like OAUTH2.

So I see absolutely no reason why desktop email client should implement
such thing like OAUTH2. It does not bring any security (comparing to
plain text), plain text token can be stolen in same way as plain text
passwords and proper implementation needs for user to generate
application tokens via some Google console service.

If you want to use more secure authentication then look for
SCRAM-SHA-256 which does not send any plain text information via (IMAP)
application protocol

[trojita] [Bug 377382] Unable to log in -- IMAP alert

[Pali Rohár]

https://bugs.kde.org/show_bug.cgi?id=377382

--- Comment #4 from Pali Rohár <pali.ro...@gmail.com> ---
On Wednesday 08 March 2017 14:45:20 Thomas Lübking wrote:
> https://bugs.kde.org/show_bug.cgi?id=377382
> 
> --- Comment #2 from Thomas Lübking <thomas.luebk...@gmail.com> ---
> Go to that URL and follow the instructions; gmail only permits OAUTH2 by
> default, other credential systems are considered "insecure" and you need to
> explicitly allow this.

Note that "insecure" is just by some retarded Google definition. OAUTH2
itself has same security as plain text password authentication.

Both plain text password and plain text OAUTH2 tokens can be stolen in
the same way.

> Notice that "insecure" simply means "you need to let trojitá know the account
> password".
>

-- 
You are receiving this mail because:
You are watching all bug changes.

[kopete] [Bug 231941] Kopete crashed on closing a chat window

[Pali Rohár]

https://bugs.kde.org/show_bug.cgi?id=231941

Pali Rohár <pali.ro...@gmail.com> changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|UNCONFIRMED |RESOLVED

--- Comment #4 from Pali Rohár <pali.ro...@gmail.com> ---
closing per previous comment

-- 
You are receiving this mail because:
You are watching all bug changes.

[kopete] [Bug 376733] Started a conversation, pushed the OTR button, then suddenly Kopete crashed.

[Pali Rohár]

https://bugs.kde.org/show_bug.cgi?id=376733

Pali Rohár <pali.ro...@gmail.com> changed:

   What|Removed |Added

 CC||pali.ro...@gmail.com
 Resolution|--- |DUPLICATE
 Status|UNCONFIRMED |RESOLVED

--- Comment #1 from Pali Rohár <pali.ro...@gmail.com> ---
Already fixed in Kopete 1.11.0

*** This bug has been marked as a duplicate of bug 349596 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[kopete] [Bug 349596] Kopete crashes after OTR keys generation

[Pali Rohár]

https://bugs.kde.org/show_bug.cgi?id=349596

Pali Rohár <pali.ro...@gmail.com> changed:

   What|Removed |Added

 CC||andre.ock...@xs4all.nl

--- Comment #12 from Pali Rohár <pali.ro...@gmail.com> ---
*** Bug 376733 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[kopete] [Bug 371269] No (obvious) way to end or restart a private conversation

[Pali Rohár]

https://bugs.kde.org/show_bug.cgi?id=371269

Pali Rohár <pali.ro...@gmail.com> changed:

   What|Removed |Added

 Resolution|--- |INVALID
 Status|UNCONFIRMED |NEEDSINFO

--- Comment #14 from Pali Rohár <pali.ro...@gmail.com> ---
I will close this bug as invalid as buttons are there and their visibility is
related to some KDE settings, not to Kopete.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kopete] [Bug 371269] No (obvious) way to end or restart a private conversation

[Pali Rohár]

https://bugs.kde.org/show_bug.cgi?id=371269

Pali Rohár <pali.ro...@gmail.com> changed:

   What|Removed |Added

 Status|NEEDSINFO   |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

[kopete] [Bug 371269] No (obvious) way to end or restart a private conversation

[Pali Rohár]

https://bugs.kde.org/show_bug.cgi?id=371269

--- Comment #13 from Pali Rohár <pali.ro...@gmail.com> ---
It is not by default and it is some (central?) default KDE settings. Also linux
distributions provides their own defaults, so maybe this is reason...

-- 
You are receiving this mail because:
You are watching all bug changes.

[kopete] [Bug 371269] No (obvious) way to end or restart a private conversation

[Pali Rohár]

https://bugs.kde.org/show_bug.cgi?id=371269

--- Comment #11 from Pali Rohár <pali.ro...@gmail.com> ---
Seems to hide main menu in chat window. Press CTRL+M to toggle visibility of
main menu. And then you should have Tools menu in main menu.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kopete] [Bug 376348] CVE 2017-5593: User Impersonation Vulnerability in Jabber protocol

[Pali Rohár]

https://bugs.kde.org/show_bug.cgi?id=376348

Pali Rohár <pali.ro...@gmail.com> changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
   Version Fixed In||16.12.3
 Resolution|--- |FIXED
  Latest Commit||https://commits.kde.org/kop
   ||ete/6243764c4fd0985320d4a10
   ||b48051cc418d584ad

--- Comment #2 from Pali Rohár <pali.ro...@gmail.com> ---
Git commit 6243764c4fd0985320d4a10b48051cc418d584ad by Pali Rohár.
Committed on 11/02/2017 at 12:24.
Pushed by pali into branch 'Applications/16.12'.

Fix CVE 2017-5593 (User Impersonation Vulnerability) in jabber protocol
FIXED-IN: 16.12.3

A  +52   -0protocols/jabber/libiris/patches/01_cve_2017-5593.patch
M  +9-5protocols/jabber/libiris/src/xmpp/xmpp-im/xmpp_tasks.cpp

https://commits.kde.org/kopete/6243764c4fd0985320d4a10b48051cc418d584ad

-- 
You are receiving this mail because:
You are watching all bug changes.

[kopete] [Bug 376348] CVE 2017-5593: User Impersonation Vulnerability in Jabber protocol

[Pali Rohár]

https://bugs.kde.org/show_bug.cgi?id=376348

Pali Rohár <pali.ro...@gmail.com> changed:

   What|Removed |Added

 Status|UNCONFIRMED |CONFIRMED
 Ever confirmed|0   |1

--- Comment #1 from Pali Rohár <pali.ro...@gmail.com> ---
Kopete versions since 1.10.80, part of KDE 16.11.80 are vulnerable.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kopete] [Bug 376348] New: CVE 2017-5593: User Impersonation Vulnerability in Jabber protocol

[Pali Rohár]

https://bugs.kde.org/show_bug.cgi?id=376348

Bug ID: 376348
   Summary: CVE 2017-5593: User Impersonation Vulnerability in
Jabber protocol
   Product: kopete
   Version: unspecified
  Platform: Other
OS: All
Status: UNCONFIRMED
  Severity: critical
  Priority: NOR
 Component: Jabber Plugin
  Assignee: kopete-bugs-n...@kde.org
  Reporter: pali.ro...@gmail.com
  Target Milestone: ---

Kopete since 16.11.80 is vulnerable for CVE 2017-5593 (User Impersonation
Vulnerability) as it uses same XMPP library as Psi (libiris).

http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2017-5593
http://seclists.org/oss-sec/2017/q1/373

Fix for libiris:
https://github.com/psi-im/iris/pull/47/commits/02e976d4426a1319a7af7d26d7aba9d8c6077570

-- 
You are receiving this mail because:
You are watching all bug changes.

[kopete] [Bug 374960] Add support for XEP-0313 Message Archive Management (MAM) on XMPP accounts to Kopete log viewer

[Pali Rohár]

https://bugs.kde.org/show_bug.cgi?id=374960

Pali Rohár <pali.ro...@gmail.com> changed:

   What|Removed |Added

  Component|History Plugin  |Jabber Plugin
 Status|UNCONFIRMED |CONFIRMED
 CC||pali.ro...@gmail.com
 Ever confirmed|0   |1

--- Comment #1 from Pali Rohár <pali.ro...@gmail.com> ---
It is already listed as idea for GSoC:
https://community.kde.org/GSoC/2017/Ideas#Kopete

For XEP-0136: Message Archiving there are also initial patches:
https://git.reviewboard.kde.org/r/111361/

-- 
You are receiving this mail because:
You are watching all bug changes.

[trojita] [Bug 374830] Context menu on e-mail address should offer "Copy e-mail address"

[Pali Rohár]

https://bugs.kde.org/show_bug.cgi?id=374830

--- Comment #3 from Pali Rohár <pali.ro...@gmail.com> ---
(In reply to Jan Kundrát from comment #2)
> (In reply to Pali Rohár from comment #1)
> > Now when I see this link, it should be changed to
> > "mailto:?To=joe%20%3c...@example.com%3E; as X-Trojita-DisplayName means to
> > create new email with header X-Trojita-DisplayName -- which is incorrect.
> 
> These links should never leave Trojita, so it's up to us to construct them
> in whatever way we like.

Yes. But now when Trojita supports mailto uris correctly, there is no need to
use custom mailto headers which indicate display name and standard mailto: way
can be used...

-- 
You are receiving this mail because:
You are watching all bug changes.

[trojita] [Bug 374830] Context menu on e-mail address should offer "Copy e-mail address"

[Pali Rohár]

https://bugs.kde.org/show_bug.cgi?id=374830

Pali Rohár <pali.ro...@gmail.com> changed:

   What|Removed |Added

 CC||pali.ro...@gmail.com

--- Comment #1 from Pali Rohár <pali.ro...@gmail.com> ---
(In reply to Robert Kratky from comment #0)
> mailto:j...@example.com?X-Trojita-DisplayName=Joe

Now when I see this link, it should be changed to
"mailto:?To=joe%20%3c...@example.com%3E; as X-Trojita-DisplayName means to
create new email with header X-Trojita-DisplayName -- which is incorrect.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kontact] [Bug 337876] kontact immediately crashes (SIGSEGV) on startup

[Pali Rohár]

https://bugs.kde.org/show_bug.cgi?id=337876

--- Comment #12 from Pali Rohár <pali.ro...@gmail.com> ---
Hi Denis! As I wrote in comment #8 this is problem with ABI incompatibility. If
you compiled Kontact plugins against old KontactInterface and then used plugins
in new Kontact it crash. If you recompiled plugins against current running
version, then it worked fine.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kopete] [Bug 368340] Build fails with mediastreamer 2.14

[Pali Rohár]

https://bugs.kde.org/show_bug.cgi?id=368340

--- Comment #8 from Pali Rohár <pali.ro...@gmail.com> ---
(In reply to David Geiger from comment #7)
> We have now the same issue on Mageia6.

Problem is because external mediastreamer library changed its API.

I have not find any information about it yet, nor how to port old applications.

Proposed patch pass NULL pointer to some functions, but again I did not find
anything about it, that this is really correct solution.

Passing NULL on "random" place without understood 'WHY?' is wrong solution.

I would suggest to report bug to mediastreamer project, that they broke API and
existing application... And without providing any information what to do...

-- 
You are receiving this mail because:
You are watching all bug changes.

[kopete] [Bug 356102] Wrong URL for Jabber server list

[Pali Rohár]

https://bugs.kde.org/show_bug.cgi?id=356102

Pali Rohár <pali.ro...@gmail.com> changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED
  Latest Commit||https://commits.kde.org/kop
   ||ete/472ed51dcef188e1d8b4c94
   ||6c99f6f48c2216385
   Version Fixed In||16.12

--- Comment #4 from Pali Rohár <pali.ro...@gmail.com> ---
Git commit 472ed51dcef188e1d8b4c946c99f6f48c2216385 by Pali Rohár.
Committed on 27/11/2016 at 16:25.
Pushed by pali into branch 'Applications/16.12'.

Update URL of jabber server list

Use https://xmpp.net/services.php instead of old https://xmpp.net/services.xml
URL which does not work anymore.
FIXED-IN: 16.12

M  +1-1protocols/jabber/ui/jabberchooseserver.cpp

https://commits.kde.org/kopete/472ed51dcef188e1d8b4c946c99f6f48c2216385

-- 
You are receiving this mail because:
You are watching all bug changes.

[kopete] [Bug 140366] Jabber plugin sends tag with unformated messages

[Pali Rohár]

https://bugs.kde.org/show_bug.cgi?id=140366

Pali Rohár <pali.ro...@gmail.com> changed:

   What|Removed |Added

 CC||pali.ro...@gmail.com

--- Comment #12 from Pali Rohár <pali.ro...@gmail.com> ---
Is this problem still there?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kopete] [Bug 349596] Kopete crashes after OTR keys generation

[Pali Rohár]

https://bugs.kde.org/show_bug.cgi?id=349596

Pali Rohár <pali.ro...@gmail.com> changed:

   What|Removed |Added

  Latest Commit||https://commits.kde.org/kop
   ||ete/15579ddcf34ad04bf190a18
   ||9b670f62c3796c057
   Version Fixed In||16.12
 Status|NEEDSINFO   |RESOLVED
 Resolution|WAITINGFORINFO  |FIXED

--- Comment #11 from Pali Rohár <pali.ro...@gmail.com> ---
Git commit 15579ddcf34ad04bf190a189b670f62c3796c057 by Pali Rohár.
Committed on 27/11/2016 at 15:55.
Pushed by pali into branch 'Applications/16.12'.

Fix crash after OTR plugin generates key

Function OtrlChatInterface::replayStoredMessages() had wrong logic to check
if there is still some postponed message waiting for processing.
FIXED-IN: 16.12

M  +1-1plugins/otr/otrlchatinterface.cpp

https://commits.kde.org/kopete/15579ddcf34ad04bf190a189b670f62c3796c057

-- 
You are receiving this mail because:
You are watching all bug changes.

[kopete] [Bug 372886] kopete crashes when OTR session is initiated without key

[Pali Rohár]

https://bugs.kde.org/show_bug.cgi?id=372886

Pali Rohár <pali.ro...@gmail.com> changed:

   What|Removed |Added

 Status|NEEDSINFO   |RESOLVED
 Resolution|BACKTRACE   |DUPLICATE

--- Comment #5 from Pali Rohár <pali.ro...@gmail.com> ---
Thank you, now I found where is a problem! For now marking as duplicate of bug
#349596.

*** This bug has been marked as a duplicate of bug 349596 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[kopete] [Bug 349596] Kopete crashes after OTR keys generation

[Pali Rohár]

https://bugs.kde.org/show_bug.cgi?id=349596

Pali Rohár <pali.ro...@gmail.com> changed:

   What|Removed |Added

 CC||olaf.the.lost.viking@gmail.
   ||com

--- Comment #10 from Pali Rohár <pali.ro...@gmail.com> ---
*** Bug 372886 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[kopete] [Bug 304029] Kopete: OTR plugin inserts whitespaces in when in XMPP-MUC (Multiuser chat)

[Pali Rohár]

https://bugs.kde.org/show_bug.cgi?id=304029

Pali Rohár <pali.ro...@gmail.com> changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED

--- Comment #2 from Pali Rohár <pali.ro...@gmail.com> ---
OTR plugin should not be active in multi user chats. If you still see this
behaviour, please provide exact steps for reproducing. Closing now.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kopete] [Bug 269463] OTR auth request with bad charset

[Pali Rohár]

https://bugs.kde.org/show_bug.cgi?id=269463

--- Comment #6 from Pali Rohár <pali.ro...@gmail.com> ---
I think we should use UTF-8 on all places.

Kopete::Message store message body in QString which is Unicode. Kopete plugins
should access messages in UTF-8 and if some Kopete protocol use different
encoding it should encode/decode Kopete::Messages itself in protocol code.

If OTR layer does not specify in which encoding should be messages we have two
options:

1) Allow user to configure encoding per contact (like ICQ protocol for ICQ
contacts)

2) Use UTF-8 which is widely used on lot of places

3) For incoming messages try UTF-8 decoder and if fails then fallback to Latin1

But I really suggest to use UTF-8 for both encoding and decoding.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kopete] [Bug 321071] OTR not interoperable with Pidgin

[Pali Rohár]

https://bugs.kde.org/show_bug.cgi?id=321071

Pali Rohár <pali.ro...@gmail.com> changed:

   What|Removed |Added

 Resolution|WAITINGFORINFO  |FIXED
 Status|NEEDSINFO   |RESOLVED

--- Comment #2 from Pali Rohár <pali.ro...@gmail.com> ---
This should be fixed since KDE 4.12 when Kopete got support for libotr 4.0

-- 
You are receiving this mail because:
You are watching all bug changes.

[kopete] [Bug 181342] Random crash - With backtrace

[Pali Rohár]

https://bugs.kde.org/show_bug.cgi?id=181342

Pali Rohár <pali.ro...@gmail.com> changed:

   What|Removed |Added

 CC||pali.ro...@gmail.com
 Resolution|BACKTRACE   |UNMAINTAINED
 Status|NEEDSINFO   |RESOLVED

--- Comment #2 from Pali Rohár <pali.ro...@gmail.com> ---
libotr.so.2 is supported by Kopete anymore, so closing.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kopete] [Bug 372886] kopete crashes when OTR session is initiated without key

[Pali Rohár]

https://bugs.kde.org/show_bug.cgi?id=372886

--- Comment #3 from Pali Rohár <pali.ro...@gmail.com> ---
In KDE crash window is button to install missing debug symbols. And yes
kopete-dbg package is needed too.

When you are going to debug kopete in gdb, start kopete with --nofork, so gdb
will have access to kopete process:

$ gdb -ex r -ex bt --args kopete --nofork

-- 
You are receiving this mail because:
You are watching all bug changes.

[kopete] [Bug 356102] Wrong URL for Jabber server list

[Pali Rohár]

https://bugs.kde.org/show_bug.cgi?id=356102

--- Comment #3 from Pali Rohár <pali.ro...@gmail.com> ---
I found same problem reported in Miranda bug tracker:
http://trac.miranda-ng.org/ticket/1215

And here is specified that new list is provided by:
https://xmpp.net/services.php

Seems it is working, but I have not find any information about that service...
Looks like other software is using that URL, so we can do that in Kopete too...

http://trac.miranda-ng.org/changeset/16538
https://github.com/jitsi/jitsi/commit/cd759e8154da715175e86f893059b38a16708c88

-- 
You are receiving this mail because:
You are watching all bug changes.

[kopete] [Bug 231941] Kopete crashed on closing a chat window

[Pali Rohár]

https://bugs.kde.org/show_bug.cgi?id=231941

Pali Rohár <pali.ro...@gmail.com> changed:

   What|Removed |Added

 CC||pali.ro...@gmail.com

--- Comment #2 from Pali Rohár <pali.ro...@gmail.com> ---
It is reproducable?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kopete] [Bug 360384] Kopete crashes on exit. Every time, all the time.

[Pali Rohár]

https://bugs.kde.org/show_bug.cgi?id=360384

Pali Rohár <pali.ro...@gmail.com> changed:

   What|Removed |Added

 Resolution|--- |WAITINGFORINFO
 Status|CONFIRMED   |NEEDSINFO

--- Comment #13 from Pali Rohár <pali.ro...@gmail.com> ---
marking as waiting for info

-- 
You are receiving this mail because:
You are watching all bug changes.

[kopete] [Bug 362535] Kopete 1.9.0 somtimes won't encrypt even though the GUI says otherwise

[Pali Rohár]

https://bugs.kde.org/show_bug.cgi?id=362535

Pali Rohár <pali.ro...@gmail.com> changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED

--- Comment #20 from Pali Rohár <pali.ro...@gmail.com> ---
There is no break reported, so I'm marking this bug back as Fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kopete] [Bug 372886] kopete crashes when OTR session is initiated without key

[Pali Rohár]

https://bugs.kde.org/show_bug.cgi?id=372886

Pali Rohár <pali.ro...@gmail.com> changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDSINFO
 Resolution|--- |BACKTRACE
 CC||pali.ro...@gmail.com

--- Comment #1 from Pali Rohár <pali.ro...@gmail.com> ---
Please attach stack trace with debug symbols.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kopete] [Bug 362535] Kopete 1.9.0 somtimes won't encrypt even though the GUI says otherwise

[Pali Rohár]

https://bugs.kde.org/show_bug.cgi?id=362535

--- Comment #19 from Pali Rohár <pali.ro...@gmail.com> ---
If you want, you can use Ubuntu live CD (= do not need to install) and add this
PPA repository: https://launchpad.net/~pali/+archive/ubuntu/kopete

It contains daily builds from kopete git repository for all supported Ubuntu
versions.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kopete] [Bug 362535] Kopete 1.9.0 somtimes won't encrypt even though the GUI says otherwise

[Pali Rohár]

https://bugs.kde.org/show_bug.cgi?id=362535

--- Comment #17 from Pali Rohár <pali.ro...@gmail.com> ---
(In reply to OlafLostViking from comment #15)
> Okay, managed to get it to work (Kopete in GIT master/Neon cannot connect to
> kdetalk.net anymore, so I created another account which worked).
> 
> The problem is still there (packages from today, minutes ago).

>From which git commit?

> Closing the
> window will break all further encrytion (even when I choose to restart the
> OTR session!). Only a restart of kopete and establishing a new OTR session
> makes encryption work again.

Can you specify steps to reproduce?

When I start OTR session with jabber contact, send message, close window, open
window again, then session stay active and new sent messages are also
encrypted.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kopete] [Bug 362535] Kopete 1.9.0 somtimes won't encrypt even though the GUI says otherwise

[Pali Rohár]

https://bugs.kde.org/show_bug.cgi?id=362535

--- Comment #16 from Pali Rohár <pali.ro...@gmail.com> ---
(In reply to OlafLostViking from comment #14)
> But will
> your fix just correct the GUI or will it prevent Kopete/libotr from ending
> the OTR encryption just when closing a window? The latter would be
> preferable, of course ;)

It will fix GUI status icon. Also if there is active OTR session (handled in
libotr) it is restored in re-opened chat window.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kopete] [Bug 229526] "The contact X has added you to his/her contact list" always appears on startup

[Pali Rohár]

https://bugs.kde.org/show_bug.cgi?id=229526

Pali Rohár <pali.ro...@gmail.com> changed:

   What|Removed |Added

 Status|NEEDSINFO   |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

[kopete] [Bug 362535] Kopete 1.9.0 somtimes won't encrypt even though the GUI says otherwise

[Pali Rohár]

https://bugs.kde.org/show_bug.cgi?id=362535

--- Comment #13 from Pali Rohár <pali.ro...@gmail.com> ---
Fix is in master branch. Please recheck that it is really working correctly
now. If is no problem I will merge fixes into Applications/16.12 branch.

The whole problem is in unfriendy libotr library with poorly designed API. It
did not report any encryption error and passed messages unencrypted... I do not
know if I could trust libotr library anymore.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kopete] [Bug 362535] Kopete 1.9.0 somtimes won't encrypt even though the GUI says otherwise

[Pali Rohár]

https://bugs.kde.org/show_bug.cgi?id=362535

Pali Rohár <pali.ro...@gmail.com> changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
   Version Fixed In||16.12
  Latest Commit||http://commits.kde.org/kope
   ||te/19957f9324a5ae45bcb1479f
   ||1bb017efa77d0aa7
 Resolution|--- |FIXED

--- Comment #12 from Pali Rohár <pali.ro...@gmail.com> ---
Git commit 19957f9324a5ae45bcb1479f1bb017efa77d0aa7 by Pali Rohár.
Committed on 21/11/2016 at 23:31.
Pushed by pali into branch 'master'.

When updating OTR GUI icon properly set OTR instance tag

Without configured instance tag libotr library does not encrypt sent
messages and moreover it even does not report any error that message was
not encrypted.

This should fix a bug when OTR "encrypted" icon is shown in GUI and libotr
itself does not want to encrypt messages. It happened when Kopete window
with active OTR session was closed and after that again opened.
FIXED-IN: 16.12

M  +4-0plugins/otr/otrlchatinterface.cpp

http://commits.kde.org/kopete/19957f9324a5ae45bcb1479f1bb017efa77d0aa7

-- 
You are receiving this mail because:
You are watching all bug changes.

[kopete] [Bug 362535] Kopete 1.9.0 somtimes won't encrypt even though the GUI says otherwise

[Pali Rohár]

https://bugs.kde.org/show_bug.cgi?id=362535

Pali Rohár <pali.ro...@gmail.com> changed:

   What|Removed |Added

 CC||thoma...@gmail.com

--- Comment #11 from Pali Rohár <pali.ro...@gmail.com> ---
*** Bug 274099 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[kopete] [Bug 274099] Kopete OTR leaks unencrypted messages

[Pali Rohár]

https://bugs.kde.org/show_bug.cgi?id=274099

Pali Rohár <pali.ro...@gmail.com> changed:

   What|Removed |Added

 CC||pali.ro...@gmail.com
 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #3 from Pali Rohár <pali.ro...@gmail.com> ---


*** This bug has been marked as a duplicate of bug 362535 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[kopete] [Bug 371269] No (obvious) way to end or restart a private conversation

[Pali Rohár]

https://bugs.kde.org/show_bug.cgi?id=371269

--- Comment #9 from Pali Rohár <pali.ro...@gmail.com> ---
In this case please report new bug with whole stack trace, so we can
investigate it.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kopete] [Bug 372183] Encrypted messages show up in ~/.xsession-errors

[Pali Rohár]

https://bugs.kde.org/show_bug.cgi?id=372183

Pali Rohár <pali.ro...@gmail.com> changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||pali.ro...@gmail.com
 Resolution|--- |DOWNSTREAM

--- Comment #1 from Pali Rohár <pali.ro...@gmail.com> ---
Those are just debug output outputs for area 14000 (Kopete). You can
enable/disable debug output in program kdebugdialog.

IIRC it is configured in kdebugrc config file and Linux distributions provides
its own config files. If you have enabled those debug outputs for Kopete by
default (verify via kdebugdialog), then please report this problem to your
Linux distribution.

Closing now as downstream.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kopete] [Bug 362535] Kopete 1.9.0 somtimes won't encrypt even though the GUI says otherwise

[Pali Rohár]

https://bugs.kde.org/show_bug.cgi?id=362535

Pali Rohár <pali.ro...@gmail.com> changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |CONFIRMED

--- Comment #10 from Pali Rohár <pali.ro...@gmail.com> ---
(In reply to OlafLostViking from comment #9)
> ===> This is the important step. Closing the window triggers the problem.
> 5. close chat window in kopete

Thank you very much! Without it I was not able to reprocude it.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kopete] [Bug 362535] Kopete 1.9.0 somtimes won't encrypt even though the GUI says otherwise

[Pali Rohár]

https://bugs.kde.org/show_bug.cgi?id=362535

Pali Rohár <pali.ro...@gmail.com> changed:

   What|Removed |Added

 Resolution|--- |WAITINGFORINFO
 Status|UNCONFIRMED |NEEDSINFO

--- Comment #8 from Pali Rohár <pali.ro...@gmail.com> ---
Hi! Please provide exact steps how to reproduce this bug. I tried to debug it,
but I have not seen any unencreypted messages sent via Jabber protocol.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kopete] [Bug 371269] No (obvious) way to end or restart a private conversation

[Pali Rohár]

https://bugs.kde.org/show_bug.cgi?id=371269

--- Comment #6 from Pali Rohár <pali.ro...@gmail.com> ---
But not main window. Window in which you are writing conversation... Window
where is your active OTR.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kopete] [Bug 371269] No (obvious) way to end or restart a private conversation

[Pali Rohár]

https://bugs.kde.org/show_bug.cgi?id=371269

--- Comment #3 from Pali Rohár <pali.ro...@gmail.com> ---
Looks very strange. Please provide screenshot, I really cannot believe that
there is no Conversation or Format or Tools menu...

Also via Settings you should be able to configure toolbars and add here OTR
icon (if you do not have it already).

-- 
You are receiving this mail because:
You are watching all bug changes.

[kopete] [Bug 354473] Cannot login to Google account

[Pali Rohár]

https://bugs.kde.org/show_bug.cgi?id=354473

Pali Rohár <pali.ro...@gmail.com> changed:

   What|Removed |Added

  Latest Commit||http://commits.kde.org/kope
   ||te/3bff188483fd2ee01bb8310a
   ||511e8cc9a4808d22
 Resolution|--- |FIXED
   Version Fixed In||16.12
 Status|CONFIRMED   |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

[kopete] [Bug 368340] Build fails with mediastreamer 2.14

[Pali Rohár]

https://bugs.kde.org/show_bug.cgi?id=368340

--- Comment #5 from Pali Rohár <pali.ro...@gmail.com> ---
Those are probably only compile errors... I can review changes.

Real testing will be harder as I have older libphone version which do not
produce compile errors and it is working fine (testing kopete vs kopete). Also
my automated builds of kopete on all supported and future ubuntu versions
passe, see:
https://launchpad.net/~pali/+archive/ubuntu/kopete/+packages

So verification if compilation is really fixed must be done by somebody already
affected by this bug. But I have no problem of merging this patch to kopete
master as this I believe will be straightforward.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kopete] [Bug 368340] Build fails with mediastreamer 2.14

[Pali Rohár]

https://bugs.kde.org/show_bug.cgi?id=368340

Pali Rohár <pali.ro...@gmail.com> changed:

   What|Removed |Added

 Status|UNCONFIRMED |CONFIRMED
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are watching all bug changes.

[kopete] [Bug 354473] Cannot login to Google account

[Pali Rohár]

https://bugs.kde.org/show_bug.cgi?id=354473

--- Comment #29 from Pali Rohár <pali.ro...@gmail.com> ---
You could use Live CD or USB pendrive for testing...

But OK, nobody complained about that patch set, so I'm going to push it to git
master...

-- 
You are receiving this mail because:
You are watching all bug changes.

[kopete] [Bug 371269] No (obvious) way to end or restart a private conversation

[Pali Rohár]

https://bugs.kde.org/show_bug.cgi?id=371269

Pali Rohár <pali.ro...@gmail.com> changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDSINFO
 CC||pali.ro...@gmail.com
 Resolution|--- |WAITINGFORINFO

--- Comment #1 from Pali Rohár <pali.ro...@gmail.com> ---
In Kopete 1.10.1 I see "Tools->OTR Settings->End OTR Session" option. I tested
and both Start and End options are working correctly.

Please retest with last version of Kopete if problem is still there for you or
not.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kopete] [Bug 229526] "The contact X has added you to his/her contact list" always appears on startup

[Pali Rohár]

https://bugs.kde.org/show_bug.cgi?id=229526

Pali Rohár <pali.ro...@gmail.com> changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
 CC||pali.ro...@gmail.com
 Status|UNCONFIRMED |NEEDSINFO

--- Comment #6 from Pali Rohár <pali.ro...@gmail.com> ---
closing per previous comment.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kopete] [Bug 365092] Frequent disconnects on fast networks

[Pali Rohár]

https://bugs.kde.org/show_bug.cgi?id=365092

Pali Rohár <pali.ro...@gmail.com> changed:

   What|Removed |Added

 Resolution|--- |INVALID
 Status|UNCONFIRMED |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

[kopete] [Bug 370450] incorrect launch command for skype accounts

[Pali Rohár via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=370450

--- Comment #3 from Pali Rohár <pali.ro...@gmail.com> ---
Probably problem is really in localized strings... But localization files are
not part of Kopete.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kopete] [Bug 338891] SASL Autenthication error while connecting to Jabber-Server

[Pali Rohár via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=338891

Pali Rohár <pali.ro...@gmail.com> changed:

   What|Removed |Added

 Resolution|WAITINGFORINFO  |FIXED
 Status|NEEDSINFO   |RESOLVED

--- Comment #4 from Pali Rohár <pali.ro...@gmail.com> ---
SCRAM-SHA-1 is already supported, closing.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kopete] [Bug 368340] Build fails with mediastreamer 2.14

[Pali Rohár via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=368340

Pali Rohár <pali.ro...@gmail.com> changed:

   What|Removed |Added

 CC||pali.ro...@gmail.com

--- Comment #3 from Pali Rohár <pali.ro...@gmail.com> ---
Hi Fabian Vogt! Can you cleanup your patch and post it to
git.reviewboard.kde.org to kopete group?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kopete] [Bug 370450] incorrect launch command for skype accounts

[Pali Rohár via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=370450

Pali Rohár <pali.ro...@gmail.com> changed:

   What|Removed |Added

 CC||pali.ro...@gmail.com

--- Comment #1 from Pali Rohár <pali.ro...@gmail.com> ---
Default is "skype" with small 's'. Do you have localized KDE?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kopete] [Bug 354473] Cannot login to Google account

[Pali Rohár via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=354473

Pali Rohár <pali.ro...@gmail.com> changed:

   What|Removed |Added

 Status|REOPENED|CONFIRMED

--- Comment #27 from Pali Rohár <pali.ro...@gmail.com> ---
@george: If you do not want to compile Kopete, you can try it on Ubuntu/Kubuntu
distributions. Daily kopete packages from git with that X-OAUTH2 patch are in
repository: https://launchpad.net/~pali/+archive/ubuntu/kopete/+packages

-- 
You are receiving this mail because:
You are watching all bug changes.

[kopete] [Bug 354473] Cannot login to Google account

[Pali Rohár via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=354473

--- Comment #25 from Pali Rohár <pali.ro...@gmail.com> ---
Support for X-OAuth2 is in kopete branch jabber-xoauth2, diff uploaded to
reviewboard: https://git.reviewboard.kde.org/r/129239/

-- 
You are receiving this mail because:
You are watching all bug changes.

[kopete] [Bug 354473] Cannot login to Google account

[Pali Rohár via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=354473

Pali Rohár <pali.ro...@gmail.com> changed:

   What|Removed |Added

   Version Fixed In|16.12   |
  Latest Commit|http://commits.kde.org/kope |
   |te/3bff188483fd2ee01bb8310a |
   |511e8cc9a4808d22|

-- 
You are receiving this mail because:
You are watching all bug changes.

[kopete] [Bug 354473] Cannot login to Google account

[Pali Rohár via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=354473

Pali Rohár <pali.ro...@gmail.com> changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are watching all bug changes.

[kopete] [Bug 354473] Cannot login to Google account

[Pali Rohár via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=354473

Pali Rohár <pali.ro...@gmail.com> changed:

   What|Removed |Added

   Version Fixed In||16.12
 Resolution|--- |FIXED
 Status|UNCONFIRMED |RESOLVED
  Latest Commit||http://commits.kde.org/kope
   ||te/3bff188483fd2ee01bb8310a
   ||511e8cc9a4808d22

--- Comment #24 from Pali Rohár <pali.ro...@gmail.com> ---
Git commit 3bff188483fd2ee01bb8310a511e8cc9a4808d22 by Pali Rohár.
Committed on 21/10/2016 at 16:44.
Pushed by pali into branch 'jabber-xoauth2'.

Add support for X-OAuth2 authentication in Jabber protocol

Based on Psi demo code from:
https://github.com/psi-im/iris/issues/35
https://github.com/psi-plus/main/blob/master/patches/dev/xoauth2-support-demo.diff

REVIEW: 129239
FIXED-IN: 16.12

M  +3-0CMakeLists.txt
M  +4-4protocols/CMakeLists.txt
M  +5-1protocols/jabber/CMakeLists.txt
M  +4-1protocols/jabber/jabberaccount.cpp
M  +40   -0protocols/jabber/jabberclient.cpp
M  +3-0protocols/jabber/jabberclient.h
M  +98   -0protocols/jabber/ui/dlgjabbereditaccountwidget.ui
A  +76   -0protocols/jabber/ui/dlgjabberxoauth2.cpp [License: GPL
(v2+)]
A  +43   -0protocols/jabber/ui/dlgjabberxoauth2.h [License: GPL (v2+)]
A  +161  -0protocols/jabber/ui/dlgxoauth2.ui
M  +18   -1protocols/jabber/ui/jabbereditaccountwidget.cpp
M  +1-0protocols/jabber/ui/jabbereditaccountwidget.h
A  +331  -0protocols/jabber/xoauth2provider.cpp [License: GPL (v2+)]
A  +25   -0protocols/jabber/xoauth2provider.h [License: GPL (v2+)]

http://commits.kde.org/kopete/3bff188483fd2ee01bb8310a511e8cc9a4808d22

-- 
You are receiving this mail because:
You are watching all bug changes.

[kopete] [Bug 314272] Kopete disconnects from Jabber when sending text outside of BOM

[Pali Rohár via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=314272

Pali Rohár <pali.ro...@gmail.com> changed:

   What|Removed |Added

 Resolution|FIXED   |DUPLICATE

--- Comment #12 from Pali Rohár <pali.ro...@gmail.com> ---


*** This bug has been marked as a duplicate of bug 225747 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[kopete] [Bug 225747] kopete does not encode utf xml properly when sending to jabber (xmpp) server

[Pali Rohár via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=225747

--- Comment #9 from Pali Rohár <pali.ro...@gmail.com> ---
*** Bug 314272 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[kopete] [Bug 225747] kopete does not encode utf xml properly when sending to jabber (xmpp) server

[Pali Rohár via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=225747

Pali Rohár <pali.ro...@gmail.com> changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED
   Version Fixed In||16.08.1
  Latest Commit||http://commits.kde.org/kope
   ||te/f23d6ccc7a7f542059c3956d
   ||64d912a34584723e

--- Comment #8 from Pali Rohár <pali.ro...@gmail.com> ---
Git commit f23d6ccc7a7f542059c3956d64d912a34584723e by Pali Rohár.
Committed on 15/08/2016 at 15:58.
Pushed by pali into branch 'Applications/16.08'.

jabber: Workaround bug in QtXML: Fix xmlToString when QDomElement contains
Unicode characters above 0x

Upstream:
https://github.com/psi-im/iris/commit/8612bc340421087cf0ebfd426661ff22f7351270

See also discussion:
https://github.com/psi-im/iris/pull/44
https://github.com/psi-im/iris/pull/43
https://github.com/psi-im/iris/issues/42
https://github.com/psi-im/iris/issues/13
https://bugreports.qt.io/browse/QTBUG-25291
Related: bug 314272
FIXED-IN: 16.08.1

A  +19   -0protocols/jabber/libiris/patches/01_qtxml_unicode.patch
M  +8-0protocols/jabber/libiris/src/xmpp/xmpp-core/xmlprotocol.cpp

http://commits.kde.org/kopete/f23d6ccc7a7f542059c3956d64d912a34584723e

-- 
You are receiving this mail because:
You are watching all bug changes.

[kopete] [Bug 314272] Kopete disconnects from Jabber when sending text outside of BOM

[Pali Rohár via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=314272

Pali Rohár <pali.ro...@gmail.com> changed:

   What|Removed |Added

  Latest Commit||http://commits.kde.org/kope
   ||te/f23d6ccc7a7f542059c3956d
   ||64d912a34584723e
   Version Fixed In||16.08.1
 Resolution|DUPLICATE   |FIXED

--- Comment #11 from Pali Rohár <pali.ro...@gmail.com> ---
Git commit f23d6ccc7a7f542059c3956d64d912a34584723e by Pali Rohár.
Committed on 15/08/2016 at 15:58.
Pushed by pali into branch 'Applications/16.08'.

jabber: Workaround bug in QtXML: Fix xmlToString when QDomElement contains
Unicode characters above 0x

Upstream:
https://github.com/psi-im/iris/commit/8612bc340421087cf0ebfd426661ff22f7351270

See also discussion:
https://github.com/psi-im/iris/pull/44
https://github.com/psi-im/iris/pull/43
https://github.com/psi-im/iris/issues/42
https://github.com/psi-im/iris/issues/13
https://bugreports.qt.io/browse/QTBUG-25291
Related: bug 225747
FIXED-IN: 16.08.1

A  +19   -0protocols/jabber/libiris/patches/01_qtxml_unicode.patch
M  +8-0protocols/jabber/libiris/src/xmpp/xmpp-core/xmlprotocol.cpp

http://commits.kde.org/kopete/f23d6ccc7a7f542059c3956d64d912a34584723e

-- 
You are receiving this mail because:
You are watching all bug changes.

[kopete] [Bug 225747] kopete does not encode utf xml properly when sending to jabber (xmpp) server

[Pali Rohár via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=225747

--- Comment #7 from Pali Rohár <pali.ro...@gmail.com> ---
This is bug in QtXml... My workaround for libiris:
https://github.com/psi-im/iris/pull/44

-- 
You are receiving this mail because:
You are watching all bug changes.

[kopete] [Bug 225747] kopete does not encode utf xml properly when sending to jabber (xmpp) server

[Pali Rohár via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=225747

Pali Rohár <pali.ro...@gmail.com> changed:

   What|Removed |Added

 CC||char...@kde.org

--- Comment #6 from Pali Rohár <pali.ro...@gmail.com> ---
*** Bug 314272 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[kopete] [Bug 314272] Kopete disconnects from Jabber when sending text outside of BOM

[Pali Rohár via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=314272

Pali Rohár <pali.ro...@gmail.com> changed:

   What|Removed |Added

 Resolution|UPSTREAM|DUPLICATE

--- Comment #10 from Pali Rohár <pali.ro...@gmail.com> ---
For sure this is same bug as #225747... I can reproduce it.

*** This bug has been marked as a duplicate of bug 225747 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[kopete] [Bug 279269] Kopete history plugin escapes quote and ampersand characters

[Pali Rohár via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=279269

Pali Rohár <pali.ro...@gmail.com> changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 Resolution|--- |DUPLICATE
 CC||pali.ro...@gmail.com

--- Comment #4 from Pali Rohár <pali.ro...@gmail.com> ---


*** This bug has been marked as a duplicate of bug 269097 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[kopete] [Bug 269097] [PATCH] Some html entities are not correctly displayed in history

[Pali Rohár via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=269097

Pali Rohár <pali.ro...@gmail.com> changed:

   What|Removed |Added

 CC||m...@sevik.ru

--- Comment #4 from Pali Rohár <pali.ro...@gmail.com> ---
*** Bug 279269 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[kopete] [Bug 225747] kopete does not encode utf xml properly when sending to jabber (xmpp) server

[Pali Rohár via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=225747

Pali Rohár <pali.ro...@gmail.com> changed:

   What|Removed |Added

 Ever confirmed|0   |1
 CC||pali.ro...@gmail.com
 Status|UNCONFIRMED |CONFIRMED

--- Comment #5 from Pali Rohár <pali.ro...@gmail.com> ---
Confirmed, unicode characters in XML should be encoded as full codepoints, not
as UTF-16 surrogate pairs. Surrogate pairs are invalid in XML, so server should
really disconnect you.

See: http://www.w3.org/TR/REC-xml/#charsets

Character Range

[2]   Char   ::=   #x9 | #xA | #xD | [#x20-#xD7FF] |
[#xE000-#xFFFD] | [#x1-#x10]/* any Unicode character, excluding the
surrogate blocks, FFFE, and . */

-- 
You are receiving this mail because:
You are watching all bug changes.

[kopete] [Bug 234167] Text doesn't wrap correctly in kopete chat window

[Pali Rohár via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=234167

Pali Rohár <pali.ro...@gmail.com> changed:

   What|Removed |Added

 Status|UNCONFIRMED |CONFIRMED
 Ever confirmed|0   |1
 CC||pali.ro...@gmail.com

--- Comment #3 from Pali Rohár <pali.ro...@gmail.com> ---
On that place is animated icon when sending message. After message is sent icon
disappear. This looks like a problem that background under that icon is not
rendered again after icon disappear... I have no idea where is problem (maybe
it is something in KDE/Qt libraries).

-- 
You are receiving this mail because:
You are watching all bug changes.

[kopete] [Bug 365092] Frequent disconnects on fast networks

[Pali Rohár via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365092

Pali Rohár <pali.ro...@gmail.com> changed:

   What|Removed |Added

 CC||pali.ro...@gmail.com

--- Comment #1 from Pali Rohár <pali.ro...@gmail.com> ---
Hi! Kopete uses libiris library for communication with jabber server. If you
think that problem is related with low level parts of jabber protocol (like
socket, network connection or parsing jabber xml parts), then please report it
to libiris project: https://github.com/psi-im/iris

-- 
You are receiving this mail because:
You are watching all bug changes.

[kopete] [Bug 272855] kopete fails to connect after network connection is switched to vpnc

[Pali Rohár via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=272855

Pali Rohár <pali.ro...@gmail.com> changed:

   What|Removed |Added

 Resolution|--- |INVALID
 Status|UNCONFIRMED |RESOLVED
 CC||pali.ro...@gmail.com

--- Comment #4 from Pali Rohár <pali.ro...@gmail.com> ---
Hi! This is not a problem with Kopete, but with your VPN software which does
set routing correctly. I'm not goint to add any hacks into Kopete just because
some VPN softwares are broken... I will close this bug as invalid Kopete
project. Rather report problem to your VPN software.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kopete] [Bug 365016] it is impossible to enter the credentials for the jabber transport

[Pali Rohár via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365016

Pali Rohár <pali.ro...@gmail.com> changed:

   What|Removed |Added

 CC||pali.ro...@gmail.com

--- Comment #1 from Pali Rohár <pali.ro...@gmail.com> ---
Sorry but linked pictures cannot be shown. In future attach all materials to
bugzilla and not link to external services which can trash data...

Anyway, from your description it looks like a problem from bug 331705 which was
fixed in Kopete version 1.9.0. Can you verify it?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kopete] [Bug 362535] Kopete 1.9.0 somtimes won't encrypt even though the GUI says otherwise

[Pali Rohár via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=362535

--- Comment #6 from Pali Rohár <pali.ro...@gmail.com> ---
(In reply to OlafLostViking from comment #5)
> Since the dropdown in the bug report form isn't up to date either (latest is
> 1.7.2),

Thats bugzilla configuration... and I have no idea how to change it...

> I wonder if Kopete is still being maintained or if it's dead: Are
> there any developers left

Kopete is still maintained, there are few developers around. KF5 port is work
in progress, jabber library periodically updated and when I have time I also
fixing some bugs... I would say it is not dead, just not heavily developed as
10 years ago.

-- 
You are receiving this mail because:
You are watching all bug changes.

[bugs.kde.org] [Bug 359603] Incorrect and useless From header in emails generated by KDE Bugzilla

[Pali Rohár via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=359603

--- Comment #47 from Pali Rohár <pali.ro...@gmail.com> ---
On Wednesday 18 May 2016 09:27:25 Ben Cooksley via KDE Bugzilla wrote:
> https://bugs.kde.org/show_bug.cgi?id=359603
> 
> --- Comment #46 from Ben Cooksley <bcooks...@kde.org> ---
> This will be my very final correspondence on this issue.
> 
> In regards to email standards, they're not relevant here. What
> commonly used email providers dictate as being required is relevant,
> as what people care about is getting their email in a readable form.
> The RFCs and other material are just a guideline towards that. Oh,
> and DMARC is an RFC, so it's part of the standards. GMail, followed
> by Yahoo are our top destinations for email delivery. So they set
> the rules.

Your words basically means: "I do not care about anybody except Gmail & 
Yahoo providers which set and dictate rules how emails could work". 
Sorry, but in open community and for free & open source projects, I 
cannot accept this statement.

If you are doing such thing, please explicitly write to KDE webpages:
We are not supporting email service and appreciate standards anymore. We 
only supports Gmail & Yahoo services and due to our limits we ignore all 
requests for supporting standard email service. Our users are restricted 
to use Gmail or Yahoo otherwise our service will not work correctly.

If you are *not* doing such thing, you cannot mark this report as 
INVALID. As INVALID means "we do not care about non Gmail users".

So I really would like to know what is current state. I really cannot 
accept community which declare themselves as free & open source 
software, but follow big corporations which "set the rules".

> In regards to the solutions you proposed, they either:
> a) Impacted upon the reliability of Bugzilla service; or
> b) Significantly increased the maintenance burden Sysadmin would face
> to maintain Bugzilla. And we have enough maintenance workload as it
> stands. Plus we'd have to author the change in the first place, and
> Bugzilla is written in Perl.

If you need I can help with Perl, this is something which I know.

I proposed solutions, because nobody else proposed anything. And I 
wanted to see this bug fixed. So I did everything which I could.

> And in case you are wondering - every other bug tracking system out
> there, including vanilla Bugzilla, follows the behaviour we follow
> now. Our previous behaviour was a hack, added in many, many years
> ago, and which is not able to be continued with, due to the issues
> noted previously.
> 
> This issue is far from being ignored. It has been looked into and
> discussed here for a very long time. The behaviour the system now
> follows is known, and is the desired and correct behaviour.
> 
> I have no idea why your workflow requires / demands filtering based
> on commenter/reporter email address (in which case, may I suggest
> headers in the email which Bugzilla includes), but it is no longer
> something we can accommodate using the From field in an email.

Reason is quite obvious. Every and I'm sure every one email client show 
3 important headers to user: From, To and Subject. Lot of email clients 
(and those web based too) have some index view, where is list of emails, 
e.g. clickable one email per line and on that line show again only 
From/To and Subject (sometimes also Date). And based on this information 
user open/select email.

Email headers From and To are there for 20+ years and they are not going 
to be changed. All existing email software is based on them and once you 
start rewriting them or mangling, you just broke email support...

And I'm using this information in From, To and Subject headers to 
quickly filter emails and mark what is important and what not. Also for 
searching for comments from specific people, etc...



And problem via total nonsense in From header

"From: via KDE Bugzilla <bugzilla_nore...@kde.org>"

is still there and did not hear anybody how and when to fix it. In 
comment 10 you wrote that this is when somebody does entered name at 
all. Should I interpret your last comment, that you are ignoring also 
this problem?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kopete] [Bug 361732] Carbons support

[Pali Rohár via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361732

Pali Rohár <pali.ro...@gmail.com> changed:

   What|Removed |Added

 Status|UNCONFIRMED |CONFIRMED
 CC||pali.ro...@gmail.com
 Ever confirmed|0   |1

--- Comment #1 from Pali Rohár <pali.ro...@gmail.com> ---
Patches for such feature are really welcome!

-- 
You are receiving this mail because:
You are watching all bug changes.

[kopete] [Bug 363317] Login or password incorrect when password len greter 8 chars

[Pali Rohár via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=363317

Pali Rohár <pali.ro...@gmail.com> changed:

   What|Removed |Added

 CC||pali.ro...@gmail.com
 Resolution|--- |DUPLICATE
 Status|UNCONFIRMED |RESOLVED

--- Comment #1 from Pali Rohár <pali.ro...@gmail.com> ---
It is probably duplicate of bug #351420. Please verify it. In that bug is also
proposed  fix which needs to be tested first before including it into kopete
git repository. If you can please do that. Thanks!

*** This bug has been marked as a duplicate of bug 351420 ***

-- 
You are receiving this mail because:
You are watching all bug changes.