[konqueror] [Bug 194399] cant use alternative configuration file. konqueror always uses the default file /home/user/.kde4.2/share/config/konquerorrc
https://bugs.kde.org/show_bug.cgi?id=194399 --- Comment #5 from Peter Mühlenpfordt --- The 'config' option to use an alternate rc file does not exist any more. There's a 'profile' option to load different settings which could be a replacement. This one works for me. -- You are receiving this mail because: You are watching all bug changes.
[kdevelop] [Bug 396851] Shortcut F8 ambiguous (File Manager plugin)
https://bugs.kde.org/show_bug.cgi?id=396851 Peter Mühlenpfordt changed: What|Removed |Added Resolution|WAITINGFORINFO |WORKSFORME Status|NEEDSINFO |RESOLVED --- Comment #3 from Peter Mühlenpfordt --- The problem seems to be fixed in current versions. Tested on Kubuntu 20.04.5 LTS and 22.10. -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 387440] In fish protocol, files with name starting with # are missidentified as folders
https://bugs.kde.org/show_bug.cgi?id=387440 Peter Mühlenpfordt changed: What|Removed |Added CC||de...@ukn8.de --- Comment #3 from Peter Mühlenpfordt --- Created attachment 153732 --> https://bugs.kde.org/attachment.cgi?id=153732=edit Dolphin showing remote file as folder I can confirm this bug for current kio-extras version 22.08.2 from Kubuntu 22.10 Since Krusader also shows files starting with '#' as folders, it seems to be a problem with the fish protocol, not Dolphin. -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 387573] Select first item in folder does not work with semantic filter active
https://bugs.kde.org/show_bug.cgi?id=387573 Peter Mühlenpfordt changed: What|Removed |Added Status|NEEDSINFO |REPORTED Resolution|WAITINGFORINFO |--- --- Comment #2 from Peter Mühlenpfordt --- Yes, this issue still exits in Gwenview version 22.08.2. Installed by Kubuntu 22.10, running with KDE Framework 5.98.0 and Qt 5.15.6. -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 401504] Crop box should start at visible image region
https://bugs.kde.org/show_bug.cgi?id=401504 Peter Mühlenpfordt changed: What|Removed |Added CC||de...@ukn8.de Status|REPORTED|CONFIRMED Ever confirmed|0 |1 --- Comment #5 from Peter Mühlenpfordt --- This is caused by the removal of `onWidgetSlidedIn` in https://phabricator.kde.org/D11378. But just re-adding it does not work for Advanced settings mode. -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 399235] [Suggestion] Rename image in Gwenview: filname only, not including file extension as default selection
https://bugs.kde.org/show_bug.cgi?id=399235 Peter Mühlenpfordt changed: What|Removed |Added Status|REPORTED|RESOLVED Version Fixed In||18.04 CC||de...@ukn8.de Resolution|--- |FIXED --- Comment #1 from Peter Mühlenpfordt --- This was fixed in https://commits.kde.org/gwenview/e85f4b589b93a5648b0150dca435018cd2fbae02 and is available in Gwenview 18.04. -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 398226] Failed to render png
https://bugs.kde.org/show_bug.cgi?id=398226 Peter Mühlenpfordt changed: What|Removed |Added CC||de...@ukn8.de Severity|critical|normal --- Comment #2 from Peter Mühlenpfordt --- Looks like a transparent PNG for which Okular shows a white and Gwenview a dark background. Maybe Settings > Configure Gwenview > Background color helps? -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 398016] Usability: cancel is the default action on resize
https://bugs.kde.org/show_bug.cgi?id=398016 Peter Mühlenpfordt changed: What|Removed |Added CC||de...@ukn8.de --- Comment #2 from Peter Mühlenpfordt --- This version seems to be a little bit outdated. ;) The oldest version I'm able to compile is 16.04 but I can't reproduce this on any version. I tried this: * Open Gwenview showing an image * Press Shift+R * Press Return -> Resize is accepted and executed. Maybe you are doing/expecting something else? -- You are receiving this mail because: You are watching all bug changes.
[kdelibs] [Bug 305702] Make Ctrl+0 default shortcut for Actual Size
https://bugs.kde.org/show_bug.cgi?id=305702
Peter Mühlenpfordt changed:
What|Removed |Added
Status|CONFIRMED |RESOLVED
Latest Commit||https://commits.kde.org/kco
||nfig/f651a817ab004b64e8fcd5
||b4b8fa5141de10995f
Resolution|--- |FIXED
Version Fixed In||5.50
--- Comment #4 from Peter Mühlenpfordt ---
Git commit f651a817ab004b64e8fcd5b4b8fa5141de10995f by Peter Mühlenpfordt.
Committed on 11/08/2018 at 11:10.
Pushed by muhlenpfordt into branch 'master'.
Set system default shortcut Ctrl+0 for "Actual Size" action
Summary:
Default shortcuts for zoom in ({key Ctrl +}) and out ({key Ctrl -})
already exists but not for going back to 100%.
The shortcut {key Ctrl 0} is widely used by different applications
for zoom to original size. This patch adds {key Ctrl 0} as system
default for `KStandardAction::ActualSize`.
FIXED-IN: 5.50
Test Plan:
Searched lxr for conflicts of `KStandardAction::ActualSize` and
usage of Ctrl+0 shortcut.
Checked the following applications with set system default shortcut:
* Gwenview
* KAlgebra
* KolourPaint
* KStars (FITS viewer)
* Cirkuit
Only Cirkuit uses Ctrl+0 for "Zoom To Fit" action. I'll create a
patch to solve this conflict.
Reviewers: dfaure, broulik, ngraham, rkflx
Reviewed By: dfaure, ngraham, rkflx
Subscribers: jriddell, rkflx, kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D14201
M +1-1src/gui/kstandardshortcut.cpp
https://commits.kde.org/kconfig/f651a817ab004b64e8fcd5b4b8fa5141de10995f
--
You are receiving this mail because:
You are watching all bug changes.
[gwenview] [Bug 389794] "Print Images" always greyed out when opening "Plugins" menu the first time
https://bugs.kde.org/show_bug.cgi?id=389794 --- Comment #3 from Peter Mühlenpfordt --- This was the commit where setEnabled() got lost on plugin init: https://cgit.kde.org/kipi-plugins.git/commit/?id=1fc7d86dbc94cb343b3c39b9dfda4d49a07f71e0 I'm not sure what the intention of this change was and if this should be fixed in the plugin code or in Gwenview (and maybe digiKam). -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 389794] "Print Images" always greyed out when opening "Plugins" menu the first time
https://bugs.kde.org/show_bug.cgi?id=389794 Peter Mühlenpfordt changed: What|Removed |Added CC||de...@ukn8.de --- Comment #2 from Peter Mühlenpfordt --- This seems to be a general issue. In digiKam these are the last two entries in the "Item" menu and they are also disabled until you select another image. The problem seems to be emiting the update signals for KIPI (currentAlbumChanged, selectionChanged) only before loading the plugins. -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 390929] Audio volume slider is out of position
https://bugs.kde.org/show_bug.cgi?id=390929
Peter Mühlenpfordt changed:
What|Removed |Added
Status|CONFIRMED |RESOLVED
Resolution|--- |FIXED
Version Fixed In||18.08.0
Latest Commit||https://commits.kde.org/gwe
||nview/fec2cd8b655e06c6cbb62
||4b32737651b5a45bc8c
--- Comment #7 from Peter Mühlenpfordt ---
Git commit fec2cd8b655e06c6cbb624b32737651b5a45bc8c by Peter Mühlenpfordt.
Committed on 05/08/2018 at 07:14.
Pushed by muhlenpfordt into branch 'Applications/18.08'.
Fix video controls volume slider not vertically centered sometimes
Summary:
The volume slider of the video controls overlay is sometimes not
centered vertically. This happens mostly on KDE Neon or if Gwenview
is started to show a video by commandline argument.
This is caused by calculating the slider and handle positions before
initializing the widget and therefore using wrong values. After the
first slider change this is correctly updated.
This patch delays the initialization of the slider to give the
overlay widget time to setup.
FIXED-IN: 18.08.0
Before:
{F6173671, size=full}
After:
{F6173673, size=full}
Test Plan:
* Start Gwenview with video file as commandline argument
* Check that all sliders are vertically centered in controls overlay
* Check in current KDE Neon system
Reviewers: #gwenview, rkflx
Reviewed By: #gwenview, rkflx
Subscribers: rkflx
Differential Revision: https://phabricator.kde.org/D14578
M +4-1lib/hud/hudslider.cpp
https://commits.kde.org/gwenview/fec2cd8b655e06c6cbb624b32737651b5a45bc8c
--
You are receiving this mail because:
You are watching all bug changes.
[kdevelop] [Bug 396851] Shortcut F8 ambiguous (File Manager plugin)
https://bugs.kde.org/show_bug.cgi?id=396851 --- Comment #1 from Peter Mühlenpfordt --- Wrong suspicion from my side - it's nothing from dolphin, the 'Filesystem' tool view is a kio plugin. The shortcut F8 is set in filewidgets/kdiroperator.cpp. If I remove Qt::Key_F8 here and compile/install kio there's no conflict any more. Btw. the same happens for Ctrl+H which conflicts with 'Kate Part > Find Selected'. -- You are receiving this mail because: You are watching all bug changes.
[kdevelop] [Bug 396851] New: Shortcut F8 ambiguous (File Manager plugin)
https://bugs.kde.org/show_bug.cgi?id=396851 Bug ID: 396851 Summary: Shortcut F8 ambiguous (File Manager plugin) Product: kdevelop Version: 5.2.1 Platform: Kubuntu Packages OS: Linux Status: UNCONFIRMED Severity: minor Priority: NOR Component: UI: general Assignee: kdevelop-bugs-n...@kde.org Reporter: de...@ukn8.de Target Milestone: --- Created attachment 114120 --> https://bugs.kde.org/attachment.cgi?id=114120=edit Screenshot after pressing F8 When trying to "Build Selection" with the default shortcut F8 from Filesystem sidebar this does not work. Instead the error message "The key sequence 'F8' is ambiguous..." is displayed. Maybe this comes from dolphinpart(?) shortcut F8 to hide/show hidden files but I found no way to disable this. Only the shortcut for kdevelop's "Build Selection" action could be changed. Steps to reproduce: * Open kdevelop and a project * Show Filesystem tool view * Press F8 (without clicking in editor window before) Expected: Build selection What happened: Error message Tested on standard Kubuntu 18.04 and KDE Neo systems. -- You are receiving this mail because: You are watching all bug changes.
[kdelibs] [Bug 305702] Make Ctrl+0 default shortcut for Actual Size
https://bugs.kde.org/show_bug.cgi?id=305702 Peter Mühlenpfordt changed: What|Removed |Added CC||de...@ukn8.de -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 396360] Shortcut F does not toggle between original size and fit to window any more
https://bugs.kde.org/show_bug.cgi?id=396360
Peter Mühlenpfordt changed:
What|Removed |Added
Resolution|--- |FIXED
Latest Commit||https://commits.kde.org/gwe
||nview/945c8a7a8d0b8326b194d
||44ec004963c0694f49a
Status|CONFIRMED |RESOLVED
--- Comment #7 from Peter Mühlenpfordt ---
Git commit 945c8a7a8d0b8326b194d44ec004963c0694f49a by Peter Mühlenpfordt.
Committed on 16/07/2018 at 15:15.
Pushed by muhlenpfordt into branch 'master'.
Toggle between zoom options "Fit"/"Fill" and "100%" on multiple activation
Summary:
In previous versions of Gwenview it was possible to toggle between
{nav Fit} and {nav 100%} zoom factors using the shortcut {key F}.
After 3e10699ac37c added the {nav Fit Width} zoom option this feature
did not work any more.
This patch adds toggling for both {nav Fit} and {nav Fill} zoom
options if the shortcut {key F} or one of the buttons is pressed
multiple times. Zooming to 100% is centered to the current cursor
position like middle click works.
Test Plan:
# Open Gwenview in View Mode
# Use zoom buttons {nav Fit}/{nav Fill} or {key F} multiple times
# The zoom should toggle between {nav Fit} and {nav 100%},
respectively between {nav Fill} and {nav 100%}
Reviewers: #gwenview, rkflx
Reviewed By: #gwenview, rkflx
Subscribers: rkflx
Differential Revision: https://phabricator.kde.org/D14093
M +2-0lib/documentview/abstractimageview.cpp
M +30 -0lib/documentview/documentview.cpp
M +2-0lib/documentview/documentview.h
M +2-7lib/documentview/documentviewcontroller.cpp
https://commits.kde.org/gwenview/945c8a7a8d0b8326b194d44ec004963c0694f49a
--
You are receiving this mail because:
You are watching all bug changes.
[gwenview] [Bug 396360] Shortcut F does not toggle between original size and fit to window any more
https://bugs.kde.org/show_bug.cgi?id=396360
--- Comment #6 from Peter Mühlenpfordt ---
Git commit 9b898af627ab46a9de5486470f488af10aaa8e87 by Peter Mühlenpfordt.
Committed on 16/07/2018 at 07:36.
Pushed by muhlenpfordt into branch 'master'.
Add shortcut Shift+F for zoom option "Fill"
Summary:
This patch adds the shortcut {key Shift F} for zoom option {nav Fill}.
Test Plan:
# Open Gwenview in View Mode
# Use {key Shift F} to switch to {nav Fill} zoom factor
Reviewers: #gwenview, rkflx
Reviewed By: #gwenview, rkflx
Subscribers: rkflx
Differential Revision: https://phabricator.kde.org/D14094
M +1-1lib/documentview/documentviewcontroller.cpp
https://commits.kde.org/gwenview/9b898af627ab46a9de5486470f488af10aaa8e87
--
You are receiving this mail because:
You are watching all bug changes.
[gwenview] [Bug 396360] Shortcut F does not toggle between original size and fit to window any more
https://bugs.kde.org/show_bug.cgi?id=396360 --- Comment #5 from Peter Mühlenpfordt --- Yes, I like it this way too. :) Created two diffs for it: https://phabricator.kde.org/D14093 https://phabricator.kde.org/D14094 -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 396360] Shortcut F does not toggle between original size and fit to window any more
https://bugs.kde.org/show_bug.cgi?id=396360 Peter Mühlenpfordt changed: What|Removed |Added CC||de...@ukn8.de --- Comment #2 from Peter Mühlenpfordt --- There are three zoom buttons by now. The documentation at https://docs.kde.org/trunk5/en/kdegraphics/gwenview/view_mode.html was updated to: "The shortcut F switches to fit mode." (Btw. - we should update the screenshot here). Should we really toggle between two of the zoom presets with one shortcut or better add shortcuts for the other two? For "Fill" Qt::Key_W is prepared but commented out. -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 396186] No setting for "toggle fullscreen" key binding
https://bugs.kde.org/show_bug.cgi?id=396186 Peter Mühlenpfordt changed: What|Removed |Added CC||de...@ukn8.de --- Comment #1 from Peter Mühlenpfordt --- Created attachment 113801 --> https://bugs.kde.org/attachment.cgi?id=113801=edit Screenshot shortcut editor I can't confirm that with 18.04 or master. Both versions offer a "toggle" and "leave" shortcut. Are the default shortcuts F11 / Ctrl+Shift+F working for you? Could you check with a clean config (remove/rename the files ~/.config/gwenviewrc and ~/.local/share/kxmlgui5/gwenview/gwenviewui.rc)? -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 395890] No Error when same Picture name is selected
https://bugs.kde.org/show_bug.cgi?id=395890 Peter Mühlenpfordt changed: What|Removed |Added Resolution|--- |FIXED Status|CONFIRMED |RESOLVED Latest Commit||https://commits.kde.org/gwe ||nview/47c66913c6ec11408504c ||dee7c6519d9224b6798 Version Fixed In||18.04.3 --- Comment #6 from Peter Mühlenpfordt --- Git commit 47c66913c6ec11408504cdee7c6519d9224b6798 by Peter Mühlenpfordt. Committed on 29/06/2018 at 07:22. Pushed by muhlenpfordt into branch 'Applications/18.04'. Enable AutoErrorHandling for rename job Summary: If a rename job started from View Mode fails, no warning message is shown. This is caused by the default disabled `AutoErrorHandling` in `KJobUiDelegate`. This patch enables the flag after creating the job. FIXED-IN: 18.04.3 Test Plan: # Open Gwenview in View Mode # Try to rename image to already existing filename # An error message should be displayed Reviewers: #gwenview, rkflx Reviewed By: #gwenview, rkflx Subscribers: rkflx Differential Revision: https://phabricator.kde.org/D13754 M +1-1app/fileoperations.cpp https://commits.kde.org/gwenview/47c66913c6ec11408504cdee7c6519d9224b6798 -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 395890] No Error when same Picture name is selected
https://bugs.kde.org/show_bug.cgi?id=395890 Peter Mühlenpfordt changed: What|Removed |Added CC||de...@ukn8.de -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 277384] Gwenview crashes while saving a bunch of pictures [ Gwenview::JpegContent::rawData, Gwenview::JpegDocumentLoadedImpl::rawData ]
https://bugs.kde.org/show_bug.cgi?id=277384 Peter Mühlenpfordt changed: What|Removed |Added CC||de...@ukn8.de --- Comment #11 from Peter Mühlenpfordt --- Is this still reproducible? I tested actual versions from git master and v17.12.3 from Kubuntu 18.04 repository with 50 rotated jpg files, each 6000x4000 px, overall ~600 MB. `Save All` run through without any problems. -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 394406] "Plus" contextual button doesn't update to "minus" when clicking a picture in browse mode.
https://bugs.kde.org/show_bug.cgi?id=394406
Peter Mühlenpfordt <de...@ukn8.de> changed:
What|Removed |Added
Latest Commit||https://commits.kde.org/gwe
||nview/5d3d973593c7cae191109
||52ba2944365a1bab623
Version Fixed In||18.04.2
Resolution|--- |FIXED
Status|CONFIRMED |RESOLVED
--- Comment #3 from Peter Mühlenpfordt <de...@ukn8.de> ---
Git commit 5d3d973593c7cae19110952ba2944365a1bab623 by Peter Mühlenpfordt.
Committed on 25/05/2018 at 07:19.
Pushed by muhlenpfordt into branch 'Applications/18.04'.
Update thumbnail de-/select hover button on selection change
Summary:
The de-/select (`-`/`+`) hover button of the thumbnails in Browse
Mode or thumbnail bar in View Mode does not reflect the actual
selection state sometimes.
This patch updates the button state when the selection changed.
FIXED-IN: 18.04.2
Test Plan:
# Open Gwenview in Browse Mode or View Mode with visible thumbnail bar
# Use e.g. {key Ctrl Click} to de-/select images or
move selection by keyboard
# `-`/`+` button of item under mouse pointer should
reflect the actual selection state
Reviewers: #gwenview, huoni
Reviewed By: #gwenview, huoni
Subscribers: rkflx
Differential Revision: https://phabricator.kde.org/D13010
M +3-1lib/thumbnailview/previewitemdelegate.cpp
M +5-2lib/thumbnailview/thumbnailbarview.cpp
https://commits.kde.org/gwenview/5d3d973593c7cae19110952ba2944365a1bab623
--
You are receiving this mail because:
You are watching all bug changes.
[gwenview] [Bug 290294] Add “Copy to Clipboard” option to context menu
https://bugs.kde.org/show_bug.cgi?id=290294
Peter Mühlenpfordt <de...@ukn8.de> changed:
What|Removed |Added
Status|UNCONFIRMED |RESOLVED
Latest Commit||https://commits.kde.org/gwe
||nview/b94861f27a29fe576867e
||ee0157d5211187a16db
Resolution|--- |FIXED
--- Comment #3 from Peter Mühlenpfordt <de...@ukn8.de> ---
Git commit b94861f27a29fe576867eee0157d5211187a16db by Peter Mühlenpfordt.
Committed on 21/05/2018 at 08:42.
Pushed by muhlenpfordt into branch 'master'.
Copy raster image and SVG content to clipboard
Summary:
The normal `Copy`/`Cut` options ({key Ctrl C}/{key Ctrl X}) copy the
url(s) of the selected file(s)/folder(s) to the clipboard.
This patch additionally copies raster image and SVG content of the
current document to the clipboard. In Browse Mode the content is
copied only if a single file is selected.
Test Plan:
# Open raster image or SVG in Gwenview
# {nav Edit > Copy} or {key Ctrl C} to copy image to clipboard
# Paste image to different applications (e.g. gimp, office writer,
facebook chat in web browser, inkscape, etc.)
# Cut should only move the file if pasted to file manager
applications (e.g. dolphin)
Reviewers: #gwenview, rkflx
Reviewed By: #gwenview, rkflx
Subscribers: huoni, rkflx, ngraham
Differential Revision: https://phabricator.kde.org/D12871
M +24 -1app/fileopscontextmanageritem.cpp
https://commits.kde.org/gwenview/b94861f27a29fe576867eee0157d5211187a16db
--
You are receiving this mail because:
You are watching all bug changes.
[gwenview] [Bug 276255] Paste Clipboard Contents disabled unless image already open
https://bugs.kde.org/show_bug.cgi?id=276255
Peter Mühlenpfordt <de...@ukn8.de> changed:
What|Removed |Added
Resolution|--- |FIXED
Latest Commit||https://commits.kde.org/gwe
||nview/358ff25a4ab9855a67275
||46f355db428dd74f8cf
Status|CONFIRMED |RESOLVED
Version Fixed In||18.04.2
--- Comment #3 from Peter Mühlenpfordt <de...@ukn8.de> ---
Git commit 358ff25a4ab9855a6727546f355db428dd74f8cf by Peter Mühlenpfordt.
Committed on 20/05/2018 at 15:16.
Pushed by muhlenpfordt into branch 'Applications/18.04'.
Update paste action on current directory and selection changes
Summary:
The paste action is disabled on Gwenview start. This is caused by
initializing the action state before setting the current directory
url in `ContextManager`. The state updates only on clipboard changes
and does not reflect the current permissions to paste into a folder.
This patch updates the paste action state on changing the directory
and the selection, which both affect the paste destination.
FIXED-IN: 18.04.2
Test Plan:
# Copy url(s) to clipboard (e.g. from `Dolphin`)
# Open Gwenview in Browse Mode
# Check if {nav Edit > Paste...} is enabled on startup
# Check if {nav Edit > Paste...} is disabled in non-writable folders
Reviewers: #gwenview, rkflx
Reviewed By: #gwenview, rkflx
Subscribers: rkflx, huoni
Differential Revision: https://phabricator.kde.org/D12902
M +1-1app/fileopscontextmanageritem.cpp
https://commits.kde.org/gwenview/358ff25a4ab9855a6727546f355db428dd74f8cf
--
You are receiving this mail because:
You are watching all bug changes.
[gwenview] [Bug 394406] "Plus" contextual button doesn't update to "minus" when clicking a picture in browse mode.
https://bugs.kde.org/show_bug.cgi?id=394406 Peter Mühlenpfordt <de...@ukn8.de> changed: What|Removed |Added CC||de...@ukn8.de --- Comment #2 from Peter Mühlenpfordt <de...@ukn8.de> --- This also happens in thumbnail bar of View Mode. -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 315983] browse mode does not correctly display custom folder icon
https://bugs.kde.org/show_bug.cgi?id=315983
--- Comment #11 from Peter Mühlenpfordt <de...@ukn8.de> ---
Git commit bafc90d730f2ad018ff440060e19b8affa074d31 by Peter Mühlenpfordt.
Committed on 15/05/2018 at 15:04.
Pushed by muhlenpfordt into branch 'Applications/18.04'.
Scale up folder icon before creating preview overlays
Summary:
If a custom folder icon is smaller than the requested preview size
`KIO::PreviewJob` returns a pixmap of only that size. E.g. `dolphin`
scales this up to its current thumbnail size which results in ugly
overlay icons for very small folder icons. If the folder icon is
scaled up before creating the overlay icons the overall preview
looks much better.
Test Plan:
# Set a small custom icon (e.g. 32 px) for a folder containing images
# Start dolphin with `Preview` enabled in the parent folder
# Zoom thumbnails to e.g. 128 pixels overlay
# The overlayed preview icons should not be blurry
| Before:| After: |
| {F5837958} | {F5837960} |
Reviewers: #frameworks, rkflx
Reviewed By: rkflx
Subscribers: ngraham, rkflx
Differential Revision: https://phabricator.kde.org/D12734
M +8-1thumbnail/thumbnail.cpp
https://commits.kde.org/kio-extras/bafc90d730f2ad018ff440060e19b8affa074d31
--
You are receiving this mail because:
You are watching all bug changes.
[kdeplasma-addons] [Bug 381173] Wrong countdown speed in timer plasmoid's window.
https://bugs.kde.org/show_bug.cgi?id=381173
--- Comment #17 from Peter Mühlenpfordt <de...@ukn8.de> ---
I don't think this is a bug of QtQuick `Timer`. IMO the problem is a duplicate
creation of `TimerView` and therefore duplicate timer trigger.
If I remove/comment out e.g. the second (main.qml, line 60):
`Plasmoid.fullRepresentation: TimerView { }`
the counter works correct. Adding a third `TimerView`, the counter jumps three
seconds at once.
I'm not familiar with QtQuick so I'm not sure what the best solution could be,
maybe moving the timer from `TimerView` to `main`?
--
You are receiving this mail because:
You are watching all bug changes.
[gwenview] [Bug 315983] browse mode does not correctly display custom folder icon
https://bugs.kde.org/show_bug.cgi?id=315983 --- Comment #10 from Peter Mühlenpfordt <de...@ukn8.de> --- > ae6fc125c838 was only to update the version number, but the tag could still > go to a later commit. Oh, right - I mixed that up. -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 315983] browse mode does not correctly display custom folder icon
https://bugs.kde.org/show_bug.cgi?id=315983
Peter Mühlenpfordt <de...@ukn8.de> changed:
What|Removed |Added
Status|CONFIRMED |RESOLVED
Resolution|--- |FIXED
Latest Commit||https://commits.kde.org/gwe
||nview/dd0d608a27711cdd1a64a
||5cb43f01513c212b0cf
Version Fixed In||18.04.2
--- Comment #8 from Peter Mühlenpfordt <de...@ukn8.de> ---
Git commit dd0d608a27711cdd1a64a5cb43f01513c212b0cf by Peter Mühlenpfordt.
Committed on 07/05/2018 at 06:57.
Pushed by muhlenpfordt into branch 'Applications/18.04'.
Fix custom folder icons using an absolute path entry
Summary:
Gwenview does not display a custom folder icon which is configured
by an absolute path and the folder does not contain any images.
This is caused by `KIconLoader::loadMimeTypeIcon()` failing for
absolute path entries. If the folder contains images the preview
job corrects the icon later.
Using `KIconLoader::loadIcon()` loads the correct icon.
FIXED-IN: 18.04.2
Test Plan:
* Create an empty folder (e.g. /tmp/parent/test-empty)
* Set a custom icon for `test-empty` using an absolute path
* Start Gwenview in Browse Mode in the `parent` folder
* Folder `test-empty` should display the custom icon
| Before:| After: |
| {F5818845} | {F5818847} |
Reviewers: #gwenview, rkflx
Reviewed By: #gwenview, rkflx
Subscribers: rkflx, huoni
Differential Revision: https://phabricator.kde.org/D12465
M +2-2lib/thumbnailview/thumbnailview.cpp
https://commits.kde.org/gwenview/dd0d608a27711cdd1a64a5cb43f01513c212b0cf
--
You are receiving this mail because:
You are watching all bug changes.
[kdeplasma-addons] [Bug 381173] Wrong countdown speed in timer plasmoid's window.
https://bugs.kde.org/show_bug.cgi?id=381173 Peter Mühlenpfordt <de...@ukn8.de> changed: What|Removed |Added CC||de...@ukn8.de -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 238682] gwenview doesn't remember width of sidebar
https://bugs.kde.org/show_bug.cgi?id=238682
Peter Mühlenpfordt <de...@ukn8.de> changed:
What|Removed |Added
Latest Commit||https://commits.kde.org/gwe
||nview/c7b70617668daed49f026
||2894bc947a12e8d413a
Version Fixed In||18.08.0
Status|CONFIRMED |RESOLVED
Resolution|--- |FIXED
--- Comment #3 from Peter Mühlenpfordt <de...@ukn8.de> ---
Git commit c7b70617668daed49f0262894bc947a12e8d413a by Peter Mühlenpfordt.
Committed on 30/04/2018 at 11:27.
Pushed by muhlenpfordt into branch 'master'.
Remember width of sidebar
Summary:
If a user moves the central splitter to change the width of the
sidebar Gwenview does not remember this for the next restart.
This patch adds a config entry to store the splitter sizes
analogous to the thumbnailbar config in View Mode.
FIXED-IN: 18.08.0
Depends on D12561
Test Plan:
* Open Gwenview in Browse or View Mode
* Show sidebar if hidden ({key F4})
* Move splitter to resize sidebar
* Quit and restart Gwenview
* Sidebar should have same width as before
* Check default with a clean config file
Reviewers: #gwenview, huoni
Reviewed By: #gwenview, huoni
Subscribers: rkflx, huoni
Differential Revision: https://phabricator.kde.org/D12489
M +19 -0app/mainwindow.cpp
M +3-0lib/gwenviewconfig.kcfg
https://commits.kde.org/gwenview/c7b70617668daed49f0262894bc947a12e8d413a
--
You are receiving this mail because:
You are watching all bug changes.
[gwenview] [Bug 315983] browse mode does not correctly display custom folder icon
https://bugs.kde.org/show_bug.cgi?id=315983 Peter Mühlenpfordt <de...@ukn8.de> changed: What|Removed |Added CC||de...@ukn8.de --- Comment #7 from Peter Mühlenpfordt <de...@ukn8.de> --- I can confirm this only for folders with an absolute path icon * without any images inside or * the custom icon's size is less than 128 pixel. With at least one image in the folder the custom icon shows up with the mini thumbnails overlay. It also doesn't matter if the icon is in PNG/SVG/JPG format. -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 393170] "Saving failed" warning has raw html in it
https://bugs.kde.org/show_bug.cgi?id=393170
Peter Mühlenpfordt <de...@ukn8.de> changed:
What|Removed |Added
Version Fixed In||18.04.1
Resolution|--- |FIXED
Latest Commit||https://commits.kde.org/gwe
||nview/5e7fe7535f9d5fb2de44f
||e408fe8cf5b0f7937b1
Status|CONFIRMED |RESOLVED
--- Comment #2 from Peter Mühlenpfordt <de...@ukn8.de> ---
Git commit 5e7fe7535f9d5fb2de44fe408fe8cf5b0f7937b1 by Peter Mühlenpfordt.
Committed on 19/04/2018 at 09:37.
Pushed by muhlenpfordt into branch 'Applications/18.04'.
Fix duplicate and markup displaying failed-save message box
Summary:
When saving of a file fails, two dialogs are displayed. One of them
contains markup tags like `` and ``.
The duplicate message box is caused by KJob's (not disabled) internal
error handling. The markup is displayed because of using strings with
markup as argument for `xi18n*` functions without special handling.
FIXED-IN: 18.04.1
Test Plan:
1. Open Gwenview in View or Browse Mode
2. {nav File > Save As} or {key Ctrl Shift S}
3. Try to save in a folder you don't have write permission (e.g. Root)
4. Error message box should display only once and without markup tags
1. Open Gwenview in View or Browse Mode
2. Edit a readonly file (e.g. rotate with {key Ctrl R})
3. Click {nav Save} or {nav Save All}
4. Error message box should display only once and without markup tags
Reviewers: #gwenview, rkflx
Reviewed By: #gwenview, rkflx
Subscribers: rkflx
Differential Revision: https://phabricator.kde.org/D12302
M +1-1app/gvcore.cpp
M +1-1app/saveallhelper.cpp
M +5-2lib/document/savejob.cpp
https://commits.kde.org/gwenview/5e7fe7535f9d5fb2de44fe408fe8cf5b0f7937b1
--
You are receiving this mail because:
You are watching all bug changes.
[gwenview] [Bug 393176] image not displayed after session restore
https://bugs.kde.org/show_bug.cgi?id=393176 Peter Mühlenpfordt <de...@ukn8.de> changed: What|Removed |Added Version Fixed In||18.04.1 Status|CONFIRMED |RESOLVED Latest Commit||https://commits.kde.org/gwe ||nview/cd18339fe959d8f9df3c4 ||962b50df4f8c4755e4c Resolution|--- |FIXED --- Comment #3 from Peter Mühlenpfordt <de...@ukn8.de> --- Git commit cd18339fe959d8f9df3c4962b50df4f8c4755e4c by Peter Mühlenpfordt. Committed on 19/04/2018 at 07:27. Pushed by muhlenpfordt into branch 'Applications/18.04'. Fix View Mode session restore Summary: While restoring a saved session the last URL is selected but View Mode is not triggered. This is caused by wrong order of switching mode and setting the current URL. FIXED-IN: 18.04.1 Test Plan: * Open one or more instances of Gwenview in different states * Logout with session restore enabled * Login * All Gwenview windows should restore in Browse or View Mode Reviewers: #gwenview, rkflx Reviewed By: #gwenview, rkflx Subscribers: rkflx Differential Revision: https://phabricator.kde.org/D12246 M +5-6app/mainwindow.cpp https://commits.kde.org/gwenview/cd18339fe959d8f9df3c4962b50df4f8c4755e4c -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 393170] "Saving failed" warning has raw html in it
https://bugs.kde.org/show_bug.cgi?id=393170 Peter Mühlenpfordt <de...@ukn8.de> changed: What|Removed |Added Status|UNCONFIRMED |CONFIRMED Ever confirmed|0 |1 CC||de...@ukn8.de --- Comment #1 from Peter Mühlenpfordt <de...@ukn8.de> --- I can confirm both issues. They still exist in current master. The duplicate message box is caused by KJob's (not disabled) internal error handling. Gwenview's error dialog adds KJobs already html-formatted error string to the message which results in displaying the markup. -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 393176] image not displayed after session restore
https://bugs.kde.org/show_bug.cgi?id=393176 Peter Mühlenpfordt <de...@ukn8.de> changed: What|Removed |Added CC||de...@ukn8.de -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 359736] Crash when reloading SVG image
https://bugs.kde.org/show_bug.cgi?id=359736
Peter Mühlenpfordt <de...@ukn8.de> changed:
What|Removed |Added
Version Fixed In||18.04.1
Resolution|--- |FIXED
Status|CONFIRMED |RESOLVED
Latest Commit||https://commits.kde.org/gwe
||nview/f11f5a43b4a65a1a9f289
||3dc577b94b7af94a37b
--- Comment #9 from Peter Mühlenpfordt <de...@ukn8.de> ---
Git commit f11f5a43b4a65a1a9f2893dc577b94b7af94a37b by Peter Mühlenpfordt.
Committed on 15/04/2018 at 07:50.
Pushed by muhlenpfordt into branch 'Applications/18.04'.
Fix reloading of SVG images
Summary:
If an SVG image is reloaded ({key F5} or {nav File > Reload}) the
`QSvgRenderer` is not updated after loading and Gwenview crashes
when trying to zoom. If the SVG file is changed outside Gwenview
while it is viewed and then reloaded it's not updated.
This is caused by a missing connection to the `loaded()` signal
and calling `SvgImageView::finishLoadFromDocument()` to setup the
new renderer.
FIXED-IN: 18.04.1
Test Plan:
1. Open SVG image in View Mode
2. Press {key F5} to reload
3. Zoom by mouse scroll or moving the slider
4. Gwenview should not crash
1. Open SVG image in View Mode
2. Overwrite viewed file with another SVG outside Gwenview
3. Press {key F5} to reload
4. New image should display
Reviewers: #gwenview, rkflx
Reviewed By: #gwenview, rkflx
Subscribers: rkflx, huoni
Differential Revision: https://phabricator.kde.org/D12187
M +6-4lib/documentview/svgviewadapter.cpp
https://commits.kde.org/gwenview/f11f5a43b4a65a1a9f2893dc577b94b7af94a37b
--
You are receiving this mail because:
You are watching all bug changes.
[gwenview] [Bug 389331] Changes to shortcuts only reflected after restart in some situations
https://bugs.kde.org/show_bug.cgi?id=389331
Peter Mühlenpfordt <de...@ukn8.de> changed:
What|Removed |Added
Latest Commit||https://commits.kde.org/gwe
||nview/936e30aca40e898db2719
||ee74b40fcffef740136
Status|UNCONFIRMED |RESOLVED
Resolution|--- |FIXED
Version Fixed In||18.04.0
--- Comment #3 from Peter Mühlenpfordt <de...@ukn8.de> ---
Git commit 936e30aca40e898db2719ee74b40fcffef740136 by Peter Mühlenpfordt.
Committed on 09/04/2018 at 07:41.
Pushed by muhlenpfordt into branch 'Applications/18.04'.
Fix shortcut config changes sometimes not updating until restart
Summary:
After setting or resetting custom shortcuts for actions in Browse or
Start Page Mode and then switching to View Mode these changes are not
active until next Gwenview restart.
This patch adds a `refreshActionProperties()` call after the shortcut
config dialog is closed to fix this.
FIXED-IN: 18.04.0
Test Plan:
* Start Gwenview in Browse Mode or Start Page Mode
* {nav Settings > Configure Shortcuts...}
* Set custom shortcut for {nav Quit} to e.g. {key Esc}
* Switch to View Mode displaying any image
* {key Esc} should quit Gwenview
* Restart Gwenview in Browse Mode or Start Page Mode
* {nav Settings > Configure Shortcuts...}
* Reset shortcuts with {nav Defaults}
* Switch to View Mode displaying any image
* {key Ctrl Q} should quit Gwenview
Reviewers: #gwenview, rkflx
Reviewed By: #gwenview, rkflx
Subscribers: rkflx, huoni
Differential Revision: https://phabricator.kde.org/D12023
M +8-2app/mainwindow.cpp
M +1-0app/mainwindow.h
https://commits.kde.org/gwenview/936e30aca40e898db2719ee74b40fcffef740136
--
You are receiving this mail because:
You are watching all bug changes.
[gwenview] [Bug 356998] After cropping a .jpg image and cancelling/denying the crop operation, the preview icon shows the cropped version in the directory browser
https://bugs.kde.org/show_bug.cgi?id=356998
Peter Mühlenpfordt <de...@ukn8.de> changed:
What|Removed |Added
Status|REOPENED|RESOLVED
Resolution|--- |FIXED
Version Fixed In||18.04.0
Latest Commit||https://commits.kde.org/gwe
||nview/f78e5e4b05b7e5a04690d
||ceb5e2203b0ef41bf66
--- Comment #5 from Peter Mühlenpfordt <de...@ukn8.de> ---
Git commit f78e5e4b05b7e5a04690dceb5e2203b0ef41bf66 by Peter Mühlenpfordt.
Committed on 09/04/2018 at 06:23.
Pushed by muhlenpfordt into branch 'Applications/18.04'.
Fix thumbnail update after undo
Summary:
After editing an image multiple times (e.g. rotate) and then undoing,
the thumbnail displays a previous edit state between the undos.
This is caused by connecting to `QUndoStack` signal `indexChanged`
which emits before some undo operations are finished and the new
thumbnail is created too early.
This patch emits the `modified`/`saved` signals for a document only
after the undo image operation is finished. It also solves the problem
displaying a wrong thumbnail in another mode after undoing all edits.
Depends on D11714
FIXED-IN: 18.04.0
Test Plan:
* Open image in Gwenview (View or Browse Mode)
* Edit image at least 3 times (e.g. rotate with {key Ctrl R})
* Undo all edits ({key Ctrl Z})
* Thumbnail should always correspond to undo step
* Thumbnail should be identical in View, Browse and Fullscreen Mode
Reviewers: #gwenview, rkflx
Reviewed By: #gwenview, rkflx
Subscribers: rkflx, huoni
Differential Revision: https://phabricator.kde.org/D11715
M +9-0lib/abstractimageoperation.cpp
M +2-0lib/abstractimageoperation.h
M +1-0lib/crop/cropimageoperation.cpp
M +1-2lib/document/document.cpp
M +2-1lib/document/document.h
M +1-0lib/redeyereduction/redeyereductionimageoperation.cpp
M +1-0lib/resize/resizeimageoperation.cpp
M +1-1lib/thumbnailview/thumbnailview.cpp
M +4-1lib/transformimageoperation.cpp
M +2-0tests/auto/documenttest.cpp
https://commits.kde.org/gwenview/f78e5e4b05b7e5a04690dceb5e2203b0ef41bf66
--
You are receiving this mail because:
You are watching all bug changes.
[gwenview] [Bug 389331] Changes to shortcuts only reflected after restart in some situations
https://bugs.kde.org/show_bug.cgi?id=389331 Peter Mühlenpfordt <de...@ukn8.de> changed: What|Removed |Added CC||de...@ukn8.de --- Comment #1 from Peter Mühlenpfordt <de...@ukn8.de> --- I can't reproduce this any more in any other branch than Applications/17.12. Tested in master, Applications/18.04 and even Applications/17.08 is ok. -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 321091] can't use right/left arrows after cropping
https://bugs.kde.org/show_bug.cgi?id=321091
Peter Mühlenpfordt <de...@ukn8.de> changed:
What|Removed |Added
Latest Commit||https://commits.kde.org/gwe
||nview/7369f4719529b7d4dd5e9
||ee55e22e447383ef6bb
Status|CONFIRMED |RESOLVED
Resolution|--- |FIXED
--- Comment #2 from Peter Mühlenpfordt <de...@ukn8.de> ---
Git commit 7369f4719529b7d4dd5e9ee55e22e447383ef6bb by Peter Mühlenpfordt.
Committed on 04/04/2018 at 06:33.
Pushed by muhlenpfordt into branch 'Applications/18.04'.
Set focus back to image view after leaving edit tool
Summary:
If you click on the toolbar of an image edit tool (crop, redeye)
the focus is lost after leaving the tool and you cannot switch images
with cursor keys.
This patch resets the focus to image view after leaving the edit tool.
Test Plan:
* Open image in Gwenview View Mode (normal or fullscreen)
* Start crop tool ({key Shift C})
* Click on {nav Crop} or {nav Cancel}
* Switching images with cursor keys should work as usual
Reviewers: #gwenview, rkflx
Reviewed By: #gwenview, rkflx
Subscribers: rkflx, huoni
Differential Revision: https://phabricator.kde.org/D11899
M +10 -0app/viewmainpage.cpp
M +3-0app/viewmainpage.h
https://commits.kde.org/gwenview/7369f4719529b7d4dd5e9ee55e22e447383ef6bb
--
You are receiving this mail because:
You are watching all bug changes.
[gwenview] [Bug 308335] Wishlist: Middle-click zoom should be centered on the current mouse location
https://bugs.kde.org/show_bug.cgi?id=308335
Peter Mühlenpfordt <de...@ukn8.de> changed:
What|Removed |Added
Latest Commit||https://commits.kde.org/gwe
||nview/1e66de8f8f2664451279b
||23f2e6e7cef3ba372bc
Resolution|--- |FIXED
Status|UNCONFIRMED |RESOLVED
--- Comment #1 from Peter Mühlenpfordt <de...@ukn8.de> ---
Git commit 1e66de8f8f2664451279b23f2e6e7cef3ba372bc by Peter Mühlenpfordt.
Committed on 15/03/2018 at 13:45.
Pushed by muhlenpfordt into branch 'master'.
Keep click position in focus on middle-click zoom
Summary:
Clicking on an image in View Mode with the middle mouse button toggles
between `Fit` and `100%` zoom modes. The image zoomed to `100%` is
always scrolled to the image center.
This patch keeps the clicked location in focus as it is done while
zooming with {key Ctrl Scroll}.
Test Plan:
* Open a big image in View Mode
* Middle-click on different locations over the image
* The `100%` zoom view should keep the clicked location in focus
Reviewers: #gwenview, rkflx
Reviewed By: #gwenview, rkflx
Subscribers: rkflx, huoni
Differential Revision: https://phabricator.kde.org/D11336
M +1-1lib/documentview/abstractimageview.cpp
https://commits.kde.org/gwenview/1e66de8f8f2664451279b23f2e6e7cef3ba372bc
--
You are receiving this mail because:
You are watching all bug changes.
[gwenview] [Bug 391884] Investigate whether crop ratios should be inverted when image orientation changes
https://bugs.kde.org/show_bug.cgi?id=391884 Peter Mühlenpfordt <de...@ukn8.de> changed: What|Removed |Added CC||de...@ukn8.de --- Comment #1 from Peter Mühlenpfordt <de...@ukn8.de> --- > [huoni @ https://phabricator.kde.org/D11202#226409] > QSizeF::transposed() simply returns a new object with width/height swapped. > I don't see how that would help determine which combobox items were under > which Landscape/Portrait heading. I think you don't need to pre-categorize the settings. If height() > width() it is portrait and vice versa. But that doesn't matter while switching the orientation. The corresponding setting for the other mode can be found by just searching the transposed actual QSizeF in the combobox list. >> IMHO a basic change/rewrite of storing and handling the combo box entries >> stands in no relation to the benefits. > > Sorry not sure what you mean. Are you saying that a change/rewrite is fine > to go ahead with regardless? What I meant was that completely changing the combo box code ist much work and it doesn't give that much benefit. If it could be done with a little bit of work it's ok. ;) -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 379617] When image name renamed to a name of a previously viewed image, the old image is still shown
https://bugs.kde.org/show_bug.cgi?id=379617 --- Comment #4 from Peter Mühlenpfordt <de...@ukn8.de> --- It's really a different bug. I created a patch which handles the cache update and fixes renaming in View Mode. But it still needs to catch the Browse Mode rename. https://phabricator.kde.org/D10917 -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 391527] After disabling "History" in settings, Gwenview still remembers last used folder
https://bugs.kde.org/show_bug.cgi?id=391527
Peter Mühlenpfordt <de...@ukn8.de> changed:
What|Removed |Added
Status|UNCONFIRMED |RESOLVED
Resolution|--- |FIXED
Latest Commit||https://commits.kde.org/gwe
||nview/8bd2f625c67966ed9d32f
||98c74f769caf56f6fdd
--- Comment #4 from Peter Mühlenpfordt <de...@ukn8.de> ---
Git commit 8bd2f625c67966ed9d32f98c74f769caf56f6fdd by Peter Mühlenpfordt.
Committed on 14/03/2018 at 08:22.
Pushed by muhlenpfordt into branch 'master'.
Prevent saving Recent Files and LastTargetDir if history is disabled
Summary:
Disabling history in {nav Settings > Configure > Advanced > History}
does not prevent showing and populating {nav File > Open Recent}.
The last target directory for Copy/Move/Link To dialog does not check
for history option too.
This patch only saves/restores file history if the option is enabled
and hides the menu entry if disabled.
Related: bug 332853
Depends on D11280
Test Plan:
* Enable/disable history option
* Open some images/folders in Gwenview
* Copy/Move/Link To some images
* Check if history is (not) saved/restored according to option value
Reviewers: #gwenview, rkflx
Reviewed By: #gwenview, rkflx
Subscribers: rkflx
Differential Revision: https://phabricator.kde.org/D11263
M +10 -4app/mainwindow.cpp
M +2-1lib/contextmanager.cpp
https://commits.kde.org/gwenview/8bd2f625c67966ed9d32f98c74f769caf56f6fdd
--
You are receiving this mail because:
You are watching all bug changes.
[gwenview] [Bug 332853] File -> Open Recent still present after disabling history
https://bugs.kde.org/show_bug.cgi?id=332853
Peter Mühlenpfordt <de...@ukn8.de> changed:
What|Removed |Added
Resolution|--- |FIXED
Latest Commit||https://commits.kde.org/gwe
||nview/8bd2f625c67966ed9d32f
||98c74f769caf56f6fdd
Status|CONFIRMED |RESOLVED
--- Comment #4 from Peter Mühlenpfordt <de...@ukn8.de> ---
Git commit 8bd2f625c67966ed9d32f98c74f769caf56f6fdd by Peter Mühlenpfordt.
Committed on 14/03/2018 at 08:22.
Pushed by muhlenpfordt into branch 'master'.
Prevent saving Recent Files and LastTargetDir if history is disabled
Summary:
Disabling history in {nav Settings > Configure > Advanced > History}
does not prevent showing and populating {nav File > Open Recent}.
The last target directory for Copy/Move/Link To dialog does not check
for history option too.
This patch only saves/restores file history if the option is enabled
and hides the menu entry if disabled.
Related: bug 391527
Depends on D11280
Test Plan:
* Enable/disable history option
* Open some images/folders in Gwenview
* Copy/Move/Link To some images
* Check if history is (not) saved/restored according to option value
Reviewers: #gwenview, rkflx
Reviewed By: #gwenview, rkflx
Subscribers: rkflx
Differential Revision: https://phabricator.kde.org/D11263
M +10 -4app/mainwindow.cpp
M +2-1lib/contextmanager.cpp
https://commits.kde.org/gwenview/8bd2f625c67966ed9d32f98c74f769caf56f6fdd
--
You are receiving this mail because:
You are watching all bug changes.
[gwenview] [Bug 391527] After disabling "History" in settings, Gwenview still remembers last used folder
https://bugs.kde.org/show_bug.cgi?id=391527
--- Comment #3 from Peter Mühlenpfordt <de...@ukn8.de> ---
Git commit fee2942254d630a042f3d9a536da8b97bc84478a by Peter Mühlenpfordt.
Committed on 14/03/2018 at 08:03.
Pushed by muhlenpfordt into branch 'master'.
Set default path of "Copy/Move/Link To" dialog to current folder
Summary:
D8785 introduced `QStandardPaths::PicturesLocation` as default
location for Copy/Move/Link To dialog.
This patch sets the starting folder to the current folder (where
the source image(s) resist). It also provides an easier handling
of switching off the history option in D11263.
Test Plan:
* Clear `LastTargetDir` config entry (e.g. remove `~/.config/gwenviewrc`)
* Start Gwenview
* Select one or more images and press {key F7} to copy
* Dialog should start in current folder
Reviewers: #gwenview, rkflx
Reviewed By: #gwenview, rkflx
Differential Revision: https://phabricator.kde.org/D11280
M +6-1app/fileoperations.cpp
M +1-1lib/contextmanager.cpp
M +0-3lib/gwenviewconfig.kcfg
https://commits.kde.org/gwenview/fee2942254d630a042f3d9a536da8b97bc84478a
--
You are receiving this mail because:
You are watching all bug changes.
[gwenview] [Bug 332853] File -> Open Recent still present after disabling history
https://bugs.kde.org/show_bug.cgi?id=332853 Peter Mühlenpfordt <de...@ukn8.de> changed: What|Removed |Added CC||de...@ukn8.de -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 391527] After disabling "History" in settings, Gwenview still remembers last used folder
https://bugs.kde.org/show_bug.cgi?id=391527 Peter Mühlenpfordt <de...@ukn8.de> changed: What|Removed |Added CC||de...@ukn8.de -- You are receiving this mail because: You are watching all bug changes.
[krename] [Bug 391291] New: Part of filename function does not count special characters
https://bugs.kde.org/show_bug.cgi?id=391291 Bug ID: 391291 Summary: Part of filename function does not count special characters Product: krename Version: unspecified Platform: Ubuntu Packages OS: Linux Status: UNCONFIRMED Severity: normal Priority: NOR Component: general Assignee: heire...@exherbo.org Reporter: de...@ukn8.de Target Milestone: --- Created attachment 36 --> https://bugs.kde.org/attachment.cgi?id=36=edit Example "part of filename" screenshot Using the part-of-filename function in KRename (e.g. [$1;5] or [$1-[length]]) does not count special characters like '&', '%', '#' and shortens the result by the number of these. If a special character is at the end of the filename-part '\' is inserted. E.g. [$2-[length]] "1234#6789.txt" -> "234#678.txt" (expected: "234#6789.txt")[$2-[length]] "12&&567.txt" -> "2&&5.txt" (expected: "2&&567.txt") [$2;3] "123%56.txt" -> "23\.txt" (expected: "23%.txt") Tested with KRename 4.0.9 (Kubuntu 17.10 packages) and 5.0.60 (git master). -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 383093] [proposal] Gwenview should remember full-screen mode state
https://bugs.kde.org/show_bug.cgi?id=383093 Peter Mühlenpfordt <de...@ukn8.de> changed: What|Removed |Added Latest Commit||https://commits.kde.org/gwe ||nview/59dd364b4bfce818764db ||d4b7f47c2df4caec58f Status|CONFIRMED |RESOLVED Resolution|--- |FIXED --- Comment #4 from Peter Mühlenpfordt <de...@ukn8.de> --- Git commit 59dd364b4bfce818764dbd4b7f47c2df4caec58f by Peter Mühlenpfordt. Committed on 01/03/2018 at 08:53. Pushed by muhlenpfordt into branch 'master'. Remember fullscreen mode and restore on next start Summary: Currently Gwenview always starts in normal (non-fullscreen) mode independent of its state on previous quit. This patch saves the fullscreen mode and restores it on next start. Test Plan: Quit Gwenview in normal/fullscreen mode and check if it restarts in previous mode. Commandline option --fullscreen overrides the saved state. Reviewers: #gwenview, rkflx Reviewed By: #gwenview, rkflx Subscribers: rkflx, ngraham Differential Revision: https://phabricator.kde.org/D10853 M +4-1app/main.cpp M +1-0app/mainwindow.cpp M +3-0lib/gwenviewconfig.kcfg https://commits.kde.org/gwenview/59dd364b4bfce818764dbd4b7f47c2df4caec58f -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 379617] When image name renamed to a name of a previously viewed image, the old image is still shown
https://bugs.kde.org/show_bug.cgi?id=379617 Peter Mühlenpfordt <de...@ukn8.de> changed: What|Removed |Added CC||de...@ukn8.de -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 390332] Filename in fullscreen toolbar not updated after renaming image
https://bugs.kde.org/show_bug.cgi?id=390332 Peter Mühlenpfordt <de...@ukn8.de> changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED Latest Commit||https://commits.kde.org/gwe ||nview/00ee923edea5196bbf11c ||046104d8a89d6331157 --- Comment #1 from Peter Mühlenpfordt <de...@ukn8.de> --- Git commit 00ee923edea5196bbf11c046104d8a89d6331157 by Peter Mühlenpfordt, on behalf of Silas Lenz. Committed on 25/02/2018 at 13:00. Pushed by muhlenpfordt into branch 'Applications/17.12'. Update filename in fullscreen view on rename Summary: When a file was renamed in fullscreen view the filename displayed in InformationLabel was not updated until you navigated to another image and back. This was caused by the current url not being updated, which also resulted in edits and saves affecting the wrong image. This patch fixes the missing url update. Also makes full screen thumbnailBar scroll to the new file similar to other thumbnailviews. Closes T8071 Test Plan: Case 1: 1. Open image in fullscreen view. 2. Rename image using F2 or right click menu. 3. Verify that all visible filenames are updated, and that navigation between images still work. Case 2: 1. Open image in normal view. 2. Rename image using F2 or Operations sidebar. 3. Verify that all visible filenames are updated, and that navigation between images still work. Case 3: 1. Select image thumbnail in browse view. 2. Rename image using F2 or right click menu. 3. Verify that all visible filenames are updated, and that the image is still selected. Reviewers: #gwenview, muhlenpfordt Reviewed By: #gwenview, muhlenpfordt Subscribers: rkflx, muhlenpfordt Tags: #gwenview Maniphest Tasks: T8071 Differential Revision: https://phabricator.kde.org/D10745 M +2-1app/fileoperations.cpp M +1-1app/fileoperations.h M +1-1app/fileopscontextmanageritem.cpp M +1-0app/mainwindow.cpp https://commits.kde.org/gwenview/00ee923edea5196bbf11c046104d8a89d6331157 -- You are receiving this mail because: You are watching all bug changes.
[krusader] [Bug 389869] After deletion of selected files current item moves one down
https://bugs.kde.org/show_bug.cgi?id=389869
Peter Mühlenpfordt <de...@ukn8.de> changed:
What|Removed |Added
Latest Commit||https://commits.kde.org/kru
||sader/dc38f3cfc6fd447723196
||7c03ea7fe76581d4e4c
Resolution|--- |FIXED
Status|CONFIRMED |RESOLVED
--- Comment #3 from Peter Mühlenpfordt <de...@ukn8.de> ---
Git commit dc38f3cfc6fd4477231967c03ea7fe76581d4e4c by Peter Mühlenpfordt.
Committed on 14/02/2018 at 06:48.
Pushed by muhlenpfordt into branch 'master'.
Fix setting new current item after file deletion
Summary:
After deleting one or more selected files and current item is not one
of these, the current item is moved one down.
This patch modifies `KrView::firstUnmarkedBelowCurrent()` to not make
an additional step down in finding the next unselected item.
Test Plan:
1. Create a folder with 5 files "file1".."file5"
2. Select "file1" and "file2"
3. Set current item to "file3"
4. Press {key Del} and delete selected files
-> The current item should stay on "file3"
Reviewers: #krusader, martinkostolny
Reviewed By: #krusader, martinkostolny
Subscribers: martinkostolny, asensi
Differential Revision: https://phabricator.kde.org/D10385
M +4-2krusader/Panel/PanelView/krview.cpp
M +1-1krusader/Panel/PanelView/krview.h
M +2-1krusader/Panel/listpanel.cpp
https://commits.kde.org/krusader/dc38f3cfc6fd4477231967c03ea7fe76581d4e4c
--
You are receiving this mail because:
You are watching all bug changes.
[gwenview] [Bug 383093] [proposal] Gwenview should remember full-screen mode state
https://bugs.kde.org/show_bug.cgi?id=383093 Peter Mühlenpfordt <de...@ukn8.de> changed: What|Removed |Added CC||de...@ukn8.de -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 387782] Session restore not working correctly for a fullscreen Gwenview.
https://bugs.kde.org/show_bug.cgi?id=387782 Peter Mühlenpfordt <de...@ukn8.de> changed: What|Removed |Added CC||de...@ukn8.de -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 195046] "presentation" mode does not exit when WM causes gwenview to leave full-screen mode
https://bugs.kde.org/show_bug.cgi?id=195046
Peter Mühlenpfordt <de...@ukn8.de> changed:
What|Removed |Added
Latest Commit||https://commits.kde.org/gwe
||nview/0d917337122fcc0227058
||6effa7df881a32d
Resolution|--- |FIXED
Status|CONFIRMED |RESOLVED
--- Comment #10 from Peter Mühlenpfordt <de...@ukn8.de> ---
Git commit 0d917337122fcc02270586effa7df881a32d by Peter Mühlenpfordt.
Committed on 09/02/2018 at 12:40.
Pushed by muhlenpfordt into branch 'master'.
Keep Gwenview fullscreen mode in sync with window manager
Summary:
Toggling fullscreen mode in Gwenview does not reflect in window manager
and vice versa.
This patch changes toggling fullscreen mode from `setWindowState()` to
`KToggleFullScreenAction::setFullScreen()` as the api doc recommends.
Test Plan:
Start Gwenview in windowed or fullscreen mode and toggle by window
manager, e.g. {nav Alt+F3 > More Actions > Fullscreen}.
Use other tools to toggle Gwenview's fullscreen mode:
```
kstart --fullscreen gwenview image.jpg
wmctrl -i -r -b add,fullscreen
wmctrl -i -r -b remove,fullscreen
```
Reviewers: rkflx, ngraham
Reviewed By: rkflx
Subscribers: broulik
Differential Revision: https://phabricator.kde.org/D10360
M +9-10 app/mainwindow.cpp
https://commits.kde.org/gwenview/0d917337122fcc02270586effa7df881a32d
--
You are receiving this mail because:
You are watching all bug changes.
[gwenview] [Bug 387784] Sidebar in fullscreen "View" mode moves buttons out of view
https://bugs.kde.org/show_bug.cgi?id=387784
Peter Mühlenpfordt <de...@ukn8.de> changed:
What|Removed |Added
Latest Commit|https://commits.kde.org/gwe |https://commits.kde.org/gwe
|nview/613dde719578427a41c34 |nview/b3e66abe28c2a85f0891f
|c85118fc628c329791d |9212403ff6648a8e2eb
--- Comment #7 from Peter Mühlenpfordt <de...@ukn8.de> ---
Git commit b3e66abe28c2a85f0891f9212403ff6648a8e2eb by Peter Mühlenpfordt.
Committed on 05/02/2018 at 09:13.
Pushed by muhlenpfordt into branch 'Applications/17.12'.
Resize top bar in fullscreen view mode on toggling sidebar
Summary:
When viewing an image in fullscreen mode and pressing {key F4} to
toggle the sidebar, the toolbar at the top does not resize.
The buttons on the right side are not visible while sidebar shows.
In browse mode `KToolBar` is used with a standard layout where this
problem does not appear. Since the toolbar in view mode overlaps the
image view a standard layout is not usable here which would send
resize events automatically.
This patch adds a resize Eventlistener to adjust toolbar width.
Test Plan:
1. Open gwenview in fullscreen view mode
2. Toggle sidebar ({key F4})
-> The top toolbar should resize according to image view width
Checked to work properly on a second monitor.
Reviewers: rkflx, ngraham
Reviewed By: rkflx
Differential Revision: https://phabricator.kde.org/D10248
M +8-0app/fullscreencontent.cpp
M +1-0app/fullscreencontent.h
M +1-2lib/fullscreenbar.cpp
https://commits.kde.org/gwenview/b3e66abe28c2a85f0891f9212403ff6648a8e2eb
--
You are receiving this mail because:
You are watching all bug changes.
[gwenview] [Bug 387784] Sidebar in fullscreen "View" mode moves buttons out of view
https://bugs.kde.org/show_bug.cgi?id=387784
Peter Mühlenpfordt <de...@ukn8.de> changed:
What|Removed |Added
Latest Commit||https://commits.kde.org/gwe
||nview/613dde719578427a41c34
||c85118fc628c329791d
Resolution|--- |FIXED
Status|CONFIRMED |RESOLVED
--- Comment #6 from Peter Mühlenpfordt <de...@ukn8.de> ---
Git commit 613dde719578427a41c34c85118fc628c329791d by Peter Mühlenpfordt.
Committed on 05/02/2018 at 08:38.
Pushed by muhlenpfordt into branch 'master'.
Resize top bar in fullscreen view mode on toggling sidebar
Summary:
When viewing an image in fullscreen mode and pressing {key F4} to
toggle the sidebar, the toolbar at the top does not resize.
The buttons on the right side are not visible while sidebar shows.
In browse mode `KToolBar` is used with a standard layout where this
problem does not appear. Since the toolbar in view mode overlaps the
image view a standard layout is not usable here which would send
resize events automatically.
This patch adds a resize Eventlistener to adjust toolbar width.
Test Plan:
1. Open gwenview in fullscreen view mode
2. Toggle sidebar ({key F4})
-> The top toolbar should resize according to image view width
Checked to work properly on a second monitor.
Reviewers: rkflx, ngraham
Reviewed By: rkflx
Differential Revision: https://phabricator.kde.org/D10248
M +8-0app/fullscreencontent.cpp
M +1-0app/fullscreencontent.h
M +1-2lib/fullscreenbar.cpp
https://commits.kde.org/gwenview/613dde719578427a41c34c85118fc628c329791d
--
You are receiving this mail because:
You are watching all bug changes.
[krusader] [Bug 389869] New: After deletion of selected files current item moves one down
https://bugs.kde.org/show_bug.cgi?id=389869 Bug ID: 389869 Summary: After deletion of selected files current item moves one down Product: krusader Version: 2.6.0 Platform: Ubuntu Packages OS: Linux Status: UNCONFIRMED Severity: normal Priority: NOR Component: general Assignee: m...@fork.pl Reporter: de...@ukn8.de Target Milestone: --- Created attachment 110331 --> https://bugs.kde.org/attachment.cgi?id=110331=edit Panel before/after deletion of selected files After deleting one or more selected files and current item is not one of these, the current item is moved one down. Steps to reproduce: 1. Create a folder with 5 files "file1".."file5" 2. Select "file1" and "file2" 3. Set current item to "file3" 4. Press Del and delete selected files Expected: Current item should stay on "file3" What happens: Current item is moved down to "file4" Tested with Krusader v2.6.0 from Kubuntu 17.10 packages and current master from git. -- You are receiving this mail because: You are watching all bug changes.
[kdelibs] [Bug 224442] KHistoryComboBox-addToHistory changes currentText (in some cases)
https://bugs.kde.org/show_bug.cgi?id=224442 Peter Mühlenpfordt <de...@ukn8.de> changed: What|Removed |Added Resolution|--- |FIXED Status|UNCONFIRMED |RESOLVED --- Comment #8 from Peter Mühlenpfordt <de...@ukn8.de> --- Can not be reproduced with current KDE/Qt versions. -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 305659] Esc key does not exit full screen mode by default
https://bugs.kde.org/show_bug.cgi?id=305659
Peter Mühlenpfordt <de...@ukn8.de> changed:
What|Removed |Added
Resolution|--- |FIXED
Latest Commit||https://commits.kde.org/gwe
||nview/1e9a4482d9007991730f1
||8aa95735563038be84e
Status|CONFIRMED |RESOLVED
--- Comment #11 from Peter Mühlenpfordt <de...@ukn8.de> ---
Git commit 1e9a4482d9007991730f18aa95735563038be84e by Peter Mühlenpfordt.
Committed on 02/02/2018 at 08:03.
Pushed by muhlenpfordt into branch 'master'.
Exit fullscreen browse mode with Escape
Summary:
Previous versions of gwenview used {key Esc} to exit fullscreen mode.
By changing shortcut handling of {key Esc} this does not work anymore.
This patch adds an `eventFilter()` to leave fullscreen from browse
mode with {key Esc}.
Test Plan:
1. Open gwenview in browse mode
2. Switch to fullscreen mode (e.g. {key F11})
3. Press {key Esc}
-> Should switch back to windowed browse mode
Reviewers: ngraham, rkflx
Reviewed By: rkflx
Differential Revision: https://phabricator.kde.org/D10182
M +18 -0app/browsemainpage.cpp
M +3-0app/browsemainpage.h
https://commits.kde.org/gwenview/1e9a4482d9007991730f18aa95735563038be84e
--
You are receiving this mail because:
You are watching all bug changes.
[gwenview] [Bug 305659] Esc key does not exit full screen mode by default
https://bugs.kde.org/show_bug.cgi?id=305659 --- Comment #9 from Peter Mühlenpfordt <de...@ukn8.de> --- Added a patch for this here: https://phabricator.kde.org/D10182 I don't think Escape should go back to start page. But what about setting a default shortcut, e.g. Ctrl+Home? Clearing the selection in browse mode would be a possibility. Unlike dolphin, gwenview has a default shortcut for Escape and the unselect should only trigger if the shortcut action does nothing (like goto browse mode in browse mode). I don't see any general way to solve this. Dolphin does not clear the selection if any action uses shortcut Escape. -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 306835] Make selecting directory in directory tree to automatically enter Browse mode
https://bugs.kde.org/show_bug.cgi?id=306835 Peter Mühlenpfordt <de...@ukn8.de> changed: What|Removed |Added Latest Commit|https://commits.kde.org/gwe |https://commits.kde.org/gwe |nview/b55420b2ac3dc72ebffdb |nview/8a6a4ea6b9853ef4c9a91 |89dbb9e662d64950ecd |6d2d91d8a7a02ad6b64 Status|REOPENED|RESOLVED Resolution|--- |FIXED --- Comment #6 from Peter Mühlenpfordt <de...@ukn8.de> --- Git commit 8a6a4ea6b9853ef4c9a916d2d91d8a7a02ad6b64 by Peter Mühlenpfordt. Committed on 26/01/2018 at 07:35. Pushed by muhlenpfordt into branch 'master'. Fix issues with clicking directories in tree view Summary: Selecting another directory in tree while showing an image in view mode, opens the first image from the selected directory in view mode. If the folder contains subfolders, gwenview selects the first one and switches to browse mode. This patch changes selection of first **item** back to first **image** (introduced in D8934) to fix this and toggles between browse/view mode only after clicking the already selected directory in tree. Additionally a trailing slash is stripped from the current dir url in context manager to fix a failing compare to initially stored dir url. Test Plan: 1. Open image in view mode 2. Click on another directory in tree view -> Should view the first image in new directory 1. Open image in view mode 2. Click multiple times on the same directory in tree view -> Should toggle browse/view mode Reviewers: rkflx Reviewed By: rkflx Subscribers: ngraham, rkflx Differential Revision: https://phabricator.kde.org/D9886 M +28 -5app/mainwindow.cpp M +2-0app/mainwindow.h M +2-1doc/index.docbook M +2-1lib/contextmanager.cpp https://commits.kde.org/gwenview/8a6a4ea6b9853ef4c9a916d2d91d8a7a02ad6b64 -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 306835] Make selecting directory in directory tree to automatically enter Browse mode
https://bugs.kde.org/show_bug.cgi?id=306835 --- Comment #7 from Peter Mühlenpfordt <de...@ukn8.de> --- According to the Gwenview User Manual, this behaviour is a feature. :-) See here: https://docs.kde.org/stable5/en/kdegraphics/gwenview/sidebar.html Therefore we decided to add toggling between View/Browse Mode by clicking multiple times on a folder. -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 383850] Gwenview shows unreadable paths in Recent Folders
https://bugs.kde.org/show_bug.cgi?id=383850 Peter Mühlenpfordt <de...@ukn8.de> changed: What|Removed |Added CC||de...@ukn8.de -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 385242] Custom shortcut ESC can ostensibly be set, but will not work
https://bugs.kde.org/show_bug.cgi?id=385242
Peter Mühlenpfordt <de...@ukn8.de> changed:
What|Removed |Added
Status|CONFIRMED |RESOLVED
Latest Commit||https://commits.kde.org/gwe
||nview/5bcb8cc92d3774263fe9c
||24cf9cbbf64da22b2f6
Resolution|--- |FIXED
--- Comment #5 from Peter Mühlenpfordt <de...@ukn8.de> ---
Git commit 5bcb8cc92d3774263fe9c24cf9cbbf64da22b2f6 by Peter Mühlenpfordt.
Committed on 22/01/2018 at 09:30.
Pushed by muhlenpfordt into branch 'master'.
Add browse mode action to action collection again
Summary:
The browse mode action with default shortcut {nav Esc} is not added to action
collection (removed in D5824) and therefore not visible/changeable in {nav
Settings > Configure Shortcuts}.
Using {nav Esc} as shortcut for e.g. Quit does not work.
This patch re-adds the browse mode action to action collection, but also checks
for `ShortcutOverride` events to handle active tool dialogs.
Test Plan:
1. Open gwenview
2. Set alternate shortcut {nav Esc} in {nav Settings -> Configure Shortcuts}
for Quit command
3. Press {nav Esc}
-> Should exit gwenview
If tool dialog (crop, red eye reduction) is active, pressing {nav Esc} should
not exit gwenview, but the tool dialog first.
Reviewers: cfeck, rkflx, ngraham
Reviewed By: rkflx, ngraham
Subscribers: ngraham
Differential Revision: https://phabricator.kde.org/D9943
M +1-0app/mainwindow.cpp
M +19 -13 app/viewmainpage.cpp
M +3-1app/viewmainpage.h
https://commits.kde.org/gwenview/5bcb8cc92d3774263fe9c24cf9cbbf64da22b2f6
--
You are receiving this mail because:
You are watching all bug changes.
[gwenview] [Bug 306835] Make selecting directory in directory tree to automatically enter Browse mode
https://bugs.kde.org/show_bug.cgi?id=306835 --- Comment #4 from Peter Mühlenpfordt <de...@ukn8.de> --- The way of passing a new directory url looks ok to me. The problem is (not) switching to browse mode in MainWindow::openSelectedDocuments(), which is done only if no items are selected. In cases with just a few images in the new directory, MainWindow::slotDirListerCompleted() triggers too early and the first item is selected - if this is an image, switching to browse mode does not happen. Selecting a big directory (tested with >5k images) it's ok, since DirLister runs longer. A solution could be switching to browse mode in MainWindow::slotCurrentDirUrlChanged(). This seems to work in a short test. -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 387573] Select first item in folder does not work with semantic filter active
https://bugs.kde.org/show_bug.cgi?id=387573 Peter Mühlenpfordt <de...@ukn8.de> changed: What|Removed |Added Summary|Select first item item in |Select first item in folder |folder does not work with |does not work with semantic |semantic filter active |filter active -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 387573] New: Select first item item in folder does not work with semantic filter active
https://bugs.kde.org/show_bug.cgi?id=387573 Bug ID: 387573 Summary: Select first item item in folder does not work with semantic filter active Product: gwenview Version: Git (add output of "git log -1 --oneline" to description) Platform: Compiled Sources OS: Linux Status: UNCONFIRMED Severity: minor Priority: NOR Component: general Assignee: gwenview-bugs-n...@kde.org Reporter: de...@ukn8.de Target Milestone: --- When entering a folder in browse mode, the first item should be selected. This does not work, if a semantic filter (e.g. rating) is active. See patch https://phabricator.kde.org/D8934 for more technical details. Steps to reproduce: 1. Open gwenview in browse mode 2. Add filter "Filter by Rating" 3. Navigate to another folder with some images inside (and no subfolders) Expected: First thumbnail is selected What happens: Nothing is selected $ git log -1 --oneline 0dd3654c (HEAD -> master, origin/master, origin/HEAD) GIT_SILENT made messages (after extraction) -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 312631] gwenview should not try to put keyboard focus onto the url bar too often.
https://bugs.kde.org/show_bug.cgi?id=312631 Peter Mühlenpfordt <bugsea...@fantasymail.de> changed: What|Removed |Added CC||bugsea...@fantasymail.de --- Comment #5 from Peter Mühlenpfordt <bugsea...@fantasymail.de> --- I created a simple patch, which sets focus to thumbnails on init. https://phabricator.kde.org/D8934 -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 362474] Copy To/Move To does not remember path any more
https://bugs.kde.org/show_bug.cgi?id=362474 --- Comment #17 from Peter Mühlenpfordt <bugsea...@fantasymail.de> --- Patch is uploaded here: https://phabricator.kde.org/D8747 Sorry, I can not confirm bug 374936 or if it's fixed by these patches. -- You are receiving this mail because: You are watching all bug changes.
