[xdg-desktop-portal-kde] [Bug 488508] New: check box broken for screen/window share in portal gui

2024-06-14 Thread Tom Crider
https://bugs.kde.org/show_bug.cgi?id=488508

Bug ID: 488508
   Summary: check box broken for screen/window share in portal gui
Classification: Plasma
   Product: xdg-desktop-portal-kde
   Version: 6.0.5
  Platform: Other
OS: Linux
Status: REPORTED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: plasma-b...@kde.org
  Reporter: gloriouseggr...@gmail.com
CC: aleix...@kde.org, jgrul...@redhat.com, n...@kde.org
  Target Milestone: ---

In the portal gui when you go to share a screen or a window if you just check
the checkbox it does nothing. If you instead click the box of the entire item
it selects it properly and allows sharing.

currently on xdg-desktop-portal-kde 6.0.5

video:
https://streamable.com/zh7u0l

Originally I opened a bug here:
https://invent.kde.org/plasma/xdg-desktop-portal-kde/-/issues/18

It was closed noting MR
https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/4390

But I applied this MR to my current build and it did not fix the issue.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 483584] plasmashell crashing on startup after boot

2024-03-21 Thread Tom Crider
https://bugs.kde.org/show_bug.cgi?id=483584

--- Comment #9 from Tom Crider  ---
(In reply to Nicolas Fella from comment #7)
> The backtraces here point to an issue with the QML disk cache, so it makes
> sense that clearing the cache fixes it.
> 
> Any issues specific to X11 or Wayland or a particular display setup are most
> likely unrelated bugs

wrt that it might be worth retesting then as there was a recent rebuild for qml
as of a yesterday (6.0.2-2 packages in nobara)

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 483584] plasmashell crashing on startup after boot

2024-03-20 Thread Tom Crider
https://bugs.kde.org/show_bug.cgi?id=483584

Tom Crider  changed:

   What|Removed |Added

 CC||gloriouseggr...@gmail.com

--- Comment #5 from Tom Crider  ---
I was able to reproduce the issue.

It appears at least from testing on Nobara that plasma-x11 session only wants
to load if a single display is connected. Any more than one and either plasma
hangs at a black screen or boots out back to sddm login screen

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-ki18n] [Bug 482657] Underlined characters in titles rendered incorrectly as ampersands in KDE6

2024-03-07 Thread Tom Crider
https://bugs.kde.org/show_bug.cgi?id=482657

--- Comment #2 from Tom Crider  ---
For additional reference I also noticed when loaded correctly in gnome it does
not have underlined characters on the dock widget titles, so this should be the
correct behavior for kde as well.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-ki18n] [Bug 482657] Underlined characters in titles rendered incorrectly as ampersands in KDE6

2024-03-07 Thread Tom Crider
https://bugs.kde.org/show_bug.cgi?id=482657

--- Comment #1 from Tom Crider  ---
Turns out this is a QT bug.
Same bug listed here:

https://bugreports.qt.io/browse/QTBUG-86407

The same fix from this commit:
https://github.com/qt/qtbase/commit/cc67b25579c1bb5ea9f5c1ca4c9b7997e66f19b9

Also needs to be applied to QDockWidget inside qstylesheetstyle. obs-studio
uses stylesheets so that clued me in:
```
>From 519cfee1bb6c1477a2cc5efdb2c9997904ddcbed Mon Sep 17 00:00:00 2001
From: GloriousEggroll 
Date: Thu, 7 Mar 2024 01:28:08 -0700
Subject: [PATCH] fix underlined text in dock widget titles rendering as
 ampersands

---
 src/widgets/styles/qstylesheetstyle.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/widgets/styles/qstylesheetstyle.cpp
b/src/widgets/styles/qstylesheetstyle.cpp
index 1ba8aa7c..37685b5f 100644
--- a/src/widgets/styles/qstylesheetstyle.cpp
+++ b/src/widgets/styles/qstylesheetstyle.cpp
@@ -4484,7 +4484,7 @@ void QStyleSheetStyle::drawControl(ControlElement ce,
const QStyleOption *opt, Q

 QString titleText = p->fontMetrics().elidedText(dwOpt->title,
Qt::ElideRight, r.width());
 drawItemText(p, r,
- alignment, dwOpt->palette,
+ alignment | Qt::TextHideMnemonic, dwOpt->palette,
  dwOpt->state & State_Enabled, titleText,
  QPalette::WindowText);

-- 
2.44.0

```

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-ki18n] [Bug 482657] Underlined characters in titles rendered incorrectly as ampersands in KDE6

2024-03-06 Thread Tom Crider
https://bugs.kde.org/show_bug.cgi?id=482657

Tom Crider  changed:

   What|Removed |Added

   Platform|Other   |Fedora RPMs

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-ki18n] [Bug 482657] New: Underlined characters in titles rendered incorrectly as ampersands in KDE6

2024-03-06 Thread Tom Crider
https://bugs.kde.org/show_bug.cgi?id=482657

Bug ID: 482657
   Summary: Underlined characters in titles rendered incorrectly
as ampersands in KDE6
Classification: Frameworks and Libraries
   Product: frameworks-ki18n
   Version: 6.0.0
  Platform: Other
OS: Linux
Status: REPORTED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: caslav.i...@gmx.net
  Reporter: gloriouseggr...@gmail.com
CC: kdelibs-b...@kde.org
  Target Milestone: ---

Created attachment 166549
  --> https://bugs.kde.org/attachment.cgi?id=166549=edit
ampersands where titles are.

In the screenshot attached, there are random ampersands (&) where underlined
characters should be in Scenes/Sources etc.

I was hitting it in Nobara first, so I spun up a vanilla fedora 40 VM and was
able to reproduce
it only happens with obs-studio + KDE 6
furthermore I can do XDG_CURRENT_DESKTOP=gnome and it works around the bug.

After digging I found if I remove kf6-ki18n it fixes it. (forcefully via rpm -e
--nodeps). Obv, not an actual fix but at least a lead on the cause.

Original obs-studio bug report opened here:
https://github.com/obsproject/obs-studio/issues/10341

-- 
You are receiving this mail because:
You are watching all bug changes.

[kde-cli-tools] [Bug 429408] kde-open5 changes case of argument

2024-01-23 Thread Tom Crider
https://bugs.kde.org/show_bug.cgi?id=429408

--- Comment #26 from Tom Crider  ---
(In reply to Bug Janitor Service from comment #25)
> A possibly relevant merge request was started @
> https://invent.kde.org/plasma/kde-cli-tools/-/merge_requests/99

Tested MR 99 on kde5, modified for thunderlinks and slack:

+if ((url.startsWith(QLatin1String("thunderlink://"))) ||
(url.startsWith(QLatin1String("slack://" {
+// :// -> :/// so QUrl doesn't break the payload's

It's working well here. Will test on kde6 shortly

-- 
You are receiving this mail because:
You are watching all bug changes.

[kde-cli-tools] [Bug 429408] kde-open5 changes case of argument

2024-01-19 Thread Tom Crider
https://bugs.kde.org/show_bug.cgi?id=429408

--- Comment #24 from Tom Crider  ---
I'm unable to edit my comments. anyway previously applied patches caused some
encoding issues, had to limit them further:

+if ((domain.toStdString().find("slack://") >= 0) ||
(domain.toStdString().find("thunderlink://") >= 0)) {
+return domain;
+}

-- 
You are receiving this mail because:
You are watching all bug changes.

[kde-cli-tools] [Bug 429408] kde-open5 changes case of argument

2024-01-16 Thread Tom Crider
https://bugs.kde.org/show_bug.cgi?id=429408

--- Comment #22 from Tom Crider  ---
not sure why i went around my butt to get to my elbow for those :facepalm:,
could have been much simpler. assuming the issue only occurs when :// is passed
and generally :// shouldn't be passed from applications -- I just ended up
doing this:

qt5-qtbase:
---
diff --git a/src/corelib/io/qurlidna.cpp b/src/corelib/io/qurlidna.cpp
index a2f0caa6..ad18d5b6 100644
--- a/src/corelib/io/qurlidna.cpp
+++ b/src/corelib/io/qurlidna.cpp
@@ -2490,6 +2490,10 @@ QString qt_ACE_do(const QString , AceOperation
op, AceLeadingDot dot)
 if (domain.isEmpty())
 return domain;

+if (domain.toStdString().find("://") >= 0){
+return domain;
+}
+
 QString result;
 result.reserve(domain.length());

---

qt6-qtbase:
---
diff --git a/src/corelib/io/qurlidna.cpp b/src/corelib/io/qurlidna.cpp
index bb14e1cd..204085c2 100644
--- a/src/corelib/io/qurlidna.cpp
+++ b/src/corelib/io/qurlidna.cpp
@@ -892,6 +892,10 @@ QString qt_ACE_do(const QString , AceOperation op,
AceLeadingDot dot,
 if (domain.isEmpty())
 return {};

+if (domain.toStdString().find("://") >= 0){
+return domain;
+}
+
 bool mappedToAscii;
 const QString mapped = mapDomainName(domain, options, );
 const QString normalized =
---

-- 
You are receiving this mail because:
You are watching all bug changes.

[kde-cli-tools] [Bug 429408] kde-open5 changes case of argument

2024-01-12 Thread Tom Crider
https://bugs.kde.org/show_bug.cgi?id=429408

--- Comment #21 from Tom Crider  ---
Alternate version for qt6-qtbase:
```
diff --git a/src/corelib/io/qurlidna.cpp b/src/corelib/io/qurlidna.cpp
index bb14e1cd..1c560975 100644
--- a/src/corelib/io/qurlidna.cpp
+++ b/src/corelib/io/qurlidna.cpp
@@ -892,8 +892,19 @@ QString qt_ACE_do(const QString , AceOperation op,
AceLeadingDot dot,
 if (domain.isEmpty())
 return {};

+/* Check for url quirk such as slack or thunderlink.
+We do this before mapDomainName because mapDomainName will
+cast it to lowercase, and some urls are case sensitive.
+If that is resolved in the future then we need to call before
+mappedToAscii, because that strips the : from the url. */
+QString quirkcheck = "://";
+if (domain.toStdString().find(quirkcheck.toStdString()) >= 0){
+return domain;
+}
+
 bool mappedToAscii;
 const QString mapped = mapDomainName(domain, options, );
+
 const QString normalized =
 mappedToAscii ? mapped :
mapped.normalized(QString::NormalizationForm_C);
 ```

-- 
You are receiving this mail because:
You are watching all bug changes.

[kde-cli-tools] [Bug 429408] kde-open5 changes case of argument

2024-01-10 Thread Tom Crider
https://bugs.kde.org/show_bug.cgi?id=429408

Tom Crider  changed:

   What|Removed |Added

 CC||gloriouseggr...@gmail.com

--- Comment #20 from Tom Crider  ---
Based on the information given I made a small workaround patch for qt5-qtbase. 
I needed this functionality to work for slack. No idea if it's any kind of
acceptable approach/welcome to suggestions:

```
diff --git a/src/corelib/io/qurlidna.cpp b/src/corelib/io/qurlidna.cpp
index a2f0caa6..88748cb3 100644
--- a/src/corelib/io/qurlidna.cpp
+++ b/src/corelib/io/qurlidna.cpp
@@ -2532,10 +2532,10 @@ QString qt_ACE_do(const QString , AceOperation
op, AceLeadingDot dot)
 ushort uc = in->unicode();
 if (uc > 0x7f)
 simple = false;
-if (uc >= 'A' && uc <= 'Z')
-*out = QChar(uc | 0x20);
-else
-*out = *in;
+/*if (uc >= 'A' && uc <= 'Z')
+*out = QChar(uc | 0x20);*/
+/*else*/
+*out = *in;
 }
 }

```

-- 
You are receiving this mail because:
You are watching all bug changes.