[amarok] [Bug 337849] Last played time not updated on some tracks

2024-06-11 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=337849

Tuomas Nurmi  changed:

   What|Removed |Added

 CC||martin.bo...@bonuama.de

--- Comment #19 from Tuomas Nurmi  ---
*** Bug 488210 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 488210] Replay Counter / last Replay doesn't write in ogg-files

2024-06-11 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=488210

Tuomas Nurmi  changed:

   What|Removed |Added

 CC||tuo...@norsumanageri.org
 Resolution|--- |DUPLICATE
 Status|REPORTED|RESOLVED

--- Comment #1 from Tuomas Nurmi  ---
Thank you for the report. I believe the issue is same as the one described in
https://bugs.kde.org/show_bug.cgi?id=337849 , so marking as such. I'll probably
try to inspect this more in a couple of weeks.

*** This bug has been marked as a duplicate of bug 337849 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 487937] Amarok crashes on startup in Debian

2024-06-10 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=487937

--- Comment #5 from Tuomas Nurmi  ---
Great to hear you managed to solve the issue! Happy listening!

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 487937] Amarok crashes on startup in Debian

2024-06-08 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=487937

--- Comment #3 from Tuomas Nurmi  ---
Thank you for the additional information!

Sounds somewhat odd. However, the fact that you encounter the crash on multiple
machines, but people using the official Debian packages don't seem to have the
problem in general,  would suggest there might be some common denominator in
your environment. 
I guess one possibility could be something related to your systems' locale (the
"mysql_embedded: Warning: Charset id '83' csname 'utf8' trying to replace
existing csname 'utf8mb3'" doesn't sound like something I recall seeing in
output myself, but I'm not sure); or, seeing the samba libs in backtrace,
something related to your network environment.
I wonder what would happen if you tried temporarily removing/hiding
libsamba-util.so.0

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 487937] Amarok crashes on startup in Debian

2024-06-05 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=487937

Tuomas Nurmi  changed:

   What|Removed |Added

 CC||tuo...@norsumanageri.org

--- Comment #1 from Tuomas Nurmi  ---
Thank you for your report; looks interesting. The fact that bitmap_copy in
libsamba-util.so.0 is called from libmariadbd.so.19 seems a little suspicious
(I could be wrong, though); at least on my openSUSE system, libmariadbd.so.19
doesn't seem to link against anything samba related.
I'll try to figure out if there's something that could be easily tested (or
possibly I'll try installing a Debian sid system myself later and see if I can
reproduce)

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 322107] Amarok creates MP3 invalid files with bitrate above 320 Kbps

2024-06-02 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=322107

Tuomas Nurmi  changed:

   What|Removed |Added

 CC||tuo...@norsumanageri.org

--- Comment #10 from Tuomas Nurmi  ---
I tried adding
parameters << QStringLiteral("-write_xing") << QStringLiteral("0"); 
to Mp3Format::ffmpegParameters() and although I can observe some differences in
tracks transcoded with and without that parameter, I haven't yet found a way to
measure what is the maximal bitrate. Any hints welcome.

"and the transcode removes the originals"
sounds strange, doesn't happen here when I'm doing the transcoding via "Copy to
Collection"; the original remains in place

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 450500] Amarok boosts audio to the maximum, with manual track changes

2024-06-02 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=450500

--- Comment #10 from Tuomas Nurmi  ---
That's great to hear, thank you! Happy listening!

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 450500] Amarok boosts audio to the maximum, with manual track changes

2024-06-01 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=450500

Tuomas Nurmi  changed:

   What|Removed |Added

 CC||tuo...@norsumanageri.org

--- Comment #8 from Tuomas Nurmi  ---
I don't think I've ever encountered this (mainly phonon-qt5-gstreamer user).
Could be something that has been fixed since somewhere, although I can't right
away think of any specific change that might have been the solution.
Do you still encounter this with Amarok 3.0.0 and recent KDE/Phonon versions?

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 281706] add search/filtering/grouping to covergrid

2024-06-01 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=281706

Tuomas Nurmi  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
 CC||tuo...@norsumanageri.org
 Resolution|--- |UNMAINTAINED

--- Comment #2 from Tuomas Nurmi  ---
Closing as covergrid hasn't worked since Qt4/KDE4 versions and the sources were
just removed from git master with
https://invent.kde.org/multimedia/amarok/-/commit/6c5a54284d2366ffe8b025a88b241b39e173f2bc
. Covergrid was neat; hopefully something similar can be implemented after Qt6
port.

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 220327] wish: integrate moodbar generator

2024-05-29 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=220327

Tuomas Nurmi  changed:

   What|Removed |Added

 CC||theun...@gmail.com

--- Comment #20 from Tuomas Nurmi  ---
*** Bug 328692 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 328692] You should make moodbar as Clementine does...

2024-05-29 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=328692

Tuomas Nurmi  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 CC||tuo...@norsumanageri.org
 Status|REPORTED|RESOLVED

--- Comment #3 from Tuomas Nurmi  ---
Heh, funny, this is actually a duplicate.

*** This bug has been marked as a duplicate of bug 220327 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 199483] Make "Album Artist/Album" collection browser mode the default

2024-05-29 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=199483

Tuomas Nurmi  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|REOPENED|RESOLVED
 CC||tuo...@norsumanageri.org

--- Comment #36 from Tuomas Nurmi  ---
This seems to have been fixed with commit
78415dfb1d44c59a0f53748071ce57b794abd83a in June 2013. Closing.

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 321107] Import OPML file for Podcast not working.

2024-05-29 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=321107

Tuomas Nurmi  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED
 CC||tuo...@norsumanageri.org

--- Comment #6 from Tuomas Nurmi  ---
Closing, as this works nowadays and was apparently fixed a couple of years ago.

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 420964] Current Track applet layout a mess

2024-05-29 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=420964

--- Comment #12 from Tuomas Nurmi  ---
Great to hear, thank you! Happy listening!

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 487730] Crash when typing in search box

2024-05-29 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=487730

Tuomas Nurmi  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|REPORTED|RESOLVED
 CC||tuo...@norsumanageri.org

--- Comment #1 from Tuomas Nurmi  ---
I believe this has been fixed since 2.9.71, please update Amarok to 3.0.0.
(3.0.0 doesn't seem to be available in any official repository for openSUSE
Leap 15.5, but at least home:ecsos and home:plasmaregataos community
repositories seem to provide packages for it)

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 313791] "Remove duplicates" function does not work completely

2024-05-28 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=313791

Tuomas Nurmi  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
  Latest Commit||https://invent.kde.org/mult
   ||imedia/amarok/-/commit/1569
   ||068ddc911e1a8970aa3afe2ae6d
   ||5986d3877
 Resolution|--- |FIXED

--- Comment #22 from Tuomas Nurmi  ---
Git commit 1569068ddc911e1a8970aa3afe2ae6d5986d3877 by Tuomas Nurmi.
Committed on 28/05/2024 at 17:45.
Pushed by nurmi into branch 'master'.

Avoid deleting multiple tracks instead of one

Additionally, testing with a sample track provided on bug report, an earlier
bug
where duplicate removal didn't work for some specific tracks seems to have been
fixed.

M  +1-0ChangeLog
M  +5-5src/playlist/PlaylistController.cpp

https://invent.kde.org/multimedia/amarok/-/commit/1569068ddc911e1a8970aa3afe2ae6d5986d3877

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 290270] Lyrics applet does not use I-Beam cursor

2024-05-28 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=290270

Tuomas Nurmi  changed:

   What|Removed |Added

 CC||tuo...@norsumanageri.org
 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED

--- Comment #7 from Tuomas Nurmi  ---
I-Beam in 3.0.0. Closing.

-- 
You are receiving this mail because:
You are watching all bug changes.

[taglib] [Bug 252805] amarokcollectionscanner segfaults on faulty .ra file

2024-05-28 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=252805

Tuomas Nurmi  changed:

   What|Removed |Added

 CC||_...@gmx.net

--- Comment #13 from Tuomas Nurmi  ---
*** Bug 344655 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 344655] amarokcollectionscanner: "Segmentation fault (core dumped)", no log in ~/.kde if called from inside Amarok

2024-05-28 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=344655

Tuomas Nurmi  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 CC||tuo...@norsumanageri.org
 Resolution|--- |DUPLICATE

--- Comment #38 from Tuomas Nurmi  ---
Seems to be a duplicate of a taglib-extras bug. Fixing should happen there
(although probably won't, as last commit in taglib-extras was 8 years ago),
closing.

*** This bug has been marked as a duplicate of bug 252805 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 486457] build of amarok3 crashes on starte

2024-05-28 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=486457

--- Comment #4 from Tuomas Nurmi  ---
Did you manage to get a working build?

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 442319] Closing Amarok with playback volume set at 100% and then reopening has volume set at 0%

2024-05-27 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=442319

Tuomas Nurmi  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/mult
   ||imedia/amarok/-/commit/5587
   ||e27f06701dd84393da54c8dd93a
   ||70d83f203
 Status|ASSIGNED|RESOLVED

--- Comment #6 from Tuomas Nurmi  ---
Git commit 5587e27f06701dd84393da54c8dd93a70d83f203 by Tuomas Nurmi.
Committed on 27/05/2024 at 21:28.
Pushed by nurmi into branch 'master'.

Avoid volume getting set to 0 when phonon-vlc playback is stopped

Shouldn't affect behaviour with other backend(s), which do not experience the
bug.

M  +1-0ChangeLog
M  +3-0src/EngineController.cpp

https://invent.kde.org/multimedia/amarok/-/commit/5587e27f06701dd84393da54c8dd93a70d83f203

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 442319] Closing Amarok with playback volume set at 100% and then reopening has volume set at 0%

2024-05-26 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=442319

Tuomas Nurmi  changed:

   What|Removed |Added

 Status|REOPENED|CONFIRMED
 CC||tuo...@norsumanageri.org

--- Comment #4 from Tuomas Nurmi  ---
Based on discussion and extra information on mailing list, I managed to
reproduce at least one case where this happens:
With Phonon VLC backend, if a playing track is stopped, master volume is set to
0. Playback will continue with correct volume if a next track is played.
However, if Amarok is shut down with playback stopped, the 0 gets written as
the master volume setting and will be the initial volume on next startup. Will
create a fix MR shortly.

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 487518] Unable to modify playlist layout on git master

2024-05-25 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=487518

Tuomas Nurmi  changed:

   What|Removed |Added

 CC||tuo...@norsumanageri.org

--- Comment #2 from Tuomas Nurmi  ---
Ah, I see that's probably not totally intuitive, but the menu shown in the
screenshot is for changing playlist filter/search settings.

You should be able to change playlist layout from [top menubar] -> Playlist ->
Playlist Layouts -> Configure Playlist Layouts... (or by selecting one of the
default layouts in that menu)

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 486342] Equalizer

2024-05-25 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=486342

--- Comment #14 from Tuomas Nurmi  ---
Ok, good to know.
Yes, phonon4qt5-backend-gstreamer is not in default openSUSE repositories any
more, but should be still available from KDE:Unstable:Frameworks:
https://build.opensuse.org/package/show/KDE%3AUnstable%3AFrameworks/phonon4qt5-backend-gstreamer

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 486342] Equalizer

2024-05-25 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=486342

--- Comment #12 from Tuomas Nurmi  ---
Phonon-gstreamer on openSUSE: Hmm, can you verify if you have the package
phonon4qt5-backend-gstreamer installed? If yes, then I'm not totally sure
what's up. (I guess it could have something to do with the fact that there are
phonon4qt5 and phonon4qt6 packages available but gstreamer backend packages
available only for phonon4qt5, but that's just wild speculating)
Compiling an own build from https://invent.kde.org/libraries/phonon-gstreamer/
is also possible, although requires some technical know-how.

And no worries keeping the report open: Not having a short term fix does not
mean a bug report needs to be closed - 3.0.0 fixed a couple of 15 year old
ones. (But I'm quite confident getting this one fixed won't take a decade!)
There's a bit of technical catching up to do all around, but nothing too
overwhelming.

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 486342] Equalizer

2024-05-23 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=486342

--- Comment #9 from Tuomas Nurmi  ---
Yes, fine questions. Some answers:
As phonon-gstreamer backend is unmaintainend (related discussion at
https://invent.kde.org/libraries/phonon-gstreamer/-/issues/1 ) and thus
unsupported, it has lately been removed from various distribution repositories.
For openSUSE, the packages are still available at various experimental
repositories (
https://software.opensuse.org/package/phonon4qt5-backend-gstreamer )
However, due to fact that it is unsupported, even its most obvious and fixable
bugs will not get fixed (e.g. 
https://bugs.kde.org/show_bug.cgi?id=475880 )

If multiple backends are installed, Phonon backend can be changed using
phononsettings application (available from separate phononsettings package, at
least on openSUSE). The packagers have set phonon-vlc-qt5 as dependency
probably as it is the only supported backend at the moment (okay, there's
apparently also phonon4qt5-backend-mpv but I have no experience with that one,
and it being a fork of phonon-vlc, its features are likely subset of those of
phonon-vlcs), and some backend is needed.

When talking about "phonon-vlc team", one should be aware that although there
are some people keeping the lights on with phonon-vlc, the actual development
work on it (as well as anything phonon-related) has been quite limited for 5
years or so, as observable from e.g. the code history at
https://invent.kde.org/libraries/phonon-vlc/-/commits/master/?ref_type=HEADS

Additionally, I believe Amarok is the only software using the more specific
audio functionalities in Phonon nowadays.
(Some Amarok functionality related phonon-vlc bugreports, which are not very
likely to get implemented any time soon mostly due to vlc library
architechture: https://bugs.kde.org/show_bug.cgi?id=323332 and
https://bugs.kde.org/show_bug.cgi?id=320215 )

Next steps of Amarok audio playback technology are something that should
receive some thoughts after/during Qt6 porting, I think. (The most obvious
options being someone spending a lot of effort on phonon-vlc, someone taking up
maintaining phonon-gstreamer, or rewriting Amarok audio playback to use e.g.
gstreamer directly)

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 486342] Equalizer

2024-05-22 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=486342

--- Comment #6 from Tuomas Nurmi  ---
Yes, the analyzer is only supported by phonon-gstreamer backend. Related
functionality was disabled in phonon-vlc backend 11 years ago due to changes in
vlc libraries:
https://invent.kde.org/libraries/phonon-vlc/-/commit/942a97e92a932ebdca049e3f893fb3f9fec62df8
(and later completely removed).

Indeed it is kind of related to equalizer behaviour, as these both depend on
the phonon backend in use. The current available phonon backend options are
phonon-vlc, which exhibits these issues, and phonon-gstreamer which is not
maintained (and might exhibit some other issues in some other software). I
haven't yet inspected the equalizer applying any deeper, but the fact that it
works pretty good with phonon-gstreamer suggests that fixing it with phonon-vlc
would probably require work inside the phonon-vlc backend.

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 390063] Anazyler should be disabled when the Context View is disabled, instead keeps running

2024-05-22 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=390063

Tuomas Nurmi  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/mult
   ||imedia/amarok/-/commit/6b10
   ||f5d938634570dc3cc11ce308e82
   ||ae9a5e019

--- Comment #6 from Tuomas Nurmi  ---
Git commit 6b10f5d938634570dc3cc11ce308e82ae9a5e019 by Tuomas Nurmi.
Committed on 22/05/2024 at 17:33.
Pushed by nurmi into branch 'master'.

Don't feed analyzer new data if it is minimized or hidden

M  +1-0ChangeLog
M  +1-0src/MainWindow.h
M  +7-1src/context/applets/analyzer/plugin/AnalyzerBase.cpp
M  +4-1src/context/applets/analyzer/plugin/AnalyzerBase.h
M  +4-0src/context/applets/analyzer/plugin/BlockAnalyzer.cpp

https://invent.kde.org/multimedia/amarok/-/commit/6b10f5d938634570dc3cc11ce308e82ae9a5e019

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 327891] Pulsating current track indication is CPU intensive

2024-05-22 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=327891

Tuomas Nurmi  changed:

   What|Removed |Added

 CC||tuo...@norsumanageri.org

--- Comment #35 from Tuomas Nurmi  ---
I've had a look at this, too, while working on other CPU usage improvements (
https://invent.kde.org/multimedia/amarok/-/merge_requests/98 ). I don't know if
this is more common with Qt5 than it was earlier, but at least I'm experiencing
notable CPU usage caused by current track indicator with Nvidia, Intel and
VirtualBox systems.

Analyzing a bit deeper, the two major factors of the load seem to be the fact
that a redraw is requested  approx 444 times every second (although the actual
rate of repaints is limited by the UI update rate, which seems to be something
like 30 FPS), and the fact that every repaint involves building the currently
playing delegate from the ground up, including text rendering, possibly cover,
moodbar, and rating painting, and rendering the pulsating overlay svg pieces.
As the playlist is QWidget based, optimizing the repainting or offloading some
steps to GPU is not quite as straightforward as it could be with some other
technical implementations. Limiting the repaint rate to e.g. approx 10 FPS
would reduce  the CPU usage somewhat, although it still seems to remain
notable.

I'm considering limiting the FPS as short-term solution, as the effect on
visuals doesn't seem to be that bad. Assessing the technical foundations of
playlist painting might be something to do during/after Qt6 port.

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 487199] to be able to resize the central window where is showed lyrics, current track, etc... [suggestion]

2024-05-20 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=487199

--- Comment #5 from Tuomas Nurmi  ---
It's always both nice and useful to hear user experiences and feedback! Even in
cases where a feature exists, any case where it hasn't been discovered yet is a
signal to take note of. And with a bit of luck, at least someone else wondering
the same thing might happen to come across this report and learn of the feature
that way.

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 487199] to be able to resize the central window where is showed lyrics, current track, etc... [suggestion]

2024-05-19 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=487199

Tuomas Nurmi  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
 Resolution|--- |FIXED

--- Comment #3 from Tuomas Nurmi  ---
Okay, very good to hear!
I didn't know that it could be changed in edit mode either for a long time; I
just found out when preparing 3.0. I added the highlight bar to applet lower
border as a hint so it would be a bit more discoverable. It could probably use
even more hints, too, but I don't have any ideas yet what they could be.

It is true that having two different edit modes (= one for the panels and one
for the applets in context panel) is not that intuitive. However, unifying them
as one wouldn't maybe be optimal solution either, as locking the panel layout
changes the context views height a bit, so it would make sizing applets a bit
messy.

Maybe I'll close this bug, but I'll try to think if I can come up with any more
related improvements.

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 486084] Collection scan failure for tracks with "inf dB" in REPLAYGAIN_TRACK_GAIN tag field

2024-05-19 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=486084

Tuomas Nurmi  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/mult
   ||imedia/amarok/-/commit/8cd6
   ||f9cd018d13ba1b3800a8db3cddc
   ||4c70ed649
 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #3 from Tuomas Nurmi  ---
Git commit 8cd6f9cd018d13ba1b3800a8db3cddc4c70ed649 by Tuomas Nurmi.
Committed on 17/05/2024 at 20:27.
Pushed by nurmi into branch 'master'.

Ignore any infinite values when reading replaygain tags

Apparently QString::toFloat converts them happily to qreals with infinite
value.
We don't really want them in database, however. Also edit
TestMetaTrack::testReplayGain
to check that inf gain is ignored.

M  +1-0ChangeLog
M  +3-3shared/MetaReplayGain.cpp
M  +5-0tests/core/meta/TestMetaTrack.cpp
M  +---tests/data/audio/album/Track03.ogg

https://invent.kde.org/multimedia/amarok/-/commit/8cd6f9cd018d13ba1b3800a8db3cddc4c70ed649

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 487199] to be able to resize the central window where is showed lyrics, current track, etc... [suggestion]

2024-05-18 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=487199

Tuomas Nurmi  changed:

   What|Removed |Added

 CC||tuo...@norsumanageri.org

--- Comment #1 from Tuomas Nurmi  ---
Hi, thank you for your request! The bugtracker also contains the wishlist, so
this is the right place!
I'm not sure if I've grasped your idea yet, however; do you mean you would like
current track and lyrics to have different width? (The context area's common
width can be changed by dragging from the edge, and the individual height of
each applet can be changed by dragging in edit mode).  Could you perhaps
provide some kind of mockup on your idea?

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 472485] Segfault in Dynamic Playlist continuous generation

2024-05-18 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=472485

--- Comment #4 from Tuomas Nurmi  ---
I tried playing a dynamic playlist with narrow subset for a hour but didn't
manage to crash Amarok yet. I might try again later, but looking at backtraces,
this might have something to do with ThreadWeaver usages in KF5 port. I think
they could use some deeper reworking to fix some underlying issues, but that's
probably something to do with Qt6 port, as they work somewhat OK now, and
re-working them might impact many things.

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 382456] Amarok APG: crashes if checkpoint is unassigned in CheckpointConstraint

2024-05-16 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=382456

--- Comment #5 from Tuomas Nurmi  ---
Sounds good, makes sense. Change committed in
https://invent.kde.org/multimedia/amarok/-/commit/aad011a2ab722fd363870e7aa502e1663bee33bc
- thank you for the comment!

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 334579] too much useless knotify output when playing audio cd

2024-05-11 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=334579

Tuomas Nurmi  changed:

   What|Removed |Added

 CC||tuo...@norsumanageri.org

--- Comment #2 from Tuomas Nurmi  ---
I remember seeing this earlier, but now trying with 3.0.0, I'm not getting any
of those "examining" notifications and I do have notifications enabled etc. I
wonder if this got fixed when doing other audio cd related work some weeks ago,
or if I've changed some setting whose effect on the notifications is not
apparent...

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 486517] Cannot play audio CDs with Amarok because it always shows 0 tracks

2024-05-10 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=486517

--- Comment #8 from Tuomas Nurmi  ---
Okay, just managed to play audio cd with Amarok on Plasma6 system (openSUSE). I
needed to install an additional kio_audiocd5, but it was co-installable with
kf6 kio-audiocd without any obvious problems, so this issue fortunately
something that is solvable with some packaging finetuning.

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 471216] Amarok starts using 100% CPU after a time playing

2024-05-10 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=471216

Tuomas Nurmi  changed:

   What|Removed |Added

 CC||tuo...@norsumanageri.org

--- Comment #2 from Tuomas Nurmi  ---
I'd be very interested to hear if you still experience this issue with 3.0.0

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 486811] no context panel

2024-05-09 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=486811

Tuomas Nurmi  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
 Resolution|--- |FIXED

--- Comment #5 from Tuomas Nurmi  ---
Nice, that's very great to hear!
Happy listening!

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 486811] no context panel

2024-05-09 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=486811

Tuomas Nurmi  changed:

   What|Removed |Added

 CC||tuo...@norsumanageri.org

--- Comment #1 from Tuomas Nurmi  ---
Hi,
thank you for your report. I believe there's some issue with paths on your
Amarok installation, causing the context applet qml files to be not found. If
you run `amarok --debug`, the output will probably provide some hints on the
exact problem.

This could also be a case of multiple amarok binaries existing in the system,
and the wrong one getting started and context applets searched from wrong path.
https://discuss.kde.org/t/amarok-3-0-beta-2-9-82-out-now/13947/39 contains some
ideas what to try, especially if you built Amarok manually (if not, the second
part of the message can be replaced with reinstalling the system binary
packages)

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 210547] print icon in the lyrics applet

2024-05-08 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=210547

Tuomas Nurmi  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
 CC||tuo...@norsumanageri.org
 Resolution|--- |NOT A BUG

--- Comment #1 from Tuomas Nurmi  ---
Maybe this kind of feature is not relevant any more in the 2020's; closing.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Phonon] [Bug 486468] Phonon-vlc with pipewire output crashes when Phonon::AudioOutput::setVolume is called without media

2024-05-08 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=486468

Tuomas Nurmi  changed:

   What|Removed |Added

Summary|Amarok 2.9.71 crashes at|Phonon-vlc with pipewire
   |startup on Fedora 40|output crashes when
   ||Phonon::AudioOutput::setVol
   ||ume is called without media
Product|amarok  |Phonon
Version|2.9.71  |unspecified
   Assignee|amarok-bugs-d...@kde.org|unassigned-b...@kde.org
  Component|general |general
 CC||myr...@kde.org,
   ||romain.per...@gmail.com,
   ||sit...@kde.org
   Target Milestone|kf5 |---

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 486468] Amarok 2.9.71 crashes at startup on Fedora 40

2024-05-08 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=486468

--- Comment #10 from Tuomas Nurmi  ---
Managed to crash dragonplayer, too, so this is pretty clearly a phonon bug.
Editing bug metadata.

Crash seems to happen often/always when Phonon::AudioOutput::setVolume is
called while no media is loaded. 

Reproducible at least on Fedora 40, phononsettings -> select "Show additional
devices" (or what ever that may be in English), and make PipeWire Sound Server
the primary audio output device -> try starting up amarok or dragon a couple of
times

Backtrace from crashing dragonplayer run through gdb, took about 5 tries to get
it crash.
Starting program: /usr/bin/dragon 
[Thread debugging using libthread_db enabled]   
Using host libthread_db library "/lib64/libthread_db.so.1".
[New Thread 0x7fffe34006c0 (LWP 18422)] 
[New Thread 0x7fffe1c006c0 (LWP 18423)] 
[New Thread 0x7fffe12006c0 (LWP 18424)]
[New Thread 0x7fffdbe006c0 (LWP 18425)]
[New Thread 0x7fffdb4006c0 (LWP 18426)] 
[New Thread 0x7fffdaa006c0 (LWP 18427)]
[New Thread 0x7fffda0006c0 (LWP 18428)] 
[New Thread 0x7fffd96006c0 (LWP 18429)]
[New Thread 0x7fffd8c006c0 (LWP 18430)]
MESA: error: ZINK: failed to choose pdev
libEGL warning: egl: failed to create dri2 screen
[New Thread 0x7fffcd8006c0 (LWP 18431)] 
[New Thread 0x7fffcce006c0 (LWP 18432)]
[New Thread 0x7fffc3e006c0 (LWP 18433)]
[New Thread 0x7fffc34006c0 (LWP 18434)]
[New Thread 0x7fffc2a006c0 (LWP 18435)]
[New Thread 0x7fffc20006c0 (LWP 18436)]
[New Thread 0x7fffc16006c0 (LWP 18437)]
[New Thread 0x7fffc0c006c0 (LWP 18438)] 
[New Thread 0x7fffb7e006c0 (LWP 18439)]
[New Thread 0x7fffb74006c0 (LWP 18440)]
[New Thread 0x7fffb6a006c0 (LWP 18441)] 
[New Thread 0x7fffb60006c0 (LWP 18442)]
qt.core.qobject.connect: QObject::connect: No such signal
Phonon::VLC::MediaObject::angleChanged(int)
qt.core.qobject.connect: QObject::connect: No such signal
Phonon::VLC::MediaObject::availableAnglesChanged(int)
qt.core.qobject.connect: QObject::connect: No such signal
Phonon::VLC::MediaObject::angleChanged(int)
qt.core.qobject.connect: QObject::connect: No such signal
Phonon::VLC::MediaObject::availableAnglesChanged(int)

Thread 1 "dragon" received signal SIGSEGV, Segmentation fault.
___pthread_mutex_lock (mutex=mutex@entry=0x28) at pthread_mutex_lock.c:80
80unsigned int type = PTHREAD_MUTEX_TYPE_ELISION (mutex);   
(gdb) bt
#0  ___pthread_mutex_lock (mutex=mutex@entry=0x28) at pthread_mutex_lock.c:80
#1  0x7fffdbfc3957 in do_lock.isra.0 (this=this@entry=0x0) at
../src/pipewire/thread-loop.c:53
#2  0x7fffdbfc3a05 in pw_thread_loop_lock (loop=0x0) at
../src/pipewire/thread-loop.c:371
#3  0x7fffe016e97c in vlc_pw_lock (ctx=) at
modules/audio_output/vlc_pipewire.c:76
#4  0x7fffe016ea56 in vlc_pw_stream_set_volume (s=0x755f6b20
, vol=0.18007)
at modules/audio_output/pipewire.c:377
#5  0x7fffe016eba0 in VolumeSet (aout=, volume=)
at modules/audio_output/pipewire.c:658
#6  0x7fffe031f9b9 in aout_OutputVolumeSet (vol=,
aout=0x5736d6c0) at audio_output/output.c:659
#7  aout_OutputUnlock (aout=0x5736d6c0) at audio_output/output.c:704
#8  0x7fffe0325f48 in aout_VolumeSet (aout=aout@entry=0x5736d6c0,
vol=vol@entry=0.18007)
at audio_output/output.c:748
#9  0x7fffe02afb6b in libvlc_audio_set_volume (mp=,
volume=)
at /usr/src/debug/vlc-3.0.20-12.fc40.x86_64/lib/audio.c:368
#10 0x7fffe03bc749 in Phonon::VLC::MediaPlayer::setVolumeInternal
(this=)
at
/usr/src/debug/phonon-backend-vlc-0.12.0-3.fc40.x86_64/src/mediaplayer.cpp:395
#11 Phonon::VLC::MediaPlayer::setAudioVolume (volume=18, this=)
at
/usr/src/debug/phonon-backend-vlc-0.12.0-3.fc40.x86_64/src/mediaplayer.cpp:380
#12 Phonon::VLC::AudioOutput::applyVolume (this=)
at
/usr/src/debug/phonon-backend-vlc-0.12.0-3.fc40.x86_64/src/audio/audiooutput.cpp:216
#13 0x77e2ff35 in Phonon::AudioOutput::setVolume (this=,
volume=0.31698053201323556)
at /usr/src/debug/phonon-4.12.0-5.fc40.x86_64/phonon/audiooutput.cpp:170
#14 0x5558bdf8 in Dragon::VideoWindow::VideoWindow (this=, parent=0x55841b40)
at /usr/src/debug/dragon-24.02.2-1.fc40.x86_64/src/app/videoWindow.cpp:142
#15 Dragon::MainWindow::MainWindow (this=0x55841b40, this=)
at /usr/src/debug/dragon-24.02.2-1.fc40.x86_64/src/app/mainWindow.cpp:101
#16 0x555804c5 in Dragon::PlayerApplication::newInstance
(this=0x7fffdc30, playDisc=false, uris=...)
at
/usr/src/debug/dragon-24.02.2-1.fc40.x86_64/src/app/playerApplication.cpp:58
#17 0x55570c8d in main (argc=, argv=)
at /usr/src/debug/dragon-24.02.2-1.

[amarok] [Bug 486468] Amarok 2.9.71 crashes at startup on Fedora 40

2024-05-08 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=486468

--- Comment #9 from Tuomas Nurmi  ---
Thank you for the new debug outputs!
I just managed to find how to reproduce this in my VirtualBox Fedora 40:
If I run phononsettings, select "Show additional devices" (or what ever that
may be in English), and make PipeWire Sound Server the primary audio output
device, Amarok crashes on startup, corresponding to your experience.
Not sure if this is actually a bug in Phonon, but I'll see if the crash can be
avoided with changing Amarok's code now that I can reproduce this. Good.

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 486517] Cannot play audio CDs with Amarok because it always shows 0 tracks

2024-05-07 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=486517

--- Comment #7 from Tuomas Nurmi  ---
"but it _is_ possible to open the CD in Dolphin.": Yes, indeed, as Dolphin in
Fedora 40 is KF6/Qt6 based version, so it works with KF6 audiocd, while Amarok
is KF5/Qt5 and would work only with KF5 audiocd. My communication was probably
a bit messy, apologies for that.

I'm not quite sure what to make of the fact that there are FC40 packages for
KF5 audiocd listed at
https://koji.fedoraproject.org/koji/packageinfo?packageID=23585 but they have
been since deleted. It could be that they were dropped because they didn't seem
to be needed any more, or because they caused some issues / cannot be installed
if a KF6 audiocd is installed. This is probably a question where Fedora people
have better knowledge than I do. (But whatever may be the case, will be
automatically fixed when Amarok gets to Qt6/KF6)

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 486517] Cannot play audio CDs with Amarok because it always shows 0 tracks

2024-05-07 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=486517

Tuomas Nurmi  changed:

   What|Removed |Added

 Resolution|--- |DOWNSTREAM
 Status|REPORTED|RESOLVED

--- Comment #5 from Tuomas Nurmi  ---
Based on old discussion at
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=884409 , this is indeed
probably the case, and a KF5 audiocd-kio would be needed. The package doesn't
seem to be available for Fedora 40:
https://koji.fedoraproject.org/koji/packageinfo?packageID=23585

I'm not sure if it wouldn't be co-installable with KF6 kioslave or if there's
some other problem. (I tried building one manually just now, but didn't get it
to work, although didn't try very hard).

So doesn't unfortunately look like anything that should/could be fixed on
Amarok's side (except for Qt6/KF6 port, but that'll still take some time). Not
sure if it would be possible with some packaging magic to have both KF5 and KF6
audiocd-kio available, or if it would only be possible to have one (and not
have audiocd:/ available in KF6 Dolphin etc).

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 486517] Cannot play audio CDs with Amarok because it always shows 0 tracks

2024-05-07 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=486517

--- Comment #4 from Tuomas Nurmi  ---
Okay, thank you for the details. Although related, the symptoms sound slightly
different in this one, I think.
I wonder if KIO usage is KF version dependent and using audiocd would require
kf5-audiocd-kio installed, while only kf6 version is available in Fedora 40.
I'm testing by trying to build a KF5 version of audiocd-kio in my Fedora 40
virtual machine right now.

Additional note:
I've noticed Fedora limits debug output quite a bit by default. To get better
debugging output from `amarok --debug` on Fedora, one should edit
/usr/share/qt5/qtlogging.ini to read something like
[Rules]
*.debug=true
qt.qpa.xcb.xcberror.warning=false
qt.*=false
kf.*=false

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 227363] The photos widget doesn't react when i press pause and continues the slide-show

2024-05-07 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=227363

Tuomas Nurmi  changed:

   What|Removed |Added

 CC||tuo...@norsumanageri.org
 Status|REPORTED|RESOLVED
 Resolution|--- |FIXED

--- Comment #9 from Tuomas Nurmi  ---
There's no slideshow anymore in KF5 photos applet so it's probably OK time to
close this request.

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 486468] Amarok 2.9.71 crashes at startup on Fedora 40

2024-05-06 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=486468

--- Comment #6 from Tuomas Nurmi  ---
Ok, I installed Fedora 40 in VirtualBox.
Installed Amarok 2.9.71 from default installation source. Tried starting it: No
crash, I was able to play music normally. Phonon-vlc backend (Qt5) seemed to be
in use. I'm not that familiar with pipewire, but I figured I could try starting
wireplumber. That caused Amarok to get stuck during startup, although didn't
crash (and that seemed to make everything else using sound get stuck during
startup, too). Was fixed after a reboot. Tried installing Helvum. Amarok was
displayed there as connected to output channels, everything looked quite
normal.

No success in finding the root cause of the crash yet.

A useful note: To get proper debugging output from `amarok --debug` on Fedora,
one should edit /usr/share/qt5/qtlogging.ini to read something like
[Rules]
*.debug=true
qt.qpa.xcb.xcberror.warning=false
qt.*=false
kf.*=false

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 486468] Amarok 2.9.71 crashes at startup on Fedora 40

2024-05-06 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=486468

Tuomas Nurmi  changed:

   What|Removed |Added

 CC||vesto...@mail.ru

--- Comment #5 from Tuomas Nurmi  ---
*** Bug 486140 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 486140] Не запускается на Fedora 40 KDE

2024-05-06 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=486140

Tuomas Nurmi  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #3 from Tuomas Nurmi  ---
Closing this in favour of another apparently corresponding report of 2.9.71
crashing on Fedora 40, which, although was filed some days after this, contains
a backtrace and more information.

*** This bug has been marked as a duplicate of bug 486468 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 486517] Cannot play audio CDs with Amarok because it always shows 0 tracks

2024-05-06 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=486517

--- Comment #2 from Tuomas Nurmi  ---
3.0.0 packages seem to be there (soon?) for Fedora, can you try if 3.0.0 fixes
the problem for you?
https://packages.fedoraproject.org/pkgs/amarok/amarok/fedora-40-updates-testing.html

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 331511] When you select the language "Català" or "Català(Valencià)" the software selects any language except those mentioned

2024-05-06 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=331511

Tuomas Nurmi  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
 CC||tuo...@norsumanageri.org
 Resolution|--- |FIXED

--- Comment #2 from Tuomas Nurmi  ---
Tried switching to Catalan, restarted, got UI in Catalan. Seems to have been
fixed since.

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 458018] stops playing after intensive use of 10 sec seek forward and backward functions

2024-05-06 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=458018

Tuomas Nurmi  changed:

   What|Removed |Added

 CC||tuo...@norsumanageri.org
 Status|REPORTED|RESOLVED
 Resolution|--- |FIXED

--- Comment #2 from Tuomas Nurmi  ---
Tried to replicate with both vlc and gstreamer phonon backend in Amarok 3, but
couldn't, so yeah, probably has been fixed since.

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 382456] Amarok APG: crashes if checkpoint is unassigned in CheckpointConstraint

2024-05-06 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=382456

Tuomas Nurmi  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/mult
   ||imedia/amarok/-/commit/25b7
   ||63728031b9737f8dce80653086f
   ||b0a05e3fc
 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED

--- Comment #3 from Tuomas Nurmi  ---
Git commit 25b763728031b9737f8dce80653086fb0a05e3fc by Tuomas Nurmi.
Committed on 06/05/2024 at 15:14.
Pushed by nurmi into branch 'master'.

Prevent crash in APG when constraint is missing data

I'm not familliar enough with APG to properly assess if the fact noted on the
bug report, that amarok allows to generate an incomplete constraint, should be
fixed or not, but at least it shouldn't crash. So let's fix that.

M  +2-2ChangeLog
M  +2-0src/playlistgenerator/constraints/Checkpoint.cpp

https://invent.kde.org/multimedia/amarok/-/commit/25b763728031b9737f8dce80653086fb0a05e3fc

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 435810] Format setting is not loaded (in Organize files)

2024-05-06 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=435810

Tuomas Nurmi  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/mult
   ||imedia/amarok/-/commit/4583
   ||b886eb247dd0a9fe7be2686e860
   ||e6788adb3
 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED

--- Comment #8 from Tuomas Nurmi  ---
Git commit 4583b886eb247dd0a9fe7be2686e860e6788adb3 by Tuomas Nurmi.
Committed on 06/05/2024 at 15:14.
Pushed by nurmi into branch 'master'.

Fix MetaQueryWidget to pre-select correct format

M  +2-1ChangeLog
M  +5-1src/dialogs/EditFilterDialog.cpp
M  +1-1src/widgets/MetaQueryWidget.cpp

https://invent.kde.org/multimedia/amarok/-/commit/4583b886eb247dd0a9fe7be2686e860e6788adb3

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 406751] Time relations become forgotten in Dynamic Playlist rules

2024-05-06 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=406751

Tuomas Nurmi  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
  Latest Commit||https://invent.kde.org/mult
   ||imedia/amarok/-/commit/4c60
   ||c7c92eac4b22c834f326471d9cb
   ||b2f8814b3
 Resolution|--- |FIXED

--- Comment #3 from Tuomas Nurmi  ---
Git commit 4c60c7c92eac4b22c834f326471d9cbb2f8814b3 by Tuomas Nurmi.
Committed on 06/05/2024 at 15:14.
Pushed by nurmi into branch 'master'.

Add missing handling of newer dates in TagMatchBias

M  +9-0src/dynamic/biases/TagMatchBias.cpp
M  +4-0src/playlistgenerator/constraints/TagMatchComparer.cpp

https://invent.kde.org/multimedia/amarok/-/commit/4c60c7c92eac4b22c834f326471d9cbb2f8814b3

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 375565] Specifying a length TagMatch bias has no effect

2024-05-06 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=375565

Tuomas Nurmi  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/mult
   ||imedia/amarok/-/commit/04fc
   ||4ce57cc1760c975adeddb887040
   ||4edce2e09
 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #6 from Tuomas Nurmi  ---
Git commit 04fc4ce57cc1760c975adeddb8870404edce2e09 by Tuomas Nurmi.
Committed on 06/05/2024 at 15:14.
Pushed by nurmi into branch 'master'.

Fix TagMatchBias to interpret length as seconds

M  +1-0ChangeLog
M  +12   -3src/dynamic/biases/TagMatchBias.cpp

https://invent.kde.org/multimedia/amarok/-/commit/04fc4ce57cc1760c975adeddb8870404edce2e09

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 486457] build of amarok3 crashes on starte

2024-05-06 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=486457

--- Comment #3 from Tuomas Nurmi  ---
Okay, thank you for the debug output!
There are multiple hints of path issues there, but especially this line is
quite telling:
amarok: file  "/DefaultPlaylistLayouts.xml" does not exist

It should try to open something like
"/usr/share/amarok/data/DefaultPlaylistLayouts.xml", but it tries to search the
playlist layout file from system root instead - and probably other data, too.

in source code, the directory is constructed as follows:
const QString dataLocation =
QStandardPaths::locate(QStandardPaths::GenericDataLocation,
  QStringLiteral("amarok/data"),
QStandardPaths::LocateDirectory);
QString configFile = dataLocation +
QStringLiteral("/DefaultPlaylistLayouts.xml");
The QStandardPaths::locate "Returns the absolute path to the first file or
directory found, otherwise returns an empty string." and
QStandardPaths::GenericDataLocation on Linux systems maps possibly to
"~/.local/share", "/usr/local/share", "/usr/share" according to Qt docs
(although they also note "The paths above should not be relied upon")

So it seems that /usr/share/amarok/data/ nor /usr/local/share/amarok/data/
don't exist. CMake installs the relevant data files under KDE_INSTALL_DATADIR,
which by default should be empty and default to /usr/share or /usr/local/share,
I think. Did you happen to use any exotic custom path settings when doing the
initial cmake configuration for the build?

Trying a new build from completely fresh build dir might be a good thing to try
(if you didn't already)
mkdir amarok-build-new && cd amarok-build-new && cmake ../amarok
-DCMAKE_INSTALL_PREFIX=`kf5-config --prefix && make && sudo make install

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 332010] No visual indication of which wikipedia search option has been selected

2024-05-04 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=332010

Tuomas Nurmi  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/mult
   ||imedia/amarok/-/commit/8c86
   ||364873bfa0b502b831978c99909
   ||7e68997cc
 Status|REPORTED|RESOLVED
 Resolution|--- |FIXED

--- Comment #1 from Tuomas Nurmi  ---
Git commit 8c86364873bfa0b502b831978c999097e68997cc by Tuomas Nurmi.
Committed on 04/05/2024 at 21:02.
Pushed by nurmi into branch 'master'.

Indicate which search option is active in Wikipedia applet

M  +1-0ChangeLog
M  +11   -4src/context/applets/wikipedia/package/contents/ui/main.qml

https://invent.kde.org/multimedia/amarok/-/commit/8c86364873bfa0b502b831978c999097e68997cc

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 284101] Collection browser should show artist name for tracks with artist != album artist

2024-05-04 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=284101

Tuomas Nurmi  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
  Latest Commit||https://invent.kde.org/mult
   ||imedia/amarok/-/commit/5b43
   ||ce29c392311f06727f45d60b0d1
   ||96a88c85b
 Resolution|--- |FIXED

--- Comment #1 from Tuomas Nurmi  ---
Git commit 5b43ce29c392311f06727f45d60b0d196a88c85b by Tuomas Nurmi.
Committed on 04/05/2024 at 18:24.
Pushed by nurmi into branch 'master'.

Add configuration option for showing artist in various artist cases

As demonstrated by the bug reports, this is something where one solution does
not
fit all. So add a configuration option; probably - and hopefully - the users
who want
to see artist in various artists compilations also want to see them when artist
differs from album artist, and vice versa. Options should be added with care,
but
I think this one is definitely justified.
Related: bug 276039

M  +5-0src/amarokconfig.kcfg
M  +6-0src/browsers/CollectionTreeItem.cpp
M  +1-0src/browsers/CollectionTreeItem.h
M  +3-1src/browsers/CollectionTreeItemModelBase.cpp
M  +12   -0src/browsers/collectionbrowser/CollectionWidget.cpp
M  +1-0src/browsers/collectionbrowser/CollectionWidget.h

https://invent.kde.org/multimedia/amarok/-/commit/5b43ce29c392311f06727f45d60b0d196a88c85b

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 276039] Collection browser plasters artist names all over collab albums

2024-05-04 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=276039

Tuomas Nurmi  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
  Latest Commit||https://invent.kde.org/mult
   ||imedia/amarok/-/commit/5b43
   ||ce29c392311f06727f45d60b0d1
   ||96a88c85b
 Resolution|--- |FIXED

--- Comment #10 from Tuomas Nurmi  ---
Git commit 5b43ce29c392311f06727f45d60b0d196a88c85b by Tuomas Nurmi.
Committed on 04/05/2024 at 18:24.
Pushed by nurmi into branch 'master'.

Add configuration option for showing artist in various artist cases

As demonstrated by the bug reports, this is something where one solution does
not
fit all. So add a configuration option; probably - and hopefully - the users
who want
to see artist in various artists compilations also want to see them when artist
differs from album artist, and vice versa. Options should be added with care,
but
I think this one is definitely justified.
Related: bug 284101

M  +5-0src/amarokconfig.kcfg
M  +6-0src/browsers/CollectionTreeItem.cpp
M  +1-0src/browsers/CollectionTreeItem.h
M  +3-1src/browsers/CollectionTreeItemModelBase.cpp
M  +12   -0src/browsers/collectionbrowser/CollectionWidget.cpp
M  +1-0src/browsers/collectionbrowser/CollectionWidget.h

https://invent.kde.org/multimedia/amarok/-/commit/5b43ce29c392311f06727f45d60b0d196a88c85b

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 234854] “do you really want to delete this playlist” should include the playlist name

2024-05-04 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=234854

Tuomas Nurmi  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/mult
   ||imedia/amarok/-/commit/8072
   ||bc79aa6a6e448156671de46b07d
   ||65e53a7f1
 Status|ASSIGNED|RESOLVED

--- Comment #9 from Tuomas Nurmi  ---
Git commit 8072bc79aa6a6e448156671de46b07d65e53a7f1 by Tuomas Nurmi.
Committed on 04/05/2024 at 07:41.
Pushed by nurmi into branch 'master'.

Show name or count of playlists in deletion confirmation dialog

M  +1-1ChangeLog
M  +7-2src/browsers/playlistbrowser/PlaylistBrowserView.cpp

https://invent.kde.org/multimedia/amarok/-/commit/8072bc79aa6a6e448156671de46b07d65e53a7f1

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 343896] The text 'Some songs' is shown in the playlist area when it is empty

2024-05-04 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=343896

Tuomas Nurmi  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/mult
   ||imedia/amarok/-/commit/8c20
   ||55d85f4b124037d6ba890b70bd6
   ||5aad26c09
 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #5 from Tuomas Nurmi  ---
Git commit 8c2055d85f4b124037d6ba890b70bd65aad26c09 by Tuomas Nurmi.
Committed on 04/05/2024 at 06:40.
Pushed by nurmi into branch 'master'.

Unify "songs" to read "tracks" in ui.

M  +4-4src/amarokconfig.kcfg
M  +1-1src/browsers/playlistbrowser/DynamicCategory.cpp
M  +1-1src/playlist/view/listview/PrettyListView.cpp
M  +1-1src/playlistgenerator/constraints/CheckpointEditWidget.ui

https://invent.kde.org/multimedia/amarok/-/commit/8c2055d85f4b124037d6ba890b70bd65aad26c09

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 486468] Amarok 2.9.71 crashes at startup on Fedora 40

2024-05-04 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=486468

--- Comment #3 from Tuomas Nurmi  ---
(In reply to Jérôme Villafruela from comment #2)
> (In reply to Tuomas Nurmi from comment #1)
> 
> Thanks for you quick response. Dragon Player starts fine with these messages

Okay, thank you for testing. I haven't encountered this myself, and it doesn't
seem to affect every Fedora user, either. I'll probably try installing a Fedora
system myself and see if I could reproduce this somehow sometime later.

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 486517] Cannot play audio CDs with Amarok because it always shows 0 tracks

2024-05-03 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=486517

Tuomas Nurmi  changed:

   What|Removed |Added

 CC||tuo...@norsumanageri.org

--- Comment #1 from Tuomas Nurmi  ---
Thank you for your report!
Looking at the version details at
https://packages.fedoraproject.org/pkgs/amarok/amarok/ , the version 2.9.71
available in Fedora repositories seems to originate from late March. Multiple
CD related fixes were merged in just around that time, and this bug report
seems similar especially to https://bugs.kde.org/show_bug.cgi?id=455371 fixed
then.

Judging from the fact you can open the CD in Dolphin, it sounds like audiocd
kioslave is installed ok, but you could maybe verify that this is the case; the
relevant package is apparently called "audiocd-kio" in Fedora. Additionally I'd
like to know if you could try this with a bit newer version of Amarok sources,
but this is a bit of an extra threshold as there might doesn't seem to be newer
Fedora packages readily available. Alternatively, could you start amarok with
`amarok --debug`, insert a CD and copypaste the debug log output parts that
follow the insertion of the CD?

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 486468] Amarok 2.9.71 crashes at startup on Fedora 40

2024-05-02 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=486468

Tuomas Nurmi  changed:

   What|Removed |Added

 CC||tuo...@norsumanageri.org

--- Comment #1 from Tuomas Nurmi  ---
Thank you for your report! Looking at the backtrace, the fact that the crash
happens very early during initialization suggests there might be something
problematic with how phonon-vlc backend interacts with pipewire. This might be
a long shot, but could you try if similar crashes happen when starting up e.g.
Dragon player? (which also uses phonon for audio playback)

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 486457] build of amarok3 crashes on starte

2024-05-02 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=486457

Tuomas Nurmi  changed:

   What|Removed |Added

 CC||tuo...@norsumanageri.org

--- Comment #1 from Tuomas Nurmi  ---
Thank you for your report! Looking at the backtrace, the crash seems to happen
during QML ContextView applet loading (a failing assert), which might indicate
some problems with data installation paths.
Can you provide output if you run `amarok --debug`?
(Additionally, running cmake with parameter like
-DCMAKE_INSTALL_PREFIX=`kf5-config --prefix` when compiling might have an
effect here)

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 486342] Equalizer

2024-04-30 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=486342

--- Comment #3 from Tuomas Nurmi  ---
Okay, thank you for confirming!
I tested using (unmaintained/unsupported) phonon-gstreamer backend and there
the equalizer changes are somewhat instant, so seems to depend on phonon
backend in use. I'll inspect later if there's anything that could be done on
Amarok's side

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 486345] Support listenbrainz scrobbling

2024-04-30 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=486345

--- Comment #3 from Tuomas Nurmi  ---
Okay, that's great to hear!

I haven't read the relevant parts of code that much, but I have a feeling the
architecture should allow adding other scrobbling services quite easily, so it
is not far-fetched idea that somebody could implement listenbrainz scrobbling
plugin, too.

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 486345] Support listenbrainz scrobbling

2024-04-30 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=486345

Tuomas Nurmi  changed:

   What|Removed |Added

 CC||tuo...@norsumanageri.org

--- Comment #1 from Tuomas Nurmi  ---
Thank you for the comment! I had a quick look, Listenbrainz sound interesting,
I'll definitely inspect it more later. However, on "mpris player"; Amarok
should be reachable through mpris interfaces (I've been using KDE Connect for
years to control it). Can you provide any more information on what's not there
yet for mpris?

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 486342] Equalizer

2024-04-30 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=486342

Tuomas Nurmi  changed:

   What|Removed |Added

 CC||tuo...@norsumanageri.org

--- Comment #1 from Tuomas Nurmi  ---
Thank you for your report. I assume you are using phonon-vlc backend. I tried
changing equalizer settings, and for them to have effect, I had to stop the
playback and start the track again (they didn't have effect right away). Can
you confirm if this is the case for you?

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 340973] Make it easy to move database

2024-04-30 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=340973

Tuomas Nurmi  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
 CC||tuo...@norsumanageri.org
 Resolution|--- |FIXED

--- Comment #5 from Tuomas Nurmi  ---
Closing as based on the last comment, this might have actually worked back 10
years ago. If everything's in right place on first start / first collection
update / rescan, the copy process probably works. (This is somewhat sensitive,
as the tracks not being in collection for during a scan can easily lead them to
be deemed removed, but writing stats to files is a possibility. Additionally,
some related bugs that might have caused loss of statistics if the paths were
not exactly the same have been fixed since.)

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 325094] Dynamic playlist fails to add appropriate tracks automatically

2024-04-30 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=325094

Tuomas Nurmi  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 CC||tuo...@norsumanageri.org
 Status|CONFIRMED   |RESOLVED

--- Comment #13 from Tuomas Nurmi  ---
As far as I can tell, seems to have been fixed with the changes merged in 2020,
so closing. Please do reopen if you encounter this with 3.0.0 or later.

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 419159] QT5 release is required to bring Amarok back into Debian and Ubuntu repositories

2024-04-29 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=419159

Tuomas Nurmi  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
 CC||tuo...@norsumanageri.org
 Resolution|--- |FIXED

--- Comment #5 from Tuomas Nurmi  ---
https://blogs.kde.org/2024/04/29/amarok-3.0-castaway-released/

+ hopefully Qt6 release later this year

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 486140] Не запускается на Fedora 40 KDE

2024-04-25 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=486140

Tuomas Nurmi  changed:

   What|Removed |Added

 CC||tuo...@norsumanageri.org

--- Comment #1 from Tuomas Nurmi  ---
Thank you for report. Unfortunately I don't read fluent Russian, but looking at
errors, seems like a packaging/installation related problem. Make sure you have
mariadb-embedded installed. You can also try resetting amarok settings &
embedded database by deleting ~/.config/amarokrc and ~/.local/share/amarok/. If
that does not help, running `amarok --debug` or getting a backtrace with KDE
crash reporter (or manually through gdb) might provide more information.

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 486084] Collection scan failure for tracks with "inf dB" in REPLAYGAIN_TRACK_GAIN tag field

2024-04-25 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=486084

Tuomas Nurmi  changed:

   What|Removed |Added

 CC||tuo...@norsumanageri.org

--- Comment #1 from Tuomas Nurmi  ---
Thank you for report and sample file! I'll try reproducing and fixing this
soonish, not sure if before or after 3.0.0 though

-- 
You are receiving this mail because:
You are watching all bug changes.

[kalarm] [Bug 486033] Systray icon does not follow color scheme in Plasma6

2024-04-24 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=486033

Tuomas Nurmi  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #2 from Tuomas Nurmi  ---
A fix was merged (
https://invent.kde.org/pim/kalarm/-/commit/6f040fd113873b1bc69fc73cb84897f10bf6da19
) but no BUG tag in commit message, so closing manually.

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 382456] Amarok APG: crashes if checkpoint is unassigned in CheckpointConstraint

2024-04-23 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=382456

Tuomas Nurmi  changed:

   What|Removed |Added

 CC||tuo...@norsumanageri.org

--- Comment #1 from Tuomas Nurmi  ---
Reproducible with 2.9.82. Let's see if I'll come up with a fix sometime

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 468768] Random Track Progression Does Not Work

2024-04-23 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=468768

Tuomas Nurmi  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|REPORTED|RESOLVED

--- Comment #3 from Tuomas Nurmi  ---
I'm somewhat confident this was fixed by
https://invent.kde.org/multimedia/amarok/-/merge_requests/31 so I'm closing
this, but please do not hesitate to reopen if you still encounter this with
2.9.82 or later.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kget] [Bug 486032] Systray icon does not follow color scheme in Plasma6

2024-04-23 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=486032

Tuomas Nurmi  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED

--- Comment #2 from Tuomas Nurmi  ---
My bad, left out the BUG tag from commit message. Fix was just merged, closing
manually.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kalarm] [Bug 486033] New: Systray icon does not follow color scheme in Plasma6

2024-04-23 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=486033

Bug ID: 486033
   Summary: Systray icon does not follow color scheme in Plasma6
Classification: Applications
   Product: kalarm
   Version: unspecified
  Platform: Other
OS: Linux
Status: REPORTED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: djar...@kde.org
  Reporter: tuo...@norsumanageri.org
  Target Milestone: ---

SUMMARY
Since Plasma 6 (?), systray does not default to symbolic icon even if
available. Therefore KAlarm icon is colourful instead.

STEPS TO REPRODUCE
1. Enable KAlarm -> Settings -> View -> Show in system tray
2. Observe KAlarm icon in systray

OBSERVED RESULT
Colourful icon (
https://invent.kde.org/frameworks/breeze-icons/-/blob/master/icons/apps/48/kalarm.svg
) is shown in systray among all the other single colour icons

EXPECTED RESULT
Symbolic Kalarm icon is used in systray
https://invent.kde.org/frameworks/breeze-icons/-/blob/master/icons/apps/22/kalarm-symbolic.svg

SOFTWARE/OS VERSIONS
KDE Plasma Version: 6.0.4

-- 
You are receiving this mail because:
You are watching all bug changes.

[kget] [Bug 486032] New: Systray icon does not follow color scheme in Plasma6

2024-04-23 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=486032

Bug ID: 486032
   Summary: Systray icon does not follow color scheme in Plasma6
Classification: Applications
   Product: kget
   Version: unspecified
  Platform: Other
OS: Linux
Status: REPORTED
  Severity: normal
  Priority: NOR
 Component: UI
  Assignee: k...@kde.org
  Reporter: tuo...@norsumanageri.org
CC: wbau...@a1.net
  Target Milestone: ---

***
If you're not sure this is actually a bug, instead post about it at
https://discuss.kde.org

If you're reporting a crash, attach a backtrace with debug symbols; see
https://community.kde.org/Guidelines_and_HOWTOs/Debugging/How_to_create_useful_crash_reports
***

SUMMARY
Since Plasma 6 (?), systray does not default to symbolic icon even if
available. Therefore KGet icon is colourful instead.

STEPS TO REPRODUCE
1. Enable KGet -> Settings -> Advanced -> Enable system tray icon
2. Observe KGet in systray

OBSERVED RESULT
Colourful icon (
https://invent.kde.org/frameworks/breeze-icons/-/blob/master/icons/apps/48/kget.svg
) is shown in systray among all the other single colour icons

EXPECTED RESULT
Symbolic KGet icon is used in systray
https://invent.kde.org/frameworks/breeze-icons/-/blob/master/icons/apps/22/kget-symbolic.svg

SOFTWARE/OS VERSIONS
KDE Plasma Version: 6.0.4

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 431738] Amarok sometimes crashes when searching in Collection Browser

2024-04-22 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=431738

Tuomas Nurmi  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
  Latest Commit||https://invent.kde.org/mult
   ||imedia/amarok/-/commit/e3a1
   ||4e6ed3aeb0800df2a781b5c999d
   ||71e4d524c
 Resolution|--- |FIXED

--- Comment #6 from Tuomas Nurmi  ---
Git commit e3a14e6ed3aeb0800df2a781b5c999d71e4d524c by Tuomas Nurmi.
Committed on 22/04/2024 at 14:41.
Pushed by nurmi into branch 'master'.

Avoid crash when a running SqlQueryMaker is deleted

Deletion only after a job has finished seems to prevent crashes in cases where
an already deleted job finishes and runs defaultEnd, and additionally cases
where SqlQueryMakerInternal is deleted during an sql query and it tries to emit
now deleted signals based on query results.

Also try to avoid running any further extra steps in SqlQueryMakerInternal::run
if
abort has been called.

Fixes a flaky test, hopefully fixes also fixes a related bug

M  +14   -1src/core-impl/collections/db/sql/SqlQueryMaker.cpp
M  +13   -2src/core-impl/collections/db/sql/SqlQueryMakerInternal.cpp
M  +2-0src/core-impl/collections/db/sql/SqlQueryMakerInternal.h

https://invent.kde.org/multimedia/amarok/-/commit/e3a14e6ed3aeb0800df2a781b5c999d71e4d524c

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 356996] Tracks become 'never played' after modifying the root Music directory

2024-04-21 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=356996

Tuomas Nurmi  changed:

   What|Removed |Added

 CC||tuo...@norsumanageri.org

--- Comment #6 from Tuomas Nurmi  ---
Ah, interesting. Reading the description and steps to reproduce, I got a
feeling this might be related to a bug that was fixed yesterday in git master (
https://bugs.kde.org/show_bug.cgi?id=475528 ).
I tried the steps and could reproduce this, but (in addition to the bug fixed
yesterday?), this case involves another aspect: Seems that when some
subdirectories of a directory are excluded from the collection, all files in
the root of the directory are excluded, too (and only the specifically included
subdirectories are included). I'm not completely sure if it should include the
top level or not; maybe it should, but that's technically a bit complicated to
implement.
(Here seems to be also an additional small UI bug: when files in a top level of
directory are not included, they are shown as checkable single files in
collection directory setup. However, selecting them has no effect as collection
scanner skips them as they are not directories)

-- 
You are receiving this mail because:
You are watching all bug changes.

[yakuake] [Bug 477228] System Tray icon not using `yakuake-symbolic` name, causing it to be inappropriately colorful

2024-04-21 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=477228

--- Comment #4 from Tuomas Nurmi  ---
Git commit e9bc393ef17fd0a5332fd359f1b746ca9adda003 by Tuomas Nurmi.
Committed on 21/04/2024 at 10:12.
Pushed by nurmi into branch 'master'.

Change systray icon to use symbolic version

Not having "-symbolic" in name prevents showing of symbolic icon on KF6 Plasma
systray.
Looking at various bugreports and code changes done in Yakuake and other
applications,
this is apparently ok way to fix this, as it should fall back to icon without
symbolic
suffix if none is found.
Related: bug 485748

M  +2-0ChangeLog
M  +1-1src/TrayIcon.cpp

https://invent.kde.org/multimedia/amarok/-/commit/e9bc393ef17fd0a5332fd359f1b746ca9adda003

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 485748] amarok icon, in systray does not follow dark breeze theme

2024-04-21 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=485748

Tuomas Nurmi  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
  Latest Commit||https://invent.kde.org/mult
   ||imedia/amarok/-/commit/e9bc
   ||393ef17fd0a5332fd359f1b746c
   ||a9adda003
 Resolution|--- |FIXED

--- Comment #3 from Tuomas Nurmi  ---
Git commit e9bc393ef17fd0a5332fd359f1b746ca9adda003 by Tuomas Nurmi.
Committed on 21/04/2024 at 10:12.
Pushed by nurmi into branch 'master'.

Change systray icon to use symbolic version

Not having "-symbolic" in name prevents showing of symbolic icon on KF6 Plasma
systray.
Looking at various bugreports and code changes done in Yakuake and other
applications,
this is apparently ok way to fix this, as it should fall back to icon without
symbolic
suffix if none is found.
Related: bug 477228

M  +2-0ChangeLog
M  +1-1src/TrayIcon.cpp

https://invent.kde.org/multimedia/amarok/-/commit/e9bc393ef17fd0a5332fd359f1b746ca9adda003

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 485813] Could the wikipedia applet not be cleared if playback is stopped?

2024-04-21 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=485813

Tuomas Nurmi  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/mult
   ||imedia/amarok/-/commit/fefd
   ||0c61616cf39bba7069f8cdf561b
   ||a787e6933

--- Comment #3 from Tuomas Nurmi  ---
Git commit fefd0c61616cf39bba7069f8cdf561ba787e6933 by Tuomas Nurmi.
Committed on 21/04/2024 at 07:08.
Pushed by nurmi into branch 'master'.

Add a button to stop Wikipedia from updating automatically

Makes sense, so one does not have to pause track to keep reading the same page.
Using pause icon and string, at least the string can be made more descriptive
later.

M  +1-0ChangeLog
M  +12   -0src/context/applets/wikipedia/package/contents/ui/main.qml
M  +20   -0src/context/applets/wikipedia/plugin/WikipediaEngine.cpp
M  +4-0src/context/applets/wikipedia/plugin/WikipediaEngine.h

https://invent.kde.org/multimedia/amarok/-/commit/fefd0c61616cf39bba7069f8cdf561ba787e6933

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 475528] Songs get deleted from local collection when new ones are added

2024-04-20 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=475528

--- Comment #6 from Tuomas Nurmi  ---
(In reply to Tuomas Nurmi from comment #4)
> Git commit 154e31b5b3002f0bb290ef55ec0eb6c612113e91 by Tuomas Nurmi.
> Committed on 20/04/2024 at 11:04.
> Pushed by nurmi into branch 'master'.
> 
> Fix erronous database query
> 
> After three days of debugging, refreshing related autotests, writing more
> tests,
> hunting for differences between autotest mock components and real ones and
> digging
> deep into database queries related to saving paths, I am happy to announce
> that I
> have a fix which changes a single _ to /.
> 
> I guess the original idea might have been to handle both unix and windows
> path
> separators. However, based on my digging, I think Qt does that anyhow in
> every case
> before anything is written to db. Also, the directories saved into db always
> come
> from MountPointManager's getRelativePath, which has never a trailing /, so
> the
> slash instead of underscore should always be a correct character here to
> match
> subdirectories.
> 
> M  +1-1src/core-impl/collections/db/sql/SqlScanResultProcessor.cpp
> 
> https://invent.kde.org/multimedia/amarok/-/commit/
> 154e31b5b3002f0bb290ef55ec0eb6c612113e91

Your welcome!
I think I've hit this bug myself once or twice, too, but it was too random to
get a good grasp on where to inspect. Your observation on the substrings in
folder names was very valuable in finding the cause of this, so thank you for
that!

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 305554] Lyrics applet doesn't display correctly

2024-04-20 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=305554

Tuomas Nurmi  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED
 CC||tuo...@norsumanageri.org

--- Comment #13 from Tuomas Nurmi  ---
Fixed nowadays in KF5 versions, e.g. 2.9.82. Closing.

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 414407] Can't load database (plugin)

2024-04-20 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=414407

Tuomas Nurmi  changed:

   What|Removed |Added

 CC||tuo...@norsumanageri.org
 Resolution|--- |FIXED
 Status|REPORTED|RESOLVED

--- Comment #37 from Tuomas Nurmi  ---
Closing this as db dependency related questions are somewhat under control at
the moment and packages for 2.9.82 and nightly git builds are somewhat widely
available.

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 431738] Amarok sometimes crashes when searching in Collection Browser

2024-04-20 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=431738

--- Comment #4 from Tuomas Nurmi  ---
Okay, actually, when enabling the sql autotests on invent.kde.org pipelines, I
found out that testsqlquerymaker very often crashes during
TestSqlQueryMaker::testDeleteQueryMakerWithRunningQuery(). This might be
related, I'll see if I can find out what's the problem there.

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 485847] Add mouseover popup on playlist

2024-04-20 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=485847

Tuomas Nurmi  changed:

   What|Removed |Added

 CC||tuo...@norsumanageri.org

--- Comment #1 from Tuomas Nurmi  ---
Playlist tooltip can actually be enabled from Edit playlist layouts -> Show
tooltips. However, the tooltips that way are pretty extensive, the setting is
not that easy to find and there's also an earlier request for showing the
ellipsed name from long time ago https://bugs.kde.org/show_bug.cgi?id=214422 so
this is probably something that could be improved somehow.

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 475528] Songs get deleted from local collection when new ones are added

2024-04-20 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=475528

Tuomas Nurmi  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED
  Latest Commit||https://invent.kde.org/mult
   ||imedia/amarok/-/commit/154e
   ||31b5b3002f0bb290ef55ec0eb6c
   ||612113e91

--- Comment #4 from Tuomas Nurmi  ---
Git commit 154e31b5b3002f0bb290ef55ec0eb6c612113e91 by Tuomas Nurmi.
Committed on 20/04/2024 at 11:04.
Pushed by nurmi into branch 'master'.

Fix erronous database query

After three days of debugging, refreshing related autotests, writing more
tests,
hunting for differences between autotest mock components and real ones and
digging
deep into database queries related to saving paths, I am happy to announce that
I
have a fix which changes a single _ to /.

I guess the original idea might have been to handle both unix and windows path
separators. However, based on my digging, I think Qt does that anyhow in every
case
before anything is written to db. Also, the directories saved into db always
come
from MountPointManager's getRelativePath, which has never a trailing /, so the
slash instead of underscore should always be a correct character here to match
subdirectories.

M  +1-1src/core-impl/collections/db/sql/SqlScanResultProcessor.cpp

https://invent.kde.org/multimedia/amarok/-/commit/154e31b5b3002f0bb290ef55ec0eb6c612113e91

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 485748] amarok icon, in systray does not follow dark breeze theme

2024-04-20 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=485748

--- Comment #2 from Tuomas Nurmi  ---
OK, inspected a bit more:
The icon that does not follow theme is
https://github.com/KDE/breeze-icons/blob/master/icons/apps/48/amarok.svg
The icon for other sizes is
https://github.com/KDE/breeze-icons/blob/master/icons/apps/32/amarok-symbolic.svg
which does follow the theme.
Changing KStatusNotifierItem::setIconByName( "amarok" );
to KStatusNotifierItem::setIconByName( "amarok-symbolic" );
fixes this, but I don't think is the right way to go, as according to
https://develop.kde.org/docs/plasma/theme/theme-tray-icons/
the systray icon Amarok should be using is "amarok".

I had a quick look at recent changes in some relevant KF components,
at least commit
https://github.com/KDE/kiconthemes/commit/2d22b9d8798f1ba2642aa3b982a65c9865fbf52d
might be related to changed behaviour (didn't assess yet whether actually is
the case),
another potential place for changes causing this might be
https://github.com/KDE/plasma-workspace/commits/master/applets/systemtray/statusnotifieritemsource.cpp

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 485813] Could the wikipedia applet not be cleared if playback is stopped?

2024-04-19 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=485813

Tuomas Nurmi  changed:

   What|Removed |Added

 CC||tuo...@norsumanageri.org

--- Comment #1 from Tuomas Nurmi  ---
Hmm, true, that's a valid point. I tried adding a button ("pause") that stops
any automatic Wikipedia page updates. Needs a bit more polishing but I think it
makes sense, I'll probably add this in a couple of days.

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 485732] Amarok synchronization with last.fm files fails to work

2024-04-19 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=485732

Tuomas Nurmi  changed:

   What|Removed |Added

 CC||tuo...@norsumanageri.org
 Status|REPORTED|CONFIRMED
 Ever confirmed|0   |1

--- Comment #2 from Tuomas Nurmi  ---
Ah, very interesting to see the problematic method name, thank you!
A quick searching indicates that although
https://www.last.fm/api/show/library.getArtists is still there,
library.getTracks has apparently been removed from Last.fm API some time ago:
https://emby.media/community/index.php?/topic/30066-lastfm-addon-gone/=findComment=356659
so to fix Last.fm synchronization, the system needs to be edited to use the API
calls still available.

I've planned to do some refreshment of Last.fm integration, possibly already in
3.0.x versions. I'll have a go at this then, too.

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 485748] amarok icon, in systray does not follow dark breeze theme

2024-04-19 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=485748

Tuomas Nurmi  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|REPORTED|CONFIRMED
 CC||tuo...@norsumanageri.org

--- Comment #1 from Tuomas Nurmi  ---
Yes, experiencing this on my Plasma6 Tumbleweed system, too, but not on
Tumbleweed still in Plasma5, so I suppose this is somehow related to Plasma/KF
version.
Icon is set in TrayIcon.cpp:83 with
KStatusNotifierItem::setIconByName( "amarok" );
so nothing strange there and this is likely somehow related to icon themes /
installation of icons in build process. Will inspect later unless someone else
comes up with a solution before that.

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 475528] Songs get deleted from local collection when new ones are added

2024-04-18 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=475528

--- Comment #2 from Tuomas Nurmi  ---
Managed to narrow down reproduction a bit:
Start with an empty embedded database, have tracks
Foghat/Foghat - 01 - Honey Hush.ogg
Fogh/16 - Punk Reggae Party.ogg
in library path. Scan the library and observe both of them appear in collection
browser.

Add both tracks to playlist. The other one does not have to be played.
Start playing Foghat/Energized/Foghat - 01 - Honey Hush.ogg, skip to nearly end
of the track but make sure it plays some seconds., check that playcount after
playing is 1

touch Fogh/

Foghat - Honey Hush disappears from collection. If not with first try, playing
the track some seconds and doing touch Fogh/ again will probably do trick.

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 444480] amarokcollectionscanner hangs in /dev

2024-04-18 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=80

Tuomas Nurmi  changed:

   What|Removed |Added

 CC||tuo...@norsumanageri.org

--- Comment #1 from Tuomas Nurmi  ---
Tested around a bit. The collection scanner knows how to avoid normal /dev,
/sys and /proc, and also seems to be ok with symlinked versions of those.
Apparently the relation is hidden somewhat deeper in lxc filesystems. It is
helpful if you can provide more information on what the path of dev looks like
when it's under lxc filesystem (and how it is connected there, link, mount or
something else). I might inspect myself later, but as I don't have lxc
filesystems available right away, that'll be post-3.0.

-- 
You are receiving this mail because:
You are watching all bug changes.

  1   2   3   >