[krita] [Bug 465128] Regular Crash (SIGABRT) [EXC_CORPSE_NOTIFY] on OSX

2023-02-01 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=465128

amyspark  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/grap
   ||hics/krita/commit/dcd653573
   ||6ba797f889b8b80f43f9f25d38a
   ||bab6
 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #4 from amyspark  ---
Git commit dcd6535736ba797f889b8b80f43f9f25d38abab6 by L. E. Segovia.
Committed on 01/02/2023 at 20:47.
Pushed by lsegovia into branch 'krita/5.1'.

KisImageFromClipboardWidget: stave off a clipboard being cleared mid-access
Related: bug 462006

(cherry picked from commit 6399b0203e7c7e8fa6fc40e4fdbe4a72cae2f304)

M  +10   -6libs/ui/widgets/kis_image_from_clipboard_widget.cpp

https://invent.kde.org/graphics/krita/commit/dcd6535736ba797f889b8b80f43f9f25d38abab6

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 462006] Crash when creating new image from selected region (clipboard)

2023-02-01 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=462006

amyspark  changed:

   What|Removed |Added

 Blocks||465128


Referenced Bugs:

https://bugs.kde.org/show_bug.cgi?id=465128
[Bug 465128] Regular Crash (SIGABRT) [EXC_CORPSE_NOTIFY] on OSX
-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 465128] Regular Crash (SIGABRT) [EXC_CORPSE_NOTIFY] on OSX

2023-02-01 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=465128

amyspark  changed:

   What|Removed |Added

 Status|NEEDSINFO   |ASSIGNED
 Depends on||462006
 Resolution|WAITINGFORINFO  |---
 Ever confirmed|0   |1

--- Comment #3 from amyspark  ---
Yup, there it is. It's actually a sibling of bug 462006, which I already fixed
for 5.2. I'll cherry pick the patch to the 5.1branch and you should be able to
see this crash disappear with tomorrow's nightly builds.


Referenced Bugs:

https://bugs.kde.org/show_bug.cgi?id=462006
[Bug 462006] Crash when creating new image from selected region (clipboard)
-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 464255] X11 connection broken on startup.

2023-02-01 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=464255

amyspark  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED
  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/krita/commit/fa671d407 |hics/krita/commit/2aef88412
   |fd6d89c87c15c67d486e5dd1c7b |76ceffaa18221ac29e427c4d31e
   |0301|fb6b

--- Comment #9 from amyspark  ---
Git commit 2aef8841276ceffaa18221ac29e427c4d31efb6b by L. E. Segovia.
Committed on 01/02/2023 at 17:31.
Pushed by merge-service into branch 'master'.

OpenGL: increase minimum to ES3 / 3.3 Compatibility / 4.1 Core

This is the second attempt of commit
ca645e71a09e1ee81dc0f7ef153b00304af058de. For this one, I've ported Qt's
dynamic OpenGL module detection (which we cannot run at this time due to
QGuiApplication having not yet been instanced), and split the minimum
version per-operating system flavor.

For all OpenGL ES users, the new version will be fixed to 3.0 +
QSurfaceFormat::NoProfile (already the default-- CompatibilityProfile
and DeprecatedFunctions are no-ops).

For desktop GL users not on macOS, the new version will be fixed to 3.3
Compatibility. While testing, I found that it was easy to induce a
"crash" (in fact, forced process exit by X11) by asking NVIDIA's GLX
implementation to instantiate a 4.x surface if it was set to GLES
(whether by setRenderableType or by using NoProfile). For that reason
I've kept the Compatibility profile but without DeprecatedFunctions--
that way the display driver returns the maximum supported version.

For all desktop OpenGL users on a Mac, we use the Apple default and sole
supported version, 4.1 Core.

This reverts commit fa671d407fd6d89c87c15c67d486e5dd1c7b0301.
CCMAIL:kimages...@kde.org

Part-of: <https://invent.kde.org/graphics/krita/-/merge_requests/1726>

M  +5-0krita/main.cc
M  +7-9libs/ui/opengl/KisOpenGLModeProber.h
M  +71   -8libs/ui/opengl/kis_opengl.cpp
M  +13   -14   libs/ui/opengl/kis_opengl_shader_loader.cpp

https://invent.kde.org/graphics/krita/commit/2aef8841276ceffaa18221ac29e427c4d31efb6b

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 465128] Regular Crash (SIGABRT) [EXC_CORPSE_NOTIFY] on OSX

2023-02-01 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=465128

amyspark  changed:

   What|Removed |Added

  Component|* Unknown   |General
   Severity|normal  |crash

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 465128] Regular Crash (SIGABRT) [EXC_CORPSE_NOTIFY] on OSX

2023-02-01 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=465128

amyspark  changed:

   What|Removed |Added

 CC||a...@amyspark.me
 Resolution|--- |WAITINGFORINFO
 Status|REPORTED|NEEDSINFO

--- Comment #1 from amyspark  ---
Hi! The crash's triggered by a runtime assertion somewhere in the UI, but the
location's not symbolicated; can you attach the Krita run log? That should be
in Help menu, option "Show Krita log for bug reports..."

Alternatively, you could try running Krita from a Terminal (
/Applications/krita.app/Contents/MacOS/krita ) and send us the console's output
when it crashes.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 455570] Krita plus 5.1.0 prealpha : complex brush outline causes performance lag

2023-01-31 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=455570

amyspark  changed:

   What|Removed |Added

 CC||a...@amyspark.me
 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---
  Component|* Unknown   |Brush engines

--- Comment #42 from amyspark  ---
Reopening as the fix for this is causing 465086.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 465086] Clone brush cursor is improperly rendered

2023-01-31 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=465086

amyspark  changed:

   What|Removed |Added

 Blocks||455570
 CC||a...@amyspark.me
 Ever confirmed|0   |1
   Assignee|krita-bugs-n...@kde.org |dimul...@gmail.com
 Status|REPORTED|ASSIGNED

--- Comment #1 from amyspark  ---
Both commits are a fix intended for 455570. Assigning to Dmitry, but please
expect some delay as to the resolution.


Referenced Bugs:

https://bugs.kde.org/show_bug.cgi?id=455570
[Bug 455570] Krita plus 5.1.0 prealpha : complex brush outline causes
performance lag
-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 455570] Krita plus 5.1.0 prealpha : complex brush outline causes performance lag

2023-01-31 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=455570

amyspark  changed:

   What|Removed |Added

 Depends on||465086


Referenced Bugs:

https://bugs.kde.org/show_bug.cgi?id=465086
[Bug 465086] Clone brush cursor is improperly rendered
-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 464015] Psd files don't load layers correctly

2023-01-29 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=464015

amyspark  changed:

   What|Removed |Added

 CC||wontoon...@gmail.com

--- Comment #30 from amyspark  ---
*** Bug 465013 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 465013] PSDs do not load properly and show a blank canvas with several lines.

2023-01-29 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=465013

amyspark  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 CC||a...@amyspark.me
 Status|REPORTED|RESOLVED

--- Comment #1 from amyspark  ---
Hi!

It wasn't exactly Android, it affected all devices that have an Arm processor,
including the Apple Macbooks.

This is a duplicate of bug 464015 which I've fixed in the 5.1 nightlies and in
the upcoming 5.2 release. We've not been able to push a release to the Play
Store yet, because of the dependency upgrades we've been doing for 5.2.

*** This bug has been marked as a duplicate of bug 464015 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 458935] GMIC crash on macos arm, stacktrace gmic::_run

2023-01-28 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=458935

amyspark  changed:

   What|Removed |Added

 Resolution|--- |WAITINGFORINFO
 CC||david.tschumpe...@gmail.com
 Status|REPORTED|NEEDSINFO

--- Comment #6 from amyspark  ---
Iván, is this still reproducible? I'll be preparing the 3.2 tarball next week,
perhaps you can try reproducing it then.

Also cc David so that he knows.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 464848] Krita instantly crashing

2023-01-28 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=464848

amyspark  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/krita/commit/a5ad124f5 |hics/krita/commit/2f6370472
   |d878f9bd249217432ffcaf6b93d |556926668a5469a22d890ada776
   |12fb|ea7d

--- Comment #18 from amyspark  ---
Git commit 2f6370472556926668a5469a22d890ada776ea7d by L. E. Segovia.
Committed on 28/01/2023 at 20:48.
Pushed by lsegovia into branch 'krita/5.1'.

KisImportExportManager: ensure a color space with no profile is rejected on
load

It was possible (unsure how, yet) to construct a color space that had no
profile in it. This would usually make it past the impex plugins (unless
there was a transform), but it would make the usage logger crash because
it records the profile name.
(cherry picked from commit a5ad124f5d878f9bd249217432ffcaf6b93d12fb)

M  +7-0libs/ui/KisImportExportManager.cpp
M  +5-4plugins/impex/tiff/kis_tiff_import.cc

https://invent.kde.org/graphics/krita/commit/2f6370472556926668a5469a22d890ada776ea7d

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 464848] Krita instantly crashing

2023-01-28 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=464848

--- Comment #17 from amyspark  ---
Git commit 52eaeee8afe99005374425ed2caadce6d7b1dc1c by L. E. Segovia.
Committed on 28/01/2023 at 20:48.
Pushed by lsegovia into branch 'krita/5.1'.

YCbCr: ensure we have a default color profile in place

Found while checking the below bug out.
(cherry picked from commit 9684e5f102af371dc7e1a216189225cfaf4aa2f4)

M  +1-1   
plugins/color/lcms2engine/colorspaces/ycbcr_f32/YCbCrF32ColorSpace.h
M  +1-1   
plugins/color/lcms2engine/colorspaces/ycbcr_u16/YCbCrU16ColorSpace.h
M  +1-1   
plugins/color/lcms2engine/colorspaces/ycbcr_u8/YCbCrU8ColorSpace.h

https://invent.kde.org/graphics/krita/commit/52eaeee8afe99005374425ed2caadce6d7b1dc1c

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 464848] Krita instantly crashing

2023-01-28 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=464848

amyspark  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/grap
   ||hics/krita/commit/a5ad124f5
   ||d878f9bd249217432ffcaf6b93d
   ||12fb
 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #16 from amyspark  ---
Git commit a5ad124f5d878f9bd249217432ffcaf6b93d12fb by L. E. Segovia.
Committed on 28/01/2023 at 20:47.
Pushed by lsegovia into branch 'master'.

KisImportExportManager: ensure a color space with no profile is rejected on
load

It was possible (unsure how, yet) to construct a color space that had no
profile in it. This would usually make it past the impex plugins (unless
there was a transform), but it would make the usage logger crash because
it records the profile name.

M  +7-0libs/ui/KisImportExportManager.cpp
M  +5-4plugins/impex/tiff/kis_tiff_import.cc

https://invent.kde.org/graphics/krita/commit/a5ad124f5d878f9bd249217432ffcaf6b93d12fb

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 464848] Krita instantly crashing

2023-01-28 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=464848

--- Comment #15 from amyspark  ---
Git commit 9684e5f102af371dc7e1a216189225cfaf4aa2f4 by L. E. Segovia.
Committed on 28/01/2023 at 20:44.
Pushed by lsegovia into branch 'master'.

YCbCr: ensure we have a default color profile in place

Found while checking the below bug out.

M  +1-1   
plugins/color/lcms2engine/colorspaces/ycbcr_f32/YCbCrF32ColorSpace.h
M  +1-1   
plugins/color/lcms2engine/colorspaces/ycbcr_u16/YCbCrU16ColorSpace.h
M  +1-1   
plugins/color/lcms2engine/colorspaces/ycbcr_u8/YCbCrU8ColorSpace.h

https://invent.kde.org/graphics/krita/commit/9684e5f102af371dc7e1a216189225cfaf4aa2f4

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 464848] Krita instantly crashing

2023-01-28 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=464848

amyspark  changed:

   What|Removed |Added

 Resolution|WAITINGFORINFO  |---
 Status|NEEDSINFO   |ASSIGNED

--- Comment #14 from amyspark  ---
Bingo, I think I've found the reason why it crashes. Incoming fix.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 464848] Krita instantly crashing

2023-01-28 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=464848

--- Comment #12 from amyspark  ---
Glad to hear that! Still, can you get a copy of those broken color profiles? So
that we can help other Cintiq users not crash on the same spot in the future.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 464700] krita quits opening a specific psd file created with photopea.

2023-01-27 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=464700

--- Comment #13 from amyspark  ---
The file should load now. For the missing pattern, it would be great if you
could report it to the authors of Photopea; we cannot supply the patterns that
come by default with Photoshop.

Let us know if you find any more issues, and thanks for reporting this crash!

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 464700] krita quits opening a specific psd file created with photopea.

2023-01-27 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=464700

amyspark  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/krita/commit/973acffa8 |hics/krita/commit/8e83efca1
   |a24c640e3a3c95007f99dfe4b4f |25a263dc993cf92e89c290f9339
   |5f48|efe3

--- Comment #12 from amyspark  ---
Git commit 8e83efca125a263dc993cf92e89c290f9339efe3 by L. E. Segovia.
Committed on 28/01/2023 at 01:31.
Pushed by lsegovia into branch 'krita/5.1'.

KisAslLayerStyleSerializer: fix layer-local patterns

This is the counterpart of bug 441605, we only found this one out
because in 464700 Wolthera injects a placeholder pattern, which in turn
was never put into global storage.

For the sake of completionism, I've added several safe asserts in the
path that the nullptr makes, so that we get breakpointable warnings for
missing resources in the future.
Related: bug 441605
CCMAIL:dimul...@gmail.com
CCMAIL:tamtamy.tym...@gmail.com
(cherry picked from commit 973acffa8a24c640e3a3c95007f99dfe4b4f5f48)

M  +15   -5libs/image/kis_asl_layer_style_serializer.cpp
M  +2-0libs/image/layerstyles/kis_ls_utils.cpp
M  +5-0libs/resources/KisLocalStrokeResources.cpp
M  +6-0libs/resources/KisRequiredResourcesOperators.cpp
M  +1-0libs/resources/KoResourceLoadResult.cpp
M  +8-0plugins/impex/psd/psd_loader.cpp

https://invent.kde.org/graphics/krita/commit/8e83efca125a263dc993cf92e89c290f9339efe3

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 441605] Safe assert on reading a file with a layer style

2023-01-27 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=441605

--- Comment #9 from amyspark  ---
Git commit 8e83efca125a263dc993cf92e89c290f9339efe3 by L. E. Segovia.
Committed on 28/01/2023 at 01:31.
Pushed by lsegovia into branch 'krita/5.1'.

KisAslLayerStyleSerializer: fix layer-local patterns

This is the counterpart of bug 441605, we only found this one out
because in 464700 Wolthera injects a placeholder pattern, which in turn
was never put into global storage.

For the sake of completionism, I've added several safe asserts in the
path that the nullptr makes, so that we get breakpointable warnings for
missing resources in the future.
Related: bug 464700
CCMAIL:dimul...@gmail.com
CCMAIL:tamtamy.tym...@gmail.com
(cherry picked from commit 973acffa8a24c640e3a3c95007f99dfe4b4f5f48)

M  +15   -5libs/image/kis_asl_layer_style_serializer.cpp
M  +2-0libs/image/layerstyles/kis_ls_utils.cpp
M  +5-0libs/resources/KisLocalStrokeResources.cpp
M  +6-0libs/resources/KisRequiredResourcesOperators.cpp
M  +1-0libs/resources/KoResourceLoadResult.cpp
M  +8-0plugins/impex/psd/psd_loader.cpp

https://invent.kde.org/graphics/krita/commit/8e83efca125a263dc993cf92e89c290f9339efe3

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 464700] krita quits opening a specific psd file created with photopea.

2023-01-27 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=464700

amyspark  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/grap
   ||hics/krita/commit/973acffa8
   ||a24c640e3a3c95007f99dfe4b4f
   ||5f48

--- Comment #11 from amyspark  ---
Git commit 973acffa8a24c640e3a3c95007f99dfe4b4f5f48 by L. E. Segovia.
Committed on 28/01/2023 at 01:29.
Pushed by lsegovia into branch 'master'.

KisAslLayerStyleSerializer: fix layer-local patterns

This is the counterpart of bug 441605, we only found this one out
because in 464700 Wolthera injects a placeholder pattern, which in turn
was never put into global storage.

For the sake of completionism, I've added several safe asserts in the
path that the nullptr makes, so that we get breakpointable warnings for
missing resources in the future.
Related: bug 441605
CCMAIL:dimul...@gmail.com
CCMAIL:tamtamy.tym...@gmail.com

M  +15   -5libs/image/kis_asl_layer_style_serializer.cpp
M  +2-0libs/image/layerstyles/kis_ls_utils.cpp
M  +5-0libs/resources/KisLocalStrokeResources.cpp
M  +6-0libs/resources/KisRequiredResourcesOperators.cpp
M  +1-0libs/resources/KoResourceLoadResult.cpp
M  +8-0plugins/impex/psd/psd_loader.cpp

https://invent.kde.org/graphics/krita/commit/973acffa8a24c640e3a3c95007f99dfe4b4f5f48

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 441605] Safe assert on reading a file with a layer style

2023-01-27 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=441605

--- Comment #8 from amyspark  ---
Git commit 973acffa8a24c640e3a3c95007f99dfe4b4f5f48 by L. E. Segovia.
Committed on 28/01/2023 at 01:29.
Pushed by lsegovia into branch 'master'.

KisAslLayerStyleSerializer: fix layer-local patterns

This is the counterpart of bug 441605, we only found this one out
because in 464700 Wolthera injects a placeholder pattern, which in turn
was never put into global storage.

For the sake of completionism, I've added several safe asserts in the
path that the nullptr makes, so that we get breakpointable warnings for
missing resources in the future.
Related: bug 464700
CCMAIL:dimul...@gmail.com
CCMAIL:tamtamy.tym...@gmail.com

M  +15   -5libs/image/kis_asl_layer_style_serializer.cpp
M  +2-0libs/image/layerstyles/kis_ls_utils.cpp
M  +5-0libs/resources/KisLocalStrokeResources.cpp
M  +6-0libs/resources/KisRequiredResourcesOperators.cpp
M  +1-0libs/resources/KoResourceLoadResult.cpp
M  +8-0plugins/impex/psd/psd_loader.cpp

https://invent.kde.org/graphics/krita/commit/973acffa8a24c640e3a3c95007f99dfe4b4f5f48

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 464700] krita quits opening a specific psd file created with photopea.

2023-01-27 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=464700

amyspark  changed:

   What|Removed |Added

 Depends on||441605

--- Comment #10 from amyspark  ---
So upon further checking, the "invalid" placeholder pattern we inject for these
cases triggers the counterpart of bug 441605: these patterns were never pushed
into the global resource server on layer style read completion.

Pushing a hotfix in a few moments.


Referenced Bugs:

https://bugs.kde.org/show_bug.cgi?id=441605
[Bug 441605] Safe assert on reading a file with a layer style
-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 441605] Safe assert on reading a file with a layer style

2023-01-27 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=441605

amyspark  changed:

   What|Removed |Added

 Blocks||464700


Referenced Bugs:

https://bugs.kde.org/show_bug.cgi?id=464700
[Bug 464700] krita quits opening a specific psd file created with photopea.
-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 464700] krita quits opening a specific psd file created with photopea.

2023-01-27 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=464700

--- Comment #9 from amyspark  ---
Can confirm the crash happens here. After adding an early return to work around
it, I get the following warnings:

krita.general: Unhandled: "/null/FrFX/overprint" class QHash > false
krita.general: WARNING: ASL style contains non-existent pattern reference!
Searching for uuid:  "c7acb22a-47a6-11de-919a-bf574370eaaf"  (name: 
"Default/orangeslices" )
krita.general: convertAndSetBlendMode: Curve conversion is not implemented yet
krita.general: Unhandled: "/null/DrSh/Cntn" class QHash > false
SAFE ASSERT (krita): "!localResources.contains(KoResourceSP())" in file
E:\krita-win\src\libs\resources\KisLocalStrokeResources.cpp, line 79

The "Unhandled" warnings refer to your use of drop shadows in the layer, we
don't support those yet.

But moving past that, this looks like the Photoshop file is incomplete. The
layer references a missing pattern, which causes Krita to insert a null pattern
into the list, then remove it, and finally access it outright. Digging further
into this.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 464848] Krita instantly crashing

2023-01-27 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=464848

amyspark  changed:

   What|Removed |Added

 Status|ASSIGNED|NEEDSINFO
 Resolution|--- |WAITINGFORINFO

--- Comment #9 from amyspark  ---
The example file opens fine here, it uses the standard Elle sRGB color profile.

Given it still crashes for you, could you try temporarily removing the screens'
calibrated color profiles, set the default "LCD color" profile on them, then
try launching Krita again? If it stops crashing, please attach those two color
profiles here.

Otherwise, please check the preferences file -- /Library/Preferences/kritarc. Open it, then try the following, one Entry
At A Time:

- check any "monitorProfile" entries and remove them
- check any "FileX" and "NameX" entries in the [RecentFiles] section and remove
them, where X is a number

In both cases, save (but don't close TextEdit) and try launching Krita again.
Once and if it stops crashing then, send us the file corresponding to the entry
that you last removed.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 464848] Krita instantly crashing

2023-01-27 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=464848

amyspark  changed:

   What|Removed |Added

 Ever confirmed|0   |1
   Assignee|krita-bugs-n...@kde.org |a...@amyspark.me
 Status|REPORTED|ASSIGNED

--- Comment #7 from amyspark  ---
Assigning, the first crash report looks like a completely empty ICC profile
makes it past our checks.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 464700] krita quits opening a specific psd file created with photopea.

2023-01-26 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=464700

amyspark  changed:

   What|Removed |Added

 Status|NEEDSINFO   |ASSIGNED
   Assignee|krita-bugs-n...@kde.org |a...@amyspark.me
 Resolution|WAITINGFORINFO  |---
 Ever confirmed|0   |1

--- Comment #8 from amyspark  ---
File made it in one piece from the looks of Bugzilla. Let's see what's
inside...

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 464848] Krita instantly crashing

2023-01-26 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=464848

amyspark  changed:

   What|Removed |Added

 CC||a...@amyspark.me
  Component|* Unknown   |Color models

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 464464] broken 5.2.0 macos dmg, Python initialization error

2023-01-24 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=464464

--- Comment #2 from amyspark  ---
This is the full script log:

krita.scripting: Loading Python plugin
krita.scripting: Initializing Python plugin for Python 3 , 10
krita.scripting: Plugin Directories:  ("/Users/amalia/Library/Application
Support/krita/", "/Volumes/krita/krita.app/Contents/Resources/",
"/Users/amalia/Library/Application Support/krita/pykrita/",
"/Volumes/krita/krita.app/Contents/share/krita/pykrita/",
"/Volumes/krita/krita.app/share/krita/pykrita/",
"/Volumes/krita/krita.app/Contents/share/pykrita/")
krita.scripting: Python::setPath. Script paths:
("/Users/amalia/Library/Application Support/krita/",
"/Volumes/krita/krita.app/Contents/Resources/",
"/Users/amalia/Library/Application Support/krita/pykrita/",
"/Volumes/krita/krita.app/Contents/share/krita/pykrita/",
"/Volumes/krita/krita.app/share/krita/pykrita/",
"/Volumes/krita/krita.app/Contents/share/pykrita/") true
krita.scripting: pythonLibsPath (krita-python-libs)
"/Volumes/krita/krita.app/Contents/Frameworks/krita-python-libs"
krita.scripting: Found krita-python-libs at
"/Volumes/krita/krita.app/Contents/Frameworks/krita-python-libs"
krita.scripting: pythonLibsPath (sip) ""
krita.scripting: "python3.10" "python3.10"
krita.scripting: Setting python paths: "/Users/amalia/Library/Application
Support/krita/:/Volumes/krita/krita.app/Contents/Resources/:/Users/amalia/Library/Application
Support/krita/pykrita/:/Volumes/krita/krita.app/Contents/share/krita/pykrita/:/Volumes/krita/krita.app/share/krita/pykrita/:/Volumes/krita/krita.app/Contents/share/pykrita/:/Volumes/krita/krita.app/Contents/Frameworks/krita-python-libs:/Users/Packaging/KritaBuild/i/lib/python3.10/site-packages:/Users/Packaging/KritaBuild/i/lib/python3.10/site-packages/PyQt5"
krita.scripting: Initializing Python interpreter
Python path configuration:
  PYTHONHOME =
'/Volumes/krita/krita.app/Contents/Frameworks/Python.framework/Versions/3.10/lib/python3.10'
  PYTHONPATH = (not set)
  program name = 'python3'
  isolated = 0
  environment = 1
  user site = 1
  import site = 1
  sys._base_executable = '/Volumes/krita/krita.app/./Contents/MacOS/krita'
  sys.base_prefix = ''
  sys.base_exec_prefix = ''
  sys.platlibdir = 'lib'
  sys.executable = '/Volumes/krita/krita.app/./Contents/MacOS/krita'
  sys.prefix = ''
  sys.exec_prefix = ''
  sys.path = [
'/Users/amalia/Library/Application Support/krita/',
'/Volumes/krita/krita.app/Contents/Resources/',
'/Users/amalia/Library/Application Support/krita/pykrita/',
'/Volumes/krita/krita.app/Contents/share/krita/pykrita/',
'/Volumes/krita/krita.app/share/krita/pykrita/',
'/Volumes/krita/krita.app/Contents/share/pykrita/',
'/Volumes/krita/krita.app/Contents/Frameworks/krita-python-libs',
'/Users/Packaging/KritaBuild/i/lib/python3.10/site-packages',
'/Users/Packaging/KritaBuild/i/lib/python3.10/site-packages/PyQt5',
  ]
Fatal Python error: init_fs_encoding: failed to get the Python codec of the
filesystem encoding
Python runtime state: core initialized
ModuleNotFoundError: No module named 'encodings'

Current thread 0x000113f8ce00 (most recent call first):
  
krita.general: Warning: some tiles have leaked:
krita.general:  Tiles in memory: 4 
Total tiles: 4
fish: Job 1, 'env QT_LOGGING_RULES="krita.scr…' terminated by signal SIGSEGV
(Address boundary error)

See the lines hardcoded to the binary factory? It means that Krita's thinking
that we're running from a system installation of Python (utilities.cpp line
382,  involving KRITA_PYKRITA_LIBRARY). findKritaPythonLibsPath needs to be
fixed so that it detects Python 3.10.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 464518] Nightly Windows build fails to load Python plugins

2023-01-24 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=464518

--- Comment #4 from amyspark  ---
Freya, sysadmin updated Python to 3.10 on Windows today morning. I've
redeployed the upgrade, refreshed the nightly build, and now it loads 3.10
successfully. Let me know if you find any issues with the Python support!

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 464518] Nightly Windows build fails to load Python plugins

2023-01-23 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=464518

amyspark  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/grap
   ||hics/krita/commit/ed6d5e622
   ||f4376cc6888f4cc2bb5b397ef64
   ||4e8c

--- Comment #3 from amyspark  ---
Git commit ed6d5e622f4376cc6888f4cc2bb5b397ef644e8c by L. E. Segovia.
Committed on 24/01/2023 at 03:26.
Pushed by lsegovia into branch 'master'.

python: Revert upgrade to 3.10 on Windows

Unfortunately, CI still relies on 3.8 for its virtualenv. Filed T16165
with sysadmin to confirm the version, and if an upgrade is possible.
CCMAIL:kimages...@kde.org

M  +6-83rdparty/ext_python/CMakeLists.txt

https://invent.kde.org/graphics/krita/commit/ed6d5e622f4376cc6888f4cc2bb5b397ef644e8c

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 464518] Nightly Windows build fails to load Python plugins

2023-01-23 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=464518

--- Comment #2 from amyspark  ---
CI isn't deploying Python 3.10, it's deploying still 3.8. This doesn't match
3rdparty, so I'll have to revert the upgrade.

I'm testing the patch along with some other stuff, I'll send it by tonight's
builds.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 464518] Nightly Windows build fails to load Python plugins

2023-01-23 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=464518

--- Comment #1 from amyspark  ---
Can confirm, commit fa671d407f. I'll look into it now.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 464518] Nightly Windows build fails to load Python plugins

2023-01-23 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=464518

amyspark  changed:

   What|Removed |Added

 Status|REPORTED|ASSIGNED
 Ever confirmed|0   |1
   Assignee|krita-bugs-n...@kde.org |a...@amyspark.me
 CC||a...@amyspark.me

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 444876] Krita's 4.4.8 crashing when creating and opening a file on MacOs 10.15.7

2023-01-23 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=444876

amyspark  changed:

   What|Removed |Added

 Resolution|--- |UNMAINTAINED
 Status|REPORTED|RESOLVED
 CC||a...@amyspark.me

--- Comment #1 from amyspark  ---
Apologies, I'm closing this bug because it was filed against the wrong
component, and 4.4.8 has been long an unsupported version.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 444876] Krita's 4.4.8 crashing when creating and opening a file on MacOs 10.15.7

2023-01-23 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=444876

amyspark  changed:

   What|Removed |Added

   Assignee|fa...@kde.org   |krita-bugs-n...@kde.org
  Component|general |General
Product|frameworks-kcrash   |krita

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 464255] X11 connection broken on startup.

2023-01-23 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=464255

amyspark  changed:

   What|Removed |Added

  Component|* Unknown   |OpenGL Canvas
 CC||a...@amyspark.me
 Resolution|FIXED   |---
   Assignee|krita-bugs-n...@kde.org |a...@amyspark.me
 Status|RESOLVED|REOPENED

--- Comment #7 from amyspark  ---
Reopening and assigning to myself to adjust the reverted commit.

Logs for reference: https://invent.kde.org/-/snippets/2478
https://invent.kde.org/-/snippets/2477

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 464710] Support opening .kra files bzip2 compressed

2023-01-23 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=464710

amyspark  changed:

   What|Removed |Added

Version|unspecified |git master (please specify
   ||the git hash!)
 CC||a...@amyspark.me

--- Comment #1 from amyspark  ---
Hi!

It's an interesting thing to do for sure. However, I believe the real problem
is that the tests you showed do not apply to KRA; the biggest contribution is
made by pixel layers, which are binary and of much higher entropy than a .txt.

I'd be glad to see if other algorithms (Zstandard, LZMA2, gzip, etc.)  are more
suitable for this case; and having multithreaded compression would certainly
help a lot, irrespective of whether we change the algorithm.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 464700] krita quits opening a specific psd file created with photopea.

2023-01-23 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=464700

amyspark  changed:

   What|Removed |Added

 Resolution|--- |WAITINGFORINFO
  Component|* Unknown   |File formats
 Status|REPORTED|NEEDSINFO
 CC||a...@amyspark.me

--- Comment #2 from amyspark  ---
Hi! Please sends us the file (or just the layer, as Dmitry said) and I'll take
a look into it.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 464463] Windows Nightlys are missing /share/ data

2023-01-18 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=464463

amyspark  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/grap
   ||hics/krita/commit/f1fedafec
   ||cd6e84ad5d9329d56c228ff095b
   ||ef33
 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED

--- Comment #1 from amyspark  ---
Git commit f1fedafeccd6e84ad5d9329d56c228ff095bef33 by L. E. Segovia.
Committed on 18/01/2023 at 18:27.
Pushed by lsegovia into branch 'master'.

frameworks: Recover and reapply Halla's change of DATAROOTDIR

A  +37   -0   
3rdparty/ext_frameworks/0003-Revert-Use-BIN_INSTALL_DIR-data-for-DATAROOTDIR-on-W.patch
M  +1-03rdparty/ext_frameworks/CMakeLists.txt

https://invent.kde.org/graphics/krita/commit/f1fedafeccd6e84ad5d9329d56c228ff095bef33

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 464463] Windows Nightlys are missing /share/ data

2023-01-18 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=464463

amyspark  changed:

   What|Removed |Added

   Keywords||triaged

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 464464] broken 5.2.0 macos dmg, Python initialization error

2023-01-18 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=464464

amyspark  changed:

   What|Removed |Added

 Status|REPORTED|ASSIGNED
 CC||a...@amyspark.me
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 464463] Windows Nightlys are missing /share/ data

2023-01-18 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=464463

amyspark  changed:

   What|Removed |Added

   Assignee|krita-bugs-n...@kde.org |a...@amyspark.me
  Component|* Unknown   |General
Version|nightly build (please   |git master (please specify
   |specify the git hash!)  |the git hash!)
 Ever confirmed|0   |1
 Status|REPORTED|ASSIGNED
 CC||a...@amyspark.me

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 361746] Crashes on opening corrupted jpg file

2023-01-18 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=361746

--- Comment #12 from amyspark  ---
Git commit 9b7b48f4da5655035497be17e516b4a826f8b54e by L. E. Segovia.
Committed on 18/01/2023 at 02:42.
Pushed by lsegovia into branch 'master'.

global: Fix ECM exception handling semantics mismatch in MSVC

According to the Extra CMake Modules documentation [1],

> kde_enable_exceptions()
>
> Enables exceptions for C++ source files compiled for the CMakeLists.txt
> file in the current directory and all subdirectories.

What isn't listed there, however, is that exceptions are enabled through
the usage of -fexceptions (GCC/Clang) and -EHsc (MSVC/Intel) [2]. All
good... except that those mean slightly different things:

> -fexceptions
>
>Enable exception handling. Generates extra code needed to propagate
>exceptions. For some targets, this implies GCC generates frame
>unwind information for all functions, which can produce significant
>data size overhead, although it does not affect execution. If you do
>not specify this option, GCC enables it by default for languages
>like C++ that normally require exception handling, and disables it
>for languages like C that do not normally require it. However, you
>may need to enable this option when compiling C code that needs to
>interoperate properly with exception handlers written in C++. You
>may also wish to disable this option if you are compiling older C++
>programs that don’t use exception handling.

(source: [3])

> c
> When used with /EHs, the compiler assumes that functions declared as
> extern "C" never throw a C++ exception. It has no effect when used with
> /EHa (that is, /EHca is equivalent to /EHa). /EHc is ignored if /EHs or
> /EHa aren't specified.

(source: [4])

These two put together mean that any exception thrown in a callstack
with C code in between works in Unix-y compilers, while they would
crash straight to Qt/QtConcurrent's event loop in MSVC.

The only affected piece of code is the JPEG error catcher,
introduced by Halla in 5c4c327ad429def4eaccc8d7bbd8f70d374a51ae, so
I added a file-level workaround there. A Krita-wide workaround is not
possible at the moment; all consumers of kritapigment would need the
same surgical workaround, because OpenEXR also injects /EHsc through
its exported targets. This was already reported upstream [5].

[1]: https://api.kde.org/ecm/kde-module/KDECompilerSettings.html
[2]:
https://invent.kde.org/frameworks/extra-cmake-modules/-/blob/v5.101.0/kde-modules/KDECompilerSettings.cmake#L502-526
[3]:
https://gcc.gnu.org/onlinedocs/gcc-7.3.0/gcc/Code-Gen-Options.html#index-fexceptions
[4]:
https://learn.microsoft.com/en-us/cpp/build/reference/eh-exception-handling-model?view=msvc-170#arguments
[5]: https://github.com/AcademySoftwareFoundation/openexr/issues/1326
CCMAIL: kimages...@kde.org

M  +4-0CMakeLists.txt
M  +7-0plugins/impex/jpeg/CMakeLists.txt

https://invent.kde.org/graphics/krita/commit/9b7b48f4da5655035497be17e516b4a826f8b54e

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 461975] Broken EXR and TIFF when exporting from some color spaces

2023-01-17 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=461975

amyspark  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

--- Comment #19 from amyspark  ---
> First issue: Maybe it's easy to solve by just deleting the file before 
> re-creating it on read-write mode or something like that.

This is because libtiff's one of the few libraries that need to go through Qt's
QIODevice to work in Android. IIRC, libtiff does not reuse IFDs on rewrite, so
we'll have to open the file with truncation mode to keep it from ballooning.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 464301] Force convert PNG to 8-bit on export option produces significantly worse results than manually downsampling.

2023-01-14 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=464301

amyspark  changed:

   What|Removed |Added

 CC||a...@amyspark.me
   Assignee|krita-bugs-n...@kde.org |a...@amyspark.me
 Status|REPORTED|ASSIGNED
 Ever confirmed|0   |1

--- Comment #1 from amyspark  ---
I was just working locally on this as a toy project. Assigning.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 464015] Psd files don't load layers correctly

2023-01-14 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=464015

amyspark  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/krita/commit/0abf00bab |hics/krita/commit/4e69b49f8
   |fa80689521a67fcdb4527fc980d |bbfc8feebf727e6410018521d12
   |25f7|c040

--- Comment #28 from amyspark  ---
Git commit 4e69b49f8bbfc8feebf727e6410018521d12c040 by L. E. Segovia.
Committed on 14/01/2023 at 12:29.
Pushed by lsegovia into branch 'krita/5.1'.

PSD: fix using implementation-defined signedness when decompressing RLE
(cherry picked from commit 0abf00babfa80689521a67fcdb4527fc980d25f7)

M  +3-2libs/psdutils/compression.cpp

https://invent.kde.org/graphics/krita/commit/4e69b49f8bbfc8feebf727e6410018521d12c040

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 464015] Psd files don't load layers correctly

2023-01-14 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=464015

amyspark  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED
  Latest Commit||https://invent.kde.org/grap
   ||hics/krita/commit/0abf00bab
   ||fa80689521a67fcdb4527fc980d
   ||25f7

--- Comment #27 from amyspark  ---
Git commit 0abf00babfa80689521a67fcdb4527fc980d25f7 by L. E. Segovia.
Committed on 14/01/2023 at 12:29.
Pushed by lsegovia into branch 'master'.

PSD: fix using implementation-defined signedness when decompressing RLE

M  +3-2libs/psdutils/compression.cpp

https://invent.kde.org/graphics/krita/commit/0abf00babfa80689521a67fcdb4527fc980d25f7

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 464015] Psd files don't load layers correctly

2023-01-14 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=464015

amyspark  changed:

   What|Removed |Added

 Status|REPORTED|ASSIGNED
 Ever confirmed|0   |1

--- Comment #26 from amyspark  ---
(In reply to sh_zam from comment #25)
> char type is unsigned on ARM and
> PackBits requires header to be signed here:

EEK. Assigning to myself, incoming fix now.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 461555] Trying to set a pattern through Krita API generate a crash

2023-01-12 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=461555

amyspark  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/krita/commit/33f242b88 |hics/krita/commit/9015a3869
   |75ef305541bd6536f17500906ea |5f16639170b349962d16c6328f1
   |5cc4|26a5

--- Comment #5 from amyspark  ---
Git commit 9015a38695f16639170b349962d16c6328f126a5 by L. E. Segovia.
Committed on 12/01/2023 at 22:11.
Pushed by lsegovia into branch 'krita/5.1'.

libkis: Use the proper pointer types for marshalling resources on activation
(cherry picked from commit 33f242b8875ef305541bd6536f17500906ea5cc4)

M  +8-13   libs/libkis/View.cpp
M  +5-2libs/ui/kis_control_frame.cpp
M  +1-2plugins/dockers/patterndocker/patterndocker_dock.cpp

https://invent.kde.org/graphics/krita/commit/9015a38695f16639170b349962d16c6328f126a5

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 461555] Trying to set a pattern through Krita API generate a crash

2023-01-12 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=461555

amyspark  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/grap
   ||hics/krita/commit/33f242b88
   ||75ef305541bd6536f17500906ea
   ||5cc4
 Status|ASSIGNED|RESOLVED

--- Comment #4 from amyspark  ---
Git commit 33f242b8875ef305541bd6536f17500906ea5cc4 by L. E. Segovia.
Committed on 12/01/2023 at 22:10.
Pushed by lsegovia into branch 'master'.

libkis: Use the proper pointer types for marshalling resources on activation

M  +8-13   libs/libkis/View.cpp
M  +5-2libs/ui/kis_control_frame.cpp
M  +1-2plugins/dockers/patterndocker/patterndocker_dock.cpp

https://invent.kde.org/graphics/krita/commit/33f242b8875ef305541bd6536f17500906ea5cc4

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 461555] Trying to set a pattern through Krita API generate a crash

2023-01-12 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=461555

amyspark  changed:

   What|Removed |Added

 Status|CONFIRMED   |ASSIGNED
 CC||a...@amyspark.me

--- Comment #3 from amyspark  ---
However, upon reproducing the traceback, the pattern is not null; it becomes
null somewhere between View::activateResource and
KisControlFrame::slotSetPattern. Assigning to myself.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 464015] Psd files don't load layers correctly

2023-01-10 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=464015

amyspark  changed:

   What|Removed |Added

 Status|ASSIGNED|NEEDSINFO
 Resolution|--- |WAITINGFORINFO

--- Comment #16 from amyspark  ---
I cannot reproduce with desktop 5.15, used 8-bit RGBA for the export and then
opened the file back into Krita.

If you have a file that renders like that after export, please let us know by
attaching it to this bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 464015] Psd files don't load layers correctly

2023-01-10 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=464015

--- Comment #15 from amyspark  ---
I'll start working on this later today.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 463914] Unexpected error when loading unusual jxl file

2023-01-08 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=463914

amyspark  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |NOT A BUG

--- Comment #5 from amyspark  ---
Ok, then closing as intended by upstream.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 464015] Psd files don't load layers correctly

2023-01-08 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=464015

amyspark  changed:

   What|Removed |Added

 CC||a...@amyspark.me
   Assignee|krita-bugs-n...@kde.org |a...@amyspark.me
 Ever confirmed|0   |1
 Status|REPORTED|ASSIGNED

--- Comment #1 from amyspark  ---
Hi! I'll assign this bug to myself.

In the meanwhile, could you please send a small test case to help reproduce the
bug? Both KRA and the exported PSD.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 463914] Unexpected error when loading unusual jxl file

2023-01-06 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=463914

amyspark  changed:

   What|Removed |Added

   Assignee|krita-bugs-n...@kde.org |a...@amyspark.me
 Status|CONFIRMED   |ASSIGNED

--- Comment #3 from amyspark  ---
Found it. It's "Rubin golden vase 1" from https://jpegxl.info/art/ and it
doesn't render on Firefox. It does have a source linked from which I can render
it, so I'll take a look after the Qt 5.15 mopping.

Assigning to myself.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 463756] CMYK its broken layers modes

2023-01-02 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=463756

amyspark  changed:

   What|Removed |Added

 CC||a...@amyspark.me
 Status|REPORTED|NEEDSINFO
 Resolution|--- |WAITINGFORINFO

--- Comment #1 from amyspark  ---
Hi! Same as 463757-- to reproduce, please send a sample you can reproduce it
with. Also tell us which depths you were working with.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 463757] krita closes when I paste an image with cmyk profile

2023-01-02 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=463757

amyspark  changed:

   What|Removed |Added

 CC||a...@amyspark.me
  Component|* Unknown   |Color models
 Resolution|--- |WAITINGFORINFO
 Status|REPORTED|NEEDSINFO

--- Comment #1 from amyspark  ---
Hi! To reproduce, please send a sample you can reproduce it with, and also (if
possible) the backtrace of the error.

See
https://community.kde.org/Guidelines_and_HOWTOs/Debugging/How_to_create_useful_crash_reports

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 463651] New: PNG support for HDR clamps the dynamic range to SDR

2022-12-30 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=463651

Bug ID: 463651
   Summary: PNG support for HDR clamps the dynamic range to SDR
Classification: Applications
   Product: krita
   Version: git master (please specify the git hash!)
  Platform: Compiled Sources
OS: Microsoft Windows
Status: REPORTED
  Keywords: regression
  Severity: normal
  Priority: NOR
 Component: File formats
  Assignee: dimul...@gmail.com
  Reporter: a...@amyspark.me
Depends on: 355727
  Target Milestone: ---

SUMMARY
***
NOTE: If you are reporting a crash, please try to attach a backtrace with debug
symbols.
See
https://community.kde.org/Guidelines_and_HOWTOs/Debugging/How_to_create_useful_crash_reports
***

While trying to test the HDR support of Krita, I noticed that the HDR test
failed, because the color conversion transformation clamps the channel values
to 0.0-1.0.

There is a possibly related issue, which I've linked here. It worked previously
to sometime before the following commits, because those sidestepped the issue
by manually managing the color (same as is currently done with JXL and HEIF by
me and Wolthera):

https://invent.kde.org/graphics/krita/-/commit/16203f979dc8b064814e4d99f0ea7c39148d22b0
https://invent.kde.org/graphics/krita/-/commit/3bdf84eaedd4d539ce1ee6b7abb47681d56af2bf

Marked as regression since at least 4.2.0 based on the above commits.

STEPS TO REPRODUCE
1. Build Krita.
2. Export a HDR image to PNG and open it back. Alternatively, run kis_png_test.

OBSERVED RESULT

The HDR information is preserved.

EXPECTED RESULT

All HDR information is clamped to 1.0.

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
commit c7bec2eae0f767960ace049677f6742e6b387a5f


Referenced Bugs:

https://bugs.kde.org/show_bug.cgi?id=355727
[Bug 355727] Colour adjustment filter layers clamp HDR images
-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 355727] Colour adjustment filter layers clamp HDR images

2022-12-30 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=355727

amyspark  changed:

   What|Removed |Added

 Blocks||463651


Referenced Bugs:

https://bugs.kde.org/show_bug.cgi?id=463651
[Bug 463651] PNG support for HDR clamps the dynamic range to SDR
-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 463632] PSD parsing error

2022-12-30 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=463632

amyspark  changed:

   What|Removed |Added

   Severity|normal  |wishlist
  Component|Filter Layers   |File formats

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 461975] Broken EXR and TIFF when exporting from some color spaces

2022-12-26 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=461975

--- Comment #16 from amyspark  ---
I'm working on supporting vector layers, at least by converting them to
bitmaps. The code is, however, so old that it'll take me a while before I can
show some reliable results.

I'll CC this bug once I have news; but as this bit is specifically a wishlist
one, I've marked this bug as resolved.

Thanks for your testing and the heads up!

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 461975] Broken EXR and TIFF when exporting from some color spaces

2022-12-26 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=461975

amyspark  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/krita/commit/ee625a5f0 |hics/krita/commit/132211ddd
   |dc63eb23f5a9e913837d01e7692 |13a34a56ab46c5c89282b63a955
   |1d0e|f4fc

--- Comment #15 from amyspark  ---
Git commit 132211ddd13a34a56ab46c5c89282b63a955f4fc by L. E. Segovia.
Committed on 27/12/2022 at 02:53.
Pushed by lsegovia into branch 'krita/5.1'.

EXR: fix opening files with only luma channel
(cherry picked from commit ee625a5f0dc63eb23f5a9e913837d01e76921d0e)

M  +23   -5plugins/impex/exr/exr_converter.cc

https://invent.kde.org/graphics/krita/commit/132211ddd13a34a56ab46c5c89282b63a955f4fc

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 461975] Broken EXR and TIFF when exporting from some color spaces

2022-12-26 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=461975

amyspark  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
  Latest Commit||https://invent.kde.org/grap
   ||hics/krita/commit/ee625a5f0
   ||dc63eb23f5a9e913837d01e7692
   ||1d0e
 Resolution|--- |FIXED

--- Comment #14 from amyspark  ---
Git commit ee625a5f0dc63eb23f5a9e913837d01e76921d0e by L. E. Segovia.
Committed on 27/12/2022 at 02:52.
Pushed by lsegovia into branch 'master'.

EXR: fix opening files with only luma channel

M  +23   -5plugins/impex/exr/exr_converter.cc

https://invent.kde.org/graphics/krita/commit/ee625a5f0dc63eb23f5a9e913837d01e76921d0e

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 462055] Metadata gets lost reading CR2 file (Canon RAW)

2022-12-23 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=462055

amyspark  changed:

   What|Removed |Added

   Severity|normal  |wishlist

--- Comment #12 from amyspark  ---
Marking as wishlist because it's a new feature. Scheduled for 5.2.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 462055] Metadata gets lost reading CR2 file (Canon RAW)

2022-12-23 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=462055

amyspark  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/grap
   ||hics/krita/commit/bebb3293a
   ||9497adfeb7ae7e41b380fea633f
   ||3761
 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED

--- Comment #11 from amyspark  ---
Git commit bebb3293a9497adfeb7ae7e41b380fea633f3761 by L. E. Segovia.
Committed on 23/12/2022 at 17:53.
Pushed by lsegovia into branch 'master'.

RAW: implement metadata import based on the TIFF approach

M  +1-1plugins/impex/raw/CMakeLists.txt
M  +84   -14   plugins/impex/raw/kis_raw_import.cpp

https://invent.kde.org/graphics/krita/commit/bebb3293a9497adfeb7ae7e41b380fea633f3761

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 463219] Color depths other than 8-bit cause artifacts

2022-12-23 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=463219

amyspark  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/krita/commit/61cf80d57 |hics/krita/commit/b388330bd
   |a103aa8ec8ffe2b7c369c5f61de |b8915af0fa1b1bac1bf473507a8
   |f890|c045

--- Comment #7 from amyspark  ---
Git commit b388330bdb8915af0fa1b1bac1bf473507a8c045 by L. E. Segovia.
Committed on 23/12/2022 at 16:44.
Pushed by lsegovia into branch 'krita/5.1'.

xsimd: Avoid using zip_* in xsimd >= 10

xsimd 10 introduces an undocumented, breaking change in the batch
zipping semantics. These are relied on in the RGBA interleavers,
when they replaced the old gather/scatter implementation.

To work around them, the old implementation was brought back,
surrounded with suitable guards, and the corresponding error pragma
was added to KoRgbaInterleavers.h.
(cherry picked from commit 61cf80d57a103aa8ec8ffe2b7c369c5f61def890)

M  +4-0libs/pigment/compositeops/KoRgbaInterleavers.h
M  +52   -0libs/pigment/compositeops/KoStreamedMath.h

https://invent.kde.org/graphics/krita/commit/b388330bdb8915af0fa1b1bac1bf473507a8c045

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 463219] Color depths other than 8-bit cause artifacts

2022-12-23 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=463219

amyspark  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/krita/commit/61cf80d57 |hics/krita/commit/b388330bd
   |a103aa8ec8ffe2b7c369c5f61de |b8915af0fa1b1bac1bf473507a8
   |f890|c045
  Component|* Unknown   |Color models
  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/krita/commit/b388330bd |hics/krita/commit/61cf80d57
   |b8915af0fa1b1bac1bf473507a8 |a103aa8ec8ffe2b7c369c5f61de
   |c045|f890

--- Comment #7 from amyspark  ---
Git commit b388330bdb8915af0fa1b1bac1bf473507a8c045 by L. E. Segovia.
Committed on 23/12/2022 at 16:44.
Pushed by lsegovia into branch 'krita/5.1'.

xsimd: Avoid using zip_* in xsimd >= 10

xsimd 10 introduces an undocumented, breaking change in the batch
zipping semantics. These are relied on in the RGBA interleavers,
when they replaced the old gather/scatter implementation.

To work around them, the old implementation was brought back,
surrounded with suitable guards, and the corresponding error pragma
was added to KoRgbaInterleavers.h.
(cherry picked from commit 61cf80d57a103aa8ec8ffe2b7c369c5f61def890)

M  +4-0libs/pigment/compositeops/KoRgbaInterleavers.h
M  +52   -0libs/pigment/compositeops/KoStreamedMath.h

https://invent.kde.org/graphics/krita/commit/b388330bdb8915af0fa1b1bac1bf473507a8c045

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 463219] Color depths other than 8-bit cause artifacts

2022-12-23 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=463219

amyspark  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/grap
   ||hics/krita/commit/61cf80d57
   ||a103aa8ec8ffe2b7c369c5f61de
   ||f890
 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED

--- Comment #6 from amyspark  ---
Git commit 61cf80d57a103aa8ec8ffe2b7c369c5f61def890 by L. E. Segovia.
Committed on 23/12/2022 at 16:40.
Pushed by lsegovia into branch 'master'.

xsimd: Avoid using zip_* in xsimd >= 10

xsimd 10 introduces an undocumented, breaking change in the batch
zipping semantics. These are relied on in the RGBA interleavers,
when they replaced the old gather/scatter implementation.

To work around them, the old implementation was brought back,
surrounded with suitable guards, and the corresponding error pragma
was added to KoRgbaInterleavers.h.

M  +4-0libs/pigment/compositeops/KoRgbaInterleavers.h
M  +52   -0libs/pigment/compositeops/KoStreamedMath.h

https://invent.kde.org/graphics/krita/commit/61cf80d57a103aa8ec8ffe2b7c369c5f61def890

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 462417] Krita Version 5.1.1 & 5.1.3 not reading in a psd file well and Krita version 4.4.5 reads it in fine

2022-12-23 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=462417

amyspark  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/krita/commit/5b48a3994 |hics/krita/commit/0f826dd72
   |c0161685cebad10db10c93669e1 |121d873450f9e2b72e6df82c041
   |6ca6|69ea

--- Comment #8 from amyspark  ---
Git commit 0f826dd72121d873450f9e2b72e6df82c04169ea by L. E. Segovia.
Committed on 23/12/2022 at 13:54.
Pushed by lsegovia into branch 'krita/5.1'.

PSD: reimplement the PackBits decompressor

This commit reimplements the decompression routine in C++11 to enable
proper bounds checking, logging, and skipping the unnecessary copies.

M  +44   -93   libs/psdutils/compression.cpp

https://invent.kde.org/graphics/krita/commit/0f826dd72121d873450f9e2b72e6df82c04169ea

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 462417] Krita Version 5.1.1 & 5.1.3 not reading in a psd file well and Krita version 4.4.5 reads it in fine

2022-12-23 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=462417

amyspark  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/grap
   ||hics/krita/commit/5b48a3994
   ||c0161685cebad10db10c93669e1
   ||6ca6
 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #7 from amyspark  ---
Git commit 5b48a3994c0161685cebad10db10c93669e16ca6 by L. E. Segovia.
Committed on 23/12/2022 at 13:47.
Pushed by lsegovia into branch 'master'.

PSD: reimplement the PackBits decompressor

This commit reimplements the decompression routine in C++11 to enable
proper bounds checking, logging, and skipping the unnecessary copies.

M  +44   -93   libs/psdutils/compression.cpp

https://invent.kde.org/graphics/krita/commit/5b48a3994c0161685cebad10db10c93669e16ca6

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 462417] Krita Version 5.1.1 & 5.1.3 not reading in a psd file well and Krita version 4.4.5 reads it in fine

2022-12-22 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=462417

--- Comment #6 from amyspark  ---
The file you supplied does not comply with the PackBits compression scheme. In
v5, I ensured that whenever the decompression routine throws an error code, it
is acted upon by zeroing the relevant row, which is causing this bug.

The workaround is easy, but I'd like to confirm first why this is the case.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 462006] Crash when creating new image from selected region (clipboard)

2022-12-22 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=462006

--- Comment #4 from amyspark  ---
Git commit 6399b0203e7c7e8fa6fc40e4fdbe4a72cae2f304 by L. E. Segovia.
Committed on 22/12/2022 at 20:24.
Pushed by lsegovia into branch 'master'.

KisImageFromClipboardWidget: stave off a clipboard being cleared mid-access

M  +10   -6libs/ui/widgets/kis_image_from_clipboard_widget.cpp

https://invent.kde.org/graphics/krita/commit/6399b0203e7c7e8fa6fc40e4fdbe4a72cae2f304

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 462006] Crash when creating new image from selected region (clipboard)

2022-12-22 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=462006

amyspark  changed:

   What|Removed |Added

 Status|ASSIGNED|NEEDSINFO
 Resolution|--- |WAITINGFORINFO

--- Comment #3 from amyspark  ---
To the reporter: I need to pin down what's clearing the clipboard mid-copy.
Please ping back with the information requested.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 462096] colorize lineart [propagation] does not work because of a dimensions mismatch

2022-12-22 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=462096

amyspark  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/grap
   ||hics/krita/-/commit/1c8a38b
   ||419ba59ce6b3cfdf5bcb911da98
   ||c1370e
 Status|ASSIGNED|RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 463079] CMYK JXL files are causing krita to crash

2022-12-22 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=463079

amyspark  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
  Latest Commit||https://invent.kde.org/grap
   ||hics/krita/-/merge_requests
   ||/1673/diffs?commit_id=f29ba
   ||0207dab24117a53b1f2e98fae48
   ||4cf05b80
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 463052] Krita crashes on double free when closing application

2022-12-22 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=463052

amyspark  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED
  Latest Commit||https://invent.kde.org/grap
   ||hics/krita/commit/145176d25
   ||a0425346820d86d14388633e3d5
   ||8f40

--- Comment #2 from amyspark  ---
Git commit 145176d25a0425346820d86d14388633e3d58f40 by L. E. Segovia.
Committed on 22/12/2022 at 20:17.
Pushed by lsegovia into branch 'master'.

KoColorProfileStorage: fix possible crash on exit

M  +2-0libs/pigment/KoColorProfileStorage.cpp

https://invent.kde.org/graphics/krita/commit/145176d25a0425346820d86d14388633e3d58f40

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 463052] Krita crashes on double free when closing application

2022-12-22 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=463052

amyspark  changed:

   What|Removed |Added

  Component|* Unknown   |Resource Management

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 462965] Crash when opening GMic filter window

2022-12-12 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=462965

amyspark  changed:

   What|Removed |Added

 Status|NEEDSINFO   |RESOLVED
 Resolution|WAITINGFORINFO  |UPSTREAM

--- Comment #2 from amyspark  ---
The GMicProcessor does not disconnect target connections on thread destruction,
and the plugin should be asserting on the thread being NULL or freed before
hitting that line.

Based on the fact that it's built as as Release binary, thus not hitting the
assertion (this is not our release configuration) and that the code crashing is
not the Krita binding itself, I am marking it as an upstream bug. Please
forward this bug to https://github.com/c-koi/gmic-qt.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 462925] TIFF: Inconsistent enabling of Save transparency channel and Photoshop boxes

2022-12-12 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=462925

amyspark  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/krita/commit/7406cea00 |hics/krita/commit/4a34cf969
   |128c90feabc154daf890b8652b1 |3b8e2c96e5cd9bd285ccd4bb713
   |ef9a|1681

--- Comment #3 from amyspark  ---
Git commit 4a34cf9693b8e2c96e5cd9bd285ccd4bb7131681 by L. E. Segovia.
Committed on 12/12/2022 at 15:27.
Pushed by lsegovia into branch 'krita/5.1'.

TIFF: fix inconsistent state of alpha and Photoshop export checkboxes

Enable alpha exporting for CMYK as it's perfectly compatible
(cherry picked from commit 7406cea00128c90feabc154daf890b8652b1ef9a)

M  +3-2plugins/impex/tiff/kis_dlg_options_tiff.cpp

https://invent.kde.org/graphics/krita/commit/4a34cf9693b8e2c96e5cd9bd285ccd4bb7131681

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 461975] Broken EXR and TIFF when exporting from some color spaces

2022-12-12 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=461975

--- Comment #11 from amyspark  ---
Git commit 229cca731c977cbbc2914da45f3d3a4eb4edbccc by L. E. Segovia.
Committed on 12/12/2022 at 15:27.
Pushed by lsegovia into branch 'krita/5.1'.

TIFF: fix LibTiff requiring read/write access to write multi-page files
(cherry picked from commit 179a85f477627256aa2db22ac6ef8f7b6cb54b63)

M  +4-3plugins/impex/tiff/kis_tiff_export.cc

https://invent.kde.org/graphics/krita/commit/229cca731c977cbbc2914da45f3d3a4eb4edbccc

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 462799] EXR plugin exports grayscale images as RGB in the green channel only

2022-12-12 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=462799

amyspark  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/krita/commit/f2b1f3c52 |hics/krita/commit/8cbda2d88
   |6133757f6543859d48d8e32e7fa |aaf367a2f9fa730bf30177e6818
   |95a9|d002

--- Comment #5 from amyspark  ---
Git commit 8cbda2d88aaf367a2f9fa730bf30177e6818d002 by L. E. Segovia.
Committed on 12/12/2022 at 15:26.
Pushed by lsegovia into branch 'krita/5.1'.

EXR: implement consistent Gray and XYZ exporting
(cherry picked from commit f2b1f3c526133757f6543859d48d8e32e7fa95a9)

M  +43   -30   plugins/impex/exr/exr_converter.cc

https://invent.kde.org/graphics/krita/commit/8cbda2d88aaf367a2f9fa730bf30177e6818d002

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 462925] TIFF: Inconsistent enabling of Save transparency channel and Photoshop boxes

2022-12-12 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=462925

amyspark  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/grap
   ||hics/krita/commit/7406cea00
   ||128c90feabc154daf890b8652b1
   ||ef9a
 Status|ASSIGNED|RESOLVED

--- Comment #2 from amyspark  ---
Git commit 7406cea00128c90feabc154daf890b8652b1ef9a by L. E. Segovia.
Committed on 12/12/2022 at 15:23.
Pushed by lsegovia into branch 'master'.

TIFF: fix inconsistent state of alpha and Photoshop export checkboxes

Enable alpha exporting for CMYK as it's perfectly compatible

M  +3-2plugins/impex/tiff/kis_dlg_options_tiff.cpp

https://invent.kde.org/graphics/krita/commit/7406cea00128c90feabc154daf890b8652b1ef9a

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 461975] Broken EXR and TIFF when exporting from some color spaces

2022-12-12 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=461975
Bug 461975 depends on bug 462925, which changed state.

Bug 462925 Summary: TIFF: Inconsistent enabling of Save transparency channel 
and Photoshop boxes
https://bugs.kde.org/show_bug.cgi?id=462925

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 462799] EXR plugin exports grayscale images as RGB in the green channel only

2022-12-12 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=462799

amyspark  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED
  Latest Commit||https://invent.kde.org/grap
   ||hics/krita/commit/f2b1f3c52
   ||6133757f6543859d48d8e32e7fa
   ||95a9

--- Comment #4 from amyspark  ---
Git commit f2b1f3c526133757f6543859d48d8e32e7fa95a9 by L. E. Segovia.
Committed on 12/12/2022 at 15:23.
Pushed by lsegovia into branch 'master'.

EXR: implement consistent Gray and XYZ exporting

M  +43   -30   plugins/impex/exr/exr_converter.cc

https://invent.kde.org/graphics/krita/commit/f2b1f3c526133757f6543859d48d8e32e7fa95a9

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 288725] support single-channel exr files (was: Some .exr files don't open correctly)

2022-12-12 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=288725
Bug 288725 depends on bug 462799, which changed state.

Bug 462799 Summary: EXR plugin exports grayscale images as RGB in the green 
channel only
https://bugs.kde.org/show_bug.cgi?id=462799

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 461975] Broken EXR and TIFF when exporting from some color spaces

2022-12-12 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=461975

--- Comment #10 from amyspark  ---
Git commit 179a85f477627256aa2db22ac6ef8f7b6cb54b63 by L. E. Segovia.
Committed on 12/12/2022 at 15:23.
Pushed by lsegovia into branch 'master'.

TIFF: fix LibTiff requiring read/write access to write multi-page files

M  +4-3plugins/impex/tiff/kis_tiff_export.cc

https://invent.kde.org/graphics/krita/commit/179a85f477627256aa2db22ac6ef8f7b6cb54b63

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 461975] Broken EXR and TIFF when exporting from some color spaces

2022-12-12 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=461975
Bug 461975 depends on bug 462799, which changed state.

Bug 462799 Summary: EXR plugin exports grayscale images as RGB in the green 
channel only
https://bugs.kde.org/show_bug.cgi?id=462799

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 462925] TIFF: Inconsistent enabling of Save transparency channel and Photoshop boxes

2022-12-11 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=462925

amyspark  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|REPORTED|ASSIGNED
   Assignee|krita-bugs-n...@kde.org |a...@amyspark.me

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 461975] Broken EXR and TIFF when exporting from some color spaces

2022-12-11 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=461975

amyspark  changed:

   What|Removed |Added

 Depends on||462925


Referenced Bugs:

https://bugs.kde.org/show_bug.cgi?id=462925
[Bug 462925] TIFF: Inconsistent enabling of Save transparency channel and
Photoshop boxes
-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 462925] New: TIFF: Inconsistent enabling of Save transparency channel and Photoshop boxes

2022-12-11 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=462925

Bug ID: 462925
   Summary: TIFF: Inconsistent enabling of Save transparency
channel and Photoshop boxes
Classification: Applications
   Product: krita
   Version: 5.1.3
  Platform: Compiled Sources
OS: Microsoft Windows
Status: REPORTED
  Severity: normal
  Priority: NOR
 Component: File formats
  Assignee: krita-bugs-n...@kde.org
  Reporter: a...@amyspark.me
Blocks: 461975
  Target Milestone: ---

SUMMARY
***
NOTE: If you are reporting a crash, please try to attach a backtrace with debug
symbols.
See
https://community.kde.org/Guidelines_and_HOWTOs/Debugging/How_to_create_useful_crash_reports
***

Issues found in the TIFF export dialog as part of bug 461975:

- The existing logic disables alpha exporting for CMYK while LibTiff can
perfectly handle it. The only banned color space is YCbCr, which is already
safe asserted + worked around in the exporter itself.
- The "Flatten" checkbox improperly disables/enables the Alpha checkbox for
reasons unknown.
- The LibTiff configure check for PSD export is overridden by the Flatten
checkbox state.

STEPS TO REPRODUCE
1. 
2. 
3. 

OBSERVED RESULT


EXPECTED RESULT


SOFTWARE/OS VERSIONS
Windows: 10 21H2
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Commit 938ccf75c3894052c2ef9f54dc17254a2f1db0cb


Referenced Bugs:

https://bugs.kde.org/show_bug.cgi?id=461975
[Bug 461975] Broken EXR and TIFF when exporting from some color spaces
-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 461975] Broken EXR and TIFF when exporting from some color spaces

2022-12-10 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=461975

--- Comment #8 from amyspark  ---
(In reply to amyspark from comment #2)
> [BUG] I was able to consistently reproduce the latter error with your files,
> but only when not flattening the files. Something's failing inside LibTiff
> and not in our code. I'll try and debug it on my end.

We recently changed the code so that all file accesses went through Qt, in
order to support Android's content URLs. We had not noticed that LibTiff
actually requires simultaneously read and write mode to save multi-page TIFFs,
so we set it as write-only.

I'll clean up the code while at it, as it'll help be more maintainable
long-term.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 462417] Krita Version 5.1.1 & 5.1.3 not reading in a psd file well and Krita version 4.4.5 reads it in fine

2022-12-09 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=462417

amyspark  changed:

   What|Removed |Added

 Ever confirmed|0   |1
   Assignee|krita-bugs-n...@kde.org |a...@amyspark.me
 Status|NEEDSINFO   |ASSIGNED
 Resolution|WAITINGFORINFO  |---
 CC||a...@amyspark.me

--- Comment #4 from amyspark  ---
Taking it, let's see what I can find.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 461975] Broken EXR and TIFF when exporting from some color spaces

2022-12-09 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=461975

--- Comment #7 from amyspark  ---
> This has to be a bug and might have caused either the issue itself or some 
> confusion in my testing. I don't know if it's always like this or if it 
> happens on some specific case.

Yes, that's a bug I found first hand when trying your files here. I'll try and
commit the first set of patches (this issue and the EXR grayscale
import/export) today so you can try with the nightlies of tonight.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 462006] Crash when creating new image from selected region (clipboard)

2022-12-08 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=462006

--- Comment #2 from amyspark  ---
Halla, this is the ever elusive "clipboard is being cleared mid document
creation" bug.

The backtrace shows the reporter is in a Catch-22 position: it's claiming that
they've initiated a paste from clipboard, but the clipboard is empty by the
time we access it. The safe assert that I added back then should have detected
and ignored the situation, but it's not, and that's why I added the hard
assertion that this bug hits on.

@sander.smid: are you closing the original document between copying and
pasting? Do you have any other application active when the issue occurs?

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 462799] EXR plugin exports grayscale images as RGB in the green channel only

2022-12-08 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=462799

amyspark  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|REPORTED|ASSIGNED

--- Comment #1 from amyspark  ---
Assigning to myself.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 288725] support single-channel exr files (was: Some .exr files don't open correctly)

2022-12-08 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=288725

amyspark  changed:

   What|Removed |Added

 Depends on||462799


Referenced Bugs:

https://bugs.kde.org/show_bug.cgi?id=462799
[Bug 462799] EXR plugin exports grayscale images as RGB in the green channel
only
-- 
You are receiving this mail because:
You are watching all bug changes.

<    1   2   3   4   5   6   7   8   9   10   >