[frameworks-kxmlgui] [Bug 414904] [KShortcutsEditorDelegate] ">" arrows are blurry on HiDPI screen
https://bugs.kde.org/show_bug.cgi?id=414904 --- Comment #9 from snx --- Git commit 1c15548132621f0a543572338402ff302c621ae1 by snooxx . Committed on 17/03/2022 at 01:36. Pushed by meven into branch 'master'. KExtendableItemDelegate: Fix HiDPI positioning of indicator arrows After fixing pixelated indicator arrows in `KShortcutsEditorDelegate` (i.e. a subclass, see frameworks/kxmlgui!104) used in the "Configure Keyboard Shortcuts" dialog, they were not drawn centered anymore, e.g. slightly moved upwards. The same problem can be observed in the download list of KGet. This is because the increased size of the pixmap is not accounted for. By transforming the pixmap size to device independent dimensions again, as used in the positioning calculations, the arrows will finally be shown correctly. Note that running `KItemViews` in conjunction with a version of `KXmlGUI` not including the fix will still work fine, since the `devicePixelRatio` will only ever be set to `1` in that case. Test Plan: - Launch `QT_SCALE_FACTOR=1.7 ./bin/kxmlguiwindowtest` (from KXmlGui, including the fix mentioned above). - Open "Configure Keyboard Shortcuts" dialog. - Arrows in "Shortcut" column positioned correctly, for both their expanded and collapsed states. - Test with `-style Fusion` and other scaling factors, too. - `QT_SCALE_FACTOR=1.7 kget`, start download, observe indicator arrow in download list. M +10 -8src/kextendableitemdelegate.cpp https://invent.kde.org/frameworks/kitemviews/commit/1c15548132621f0a543572338402ff302c621ae1 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kxmlgui] [Bug 414904] [KShortcutsEditorDelegate] ">" arrows are blurry on HiDPI screen
https://bugs.kde.org/show_bug.cgi?id=414904 snx changed: What|Removed |Added Resolution|--- |FIXED Status|ASSIGNED|RESOLVED Latest Commit||https://invent.kde.org/fram ||eworks/kxmlgui/commit/a8207 ||6a6c353509ca404157237f61c6a ||28b37d3e --- Comment #8 from snx --- Git commit a82076a6c353509ca404157237f61c6a28b37d3e by snooxx . Committed on 16/03/2022 at 20:11. Pushed by ahmadsamir into branch 'master'. KShortcutsEditorDelegate: Fix HiDPI rendering of indicator arrows Even with HiDPI rendering enabled in applications, the standard "Configure Keyboard Shortcuts" dialog would still show pixelated indicator arrows in the "Shortcut" and "Alternate" columns. This is because the respective pixmap is only scaled up, but not rendered appropriately sized from the beginning. Setting the pixmap's `devicePixelRatio` and increasing its size fixes the issue. `option.rect` is in device independent pixels, and therefore should be kept as is. Note: In order for the arrows to still get drawn in the right place, additional fixes in `KExtendableItemDelegate` (i.e. the base class) are necessary, see frameworks/kitemviews!10. Test Plan: - Launch `QT_SCALE_FACTOR=1.7 ./bin/kxmlguiwindowtest`. - Open "Configure Keyboard Shortcuts" dialog. - Arrows in "Shortcut" column should not be pixelated anymore, for both their expanded and collapsed states. - Test with `-style Fusion` and other scaling factors, too. M +7-2src/kshortcutseditordelegate.cpp https://invent.kde.org/frameworks/kxmlgui/commit/a82076a6c353509ca404157237f61c6a28b37d3e -- You are receiving this mail because: You are watching all bug changes.
[kmag] [Bug 108068] kmag unusable for disabled people because KMag window covers a part of the screen that cannot be magnified
https://bugs.kde.org/show_bug.cgi?id=108068 snx changed: What|Removed |Added CC||s...@mailbox.org Ever confirmed|0 |1 Status|REPORTED|CONFIRMED --- Comment #7 from snx --- > KMag needs to be in an area where no window can be beneath it, > for example in a bar at the top or any other screen edge. Exactly this idea has already been implemented in the KDE3-based KMag (see https://invent.kde.org/accessibility/kmag/-/commit/1884b51a07f4a7a4d28bb325e4664e0bdc8802b6). That old version is quite easy to get running these days to test how it works (it needs more CPU than a Qt5-based KMag, though), let me know if you need some pointers to get started. The Qt4 port was branched off earlier than that commit and unfortunately was never forward-ported, which is why the Qt5-based KMag does not include it. Still, the code it out there and "only" needs porting. (Incidentally, the recursion issue mentioned above has also been fixed two times: Once in the Qt3 branch, and also in the Qt4 branch in a seemingly independent effort.) -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 450813] "Dolphin" crashes when dragging a file to the top of the Places-Panel
https://bugs.kde.org/show_bug.cgi?id=450813 snx changed: What|Removed |Added Status|ASSIGNED|RESOLVED Latest Commit||https://invent.kde.org/fram ||eworks/kio/commit/386629579 ||4d9201c4b4269e0cd5006ed01d6 ||b8af Resolution|--- |FIXED --- Comment #4 from snx --- Git commit 3866295794d9201c4b4269e0cd5006ed01d6b8af by snooxx . Committed on 02/03/2022 at 17:21. Pushed by broulik into branch 'master'. KFilePlacesView: Fix crash when dragging over topmost section header b5de820a78 fixed incorrect highlighting of the section header label during drag operations over the first place of a section in clients setting `m_dropOnPlace`, e.g. Dolphin. This was effective for all except the topmost section header, where it would cause a crash (independent of the state of `m_dropOnPlace`). In `KFilePlacesViewDelegate::previousVisibleIndex` access to `model` fails, because the `index` determined via `indexAt` of `m_dropRect` in `KFilePlacesView::paintEvent` is invalid when dragging towards the topmost section header label. This is because `m_dropRect.topLeft()` can extend above the entry's `visualRect`, i.e. it covers the places items below as well as above the separator, of which the latter does not exist for the first entry. By remembering the index belonging to `m_dropRect` in `m_dropIndex` instead of reconstructing it, we can guarantee it to be valid. Related: bug 450966 Test Plan: No more crash when dragging places or folders over topmost section header label in places view in `kdialog --getsaveurl` as well as `dolphin`. Other functionality related to dragging places around (including existing bugs) is unaffected and the behavior of the original fix remains. M +7-5src/filewidgets/kfileplacesview.cpp https://invent.kde.org/frameworks/kio/commit/3866295794d9201c4b4269e0cd5006ed01d6b8af -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 450966] Dolphin crashes when dragging image from Gwenview over the details view
https://bugs.kde.org/show_bug.cgi?id=450966 --- Comment #5 from snx --- Git commit fc95fed526f59b70ea93c5e81680ffd0dec05c61 by snooxx . Committed on 03/03/2022 at 09:06. Pushed by broulik into branch 'master'. KFilePlacesView: Fix potential crash in `previousVisibleIndex` The previous commit fixed a crash in `KFilePlacesViewDelegate::previousVisibleIndex`, where access to `model` failed due to an invalid index. In addition to the previous commit already fixing the crash, unrelated potential crashes in the future can be avoided by checking for an invalid `index` in `previousVisibleIndex`. The existing logic of `indexIsSectionHeader` is kept intact, since now an invalid `index` will lead to comparing two empty strings, i.e. it will not be considered a section header as required by the rest of the code. This fix alone would already solve the crash without any side effects, still introducing `m_dropIndex` seemed less brittle. Related: bug 450813 Test Plan: Functionality related to dragging places around (including existing bugs) is unaffected. M +1-1src/filewidgets/kfileplacesview.cpp https://invent.kde.org/frameworks/kio/commit/fc95fed526f59b70ea93c5e81680ffd0dec05c61 -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 450813] "Dolphin" crashes when dragging a file to the top of the Places-Panel
https://bugs.kde.org/show_bug.cgi?id=450813 --- Comment #3 from snx --- Git commit fc95fed526f59b70ea93c5e81680ffd0dec05c61 by snooxx . Committed on 03/03/2022 at 09:06. Pushed by broulik into branch 'master'. KFilePlacesView: Fix potential crash in `previousVisibleIndex` The previous commit fixed a crash in `KFilePlacesViewDelegate::previousVisibleIndex`, where access to `model` failed due to an invalid index. In addition to the previous commit already fixing the crash, unrelated potential crashes in the future can be avoided by checking for an invalid `index` in `previousVisibleIndex`. The existing logic of `indexIsSectionHeader` is kept intact, since now an invalid `index` will lead to comparing two empty strings, i.e. it will not be considered a section header as required by the rest of the code. This fix alone would already solve the crash without any side effects, still introducing `m_dropIndex` seemed less brittle. Related: bug 450966 Test Plan: Functionality related to dragging places around (including existing bugs) is unaffected. M +1-1src/filewidgets/kfileplacesview.cpp https://invent.kde.org/frameworks/kio/commit/fc95fed526f59b70ea93c5e81680ffd0dec05c61 -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 450966] Dolphin crashes when dragging image from Gwenview over the details view
https://bugs.kde.org/show_bug.cgi?id=450966 snx changed: What|Removed |Added Latest Commit||https://invent.kde.org/fram ||eworks/kio/commit/386629579 ||4d9201c4b4269e0cd5006ed01d6 ||b8af Resolution|--- |FIXED Status|ASSIGNED|RESOLVED --- Comment #4 from snx --- Git commit 3866295794d9201c4b4269e0cd5006ed01d6b8af by snooxx . Committed on 02/03/2022 at 17:21. Pushed by broulik into branch 'master'. KFilePlacesView: Fix crash when dragging over topmost section header b5de820a78 fixed incorrect highlighting of the section header label during drag operations over the first place of a section in clients setting `m_dropOnPlace`, e.g. Dolphin. This was effective for all except the topmost section header, where it would cause a crash (independent of the state of `m_dropOnPlace`). In `KFilePlacesViewDelegate::previousVisibleIndex` access to `model` fails, because the `index` determined via `indexAt` of `m_dropRect` in `KFilePlacesView::paintEvent` is invalid when dragging towards the topmost section header label. This is because `m_dropRect.topLeft()` can extend above the entry's `visualRect`, i.e. it covers the places items below as well as above the separator, of which the latter does not exist for the first entry. By remembering the index belonging to `m_dropRect` in `m_dropIndex` instead of reconstructing it, we can guarantee it to be valid. Related: bug 450813 Test Plan: No more crash when dragging places or folders over topmost section header label in places view in `kdialog --getsaveurl` as well as `dolphin`. Other functionality related to dragging places around (including existing bugs) is unaffected and the behavior of the original fix remains. M +7-5src/filewidgets/kfileplacesview.cpp https://invent.kde.org/frameworks/kio/commit/3866295794d9201c4b4269e0cd5006ed01d6b8af -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 449236] Scrollbar do not takes the colors from the profile color scheme anymore when using an Application Theme different from Breeze i.e.(Oxygen, Fusion).
https://bugs.kde.org/show_bug.cgi?id=449236 snx changed: What|Removed |Added CC||s...@mailbox.org -- You are receiving this mail because: You are watching all bug changes.
